[INFO] fetching crate rsrl_domains 0.2.0... [INFO] linting rsrl_domains-0.2.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate rsrl_domains 0.2.0 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate rsrl_domains 0.2.0 [INFO] finished tweaking crates.io crate rsrl_domains 0.2.0 [INFO] tweaked toml for crates.io crate rsrl_domains 0.2.0 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate rsrl_domains 0.2.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 32 packages to latest compatible versions [INFO] [stderr] Adding cpython v0.3.0 (available: v0.7.2) [INFO] [stderr] Adding ndarray v0.12.1 (available: v0.17.2) [INFO] [stderr] Adding rand v0.7.3 (available: v0.10.0) [INFO] [stderr] Adding spaces v5.0.0 (available: v6.0.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded matrixmultiply v0.1.15 [INFO] [stderr] Downloaded rawpointer v0.1.0 [INFO] [stderr] Downloaded cpython v0.3.0 [INFO] [stderr] Downloaded python3-sys v0.3.0 [INFO] [stderr] Downloaded ndarray v0.12.1 [INFO] [stderr] Downloaded spaces v5.0.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3a4a946f72b19868b67288ad555d09e489bf621b26e948d5a6591cc4714bac56 [INFO] running `Command { std: "docker" "start" "-a" "3a4a946f72b19868b67288ad555d09e489bf621b26e948d5a6591cc4714bac56", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3a4a946f72b19868b67288ad555d09e489bf621b26e948d5a6591cc4714bac56", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3a4a946f72b19868b67288ad555d09e489bf621b26e948d5a6591cc4714bac56", kill_on_drop: false }` [INFO] [stdout] 3a4a946f72b19868b67288ad555d09e489bf621b26e948d5a6591cc4714bac56 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d3438ccdc987516c1f5f819747022c15eb5bdd5e164c474d5469761ac2bbbd50 [INFO] running `Command { std: "docker" "start" "-a" "d3438ccdc987516c1f5f819747022c15eb5bdd5e164c474d5469761ac2bbbd50", kill_on_drop: false }` [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Compiling matrixmultiply v0.1.15 [INFO] [stderr] Compiling ndarray v0.12.1 [INFO] [stderr] Checking rawpointer v0.1.0 [INFO] [stderr] Checking itertools v0.7.11 [INFO] [stderr] Checking spaces v5.0.0 [INFO] [stderr] Checking rsrl_domains v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:177:13 [INFO] [stdout] | [INFO] [stdout] 177 | action: action, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `action` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:177:13 [INFO] [stdout] | [INFO] [stdout] 177 | action: action, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `action` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/lib.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 105 | / match self { [INFO] [stdout] 106 | | Observation::Full(_) => true, [INFO] [stdout] 107 | | _ => false, [INFO] [stdout] 108 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 105 - match self { [INFO] [stdout] 106 - Observation::Full(_) => true, [INFO] [stdout] 107 - _ => false, [INFO] [stdout] 108 - } [INFO] [stdout] 105 + matches!(self, Observation::Full(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/lib.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | / match self { [INFO] [stdout] 114 | | Observation::Partial(_) => true, [INFO] [stdout] 115 | | _ => false, [INFO] [stdout] 116 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 113 - match self { [INFO] [stdout] 114 - Observation::Partial(_) => true, [INFO] [stdout] 115 - _ => false, [INFO] [stdout] 116 - } [INFO] [stdout] 113 + matches!(self, Observation::Partial(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/lib.rs:121:9 [INFO] [stdout] | [INFO] [stdout] 121 | / match self { [INFO] [stdout] 122 | | Observation::Terminal(_) => true, [INFO] [stdout] 123 | | _ => false, [INFO] [stdout] 124 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 121 - match self { [INFO] [stdout] 122 - Observation::Terminal(_) => true, [INFO] [stdout] 123 - _ => false, [INFO] [stdout] 124 - } [INFO] [stdout] 121 + matches!(self, Observation::Terminal(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/lib.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | impl Into> for Transition { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 197 | impl_into!(Transition => Transition); [INFO] [stdout] | -------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: replace the `Into` implementation with `From>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] = note: this warning originates in the macro `impl_into` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/lib.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | impl Into> for Transition { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 198 | impl_into!(Transition => Transition); [INFO] [stdout] | --------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: replace the `Into` implementation with `From>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: this warning originates in the macro `impl_into` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/lib.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | impl Into> for Transition { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 199 | impl_into!(Transition => Transition); [INFO] [stdout] | --------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: replace the `Into` implementation with `From>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: this warning originates in the macro `impl_into` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/lib.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | impl Into> for Transition { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 200 | impl_into!(Transition => Transition); [INFO] [stdout] | --------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: replace the `Into` implementation with `From>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: this warning originates in the macro `impl_into` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/lib.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | impl Into> for Transition { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 201 | impl_into!(Transition => Transition); [INFO] [stdout] | ----------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: replace the `Into` implementation with `From>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: this warning originates in the macro `impl_into` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/lib.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | impl Into> for Transition { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 202 | impl_into!(Transition => Transition); [INFO] [stdout] | -------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: replace the `Into` implementation with `From>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: this warning originates in the macro `impl_into` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/lib.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | impl Into> for Transition { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 203 | impl_into!(Transition => Transition); [INFO] [stdout] | --------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: replace the `Into` implementation with `From>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: this warning originates in the macro `impl_into` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/lib.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | impl Into> for Transition { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 204 | impl_into!(Transition => Transition); [INFO] [stdout] | --------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: replace the `Into` implementation with `From>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: this warning originates in the macro `impl_into` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/lib.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | impl Into> for Transition { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 205 | impl_into!(Transition => Transition); [INFO] [stdout] | --------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: replace the `Into` implementation with `From>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: this warning originates in the macro `impl_into` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/lib.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | impl Into> for Transition { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 206 | impl_into!(Transition => Transition); [INFO] [stdout] | ----------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: replace the `Into` implementation with `From>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: this warning originates in the macro `impl_into` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/lib.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | impl Into> for Transition { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 207 | impl_into!(Transition => Transition); [INFO] [stdout] | --------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: replace the `Into` implementation with `From>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: this warning originates in the macro `impl_into` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/lib.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | impl Into> for Transition { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 208 | impl_into!(Transition => Transition); [INFO] [stdout] | --------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: replace the `Into` implementation with `From>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: this warning originates in the macro `impl_into` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Observation<&S>` which implements the `Copy` trait [INFO] [stdout] --> src/lib.rs:325:23 [INFO] [stdout] | [INFO] [stdout] 325 | from: t.from.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `t.from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Observation<&S>` which implements the `Copy` trait [INFO] [stdout] --> src/lib.rs:328:21 [INFO] [stdout] | [INFO] [stdout] 328 | to: t.to.clone(), [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `t.to` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `r` [INFO] [stdout] --> src/cart_pole.rs:147:18 [INFO] [stdout] | [INFO] [stdout] 147 | let (ns, r) = m.step(&0); [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: you might have meant to pattern match on the similarly named constant `G` [INFO] [stdout] | [INFO] [stdout] 147 - let (ns, r) = m.step(&0); [INFO] [stdout] 147 + let (ns, consts::G) = m.step(&0); [INFO] [stdout] | [INFO] [stdout] help: if this is intentional, prefix it with an underscore [INFO] [stdout] | [INFO] [stdout] 147 | let (ns, _r) = m.step(&0); [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `r` [INFO] [stdout] --> src/cart_pole.rs:155:18 [INFO] [stdout] | [INFO] [stdout] 155 | let (ns, r) = m.step(&0); [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: you might have meant to pattern match on the similarly named constant `G` [INFO] [stdout] | [INFO] [stdout] 155 - let (ns, r) = m.step(&0); [INFO] [stdout] 155 + let (ns, consts::G) = m.step(&0); [INFO] [stdout] | [INFO] [stdout] help: if this is intentional, prefix it with an underscore [INFO] [stdout] | [INFO] [stdout] 155 | let (ns, _r) = m.step(&0); [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `r` [INFO] [stdout] --> src/cart_pole.rs:168:18 [INFO] [stdout] | [INFO] [stdout] 168 | let (ns, r) = m.step(&1); [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: you might have meant to pattern match on the similarly named constant `G` [INFO] [stdout] | [INFO] [stdout] 168 - let (ns, r) = m.step(&1); [INFO] [stdout] 168 + let (ns, consts::G) = m.step(&1); [INFO] [stdout] | [INFO] [stdout] help: if this is intentional, prefix it with an underscore [INFO] [stdout] | [INFO] [stdout] 168 | let (ns, _r) = m.step(&1); [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `r` [INFO] [stdout] --> src/cart_pole.rs:176:18 [INFO] [stdout] | [INFO] [stdout] 176 | let (ns, r) = m.step(&1); [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: you might have meant to pattern match on the similarly named constant `G` [INFO] [stdout] | [INFO] [stdout] 176 - let (ns, r) = m.step(&1); [INFO] [stdout] 176 + let (ns, consts::G) = m.step(&1); [INFO] [stdout] | [INFO] [stdout] help: if this is intentional, prefix it with an underscore [INFO] [stdout] | [INFO] [stdout] 176 | let (ns, _r) = m.step(&1); [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `flat_map` with an identity function [INFO] [stdout] --> src/grid_world.rs:58:35 [INFO] [stdout] | [INFO] [stdout] 58 | let mvals = m.into_iter().flat_map(|v| v).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `flatten()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#flat_map_identity [INFO] [stdout] = note: `#[warn(clippy::flat_map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/mountain_car/discrete.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | /// replacing eligibility traces. Recent Advances in Reinforcement Learning, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 47 | /// replacing eligibility traces. Recent Advances in Reinforcement Learning, [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/mountain_car/discrete.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | /// 123-158. - Sutton, R. S., & Barto, A. G. (1998). Reinforcement learning: An [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 48 | /// 123-158. - Sutton, R. S., & Barto, A. G. (1998). Reinforcement learning: An [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/mountain_car/discrete.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | /// introduction (Vol. 1, No. 1). Cambridge: MIT press. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 49 | /// introduction (Vol. 1, No. 1). Cambridge: MIT press. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this multiplication by -1 can be written more succinctly [INFO] [stdout] --> src/cart_pole.rs:26:32 [INFO] [stdout] | [INFO] [stdout] 26 | const ALL_ACTIONS: [f64; 2] = [-1.0 * CART_FORCE, 1.0 * CART_FORCE]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using: `-CART_FORCE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stdout] = note: `#[warn(clippy::neg_multiply)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `THETA` contains a capitalized acronym [INFO] [stdout] --> src/cart_pole.rs:29:22 [INFO] [stdout] | [INFO] [stdout] 29 | X => 0, DX => 1, THETA => 2, DTHETA => 3 [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Theta` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DTHETA` contains a capitalized acronym [INFO] [stdout] --> src/cart_pole.rs:29:34 [INFO] [stdout] | [INFO] [stdout] 29 | X => 0, DX => 1, THETA => 2, DTHETA => 3 [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Dtheta` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/lib.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 105 | / match self { [INFO] [stdout] 106 | | Observation::Full(_) => true, [INFO] [stdout] 107 | | _ => false, [INFO] [stdout] 108 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 105 - match self { [INFO] [stdout] 106 - Observation::Full(_) => true, [INFO] [stdout] 107 - _ => false, [INFO] [stdout] 108 - } [INFO] [stdout] 105 + matches!(self, Observation::Full(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/lib.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | / match self { [INFO] [stdout] 114 | | Observation::Partial(_) => true, [INFO] [stdout] 115 | | _ => false, [INFO] [stdout] 116 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 113 - match self { [INFO] [stdout] 114 - Observation::Partial(_) => true, [INFO] [stdout] 115 - _ => false, [INFO] [stdout] 116 - } [INFO] [stdout] 113 + matches!(self, Observation::Partial(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/lib.rs:121:9 [INFO] [stdout] | [INFO] [stdout] 121 | / match self { [INFO] [stdout] 122 | | Observation::Terminal(_) => true, [INFO] [stdout] 123 | | _ => false, [INFO] [stdout] 124 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 121 - match self { [INFO] [stdout] 122 - Observation::Terminal(_) => true, [INFO] [stdout] 123 - _ => false, [INFO] [stdout] 124 - } [INFO] [stdout] 121 + matches!(self, Observation::Terminal(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/cart_pole.rs:42:31 [INFO] [stdout] | [INFO] [stdout] 42 | let ns = runge_kutta4(&fx, 0.0, self.0.to_vec(), DT); [INFO] [stdout] | ^^^ help: change this to: `fx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/lib.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | impl Into> for Transition { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 197 | impl_into!(Transition => Transition); [INFO] [stdout] | -------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: replace the `Into` implementation with `From>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] = note: this warning originates in the macro `impl_into` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/lib.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | impl Into> for Transition { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 198 | impl_into!(Transition => Transition); [INFO] [stdout] | --------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: replace the `Into` implementation with `From>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: this warning originates in the macro `impl_into` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/lib.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | impl Into> for Transition { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 199 | impl_into!(Transition => Transition); [INFO] [stdout] | --------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: replace the `Into` implementation with `From>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: this warning originates in the macro `impl_into` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/lib.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | impl Into> for Transition { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 200 | impl_into!(Transition => Transition); [INFO] [stdout] | --------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: replace the `Into` implementation with `From>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: this warning originates in the macro `impl_into` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/lib.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | impl Into> for Transition { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 201 | impl_into!(Transition => Transition); [INFO] [stdout] | ----------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: replace the `Into` implementation with `From>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: this warning originates in the macro `impl_into` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/lib.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | impl Into> for Transition { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 202 | impl_into!(Transition => Transition); [INFO] [stdout] | -------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: replace the `Into` implementation with `From>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: this warning originates in the macro `impl_into` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/lib.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | impl Into> for Transition { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 203 | impl_into!(Transition => Transition); [INFO] [stdout] | --------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: replace the `Into` implementation with `From>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: this warning originates in the macro `impl_into` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/lib.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | impl Into> for Transition { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 204 | impl_into!(Transition => Transition); [INFO] [stdout] | --------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: replace the `Into` implementation with `From>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: this warning originates in the macro `impl_into` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/lib.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | impl Into> for Transition { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 205 | impl_into!(Transition => Transition); [INFO] [stdout] | --------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: replace the `Into` implementation with `From>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: this warning originates in the macro `impl_into` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/lib.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | impl Into> for Transition { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 206 | impl_into!(Transition => Transition); [INFO] [stdout] | ----------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: replace the `Into` implementation with `From>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: this warning originates in the macro `impl_into` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/lib.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | impl Into> for Transition { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 207 | impl_into!(Transition => Transition); [INFO] [stdout] | --------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: replace the `Into` implementation with `From>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: this warning originates in the macro `impl_into` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/lib.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | impl Into> for Transition { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 208 | impl_into!(Transition => Transition); [INFO] [stdout] | --------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: replace the `Into` implementation with `From>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: this warning originates in the macro `impl_into` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/acrobot.rs:62:31 [INFO] [stdout] | [INFO] [stdout] 62 | let ns = runge_kutta4(&fx, 0.0, self.0.to_vec(), DT); [INFO] [stdout] | ^^^ help: change this to: `fx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this multiplication by -1 can be written more succinctly [INFO] [stdout] --> src/acrobot.rs:97:20 [INFO] [stdout] | [INFO] [stdout] 97 | let phi1 = -1.0 * L1 * LC2 * dtheta2 * dtheta2 * sin_t2 [INFO] [stdout] | ^^^^^^^^^ help: consider using: `-L1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Observation<&S>` which implements the `Copy` trait [INFO] [stdout] --> src/lib.rs:325:23 [INFO] [stdout] | [INFO] [stdout] 325 | from: t.from.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `t.from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Observation<&S>` which implements the `Copy` trait [INFO] [stdout] --> src/lib.rs:328:21 [INFO] [stdout] | [INFO] [stdout] 328 | to: t.to.clone(), [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `t.to` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/hiv.rs:60:35 [INFO] [stdout] | [INFO] [stdout] 60 | let mut ns = runge_kutta4(&fx, 0.0, self.state.to_vec(), DT_STEP); [INFO] [stdout] | ^^^ help: change this to: `fx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/hiv.rs:62:31 [INFO] [stdout] | [INFO] [stdout] 62 | ns = runge_kutta4(&fx, 0.0, ns, DT_STEP); [INFO] [stdout] | ^^^ help: change this to: `fx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `flat_map` with an identity function [INFO] [stdout] --> src/grid_world.rs:58:35 [INFO] [stdout] | [INFO] [stdout] 58 | let mvals = m.into_iter().flat_map(|v| v).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `flatten()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#flat_map_identity [INFO] [stdout] = note: `#[warn(clippy::flat_map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/roulette.rs:187:20 [INFO] [stdout] | [INFO] [stdout] 187 | 126 if landing == 23 || landing == 24 || landing == 27 || landing == 27 => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 187 - 126 if landing == 23 || landing == 24 || landing == 27 || landing == 27 => { [INFO] [stdout] 187 + 126 if !(landing != 23 && landing != 24 && landing != 27) => { [INFO] [stdout] | [INFO] [stdout] 187 - 126 if landing == 23 || landing == 24 || landing == 27 || landing == 27 => { [INFO] [stdout] 187 + 126 if landing == 23 || landing == 24 || landing == 27 => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/grid_world.rs:181:48 [INFO] [stdout] | [INFO] [stdout] 181 | let gw_str = GridWorld::::from_str(&l); [INFO] [stdout] | ^^ help: change this to: `l` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/mountain_car/discrete.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | /// replacing eligibility traces. Recent Advances in Reinforcement Learning, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 47 | /// replacing eligibility traces. Recent Advances in Reinforcement Learning, [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/mountain_car/discrete.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | /// 123-158. - Sutton, R. S., & Barto, A. G. (1998). Reinforcement learning: An [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 48 | /// 123-158. - Sutton, R. S., & Barto, A. G. (1998). Reinforcement learning: An [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/mountain_car/discrete.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | /// introduction (Vol. 1, No. 1). Cambridge: MIT press. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 49 | /// introduction (Vol. 1, No. 1). Cambridge: MIT press. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:119:19 [INFO] [stdout] | [INFO] [stdout] 119 | 99 if landing >= 1 && landing <= 3 => Some(11.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=3).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:120:20 [INFO] [stdout] | [INFO] [stdout] 120 | 100 if landing >= 4 && landing <= 6 => Some(11.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(4..=6).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:121:20 [INFO] [stdout] | [INFO] [stdout] 121 | 101 if landing >= 7 && landing <= 9 => Some(11.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(7..=9).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:122:20 [INFO] [stdout] | [INFO] [stdout] 122 | 102 if landing >= 10 && landing <= 12 => Some(11.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(10..=12).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:123:20 [INFO] [stdout] | [INFO] [stdout] 123 | 103 if landing >= 13 && landing <= 15 => Some(11.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(13..=15).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:124:20 [INFO] [stdout] | [INFO] [stdout] 124 | 104 if landing >= 16 && landing <= 18 => Some(11.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(16..=18).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:125:20 [INFO] [stdout] | [INFO] [stdout] 125 | 105 if landing >= 19 && landing <= 21 => Some(11.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(19..=21).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:126:20 [INFO] [stdout] | [INFO] [stdout] 126 | 106 if landing >= 22 && landing <= 24 => Some(11.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(22..=24).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:127:20 [INFO] [stdout] | [INFO] [stdout] 127 | 107 if landing >= 25 && landing <= 27 => Some(11.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(25..=27).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:128:20 [INFO] [stdout] | [INFO] [stdout] 128 | 108 if landing >= 28 && landing <= 30 => Some(11.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(28..=30).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:129:20 [INFO] [stdout] | [INFO] [stdout] 129 | 109 if landing >= 31 && landing <= 33 => Some(11.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(31..=33).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:130:20 [INFO] [stdout] | [INFO] [stdout] 130 | 110 if landing >= 34 && landing <= 36 => Some(11.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(34..=36).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this multiplication by -1 can be written more succinctly [INFO] [stdout] --> src/cart_pole.rs:26:32 [INFO] [stdout] | [INFO] [stdout] 26 | const ALL_ACTIONS: [f64; 2] = [-1.0 * CART_FORCE, 1.0 * CART_FORCE]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using: `-CART_FORCE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stdout] = note: `#[warn(clippy::neg_multiply)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `THETA` contains a capitalized acronym [INFO] [stdout] --> src/cart_pole.rs:29:22 [INFO] [stdout] | [INFO] [stdout] 29 | X => 0, DX => 1, THETA => 2, DTHETA => 3 [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Theta` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DTHETA` contains a capitalized acronym [INFO] [stdout] --> src/cart_pole.rs:29:34 [INFO] [stdout] | [INFO] [stdout] 29 | X => 0, DX => 1, THETA => 2, DTHETA => 3 [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Dtheta` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/cart_pole.rs:42:31 [INFO] [stdout] | [INFO] [stdout] 42 | let ns = runge_kutta4(&fx, 0.0, self.0.to_vec(), DT); [INFO] [stdout] | ^^^ help: change this to: `fx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:213:20 [INFO] [stdout] | [INFO] [stdout] 213 | 133 if landing >= 1 && landing <= 6 => Some(5.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=6).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:214:20 [INFO] [stdout] | [INFO] [stdout] 214 | 134 if landing >= 4 && landing <= 9 => Some(5.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(4..=9).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:215:20 [INFO] [stdout] | [INFO] [stdout] 215 | 135 if landing >= 7 && landing <= 12 => Some(5.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(7..=12).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:216:20 [INFO] [stdout] | [INFO] [stdout] 216 | 136 if landing >= 10 && landing <= 15 => Some(5.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(10..=15).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:217:20 [INFO] [stdout] | [INFO] [stdout] 217 | 137 if landing >= 13 && landing <= 18 => Some(5.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(13..=18).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:218:20 [INFO] [stdout] | [INFO] [stdout] 218 | 138 if landing >= 16 && landing <= 21 => Some(5.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(16..=21).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:219:20 [INFO] [stdout] | [INFO] [stdout] 219 | 139 if landing >= 19 && landing <= 24 => Some(5.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(19..=24).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:220:20 [INFO] [stdout] | [INFO] [stdout] 220 | 140 if landing >= 22 && landing <= 27 => Some(5.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(22..=27).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:221:20 [INFO] [stdout] | [INFO] [stdout] 221 | 141 if landing >= 25 && landing <= 30 => Some(5.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(25..=30).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:222:20 [INFO] [stdout] | [INFO] [stdout] 222 | 142 if landing >= 28 && landing <= 33 => Some(5.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(28..=33).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:223:20 [INFO] [stdout] | [INFO] [stdout] 223 | 143 if landing >= 31 && landing <= 36 => Some(5.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(31..=36).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:231:20 [INFO] [stdout] | [INFO] [stdout] 231 | 147 if landing >= 1 && landing <= 12 => Some(2.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=12).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:232:20 [INFO] [stdout] | [INFO] [stdout] 232 | 148 if landing >= 13 && landing <= 24 => Some(2.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(13..=24).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:233:20 [INFO] [stdout] | [INFO] [stdout] 233 | 149 if landing >= 25 && landing <= 36 => Some(2.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(25..=36).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/cart_pole.rs:153:26 [INFO] [stdout] | [INFO] [stdout] 153 | assert!((ns[3] - 0.2951522145037250).abs() < 1e-7); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] = note: `#[warn(clippy::excessive_precision)]` on by default [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 153 - assert!((ns[3] - 0.2951522145037250).abs() < 1e-7); [INFO] [stdout] 153 + assert!((ns[3] - 0.295_152_214_503_725).abs() < 1e-7); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:268:20 [INFO] [stdout] | [INFO] [stdout] 268 | 154 if landing >= 1 && landing <= 18 => Some(self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=18).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:269:20 [INFO] [stdout] | [INFO] [stdout] 269 | 155 if landing >= 19 && landing <= 36 => Some(self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(19..=36).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:326:33 [INFO] [stdout] | [INFO] [stdout] 326 | action: t.action.clone(), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `A` does not implement `Clone`, so calling `clone` on `&A` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/cart_pole.rs:174:26 [INFO] [stdout] | [INFO] [stdout] 174 | assert!((ns[3] + 0.2951522145037250).abs() < 1e-7); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 174 - assert!((ns[3] + 0.2951522145037250).abs() < 1e-7); [INFO] [stdout] 174 + assert!((ns[3] + 0.295_152_214_503_725).abs() < 1e-7); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/acrobot.rs:62:31 [INFO] [stdout] | [INFO] [stdout] 62 | let ns = runge_kutta4(&fx, 0.0, self.0.to_vec(), DT); [INFO] [stdout] | ^^^ help: change this to: `fx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this multiplication by -1 can be written more succinctly [INFO] [stdout] --> src/acrobot.rs:97:20 [INFO] [stdout] | [INFO] [stdout] 97 | let phi1 = -1.0 * L1 * LC2 * dtheta2 * dtheta2 * sin_t2 [INFO] [stdout] | ^^^^^^^^^ help: consider using: `-L1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/hiv.rs:60:35 [INFO] [stdout] | [INFO] [stdout] 60 | let mut ns = runge_kutta4(&fx, 0.0, self.state.to_vec(), DT_STEP); [INFO] [stdout] | ^^^ help: change this to: `fx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/hiv.rs:62:31 [INFO] [stdout] | [INFO] [stdout] 62 | ns = runge_kutta4(&fx, 0.0, ns, DT_STEP); [INFO] [stdout] | ^^^ help: change this to: `fx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/roulette.rs:187:20 [INFO] [stdout] | [INFO] [stdout] 187 | 126 if landing == 23 || landing == 24 || landing == 27 || landing == 27 => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 187 - 126 if landing == 23 || landing == 24 || landing == 27 || landing == 27 => { [INFO] [stdout] 187 + 126 if !(landing != 23 && landing != 24 && landing != 27) => { [INFO] [stdout] | [INFO] [stdout] 187 - 126 if landing == 23 || landing == 24 || landing == 27 || landing == 27 => { [INFO] [stdout] 187 + 126 if landing == 23 || landing == 24 || landing == 27 => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:119:19 [INFO] [stdout] | [INFO] [stdout] 119 | 99 if landing >= 1 && landing <= 3 => Some(11.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=3).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:120:20 [INFO] [stdout] | [INFO] [stdout] 120 | 100 if landing >= 4 && landing <= 6 => Some(11.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(4..=6).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:121:20 [INFO] [stdout] | [INFO] [stdout] 121 | 101 if landing >= 7 && landing <= 9 => Some(11.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(7..=9).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:122:20 [INFO] [stdout] | [INFO] [stdout] 122 | 102 if landing >= 10 && landing <= 12 => Some(11.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(10..=12).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:123:20 [INFO] [stdout] | [INFO] [stdout] 123 | 103 if landing >= 13 && landing <= 15 => Some(11.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(13..=15).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:124:20 [INFO] [stdout] | [INFO] [stdout] 124 | 104 if landing >= 16 && landing <= 18 => Some(11.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(16..=18).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:125:20 [INFO] [stdout] | [INFO] [stdout] 125 | 105 if landing >= 19 && landing <= 21 => Some(11.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(19..=21).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:126:20 [INFO] [stdout] | [INFO] [stdout] 126 | 106 if landing >= 22 && landing <= 24 => Some(11.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(22..=24).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:127:20 [INFO] [stdout] | [INFO] [stdout] 127 | 107 if landing >= 25 && landing <= 27 => Some(11.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(25..=27).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:128:20 [INFO] [stdout] | [INFO] [stdout] 128 | 108 if landing >= 28 && landing <= 30 => Some(11.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(28..=30).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:129:20 [INFO] [stdout] | [INFO] [stdout] 129 | 109 if landing >= 31 && landing <= 33 => Some(11.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(31..=33).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:130:20 [INFO] [stdout] | [INFO] [stdout] 130 | 110 if landing >= 34 && landing <= 36 => Some(11.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(34..=36).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:213:20 [INFO] [stdout] | [INFO] [stdout] 213 | 133 if landing >= 1 && landing <= 6 => Some(5.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=6).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:214:20 [INFO] [stdout] | [INFO] [stdout] 214 | 134 if landing >= 4 && landing <= 9 => Some(5.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(4..=9).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:215:20 [INFO] [stdout] | [INFO] [stdout] 215 | 135 if landing >= 7 && landing <= 12 => Some(5.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(7..=12).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:216:20 [INFO] [stdout] | [INFO] [stdout] 216 | 136 if landing >= 10 && landing <= 15 => Some(5.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(10..=15).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:217:20 [INFO] [stdout] | [INFO] [stdout] 217 | 137 if landing >= 13 && landing <= 18 => Some(5.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(13..=18).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:218:20 [INFO] [stdout] | [INFO] [stdout] 218 | 138 if landing >= 16 && landing <= 21 => Some(5.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(16..=21).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:219:20 [INFO] [stdout] | [INFO] [stdout] 219 | 139 if landing >= 19 && landing <= 24 => Some(5.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(19..=24).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:220:20 [INFO] [stdout] | [INFO] [stdout] 220 | 140 if landing >= 22 && landing <= 27 => Some(5.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(22..=27).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:221:20 [INFO] [stdout] | [INFO] [stdout] 221 | 141 if landing >= 25 && landing <= 30 => Some(5.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(25..=30).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:222:20 [INFO] [stdout] | [INFO] [stdout] 222 | 142 if landing >= 28 && landing <= 33 => Some(5.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(28..=33).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:223:20 [INFO] [stdout] | [INFO] [stdout] 223 | 143 if landing >= 31 && landing <= 36 => Some(5.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(31..=36).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:231:20 [INFO] [stdout] | [INFO] [stdout] 231 | 147 if landing >= 1 && landing <= 12 => Some(2.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=12).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:232:20 [INFO] [stdout] | [INFO] [stdout] 232 | 148 if landing >= 13 && landing <= 24 => Some(2.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(13..=24).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:233:20 [INFO] [stdout] | [INFO] [stdout] 233 | 149 if landing >= 25 && landing <= 36 => Some(2.0 * self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(25..=36).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:268:20 [INFO] [stdout] | [INFO] [stdout] 268 | 154 if landing >= 1 && landing <= 18 => Some(self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=18).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/roulette.rs:269:20 [INFO] [stdout] | [INFO] [stdout] 269 | 155 if landing >= 19 && landing <= 36 => Some(self.bet_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(19..=36).contains(&landing)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:326:33 [INFO] [stdout] | [INFO] [stdout] 326 | action: t.action.clone(), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `A` does not implement `Clone`, so calling `clone` on `&A` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.57s [INFO] running `Command { std: "docker" "inspect" "d3438ccdc987516c1f5f819747022c15eb5bdd5e164c474d5469761ac2bbbd50", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d3438ccdc987516c1f5f819747022c15eb5bdd5e164c474d5469761ac2bbbd50", kill_on_drop: false }` [INFO] [stdout] d3438ccdc987516c1f5f819747022c15eb5bdd5e164c474d5469761ac2bbbd50