[INFO] fetching crate rskiller 0.2.1... [INFO] linting rskiller-0.2.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate rskiller 0.2.1 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate rskiller 0.2.1 [INFO] finished tweaking crates.io crate rskiller 0.2.1 [INFO] tweaked toml for crates.io crate rskiller 0.2.1 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate rskiller 0.2.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate rskiller 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded clap_complete v4.5.58 [INFO] [stderr] Downloaded anstyle-wincon v3.0.8 [INFO] [stderr] Downloaded cc v1.2.25 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8d5da2c0bfb5ece695c6df390009fbcd371419697a9655f6be5496ef77d47eb5 [INFO] running `Command { std: "docker" "start" "-a" "8d5da2c0bfb5ece695c6df390009fbcd371419697a9655f6be5496ef77d47eb5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8d5da2c0bfb5ece695c6df390009fbcd371419697a9655f6be5496ef77d47eb5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8d5da2c0bfb5ece695c6df390009fbcd371419697a9655f6be5496ef77d47eb5", kill_on_drop: false }` [INFO] [stdout] 8d5da2c0bfb5ece695c6df390009fbcd371419697a9655f6be5496ef77d47eb5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d33a5eadb32df44a93889f87358b23d54966f7001c224bb77bd8cf49039cdf69 [INFO] running `Command { std: "docker" "start" "-a" "d33a5eadb32df44a93889f87358b23d54966f7001c224bb77bd8cf49039cdf69", kill_on_drop: false }` [INFO] [stderr] Compiling rustix v1.0.7 [INFO] [stderr] Checking signal-hook-registry v1.4.5 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Compiling convert_case v0.7.1 [INFO] [stderr] Compiling portable-atomic v1.11.0 [INFO] [stderr] Compiling clap_derive v4.5.47 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking signal-hook v0.3.18 [INFO] [stderr] Compiling derive_more-impl v2.0.1 [INFO] [stderr] Checking clap_builder v4.5.48 [INFO] [stderr] Compiling litrs v0.4.1 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking console v0.16.1 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling document-features v0.2.11 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking unit-prefix v0.5.1 [INFO] [stderr] Checking indicatif v0.18.0 [INFO] [stderr] Checking derive_more v2.0.1 [INFO] [stderr] Checking humansize v2.1.3 [INFO] [stderr] Checking dirs v6.0.0 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Checking tokio v1.45.1 [INFO] [stderr] Checking getrandom v0.3.3 [INFO] [stderr] Checking crossterm v0.29.0 [INFO] [stderr] Checking tempfile v3.20.0 [INFO] [stderr] Checking clap v4.5.48 [INFO] [stderr] Checking clap_complete v4.5.58 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking serde_json v1.0.140 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking rskiller v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/config.rs:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | / impl Default for SearchConfig { [INFO] [stdout] 77 | | fn default() -> Self { [INFO] [stdout] 78 | | Self { [INFO] [stdout] 79 | | directory: None, [INFO] [stdout] ... | [INFO] [stdout] 87 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 26 + #[derive(Default)] [INFO] [stdout] 27 | pub struct SearchConfig { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/config.rs:89:1 [INFO] [stdout] | [INFO] [stdout] 89 | / impl Default for OutputConfig { [INFO] [stdout] 90 | | fn default() -> Self { [INFO] [stdout] 91 | | Self { [INFO] [stdout] 92 | | sort: None, [INFO] [stdout] ... | [INFO] [stdout] 98 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 36 + #[derive(Default)] [INFO] [stdout] 37 | pub struct OutputConfig { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/config.rs:100:1 [INFO] [stdout] | [INFO] [stdout] 100 | / impl Default for BehaviorConfig { [INFO] [stdout] 101 | | fn default() -> Self { [INFO] [stdout] 102 | | Self { [INFO] [stdout] 103 | | dry_run: None, [INFO] [stdout] ... | [INFO] [stdout] 109 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 44 + #[derive(Default)] [INFO] [stdout] 45 | pub struct BehaviorConfig { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/config.rs:111:1 [INFO] [stdout] | [INFO] [stdout] 111 | / impl Default for SafetyConfig { [INFO] [stdout] 112 | | fn default() -> Self { [INFO] [stdout] 113 | | Self { [INFO] [stdout] 114 | | confirm_large_deletions: None, [INFO] [stdout] ... | [INFO] [stdout] 120 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 52 + #[derive(Default)] [INFO] [stdout] 53 | pub struct SafetyConfig { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/config.rs:122:1 [INFO] [stdout] | [INFO] [stdout] 122 | / impl Default for PerformanceConfig { [INFO] [stdout] 123 | | fn default() -> Self { [INFO] [stdout] 124 | | Self { [INFO] [stdout] 125 | | enable_parallel_scanning: None, [INFO] [stdout] ... | [INFO] [stdout] 131 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 60 + #[derive(Default)] [INFO] [stdout] 61 | pub struct PerformanceConfig { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/config.rs:133:1 [INFO] [stdout] | [INFO] [stdout] 133 | / impl Default for FiltersConfig { [INFO] [stdout] 134 | | fn default() -> Self { [INFO] [stdout] 135 | | Self { [INFO] [stdout] 136 | | min_age_days: None, [INFO] [stdout] ... | [INFO] [stdout] 143 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 68 + #[derive(Default)] [INFO] [stdout] 69 | pub struct FiltersConfig { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/scanner.rs:200:43 [INFO] [stdout] | [INFO] [stdout] 200 | let target_dir = project_dir.join(&cli.get_target_name()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `cli.get_target_name()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/scanner.rs:363:32 [INFO] [stdout] | [INFO] [stdout] 363 | fn sort_projects(projects: &mut Vec, sort_by: &SortBy, _use_gb: bool) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 363 - fn sort_projects(projects: &mut Vec, sort_by: &SortBy, _use_gb: bool) { [INFO] [stdout] 363 + fn sort_projects(projects: &mut [RustProject], sort_by: &SortBy, _use_gb: bool) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/scanner.rs:366:17 [INFO] [stdout] | [INFO] [stdout] 366 | projects.sort_by(|a, b| b.total_cleanable_size().cmp(&a.total_cleanable_size())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 366 - projects.sort_by(|a, b| b.total_cleanable_size().cmp(&a.total_cleanable_size())); [INFO] [stdout] 366 + projects.sort_by_key(|b| std::cmp::Reverse(b.total_cleanable_size())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/scanner.rs:424:23 [INFO] [stdout] | [INFO] [stdout] 424 | } else if !project.target_dir.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `project.target_dir.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/config.rs:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | / impl Default for SearchConfig { [INFO] [stdout] 77 | | fn default() -> Self { [INFO] [stdout] 78 | | Self { [INFO] [stdout] 79 | | directory: None, [INFO] [stdout] ... | [INFO] [stdout] 87 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 26 + #[derive(Default)] [INFO] [stdout] 27 | pub struct SearchConfig { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/config.rs:89:1 [INFO] [stdout] | [INFO] [stdout] 89 | / impl Default for OutputConfig { [INFO] [stdout] 90 | | fn default() -> Self { [INFO] [stdout] 91 | | Self { [INFO] [stdout] 92 | | sort: None, [INFO] [stdout] ... | [INFO] [stdout] 98 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 36 + #[derive(Default)] [INFO] [stdout] 37 | pub struct OutputConfig { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/config.rs:100:1 [INFO] [stdout] | [INFO] [stdout] 100 | / impl Default for BehaviorConfig { [INFO] [stdout] 101 | | fn default() -> Self { [INFO] [stdout] 102 | | Self { [INFO] [stdout] 103 | | dry_run: None, [INFO] [stdout] ... | [INFO] [stdout] 109 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 44 + #[derive(Default)] [INFO] [stdout] 45 | pub struct BehaviorConfig { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/config.rs:111:1 [INFO] [stdout] | [INFO] [stdout] 111 | / impl Default for SafetyConfig { [INFO] [stdout] 112 | | fn default() -> Self { [INFO] [stdout] 113 | | Self { [INFO] [stdout] 114 | | confirm_large_deletions: None, [INFO] [stdout] ... | [INFO] [stdout] 120 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 52 + #[derive(Default)] [INFO] [stdout] 53 | pub struct SafetyConfig { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/config.rs:122:1 [INFO] [stdout] | [INFO] [stdout] 122 | / impl Default for PerformanceConfig { [INFO] [stdout] 123 | | fn default() -> Self { [INFO] [stdout] 124 | | Self { [INFO] [stdout] 125 | | enable_parallel_scanning: None, [INFO] [stdout] ... | [INFO] [stdout] 131 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 60 + #[derive(Default)] [INFO] [stdout] 61 | pub struct PerformanceConfig { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/config.rs:133:1 [INFO] [stdout] | [INFO] [stdout] 133 | / impl Default for FiltersConfig { [INFO] [stdout] 134 | | fn default() -> Self { [INFO] [stdout] 135 | | Self { [INFO] [stdout] 136 | | min_age_days: None, [INFO] [stdout] ... | [INFO] [stdout] 143 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 68 + #[derive(Default)] [INFO] [stdout] 69 | pub struct FiltersConfig { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/scanner.rs:200:43 [INFO] [stdout] | [INFO] [stdout] 200 | let target_dir = project_dir.join(&cli.get_target_name()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `cli.get_target_name()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/scanner.rs:363:32 [INFO] [stdout] | [INFO] [stdout] 363 | fn sort_projects(projects: &mut Vec, sort_by: &SortBy, _use_gb: bool) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 363 - fn sort_projects(projects: &mut Vec, sort_by: &SortBy, _use_gb: bool) { [INFO] [stdout] 363 + fn sort_projects(projects: &mut [RustProject], sort_by: &SortBy, _use_gb: bool) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/scanner.rs:366:17 [INFO] [stdout] | [INFO] [stdout] 366 | projects.sort_by(|a, b| b.total_cleanable_size().cmp(&a.total_cleanable_size())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 366 - projects.sort_by(|a, b| b.total_cleanable_size().cmp(&a.total_cleanable_size())); [INFO] [stdout] 366 + projects.sort_by_key(|b| std::cmp::Reverse(b.total_cleanable_size())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/scanner.rs:424:23 [INFO] [stdout] | [INFO] [stdout] 424 | } else if !project.target_dir.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `project.target_dir.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 27.91s [INFO] running `Command { std: "docker" "inspect" "d33a5eadb32df44a93889f87358b23d54966f7001c224bb77bd8cf49039cdf69", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d33a5eadb32df44a93889f87358b23d54966f7001c224bb77bd8cf49039cdf69", kill_on_drop: false }` [INFO] [stdout] d33a5eadb32df44a93889f87358b23d54966f7001c224bb77bd8cf49039cdf69