[INFO] fetching crate rotsniff 0.2.1... [INFO] linting rotsniff-0.2.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate rotsniff 0.2.1 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate rotsniff 0.2.1 [INFO] finished tweaking crates.io crate rotsniff 0.2.1 [INFO] tweaked toml for crates.io crate rotsniff 0.2.1 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate rotsniff 0.2.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate rotsniff 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded anstyle-query v1.1.0 [INFO] [stderr] Downloaded proc-macro2 v1.0.85 [INFO] [stderr] Downloaded clap_lex v0.7.1 [INFO] [stderr] Downloaded subtle v2.6.0 [INFO] [stderr] Downloaded csv-core v0.1.11 [INFO] [stderr] Downloaded clap_derive v4.5.5 [INFO] [stderr] Downloaded clap v4.5.7 [INFO] [stderr] Downloaded serde_derive v1.0.203 [INFO] [stderr] Downloaded serde v1.0.203 [INFO] [stderr] Downloaded regex v1.10.5 [INFO] [stderr] Downloaded clap_builder v4.5.7 [INFO] [stderr] Downloaded regex-syntax v0.8.4 [INFO] [stderr] Downloaded regex-automata v0.4.7 [INFO] [stderr] Downloaded csv v1.3.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1de17acc4d4ca0226fbea086814f2e15e1efa65983a603ffedd240cde3095723 [INFO] running `Command { std: "docker" "start" "-a" "1de17acc4d4ca0226fbea086814f2e15e1efa65983a603ffedd240cde3095723", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1de17acc4d4ca0226fbea086814f2e15e1efa65983a603ffedd240cde3095723", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1de17acc4d4ca0226fbea086814f2e15e1efa65983a603ffedd240cde3095723", kill_on_drop: false }` [INFO] [stdout] 1de17acc4d4ca0226fbea086814f2e15e1efa65983a603ffedd240cde3095723 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e792ad23232ea6cc52bd3762c033508343be66b58104ebd21752c99b1e0aa90a [INFO] running `Command { std: "docker" "start" "-a" "e792ad23232ea6cc52bd3762c033508343be66b58104ebd21752c99b1e0aa90a", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking subtle v2.6.0 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking either v1.12.0 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking clap_builder v4.5.7 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling clap_derive v4.5.5 [INFO] [stderr] Checking clap v4.5.7 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking rotsniff v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/database.rs:29:14 [INFO] [stdout] | [INFO] [stdout] 29 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/main.rs:53:52 [INFO] [stdout] | [INFO] [stdout] 53 | Some(regex) if args.negate_fnfilter => x.to_str().map_or(false, |x| !regex.is_match(x)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 53 - Some(regex) if args.negate_fnfilter => x.to_str().map_or(false, |x| !regex.is_match(x)), [INFO] [stdout] 53 + Some(regex) if args.negate_fnfilter => x.to_str().is_some_and(|x| !regex.is_match(x)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/database.rs:29:14 [INFO] [stdout] | [INFO] [stdout] 29 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/main.rs:54:28 [INFO] [stdout] | [INFO] [stdout] 54 | Some(regex) => x.to_str().map_or(false, |x| regex.is_match(x)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 54 - Some(regex) => x.to_str().map_or(false, |x| regex.is_match(x)), [INFO] [stdout] 54 + Some(regex) => x.to_str().is_some_and(|x| regex.is_match(x)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:66:43 [INFO] [stdout] | [INFO] [stdout] 66 | let new_hashes = paths(&args, &directory) [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `directory` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:67:29 [INFO] [stdout] | [INFO] [stdout] 67 | .filter(|x| !database.get(x).is_some()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `database.get(x).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:147:37 [INFO] [stdout] | [INFO] [stdout] 147 | .chain(paths(&args, &directory).par_bridge().filter_map( [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `directory` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:158:16 [INFO] [stdout] | [INFO] [stdout] 158 | if diff.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!diff.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/main.rs:53:52 [INFO] [stdout] | [INFO] [stdout] 53 | Some(regex) if args.negate_fnfilter => x.to_str().map_or(false, |x| !regex.is_match(x)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 53 - Some(regex) if args.negate_fnfilter => x.to_str().map_or(false, |x| !regex.is_match(x)), [INFO] [stdout] 53 + Some(regex) if args.negate_fnfilter => x.to_str().is_some_and(|x| !regex.is_match(x)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/main.rs:54:28 [INFO] [stdout] | [INFO] [stdout] 54 | Some(regex) => x.to_str().map_or(false, |x| regex.is_match(x)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 54 - Some(regex) => x.to_str().map_or(false, |x| regex.is_match(x)), [INFO] [stdout] 54 + Some(regex) => x.to_str().is_some_and(|x| regex.is_match(x)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:66:43 [INFO] [stdout] | [INFO] [stdout] 66 | let new_hashes = paths(&args, &directory) [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `directory` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:67:29 [INFO] [stdout] | [INFO] [stdout] 67 | .filter(|x| !database.get(x).is_some()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `database.get(x).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:147:37 [INFO] [stdout] | [INFO] [stdout] 147 | .chain(paths(&args, &directory).par_bridge().filter_map( [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `directory` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:158:16 [INFO] [stdout] | [INFO] [stdout] 158 | if diff.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!diff.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 17.86s [INFO] running `Command { std: "docker" "inspect" "e792ad23232ea6cc52bd3762c033508343be66b58104ebd21752c99b1e0aa90a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e792ad23232ea6cc52bd3762c033508343be66b58104ebd21752c99b1e0aa90a", kill_on_drop: false }` [INFO] [stdout] e792ad23232ea6cc52bd3762c033508343be66b58104ebd21752c99b1e0aa90a