[INFO] fetching crate robust-git-bisect 0.1.1... [INFO] linting robust-git-bisect-0.1.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate robust-git-bisect 0.1.1 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate robust-git-bisect 0.1.1 [INFO] finished tweaking crates.io crate robust-git-bisect 0.1.1 [INFO] tweaked toml for crates.io crate robust-git-bisect 0.1.1 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate robust-git-bisect 0.1.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate robust-git-bisect 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded autocfg v1.0.1 [INFO] [stderr] Downloaded termcolor v1.1.0 [INFO] [stderr] Downloaded log v0.4.11 [INFO] [stderr] Downloaded union-find v0.3.2 [INFO] [stderr] Downloaded num-traits v0.2.12 [INFO] [stderr] Downloaded robust-binary-search v0.1.0 [INFO] [stderr] Downloaded simplelog v0.8.0 [INFO] [stderr] Downloaded time v0.1.44 [INFO] [stderr] Downloaded hermit-abi v0.1.17 [INFO] [stderr] Downloaded ansi_term v0.11.0 [INFO] [stderr] Downloaded unicode-width v0.1.8 [INFO] [stderr] Downloaded rand_xoshiro v0.4.0 [INFO] [stderr] Downloaded sized-chunks v0.6.2 [INFO] [stderr] Downloaded typenum v1.12.0 [INFO] [stderr] Downloaded num-integer v0.1.43 [INFO] [stderr] Downloaded chrono v0.4.19 [INFO] [stderr] Downloaded version_check v0.9.2 [INFO] [stderr] Downloaded libc v0.2.79 [INFO] [stderr] Downloaded clap v2.33.3 [INFO] [stderr] Downloaded im-rc v15.0.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 433245aa7fc022936fdfe3313fd4bc62b991d475c33c2aaad6a8bf356e2723ba [INFO] running `Command { std: "docker" "start" "-a" "433245aa7fc022936fdfe3313fd4bc62b991d475c33c2aaad6a8bf356e2723ba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "433245aa7fc022936fdfe3313fd4bc62b991d475c33c2aaad6a8bf356e2723ba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "433245aa7fc022936fdfe3313fd4bc62b991d475c33c2aaad6a8bf356e2723ba", kill_on_drop: false }` [INFO] [stdout] 433245aa7fc022936fdfe3313fd4bc62b991d475c33c2aaad6a8bf356e2723ba [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cc00a61dfd3b9018c3e8e815b7c877f60818c56421682cb883b0512542f3394b [INFO] running `Command { std: "docker" "start" "-a" "cc00a61dfd3b9018c3e8e815b7c877f60818c56421682cb883b0512542f3394b", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling libc v0.2.79 [INFO] [stderr] Compiling typenum v1.12.0 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking termcolor v1.1.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking union-find v0.3.2 [INFO] [stderr] Checking rand_xoshiro v0.4.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling im-rc v15.0.0 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling num-integer v0.1.43 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking bitmaps v2.1.0 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking sized-chunks v0.6.2 [INFO] [stderr] Checking simplelog v0.8.0 [INFO] [stderr] Checking robust-binary-search v0.1.0 [INFO] [stderr] Checking robust-git-bisect v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/main.rs:40:20 [INFO] [stdout] | [INFO] [stdout] 40 | struct StringUnion(String); [INFO] [stdout] | ----------- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `StringUnion` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/main.rs:86:18 [INFO] [stdout] | [INFO] [stdout] 86 | .or_insert_with(HashSet::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:144:21 [INFO] [stdout] | [INFO] [stdout] 144 | let heads = !run("sh", |cmd| cmd.current_dir(&dir).arg("-c").arg(test_cmd)).is_ok(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `run("sh", |cmd| cmd.current_dir(&dir).arg("-c").arg(test_cmd)).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:222:26 [INFO] [stdout] | [INFO] [stdout] 222 | .current_dir(&dir) [INFO] [stdout] | ^^^^ help: change this to: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:236:33 [INFO] [stdout] | [INFO] [stdout] 236 | .or_insert_with(|| Vec::new()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Vec::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:240:33 [INFO] [stdout] | [INFO] [stdout] 240 | .or_insert_with(|| Vec::new()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Vec::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/main.rs:269:14 [INFO] [stdout] | [INFO] [stdout] 269 | .or_insert_with(GitSegmentUf::default); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/main.rs:281:26 [INFO] [stdout] | [INFO] [stdout] 281 | for (_key, value) in &mut segments { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 281 - for (_key, value) in &mut segments { [INFO] [stdout] 281 + for value in segments.values_mut() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/main.rs:296:9 [INFO] [stdout] | [INFO] [stdout] 296 | / loop { [INFO] [stdout] 297 | | let child_commits = match children.get(&commit) { [INFO] [stdout] 298 | | Some(x) => x, [INFO] [stdout] 299 | | None => break, [INFO] [stdout] ... | [INFO] [stdout] 309 | | commit = child_commits[0].clone(); [INFO] [stdout] 310 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 296 ~ while let Some(x) = children.get(&commit) { [INFO] [stdout] 297 + let child_commits = x; [INFO] [stdout] 298 + .. [INFO] [stdout] 299 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:342:30 [INFO] [stdout] | [INFO] [stdout] 342 | let metrics = run_bisect(&dir, &git_segments, &test_cmd, min_likelihood); [INFO] [stdout] | ^^^^ help: change this to: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:342:51 [INFO] [stdout] | [INFO] [stdout] 342 | let metrics = run_bisect(&dir, &git_segments, &test_cmd, min_likelihood); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `test_cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/main.rs:40:20 [INFO] [stdout] | [INFO] [stdout] 40 | struct StringUnion(String); [INFO] [stdout] | ----------- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `StringUnion` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/main.rs:86:18 [INFO] [stdout] | [INFO] [stdout] 86 | .or_insert_with(HashSet::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:144:21 [INFO] [stdout] | [INFO] [stdout] 144 | let heads = !run("sh", |cmd| cmd.current_dir(&dir).arg("-c").arg(test_cmd)).is_ok(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `run("sh", |cmd| cmd.current_dir(&dir).arg("-c").arg(test_cmd)).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:222:26 [INFO] [stdout] | [INFO] [stdout] 222 | .current_dir(&dir) [INFO] [stdout] | ^^^^ help: change this to: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:236:33 [INFO] [stdout] | [INFO] [stdout] 236 | .or_insert_with(|| Vec::new()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Vec::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:240:33 [INFO] [stdout] | [INFO] [stdout] 240 | .or_insert_with(|| Vec::new()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Vec::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/main.rs:269:14 [INFO] [stdout] | [INFO] [stdout] 269 | .or_insert_with(GitSegmentUf::default); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/main.rs:281:26 [INFO] [stdout] | [INFO] [stdout] 281 | for (_key, value) in &mut segments { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 281 - for (_key, value) in &mut segments { [INFO] [stdout] 281 + for value in segments.values_mut() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/main.rs:296:9 [INFO] [stdout] | [INFO] [stdout] 296 | / loop { [INFO] [stdout] 297 | | let child_commits = match children.get(&commit) { [INFO] [stdout] 298 | | Some(x) => x, [INFO] [stdout] 299 | | None => break, [INFO] [stdout] ... | [INFO] [stdout] 309 | | commit = child_commits[0].clone(); [INFO] [stdout] 310 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 296 ~ while let Some(x) = children.get(&commit) { [INFO] [stdout] 297 + let child_commits = x; [INFO] [stdout] 298 + .. [INFO] [stdout] 299 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:342:30 [INFO] [stdout] | [INFO] [stdout] 342 | let metrics = run_bisect(&dir, &git_segments, &test_cmd, min_likelihood); [INFO] [stdout] | ^^^^ help: change this to: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:342:51 [INFO] [stdout] | [INFO] [stdout] 342 | let metrics = run_bisect(&dir, &git_segments, &test_cmd, min_likelihood); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `test_cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.93s [INFO] running `Command { std: "docker" "inspect" "cc00a61dfd3b9018c3e8e815b7c877f60818c56421682cb883b0512542f3394b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cc00a61dfd3b9018c3e8e815b7c877f60818c56421682cb883b0512542f3394b", kill_on_drop: false }` [INFO] [stdout] cc00a61dfd3b9018c3e8e815b7c877f60818c56421682cb883b0512542f3394b