[INFO] fetching crate robosync 1.0.10... [INFO] linting robosync-1.0.10 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate robosync 1.0.10 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate robosync 1.0.10 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate robosync 1.0.10 [INFO] tweaked toml for crates.io crate robosync 1.0.10 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate robosync 1.0.10 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate robosync 1.0.10 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded anstyle-wincon v3.0.9 [INFO] [stderr] Downloaded anstyle-query v1.1.3 [INFO] [stderr] Downloaded filetime v0.2.25 [INFO] [stderr] Downloaded libredox v0.1.9 [INFO] [stderr] Downloaded anstream v0.6.19 [INFO] [stderr] Downloaded console v0.16.0 [INFO] [stderr] Downloaded clap v4.5.42 [INFO] [stderr] Downloaded indicatif v0.18.0 [INFO] [stderr] Downloaded io-uring v0.7.9 [INFO] [stderr] Downloaded mio v0.8.11 [INFO] [stderr] Downloaded crossterm v0.27.0 [INFO] [stderr] Downloaded clap_builder v4.5.42 [INFO] [stderr] Downloaded serde_json v1.0.141 [INFO] [stderr] Downloaded hashbrown v0.15.4 [INFO] [stderr] Downloaded io-uring v0.6.4 [INFO] [stderr] Downloaded jwalk v0.8.1 [INFO] [stderr] Downloaded unicode-width v0.2.1 [INFO] [stderr] Downloaded nix v0.27.1 [INFO] [stderr] Downloaded lz4_flex v0.11.5 [INFO] [stderr] Downloaded uuid v1.17.0 [INFO] [stderr] Downloaded twox-hash v2.1.1 [INFO] [stderr] Downloaded memmap2 v0.9.7 [INFO] [stderr] Downloaded cc v1.2.30 [INFO] [stderr] Downloaded unit-prefix v0.5.1 [INFO] [stderr] Downloaded jobserver v0.1.33 [INFO] [stderr] Downloaded zstd-sys v2.0.15+zstd.1.5.7 [INFO] [stderr] Downloaded tokio v1.47.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0c83d9f0f6de5e28f97c7838aa8474ec9df6b25a4602ccb60220c1416c3eb0e5 [INFO] running `Command { std: "docker" "start" "-a" "0c83d9f0f6de5e28f97c7838aa8474ec9df6b25a4602ccb60220c1416c3eb0e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0c83d9f0f6de5e28f97c7838aa8474ec9df6b25a4602ccb60220c1416c3eb0e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0c83d9f0f6de5e28f97c7838aa8474ec9df6b25a4602ccb60220c1416c3eb0e5", kill_on_drop: false }` [INFO] [stdout] 0c83d9f0f6de5e28f97c7838aa8474ec9df6b25a4602ccb60220c1416c3eb0e5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b61c983b0c81f5e401a9e6a22065692e29510e2a7ad68478d3706a8b48fb6974 [INFO] running `Command { std: "docker" "start" "-a" "b61c983b0c81f5e401a9e6a22065692e29510e2a7ad68478d3706a8b48fb6974", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Compiling proc-macro2 v1.0.95 [INFO] [stderr] Compiling unicode-ident v1.0.18 [INFO] [stderr] Checking cfg-if v1.0.1 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Compiling typenum v1.18.0 [INFO] [stderr] Compiling parking_lot_core v0.9.11 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Compiling lock_api v0.4.13 [INFO] [stderr] Compiling signal-hook v0.3.18 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling serde_json v1.0.141 [INFO] [stderr] Checking bitflags v2.9.1 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking once_cell v1.21.3 [INFO] [stderr] Checking anstyle-parse v0.2.7 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Checking colorchoice v1.0.4 [INFO] [stderr] Checking anstyle v1.0.11 [INFO] [stderr] Checking anstyle-query v1.1.3 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Compiling portable-atomic v1.11.1 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Checking clap_lex v0.7.5 [INFO] [stderr] Checking memchr v2.7.5 [INFO] [stderr] Checking ryu v1.0.20 [INFO] [stderr] Checking itoa v1.0.15 [INFO] [stderr] Checking hashbrown v0.15.4 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking anstream v0.6.19 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking equivalent v1.0.2 [INFO] [stderr] Checking crossbeam-queue v0.3.12 [INFO] [stderr] Checking crossbeam-channel v0.5.15 [INFO] [stderr] Compiling io-uring v0.6.4 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking winnow v0.7.12 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Checking clap_builder v4.5.42 [INFO] [stderr] Checking toml_write v0.1.2 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking unicode-width v0.2.1 [INFO] [stderr] Compiling anyhow v1.0.98 [INFO] [stderr] Checking crossbeam-deque v0.8.6 [INFO] [stderr] Compiling thiserror v1.0.69 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Checking half v2.6.0 [INFO] [stderr] Checking bytes v1.10.1 [INFO] [stderr] Checking constant_time_eq v0.3.1 [INFO] [stderr] Checking twox-hash v2.1.1 [INFO] [stderr] Checking unit-prefix v0.5.1 [INFO] [stderr] Checking pin-project-lite v0.2.16 [INFO] [stderr] Checking arrayref v0.3.9 [INFO] [stderr] Checking iana-time-zone v0.1.63 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Compiling jobserver v0.1.33 [INFO] [stderr] Compiling rustix v1.0.8 [INFO] [stderr] Checking plotters-backend v0.3.7 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Checking lz4_flex v0.11.5 [INFO] [stderr] Compiling cc v1.2.30 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking plotters-svg v0.3.7 [INFO] [stderr] Checking indexmap v2.10.0 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking xxhash-rust v0.8.15 [INFO] [stderr] Checking linux-raw-sys v0.9.4 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking fastrand v2.3.0 [INFO] [stderr] Checking oorandom v11.1.5 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking signal-hook-registry v1.4.5 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking socket2 v0.6.0 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking console v0.16.0 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Checking filetime v0.2.25 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Compiling zstd-sys v2.0.15+zstd.1.5.7 [INFO] [stderr] Compiling blake3 v1.8.2 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking memmap2 v0.9.7 [INFO] [stderr] Checking is-terminal v0.4.16 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking indicatif v0.18.0 [INFO] [stderr] Checking jwalk v0.8.1 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling clap_derive v4.5.41 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking tokio v1.47.0 [INFO] [stderr] Compiling async-trait v0.1.88 [INFO] [stderr] Checking tempfile v3.20.0 [INFO] [stderr] Checking clap v4.5.42 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking uuid v1.17.0 [INFO] [stderr] Checking chrono v0.4.41 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Compiling zstd-safe v7.2.4 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Checking robosync v1.0.10 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable `last_rate` is assigned to, but never used [INFO] [stdout] --> src/mixed_strategy.rs:433:25 [INFO] [stdout] | [INFO] [stdout] 433 | let mut last_rate = 0.0; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_last_rate` instead [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `last_rate` is never read [INFO] [stdout] --> src/mixed_strategy.rs:463:29 [INFO] [stdout] | [INFO] [stdout] 463 | ... last_rate = rate; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `last_rate` is assigned to, but never used [INFO] [stdout] --> src/mixed_strategy.rs:433:25 [INFO] [stdout] | [INFO] [stdout] 433 | let mut last_rate = 0.0; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_last_rate` instead [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `last_rate` is never read [INFO] [stdout] --> src/mixed_strategy.rs:463:29 [INFO] [stdout] | [INFO] [stdout] 463 | ... last_rate = rate; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/checksum.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | / impl Default for ChecksumType { [INFO] [stdout] 14 | | fn default() -> Self { [INFO] [stdout] 15 | | Self::Blake3 [INFO] [stdout] 16 | | } [INFO] [stdout] 17 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 7 + #[derive(Default)] [INFO] [stdout] 8 | pub enum ChecksumType { [INFO] [stdout] 9 ~ #[default] [INFO] [stdout] 10 ~ Blake3, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/checksum.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | / impl Default for ChecksumType { [INFO] [stdout] 14 | | fn default() -> Self { [INFO] [stdout] 15 | | Self::Blake3 [INFO] [stdout] 16 | | } [INFO] [stdout] 17 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 7 + #[derive(Default)] [INFO] [stdout] 8 | pub enum ChecksumType { [INFO] [stdout] 9 ~ #[default] [INFO] [stdout] 10 ~ Blake3, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/fast_file_list.rs:181:32 [INFO] [stdout] | [INFO] [stdout] 181 | ... if count % self.config.progress_interval == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `count.is_multiple_of(self.config.progress_interval)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/file_list.rs:658:20 [INFO] [stdout] | [INFO] [stdout] 658 | if count % progress_update_interval == 0 || count == source.len() - 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `count.is_multiple_of(progress_update_interval)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/formatted_display.rs:53:1 [INFO] [stdout] | [INFO] [stdout] 53 | / pub fn print_file_analysis( [INFO] [stdout] 54 | | total_files: u64, [INFO] [stdout] 55 | | small_files: u64, [INFO] [stdout] 56 | | medium_files: u64, [INFO] [stdout] ... | [INFO] [stdout] 61 | | large_size: u64, [INFO] [stdout] 62 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (12/7) [INFO] [stdout] --> src/formatted_display.rs:92:1 [INFO] [stdout] | [INFO] [stdout] 92 | / pub fn print_pending_operations( [INFO] [stdout] 93 | | files_create: u64, [INFO] [stdout] 94 | | files_update: u64, [INFO] [stdout] 95 | | files_delete: u64, [INFO] [stdout] ... | [INFO] [stdout] 104 | | size_skip: u64, [INFO] [stdout] 105 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/fast_file_list.rs:181:32 [INFO] [stdout] | [INFO] [stdout] 181 | ... if count % self.config.progress_interval == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `count.is_multiple_of(self.config.progress_interval)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: items after a test module [INFO] [stdout] --> src/file_list.rs:1012:1 [INFO] [stdout] | [INFO] [stdout] 1012 | mod tests { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1313 | fn dereference_symlink(symlink_path: &Path, target_path: &Path) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_test_module [INFO] [stdout] = note: `#[warn(clippy::items_after_test_module)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/file_list.rs:658:20 [INFO] [stdout] | [INFO] [stdout] 658 | if count % progress_update_interval == 0 || count == source.len() - 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `count.is_multiple_of(progress_update_interval)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/metadata.rs:448:5 [INFO] [stdout] | [INFO] [stdout] 448 | caps.filesystem_type = classify_unix_filesystem(&mount_info.fstype, &mount_info.mount_point); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `metadata::FilesystemCapabilities { filesystem_type: classify_unix_filesystem(&mount_info.fstype, &mount_info.mount_point), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/metadata.rs:447:5 [INFO] [stdout] | [INFO] [stdout] 447 | let mut caps = FilesystemCapabilities::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/metadata.rs:685:40 [INFO] [stdout] | [INFO] [stdout] 685 | const NETWORK_BUFFER_SIZE: usize = 1 * 1024 * 1024; // 1MB instead of 32MB [INFO] [stdout] | ^^^^^^^^ help: consider reducing it to: `1024` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `clone` can be replaced with `std::slice::from_ref` [INFO] [stdout] --> src/file_list.rs:1230:32 [INFO] [stdout] | [INFO] [stdout] 1230 | compare_file_lists(&[symlink_file.clone()], &[target_regular_file.clone()]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::slice::from_ref(&symlink_file)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cloned_ref_to_slice_refs [INFO] [stdout] = note: `#[warn(clippy::cloned_ref_to_slice_refs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `clone` can be replaced with `std::slice::from_ref` [INFO] [stdout] --> src/file_list.rs:1230:57 [INFO] [stdout] | [INFO] [stdout] 1230 | compare_file_lists(&[symlink_file.clone()], &[target_regular_file.clone()]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::slice::from_ref(&target_regular_file)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cloned_ref_to_slice_refs [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `clone` can be replaced with `std::slice::from_ref` [INFO] [stdout] --> src/file_list.rs:1237:69 [INFO] [stdout] | [INFO] [stdout] 1237 | let operations = compare_file_lists(&[target_regular_file], &[symlink_file.clone()]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::slice::from_ref(&symlink_file)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cloned_ref_to_slice_refs [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/formatted_display.rs:53:1 [INFO] [stdout] | [INFO] [stdout] 53 | / pub fn print_file_analysis( [INFO] [stdout] 54 | | total_files: u64, [INFO] [stdout] 55 | | small_files: u64, [INFO] [stdout] 56 | | medium_files: u64, [INFO] [stdout] ... | [INFO] [stdout] 61 | | large_size: u64, [INFO] [stdout] 62 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (12/7) [INFO] [stdout] --> src/formatted_display.rs:92:1 [INFO] [stdout] | [INFO] [stdout] 92 | / pub fn print_pending_operations( [INFO] [stdout] 93 | | files_create: u64, [INFO] [stdout] 94 | | files_update: u64, [INFO] [stdout] 95 | | files_delete: u64, [INFO] [stdout] ... | [INFO] [stdout] 104 | | size_skip: u64, [INFO] [stdout] 105 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/mixed_strategy.rs:636:13 [INFO] [stdout] | [INFO] [stdout] 636 | / if let Ok(report_path) = error_logger.finalize_with_stats(&total_stats) { [INFO] [stdout] 637 | | report_path [INFO] [stdout] 638 | | } else { [INFO] [stdout] 639 | | None [INFO] [stdout] 640 | | }; [INFO] [stdout] | |_____________^ help: replace it with: `error_logger.finalize_with_stats(&total_stats).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` branch is empty [INFO] [stdout] --> src/mixed_strategy.rs:803:17 [INFO] [stdout] | [INFO] [stdout] 803 | if !active.is_empty() {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: you can remove it: `!active.is_empty();` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_ifs [INFO] [stdout] = note: `#[warn(clippy::needless_ifs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/metadata.rs:448:5 [INFO] [stdout] | [INFO] [stdout] 448 | caps.filesystem_type = classify_unix_filesystem(&mount_info.fstype, &mount_info.mount_point); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `metadata::FilesystemCapabilities { filesystem_type: classify_unix_filesystem(&mount_info.fstype, &mount_info.mount_point), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/metadata.rs:447:5 [INFO] [stdout] | [INFO] [stdout] 447 | let mut caps = FilesystemCapabilities::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/native_tools.rs:74:21 [INFO] [stdout] | [INFO] [stdout] 74 | / for line in reader.lines() { [INFO] [stdout] 75 | | if let Ok(line) = line { [INFO] [stdout] 76 | | progress_manager.update_from_tool_output(&line, ToolType::Rsync); [INFO] [stdout] 77 | | } [INFO] [stdout] 78 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/native_tools.rs:75:25 [INFO] [stdout] | [INFO] [stdout] 75 | / if let Ok(line) = line { [INFO] [stdout] 76 | | progress_manager.update_from_tool_output(&line, ToolType::Rsync); [INFO] [stdout] 77 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 74 ~ for line in reader.lines().flatten() { [INFO] [stdout] 75 + progress_manager.update_from_tool_output(&line, ToolType::Rsync); [INFO] [stdout] 76 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/metadata.rs:685:40 [INFO] [stdout] | [INFO] [stdout] 685 | const NETWORK_BUFFER_SIZE: usize = 1 * 1024 * 1024; // 1MB instead of 32MB [INFO] [stdout] | ^^^^^^^^ help: consider reducing it to: `1024` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/native_tools.rs:350:28 [INFO] [stdout] | [INFO] [stdout] 350 | show_progress: !progress_manager.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `progress_manager.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/options.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | / impl Default for SymlinkBehavior { [INFO] [stdout] 24 | | fn default() -> Self { [INFO] [stdout] 25 | | SymlinkBehavior::Preserve [INFO] [stdout] 26 | | } [INFO] [stdout] 27 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 11 + #[derive(Default)] [INFO] [stdout] 12 | pub enum SymlinkBehavior { [INFO] [stdout] 13 | /// Preserve symlinks as symlinks (default, equivalent to --links) [INFO] [stdout] 14 | #[serde(rename = "preserve")] [INFO] [stdout] 15 ~ #[default] [INFO] [stdout] 16 ~ Preserve, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/mixed_strategy.rs:636:13 [INFO] [stdout] | [INFO] [stdout] 636 | / if let Ok(report_path) = error_logger.finalize_with_stats(&total_stats) { [INFO] [stdout] 637 | | report_path [INFO] [stdout] 638 | | } else { [INFO] [stdout] 639 | | None [INFO] [stdout] 640 | | }; [INFO] [stdout] | |_____________^ help: replace it with: `error_logger.finalize_with_stats(&total_stats).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` branch is empty [INFO] [stdout] --> src/mixed_strategy.rs:803:17 [INFO] [stdout] | [INFO] [stdout] 803 | if !active.is_empty() {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: you can remove it: `!active.is_empty();` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_ifs [INFO] [stdout] = note: `#[warn(clippy::needless_ifs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/native_tools.rs:74:21 [INFO] [stdout] | [INFO] [stdout] 74 | / for line in reader.lines() { [INFO] [stdout] 75 | | if let Ok(line) = line { [INFO] [stdout] 76 | | progress_manager.update_from_tool_output(&line, ToolType::Rsync); [INFO] [stdout] 77 | | } [INFO] [stdout] 78 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/native_tools.rs:75:25 [INFO] [stdout] | [INFO] [stdout] 75 | / if let Ok(line) = line { [INFO] [stdout] 76 | | progress_manager.update_from_tool_output(&line, ToolType::Rsync); [INFO] [stdout] 77 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 74 ~ for line in reader.lines().flatten() { [INFO] [stdout] 75 + progress_manager.update_from_tool_output(&line, ToolType::Rsync); [INFO] [stdout] 76 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/native_tools.rs:350:28 [INFO] [stdout] | [INFO] [stdout] 350 | show_progress: !progress_manager.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `progress_manager.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/options.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | / impl Default for SymlinkBehavior { [INFO] [stdout] 24 | | fn default() -> Self { [INFO] [stdout] 25 | | SymlinkBehavior::Preserve [INFO] [stdout] 26 | | } [INFO] [stdout] 27 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 11 + #[derive(Default)] [INFO] [stdout] 12 | pub enum SymlinkBehavior { [INFO] [stdout] 13 | /// Preserve symlinks as symlinks (default, equivalent to --links) [INFO] [stdout] 14 | #[serde(rename = "preserve")] [INFO] [stdout] 15 ~ #[default] [INFO] [stdout] 16 ~ Preserve, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/parallel_sync.rs:1682:40 [INFO] [stdout] | [INFO] [stdout] 1682 | ... if current_file % 100 == 0 || current_file > 3560 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `current_file.is_multiple_of(100)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/parallel_sync.rs:2832:9 [INFO] [stdout] | [INFO] [stdout] 2832 | dir_ops.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 2832 - dir_ops.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] 2832 + dir_ops.sort_by_key(|b| std::cmp::Reverse(b.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/parallel_sync.rs:2902:9 [INFO] [stdout] | [INFO] [stdout] 2902 | dir_ops.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 2902 - dir_ops.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] 2902 + dir_ops.sort_by_key(|b| std::cmp::Reverse(b.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/parallel_sync.rs:1682:40 [INFO] [stdout] | [INFO] [stdout] 1682 | ... if current_file % 100 == 0 || current_file > 3560 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `current_file.is_multiple_of(100)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/streaming_delta.rs:183:10 [INFO] [stdout] | [INFO] [stdout] 183 | ) -> Result<(Vec<(usize, usize, Vec)>, usize)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/parallel_sync.rs:2832:9 [INFO] [stdout] | [INFO] [stdout] 2832 | dir_ops.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 2832 - dir_ops.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] 2832 + dir_ops.sort_by_key(|b| std::cmp::Reverse(b.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/parallel_sync.rs:2902:9 [INFO] [stdout] | [INFO] [stdout] 2902 | dir_ops.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 2902 - dir_ops.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] 2902 + dir_ops.sort_by_key(|b| std::cmp::Reverse(b.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/strategy.rs:384:9 [INFO] [stdout] | [INFO] [stdout] 384 | options.checksum = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `options::SyncOptions { checksum: true, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/strategy.rs:383:9 [INFO] [stdout] | [INFO] [stdout] 383 | let mut options = SyncOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/streaming_delta.rs:183:10 [INFO] [stdout] | [INFO] [stdout] 183 | ) -> Result<(Vec<(usize, usize, Vec)>, usize)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> benches/quick_performance.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 62 | options.checksum = true; // Enable checksum calculation [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `robosync::SyncOptions { checksum: true, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> benches/quick_performance.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | let mut options = SyncOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> benches/quick_performance.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | options.checksum = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `robosync::SyncOptions { checksum: true, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> benches/quick_performance.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | let mut options = SyncOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> benches/quick_performance.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | options.checksum = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `robosync::SyncOptions { checksum: true, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> benches/quick_performance.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | let mut options = SyncOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/main.rs:760:13 [INFO] [stdout] | [INFO] [stdout] 760 | max_threads % 8 == 0 || max_threads == 64 || max_threads == 128 || max_threads == 256, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace with: `max_threads.is_multiple_of(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> benches/performance.rs:66:17 [INFO] [stdout] | [INFO] [stdout] 66 | options.checksum = true; // Enable checksum calculation [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `robosync::SyncOptions { checksum: true, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> benches/performance.rs:65:17 [INFO] [stdout] | [INFO] [stdout] 65 | let mut options = SyncOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> benches/performance.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 135 | options.checksum = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `robosync::SyncOptions { checksum: true, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> benches/performance.rs:134:9 [INFO] [stdout] | [INFO] [stdout] 134 | let mut options = SyncOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> benches/performance.rs:147:9 [INFO] [stdout] | [INFO] [stdout] 147 | options.checksum = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `robosync::SyncOptions { checksum: true, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> benches/performance.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 146 | let mut options = SyncOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [optimized + debuginfo] target(s) in 48.43s [INFO] running `Command { std: "docker" "inspect" "b61c983b0c81f5e401a9e6a22065692e29510e2a7ad68478d3706a8b48fb6974", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b61c983b0c81f5e401a9e6a22065692e29510e2a7ad68478d3706a8b48fb6974", kill_on_drop: false }` [INFO] [stdout] b61c983b0c81f5e401a9e6a22065692e29510e2a7ad68478d3706a8b48fb6974