[INFO] fetching crate ripress 2.4.0... [INFO] linting ripress-2.4.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate ripress 2.4.0 into /workspace/builds/worker-7-tc1/source [INFO] removed /workspace/builds/worker-7-tc1/source/.cargo/config.toml [INFO] started tweaking crates.io crate ripress 2.4.0 [INFO] finished tweaking crates.io crate ripress 2.4.0 [INFO] tweaked toml for crates.io crate ripress 2.4.0 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate ripress 2.4.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate ripress 2.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded hyper-staticfile v0.10.1 [INFO] [stderr] Downloaded routerify_ng v0.3.0 [INFO] [stderr] Downloaded http-range v0.1.5 [INFO] [stderr] Downloaded ripress-derive v0.0.3 [INFO] [stderr] Downloaded reqwest v0.12.26 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 63f9eac35cbe4d0d85504bccc2a5b0f0247091ff2f18776704596b2ba581db68 [INFO] running `Command { std: "docker" "start" "-a" "63f9eac35cbe4d0d85504bccc2a5b0f0247091ff2f18776704596b2ba581db68", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "63f9eac35cbe4d0d85504bccc2a5b0f0247091ff2f18776704596b2ba581db68", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "63f9eac35cbe4d0d85504bccc2a5b0f0247091ff2f18776704596b2ba581db68", kill_on_drop: false }` [INFO] [stdout] 63f9eac35cbe4d0d85504bccc2a5b0f0247091ff2f18776704596b2ba581db68 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b27e3b53ba95e574ef91731e1e2203c572c075cb909e468654040417ac23a8fc [INFO] running `Command { std: "docker" "start" "-a" "b27e3b53ba95e574ef91731e1e2203c572c075cb909e468654040417ac23a8fc", kill_on_drop: false }` [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Checking socket2 v0.6.1 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Compiling zerocopy-derive v0.8.31 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling openssl-sys v0.9.111 [INFO] [stderr] Checking indexmap v2.12.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking ryu v1.0.21 [INFO] [stderr] Compiling openssl v0.10.75 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Checking serde_json v1.0.145 [INFO] [stderr] Compiling cookie v0.18.1 [INFO] [stderr] Checking uuid v1.19.0 [INFO] [stderr] Checking time v0.3.44 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking iri-string v0.7.9 [INFO] [stderr] Checking http-range v0.1.5 [INFO] [stderr] Checking cfb v0.7.3 [INFO] [stderr] Checking rustix v1.1.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking rustls-pki-types v1.13.2 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion-plot v0.6.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Checking infer v0.19.0 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Compiling ripress-derive v0.0.3 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Checking zerocopy v0.8.31 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking tempfile v3.23.0 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking criterion v0.7.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking tokio-util v0.7.17 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking h2 v0.4.12 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking hyper-util v0.1.19 [INFO] [stderr] Checking hyper-staticfile v0.10.1 [INFO] [stderr] Checking routerify_ng v0.3.0 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.26 [INFO] [stderr] Checking ripress v2.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/app/middlewares.rs:113:13 [INFO] [stdout] | [INFO] [stdout] 113 | path: path, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/app/middlewares.rs:238:13 [INFO] [stdout] | [INFO] [stdout] 238 | path: path, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/origin_url.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | / /// Returns the url string as a string slice. [INFO] [stdout] 26 | | [INFO] [stdout] | |_^ [INFO] [stdout] 27 | pub fn as_str(&self) -> &str { [INFO] [stdout] | ------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/origin_url.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | / /// Returns the value of the url string; [INFO] [stdout] 32 | | [INFO] [stdout] | |_^ [INFO] [stdout] 33 | pub fn value(&self) -> &String { [INFO] [stdout] | ------------ the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/body/mod.rs:80:5 [INFO] [stdout] | [INFO] [stdout] 80 | / /// [INFO] [stdout] 81 | | [INFO] [stdout] | |_^ [INFO] [stdout] 82 | pub fn len(&self) -> usize { [INFO] [stdout] | ---------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/body/form_data.rs:488:5 [INFO] [stdout] | [INFO] [stdout] 488 | / /// ``` [INFO] [stdout] 489 | | [INFO] [stdout] | |_^ [INFO] [stdout] 490 | pub fn from_comma_separated(query: &str) -> Result { [INFO] [stdout] | --------------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/route_params.rs:839:5 [INFO] [stdout] | [INFO] [stdout] 839 | / /// Panics if the param does not exist. [INFO] [stdout] 840 | | [INFO] [stdout] | |_^ [INFO] [stdout] 841 | fn index(&self, name: &str) -> &Self::Output { [INFO] [stdout] | -------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | / /// ``` [INFO] [stdout] 56 | | [INFO] [stdout] | |_^ [INFO] [stdout] 57 | pub fn new(data: impl AsRef<[u8]>) -> Self { [INFO] [stdout] | ---------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | / /// ``` [INFO] [stdout] 71 | | [INFO] [stdout] | |_^ [INFO] [stdout] 72 | pub fn as_bytes(&self) -> &[u8] { [INFO] [stdout] | --------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | / /// ``` [INFO] [stdout] 91 | | [INFO] [stdout] | |_^ [INFO] [stdout] 92 | pub fn as_str(&self) -> Result<&str, std::str::Utf8Error> { [INFO] [stdout] | ------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:201:5 [INFO] [stdout] | [INFO] [stdout] 201 | / /// ``` [INFO] [stdout] 202 | | [INFO] [stdout] | |_^ [INFO] [stdout] 203 | pub fn new() -> Self { [INFO] [stdout] | ---------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:221:5 [INFO] [stdout] | [INFO] [stdout] 221 | / /// ``` [INFO] [stdout] 222 | | [INFO] [stdout] | |_^ [INFO] [stdout] 223 | pub fn with_capacity(capacity: usize) -> Self { [INFO] [stdout] | -------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:242:5 [INFO] [stdout] | [INFO] [stdout] 242 | / /// ``` [INFO] [stdout] 243 | | [INFO] [stdout] | |_^ [INFO] [stdout] 244 | pub fn insert(&mut self, key: impl AsRef<[u8]>, value: impl AsRef<[u8]>) { [INFO] [stdout] | ------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:265:5 [INFO] [stdout] | [INFO] [stdout] 265 | / /// ``` [INFO] [stdout] 266 | | [INFO] [stdout] | |_^ [INFO] [stdout] 267 | pub fn insert_owned(&mut self, key: Vec, value: Vec) { [INFO] [stdout] | ------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:286:5 [INFO] [stdout] | [INFO] [stdout] 286 | / /// ``` [INFO] [stdout] 287 | | [INFO] [stdout] | |_^ [INFO] [stdout] 288 | pub fn get(&self, key: impl AsRef<[u8]>) -> Option { [INFO] [stdout] | ---------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:310:5 [INFO] [stdout] | [INFO] [stdout] 310 | / /// ``` [INFO] [stdout] 311 | | [INFO] [stdout] | |_^ [INFO] [stdout] 312 | pub fn remove(&mut self, key: impl AsRef<[u8]>) -> Option> { [INFO] [stdout] | ------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:329:5 [INFO] [stdout] | [INFO] [stdout] 329 | / /// ``` [INFO] [stdout] 330 | | [INFO] [stdout] | |_^ [INFO] [stdout] 331 | pub fn contains_key(&self, key: impl AsRef<[u8]>) -> bool { [INFO] [stdout] | ------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:349:5 [INFO] [stdout] | [INFO] [stdout] 349 | / /// ``` [INFO] [stdout] 350 | | [INFO] [stdout] | |_^ [INFO] [stdout] 351 | pub fn len(&self) -> usize { [INFO] [stdout] | ---------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:367:5 [INFO] [stdout] | [INFO] [stdout] 367 | / /// ``` [INFO] [stdout] 368 | | [INFO] [stdout] | |_^ [INFO] [stdout] 369 | pub fn is_empty(&self) -> bool { [INFO] [stdout] | --------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:387:5 [INFO] [stdout] | [INFO] [stdout] 387 | / /// ``` [INFO] [stdout] 388 | | [INFO] [stdout] | |_^ [INFO] [stdout] 389 | pub fn clear(&mut self) { [INFO] [stdout] | ------------ the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:410:5 [INFO] [stdout] | [INFO] [stdout] 410 | / /// ``` [INFO] [stdout] 411 | | [INFO] [stdout] | |_^ [INFO] [stdout] 412 | pub fn iter(&self) -> impl Iterator { [INFO] [stdout] | ----------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:430:5 [INFO] [stdout] | [INFO] [stdout] 430 | / /// ``` [INFO] [stdout] 431 | | [INFO] [stdout] | |_^ [INFO] [stdout] 432 | pub fn keys(&self) -> impl Iterator { [INFO] [stdout] | ----------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:450:5 [INFO] [stdout] | [INFO] [stdout] 450 | / /// ``` [INFO] [stdout] 451 | | [INFO] [stdout] | |_^ [INFO] [stdout] 452 | pub fn values(&self) -> impl Iterator { [INFO] [stdout] | ------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:473:5 [INFO] [stdout] | [INFO] [stdout] 473 | / /// ``` [INFO] [stdout] 474 | | [INFO] [stdout] | |_^ [INFO] [stdout] 475 | pub fn from_map(map: HashMap) -> Self [INFO] [stdout] | --------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:502:5 [INFO] [stdout] | [INFO] [stdout] 502 | / /// ``` [INFO] [stdout] 503 | | [INFO] [stdout] | |_^ [INFO] [stdout] 504 | pub fn byte_size(&self) -> usize { [INFO] [stdout] | ---------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:528:5 [INFO] [stdout] | [INFO] [stdout] 528 | / /// ``` [INFO] [stdout] 529 | | [INFO] [stdout] | |_^ [INFO] [stdout] 530 | pub fn shrink_to_fit(&mut self) { [INFO] [stdout] | -------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/mod.rs:443:5 [INFO] [stdout] | [INFO] [stdout] 443 | / /// ``` [INFO] [stdout] 444 | | [INFO] [stdout] | |_^ [INFO] [stdout] 445 | pub fn new() -> Self { [INFO] [stdout] | ---------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/mod.rs:480:5 [INFO] [stdout] | [INFO] [stdout] 480 | / /// ``` [INFO] [stdout] 481 | | [INFO] [stdout] | |_^ [INFO] [stdout] 482 | pub fn get_cookie(&self, name: &str) -> Option<&String> { [INFO] [stdout] | ----------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/mod.rs:522:5 [INFO] [stdout] | [INFO] [stdout] 522 | / /// ``` [INFO] [stdout] 523 | | [INFO] [stdout] | |_^ [INFO] [stdout] 524 | pub fn set_data>(&mut self, data_key: T, data_value: T) { [INFO] [stdout] | --------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/mod.rs:541:5 [INFO] [stdout] | [INFO] [stdout] 541 | / /// ``` [INFO] [stdout] 542 | | [INFO] [stdout] | |_^ [INFO] [stdout] 543 | pub fn get_all_data(&self) -> &RequestData { [INFO] [stdout] | ------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/mod.rs:562:5 [INFO] [stdout] | [INFO] [stdout] 562 | / /// ``` [INFO] [stdout] 563 | | [INFO] [stdout] | |_^ [INFO] [stdout] 564 | pub fn get_data>(&self, data_key: T) -> Option { [INFO] [stdout] | --------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/mod.rs:587:5 [INFO] [stdout] | [INFO] [stdout] 587 | / /// ``` [INFO] [stdout] 588 | | [INFO] [stdout] | |_^ [INFO] [stdout] 589 | pub fn is(&self, content_type: RequestBodyType) -> bool { [INFO] [stdout] | --------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/mod.rs:606:5 [INFO] [stdout] | [INFO] [stdout] 606 | / /// ``` [INFO] [stdout] 607 | | [INFO] [stdout] | |_^ [INFO] [stdout] 608 | pub fn bytes(&self) -> Result<&[u8], String> { [INFO] [stdout] | ------------ the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/mod.rs:652:5 [INFO] [stdout] | [INFO] [stdout] 652 | / /// ``` [INFO] [stdout] 653 | | [INFO] [stdout] | |_^ [INFO] [stdout] 654 | pub fn json(&self) -> Result [INFO] [stdout] | ----------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/mod.rs:684:5 [INFO] [stdout] | [INFO] [stdout] 684 | / /// Returns an `Result`, where `Ok(String)` contains the body if it is valid text, or `Err(error)` if it is not. [INFO] [stdout] 685 | | [INFO] [stdout] | |_^ [INFO] [stdout] 686 | pub fn text(&self) -> Result<&str, String> { [INFO] [stdout] | ----------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/mod.rs:716:5 [INFO] [stdout] | [INFO] [stdout] 716 | / /// Returns an `Result>`, where `Ok(HashMap)` contains the form_data if it is valid f... [INFO] [stdout] 717 | | [INFO] [stdout] | |_^ [INFO] [stdout] 718 | pub fn form_data(&self) -> Result<&FormData, String> { [INFO] [stdout] | ---------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/res/response_headers/mod.rs:861:5 [INFO] [stdout] | [INFO] [stdout] 861 | / /// headers.insert("X-Custom", "value"); [INFO] [stdout] 862 | | [INFO] [stdout] | |_^ [INFO] [stdout] ... [INFO] [stdout] 874 | pub fn keys(&self) -> Vec<&HeaderName> { [INFO] [stdout] | ----------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the documentation should include the empty line include it in the comment [INFO] [stdout] | [INFO] [stdout] 862 | /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/res/mod.rs:214:5 [INFO] [stdout] | [INFO] [stdout] 214 | / /// ``` [INFO] [stdout] 215 | | [INFO] [stdout] | |_^ [INFO] [stdout] 216 | pub fn new() -> Self { [INFO] [stdout] | ---------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/res/mod.rs:343:5 [INFO] [stdout] | [INFO] [stdout] 343 | / /// ``` [INFO] [stdout] 344 | | [INFO] [stdout] | |_^ [INFO] [stdout] 345 | pub fn text>(mut self, text: T) -> Self { [INFO] [stdout] | ----------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/res/mod.rs:379:5 [INFO] [stdout] | [INFO] [stdout] 379 | / /// ``` [INFO] [stdout] 380 | | [INFO] [stdout] | |_^ [INFO] [stdout] 381 | pub fn json(mut self, json: T) -> Self { [INFO] [stdout] | ----------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/res/mod.rs:411:5 [INFO] [stdout] | [INFO] [stdout] 411 | / /// ``` [INFO] [stdout] 412 | | [INFO] [stdout] | |_^ [INFO] [stdout] 413 | pub fn bytes>(mut self, bytes: T) -> Self { [INFO] [stdout] | ------------ the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/res/mod.rs:427:5 [INFO] [stdout] | [INFO] [stdout] 427 | / /// ``` [INFO] [stdout] 428 | | [INFO] [stdout] | |_^ [INFO] [stdout] 429 | pub fn set_header>( [INFO] [stdout] | ----------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/res/mod.rs:458:5 [INFO] [stdout] | [INFO] [stdout] 458 | / /// ``` [INFO] [stdout] 459 | | [INFO] [stdout] | |_^ [INFO] [stdout] 460 | pub fn set_cookie( [INFO] [stdout] | ----------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/res/mod.rs:492:5 [INFO] [stdout] | [INFO] [stdout] 492 | / /// ``` [INFO] [stdout] 493 | | [INFO] [stdout] | |_^ [INFO] [stdout] 494 | pub fn clear_cookie(mut self, key: &'static str) -> Self { [INFO] [stdout] | ------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/res/mod.rs:521:5 [INFO] [stdout] | [INFO] [stdout] 521 | / /// ``` [INFO] [stdout] 522 | | [INFO] [stdout] | |_^ [INFO] [stdout] 523 | pub fn redirect(mut self, path: &'static str) -> Self { [INFO] [stdout] | --------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/res/mod.rs:545:5 [INFO] [stdout] | [INFO] [stdout] 545 | / /// ``` [INFO] [stdout] 546 | | [INFO] [stdout] | |_^ [INFO] [stdout] 547 | pub fn permanent_redirect(mut self, path: &'static str) -> Self { [INFO] [stdout] | ------------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/res/mod.rs:575:5 [INFO] [stdout] | [INFO] [stdout] 575 | / /// ``` [INFO] [stdout] 576 | | [INFO] [stdout] | |_^ [INFO] [stdout] 577 | pub fn html(mut self, html: &str) -> Self { [INFO] [stdout] | ----------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/middlewares/cors.rs:223:1 [INFO] [stdout] | [INFO] [stdout] 223 | / /// - Follows browser security model requirements [INFO] [stdout] 224 | | [INFO] [stdout] | |_^ [INFO] [stdout] ... [INFO] [stdout] 252 | pub struct CorsConfig { [INFO] [stdout] | --------------------- the comment documents this struct [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the documentation should include the empty line include it in the comment [INFO] [stdout] | [INFO] [stdout] 224 | /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/middlewares/rate_limiter.rs:295:1 [INFO] [stdout] | [INFO] [stdout] 295 | / /// - Implement proper error handling in client applications [INFO] [stdout] 296 | | [INFO] [stdout] | |_^ [INFO] [stdout] ... [INFO] [stdout] 317 | pub struct RateLimiterConfig { [INFO] [stdout] | ---------------------------- the comment documents this struct [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the documentation should include the empty line include it in the comment [INFO] [stdout] | [INFO] [stdout] 296 | /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/router/mod.rs:141:5 [INFO] [stdout] | [INFO] [stdout] 141 | / /// ``` [INFO] [stdout] 142 | | [INFO] [stdout] | |_^ [INFO] [stdout] 143 | #[deprecated(since = "1.9.12", note = "use `app.router` instead")] [INFO] [stdout] 144 | pub fn register(self, app: &mut App) { [INFO] [stdout] | --------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/app/middlewares.rs:113:13 [INFO] [stdout] | [INFO] [stdout] 113 | path: path, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/app/middlewares.rs:238:13 [INFO] [stdout] | [INFO] [stdout] 238 | path: path, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/origin_url.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | / /// Returns the url string as a string slice. [INFO] [stdout] 26 | | [INFO] [stdout] | |_^ [INFO] [stdout] 27 | pub fn as_str(&self) -> &str { [INFO] [stdout] | ------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/origin_url.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | / /// Returns the value of the url string; [INFO] [stdout] 32 | | [INFO] [stdout] | |_^ [INFO] [stdout] 33 | pub fn value(&self) -> &String { [INFO] [stdout] | ------------ the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/body/mod.rs:80:5 [INFO] [stdout] | [INFO] [stdout] 80 | / /// [INFO] [stdout] 81 | | [INFO] [stdout] | |_^ [INFO] [stdout] 82 | pub fn len(&self) -> usize { [INFO] [stdout] | ---------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/body/form_data.rs:488:5 [INFO] [stdout] | [INFO] [stdout] 488 | / /// ``` [INFO] [stdout] 489 | | [INFO] [stdout] | |_^ [INFO] [stdout] 490 | pub fn from_comma_separated(query: &str) -> Result { [INFO] [stdout] | --------------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/route_params.rs:839:5 [INFO] [stdout] | [INFO] [stdout] 839 | / /// Panics if the param does not exist. [INFO] [stdout] 840 | | [INFO] [stdout] | |_^ [INFO] [stdout] 841 | fn index(&self, name: &str) -> &Self::Output { [INFO] [stdout] | -------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | / /// ``` [INFO] [stdout] 56 | | [INFO] [stdout] | |_^ [INFO] [stdout] 57 | pub fn new(data: impl AsRef<[u8]>) -> Self { [INFO] [stdout] | ---------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | / /// ``` [INFO] [stdout] 71 | | [INFO] [stdout] | |_^ [INFO] [stdout] 72 | pub fn as_bytes(&self) -> &[u8] { [INFO] [stdout] | --------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | / /// ``` [INFO] [stdout] 91 | | [INFO] [stdout] | |_^ [INFO] [stdout] 92 | pub fn as_str(&self) -> Result<&str, std::str::Utf8Error> { [INFO] [stdout] | ------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:201:5 [INFO] [stdout] | [INFO] [stdout] 201 | / /// ``` [INFO] [stdout] 202 | | [INFO] [stdout] | |_^ [INFO] [stdout] 203 | pub fn new() -> Self { [INFO] [stdout] | ---------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:221:5 [INFO] [stdout] | [INFO] [stdout] 221 | / /// ``` [INFO] [stdout] 222 | | [INFO] [stdout] | |_^ [INFO] [stdout] 223 | pub fn with_capacity(capacity: usize) -> Self { [INFO] [stdout] | -------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:242:5 [INFO] [stdout] | [INFO] [stdout] 242 | / /// ``` [INFO] [stdout] 243 | | [INFO] [stdout] | |_^ [INFO] [stdout] 244 | pub fn insert(&mut self, key: impl AsRef<[u8]>, value: impl AsRef<[u8]>) { [INFO] [stdout] | ------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:265:5 [INFO] [stdout] | [INFO] [stdout] 265 | / /// ``` [INFO] [stdout] 266 | | [INFO] [stdout] | |_^ [INFO] [stdout] 267 | pub fn insert_owned(&mut self, key: Vec, value: Vec) { [INFO] [stdout] | ------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:286:5 [INFO] [stdout] | [INFO] [stdout] 286 | / /// ``` [INFO] [stdout] 287 | | [INFO] [stdout] | |_^ [INFO] [stdout] 288 | pub fn get(&self, key: impl AsRef<[u8]>) -> Option { [INFO] [stdout] | ---------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:310:5 [INFO] [stdout] | [INFO] [stdout] 310 | / /// ``` [INFO] [stdout] 311 | | [INFO] [stdout] | |_^ [INFO] [stdout] 312 | pub fn remove(&mut self, key: impl AsRef<[u8]>) -> Option> { [INFO] [stdout] | ------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:329:5 [INFO] [stdout] | [INFO] [stdout] 329 | / /// ``` [INFO] [stdout] 330 | | [INFO] [stdout] | |_^ [INFO] [stdout] 331 | pub fn contains_key(&self, key: impl AsRef<[u8]>) -> bool { [INFO] [stdout] | ------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:349:5 [INFO] [stdout] | [INFO] [stdout] 349 | / /// ``` [INFO] [stdout] 350 | | [INFO] [stdout] | |_^ [INFO] [stdout] 351 | pub fn len(&self) -> usize { [INFO] [stdout] | ---------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:367:5 [INFO] [stdout] | [INFO] [stdout] 367 | / /// ``` [INFO] [stdout] 368 | | [INFO] [stdout] | |_^ [INFO] [stdout] 369 | pub fn is_empty(&self) -> bool { [INFO] [stdout] | --------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:387:5 [INFO] [stdout] | [INFO] [stdout] 387 | / /// ``` [INFO] [stdout] 388 | | [INFO] [stdout] | |_^ [INFO] [stdout] 389 | pub fn clear(&mut self) { [INFO] [stdout] | ------------ the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:410:5 [INFO] [stdout] | [INFO] [stdout] 410 | / /// ``` [INFO] [stdout] 411 | | [INFO] [stdout] | |_^ [INFO] [stdout] 412 | pub fn iter(&self) -> impl Iterator { [INFO] [stdout] | ----------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:430:5 [INFO] [stdout] | [INFO] [stdout] 430 | / /// ``` [INFO] [stdout] 431 | | [INFO] [stdout] | |_^ [INFO] [stdout] 432 | pub fn keys(&self) -> impl Iterator { [INFO] [stdout] | ----------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:450:5 [INFO] [stdout] | [INFO] [stdout] 450 | / /// ``` [INFO] [stdout] 451 | | [INFO] [stdout] | |_^ [INFO] [stdout] 452 | pub fn values(&self) -> impl Iterator { [INFO] [stdout] | ------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:473:5 [INFO] [stdout] | [INFO] [stdout] 473 | / /// ``` [INFO] [stdout] 474 | | [INFO] [stdout] | |_^ [INFO] [stdout] 475 | pub fn from_map(map: HashMap) -> Self [INFO] [stdout] | --------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:502:5 [INFO] [stdout] | [INFO] [stdout] 502 | / /// ``` [INFO] [stdout] 503 | | [INFO] [stdout] | |_^ [INFO] [stdout] 504 | pub fn byte_size(&self) -> usize { [INFO] [stdout] | ---------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/request_data.rs:528:5 [INFO] [stdout] | [INFO] [stdout] 528 | / /// ``` [INFO] [stdout] 529 | | [INFO] [stdout] | |_^ [INFO] [stdout] 530 | pub fn shrink_to_fit(&mut self) { [INFO] [stdout] | -------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/mod.rs:443:5 [INFO] [stdout] | [INFO] [stdout] 443 | / /// ``` [INFO] [stdout] 444 | | [INFO] [stdout] | |_^ [INFO] [stdout] 445 | pub fn new() -> Self { [INFO] [stdout] | ---------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/mod.rs:480:5 [INFO] [stdout] | [INFO] [stdout] 480 | / /// ``` [INFO] [stdout] 481 | | [INFO] [stdout] | |_^ [INFO] [stdout] 482 | pub fn get_cookie(&self, name: &str) -> Option<&String> { [INFO] [stdout] | ----------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/mod.rs:522:5 [INFO] [stdout] | [INFO] [stdout] 522 | / /// ``` [INFO] [stdout] 523 | | [INFO] [stdout] | |_^ [INFO] [stdout] 524 | pub fn set_data>(&mut self, data_key: T, data_value: T) { [INFO] [stdout] | --------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/mod.rs:541:5 [INFO] [stdout] | [INFO] [stdout] 541 | / /// ``` [INFO] [stdout] 542 | | [INFO] [stdout] | |_^ [INFO] [stdout] 543 | pub fn get_all_data(&self) -> &RequestData { [INFO] [stdout] | ------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/mod.rs:562:5 [INFO] [stdout] | [INFO] [stdout] 562 | / /// ``` [INFO] [stdout] 563 | | [INFO] [stdout] | |_^ [INFO] [stdout] 564 | pub fn get_data>(&self, data_key: T) -> Option { [INFO] [stdout] | --------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/mod.rs:587:5 [INFO] [stdout] | [INFO] [stdout] 587 | / /// ``` [INFO] [stdout] 588 | | [INFO] [stdout] | |_^ [INFO] [stdout] 589 | pub fn is(&self, content_type: RequestBodyType) -> bool { [INFO] [stdout] | --------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/mod.rs:606:5 [INFO] [stdout] | [INFO] [stdout] 606 | / /// ``` [INFO] [stdout] 607 | | [INFO] [stdout] | |_^ [INFO] [stdout] 608 | pub fn bytes(&self) -> Result<&[u8], String> { [INFO] [stdout] | ------------ the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/mod.rs:652:5 [INFO] [stdout] | [INFO] [stdout] 652 | / /// ``` [INFO] [stdout] 653 | | [INFO] [stdout] | |_^ [INFO] [stdout] 654 | pub fn json(&self) -> Result [INFO] [stdout] | ----------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/mod.rs:684:5 [INFO] [stdout] | [INFO] [stdout] 684 | / /// Returns an `Result`, where `Ok(String)` contains the body if it is valid text, or `Err(error)` if it is not. [INFO] [stdout] 685 | | [INFO] [stdout] | |_^ [INFO] [stdout] 686 | pub fn text(&self) -> Result<&str, String> { [INFO] [stdout] | ----------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/req/mod.rs:716:5 [INFO] [stdout] | [INFO] [stdout] 716 | / /// Returns an `Result>`, where `Ok(HashMap)` contains the form_data if it is valid f... [INFO] [stdout] 717 | | [INFO] [stdout] | |_^ [INFO] [stdout] 718 | pub fn form_data(&self) -> Result<&FormData, String> { [INFO] [stdout] | ---------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/res/response_headers/mod.rs:861:5 [INFO] [stdout] | [INFO] [stdout] 861 | / /// headers.insert("X-Custom", "value"); [INFO] [stdout] 862 | | [INFO] [stdout] | |_^ [INFO] [stdout] ... [INFO] [stdout] 874 | pub fn keys(&self) -> Vec<&HeaderName> { [INFO] [stdout] | ----------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the documentation should include the empty line include it in the comment [INFO] [stdout] | [INFO] [stdout] 862 | /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/res/mod.rs:214:5 [INFO] [stdout] | [INFO] [stdout] 214 | / /// ``` [INFO] [stdout] 215 | | [INFO] [stdout] | |_^ [INFO] [stdout] 216 | pub fn new() -> Self { [INFO] [stdout] | ---------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/res/mod.rs:343:5 [INFO] [stdout] | [INFO] [stdout] 343 | / /// ``` [INFO] [stdout] 344 | | [INFO] [stdout] | |_^ [INFO] [stdout] 345 | pub fn text>(mut self, text: T) -> Self { [INFO] [stdout] | ----------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/res/mod.rs:379:5 [INFO] [stdout] | [INFO] [stdout] 379 | / /// ``` [INFO] [stdout] 380 | | [INFO] [stdout] | |_^ [INFO] [stdout] 381 | pub fn json(mut self, json: T) -> Self { [INFO] [stdout] | ----------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/res/mod.rs:411:5 [INFO] [stdout] | [INFO] [stdout] 411 | / /// ``` [INFO] [stdout] 412 | | [INFO] [stdout] | |_^ [INFO] [stdout] 413 | pub fn bytes>(mut self, bytes: T) -> Self { [INFO] [stdout] | ------------ the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/res/mod.rs:427:5 [INFO] [stdout] | [INFO] [stdout] 427 | / /// ``` [INFO] [stdout] 428 | | [INFO] [stdout] | |_^ [INFO] [stdout] 429 | pub fn set_header>( [INFO] [stdout] | ----------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/res/mod.rs:458:5 [INFO] [stdout] | [INFO] [stdout] 458 | / /// ``` [INFO] [stdout] 459 | | [INFO] [stdout] | |_^ [INFO] [stdout] 460 | pub fn set_cookie( [INFO] [stdout] | ----------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/res/mod.rs:492:5 [INFO] [stdout] | [INFO] [stdout] 492 | / /// ``` [INFO] [stdout] 493 | | [INFO] [stdout] | |_^ [INFO] [stdout] 494 | pub fn clear_cookie(mut self, key: &'static str) -> Self { [INFO] [stdout] | ------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/res/mod.rs:521:5 [INFO] [stdout] | [INFO] [stdout] 521 | / /// ``` [INFO] [stdout] 522 | | [INFO] [stdout] | |_^ [INFO] [stdout] 523 | pub fn redirect(mut self, path: &'static str) -> Self { [INFO] [stdout] | --------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/res/mod.rs:545:5 [INFO] [stdout] | [INFO] [stdout] 545 | / /// ``` [INFO] [stdout] 546 | | [INFO] [stdout] | |_^ [INFO] [stdout] 547 | pub fn permanent_redirect(mut self, path: &'static str) -> Self { [INFO] [stdout] | ------------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/res/mod.rs:575:5 [INFO] [stdout] | [INFO] [stdout] 575 | / /// ``` [INFO] [stdout] 576 | | [INFO] [stdout] | |_^ [INFO] [stdout] 577 | pub fn html(mut self, html: &str) -> Self { [INFO] [stdout] | ----------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/middlewares/cors.rs:223:1 [INFO] [stdout] | [INFO] [stdout] 223 | / /// - Follows browser security model requirements [INFO] [stdout] 224 | | [INFO] [stdout] | |_^ [INFO] [stdout] ... [INFO] [stdout] 252 | pub struct CorsConfig { [INFO] [stdout] | --------------------- the comment documents this struct [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the documentation should include the empty line include it in the comment [INFO] [stdout] | [INFO] [stdout] 224 | /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/middlewares/rate_limiter.rs:295:1 [INFO] [stdout] | [INFO] [stdout] 295 | / /// - Implement proper error handling in client applications [INFO] [stdout] 296 | | [INFO] [stdout] | |_^ [INFO] [stdout] ... [INFO] [stdout] 317 | pub struct RateLimiterConfig { [INFO] [stdout] | ---------------------------- the comment documents this struct [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the documentation should include the empty line include it in the comment [INFO] [stdout] | [INFO] [stdout] 296 | /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/router/mod.rs:141:5 [INFO] [stdout] | [INFO] [stdout] 141 | / /// ``` [INFO] [stdout] 142 | | [INFO] [stdout] | |_^ [INFO] [stdout] 143 | #[deprecated(since = "1.9.12", note = "use `app.router` instead")] [INFO] [stdout] 144 | pub fn register(self, app: &mut App) { [INFO] [stdout] | --------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/tests/app_test.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | use reqwest; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `App` [INFO] [stdout] --> src/app/mod.rs:139:5 [INFO] [stdout] | [INFO] [stdout] 139 | / pub fn new() -> Self { [INFO] [stdout] 140 | | App { [INFO] [stdout] 141 | | routes: HashMap::new(), [INFO] [stdout] 142 | | middlewares: Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 145 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 126 + impl Default for App { [INFO] [stdout] 127 + fn default() -> Self { [INFO] [stdout] 128 + Self::new() [INFO] [stdout] 129 + } [INFO] [stdout] 130 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/app/mod.rs:256:38 [INFO] [stdout] | [INFO] [stdout] 256 | for (method, handler) in methods.to_owned() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: use: `methods.iter().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:258:44 [INFO] [stdout] | [INFO] [stdout] 258 | self.add_route(method, &base_path, move |req: HttpRequest, res| { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `base_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant redefinition of a binding `http2_enabled` [INFO] [stdout] --> src/app/mod.rs:603:21 [INFO] [stdout] | [INFO] [stdout] 603 | let http2_enabled = http2_enabled; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: `http2_enabled` is initially defined here [INFO] [stdout] --> src/app/mod.rs:581:13 [INFO] [stdout] | [INFO] [stdout] 581 | let http2_enabled = self.settings.http2_config.is_enabled; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_locals [INFO] [stdout] = note: `#[warn(clippy::redundant_locals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/app/mod.rs:628:13 [INFO] [stdout] | [INFO] [stdout] 628 | / return Box::new(ApiError::Generic( [INFO] [stdout] 629 | | HttpResponse::new() [INFO] [stdout] 630 | | .internal_server_error() [INFO] [stdout] 631 | | .text("Unhandled error"), [INFO] [stdout] 632 | | )); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 628 ~ Box::new(ApiError::Generic( [INFO] [stdout] 629 + HttpResponse::new() [INFO] [stdout] 630 + .internal_server_error() [INFO] [stdout] 631 + .text("Unhandled error"), [INFO] [stdout] 632 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/app/mod.rs:755:21 [INFO] [stdout] | [INFO] [stdout] 755 | / std::io::Error::new( [INFO] [stdout] 756 | | std::io::ErrorKind::Other, [INFO] [stdout] 757 | | format!("Failed to collect body: {}", e), [INFO] [stdout] 758 | | ) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 755 ~ std::io::Error::other( [INFO] [stdout] 756 ~ format!("Failed to collect body: {}", e), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/req/conversions.rs:42:22 [INFO] [stdout] | [INFO] [stdout] 42 | .unwrap_or(String::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.filter_map(..)` can be written more simply using `.map(..)` [INFO] [stdout] --> src/req/conversions.rs:50:14 [INFO] [stdout] | [INFO] [stdout] 50 | .filter_map(|(key, value)| Some((key.to_string(), value.to_string()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stdout] = note: `#[warn(clippy::unnecessary_filter_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/req/conversions.rs:120:53 [INFO] [stdout] | [INFO] [stdout] 120 | .and_then(|ct| extract_boundary(&ct)); [INFO] [stdout] | ^^^ help: change this to: `ct` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/req/conversions.rs:220:22 [INFO] [stdout] | [INFO] [stdout] 220 | .unwrap_or(String::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.filter_map(..)` can be written more simply using `.map(..)` [INFO] [stdout] --> src/req/conversions.rs:229:14 [INFO] [stdout] | [INFO] [stdout] 229 | .filter_map(|(key, value)| Some((key.to_string(), value.to_string()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/req/conversions.rs:236:55 [INFO] [stdout] | [INFO] [stdout] 236 | let cookies = Self::get_cookies_from_req_info(&req_info); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `req_info` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/req/conversions.rs:428:60 [INFO] [stdout] | [INFO] [stdout] 428 | hyper::header::HeaderValue::from_bytes(&cookie)?, [INFO] [stdout] | ^^^^^^^ help: change this to: `cookie` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/req/query_params.rs:188:14 [INFO] [stdout] | [INFO] [stdout] 188 | .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/req/query_params.rs:309:9 [INFO] [stdout] | [INFO] [stdout] 309 | self.get(name).map_or(false, |v| !v.is_empty()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 309 - self.get(name).map_or(false, |v| !v.is_empty()) [INFO] [stdout] 309 + self.get(name).is_some_and(|v| !v.is_empty()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `RequestBody` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/req/body/mod.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/req/body/text_data.rs:625:45 [INFO] [stdout] | [INFO] [stdout] 625 | while !self.inner.is_empty() && !std::str::from_utf8(&self.inner).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::str::from_utf8(&self.inner).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/req/mod.rs:565:23 [INFO] [stdout] | [INFO] [stdout] 565 | self.data.get(&data_key.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `data_key.into()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/req/mod.rs:590:9 [INFO] [stdout] | [INFO] [stdout] 590 | return self.body.body_type() == content_type; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 590 - return self.body.body_type() == content_type; [INFO] [stdout] 590 + self.body.body_type() == content_type [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/req/mod.rs:620:33 [INFO] [stdout] | [INFO] [stdout] 620 | body.body_type().to_string(), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TEXT` contains a capitalized acronym [INFO] [stdout] --> src/res/response_body.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | TEXT(String), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `HTML` contains a capitalized acronym [INFO] [stdout] --> src/res/response_body.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | HTML(String), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Html` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JSON` contains a capitalized acronym [INFO] [stdout] --> src/res/response_body.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | JSON(serde_json::Value), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Json` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BINARY` contains a capitalized acronym [INFO] [stdout] --> src/res/response_body.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | BINARY(Bytes), [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Binary` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TEXT` contains a capitalized acronym [INFO] [stdout] --> src/res/response_body.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 63 | TEXT, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JSON` contains a capitalized acronym [INFO] [stdout] --> src/res/response_body.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 64 | JSON, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Json` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `HTML` contains a capitalized acronym [INFO] [stdout] --> src/res/response_body.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | HTML, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Html` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BINARY` contains a capitalized acronym [INFO] [stdout] --> src/res/response_body.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 66 | BINARY, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Binary` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.stream` after checking its variant with `is_some` [INFO] [stdout] --> src/res/conversions.rs:193:17 [INFO] [stdout] | [INFO] [stdout] 132 | if self.stream.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = self.stream` [INFO] [stdout] ... [INFO] [stdout] 193 | self.stream.unwrap().collect().await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/res/conversions.rs:211:13 [INFO] [stdout] | [INFO] [stdout] 211 | return Ok(hyper_response); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 211 - return Ok(hyper_response); [INFO] [stdout] 211 + Ok(hyper_response) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/res/conversions.rs:297:13 [INFO] [stdout] | [INFO] [stdout] 297 | return Ok(response); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 297 - return Ok(response); [INFO] [stdout] 297 + Ok(response) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/res/conversions.rs:156:35 [INFO] [stdout] | [INFO] [stdout] 156 | ... .path(c.options.path.as_deref().unwrap_or("/")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `c.options.path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] = note: `#[warn(clippy::needless_option_as_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/res/conversions.rs:157:47 [INFO] [stdout] | [INFO] [stdout] 157 | if let Some(domain) = c.options.domain.as_deref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `c.options.domain` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `bytes::Bytes` [INFO] [stdout] --> src/res/conversions.rs:236:38 [INFO] [stdout] | [INFO] [stdout] 236 | .body(Full::from(Bytes::from(bytes))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider removing `Bytes::from()`: `bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/res/conversions.rs:257:35 [INFO] [stdout] | [INFO] [stdout] 257 | ... .path(c.options.path.as_deref().unwrap_or("/")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `c.options.path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/res/conversions.rs:259:47 [INFO] [stdout] | [INFO] [stdout] 259 | if let Some(domain) = c.options.domain.as_deref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `c.options.domain` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/res/mod.rs:171:9 [INFO] [stdout] | [INFO] [stdout] 171 | Option> + Send + 'static>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `HttpResponse` [INFO] [stdout] --> src/res/mod.rs:216:5 [INFO] [stdout] | [INFO] [stdout] 216 | / pub fn new() -> Self { [INFO] [stdout] 217 | | Self { [INFO] [stdout] 218 | | status_code: StatusCode::Ok, [INFO] [stdout] 219 | | body: ResponseBody::TEXT(String::new()), [INFO] [stdout] ... | [INFO] [stdout] 224 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 198 + impl Default for HttpResponse { [INFO] [stdout] 199 + fn default() -> Self { [INFO] [stdout] 200 + Self::new() [INFO] [stdout] 201 + } [INFO] [stdout] 202 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/res/mod.rs:253:9 [INFO] [stdout] | [INFO] [stdout] 253 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 253 - return self; [INFO] [stdout] 253 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/res/mod.rs:259:9 [INFO] [stdout] | [INFO] [stdout] 259 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 259 - return self; [INFO] [stdout] 259 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/res/mod.rs:265:9 [INFO] [stdout] | [INFO] [stdout] 265 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 265 - return self; [INFO] [stdout] 265 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/res/mod.rs:271:9 [INFO] [stdout] | [INFO] [stdout] 271 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 271 - return self; [INFO] [stdout] 271 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/res/mod.rs:277:9 [INFO] [stdout] | [INFO] [stdout] 277 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 277 - return self; [INFO] [stdout] 277 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/res/mod.rs:283:9 [INFO] [stdout] | [INFO] [stdout] 283 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 283 - return self; [INFO] [stdout] 283 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/res/mod.rs:289:9 [INFO] [stdout] | [INFO] [stdout] 289 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 289 - return self; [INFO] [stdout] 289 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/res/mod.rs:295:9 [INFO] [stdout] | [INFO] [stdout] 295 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 295 - return self; [INFO] [stdout] 295 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/res/mod.rs:301:9 [INFO] [stdout] | [INFO] [stdout] 301 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 301 - return self; [INFO] [stdout] 301 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/res/mod.rs:307:9 [INFO] [stdout] | [INFO] [stdout] 307 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 307 - return self; [INFO] [stdout] 307 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/res/mod.rs:313:9 [INFO] [stdout] | [INFO] [stdout] 313 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 313 - return self; [INFO] [stdout] 313 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/res/mod.rs:347:9 [INFO] [stdout] | [INFO] [stdout] 347 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 347 - return self; [INFO] [stdout] 347 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/res/mod.rs:383:9 [INFO] [stdout] | [INFO] [stdout] 383 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 383 - return self; [INFO] [stdout] 383 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/res/mod.rs:415:9 [INFO] [stdout] | [INFO] [stdout] 415 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 415 - return self; [INFO] [stdout] 415 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helpers.rs:39:17 [INFO] [stdout] | [INFO] [stdout] 39 | return Ok(hyper_req); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return Ok(hyper_req); [INFO] [stdout] 39 + Ok(hyper_req) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helpers.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 42 | return Err(ApiError::Generic(res)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return Err(ApiError::Generic(res)); [INFO] [stdout] 42 + Err(ApiError::Generic(res)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `app::api_error::ApiError` [INFO] [stdout] --> src/helpers.rs:31:19 [INFO] [stdout] | [INFO] [stdout] 31 | .await [INFO] [stdout] | ___________________^ [INFO] [stdout] 32 | | .map_err(ApiError::from)?; [INFO] [stdout] | |____________________________________^ help: consider removing [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helpers.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 81 | return Ok(hyper_res); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 81 - return Ok(hyper_res); [INFO] [stdout] 81 + Ok(hyper_res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/helpers.rs:178:6 [INFO] [stdout] | [INFO] [stdout] 178 | ) -> (Vec<(&'a str, &'a str)>, Vec<(Vec, Option<&'a str>)>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `split_once` [INFO] [stdout] --> src/helpers.rs:225:35 [INFO] [stdout] | [INFO] [stdout] 225 | let after_colon = l.splitn(2, ':').nth(1).unwrap_or("").trim(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `l.split_once(':').map(|x| x.1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_split_once [INFO] [stdout] = note: `#[warn(clippy::manual_split_once)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/helpers.rs:238:32 [INFO] [stdout] | [INFO] [stdout] 238 | if let Some(_) = val2.find('"') { [INFO] [stdout] | -------^^^^^^^----------------- help: try: `if val2.find('"').is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/middlewares/cors.rs:225:5 [INFO] [stdout] | [INFO] [stdout] 225 | /// Configuration struct for the CORS Middleware [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 225 | /// Configuration struct for the CORS Middleware [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/middlewares/rate_limiter.rs:297:5 [INFO] [stdout] | [INFO] [stdout] 297 | /// Configuration struct for the rate limiter middleware [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 297 | /// Configuration struct for the rate limiter middleware [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/middlewares/shield/config.rs:526:1 [INFO] [stdout] | [INFO] [stdout] 526 | / impl Default for CrossOriginOpenerPolicy { [INFO] [stdout] 527 | | fn default() -> Self { [INFO] [stdout] 528 | | Self::SameOrigin [INFO] [stdout] 529 | | } [INFO] [stdout] 530 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 517 + #[derive(Default)] [INFO] [stdout] 518 | pub enum CrossOriginOpenerPolicy { [INFO] [stdout] 519 | /// Isolate from all cross-origin documents (most secure) [INFO] [stdout] 520 ~ #[default] [INFO] [stdout] 521 ~ SameOrigin, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/middlewares/shield/config.rs:574:1 [INFO] [stdout] | [INFO] [stdout] 574 | / impl Default for CrossOriginResourcePolicy { [INFO] [stdout] 575 | | fn default() -> Self { [INFO] [stdout] 576 | | Self::SameOrigin [INFO] [stdout] 577 | | } [INFO] [stdout] 578 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 565 + #[derive(Default)] [INFO] [stdout] 566 | pub enum CrossOriginResourcePolicy { [INFO] [stdout] 567 | /// Only allow same-origin resource inclusion (most secure) [INFO] [stdout] 568 ~ #[default] [INFO] [stdout] 569 ~ SameOrigin, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/middlewares/shield/config.rs:722:1 [INFO] [stdout] | [INFO] [stdout] 722 | / impl Default for CrossOriginEmbedderPolicy { [INFO] [stdout] 723 | | fn default() -> Self { [INFO] [stdout] 724 | | Self::UnsafeNone [INFO] [stdout] 725 | | } [INFO] [stdout] 726 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 715 + #[derive(Default)] [INFO] [stdout] 716 | pub enum CrossOriginEmbedderPolicy { [INFO] [stdout] 717 | /// Require CORP header on all cross-origin resources [INFO] [stdout] 718 | RequireCorp, [INFO] [stdout] 719 | /// No requirements (maintains compatibility) [INFO] [stdout] 720 ~ #[default] [INFO] [stdout] 721 ~ UnsafeNone, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/middlewares/shield/config.rs:833:1 [INFO] [stdout] | [INFO] [stdout] 833 | / impl Default for ShieldConfig { [INFO] [stdout] 834 | | fn default() -> Self { [INFO] [stdout] 835 | | Self { [INFO] [stdout] 836 | | content_security_policy: ContentSecurityPolicy::default(), [INFO] [stdout] ... | [INFO] [stdout] 853 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 27 + #[derive(Default)] [INFO] [stdout] 28 | pub struct ShieldConfig { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/middlewares/shield/mod.rs:542:47 [INFO] [stdout] | [INFO] [stdout] 542 | .insert("cross-origin-opener-policy", header_value.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `header_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/middlewares/shield/mod.rs:560:49 [INFO] [stdout] | [INFO] [stdout] 560 | .insert("cross-origin-resource-policy", header_value.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `header_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/middlewares/shield/mod.rs:577:49 [INFO] [stdout] | [INFO] [stdout] 577 | .insert("Cross-Origin-Embedder-Policy", header_value.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `header_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/types.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | / match method { [INFO] [stdout] 53 | | &Method::GET => HttpMethods::GET, [INFO] [stdout] 54 | | &Method::POST => HttpMethods::POST, [INFO] [stdout] 55 | | &Method::PUT => HttpMethods::PUT, [INFO] [stdout] ... | [INFO] [stdout] 60 | | _ => HttpMethods::GET, [INFO] [stdout] 61 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 52 ~ match *method { [INFO] [stdout] 53 ~ Method::GET => HttpMethods::GET, [INFO] [stdout] 54 ~ Method::POST => HttpMethods::POST, [INFO] [stdout] 55 ~ Method::PUT => HttpMethods::PUT, [INFO] [stdout] 56 ~ Method::DELETE => HttpMethods::DELETE, [INFO] [stdout] 57 ~ Method::PATCH => HttpMethods::PATCH, [INFO] [stdout] 58 ~ Method::HEAD => HttpMethods::HEAD, [INFO] [stdout] 59 ~ Method::OPTIONS => HttpMethods::OPTIONS, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `App` [INFO] [stdout] --> src/app/mod.rs:139:5 [INFO] [stdout] | [INFO] [stdout] 139 | / pub fn new() -> Self { [INFO] [stdout] 140 | | App { [INFO] [stdout] 141 | | routes: HashMap::new(), [INFO] [stdout] 142 | | middlewares: Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 145 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 126 + impl Default for App { [INFO] [stdout] 127 + fn default() -> Self { [INFO] [stdout] 128 + Self::new() [INFO] [stdout] 129 + } [INFO] [stdout] 130 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/app/mod.rs:256:38 [INFO] [stdout] | [INFO] [stdout] 256 | for (method, handler) in methods.to_owned() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: use: `methods.iter().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:258:44 [INFO] [stdout] | [INFO] [stdout] 258 | self.add_route(method, &base_path, move |req: HttpRequest, res| { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `base_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant redefinition of a binding `http2_enabled` [INFO] [stdout] --> src/app/mod.rs:603:21 [INFO] [stdout] | [INFO] [stdout] 603 | let http2_enabled = http2_enabled; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: `http2_enabled` is initially defined here [INFO] [stdout] --> src/app/mod.rs:581:13 [INFO] [stdout] | [INFO] [stdout] 581 | let http2_enabled = self.settings.http2_config.is_enabled; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_locals [INFO] [stdout] = note: `#[warn(clippy::redundant_locals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/app/mod.rs:628:13 [INFO] [stdout] | [INFO] [stdout] 628 | / return Box::new(ApiError::Generic( [INFO] [stdout] 629 | | HttpResponse::new() [INFO] [stdout] 630 | | .internal_server_error() [INFO] [stdout] 631 | | .text("Unhandled error"), [INFO] [stdout] 632 | | )); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 628 ~ Box::new(ApiError::Generic( [INFO] [stdout] 629 + HttpResponse::new() [INFO] [stdout] 630 + .internal_server_error() [INFO] [stdout] 631 + .text("Unhandled error"), [INFO] [stdout] 632 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/app/mod.rs:755:21 [INFO] [stdout] | [INFO] [stdout] 755 | / std::io::Error::new( [INFO] [stdout] 756 | | std::io::ErrorKind::Other, [INFO] [stdout] 757 | | format!("Failed to collect body: {}", e), [INFO] [stdout] 758 | | ) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 755 ~ std::io::Error::other( [INFO] [stdout] 756 ~ format!("Failed to collect body: {}", e), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/req/conversions.rs:42:22 [INFO] [stdout] | [INFO] [stdout] 42 | .unwrap_or(String::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.filter_map(..)` can be written more simply using `.map(..)` [INFO] [stdout] --> src/req/conversions.rs:50:14 [INFO] [stdout] | [INFO] [stdout] 50 | .filter_map(|(key, value)| Some((key.to_string(), value.to_string()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stdout] = note: `#[warn(clippy::unnecessary_filter_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/req/conversions.rs:120:53 [INFO] [stdout] | [INFO] [stdout] 120 | .and_then(|ct| extract_boundary(&ct)); [INFO] [stdout] | ^^^ help: change this to: `ct` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/req/conversions.rs:220:22 [INFO] [stdout] | [INFO] [stdout] 220 | .unwrap_or(String::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.filter_map(..)` can be written more simply using `.map(..)` [INFO] [stdout] --> src/req/conversions.rs:229:14 [INFO] [stdout] | [INFO] [stdout] 229 | .filter_map(|(key, value)| Some((key.to_string(), value.to_string()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/req/conversions.rs:236:55 [INFO] [stdout] | [INFO] [stdout] 236 | let cookies = Self::get_cookies_from_req_info(&req_info); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `req_info` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/req/conversions.rs:428:60 [INFO] [stdout] | [INFO] [stdout] 428 | hyper::header::HeaderValue::from_bytes(&cookie)?, [INFO] [stdout] | ^^^^^^^ help: change this to: `cookie` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/req/query_params.rs:188:14 [INFO] [stdout] | [INFO] [stdout] 188 | .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/req/query_params.rs:309:9 [INFO] [stdout] | [INFO] [stdout] 309 | self.get(name).map_or(false, |v| !v.is_empty()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 309 - self.get(name).map_or(false, |v| !v.is_empty()) [INFO] [stdout] 309 + self.get(name).is_some_and(|v| !v.is_empty()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `RequestBody` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/req/body/mod.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/req/body/text_data.rs:625:45 [INFO] [stdout] | [INFO] [stdout] 625 | while !self.inner.is_empty() && !std::str::from_utf8(&self.inner).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::str::from_utf8(&self.inner).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/req/mod.rs:565:23 [INFO] [stdout] | [INFO] [stdout] 565 | self.data.get(&data_key.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `data_key.into()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/req/mod.rs:590:9 [INFO] [stdout] | [INFO] [stdout] 590 | return self.body.body_type() == content_type; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 590 - return self.body.body_type() == content_type; [INFO] [stdout] 590 + self.body.body_type() == content_type [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/req/mod.rs:620:33 [INFO] [stdout] | [INFO] [stdout] 620 | body.body_type().to_string(), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TEXT` contains a capitalized acronym [INFO] [stdout] --> src/res/response_body.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | TEXT(String), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `HTML` contains a capitalized acronym [INFO] [stdout] --> src/res/response_body.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | HTML(String), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Html` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JSON` contains a capitalized acronym [INFO] [stdout] --> src/res/response_body.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | JSON(serde_json::Value), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Json` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BINARY` contains a capitalized acronym [INFO] [stdout] --> src/res/response_body.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | BINARY(Bytes), [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Binary` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TEXT` contains a capitalized acronym [INFO] [stdout] --> src/res/response_body.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 63 | TEXT, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JSON` contains a capitalized acronym [INFO] [stdout] --> src/res/response_body.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 64 | JSON, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Json` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `HTML` contains a capitalized acronym [INFO] [stdout] --> src/res/response_body.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | HTML, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Html` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BINARY` contains a capitalized acronym [INFO] [stdout] --> src/res/response_body.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 66 | BINARY, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Binary` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.stream` after checking its variant with `is_some` [INFO] [stdout] --> src/res/conversions.rs:193:17 [INFO] [stdout] | [INFO] [stdout] 132 | if self.stream.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = self.stream` [INFO] [stdout] ... [INFO] [stdout] 193 | self.stream.unwrap().collect().await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/res/conversions.rs:211:13 [INFO] [stdout] | [INFO] [stdout] 211 | return Ok(hyper_response); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 211 - return Ok(hyper_response); [INFO] [stdout] 211 + Ok(hyper_response) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/res/conversions.rs:297:13 [INFO] [stdout] | [INFO] [stdout] 297 | return Ok(response); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 297 - return Ok(response); [INFO] [stdout] 297 + Ok(response) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/res/conversions.rs:156:35 [INFO] [stdout] | [INFO] [stdout] 156 | ... .path(c.options.path.as_deref().unwrap_or("/")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `c.options.path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] = note: `#[warn(clippy::needless_option_as_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/res/conversions.rs:157:47 [INFO] [stdout] | [INFO] [stdout] 157 | if let Some(domain) = c.options.domain.as_deref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `c.options.domain` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `bytes::Bytes` [INFO] [stdout] --> src/res/conversions.rs:236:38 [INFO] [stdout] | [INFO] [stdout] 236 | .body(Full::from(Bytes::from(bytes))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider removing `Bytes::from()`: `bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/res/conversions.rs:257:35 [INFO] [stdout] | [INFO] [stdout] 257 | ... .path(c.options.path.as_deref().unwrap_or("/")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `c.options.path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/res/conversions.rs:259:47 [INFO] [stdout] | [INFO] [stdout] 259 | if let Some(domain) = c.options.domain.as_deref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `c.options.domain` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/res/mod.rs:171:9 [INFO] [stdout] | [INFO] [stdout] 171 | Option> + Send + 'static>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `HttpResponse` [INFO] [stdout] --> src/res/mod.rs:216:5 [INFO] [stdout] | [INFO] [stdout] 216 | / pub fn new() -> Self { [INFO] [stdout] 217 | | Self { [INFO] [stdout] 218 | | status_code: StatusCode::Ok, [INFO] [stdout] 219 | | body: ResponseBody::TEXT(String::new()), [INFO] [stdout] ... | [INFO] [stdout] 224 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 198 + impl Default for HttpResponse { [INFO] [stdout] 199 + fn default() -> Self { [INFO] [stdout] 200 + Self::new() [INFO] [stdout] 201 + } [INFO] [stdout] 202 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/res/mod.rs:253:9 [INFO] [stdout] | [INFO] [stdout] 253 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 253 - return self; [INFO] [stdout] 253 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/res/mod.rs:259:9 [INFO] [stdout] | [INFO] [stdout] 259 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 259 - return self; [INFO] [stdout] 259 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/res/mod.rs:265:9 [INFO] [stdout] | [INFO] [stdout] 265 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 265 - return self; [INFO] [stdout] 265 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/res/mod.rs:271:9 [INFO] [stdout] | [INFO] [stdout] 271 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 271 - return self; [INFO] [stdout] 271 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/res/mod.rs:277:9 [INFO] [stdout] | [INFO] [stdout] 277 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 277 - return self; [INFO] [stdout] 277 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/res/mod.rs:283:9 [INFO] [stdout] | [INFO] [stdout] 283 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 283 - return self; [INFO] [stdout] 283 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/res/mod.rs:289:9 [INFO] [stdout] | [INFO] [stdout] 289 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 289 - return self; [INFO] [stdout] 289 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/res/mod.rs:295:9 [INFO] [stdout] | [INFO] [stdout] 295 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 295 - return self; [INFO] [stdout] 295 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/res/mod.rs:301:9 [INFO] [stdout] | [INFO] [stdout] 301 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 301 - return self; [INFO] [stdout] 301 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/res/mod.rs:307:9 [INFO] [stdout] | [INFO] [stdout] 307 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 307 - return self; [INFO] [stdout] 307 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/res/mod.rs:313:9 [INFO] [stdout] | [INFO] [stdout] 313 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 313 - return self; [INFO] [stdout] 313 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/res/mod.rs:347:9 [INFO] [stdout] | [INFO] [stdout] 347 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 347 - return self; [INFO] [stdout] 347 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/res/mod.rs:383:9 [INFO] [stdout] | [INFO] [stdout] 383 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 383 - return self; [INFO] [stdout] 383 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/res/mod.rs:415:9 [INFO] [stdout] | [INFO] [stdout] 415 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 415 - return self; [INFO] [stdout] 415 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helpers.rs:39:17 [INFO] [stdout] | [INFO] [stdout] 39 | return Ok(hyper_req); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return Ok(hyper_req); [INFO] [stdout] 39 + Ok(hyper_req) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helpers.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 42 | return Err(ApiError::Generic(res)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return Err(ApiError::Generic(res)); [INFO] [stdout] 42 + Err(ApiError::Generic(res)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `app::api_error::ApiError` [INFO] [stdout] --> src/helpers.rs:31:19 [INFO] [stdout] | [INFO] [stdout] 31 | .await [INFO] [stdout] | ___________________^ [INFO] [stdout] 32 | | .map_err(ApiError::from)?; [INFO] [stdout] | |____________________________________^ help: consider removing [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helpers.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 81 | return Ok(hyper_res); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 81 - return Ok(hyper_res); [INFO] [stdout] 81 + Ok(hyper_res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/helpers.rs:178:6 [INFO] [stdout] | [INFO] [stdout] 178 | ) -> (Vec<(&'a str, &'a str)>, Vec<(Vec, Option<&'a str>)>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `split_once` [INFO] [stdout] --> src/helpers.rs:225:35 [INFO] [stdout] | [INFO] [stdout] 225 | let after_colon = l.splitn(2, ':').nth(1).unwrap_or("").trim(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `l.split_once(':').map(|x| x.1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_split_once [INFO] [stdout] = note: `#[warn(clippy::manual_split_once)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/helpers.rs:238:32 [INFO] [stdout] | [INFO] [stdout] 238 | if let Some(_) = val2.find('"') { [INFO] [stdout] | -------^^^^^^^----------------- help: try: `if val2.find('"').is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/middlewares/cors.rs:225:5 [INFO] [stdout] | [INFO] [stdout] 225 | /// Configuration struct for the CORS Middleware [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 225 | /// Configuration struct for the CORS Middleware [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/middlewares/rate_limiter.rs:297:5 [INFO] [stdout] | [INFO] [stdout] 297 | /// Configuration struct for the rate limiter middleware [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 297 | /// Configuration struct for the rate limiter middleware [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/middlewares/shield/config.rs:526:1 [INFO] [stdout] | [INFO] [stdout] 526 | / impl Default for CrossOriginOpenerPolicy { [INFO] [stdout] 527 | | fn default() -> Self { [INFO] [stdout] 528 | | Self::SameOrigin [INFO] [stdout] 529 | | } [INFO] [stdout] 530 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 517 + #[derive(Default)] [INFO] [stdout] 518 | pub enum CrossOriginOpenerPolicy { [INFO] [stdout] 519 | /// Isolate from all cross-origin documents (most secure) [INFO] [stdout] 520 ~ #[default] [INFO] [stdout] 521 ~ SameOrigin, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/middlewares/shield/config.rs:574:1 [INFO] [stdout] | [INFO] [stdout] 574 | / impl Default for CrossOriginResourcePolicy { [INFO] [stdout] 575 | | fn default() -> Self { [INFO] [stdout] 576 | | Self::SameOrigin [INFO] [stdout] 577 | | } [INFO] [stdout] 578 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 565 + #[derive(Default)] [INFO] [stdout] 566 | pub enum CrossOriginResourcePolicy { [INFO] [stdout] 567 | /// Only allow same-origin resource inclusion (most secure) [INFO] [stdout] 568 ~ #[default] [INFO] [stdout] 569 ~ SameOrigin, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/middlewares/shield/config.rs:722:1 [INFO] [stdout] | [INFO] [stdout] 722 | / impl Default for CrossOriginEmbedderPolicy { [INFO] [stdout] 723 | | fn default() -> Self { [INFO] [stdout] 724 | | Self::UnsafeNone [INFO] [stdout] 725 | | } [INFO] [stdout] 726 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 715 + #[derive(Default)] [INFO] [stdout] 716 | pub enum CrossOriginEmbedderPolicy { [INFO] [stdout] 717 | /// Require CORP header on all cross-origin resources [INFO] [stdout] 718 | RequireCorp, [INFO] [stdout] 719 | /// No requirements (maintains compatibility) [INFO] [stdout] 720 ~ #[default] [INFO] [stdout] 721 ~ UnsafeNone, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/middlewares/shield/config.rs:833:1 [INFO] [stdout] | [INFO] [stdout] 833 | / impl Default for ShieldConfig { [INFO] [stdout] 834 | | fn default() -> Self { [INFO] [stdout] 835 | | Self { [INFO] [stdout] 836 | | content_security_policy: ContentSecurityPolicy::default(), [INFO] [stdout] ... | [INFO] [stdout] 853 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 27 + #[derive(Default)] [INFO] [stdout] 28 | pub struct ShieldConfig { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/middlewares/shield/mod.rs:542:47 [INFO] [stdout] | [INFO] [stdout] 542 | .insert("cross-origin-opener-policy", header_value.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `header_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/middlewares/shield/mod.rs:560:49 [INFO] [stdout] | [INFO] [stdout] 560 | .insert("cross-origin-resource-policy", header_value.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `header_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/middlewares/shield/mod.rs:577:49 [INFO] [stdout] | [INFO] [stdout] 577 | .insert("Cross-Origin-Embedder-Policy", header_value.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `header_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/types.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | / match method { [INFO] [stdout] 53 | | &Method::GET => HttpMethods::GET, [INFO] [stdout] 54 | | &Method::POST => HttpMethods::POST, [INFO] [stdout] 55 | | &Method::PUT => HttpMethods::PUT, [INFO] [stdout] ... | [INFO] [stdout] 60 | | _ => HttpMethods::GET, [INFO] [stdout] 61 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 52 ~ match *method { [INFO] [stdout] 53 ~ Method::GET => HttpMethods::GET, [INFO] [stdout] 54 ~ Method::POST => HttpMethods::POST, [INFO] [stdout] 55 ~ Method::PUT => HttpMethods::PUT, [INFO] [stdout] 56 ~ Method::DELETE => HttpMethods::DELETE, [INFO] [stdout] 57 ~ Method::PATCH => HttpMethods::PATCH, [INFO] [stdout] 58 ~ Method::HEAD => HttpMethods::HEAD, [INFO] [stdout] 59 ~ Method::OPTIONS => HttpMethods::OPTIONS, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tests/app_test.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | return res.ok(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return res.ok(); [INFO] [stdout] 28 + res.ok() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/tests/errors_test.rs:39:22 [INFO] [stdout] | [INFO] [stdout] 39 | let io_err = std::io::Error::new(std::io::ErrorKind::Other, "disk fail"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 39 - let io_err = std::io::Error::new(std::io::ErrorKind::Other, "disk fail"); [INFO] [stdout] 39 + let io_err = std::io::Error::other("disk fail"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/tests/extractors_test.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | req.body = RequestBody::new_json(json_value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `req::HttpRequest { body: RequestBody::new_json(json_value), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/tests/extractors_test.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | let mut req = HttpRequest::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/tests/extractors_test.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | req.origin_url = Url::new(format!("http://localhost/test?{}", query).as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `req::HttpRequest { origin_url: Url::new(format!("http://localhost/test?{}", query).as_str()), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/tests/extractors_test.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | let mut req = HttpRequest::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/tests/helper_test.rs:229:20 [INFO] [stdout] | [INFO] [stdout] 229 | let body = format!( [INFO] [stdout] | ____________________^ [INFO] [stdout] 230 | | "--AaB03x\r\nContent-Disposition: form-data; name=\"submit-name\"\r\n\r\nLarry\r\n--AaB03x--" [INFO] [stdout] 231 | | ); [INFO] [stdout] | |_________^ help: consider using `.to_string()`: `"--AaB03x\r\nContent-Disposition: form-data; name=\"submit-name\"\r\n\r\nLarry\r\n--AaB03x--".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/tests/helper_test.rs:240:20 [INFO] [stdout] | [INFO] [stdout] 240 | let body = format!( [INFO] [stdout] | ____________________^ [INFO] [stdout] 241 | | "--xyz\r\nContent-Disposition: form-data; name=\"f1\"\r\n\r\nv1\r\n--xyz\r\nContent-Disposition: form-data; name=\"f2... [INFO] [stdout] 242 | | ); [INFO] [stdout] | |_________^ help: consider using `.to_string()`: `"--xyz\r\nContent-Disposition: form-data; name=\"f1\"\r\n\r\nv1\r\n--xyz\r\nContent-Disposition: form-data; name=\"f2\"\r\n\r\nv2\r\n--xyz--".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/tests/helper_test.rs:290:20 [INFO] [stdout] | [INFO] [stdout] 290 | let body = format!( [INFO] [stdout] | ____________________^ [INFO] [stdout] 291 | | "--multistar\r\nContent-Disposition: form-data; name=\"file\"; filename*=\"myfile.txt\"\r\n\r\nabc\r\n--multistar--" [INFO] [stdout] 292 | | ); [INFO] [stdout] | |_________^ help: consider using `.to_string()`: `"--multistar\r\nContent-Disposition: form-data; name=\"file\"; filename*=\"myfile.txt\"\r\n\r\nabc\r\n--multistar--".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*mut hyper::Request>` -> `*mut hyper::Request>`) [INFO] [stdout] --> src/tests/middleware/exec.rs:31:19 [INFO] [stdout] | [INFO] [stdout] 31 | let ptr = Box::into_raw(Box::new(full_request)) as *mut Request>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Box::into_raw(Box::new(full_request))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/request/body.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 120 | assert_eq!(form.contains_key("key"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 120 - assert_eq!(form.contains_key("key"), true); [INFO] [stdout] 120 + assert!(form.contains_key("key")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/request/body.rs:121:9 [INFO] [stdout] | [INFO] [stdout] 121 | assert_eq!(form.contains_key("missing"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 121 - assert_eq!(form.contains_key("missing"), false); [INFO] [stdout] 121 + assert!(!form.contains_key("missing")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/request/body.rs:128:9 [INFO] [stdout] | [INFO] [stdout] 128 | assert_eq!(form.contains_key("key2"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 128 - assert_eq!(form.contains_key("key2"), true); [INFO] [stdout] 128 + assert!(form.contains_key("key2")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/request/body.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 129 | assert_eq!(form.contains_key("key3"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 129 - assert_eq!(form.contains_key("key3"), true); [INFO] [stdout] 129 + assert!(form.contains_key("key3")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/request/body.rs:637:9 [INFO] [stdout] | [INFO] [stdout] 637 | assert_eq!(text.is_empty(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 637 - assert_eq!(text.is_empty(), true); [INFO] [stdout] 637 + assert!(text.is_empty()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/request/body.rs:638:9 [INFO] [stdout] | [INFO] [stdout] 638 | assert_eq!(text.contains("Hello").unwrap(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 638 - assert_eq!(text.contains("Hello").unwrap(), false); [INFO] [stdout] 638 + assert!(!text.contains("Hello").unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/tests/request/body.rs:699:28 [INFO] [stdout] | [INFO] [stdout] 699 | let bytes: &[u8] = &*text; [INFO] [stdout] | ^^^^^^ help: try: `&text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/tests/request/data.rs:45:25 [INFO] [stdout] | [INFO] [stdout] 45 | data.insert(k.to_string(), v); [INFO] [stdout] | ^^^^^^^^^^^^^ help: use: `k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tests/request/form_data_test.rs:126:33 [INFO] [stdout] | [INFO] [stdout] 126 | assert!(values.contains(&&"value1")); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `(&"value1")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tests/request/form_data_test.rs:127:33 [INFO] [stdout] | [INFO] [stdout] 127 | assert!(values.contains(&&"value2")); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `(&"value2")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/request/headers.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | assert_eq!(headers.contains_key("id"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 39 - assert_eq!(headers.contains_key("id"), true); [INFO] [stdout] 39 + assert!(headers.contains_key("id")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/request/headers.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | assert_eq!(headers.contains_key("name"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 40 - assert_eq!(headers.contains_key("name"), true); [INFO] [stdout] 40 + assert!(headers.contains_key("name")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/request/headers.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | assert_eq!(headers.contains_key("non-existent"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 41 - assert_eq!(headers.contains_key("non-existent"), false); [INFO] [stdout] 41 + assert!(!headers.contains_key("non-existent")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/request/headers.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | assert_eq!(headers.is_empty(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 92 - assert_eq!(headers.is_empty(), true); [INFO] [stdout] 92 + assert!(headers.is_empty()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/request/headers.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | assert_eq!(headers.as_header_map().is_empty(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 96 - assert_eq!(headers.as_header_map().is_empty(), true); [INFO] [stdout] 96 + assert!(headers.as_header_map().is_empty()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/request/headers.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | assert_eq!(headers.into_header_map().is_empty(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 98 - assert_eq!(headers.into_header_map().is_empty(), true); [INFO] [stdout] 98 + assert!(headers.into_header_map().is_empty()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/request/query_param.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 116 | assert_eq!(query.get_bool("active").unwrap(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 116 - assert_eq!(query.get_bool("active").unwrap(), true); [INFO] [stdout] 116 + assert!(query.get_bool("active").unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/request/query_param.rs:149:9 [INFO] [stdout] | [INFO] [stdout] 149 | assert_eq!(query.get_bool("active").unwrap(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 149 - assert_eq!(query.get_bool("active").unwrap(), true); [INFO] [stdout] 149 + assert!(query.get_bool("active").unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/request/query_param.rs:150:9 [INFO] [stdout] | [INFO] [stdout] 150 | assert_eq!(query.get_bool("debug").unwrap(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 150 - assert_eq!(query.get_bool("debug").unwrap(), true); [INFO] [stdout] 150 + assert!(query.get_bool("debug").unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/request/query_param.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 151 | assert_eq!(query.get_bool("verbose").unwrap(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 151 - assert_eq!(query.get_bool("verbose").unwrap(), true); [INFO] [stdout] 151 + assert!(query.get_bool("verbose").unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/request/query_param.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 152 | assert_eq!(query.get_bool("disabled").unwrap(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 152 - assert_eq!(query.get_bool("disabled").unwrap(), false); [INFO] [stdout] 152 + assert!(!query.get_bool("disabled").unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/tests/request/route_params.rs:84:26 [INFO] [stdout] | [INFO] [stdout] 84 | message: format!("Route Param 'invalid' not found"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Route Param 'invalid' not found".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/request/route_params.rs:223:9 [INFO] [stdout] | [INFO] [stdout] 223 | assert_eq!(params.is_empty(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 223 - assert_eq!(params.is_empty(), false); [INFO] [stdout] 223 + assert!(!params.is_empty()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/tests/request/mod.rs:23:29 [INFO] [stdout] | [INFO] [stdout] 23 | self.headers.insert(key.to_string(), value.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/tests/request/mod.rs:23:46 [INFO] [stdout] | [INFO] [stdout] 23 | self.headers.insert(key.to_string(), value.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tests/response/mod.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | return content_type.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return content_type.clone(); [INFO] [stdout] 51 + content_type.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/tests/response/mod.rs:286:22 [INFO] [stdout] | [INFO] [stdout] 286 | let io_err = std::io::Error::new(std::io::ErrorKind::Other, "low-level failure"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 286 - let io_err = std::io::Error::new(std::io::ErrorKind::Other, "low-level failure"); [INFO] [stdout] 286 + let io_err = std::io::Error::other("low-level failure"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tests/router_test.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | return res.ok(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4 - return res.ok(); [INFO] [stdout] 4 + res.ok() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 37.39s [INFO] running `Command { std: "docker" "inspect" "b27e3b53ba95e574ef91731e1e2203c572c075cb909e468654040417ac23a8fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b27e3b53ba95e574ef91731e1e2203c572c075cb909e468654040417ac23a8fc", kill_on_drop: false }` [INFO] [stdout] b27e3b53ba95e574ef91731e1e2203c572c075cb909e468654040417ac23a8fc