[INFO] fetching crate ripgrep 15.1.0... [INFO] linting ripgrep-15.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate ripgrep 15.1.0 into /workspace/builds/worker-6-tc1/source [INFO] removed /workspace/builds/worker-6-tc1/source/.cargo/config.toml [INFO] started tweaking crates.io crate ripgrep 15.1.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate ripgrep 15.1.0 [INFO] tweaked toml for crates.io crate ripgrep 15.1.0 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate ripgrep 15.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate ripgrep 15.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded grep-pcre2 v0.1.9 [INFO] [stderr] Downloaded lexopt v0.3.1 [INFO] [stderr] Downloaded tikv-jemallocator v0.6.1 [INFO] [stderr] Downloaded ignore v0.4.24 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5844af07056e4b75ef04df3f8d3a36e16b1edf5259a2d82e6a359c134d783650 [INFO] running `Command { std: "docker" "start" "-a" "5844af07056e4b75ef04df3f8d3a36e16b1edf5259a2d82e6a359c134d783650", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5844af07056e4b75ef04df3f8d3a36e16b1edf5259a2d82e6a359c134d783650", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5844af07056e4b75ef04df3f8d3a36e16b1edf5259a2d82e6a359c134d783650", kill_on_drop: false }` [INFO] [stdout] 5844af07056e4b75ef04df3f8d3a36e16b1edf5259a2d82e6a359c134d783650 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8e839055055b8f679a2a1bc133309a3a5fec5047c7861b6dff77b24501248477 [INFO] running `Command { std: "docker" "start" "-a" "8e839055055b8f679a2a1bc133309a3a5fec5047c7861b6dff77b24501248477", kill_on_drop: false }` [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking grep-matcher v0.1.8 [INFO] [stderr] Compiling proc-macro2 v1.0.101 [INFO] [stderr] Checking encoding_rs_io v0.1.7 [INFO] [stderr] Checking memmap2 v0.9.9 [INFO] [stderr] Compiling quote v1.0.41 [INFO] [stderr] Compiling unicode-ident v1.0.20 [INFO] [stderr] Compiling ripgrep v15.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking textwrap v0.16.2 [INFO] [stderr] Checking lexopt v0.3.1 [INFO] [stderr] warning: ripgrep@15.1.0: output from `git rev-parse` is empty, so skipping embedding of commit hash [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Compiling syn v2.0.107 [INFO] [stderr] Checking bstr v1.12.0 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking globset v0.4.18 [INFO] [stderr] Checking grep-searcher v0.1.16 [INFO] [stderr] Checking grep-regex v0.1.14 [INFO] [stderr] Checking grep-printer v0.3.1 [INFO] [stderr] Checking grep-cli v0.1.12 [INFO] [stderr] Checking ignore v0.4.24 [INFO] [stderr] Checking grep v0.4.1 [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> crates/core/messages.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 73 | if crate::messages::messages() { [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] = note: `#[warn(clippy::crate_in_macro_def)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> crates/core/messages.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | crate::messages::set_errored(); [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> crates/core/messages.rs:94:12 [INFO] [stdout] | [INFO] [stdout] 94 | if crate::messages::messages() && crate::messages::ignore_messages() { [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/complete/mod.rs:5:20 [INFO] [stdout] | [INFO] [stdout] 5 | static ENCODINGS: &'static str = include_str!("encodings.sh"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/complete/bash.rs:7:23 [INFO] [stdout] | [INFO] [stdout] 7 | const TEMPLATE_FULL: &'static str = " [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/complete/bash.rs:45:23 [INFO] [stdout] | [INFO] [stdout] 45 | const TEMPLATE_CASE: &'static str = " [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/complete/bash.rs:52:31 [INFO] [stdout] | [INFO] [stdout] 52 | const TEMPLATE_CASE_CHOICES: &'static str = " [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/complete/fish.rs:7:18 [INFO] [stdout] | [INFO] [stdout] 7 | const TEMPLATE: &'static str = "complete -c rg !SHORT! -l !LONG! -d '!DOC!'"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/complete/fish.rs:8:26 [INFO] [stdout] | [INFO] [stdout] 8 | const TEMPLATE_NEGATED: &'static str = "complete -c rg -l !NEGATED! -n '__rg_contains_opt !LONG! !SHORT!' -d '!DOC!'\n"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/complete/powershell.rs:7:18 [INFO] [stdout] | [INFO] [stdout] 7 | const TEMPLATE: &'static str = " [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/complete/powershell.rs:37:23 [INFO] [stdout] | [INFO] [stdout] 37 | const TEMPLATE_FLAG: &'static str = "[CompletionResult]::new('!DASH_NAME!', '!NAME!', [CompletionResultType]::ParameterName, '!DOC!')"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/doc/help.rs:13:24 [INFO] [stdout] | [INFO] [stdout] 13 | const TEMPLATE_SHORT: &'static str = include_str!("template.short.help"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/doc/help.rs:14:23 [INFO] [stdout] | [INFO] [stdout] 14 | const TEMPLATE_LONG: &'static str = include_str!("template.long.help"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/doc/man.rs:9:18 [INFO] [stdout] | [INFO] [stdout] 9 | const TEMPLATE: &'static str = include_str!("template.rg.1"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/logger.rs:19:16 [INFO] [stdout] | [INFO] [stdout] 19 | const LOGGER: &'static Logger = &Logger(()); [INFO] [stdout] | -^^^^^^^------- help: consider removing `'static`: `&Logger` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/core/flags/complete/fish.rs:26:32 [INFO] [stdout] | [INFO] [stdout] 26 | .replace("!LONG!", &long) [INFO] [stdout] | ^^^^^ help: change this to: `long` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> crates/core/flags/complete/fish.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 44 | completion.push_str("'"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `completion.push('\'')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> crates/core/flags/complete/fish.rs:49:17 [INFO] [stdout] | [INFO] [stdout] 49 | completion.push_str("'"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `completion.push('\'')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/core/flags/complete/fish.rs:67:43 [INFO] [stdout] | [INFO] [stdout] 67 | .replace("!NEGATED!", &negated) [INFO] [stdout] | ^^^^^^^^ help: change this to: `negated` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/core/flags/complete/fish.rs:69:40 [INFO] [stdout] | [INFO] [stdout] 69 | .replace("!LONG!", &long) [INFO] [stdout] | ^^^^^ help: change this to: `long` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/core/flags/complete/powershell.rs:57:36 [INFO] [stdout] | [INFO] [stdout] 57 | .replace("!NAME!", &name) [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/core/flags/complete/powershell.rs:79:40 [INFO] [stdout] | [INFO] [stdout] 79 | .replace("!NAME!", &negated) [INFO] [stdout] | ^^^^^^^^ help: change this to: `negated` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/core/flags/complete/zsh.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | Namely, the zsh completions take application level context about flag [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 9 | Namely, the zsh completions take application level context about flag [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/core/flags/complete/zsh.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | compatibility into account. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 10 | compatibility into account. [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/core/flags/complete/zsh.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | isn't included in the zsh completions. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 12 | isn't included in the zsh completions. [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/core/flags/complete/zsh.rs:14:1 [INFO] [stdout] | [INFO] [stdout] 14 | works and how it can be extended. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 14 | works and how it can be extended. [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/core/flags/config.rs:61:31 [INFO] [stdout] | [INFO] [stdout] 61 | match std::fs::File::open(&path) { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> crates/core/flags/defs.rs:3038:9 [INFO] [stdout] | [INFO] [stdout] 3038 | &*BORROWED [INFO] [stdout] | ^^^^^^^^^^ help: try: `&BORROWED` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JSON` contains a capitalized acronym [INFO] [stdout] --> crates/core/flags/defs.rs:3436:8 [INFO] [stdout] | [INFO] [stdout] 3436 | struct JSON; [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Json` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/core/flags/doc/help.rs:118:34 [INFO] [stdout] | [INFO] [stdout] 118 | generate_long_flag(flag, &mut cat); [INFO] [stdout] | ^^^^^^^^ help: change this to: `cat` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> crates/core/flags/doc/help.rs:229:28 [INFO] [stdout] | [INFO] [stdout] 229 | lines.push(format!("{item_label}")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `item_label.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> crates/core/flags/doc/help.rs:236:28 [INFO] [stdout] | [INFO] [stdout] 236 | lines.push(format!("{pieces}")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `pieces.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/core/flags/doc/man.rs:34:29 [INFO] [stdout] | [INFO] [stdout] 34 | generate_flag(flag, &mut cat); [INFO] [stdout] | ^^^^^^^^ help: change this to: `cat` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> crates/core/flags/hiargs.rs:127:9 [INFO] [stdout] | [INFO] [stdout] 127 | / match low.mode { [INFO] [stdout] 128 | | Mode::Search(ref mut mode) => match *mode { [INFO] [stdout] 129 | | // treat `-v --count-matches` as `-v --count` [INFO] [stdout] 130 | | SearchMode::CountMatches if low.invert_match => { [INFO] [stdout] ... | [INFO] [stdout] 139 | | _ => {} [INFO] [stdout] 140 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 127 ~ if let Mode::Search(ref mut mode) = low.mode { match *mode { [INFO] [stdout] 128 + // treat `-v --count-matches` as `-v --count` [INFO] [stdout] 129 + SearchMode::CountMatches if low.invert_match => { [INFO] [stdout] 130 + *mode = SearchMode::Count; [INFO] [stdout] 131 + } [INFO] [stdout] 132 + // treat `-o --count` as `--count-matches` [INFO] [stdout] 133 + SearchMode::Count if low.only_matching => { [INFO] [stdout] 134 + *mode = SearchMode::CountMatches; [INFO] [stdout] 135 + } [INFO] [stdout] 136 + _ => {} [INFO] [stdout] 137 + } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> crates/core/flags/hiargs.rs:176:29 [INFO] [stdout] | [INFO] [stdout] 176 | let with_filename = low [INFO] [stdout] | _____________________________^ [INFO] [stdout] 177 | | .with_filename [INFO] [stdout] 178 | | .unwrap_or_else(|| low.vimgrep || !paths.is_one_file); [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 178 - .unwrap_or_else(|| low.vimgrep || !paths.is_one_file); [INFO] [stdout] 178 + .unwrap_or(low.vimgrep || !paths.is_one_file); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/core/flags/hiargs.rs:207:47 [INFO] [stdout] | [INFO] [stdout] 207 | | SearchMode::CountMatches => return false, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 207 - | SearchMode::CountMatches => return false, [INFO] [stdout] 207 + | SearchMode::CountMatches => false, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/core/flags/hiargs.rs:208:37 [INFO] [stdout] | [INFO] [stdout] 208 | SearchMode::JSON => return true, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 208 - SearchMode::JSON => return true, [INFO] [stdout] 208 + SearchMode::JSON => true, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> crates/core/flags/hiargs.rs:552:24 [INFO] [stdout] | [INFO] [stdout] 552 | .separator(self.path_separator.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.path_separator` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> crates/core/flags/hiargs.rs:623:30 [INFO] [stdout] | [INFO] [stdout] 623 | .path_terminator(self.path_terminator.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.path_terminator` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> crates/core/flags/hiargs.rs:634:29 [INFO] [stdout] | [INFO] [stdout] 634 | .separator_path(self.path_separator.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.path_separator` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> crates/core/flags/hiargs.rs:661:30 [INFO] [stdout] | [INFO] [stdout] 661 | .path_terminator(self.path_terminator.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.path_terminator` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> crates/core/flags/hiargs.rs:663:29 [INFO] [stdout] | [INFO] [stdout] 663 | .separator_path(self.path_separator.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.path_separator` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> crates/core/flags/hiargs.rs:786:36 [INFO] [stdout] | [INFO] [stdout] 786 | haystacks.sort_by(|ref h1, ref h2| { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 786 - haystacks.sort_by(|ref h1, ref h2| { [INFO] [stdout] 786 + haystacks.sort_by(|h1, ref h2| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> crates/core/flags/hiargs.rs:786:44 [INFO] [stdout] | [INFO] [stdout] 786 | haystacks.sort_by(|ref h1, ref h2| { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 786 - haystacks.sort_by(|ref h1, ref h2| { [INFO] [stdout] 786 + haystacks.sort_by(|ref h1, h2| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/core/flags/hiargs.rs:1228:21 [INFO] [stdout] | [INFO] [stdout] 1228 | builder.add(&glob)?; [INFO] [stdout] | ^^^^^ help: change this to: `glob` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JSON` contains a capitalized acronym [INFO] [stdout] --> crates/core/flags/lowargs.rs:213:5 [INFO] [stdout] | [INFO] [stdout] 213 | JSON, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Json` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/core/flags/lowargs.rs:254:1 [INFO] [stdout] | [INFO] [stdout] 254 | / impl Default for BinaryMode { [INFO] [stdout] 255 | | fn default() -> BinaryMode { [INFO] [stdout] 256 | | BinaryMode::Auto [INFO] [stdout] 257 | | } [INFO] [stdout] 258 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 233 + #[derive(Default)] [INFO] [stdout] 234 | pub(crate) enum BinaryMode { [INFO] [stdout] 235 | /// Automatically determine the binary mode to use. Essentially, when [INFO] [stdout] ... [INFO] [stdout] 239 | /// a file is classified as binary, searching will immediately stop. [INFO] [stdout] 240 ~ #[default] [INFO] [stdout] 241 ~ Auto, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/core/flags/lowargs.rs:290:1 [INFO] [stdout] | [INFO] [stdout] 290 | / impl Default for BufferMode { [INFO] [stdout] 291 | | fn default() -> BufferMode { [INFO] [stdout] 292 | | BufferMode::Auto [INFO] [stdout] 293 | | } [INFO] [stdout] 294 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 273 + #[derive(Default)] [INFO] [stdout] 274 | pub(crate) enum BufferMode { [INFO] [stdout] 275 | /// Select the buffer mode, 'line' or 'block', automatically based on [INFO] [stdout] 276 | /// whether stdout is connected to a tty. [INFO] [stdout] 277 ~ #[default] [INFO] [stdout] 278 ~ Auto, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/core/flags/lowargs.rs:311:1 [INFO] [stdout] | [INFO] [stdout] 311 | / impl Default for CaseMode { [INFO] [stdout] 312 | | fn default() -> CaseMode { [INFO] [stdout] 313 | | CaseMode::Sensitive [INFO] [stdout] 314 | | } [INFO] [stdout] 315 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 300 + #[derive(Default)] [INFO] [stdout] 301 | pub(crate) enum CaseMode { [INFO] [stdout] 302 | /// Patterns are matched case sensitively. i.e., `a` does not match `A`. [INFO] [stdout] 303 ~ #[default] [INFO] [stdout] 304 ~ Sensitive, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/core/flags/lowargs.rs:338:1 [INFO] [stdout] | [INFO] [stdout] 338 | / impl Default for ColorChoice { [INFO] [stdout] 339 | | fn default() -> ColorChoice { [INFO] [stdout] 340 | | ColorChoice::Auto [INFO] [stdout] 341 | | } [INFO] [stdout] 342 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 321 + #[derive(Default)] [INFO] [stdout] 322 | pub(crate) enum ColorChoice { [INFO] [stdout] 323 | /// Color and hyperlinks will never be used. [INFO] [stdout] ... [INFO] [stdout] 326 | /// tty. [INFO] [stdout] 327 ~ #[default] [INFO] [stdout] 328 ~ Auto, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/core/flags/lowargs.rs:544:1 [INFO] [stdout] | [INFO] [stdout] 544 | / impl Default for EncodingMode { [INFO] [stdout] 545 | | fn default() -> EncodingMode { [INFO] [stdout] 546 | | EncodingMode::Auto [INFO] [stdout] 547 | | } [INFO] [stdout] 548 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 533 + #[derive(Default)] [INFO] [stdout] 534 | pub(crate) enum EncodingMode { [INFO] [stdout] 535 | /// Use only BOM sniffing to auto-detect an encoding. [INFO] [stdout] 536 ~ #[default] [INFO] [stdout] 537 ~ Auto, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/core/flags/lowargs.rs:569:1 [INFO] [stdout] | [INFO] [stdout] 569 | / impl Default for EngineChoice { [INFO] [stdout] 570 | | fn default() -> EngineChoice { [INFO] [stdout] 571 | | EngineChoice::Default [INFO] [stdout] 572 | | } [INFO] [stdout] 573 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 554 + #[derive(Default)] [INFO] [stdout] 555 | pub(crate) enum EngineChoice { [INFO] [stdout] 556 | /// Uses the default regex engine: Rust's `regex` crate. [INFO] [stdout] ... [INFO] [stdout] 559 | /// the implementation of the `regex` crate.) [INFO] [stdout] 560 ~ #[default] [INFO] [stdout] 561 ~ Default, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/core/flags/lowargs.rs:669:1 [INFO] [stdout] | [INFO] [stdout] 669 | / impl Default for MmapMode { [INFO] [stdout] 670 | | fn default() -> MmapMode { [INFO] [stdout] 671 | | MmapMode::Auto [INFO] [stdout] 672 | | } [INFO] [stdout] 673 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 655 + #[derive(Default)] [INFO] [stdout] 656 | pub(crate) enum MmapMode { [INFO] [stdout] 657 | /// This instructs ripgrep to use heuristics for selecting when to and not [INFO] [stdout] 658 | /// to use memory maps for searching. [INFO] [stdout] 659 ~ #[default] [INFO] [stdout] 660 ~ Auto, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> crates/core/flags/parse.rs:107:36 [INFO] [stdout] | [INFO] [stdout] 107 | if let Err(err) = parser.parse(final_args.into_iter(), &mut low) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> crates/core/flags/parse.rs:223:12 [INFO] [stdout] | [INFO] [stdout] 223 | I: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 107 - if let Err(err) = parser.parse(final_args.into_iter(), &mut low) { [INFO] [stdout] 107 + if let Err(err) = parser.parse(final_args, &mut low) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> crates/core/flags/parse.rs:233:43 [INFO] [stdout] | [INFO] [stdout] 233 | lexopt::Arg::Short(ch) if ch == 'h' => { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] = note: `#[warn(clippy::redundant_guards)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 233 - lexopt::Arg::Short(ch) if ch == 'h' => { [INFO] [stdout] 233 + lexopt::Arg::Short('h') => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> crates/core/flags/parse.rs:239:43 [INFO] [stdout] | [INFO] [stdout] 239 | lexopt::Arg::Short(ch) if ch == 'V' => { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 239 - lexopt::Arg::Short(ch) if ch == 'V' => { [INFO] [stdout] 239 + lexopt::Arg::Short('V') => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> crates/core/flags/parse.rs:246:44 [INFO] [stdout] | [INFO] [stdout] 246 | lexopt::Arg::Long(name) if name == "help" => { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 246 - lexopt::Arg::Long(name) if name == "help" => { [INFO] [stdout] 246 + lexopt::Arg::Long("help") => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> crates/core/flags/parse.rs:252:44 [INFO] [stdout] | [INFO] [stdout] 252 | lexopt::Arg::Long(name) if name == "version" => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 252 - lexopt::Arg::Long(name) if name == "version" => { [INFO] [stdout] 252 + lexopt::Arg::Long("version") => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/core/haystack.rs:158:9 [INFO] [stdout] | [INFO] [stdout] 158 | self.dent.file_type().map_or(false, |ft| ft.is_file()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 158 - self.dent.file_type().map_or(false, |ft| ft.is_file()) [INFO] [stdout] 158 + self.dent.file_type().is_some_and(|ft| ft.is_file()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JSON` contains a capitalized acronym [INFO] [stdout] --> crates/core/search.rs:210:5 [INFO] [stdout] | [INFO] [stdout] 210 | JSON(grep::printer::JSON), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Json` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> crates/core/search.rs:285:12 [INFO] [stdout] | [INFO] [stdout] 285 | if !self.config.preprocessor.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.config.preprocessor.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/core/search.rs:307:13 [INFO] [stdout] | [INFO] [stdout] 307 | / io::Error::new( [INFO] [stdout] 308 | | io::ErrorKind::Other, [INFO] [stdout] 309 | | format!( [INFO] [stdout] 310 | | "preprocessor command could not start: '{cmd:?}': {err}", [INFO] [stdout] 311 | | ), [INFO] [stdout] 312 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 307 ~ io::Error::other( [INFO] [stdout] 308 ~ format!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/core/search.rs:315:13 [INFO] [stdout] | [INFO] [stdout] 315 | / io::Error::new( [INFO] [stdout] 316 | | io::ErrorKind::Other, [INFO] [stdout] 317 | | format!("preprocessor command failed: '{cmd:?}': {err}"), [INFO] [stdout] 318 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 315 ~ io::Error::other( [INFO] [stdout] 316 ~ format!("preprocessor command failed: '{cmd:?}': {err}"), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> crates/core/search.rs:392:24 [INFO] [stdout] | [INFO] [stdout] 392 | stats: sink.stats().map(|s| s.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `sink.stats().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> crates/core/search.rs:400:24 [INFO] [stdout] | [INFO] [stdout] 400 | stats: sink.stats().map(|s| s.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `sink.stats().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> crates/core/search.rs:429:24 [INFO] [stdout] | [INFO] [stdout] 429 | stats: sink.stats().map(|s| s.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `sink.stats().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> crates/core/search.rs:437:24 [INFO] [stdout] | [INFO] [stdout] 437 | stats: sink.stats().map(|s| s.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `sink.stats().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `print` doesn't need a mutable reference [INFO] [stdout] --> crates/core/main.rs:226:30 [INFO] [stdout] | [INFO] [stdout] 226 | let _ = bufwtr.print(&mut wtr); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 226 - let _ = bufwtr.print(&mut wtr); [INFO] [stdout] 226 + let _ = bufwtr.print(&wtr); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/core/main.rs:226:30 [INFO] [stdout] | [INFO] [stdout] 226 | let _ = bufwtr.print(&mut wtr); [INFO] [stdout] | ^^^^^^^^ help: change this to: `wtr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> crates/core/main.rs:459:9 [INFO] [stdout] | [INFO] [stdout] 459 | write!(wtr, "\n") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] = note: `#[warn(clippy::write_with_newline)]` on by default [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 459 - write!(wtr, "\n") [INFO] [stdout] 459 + writeln!(wtr) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> crates/core/messages.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 73 | if crate::messages::messages() { [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] = note: `#[warn(clippy::crate_in_macro_def)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> crates/core/messages.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | crate::messages::set_errored(); [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> crates/core/messages.rs:94:12 [INFO] [stdout] | [INFO] [stdout] 94 | if crate::messages::messages() && crate::messages::ignore_messages() { [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/complete/mod.rs:5:20 [INFO] [stdout] | [INFO] [stdout] 5 | static ENCODINGS: &'static str = include_str!("encodings.sh"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/complete/bash.rs:7:23 [INFO] [stdout] | [INFO] [stdout] 7 | const TEMPLATE_FULL: &'static str = " [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/complete/bash.rs:45:23 [INFO] [stdout] | [INFO] [stdout] 45 | const TEMPLATE_CASE: &'static str = " [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/complete/bash.rs:52:31 [INFO] [stdout] | [INFO] [stdout] 52 | const TEMPLATE_CASE_CHOICES: &'static str = " [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/complete/fish.rs:7:18 [INFO] [stdout] | [INFO] [stdout] 7 | const TEMPLATE: &'static str = "complete -c rg !SHORT! -l !LONG! -d '!DOC!'"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/complete/fish.rs:8:26 [INFO] [stdout] | [INFO] [stdout] 8 | const TEMPLATE_NEGATED: &'static str = "complete -c rg -l !NEGATED! -n '__rg_contains_opt !LONG! !SHORT!' -d '!DOC!'\n"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/complete/powershell.rs:7:18 [INFO] [stdout] | [INFO] [stdout] 7 | const TEMPLATE: &'static str = " [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/complete/powershell.rs:37:23 [INFO] [stdout] | [INFO] [stdout] 37 | const TEMPLATE_FLAG: &'static str = "[CompletionResult]::new('!DASH_NAME!', '!NAME!', [CompletionResultType]::ParameterName, '!DOC!')"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/doc/help.rs:13:24 [INFO] [stdout] | [INFO] [stdout] 13 | const TEMPLATE_SHORT: &'static str = include_str!("template.short.help"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/doc/help.rs:14:23 [INFO] [stdout] | [INFO] [stdout] 14 | const TEMPLATE_LONG: &'static str = include_str!("template.long.help"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/flags/doc/man.rs:9:18 [INFO] [stdout] | [INFO] [stdout] 9 | const TEMPLATE: &'static str = include_str!("template.rg.1"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> crates/core/logger.rs:19:16 [INFO] [stdout] | [INFO] [stdout] 19 | const LOGGER: &'static Logger = &Logger(()); [INFO] [stdout] | -^^^^^^^------- help: consider removing `'static`: `&Logger` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> tests/macros.rs:6:30 [INFO] [stdout] | [INFO] [stdout] 6 | let (dir, cmd) = crate::util::setup(stringify!($name)); [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] = note: `#[warn(clippy::crate_in_macro_def)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> tests/hay.rs:1:22 [INFO] [stdout] | [INFO] [stdout] 1 | pub const SHERLOCK: &'static str = "\ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> tests/hay.rs:10:27 [INFO] [stdout] | [INFO] [stdout] 10 | pub const SHERLOCK_CRLF: &'static str = "\ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> tests/util.rs:14:19 [INFO] [stdout] | [INFO] [stdout] 14 | static TEST_DIR: &'static str = "ripgrep-tests"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> tests/binary.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | const HAY: &'static [u8] = include_bytes!("./data/sherlock-nul.txt"); [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> tests/feature.rs:623:22 [INFO] [stdout] | [INFO] [stdout] 623 | const SHERLOCK: &'static str = "\ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> tests/feature.rs:649:22 [INFO] [stdout] | [INFO] [stdout] 649 | const SHERLOCK: &'static str = "\ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/core/flags/complete/fish.rs:26:32 [INFO] [stdout] | [INFO] [stdout] 26 | .replace("!LONG!", &long) [INFO] [stdout] | ^^^^^ help: change this to: `long` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> crates/core/flags/complete/fish.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 44 | completion.push_str("'"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `completion.push('\'')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> crates/core/flags/complete/fish.rs:49:17 [INFO] [stdout] | [INFO] [stdout] 49 | completion.push_str("'"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `completion.push('\'')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/core/flags/complete/fish.rs:67:43 [INFO] [stdout] | [INFO] [stdout] 67 | .replace("!NEGATED!", &negated) [INFO] [stdout] | ^^^^^^^^ help: change this to: `negated` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/core/flags/complete/fish.rs:69:40 [INFO] [stdout] | [INFO] [stdout] 69 | .replace("!LONG!", &long) [INFO] [stdout] | ^^^^^ help: change this to: `long` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/core/flags/complete/powershell.rs:57:36 [INFO] [stdout] | [INFO] [stdout] 57 | .replace("!NAME!", &name) [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/core/flags/complete/powershell.rs:79:40 [INFO] [stdout] | [INFO] [stdout] 79 | .replace("!NAME!", &negated) [INFO] [stdout] | ^^^^^^^^ help: change this to: `negated` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/core/flags/complete/zsh.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | Namely, the zsh completions take application level context about flag [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 9 | Namely, the zsh completions take application level context about flag [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/core/flags/complete/zsh.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | compatibility into account. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 10 | compatibility into account. [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/core/flags/complete/zsh.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | isn't included in the zsh completions. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 12 | isn't included in the zsh completions. [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> crates/core/flags/complete/zsh.rs:14:1 [INFO] [stdout] | [INFO] [stdout] 14 | works and how it can be extended. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 14 | works and how it can be extended. [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/core/flags/config.rs:61:31 [INFO] [stdout] | [INFO] [stdout] 61 | match std::fs::File::open(&path) { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:621:5 [INFO] [stdout] | [INFO] [stdout] 621 | assert_eq!(false, args.byte_offset); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 621 - assert_eq!(false, args.byte_offset); [INFO] [stdout] 621 + assert!(!args.byte_offset); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:624:5 [INFO] [stdout] | [INFO] [stdout] 624 | assert_eq!(true, args.byte_offset); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 624 - assert_eq!(true, args.byte_offset); [INFO] [stdout] 624 + assert!(args.byte_offset); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:627:5 [INFO] [stdout] | [INFO] [stdout] 627 | assert_eq!(true, args.byte_offset); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 627 - assert_eq!(true, args.byte_offset); [INFO] [stdout] 627 + assert!(args.byte_offset); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:630:5 [INFO] [stdout] | [INFO] [stdout] 630 | assert_eq!(false, args.byte_offset); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 630 - assert_eq!(false, args.byte_offset); [INFO] [stdout] 630 + assert!(!args.byte_offset); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:633:5 [INFO] [stdout] | [INFO] [stdout] 633 | assert_eq!(true, args.byte_offset); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 633 - assert_eq!(true, args.byte_offset); [INFO] [stdout] 633 + assert!(args.byte_offset); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:1431:5 [INFO] [stdout] | [INFO] [stdout] 1431 | assert_eq!(false, args.crlf); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1431 - assert_eq!(false, args.crlf); [INFO] [stdout] 1431 + assert!(!args.crlf); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:1434:5 [INFO] [stdout] | [INFO] [stdout] 1434 | assert_eq!(true, args.crlf); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1434 - assert_eq!(true, args.crlf); [INFO] [stdout] 1434 + assert!(args.crlf); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:1435:5 [INFO] [stdout] | [INFO] [stdout] 1435 | assert_eq!(false, args.null_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1435 - assert_eq!(false, args.null_data); [INFO] [stdout] 1435 + assert!(!args.null_data); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:1438:5 [INFO] [stdout] | [INFO] [stdout] 1438 | assert_eq!(false, args.crlf); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1438 - assert_eq!(false, args.crlf); [INFO] [stdout] 1438 + assert!(!args.crlf); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:1439:5 [INFO] [stdout] | [INFO] [stdout] 1439 | assert_eq!(true, args.null_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1439 - assert_eq!(true, args.null_data); [INFO] [stdout] 1439 + assert!(args.null_data); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:1442:5 [INFO] [stdout] | [INFO] [stdout] 1442 | assert_eq!(true, args.crlf); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1442 - assert_eq!(true, args.crlf); [INFO] [stdout] 1442 + assert!(args.crlf); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:1443:5 [INFO] [stdout] | [INFO] [stdout] 1443 | assert_eq!(false, args.null_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1443 - assert_eq!(false, args.null_data); [INFO] [stdout] 1443 + assert!(!args.null_data); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:1446:5 [INFO] [stdout] | [INFO] [stdout] 1446 | assert_eq!(false, args.crlf); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1446 - assert_eq!(false, args.crlf); [INFO] [stdout] 1446 + assert!(!args.crlf); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:1447:5 [INFO] [stdout] | [INFO] [stdout] 1447 | assert_eq!(true, args.null_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1447 - assert_eq!(true, args.null_data); [INFO] [stdout] 1447 + assert!(args.null_data); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:1450:5 [INFO] [stdout] | [INFO] [stdout] 1450 | assert_eq!(false, args.crlf); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1450 - assert_eq!(false, args.crlf); [INFO] [stdout] 1450 + assert!(!args.crlf); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:1451:5 [INFO] [stdout] | [INFO] [stdout] 1451 | assert_eq!(false, args.null_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1451 - assert_eq!(false, args.null_data); [INFO] [stdout] 1451 + assert!(!args.null_data); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2324:5 [INFO] [stdout] | [INFO] [stdout] 2324 | assert_eq!(false, args.fixed_strings); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2324 - assert_eq!(false, args.fixed_strings); [INFO] [stdout] 2324 + assert!(!args.fixed_strings); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2327:5 [INFO] [stdout] | [INFO] [stdout] 2327 | assert_eq!(true, args.fixed_strings); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2327 - assert_eq!(true, args.fixed_strings); [INFO] [stdout] 2327 + assert!(args.fixed_strings); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2330:5 [INFO] [stdout] | [INFO] [stdout] 2330 | assert_eq!(true, args.fixed_strings); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2330 - assert_eq!(true, args.fixed_strings); [INFO] [stdout] 2330 + assert!(args.fixed_strings); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2333:5 [INFO] [stdout] | [INFO] [stdout] 2333 | assert_eq!(false, args.fixed_strings); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2333 - assert_eq!(false, args.fixed_strings); [INFO] [stdout] 2333 + assert!(!args.fixed_strings); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2336:5 [INFO] [stdout] | [INFO] [stdout] 2336 | assert_eq!(true, args.fixed_strings); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2336 - assert_eq!(true, args.fixed_strings); [INFO] [stdout] 2336 + assert!(args.fixed_strings); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2382:5 [INFO] [stdout] | [INFO] [stdout] 2382 | assert_eq!(false, args.follow); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2382 - assert_eq!(false, args.follow); [INFO] [stdout] 2382 + assert!(!args.follow); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2385:5 [INFO] [stdout] | [INFO] [stdout] 2385 | assert_eq!(true, args.follow); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2385 - assert_eq!(true, args.follow); [INFO] [stdout] 2385 + assert!(args.follow); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2388:5 [INFO] [stdout] | [INFO] [stdout] 2388 | assert_eq!(true, args.follow); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2388 - assert_eq!(true, args.follow); [INFO] [stdout] 2388 + assert!(args.follow); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2391:5 [INFO] [stdout] | [INFO] [stdout] 2391 | assert_eq!(false, args.follow); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2391 - assert_eq!(false, args.follow); [INFO] [stdout] 2391 + assert!(!args.follow); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2394:5 [INFO] [stdout] | [INFO] [stdout] 2394 | assert_eq!(true, args.follow); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2394 - assert_eq!(true, args.follow); [INFO] [stdout] 2394 + assert!(args.follow); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2629:5 [INFO] [stdout] | [INFO] [stdout] 2629 | assert_eq!(false, args.glob_case_insensitive); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2629 - assert_eq!(false, args.glob_case_insensitive); [INFO] [stdout] 2629 + assert!(!args.glob_case_insensitive); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2632:5 [INFO] [stdout] | [INFO] [stdout] 2632 | assert_eq!(true, args.glob_case_insensitive); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2632 - assert_eq!(true, args.glob_case_insensitive); [INFO] [stdout] 2632 + assert!(args.glob_case_insensitive); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2639:5 [INFO] [stdout] | [INFO] [stdout] 2639 | assert_eq!(false, args.glob_case_insensitive); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2639 - assert_eq!(false, args.glob_case_insensitive); [INFO] [stdout] 2639 + assert!(!args.glob_case_insensitive); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2646:5 [INFO] [stdout] | [INFO] [stdout] 2646 | assert_eq!(true, args.glob_case_insensitive); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2646 - assert_eq!(true, args.glob_case_insensitive); [INFO] [stdout] 2646 + assert!(args.glob_case_insensitive); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2820:5 [INFO] [stdout] | [INFO] [stdout] 2820 | assert_eq!(false, args.hidden); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2820 - assert_eq!(false, args.hidden); [INFO] [stdout] 2820 + assert!(!args.hidden); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2823:5 [INFO] [stdout] | [INFO] [stdout] 2823 | assert_eq!(true, args.hidden); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2823 - assert_eq!(true, args.hidden); [INFO] [stdout] 2823 + assert!(args.hidden); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2826:5 [INFO] [stdout] | [INFO] [stdout] 2826 | assert_eq!(true, args.hidden); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2826 - assert_eq!(true, args.hidden); [INFO] [stdout] 2826 + assert!(args.hidden); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2829:5 [INFO] [stdout] | [INFO] [stdout] 2829 | assert_eq!(false, args.hidden); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2829 - assert_eq!(false, args.hidden); [INFO] [stdout] 2829 + assert!(!args.hidden); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:2832:5 [INFO] [stdout] | [INFO] [stdout] 2832 | assert_eq!(true, args.hidden); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2832 - assert_eq!(true, args.hidden); [INFO] [stdout] 2832 + assert!(args.hidden); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> crates/core/flags/defs.rs:3038:9 [INFO] [stdout] | [INFO] [stdout] 3038 | &*BORROWED [INFO] [stdout] | ^^^^^^^^^^ help: try: `&BORROWED` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:3308:5 [INFO] [stdout] | [INFO] [stdout] 3308 | assert_eq!(false, args.ignore_file_case_insensitive); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3308 - assert_eq!(false, args.ignore_file_case_insensitive); [INFO] [stdout] 3308 + assert!(!args.ignore_file_case_insensitive); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:3311:5 [INFO] [stdout] | [INFO] [stdout] 3311 | assert_eq!(true, args.ignore_file_case_insensitive); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3311 - assert_eq!(true, args.ignore_file_case_insensitive); [INFO] [stdout] 3311 + assert!(args.ignore_file_case_insensitive); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:3318:5 [INFO] [stdout] | [INFO] [stdout] 3318 | assert_eq!(false, args.ignore_file_case_insensitive); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3318 - assert_eq!(false, args.ignore_file_case_insensitive); [INFO] [stdout] 3318 + assert!(!args.ignore_file_case_insensitive); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:3325:5 [INFO] [stdout] | [INFO] [stdout] 3325 | assert_eq!(true, args.ignore_file_case_insensitive); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3325 - assert_eq!(true, args.ignore_file_case_insensitive); [INFO] [stdout] 3325 + assert!(args.ignore_file_case_insensitive); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:3367:5 [INFO] [stdout] | [INFO] [stdout] 3367 | assert_eq!(false, args.include_zero); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3367 - assert_eq!(false, args.include_zero); [INFO] [stdout] 3367 + assert!(!args.include_zero); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:3370:5 [INFO] [stdout] | [INFO] [stdout] 3370 | assert_eq!(true, args.include_zero); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3370 - assert_eq!(true, args.include_zero); [INFO] [stdout] 3370 + assert!(args.include_zero); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:3373:5 [INFO] [stdout] | [INFO] [stdout] 3373 | assert_eq!(false, args.include_zero); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3373 - assert_eq!(false, args.include_zero); [INFO] [stdout] 3373 + assert!(!args.include_zero); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:3422:5 [INFO] [stdout] | [INFO] [stdout] 3422 | assert_eq!(false, args.invert_match); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3422 - assert_eq!(false, args.invert_match); [INFO] [stdout] 3422 + assert!(!args.invert_match); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:3425:5 [INFO] [stdout] | [INFO] [stdout] 3425 | assert_eq!(true, args.invert_match); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3425 - assert_eq!(true, args.invert_match); [INFO] [stdout] 3425 + assert!(args.invert_match); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:3428:5 [INFO] [stdout] | [INFO] [stdout] 3428 | assert_eq!(true, args.invert_match); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3428 - assert_eq!(true, args.invert_match); [INFO] [stdout] 3428 + assert!(args.invert_match); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:3431:5 [INFO] [stdout] | [INFO] [stdout] 3431 | assert_eq!(false, args.invert_match); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3431 - assert_eq!(false, args.invert_match); [INFO] [stdout] 3431 + assert!(!args.invert_match); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JSON` contains a capitalized acronym [INFO] [stdout] --> crates/core/flags/defs.rs:3436:8 [INFO] [stdout] | [INFO] [stdout] 3436 | struct JSON; [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Json` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:3861:5 [INFO] [stdout] | [INFO] [stdout] 3861 | assert_eq!(false, args.max_columns_preview); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3861 - assert_eq!(false, args.max_columns_preview); [INFO] [stdout] 3861 + assert!(!args.max_columns_preview); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:3864:5 [INFO] [stdout] | [INFO] [stdout] 3864 | assert_eq!(true, args.max_columns_preview); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3864 - assert_eq!(true, args.max_columns_preview); [INFO] [stdout] 3864 + assert!(args.max_columns_preview); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:3869:5 [INFO] [stdout] | [INFO] [stdout] 3869 | assert_eq!(false, args.max_columns_preview); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3869 - assert_eq!(false, args.max_columns_preview); [INFO] [stdout] 3869 + assert!(!args.max_columns_preview); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4200:5 [INFO] [stdout] | [INFO] [stdout] 4200 | assert_eq!(false, args.multiline); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4200 - assert_eq!(false, args.multiline); [INFO] [stdout] 4200 + assert!(!args.multiline); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4203:5 [INFO] [stdout] | [INFO] [stdout] 4203 | assert_eq!(true, args.multiline); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4203 - assert_eq!(true, args.multiline); [INFO] [stdout] 4203 + assert!(args.multiline); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4206:5 [INFO] [stdout] | [INFO] [stdout] 4206 | assert_eq!(true, args.multiline); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4206 - assert_eq!(true, args.multiline); [INFO] [stdout] 4206 + assert!(args.multiline); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4209:5 [INFO] [stdout] | [INFO] [stdout] 4209 | assert_eq!(false, args.multiline); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4209 - assert_eq!(false, args.multiline); [INFO] [stdout] 4209 + assert!(!args.multiline); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4264:5 [INFO] [stdout] | [INFO] [stdout] 4264 | assert_eq!(false, args.multiline_dotall); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4264 - assert_eq!(false, args.multiline_dotall); [INFO] [stdout] 4264 + assert!(!args.multiline_dotall); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4267:5 [INFO] [stdout] | [INFO] [stdout] 4267 | assert_eq!(true, args.multiline_dotall); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4267 - assert_eq!(true, args.multiline_dotall); [INFO] [stdout] 4267 + assert!(args.multiline_dotall); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4271:5 [INFO] [stdout] | [INFO] [stdout] 4271 | assert_eq!(false, args.multiline_dotall); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4271 - assert_eq!(false, args.multiline_dotall); [INFO] [stdout] 4271 + assert!(!args.multiline_dotall); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4313:5 [INFO] [stdout] | [INFO] [stdout] 4313 | assert_eq!(false, args.no_config); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4313 - assert_eq!(false, args.no_config); [INFO] [stdout] 4313 + assert!(!args.no_config); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4316:5 [INFO] [stdout] | [INFO] [stdout] 4316 | assert_eq!(true, args.no_config); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4316 - assert_eq!(true, args.no_config); [INFO] [stdout] 4316 + assert!(args.no_config); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4370:5 [INFO] [stdout] | [INFO] [stdout] 4370 | assert_eq!(false, args.no_ignore_dot); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4370 - assert_eq!(false, args.no_ignore_dot); [INFO] [stdout] 4370 + assert!(!args.no_ignore_dot); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4371:5 [INFO] [stdout] | [INFO] [stdout] 4371 | assert_eq!(false, args.no_ignore_exclude); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4371 - assert_eq!(false, args.no_ignore_exclude); [INFO] [stdout] 4371 + assert!(!args.no_ignore_exclude); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4372:5 [INFO] [stdout] | [INFO] [stdout] 4372 | assert_eq!(false, args.no_ignore_global); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4372 - assert_eq!(false, args.no_ignore_global); [INFO] [stdout] 4372 + assert!(!args.no_ignore_global); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4373:5 [INFO] [stdout] | [INFO] [stdout] 4373 | assert_eq!(false, args.no_ignore_parent); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4373 - assert_eq!(false, args.no_ignore_parent); [INFO] [stdout] 4373 + assert!(!args.no_ignore_parent); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4374:5 [INFO] [stdout] | [INFO] [stdout] 4374 | assert_eq!(false, args.no_ignore_vcs); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4374 - assert_eq!(false, args.no_ignore_vcs); [INFO] [stdout] 4374 + assert!(!args.no_ignore_vcs); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4377:5 [INFO] [stdout] | [INFO] [stdout] 4377 | assert_eq!(true, args.no_ignore_dot); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4377 - assert_eq!(true, args.no_ignore_dot); [INFO] [stdout] 4377 + assert!(args.no_ignore_dot); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4378:5 [INFO] [stdout] | [INFO] [stdout] 4378 | assert_eq!(true, args.no_ignore_exclude); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4378 - assert_eq!(true, args.no_ignore_exclude); [INFO] [stdout] 4378 + assert!(args.no_ignore_exclude); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4379:5 [INFO] [stdout] | [INFO] [stdout] 4379 | assert_eq!(true, args.no_ignore_global); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4379 - assert_eq!(true, args.no_ignore_global); [INFO] [stdout] 4379 + assert!(args.no_ignore_global); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4380:5 [INFO] [stdout] | [INFO] [stdout] 4380 | assert_eq!(true, args.no_ignore_parent); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4380 - assert_eq!(true, args.no_ignore_parent); [INFO] [stdout] 4380 + assert!(args.no_ignore_parent); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4381:5 [INFO] [stdout] | [INFO] [stdout] 4381 | assert_eq!(true, args.no_ignore_vcs); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4381 - assert_eq!(true, args.no_ignore_vcs); [INFO] [stdout] 4381 + assert!(args.no_ignore_vcs); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4384:5 [INFO] [stdout] | [INFO] [stdout] 4384 | assert_eq!(false, args.no_ignore_dot); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4384 - assert_eq!(false, args.no_ignore_dot); [INFO] [stdout] 4384 + assert!(!args.no_ignore_dot); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4385:5 [INFO] [stdout] | [INFO] [stdout] 4385 | assert_eq!(false, args.no_ignore_exclude); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4385 - assert_eq!(false, args.no_ignore_exclude); [INFO] [stdout] 4385 + assert!(!args.no_ignore_exclude); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4386:5 [INFO] [stdout] | [INFO] [stdout] 4386 | assert_eq!(false, args.no_ignore_global); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4386 - assert_eq!(false, args.no_ignore_global); [INFO] [stdout] 4386 + assert!(!args.no_ignore_global); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4387:5 [INFO] [stdout] | [INFO] [stdout] 4387 | assert_eq!(false, args.no_ignore_parent); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4387 - assert_eq!(false, args.no_ignore_parent); [INFO] [stdout] 4387 + assert!(!args.no_ignore_parent); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4388:5 [INFO] [stdout] | [INFO] [stdout] 4388 | assert_eq!(false, args.no_ignore_vcs); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4388 - assert_eq!(false, args.no_ignore_vcs); [INFO] [stdout] 4388 + assert!(!args.no_ignore_vcs); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4431:5 [INFO] [stdout] | [INFO] [stdout] 4431 | assert_eq!(false, args.no_ignore_dot); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4431 - assert_eq!(false, args.no_ignore_dot); [INFO] [stdout] 4431 + assert!(!args.no_ignore_dot); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4434:5 [INFO] [stdout] | [INFO] [stdout] 4434 | assert_eq!(true, args.no_ignore_dot); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4434 - assert_eq!(true, args.no_ignore_dot); [INFO] [stdout] 4434 + assert!(args.no_ignore_dot); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4437:5 [INFO] [stdout] | [INFO] [stdout] 4437 | assert_eq!(false, args.no_ignore_dot); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4437 - assert_eq!(false, args.no_ignore_dot); [INFO] [stdout] 4437 + assert!(!args.no_ignore_dot); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4477:5 [INFO] [stdout] | [INFO] [stdout] 4477 | assert_eq!(false, args.no_ignore_exclude); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4477 - assert_eq!(false, args.no_ignore_exclude); [INFO] [stdout] 4477 + assert!(!args.no_ignore_exclude); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4480:5 [INFO] [stdout] | [INFO] [stdout] 4480 | assert_eq!(true, args.no_ignore_exclude); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4480 - assert_eq!(true, args.no_ignore_exclude); [INFO] [stdout] 4480 + assert!(args.no_ignore_exclude); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4484:5 [INFO] [stdout] | [INFO] [stdout] 4484 | assert_eq!(false, args.no_ignore_exclude); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4484 - assert_eq!(false, args.no_ignore_exclude); [INFO] [stdout] 4484 + assert!(!args.no_ignore_exclude); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4524:5 [INFO] [stdout] | [INFO] [stdout] 4524 | assert_eq!(false, args.no_ignore_files); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4524 - assert_eq!(false, args.no_ignore_files); [INFO] [stdout] 4524 + assert!(!args.no_ignore_files); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4527:5 [INFO] [stdout] | [INFO] [stdout] 4527 | assert_eq!(true, args.no_ignore_files); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4527 - assert_eq!(true, args.no_ignore_files); [INFO] [stdout] 4527 + assert!(args.no_ignore_files); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4530:5 [INFO] [stdout] | [INFO] [stdout] 4530 | assert_eq!(false, args.no_ignore_files); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4530 - assert_eq!(false, args.no_ignore_files); [INFO] [stdout] 4530 + assert!(!args.no_ignore_files); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4571:5 [INFO] [stdout] | [INFO] [stdout] 4571 | assert_eq!(false, args.no_ignore_global); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4571 - assert_eq!(false, args.no_ignore_global); [INFO] [stdout] 4571 + assert!(!args.no_ignore_global); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4574:5 [INFO] [stdout] | [INFO] [stdout] 4574 | assert_eq!(true, args.no_ignore_global); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4574 - assert_eq!(true, args.no_ignore_global); [INFO] [stdout] 4574 + assert!(args.no_ignore_global); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4578:5 [INFO] [stdout] | [INFO] [stdout] 4578 | assert_eq!(false, args.no_ignore_global); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4578 - assert_eq!(false, args.no_ignore_global); [INFO] [stdout] 4578 + assert!(!args.no_ignore_global); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4620:5 [INFO] [stdout] | [INFO] [stdout] 4620 | assert_eq!(false, args.no_ignore_messages); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4620 - assert_eq!(false, args.no_ignore_messages); [INFO] [stdout] 4620 + assert!(!args.no_ignore_messages); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4623:5 [INFO] [stdout] | [INFO] [stdout] 4623 | assert_eq!(true, args.no_ignore_messages); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4623 - assert_eq!(true, args.no_ignore_messages); [INFO] [stdout] 4623 + assert!(args.no_ignore_messages); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4627:5 [INFO] [stdout] | [INFO] [stdout] 4627 | assert_eq!(false, args.no_ignore_messages); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4627 - assert_eq!(false, args.no_ignore_messages); [INFO] [stdout] 4627 + assert!(!args.no_ignore_messages); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4669:5 [INFO] [stdout] | [INFO] [stdout] 4669 | assert_eq!(false, args.no_ignore_parent); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4669 - assert_eq!(false, args.no_ignore_parent); [INFO] [stdout] 4669 + assert!(!args.no_ignore_parent); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4672:5 [INFO] [stdout] | [INFO] [stdout] 4672 | assert_eq!(true, args.no_ignore_parent); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4672 - assert_eq!(true, args.no_ignore_parent); [INFO] [stdout] 4672 + assert!(args.no_ignore_parent); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4676:5 [INFO] [stdout] | [INFO] [stdout] 4676 | assert_eq!(false, args.no_ignore_parent); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4676 - assert_eq!(false, args.no_ignore_parent); [INFO] [stdout] 4676 + assert!(!args.no_ignore_parent); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4726:5 [INFO] [stdout] | [INFO] [stdout] 4726 | assert_eq!(false, args.no_ignore_vcs); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4726 - assert_eq!(false, args.no_ignore_vcs); [INFO] [stdout] 4726 + assert!(!args.no_ignore_vcs); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4729:5 [INFO] [stdout] | [INFO] [stdout] 4729 | assert_eq!(true, args.no_ignore_vcs); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4729 - assert_eq!(true, args.no_ignore_vcs); [INFO] [stdout] 4729 + assert!(args.no_ignore_vcs); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4732:5 [INFO] [stdout] | [INFO] [stdout] 4732 | assert_eq!(false, args.no_ignore_vcs); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4732 - assert_eq!(false, args.no_ignore_vcs); [INFO] [stdout] 4732 + assert!(!args.no_ignore_vcs); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4773:5 [INFO] [stdout] | [INFO] [stdout] 4773 | assert_eq!(false, args.no_messages); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4773 - assert_eq!(false, args.no_messages); [INFO] [stdout] 4773 + assert!(!args.no_messages); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4776:5 [INFO] [stdout] | [INFO] [stdout] 4776 | assert_eq!(true, args.no_messages); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4776 - assert_eq!(true, args.no_messages); [INFO] [stdout] 4776 + assert!(args.no_messages); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4779:5 [INFO] [stdout] | [INFO] [stdout] 4779 | assert_eq!(false, args.no_messages); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4779 - assert_eq!(false, args.no_messages); [INFO] [stdout] 4779 + assert!(!args.no_messages); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4820:5 [INFO] [stdout] | [INFO] [stdout] 4820 | assert_eq!(false, args.no_unicode); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4820 - assert_eq!(false, args.no_unicode); [INFO] [stdout] 4820 + assert!(!args.no_unicode); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4823:5 [INFO] [stdout] | [INFO] [stdout] 4823 | assert_eq!(true, args.no_unicode); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4823 - assert_eq!(true, args.no_unicode); [INFO] [stdout] 4823 + assert!(args.no_unicode); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4827:5 [INFO] [stdout] | [INFO] [stdout] 4827 | assert_eq!(false, args.no_unicode); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4827 - assert_eq!(false, args.no_unicode); [INFO] [stdout] 4827 + assert!(!args.no_unicode); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4875:5 [INFO] [stdout] | [INFO] [stdout] 4875 | assert_eq!(false, args.no_require_git); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4875 - assert_eq!(false, args.no_require_git); [INFO] [stdout] 4875 + assert!(!args.no_require_git); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4878:5 [INFO] [stdout] | [INFO] [stdout] 4878 | assert_eq!(true, args.no_require_git); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4878 - assert_eq!(true, args.no_require_git); [INFO] [stdout] 4878 + assert!(args.no_require_git); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4881:5 [INFO] [stdout] | [INFO] [stdout] 4881 | assert_eq!(false, args.no_require_git); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4881 - assert_eq!(false, args.no_require_git); [INFO] [stdout] 4881 + assert!(!args.no_require_git); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4948:5 [INFO] [stdout] | [INFO] [stdout] 4948 | assert_eq!(false, args.no_unicode); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4948 - assert_eq!(false, args.no_unicode); [INFO] [stdout] 4948 + assert!(!args.no_unicode); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4951:5 [INFO] [stdout] | [INFO] [stdout] 4951 | assert_eq!(true, args.no_unicode); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4951 - assert_eq!(true, args.no_unicode); [INFO] [stdout] 4951 + assert!(args.no_unicode); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4954:5 [INFO] [stdout] | [INFO] [stdout] 4954 | assert_eq!(false, args.no_unicode); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4954 - assert_eq!(false, args.no_unicode); [INFO] [stdout] 4954 + assert!(!args.no_unicode); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4957:5 [INFO] [stdout] | [INFO] [stdout] 4957 | assert_eq!(false, args.no_unicode); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4957 - assert_eq!(false, args.no_unicode); [INFO] [stdout] 4957 + assert!(!args.no_unicode); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:4960:5 [INFO] [stdout] | [INFO] [stdout] 4960 | assert_eq!(false, args.no_unicode); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4960 - assert_eq!(false, args.no_unicode); [INFO] [stdout] 4960 + assert!(!args.no_unicode); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5003:5 [INFO] [stdout] | [INFO] [stdout] 5003 | assert_eq!(false, args.null); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5003 - assert_eq!(false, args.null); [INFO] [stdout] 5003 + assert!(!args.null); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5006:5 [INFO] [stdout] | [INFO] [stdout] 5006 | assert_eq!(true, args.null); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5006 - assert_eq!(true, args.null); [INFO] [stdout] 5006 + assert!(args.null); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5009:5 [INFO] [stdout] | [INFO] [stdout] 5009 | assert_eq!(true, args.null); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5009 - assert_eq!(true, args.null); [INFO] [stdout] 5009 + assert!(args.null); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5059:5 [INFO] [stdout] | [INFO] [stdout] 5059 | assert_eq!(false, args.null_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5059 - assert_eq!(false, args.null_data); [INFO] [stdout] 5059 + assert!(!args.null_data); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5062:5 [INFO] [stdout] | [INFO] [stdout] 5062 | assert_eq!(true, args.null_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5062 - assert_eq!(true, args.null_data); [INFO] [stdout] 5062 + assert!(args.null_data); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5065:5 [INFO] [stdout] | [INFO] [stdout] 5065 | assert_eq!(false, args.null_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5065 - assert_eq!(false, args.null_data); [INFO] [stdout] 5065 + assert!(!args.null_data); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5066:5 [INFO] [stdout] | [INFO] [stdout] 5066 | assert_eq!(true, args.crlf); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5066 - assert_eq!(true, args.crlf); [INFO] [stdout] 5066 + assert!(args.crlf); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5069:5 [INFO] [stdout] | [INFO] [stdout] 5069 | assert_eq!(true, args.null_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5069 - assert_eq!(true, args.null_data); [INFO] [stdout] 5069 + assert!(args.null_data); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5070:5 [INFO] [stdout] | [INFO] [stdout] 5070 | assert_eq!(false, args.crlf); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5070 - assert_eq!(false, args.crlf); [INFO] [stdout] 5070 + assert!(!args.crlf); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5073:5 [INFO] [stdout] | [INFO] [stdout] 5073 | assert_eq!(true, args.null_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5073 - assert_eq!(true, args.null_data); [INFO] [stdout] 5073 + assert!(args.null_data); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5074:5 [INFO] [stdout] | [INFO] [stdout] 5074 | assert_eq!(false, args.crlf); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5074 - assert_eq!(false, args.crlf); [INFO] [stdout] 5074 + assert!(!args.crlf); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5127:5 [INFO] [stdout] | [INFO] [stdout] 5127 | assert_eq!(false, args.one_file_system); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5127 - assert_eq!(false, args.one_file_system); [INFO] [stdout] 5127 + assert!(!args.one_file_system); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5130:5 [INFO] [stdout] | [INFO] [stdout] 5130 | assert_eq!(true, args.one_file_system); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5130 - assert_eq!(true, args.one_file_system); [INFO] [stdout] 5130 + assert!(args.one_file_system); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5134:5 [INFO] [stdout] | [INFO] [stdout] 5134 | assert_eq!(false, args.one_file_system); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5134 - assert_eq!(false, args.one_file_system); [INFO] [stdout] 5134 + assert!(!args.one_file_system); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5175:5 [INFO] [stdout] | [INFO] [stdout] 5175 | assert_eq!(false, args.only_matching); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5175 - assert_eq!(false, args.only_matching); [INFO] [stdout] 5175 + assert!(!args.only_matching); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5178:5 [INFO] [stdout] | [INFO] [stdout] 5178 | assert_eq!(true, args.only_matching); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5178 - assert_eq!(true, args.only_matching); [INFO] [stdout] 5178 + assert!(args.only_matching); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5181:5 [INFO] [stdout] | [INFO] [stdout] 5181 | assert_eq!(true, args.only_matching); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5181 - assert_eq!(true, args.only_matching); [INFO] [stdout] 5181 + assert!(args.only_matching); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5737:5 [INFO] [stdout] | [INFO] [stdout] 5737 | assert_eq!(false, args.quiet); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5737 - assert_eq!(false, args.quiet); [INFO] [stdout] 5737 + assert!(!args.quiet); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5740:5 [INFO] [stdout] | [INFO] [stdout] 5740 | assert_eq!(true, args.quiet); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5740 - assert_eq!(true, args.quiet); [INFO] [stdout] 5740 + assert!(args.quiet); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5743:5 [INFO] [stdout] | [INFO] [stdout] 5743 | assert_eq!(true, args.quiet); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5743 - assert_eq!(true, args.quiet); [INFO] [stdout] 5743 + assert!(args.quiet); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5747:5 [INFO] [stdout] | [INFO] [stdout] 5747 | assert_eq!(true, args.quiet); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5747 - assert_eq!(true, args.quiet); [INFO] [stdout] 5747 + assert!(args.quiet); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5750:5 [INFO] [stdout] | [INFO] [stdout] 5750 | assert_eq!(true, args.quiet); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5750 - assert_eq!(true, args.quiet); [INFO] [stdout] 5750 + assert!(args.quiet); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5753:5 [INFO] [stdout] | [INFO] [stdout] 5753 | assert_eq!(true, args.quiet); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5753 - assert_eq!(true, args.quiet); [INFO] [stdout] 5753 + assert!(args.quiet); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5756:5 [INFO] [stdout] | [INFO] [stdout] 5756 | assert_eq!(true, args.quiet); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5756 - assert_eq!(true, args.quiet); [INFO] [stdout] 5756 + assert!(args.quiet); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:5759:5 [INFO] [stdout] | [INFO] [stdout] 5759 | assert_eq!(true, args.quiet); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5759 - assert_eq!(true, args.quiet); [INFO] [stdout] 5759 + assert!(args.quiet); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:6115:5 [INFO] [stdout] | [INFO] [stdout] 6115 | assert_eq!(false, args.search_zip); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6115 - assert_eq!(false, args.search_zip); [INFO] [stdout] 6115 + assert!(!args.search_zip); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:6118:5 [INFO] [stdout] | [INFO] [stdout] 6118 | assert_eq!(true, args.search_zip); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6118 - assert_eq!(true, args.search_zip); [INFO] [stdout] 6118 + assert!(args.search_zip); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:6121:5 [INFO] [stdout] | [INFO] [stdout] 6121 | assert_eq!(true, args.search_zip); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6121 - assert_eq!(true, args.search_zip); [INFO] [stdout] 6121 + assert!(args.search_zip); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:6124:5 [INFO] [stdout] | [INFO] [stdout] 6124 | assert_eq!(false, args.search_zip); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6124 - assert_eq!(false, args.search_zip); [INFO] [stdout] 6124 + assert!(!args.search_zip); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:6128:5 [INFO] [stdout] | [INFO] [stdout] 6128 | assert_eq!(false, args.search_zip); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6128 - assert_eq!(false, args.search_zip); [INFO] [stdout] 6128 + assert!(!args.search_zip); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:6132:5 [INFO] [stdout] | [INFO] [stdout] 6132 | assert_eq!(true, args.search_zip); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6132 - assert_eq!(true, args.search_zip); [INFO] [stdout] 6132 + assert!(args.search_zip); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:6136:5 [INFO] [stdout] | [INFO] [stdout] 6136 | assert_eq!(false, args.search_zip); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6136 - assert_eq!(false, args.search_zip); [INFO] [stdout] 6136 + assert!(!args.search_zip); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:6561:5 [INFO] [stdout] | [INFO] [stdout] 6561 | assert_eq!(false, args.stats); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6561 - assert_eq!(false, args.stats); [INFO] [stdout] 6561 + assert!(!args.stats); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:6564:5 [INFO] [stdout] | [INFO] [stdout] 6564 | assert_eq!(true, args.stats); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6564 - assert_eq!(true, args.stats); [INFO] [stdout] 6564 + assert!(args.stats); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:6567:5 [INFO] [stdout] | [INFO] [stdout] 6567 | assert_eq!(false, args.stats); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6567 - assert_eq!(false, args.stats); [INFO] [stdout] 6567 + assert!(!args.stats); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:6610:5 [INFO] [stdout] | [INFO] [stdout] 6610 | assert_eq!(false, args.stop_on_nonmatch); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6610 - assert_eq!(false, args.stop_on_nonmatch); [INFO] [stdout] 6610 + assert!(!args.stop_on_nonmatch); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:6613:5 [INFO] [stdout] | [INFO] [stdout] 6613 | assert_eq!(true, args.stop_on_nonmatch); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6613 - assert_eq!(true, args.stop_on_nonmatch); [INFO] [stdout] 6613 + assert!(args.stop_on_nonmatch); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:6616:5 [INFO] [stdout] | [INFO] [stdout] 6616 | assert_eq!(true, args.multiline); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6616 - assert_eq!(true, args.multiline); [INFO] [stdout] 6616 + assert!(args.multiline); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:6617:5 [INFO] [stdout] | [INFO] [stdout] 6617 | assert_eq!(false, args.stop_on_nonmatch); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6617 - assert_eq!(false, args.stop_on_nonmatch); [INFO] [stdout] 6617 + assert!(!args.stop_on_nonmatch); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:6620:5 [INFO] [stdout] | [INFO] [stdout] 6620 | assert_eq!(false, args.multiline); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6620 - assert_eq!(false, args.multiline); [INFO] [stdout] 6620 + assert!(!args.multiline); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:6621:5 [INFO] [stdout] | [INFO] [stdout] 6621 | assert_eq!(true, args.stop_on_nonmatch); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6621 - assert_eq!(true, args.stop_on_nonmatch); [INFO] [stdout] 6621 + assert!(args.stop_on_nonmatch); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:6625:5 [INFO] [stdout] | [INFO] [stdout] 6625 | assert_eq!(false, args.multiline); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6625 - assert_eq!(false, args.multiline); [INFO] [stdout] 6625 + assert!(!args.multiline); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:6626:5 [INFO] [stdout] | [INFO] [stdout] 6626 | assert_eq!(true, args.stop_on_nonmatch); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6626 - assert_eq!(true, args.stop_on_nonmatch); [INFO] [stdout] 6626 + assert!(args.stop_on_nonmatch); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:6851:5 [INFO] [stdout] | [INFO] [stdout] 6851 | assert_eq!(false, args.trim); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6851 - assert_eq!(false, args.trim); [INFO] [stdout] 6851 + assert!(!args.trim); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:6854:5 [INFO] [stdout] | [INFO] [stdout] 6854 | assert_eq!(true, args.trim); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6854 - assert_eq!(true, args.trim); [INFO] [stdout] 6854 + assert!(args.trim); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:6857:5 [INFO] [stdout] | [INFO] [stdout] 6857 | assert_eq!(false, args.trim); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6857 - assert_eq!(false, args.trim); [INFO] [stdout] 6857 + assert!(!args.trim); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:7269:5 [INFO] [stdout] | [INFO] [stdout] 7269 | assert_eq!(false, args.no_ignore_vcs); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 7269 - assert_eq!(false, args.no_ignore_vcs); [INFO] [stdout] 7269 + assert!(!args.no_ignore_vcs); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:7270:5 [INFO] [stdout] | [INFO] [stdout] 7270 | assert_eq!(false, args.hidden); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 7270 - assert_eq!(false, args.hidden); [INFO] [stdout] 7270 + assert!(!args.hidden); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:7274:5 [INFO] [stdout] | [INFO] [stdout] 7274 | assert_eq!(true, args.no_ignore_vcs); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 7274 - assert_eq!(true, args.no_ignore_vcs); [INFO] [stdout] 7274 + assert!(args.no_ignore_vcs); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:7275:5 [INFO] [stdout] | [INFO] [stdout] 7275 | assert_eq!(false, args.hidden); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 7275 - assert_eq!(false, args.hidden); [INFO] [stdout] 7275 + assert!(!args.hidden); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:7279:5 [INFO] [stdout] | [INFO] [stdout] 7279 | assert_eq!(true, args.no_ignore_vcs); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 7279 - assert_eq!(true, args.no_ignore_vcs); [INFO] [stdout] 7279 + assert!(args.no_ignore_vcs); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:7280:5 [INFO] [stdout] | [INFO] [stdout] 7280 | assert_eq!(true, args.hidden); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 7280 - assert_eq!(true, args.hidden); [INFO] [stdout] 7280 + assert!(args.hidden); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:7284:5 [INFO] [stdout] | [INFO] [stdout] 7284 | assert_eq!(true, args.no_ignore_vcs); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 7284 - assert_eq!(true, args.no_ignore_vcs); [INFO] [stdout] 7284 + assert!(args.no_ignore_vcs); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:7285:5 [INFO] [stdout] | [INFO] [stdout] 7285 | assert_eq!(true, args.hidden); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 7285 - assert_eq!(true, args.hidden); [INFO] [stdout] 7285 + assert!(args.hidden); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:7398:5 [INFO] [stdout] | [INFO] [stdout] 7398 | assert_eq!(false, args.vimgrep); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 7398 - assert_eq!(false, args.vimgrep); [INFO] [stdout] 7398 + assert!(!args.vimgrep); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/core/flags/defs.rs:7401:5 [INFO] [stdout] | [INFO] [stdout] 7401 | assert_eq!(true, args.vimgrep); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 7401 - assert_eq!(true, args.vimgrep); [INFO] [stdout] 7401 + assert!(args.vimgrep); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/core/flags/doc/help.rs:118:34 [INFO] [stdout] | [INFO] [stdout] 118 | generate_long_flag(flag, &mut cat); [INFO] [stdout] | ^^^^^^^^ help: change this to: `cat` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> crates/core/flags/doc/help.rs:229:28 [INFO] [stdout] | [INFO] [stdout] 229 | lines.push(format!("{item_label}")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `item_label.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> crates/core/flags/doc/help.rs:236:28 [INFO] [stdout] | [INFO] [stdout] 236 | lines.push(format!("{pieces}")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `pieces.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/core/flags/doc/man.rs:34:29 [INFO] [stdout] | [INFO] [stdout] 34 | generate_flag(flag, &mut cat); [INFO] [stdout] | ^^^^^^^^ help: change this to: `cat` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> crates/core/flags/hiargs.rs:127:9 [INFO] [stdout] | [INFO] [stdout] 127 | / match low.mode { [INFO] [stdout] 128 | | Mode::Search(ref mut mode) => match *mode { [INFO] [stdout] 129 | | // treat `-v --count-matches` as `-v --count` [INFO] [stdout] 130 | | SearchMode::CountMatches if low.invert_match => { [INFO] [stdout] ... | [INFO] [stdout] 139 | | _ => {} [INFO] [stdout] 140 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 127 ~ if let Mode::Search(ref mut mode) = low.mode { match *mode { [INFO] [stdout] 128 + // treat `-v --count-matches` as `-v --count` [INFO] [stdout] 129 + SearchMode::CountMatches if low.invert_match => { [INFO] [stdout] 130 + *mode = SearchMode::Count; [INFO] [stdout] 131 + } [INFO] [stdout] 132 + // treat `-o --count` as `--count-matches` [INFO] [stdout] 133 + SearchMode::Count if low.only_matching => { [INFO] [stdout] 134 + *mode = SearchMode::CountMatches; [INFO] [stdout] 135 + } [INFO] [stdout] 136 + _ => {} [INFO] [stdout] 137 + } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> crates/core/flags/hiargs.rs:176:29 [INFO] [stdout] | [INFO] [stdout] 176 | let with_filename = low [INFO] [stdout] | _____________________________^ [INFO] [stdout] 177 | | .with_filename [INFO] [stdout] 178 | | .unwrap_or_else(|| low.vimgrep || !paths.is_one_file); [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 178 - .unwrap_or_else(|| low.vimgrep || !paths.is_one_file); [INFO] [stdout] 178 + .unwrap_or(low.vimgrep || !paths.is_one_file); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/core/flags/hiargs.rs:207:47 [INFO] [stdout] | [INFO] [stdout] 207 | | SearchMode::CountMatches => return false, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 207 - | SearchMode::CountMatches => return false, [INFO] [stdout] 207 + | SearchMode::CountMatches => false, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/core/flags/hiargs.rs:208:37 [INFO] [stdout] | [INFO] [stdout] 208 | SearchMode::JSON => return true, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 208 - SearchMode::JSON => return true, [INFO] [stdout] 208 + SearchMode::JSON => true, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> crates/core/flags/hiargs.rs:552:24 [INFO] [stdout] | [INFO] [stdout] 552 | .separator(self.path_separator.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.path_separator` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> crates/core/flags/hiargs.rs:623:30 [INFO] [stdout] | [INFO] [stdout] 623 | .path_terminator(self.path_terminator.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.path_terminator` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> crates/core/flags/hiargs.rs:634:29 [INFO] [stdout] | [INFO] [stdout] 634 | .separator_path(self.path_separator.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.path_separator` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> crates/core/flags/hiargs.rs:661:30 [INFO] [stdout] | [INFO] [stdout] 661 | .path_terminator(self.path_terminator.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.path_terminator` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> crates/core/flags/hiargs.rs:663:29 [INFO] [stdout] | [INFO] [stdout] 663 | .separator_path(self.path_separator.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.path_separator` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> crates/core/flags/hiargs.rs:786:36 [INFO] [stdout] | [INFO] [stdout] 786 | haystacks.sort_by(|ref h1, ref h2| { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 786 - haystacks.sort_by(|ref h1, ref h2| { [INFO] [stdout] 786 + haystacks.sort_by(|h1, ref h2| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> crates/core/flags/hiargs.rs:786:44 [INFO] [stdout] | [INFO] [stdout] 786 | haystacks.sort_by(|ref h1, ref h2| { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 786 - haystacks.sort_by(|ref h1, ref h2| { [INFO] [stdout] 786 + haystacks.sort_by(|ref h1, h2| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/core/flags/hiargs.rs:1228:21 [INFO] [stdout] | [INFO] [stdout] 1228 | builder.add(&glob)?; [INFO] [stdout] | ^^^^^ help: change this to: `glob` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JSON` contains a capitalized acronym [INFO] [stdout] --> crates/core/flags/lowargs.rs:213:5 [INFO] [stdout] | [INFO] [stdout] 213 | JSON, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Json` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/core/flags/lowargs.rs:254:1 [INFO] [stdout] | [INFO] [stdout] 254 | / impl Default for BinaryMode { [INFO] [stdout] 255 | | fn default() -> BinaryMode { [INFO] [stdout] 256 | | BinaryMode::Auto [INFO] [stdout] 257 | | } [INFO] [stdout] 258 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 233 + #[derive(Default)] [INFO] [stdout] 234 | pub(crate) enum BinaryMode { [INFO] [stdout] 235 | /// Automatically determine the binary mode to use. Essentially, when [INFO] [stdout] ... [INFO] [stdout] 239 | /// a file is classified as binary, searching will immediately stop. [INFO] [stdout] 240 ~ #[default] [INFO] [stdout] 241 ~ Auto, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/core/flags/lowargs.rs:290:1 [INFO] [stdout] | [INFO] [stdout] 290 | / impl Default for BufferMode { [INFO] [stdout] 291 | | fn default() -> BufferMode { [INFO] [stdout] 292 | | BufferMode::Auto [INFO] [stdout] 293 | | } [INFO] [stdout] 294 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 273 + #[derive(Default)] [INFO] [stdout] 274 | pub(crate) enum BufferMode { [INFO] [stdout] 275 | /// Select the buffer mode, 'line' or 'block', automatically based on [INFO] [stdout] 276 | /// whether stdout is connected to a tty. [INFO] [stdout] 277 ~ #[default] [INFO] [stdout] 278 ~ Auto, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/core/flags/lowargs.rs:311:1 [INFO] [stdout] | [INFO] [stdout] 311 | / impl Default for CaseMode { [INFO] [stdout] 312 | | fn default() -> CaseMode { [INFO] [stdout] 313 | | CaseMode::Sensitive [INFO] [stdout] 314 | | } [INFO] [stdout] 315 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 300 + #[derive(Default)] [INFO] [stdout] 301 | pub(crate) enum CaseMode { [INFO] [stdout] 302 | /// Patterns are matched case sensitively. i.e., `a` does not match `A`. [INFO] [stdout] 303 ~ #[default] [INFO] [stdout] 304 ~ Sensitive, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/core/flags/lowargs.rs:338:1 [INFO] [stdout] | [INFO] [stdout] 338 | / impl Default for ColorChoice { [INFO] [stdout] 339 | | fn default() -> ColorChoice { [INFO] [stdout] 340 | | ColorChoice::Auto [INFO] [stdout] 341 | | } [INFO] [stdout] 342 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 321 + #[derive(Default)] [INFO] [stdout] 322 | pub(crate) enum ColorChoice { [INFO] [stdout] 323 | /// Color and hyperlinks will never be used. [INFO] [stdout] ... [INFO] [stdout] 326 | /// tty. [INFO] [stdout] 327 ~ #[default] [INFO] [stdout] 328 ~ Auto, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/core/flags/lowargs.rs:544:1 [INFO] [stdout] | [INFO] [stdout] 544 | / impl Default for EncodingMode { [INFO] [stdout] 545 | | fn default() -> EncodingMode { [INFO] [stdout] 546 | | EncodingMode::Auto [INFO] [stdout] 547 | | } [INFO] [stdout] 548 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 533 + #[derive(Default)] [INFO] [stdout] 534 | pub(crate) enum EncodingMode { [INFO] [stdout] 535 | /// Use only BOM sniffing to auto-detect an encoding. [INFO] [stdout] 536 ~ #[default] [INFO] [stdout] 537 ~ Auto, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/core/flags/lowargs.rs:569:1 [INFO] [stdout] | [INFO] [stdout] 569 | / impl Default for EngineChoice { [INFO] [stdout] 570 | | fn default() -> EngineChoice { [INFO] [stdout] 571 | | EngineChoice::Default [INFO] [stdout] 572 | | } [INFO] [stdout] 573 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 554 + #[derive(Default)] [INFO] [stdout] 555 | pub(crate) enum EngineChoice { [INFO] [stdout] 556 | /// Uses the default regex engine: Rust's `regex` crate. [INFO] [stdout] ... [INFO] [stdout] 559 | /// the implementation of the `regex` crate.) [INFO] [stdout] 560 ~ #[default] [INFO] [stdout] 561 ~ Default, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/core/flags/lowargs.rs:669:1 [INFO] [stdout] | [INFO] [stdout] 669 | / impl Default for MmapMode { [INFO] [stdout] 670 | | fn default() -> MmapMode { [INFO] [stdout] 671 | | MmapMode::Auto [INFO] [stdout] 672 | | } [INFO] [stdout] 673 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 655 + #[derive(Default)] [INFO] [stdout] 656 | pub(crate) enum MmapMode { [INFO] [stdout] 657 | /// This instructs ripgrep to use heuristics for selecting when to and not [INFO] [stdout] 658 | /// to use memory maps for searching. [INFO] [stdout] 659 ~ #[default] [INFO] [stdout] 660 ~ Auto, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> crates/core/flags/parse.rs:107:36 [INFO] [stdout] | [INFO] [stdout] 107 | if let Err(err) = parser.parse(final_args.into_iter(), &mut low) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> crates/core/flags/parse.rs:223:12 [INFO] [stdout] | [INFO] [stdout] 223 | I: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 107 - if let Err(err) = parser.parse(final_args.into_iter(), &mut low) { [INFO] [stdout] 107 + if let Err(err) = parser.parse(final_args, &mut low) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> crates/core/flags/parse.rs:233:43 [INFO] [stdout] | [INFO] [stdout] 233 | lexopt::Arg::Short(ch) if ch == 'h' => { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] = note: `#[warn(clippy::redundant_guards)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 233 - lexopt::Arg::Short(ch) if ch == 'h' => { [INFO] [stdout] 233 + lexopt::Arg::Short('h') => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> crates/core/flags/parse.rs:239:43 [INFO] [stdout] | [INFO] [stdout] 239 | lexopt::Arg::Short(ch) if ch == 'V' => { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 239 - lexopt::Arg::Short(ch) if ch == 'V' => { [INFO] [stdout] 239 + lexopt::Arg::Short('V') => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> crates/core/flags/parse.rs:246:44 [INFO] [stdout] | [INFO] [stdout] 246 | lexopt::Arg::Long(name) if name == "help" => { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 246 - lexopt::Arg::Long(name) if name == "help" => { [INFO] [stdout] 246 + lexopt::Arg::Long("help") => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> crates/core/flags/parse.rs:252:44 [INFO] [stdout] | [INFO] [stdout] 252 | lexopt::Arg::Long(name) if name == "version" => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 252 - lexopt::Arg::Long(name) if name == "version" => { [INFO] [stdout] 252 + lexopt::Arg::Long("version") => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/core/haystack.rs:158:9 [INFO] [stdout] | [INFO] [stdout] 158 | self.dent.file_type().map_or(false, |ft| ft.is_file()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 158 - self.dent.file_type().map_or(false, |ft| ft.is_file()) [INFO] [stdout] 158 + self.dent.file_type().is_some_and(|ft| ft.is_file()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JSON` contains a capitalized acronym [INFO] [stdout] --> crates/core/search.rs:210:5 [INFO] [stdout] | [INFO] [stdout] 210 | JSON(grep::printer::JSON), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Json` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> crates/core/search.rs:285:12 [INFO] [stdout] | [INFO] [stdout] 285 | if !self.config.preprocessor.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.config.preprocessor.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/core/search.rs:307:13 [INFO] [stdout] | [INFO] [stdout] 307 | / io::Error::new( [INFO] [stdout] 308 | | io::ErrorKind::Other, [INFO] [stdout] 309 | | format!( [INFO] [stdout] 310 | | "preprocessor command could not start: '{cmd:?}': {err}", [INFO] [stdout] 311 | | ), [INFO] [stdout] 312 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 307 ~ io::Error::other( [INFO] [stdout] 308 ~ format!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/core/search.rs:315:13 [INFO] [stdout] | [INFO] [stdout] 315 | / io::Error::new( [INFO] [stdout] 316 | | io::ErrorKind::Other, [INFO] [stdout] 317 | | format!("preprocessor command failed: '{cmd:?}': {err}"), [INFO] [stdout] 318 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 315 ~ io::Error::other( [INFO] [stdout] 316 ~ format!("preprocessor command failed: '{cmd:?}': {err}"), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> crates/core/search.rs:392:24 [INFO] [stdout] | [INFO] [stdout] 392 | stats: sink.stats().map(|s| s.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `sink.stats().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> crates/core/search.rs:400:24 [INFO] [stdout] | [INFO] [stdout] 400 | stats: sink.stats().map(|s| s.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `sink.stats().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> crates/core/search.rs:429:24 [INFO] [stdout] | [INFO] [stdout] 429 | stats: sink.stats().map(|s| s.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `sink.stats().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> crates/core/search.rs:437:24 [INFO] [stdout] | [INFO] [stdout] 437 | stats: sink.stats().map(|s| s.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `sink.stats().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `print` doesn't need a mutable reference [INFO] [stdout] --> crates/core/main.rs:226:30 [INFO] [stdout] | [INFO] [stdout] 226 | let _ = bufwtr.print(&mut wtr); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 226 - let _ = bufwtr.print(&mut wtr); [INFO] [stdout] 226 + let _ = bufwtr.print(&wtr); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> crates/core/main.rs:226:30 [INFO] [stdout] | [INFO] [stdout] 226 | let _ = bufwtr.print(&mut wtr); [INFO] [stdout] | ^^^^^^^^ help: change this to: `wtr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> crates/core/main.rs:459:9 [INFO] [stdout] | [INFO] [stdout] 459 | write!(wtr, "\n") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] = note: `#[warn(clippy::write_with_newline)]` on by default [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 459 - write!(wtr, "\n") [INFO] [stdout] 459 + writeln!(wtr) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/core/flags/defs.rs:7617:25 [INFO] [stdout] | [INFO] [stdout] 7617 | let mut total = vec![false; 128]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: you can use an array directly: `[false; 128]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/core/flags/defs.rs:7627:25 [INFO] [stdout] | [INFO] [stdout] 7627 | let mut taken = vec![false; 128]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: you can use an array directly: `[false; 128]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/core/flags/defs.rs:7694:25 [INFO] [stdout] | [INFO] [stdout] 7694 | let mut taken = vec![false; 128]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: you can use an array directly: `[false; 128]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/util.rs:78:60 [INFO] [stdout] | [INFO] [stdout] 78 | env::temp_dir().join(TEST_DIR).join(name).join(&format!("{id}")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `format!("{id}")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> tests/util.rs:496:5 [INFO] [stdout] | [INFO] [stdout] 496 | std::env::var("CROSS_RUNNER").ok().map_or(false, |v| !v.is_empty()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 496 - std::env::var("CROSS_RUNNER").ok().map_or(false, |v| !v.is_empty()) [INFO] [stdout] 496 + std::env::var("CROSS_RUNNER").ok().is_some_and(|v| !v.is_empty()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/binary.rs:39:14 [INFO] [stdout] | [INFO] [stdout] 39 | cmd.args(&["--mmap", "-n", "Project Gutenberg EBook", "-g", "hay"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--mmap", "-n", "Project Gutenberg EBook", "-g", "hay"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/binary.rs:52:14 [INFO] [stdout] | [INFO] [stdout] 52 | cmd.args(&["--mmap", "-n", "Project Gutenberg EBook", "hay"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--mmap", "-n", "Project Gutenberg EBook", "hay"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/binary.rs:67:14 [INFO] [stdout] | [INFO] [stdout] 67 | cmd.args(&["--mmap", "-n", "abcdef", "hay"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--mmap", "-n", "abcdef", "hay"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/binary.rs:79:14 [INFO] [stdout] | [INFO] [stdout] 79 | cmd.args(&["--mmap", "-c", "Project Gutenberg EBook|Heaven", "hay"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--mmap", "-c", "Project Gutenberg EBook|Heaven", "hay"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/binary.rs:93:14 [INFO] [stdout] | [INFO] [stdout] 93 | cmd.args(&["--mmap", "-n", "Project Gutenberg EBook|Heaven", "hay"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--mmap", "-n", "Project Gutenberg EBook|Heaven", "hay"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/binary.rs:110:14 [INFO] [stdout] | [INFO] [stdout] 110 | cmd.args(&["--mmap", "-n", "--binary", "Heaven", "-g", "hay"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--mmap", "-n", "--binary", "Heaven", "-g", "hay"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/binary.rs:122:14 [INFO] [stdout] | [INFO] [stdout] 122 | cmd.args(&["--mmap", "-n", "--text", "Heaven", "-g", "hay"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--mmap", "-n", "--text", "Heaven", "-g", "hay"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/binary.rs:136:14 [INFO] [stdout] | [INFO] [stdout] 136 | cmd.args(&["--mmap", "-n", "medical student", "hay"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--mmap", "-n", "medical student", "hay"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/binary.rs:164:14 [INFO] [stdout] | [INFO] [stdout] 164 | cmd.args(&["--no-mmap", "-n", "Project Gutenberg EBook", "-g", "hay"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--no-mmap", "-n", "Project Gutenberg EBook", "-g", "hay"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/binary.rs:177:14 [INFO] [stdout] | [INFO] [stdout] 177 | cmd.args(&["--no-mmap", "-n", "Project Gutenberg EBook", "hay"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--no-mmap", "-n", "Project Gutenberg EBook", "hay"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/binary.rs:188:14 [INFO] [stdout] | [INFO] [stdout] 188 | cmd.args(&["--no-mmap", "-n", "Project Gutenberg EBook"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--no-mmap", "-n", "Project Gutenberg EBook"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/binary.rs:202:14 [INFO] [stdout] | [INFO] [stdout] 202 | cmd.args(&[ [INFO] [stdout] | ______________^ [INFO] [stdout] 203 | | "--no-mmap", [INFO] [stdout] 204 | | "-n", [INFO] [stdout] 205 | | "--binary", [INFO] [stdout] ... | [INFO] [stdout] 208 | | "hay", [INFO] [stdout] 209 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 202 ~ cmd.args([ [INFO] [stdout] 203 + "--no-mmap", [INFO] [stdout] 204 + "-n", [INFO] [stdout] 205 + "--binary", [INFO] [stdout] 206 + "Project Gutenberg EBook", [INFO] [stdout] 207 + "-g", [INFO] [stdout] 208 + "hay", [INFO] [stdout] 209 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/binary.rs:222:14 [INFO] [stdout] | [INFO] [stdout] 222 | cmd.args(&[ [INFO] [stdout] | ______________^ [INFO] [stdout] 223 | | "--no-mmap", [INFO] [stdout] 224 | | "-n", [INFO] [stdout] 225 | | "--text", [INFO] [stdout] ... | [INFO] [stdout] 228 | | "hay", [INFO] [stdout] 229 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 222 ~ cmd.args([ [INFO] [stdout] 223 + "--no-mmap", [INFO] [stdout] 224 + "-n", [INFO] [stdout] 225 + "--text", [INFO] [stdout] 226 + "Project Gutenberg EBook", [INFO] [stdout] 227 + "-g", [INFO] [stdout] 228 + "hay", [INFO] [stdout] 229 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/binary.rs:241:14 [INFO] [stdout] | [INFO] [stdout] 241 | cmd.args(&["--no-mmap", "-n", "--text", "Project Gutenberg EBook", "hay"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--no-mmap", "-n", "--text", "Project Gutenberg EBook", "hay"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/binary.rs:264:14 [INFO] [stdout] | [INFO] [stdout] 264 | cmd.args(&["--no-mmap", "-l", "Project Gutenberg EBook", "-g", "hay"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--no-mmap", "-l", "Project Gutenberg EBook", "-g", "hay"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/binary.rs:273:14 [INFO] [stdout] | [INFO] [stdout] 273 | cmd.args(&["--no-mmap", "-q", "Project Gutenberg EBook", "-g", "hay"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--no-mmap", "-q", "Project Gutenberg EBook", "-g", "hay"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/binary.rs:283:14 [INFO] [stdout] | [INFO] [stdout] 283 | cmd.args(&["--no-mmap", "-c", "Project Gutenberg EBook", "-g", "hay"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--no-mmap", "-c", "Project Gutenberg EBook", "-g", "hay"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/binary.rs:293:18 [INFO] [stdout] | [INFO] [stdout] 293 | cmd.args(&[ [INFO] [stdout] | __________________^ [INFO] [stdout] 294 | | "--no-mmap", [INFO] [stdout] 295 | | "-c", [INFO] [stdout] 296 | | "--binary", [INFO] [stdout] ... | [INFO] [stdout] 299 | | "hay", [INFO] [stdout] 300 | | ]); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 293 ~ cmd.args([ [INFO] [stdout] 294 + "--no-mmap", [INFO] [stdout] 295 + "-c", [INFO] [stdout] 296 + "--binary", [INFO] [stdout] 297 + "Project Gutenberg EBook", [INFO] [stdout] 298 + "-g", [INFO] [stdout] 299 + "hay", [INFO] [stdout] 300 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/binary.rs:310:14 [INFO] [stdout] | [INFO] [stdout] 310 | cmd.args(&["--no-mmap", "-c", "Project Gutenberg EBook", "hay"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--no-mmap", "-c", "Project Gutenberg EBook", "hay"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/binary.rs:318:14 [INFO] [stdout] | [INFO] [stdout] 318 | cmd.args(&[ [INFO] [stdout] | ______________^ [INFO] [stdout] 319 | | "--no-mmap", [INFO] [stdout] 320 | | "-n", [INFO] [stdout] 321 | | "Project Gutenberg EBook|a medical student", [INFO] [stdout] 322 | | "-g", [INFO] [stdout] 323 | | "hay", [INFO] [stdout] 324 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 318 ~ cmd.args([ [INFO] [stdout] 319 + "--no-mmap", [INFO] [stdout] 320 + "-n", [INFO] [stdout] 321 + "Project Gutenberg EBook|a medical student", [INFO] [stdout] 322 + "-g", [INFO] [stdout] 323 + "hay", [INFO] [stdout] 324 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/binary.rs:337:14 [INFO] [stdout] | [INFO] [stdout] 337 | cmd.args(&[ [INFO] [stdout] | ______________^ [INFO] [stdout] 338 | | "--no-mmap", [INFO] [stdout] 339 | | "-n", [INFO] [stdout] 340 | | "--text", [INFO] [stdout] ... | [INFO] [stdout] 343 | | "hay", [INFO] [stdout] 344 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 337 ~ cmd.args([ [INFO] [stdout] 338 + "--no-mmap", [INFO] [stdout] 339 + "-n", [INFO] [stdout] 340 + "--text", [INFO] [stdout] 341 + "Project Gutenberg EBook|a medical student", [INFO] [stdout] 342 + "-g", [INFO] [stdout] 343 + "hay", [INFO] [stdout] 344 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/binary.rs:357:14 [INFO] [stdout] | [INFO] [stdout] 357 | cmd.args(&["--no-mmap", "-n", "Heaven", "-g", "hay"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--no-mmap", "-n", "Heaven", "-g", "hay"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/binary.rs:365:14 [INFO] [stdout] | [INFO] [stdout] 365 | cmd.args(&["--no-mmap", "-n", "Heaven", "hay"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--no-mmap", "-n", "Heaven", "hay"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/binary.rs:378:14 [INFO] [stdout] | [INFO] [stdout] 378 | cmd.args(&["--no-mmap", "-n", "--binary", "Heaven", "-g", "hay"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--no-mmap", "-n", "--binary", "Heaven", "-g", "hay"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/binary.rs:390:14 [INFO] [stdout] | [INFO] [stdout] 390 | cmd.args(&["--no-mmap", "-n", "--text", "Heaven", "-g", "hay"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--no-mmap", "-n", "--text", "Heaven", "-g", "hay"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/binary.rs:402:14 [INFO] [stdout] | [INFO] [stdout] 402 | cmd.args(&["--no-mmap", "-n", "a medical student", "-g", "hay"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--no-mmap", "-n", "a medical student", "-g", "hay"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/binary.rs:413:14 [INFO] [stdout] | [INFO] [stdout] 413 | cmd.args(&["--no-mmap", "-n", "a medical student", "hay"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--no-mmap", "-n", "a medical student", "hay"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/binary.rs:425:14 [INFO] [stdout] | [INFO] [stdout] 425 | cmd.args(&["--no-mmap", "-n", "--text", "a medical student", "-g", "hay"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--no-mmap", "-n", "--text", "a medical student", "-g", "hay"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> tests/binary.rs:442:9 [INFO] [stdout] | [INFO] [stdout] 442 | file1.push_str("\x00"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `file1.push('\x00')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/binary.rs:447:38 [INFO] [stdout] | [INFO] [stdout] 447 | let got = dir.command().args(&["--sort=path", "-l", "cat"]).stdout(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--sort=path", "-l", "cat"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/binary.rs:453:38 [INFO] [stdout] | [INFO] [stdout] 453 | let got = dir.command().args(&["--sort=path", "-c", "cat"]).stdout(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--sort=path", "-c", "cat"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/binary.rs:458:19 [INFO] [stdout] | [INFO] [stdout] 458 | .args(&["--sort=path", "-c", "cat", "--binary"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--sort=path", "-c", "cat", "--binary"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/binary.rs:464:19 [INFO] [stdout] | [INFO] [stdout] 464 | .args(&["--sort=path", "-c", "cat", "--text"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--sort=path", "-c", "cat", "--text"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/feature.rs:156:14 [INFO] [stdout] | [INFO] [stdout] 156 | cmd.args(&["--ignore-file", "../.not-an-ignore", "-l", "test"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--ignore-file", "../.not-an-ignore", "-l", "test"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/feature.rs:183:14 [INFO] [stdout] | [INFO] [stdout] 183 | cmd.args(&[ [INFO] [stdout] | ______________^ [INFO] [stdout] 184 | | "--ignore-file", [INFO] [stdout] 185 | | ".not-an-ignore1", [INFO] [stdout] 186 | | "--ignore-file", [INFO] [stdout] 187 | | ".not-an-ignore2", [INFO] [stdout] 188 | | "test", [INFO] [stdout] 189 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 183 ~ cmd.args([ [INFO] [stdout] 184 + "--ignore-file", [INFO] [stdout] 185 + ".not-an-ignore1", [INFO] [stdout] 186 + "--ignore-file", [INFO] [stdout] 187 + ".not-an-ignore2", [INFO] [stdout] 188 + "test", [INFO] [stdout] 189 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/feature.rs:551:14 [INFO] [stdout] | [INFO] [stdout] 551 | cmd.args(&["-e", "foo", "-e", "bar", "file"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-e", "foo", "-e", "bar", "file"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/feature.rs:557:14 [INFO] [stdout] | [INFO] [stdout] 557 | cmd.args(&["-f", "patterns", "file"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-f", "patterns", "file"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/feature.rs:563:14 [INFO] [stdout] | [INFO] [stdout] 563 | cmd.args(&["-c", "foo", "file"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-c", "foo", "file"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/feature.rs:578:14 [INFO] [stdout] | [INFO] [stdout] 578 | cmd.args(&["-o", "foo", "file"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-o", "foo", "file"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/feature.rs:593:14 [INFO] [stdout] | [INFO] [stdout] 593 | cmd.args(&["-r", "wat", "foo", "file"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-r", "wat", "foo", "file"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/feature.rs:633:14 [INFO] [stdout] | [INFO] [stdout] 633 | cmd.args(&["-n", "-B1", "-A2", "--trim", "Holmeses", "sherlock"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-n", "-B1", "-A2", "--trim", "Holmeses", "sherlock"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/feature.rs:659:14 [INFO] [stdout] | [INFO] [stdout] 659 | cmd.args(&["-n", "-B1", "-A2", "--trim", r"\s+Holmeses", "sherlock"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-n", "-B1", "-A2", "--trim", r"\s+Holmeses", "sherlock"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/feature.rs:673:14 [INFO] [stdout] | [INFO] [stdout] 673 | cmd.args(&["--multiline", "--trim", "-r$0", "--no-filename", r"a\n?bc"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--multiline", "--trim", "-r$0", "--no-filename", r"a\n?bc"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/feature.rs:682:14 [INFO] [stdout] | [INFO] [stdout] 682 | cmd.args(&[ [INFO] [stdout] | ______________^ [INFO] [stdout] 683 | | "--trim", [INFO] [stdout] 684 | | "--max-columns-preview", [INFO] [stdout] 685 | | "-M8", [INFO] [stdout] 686 | | "--no-filename", [INFO] [stdout] 687 | | "abc", [INFO] [stdout] 688 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 682 ~ cmd.args([ [INFO] [stdout] 683 + "--trim", [INFO] [stdout] 684 + "--max-columns-preview", [INFO] [stdout] 685 + "-M8", [INFO] [stdout] 686 + "--no-filename", [INFO] [stdout] 687 + "abc", [INFO] [stdout] 688 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/feature.rs:697:14 [INFO] [stdout] | [INFO] [stdout] 697 | cmd.args(&[ [INFO] [stdout] | ______________^ [INFO] [stdout] 698 | | "--trim", [INFO] [stdout] 699 | | "--max-columns-preview", [INFO] [stdout] 700 | | "-M8", [INFO] [stdout] ... | [INFO] [stdout] 704 | | "abc", [INFO] [stdout] 705 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 697 ~ cmd.args([ [INFO] [stdout] 698 + "--trim", [INFO] [stdout] 699 + "--max-columns-preview", [INFO] [stdout] 700 + "-M8", [INFO] [stdout] 701 + "--color=always", [INFO] [stdout] 702 + "--colors=path:none", [INFO] [stdout] 703 + "--no-filename", [INFO] [stdout] 704 + "abc", [INFO] [stdout] 705 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/feature.rs:716:18 [INFO] [stdout] | [INFO] [stdout] 716 | cmd.args(&[ [INFO] [stdout] | __________________^ [INFO] [stdout] 717 | | "--multiline", [INFO] [stdout] 718 | | "--trim", [INFO] [stdout] 719 | | "--max-columns-preview", [INFO] [stdout] ... | [INFO] [stdout] 726 | | r"a\n?bc", [INFO] [stdout] 727 | | ]); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 716 ~ cmd.args([ [INFO] [stdout] 717 + "--multiline", [INFO] [stdout] 718 + "--trim", [INFO] [stdout] 719 + "--max-columns-preview", [INFO] [stdout] 720 + "-M8", [INFO] [stdout] 721 + // Force the "slow" printing path without actually [INFO] [stdout] 722 + // putting colors in the output. [INFO] [stdout] 723 + "--color=always", [INFO] [stdout] 724 + "--colors=path:none", [INFO] [stdout] 725 + "--no-filename", [INFO] [stdout] 726 + r"a\n?bc", [INFO] [stdout] 727 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/feature.rs:739:18 [INFO] [stdout] | [INFO] [stdout] 739 | cmd.args(&[ [INFO] [stdout] | __________________^ [INFO] [stdout] 740 | | "--multiline", [INFO] [stdout] 741 | | "--trim", [INFO] [stdout] 742 | | "--max-columns-preview", [INFO] [stdout] ... | [INFO] [stdout] 746 | | r".*a\n?bc.*", [INFO] [stdout] 747 | | ]); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 739 ~ cmd.args([ [INFO] [stdout] 740 + "--multiline", [INFO] [stdout] 741 + "--trim", [INFO] [stdout] 742 + "--max-columns-preview", [INFO] [stdout] 743 + "-M8", [INFO] [stdout] 744 + "--only-matching", [INFO] [stdout] 745 + "--no-filename", [INFO] [stdout] 746 + r".*a\n?bc.*", [INFO] [stdout] 747 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/feature.rs:759:18 [INFO] [stdout] | [INFO] [stdout] 759 | cmd.args(&[ [INFO] [stdout] | __________________^ [INFO] [stdout] 760 | | "--multiline", [INFO] [stdout] 761 | | "--trim", [INFO] [stdout] 762 | | "--max-columns-preview", [INFO] [stdout] ... | [INFO] [stdout] 766 | | r".*a\n?bc.*", [INFO] [stdout] 767 | | ]); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 759 ~ cmd.args([ [INFO] [stdout] 760 + "--multiline", [INFO] [stdout] 761 + "--trim", [INFO] [stdout] 762 + "--max-columns-preview", [INFO] [stdout] 763 + "-M8", [INFO] [stdout] 764 + "--vimgrep", [INFO] [stdout] 765 + "--no-filename", [INFO] [stdout] 766 + r".*a\n?bc.*", [INFO] [stdout] 767 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/feature.rs:790:14 [INFO] [stdout] | [INFO] [stdout] 790 | cmd.args(&[ [INFO] [stdout] | ______________^ [INFO] [stdout] 791 | | "-M46", [INFO] [stdout] 792 | | "--max-columns-preview", [INFO] [stdout] 793 | | "exhibited|dusted|has to have it", [INFO] [stdout] 794 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 790 ~ cmd.args([ [INFO] [stdout] 791 + "-M46", [INFO] [stdout] 792 + "--max-columns-preview", [INFO] [stdout] 793 + "exhibited|dusted|has to have it", [INFO] [stdout] 794 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/feature.rs:805:14 [INFO] [stdout] | [INFO] [stdout] 805 | cmd.args(&[ [INFO] [stdout] | ______________^ [INFO] [stdout] 806 | | "-M43", [INFO] [stdout] 807 | | "--max-columns-preview", [INFO] [stdout] ... | [INFO] [stdout] 812 | | "exhibited|dusted|has to have it", [INFO] [stdout] 813 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 805 ~ cmd.args([ [INFO] [stdout] 806 + "-M43", [INFO] [stdout] 807 + "--max-columns-preview", [INFO] [stdout] 808 + // Doing a replacement forces ripgrep to show the number of remaining [INFO] [stdout] 809 + // matches. Normally, this happens by default when printing a tty with [INFO] [stdout] 810 + // colors. [INFO] [stdout] 811 + "-rxxx", [INFO] [stdout] 812 + "exhibited|dusted|has to have it", [INFO] [stdout] 813 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/feature.rs:885:27 [INFO] [stdout] | [INFO] [stdout] 885 | let stdout = cmd.args(&["--sort", "path", "--files"]).stdout(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--sort", "path", "--files"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/feature.rs:889:18 [INFO] [stdout] | [INFO] [stdout] 889 | cmd.args(&["--sort", "path", "--files", "--no-require-git"]).stdout(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--sort", "path", "--files", "--no-require-git"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/feature.rs:893:15 [INFO] [stdout] | [INFO] [stdout] 893 | .args(&[ [INFO] [stdout] | _______________^ [INFO] [stdout] 894 | | "--sort", [INFO] [stdout] 895 | | "path", [INFO] [stdout] 896 | | "--files", [INFO] [stdout] 897 | | "--no-require-git", [INFO] [stdout] 898 | | "--require-git", [INFO] [stdout] 899 | | ]) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 893 ~ .args([ [INFO] [stdout] 894 + "--sort", [INFO] [stdout] 895 + "path", [INFO] [stdout] 896 + "--files", [INFO] [stdout] 897 + "--no-require-git", [INFO] [stdout] 898 + "--require-git", [INFO] [stdout] 899 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/feature.rs:1100:14 [INFO] [stdout] | [INFO] [stdout] 1100 | cmd.args(&["-C1", "-A2", "5", "test"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-C1", "-A2", "5", "test"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/feature.rs:1109:18 [INFO] [stdout] | [INFO] [stdout] 1109 | cmd.args(&["-A2", "-C1", "5", "test"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-A2", "-C1", "5", "test"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/feature.rs:1116:14 [INFO] [stdout] | [INFO] [stdout] 1116 | cmd.args(&["-A1", "--no-context-separator", "foo", "test"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-A1", "--no-context-separator", "foo", "test"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/feature.rs:1122:14 [INFO] [stdout] | [INFO] [stdout] 1122 | cmd.args(&[ [INFO] [stdout] | ______________^ [INFO] [stdout] 1123 | | "-A1", [INFO] [stdout] 1124 | | "--context-separator", [INFO] [stdout] 1125 | | "AAA", [INFO] [stdout] ... | [INFO] [stdout] 1128 | | "test", [INFO] [stdout] 1129 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1122 ~ cmd.args([ [INFO] [stdout] 1123 + "-A1", [INFO] [stdout] 1124 + "--context-separator", [INFO] [stdout] 1125 + "AAA", [INFO] [stdout] 1126 + "--no-context-separator", [INFO] [stdout] 1127 + "foo", [INFO] [stdout] 1128 + "test", [INFO] [stdout] 1129 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/feature.rs:1135:14 [INFO] [stdout] | [INFO] [stdout] 1135 | cmd.args(&[ [INFO] [stdout] | ______________^ [INFO] [stdout] 1136 | | "-A1", [INFO] [stdout] 1137 | | "--no-context-separator", [INFO] [stdout] 1138 | | "--context-separator", [INFO] [stdout] ... | [INFO] [stdout] 1141 | | "test", [INFO] [stdout] 1142 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1135 ~ cmd.args([ [INFO] [stdout] 1136 + "-A1", [INFO] [stdout] 1137 + "--no-context-separator", [INFO] [stdout] 1138 + "--context-separator", [INFO] [stdout] 1139 + "AAA", [INFO] [stdout] 1140 + "foo", [INFO] [stdout] 1141 + "test", [INFO] [stdout] 1142 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/feature.rs:1148:14 [INFO] [stdout] | [INFO] [stdout] 1148 | cmd.args(&["-A1", "--context-separator", "AAA", "foo", "test"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-A1", "--context-separator", "AAA", "foo", "test"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/feature.rs:1154:14 [INFO] [stdout] | [INFO] [stdout] 1154 | cmd.args(&["-A1", "foo", "test"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-A1", "foo", "test"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/feature.rs:1160:14 [INFO] [stdout] | [INFO] [stdout] 1160 | cmd.args(&["-A1", "--context-separator", "", "foo", "test"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-A1", "--context-separator", "", "foo", "test"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/feature.rs:1172:14 [INFO] [stdout] | [INFO] [stdout] 1172 | cmd.args(&["--stop-on-nonmatch", "[235]"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--stop-on-nonmatch", "[235]"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/json.rs:288:8 [INFO] [stdout] | [INFO] [stdout] 288 | if !dir.try_create_bytes(OsStr::from_bytes(name), contents).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dir.try_create_bytes(OsStr::from_bytes(name), contents).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/json.rs:330:8 [INFO] [stdout] | [INFO] [stdout] 330 | if !dir.try_create_bytes(OsStr::new(name), contents).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dir.try_create_bytes(OsStr::new(name), contents).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/misc.rs:65:14 [INFO] [stdout] | [INFO] [stdout] 65 | cmd.args(&[ [INFO] [stdout] | ______________^ [INFO] [stdout] 66 | | // This forces the issue since --with-filename is disabled by default [INFO] [stdout] 67 | | // when searching one file. [INFO] [stdout] 68 | | "--with-filename", [INFO] [stdout] ... | [INFO] [stdout] 71 | | "sherlock", [INFO] [stdout] 72 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 65 ~ cmd.args([ [INFO] [stdout] 66 + // This forces the issue since --with-filename is disabled by default [INFO] [stdout] 67 + // when searching one file. [INFO] [stdout] 68 + "--with-filename", [INFO] [stdout] 69 + "--heading", [INFO] [stdout] 70 + "Sherlock", [INFO] [stdout] 71 + "sherlock", [INFO] [stdout] 72 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/misc.rs:161:14 [INFO] [stdout] | [INFO] [stdout] 161 | cmd.args(&[ [INFO] [stdout] | ______________^ [INFO] [stdout] 162 | | "-x", [INFO] [stdout] 163 | | "Watson|and exhibited clearly, with a label attached.", [INFO] [stdout] 164 | | "sherlock", [INFO] [stdout] 165 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 161 ~ cmd.args([ [INFO] [stdout] 162 + "-x", [INFO] [stdout] 163 + "Watson|and exhibited clearly, with a label attached.", [INFO] [stdout] 164 + "sherlock", [INFO] [stdout] 165 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/misc.rs:201:14 [INFO] [stdout] | [INFO] [stdout] 201 | cmd.args(&["-r", "$2, $1", "([A-Z][a-z]+) ([A-Z][a-z]+)", "sherlock"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-r", "$2, $1", "([A-Z][a-z]+) ([A-Z][a-z]+)", "sherlock"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/misc.rs:213:14 [INFO] [stdout] | [INFO] [stdout] 213 | cmd.args(&[ [INFO] [stdout] | ______________^ [INFO] [stdout] 214 | | "-r", [INFO] [stdout] 215 | | "$last, $first", [INFO] [stdout] 216 | | "(?P[A-Z][a-z]+) (?P[A-Z][a-z]+)", [INFO] [stdout] 217 | | "sherlock", [INFO] [stdout] 218 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 213 ~ cmd.args([ [INFO] [stdout] 214 + "-r", [INFO] [stdout] 215 + "$last, $first", [INFO] [stdout] 216 + "(?P[A-Z][a-z]+) (?P[A-Z][a-z]+)", [INFO] [stdout] 217 + "sherlock", [INFO] [stdout] 218 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/misc.rs:295:14 [INFO] [stdout] | [INFO] [stdout] 295 | cmd.args(&["--type-add", "wat:*.wat", "-t", "wat", "Sherlock"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--type-add", "wat:*.wat", "-t", "wat", "Sherlock"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/misc.rs:305:14 [INFO] [stdout] | [INFO] [stdout] 305 | cmd.args(&[ [INFO] [stdout] | ______________^ [INFO] [stdout] 306 | | "--type-add", [INFO] [stdout] 307 | | "wat:*.wat", [INFO] [stdout] 308 | | "--type-add", [INFO] [stdout] ... | [INFO] [stdout] 312 | | "Sherlock", [INFO] [stdout] 313 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 305 ~ cmd.args([ [INFO] [stdout] 306 + "--type-add", [INFO] [stdout] 307 + "wat:*.wat", [INFO] [stdout] 308 + "--type-add", [INFO] [stdout] 309 + "combo:include:wat,py", [INFO] [stdout] 310 + "-t", [INFO] [stdout] 311 + "combo", [INFO] [stdout] 312 + "Sherlock", [INFO] [stdout] 313 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/misc.rs:361:14 [INFO] [stdout] | [INFO] [stdout] 361 | cmd.args(&["--glob-case-insensitive", "--glob", "*.html", "Sherlock"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--glob-case-insensitive", "--glob", "*.html", "Sherlock"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/misc.rs:411:14 [INFO] [stdout] | [INFO] [stdout] 411 | cmd.args(&["--count", "--include-zero", "nada"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--count", "--include-zero", "nada"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/misc.rs:423:14 [INFO] [stdout] | [INFO] [stdout] 423 | cmd.args(&["--count", "--include-zero", "--no-include-zero", "nada"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--count", "--include-zero", "--no-include-zero", "nada"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/misc.rs:869:14 [INFO] [stdout] | [INFO] [stdout] 869 | cmd.args(&["--pre", "xzcat", "--pre-glob", "*.xz", "Sherlock"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--pre", "xzcat", "--pre-glob", "*.xz", "Sherlock"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/multiline.rs:23:14 [INFO] [stdout] | [INFO] [stdout] 23 | cmd.args(&["-n", "-U", "of this world.+detective work", "sherlock"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-n", "-U", "of this world.+detective work", "sherlock"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/multiline.rs:30:14 [INFO] [stdout] | [INFO] [stdout] 30 | cmd.args(&[ [INFO] [stdout] | ______________^ [INFO] [stdout] 31 | | "-n", [INFO] [stdout] 32 | | "-U", [INFO] [stdout] 33 | | "--multiline-dotall", [INFO] [stdout] 34 | | "of this world.+detective work", [INFO] [stdout] 35 | | "sherlock", [INFO] [stdout] 36 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 30 ~ cmd.args([ [INFO] [stdout] 31 + "-n", [INFO] [stdout] 32 + "-U", [INFO] [stdout] 33 + "--multiline-dotall", [INFO] [stdout] 34 + "of this world.+detective work", [INFO] [stdout] 35 + "sherlock", [INFO] [stdout] 36 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/multiline.rs:48:14 [INFO] [stdout] | [INFO] [stdout] 48 | cmd.args(&[ [INFO] [stdout] | ______________^ [INFO] [stdout] 49 | | "-n", [INFO] [stdout] 50 | | "-U", [INFO] [stdout] 51 | | "--only-matching", [INFO] [stdout] 52 | | r"Watson|Sherlock\p{Any}+?Holmes", [INFO] [stdout] 53 | | "sherlock", [INFO] [stdout] 54 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 48 ~ cmd.args([ [INFO] [stdout] 49 + "-n", [INFO] [stdout] 50 + "-U", [INFO] [stdout] 51 + "--only-matching", [INFO] [stdout] 52 + r"Watson|Sherlock\p{Any}+?Holmes", [INFO] [stdout] 53 + "sherlock", [INFO] [stdout] 54 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/multiline.rs:74:14 [INFO] [stdout] | [INFO] [stdout] 74 | cmd.args(&[ [INFO] [stdout] | ______________^ [INFO] [stdout] 75 | | "-n", [INFO] [stdout] 76 | | "-U", [INFO] [stdout] 77 | | "--vimgrep", [INFO] [stdout] 78 | | r"Watson|Sherlock\p{Any}+?Holmes", [INFO] [stdout] 79 | | "sherlock", [INFO] [stdout] 80 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 74 ~ cmd.args([ [INFO] [stdout] 75 + "-n", [INFO] [stdout] 76 + "-U", [INFO] [stdout] 77 + "--vimgrep", [INFO] [stdout] 78 + r"Watson|Sherlock\p{Any}+?Holmes", [INFO] [stdout] 79 + "sherlock", [INFO] [stdout] 80 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/multiline.rs:95:14 [INFO] [stdout] | [INFO] [stdout] 95 | cmd.args(&["-n", "-U", r"of this world\p{Any}+?detective work"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-n", "-U", r"of this world\p{Any}+?detective work"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/multiline.rs:106:14 [INFO] [stdout] | [INFO] [stdout] 106 | cmd.args(&[ [INFO] [stdout] | ______________^ [INFO] [stdout] 107 | | "-n", [INFO] [stdout] 108 | | "-U", [INFO] [stdout] 109 | | "-C1", [INFO] [stdout] 110 | | r"detective work\p{Any}+?result of luck", [INFO] [stdout] 111 | | "sherlock", [INFO] [stdout] 112 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 106 ~ cmd.args([ [INFO] [stdout] 107 + "-n", [INFO] [stdout] 108 + "-U", [INFO] [stdout] 109 + "-C1", [INFO] [stdout] 110 + r"detective work\p{Any}+?result of luck", [INFO] [stdout] 111 + "sherlock", [INFO] [stdout] 112 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:348:14 [INFO] [stdout] | [INFO] [stdout] 348 | cmd.args(&[ [INFO] [stdout] | ______________^ [INFO] [stdout] 349 | | "--no-ignore", [INFO] [stdout] 350 | | "--hidden", [INFO] [stdout] 351 | | "--follow", [INFO] [stdout] ... | [INFO] [stdout] 356 | | "*.{js,json,php,md,styl,scss,sass,pug,html,config,py,cpp,c,go,hs}", [INFO] [stdout] 357 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 348 ~ cmd.args([ [INFO] [stdout] 349 + "--no-ignore", [INFO] [stdout] 350 + "--hidden", [INFO] [stdout] 351 + "--follow", [INFO] [stdout] 352 + "--files", [INFO] [stdout] 353 + "--glob", [INFO] [stdout] 354 + "!{.git,node_modules,plugged}/**", [INFO] [stdout] 355 + "--glob", [INFO] [stdout] 356 + "*.{js,json,php,md,styl,scss,sass,pug,html,config,py,cpp,c,go,hs}", [INFO] [stdout] 357 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:376:14 [INFO] [stdout] | [INFO] [stdout] 376 | cmd.args(&[ [INFO] [stdout] | ______________^ [INFO] [stdout] 377 | | "-A1", [INFO] [stdout] 378 | | "-H", [INFO] [stdout] 379 | | "--no-heading", [INFO] [stdout] ... | [INFO] [stdout] 384 | | "foo", [INFO] [stdout] 385 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 376 ~ cmd.args([ [INFO] [stdout] 377 + "-A1", [INFO] [stdout] 378 + "-H", [INFO] [stdout] 379 + "--no-heading", [INFO] [stdout] 380 + "-N", [INFO] [stdout] 381 + "--colors=match:none", [INFO] [stdout] 382 + "--color=always", [INFO] [stdout] 383 + "--hyperlink-format=", [INFO] [stdout] 384 + "foo", [INFO] [stdout] 385 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:428:14 [INFO] [stdout] | [INFO] [stdout] 428 | cmd.args(&["--only-matching", "--column", r"[0-9]", "digits.txt"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--only-matching", "--column", r"[0-9]", "digits.txt"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:528:14 [INFO] [stdout] | [INFO] [stdout] 528 | cmd.args(&[ [INFO] [stdout] | ______________^ [INFO] [stdout] 529 | | "--color", [INFO] [stdout] 530 | | "ansi", [INFO] [stdout] 531 | | "--colors", [INFO] [stdout] ... | [INFO] [stdout] 541 | | "input.txt", [INFO] [stdout] 542 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 528 ~ cmd.args([ [INFO] [stdout] 529 + "--color", [INFO] [stdout] 530 + "ansi", [INFO] [stdout] 531 + "--colors", [INFO] [stdout] 532 + "path:none", [INFO] [stdout] 533 + "--colors", [INFO] [stdout] 534 + "line:none", [INFO] [stdout] 535 + "--colors", [INFO] [stdout] 536 + "match:fg:red", [INFO] [stdout] 537 + "--colors", [INFO] [stdout] 538 + "match:style:nobold", [INFO] [stdout] 539 + "--line-number", [INFO] [stdout] 540 + r"^$", [INFO] [stdout] 541 + "input.txt", [INFO] [stdout] 542 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:638:18 [INFO] [stdout] | [INFO] [stdout] 638 | cmd.args(&["Sample"]).assert_err(); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `["Sample"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:642:18 [INFO] [stdout] | [INFO] [stdout] 642 | cmd.args(&["Sample", "a"]).assert_err(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `["Sample", "a"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:647:18 [INFO] [stdout] | [INFO] [stdout] 647 | cmd.args(&["Sample"]).assert_err(); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `["Sample"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:945:18 [INFO] [stdout] | [INFO] [stdout] 945 | cmd.args(&["-U", "-r?", "-n", "\n", "input"]).stdout() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-U", "-r?", "-n", "\n", "input"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1024:35 [INFO] [stdout] | [INFO] [stdout] 1024 | eqnice!("d\ne\nd\n", cmd.args(&["-A2", "-m1", "d", "foo"]).stdout()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-A2", "-m1", "d", "foo"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1034:15 [INFO] [stdout] | [INFO] [stdout] 1034 | .args(&["test", "--no-ignore", "--sort", "path", "mylink"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["test", "--no-ignore", "--sort", "path", "mylink"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1046:14 [INFO] [stdout] | [INFO] [stdout] 1046 | cmd.args(&["-No", r".*o(?!.*\s)", "ip.txt"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-No", r".*o(?!.*\s)", "ip.txt"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1050:14 [INFO] [stdout] | [INFO] [stdout] 1050 | cmd.args(&["-No", r".*o(?!.*[ \t])", "ip.txt"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-No", r".*o(?!.*[ \t])", "ip.txt"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1061:14 [INFO] [stdout] | [INFO] [stdout] 1061 | cmd.args(&["-No", r".*o(?!.*\s)", "ip.txt"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-No", r".*o(?!.*\s)", "ip.txt"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1073:14 [INFO] [stdout] | [INFO] [stdout] 1073 | cmd.args(&["-nU", "-rquux", r"(?<=foo\n)bar", "test"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-nU", "-rquux", r"(?<=foo\n)bar", "test"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1148:14 [INFO] [stdout] | [INFO] [stdout] 1148 | cmd.args(&[ [INFO] [stdout] | ______________^ [INFO] [stdout] 1149 | | "--pcre2", [INFO] [stdout] 1150 | | "--multiline", [INFO] [stdout] 1151 | | "--count", [INFO] [stdout] 1152 | | r"(?s)def (\w+);(?=.*use \w+)", [INFO] [stdout] 1153 | | "foo", [INFO] [stdout] 1154 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1148 ~ cmd.args([ [INFO] [stdout] 1149 + "--pcre2", [INFO] [stdout] 1150 + "--multiline", [INFO] [stdout] 1151 + "--count", [INFO] [stdout] 1152 + r"(?s)def (\w+);(?=.*use \w+)", [INFO] [stdout] 1153 + "foo", [INFO] [stdout] 1154 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1159:14 [INFO] [stdout] | [INFO] [stdout] 1159 | cmd.args(&[ [INFO] [stdout] | ______________^ [INFO] [stdout] 1160 | | "--pcre2", [INFO] [stdout] 1161 | | "--multiline", [INFO] [stdout] 1162 | | "--count-matches", [INFO] [stdout] 1163 | | r"(?s)def (\w+);(?=.*use \w+)", [INFO] [stdout] 1164 | | "foo", [INFO] [stdout] 1165 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1159 ~ cmd.args([ [INFO] [stdout] 1160 + "--pcre2", [INFO] [stdout] 1161 + "--multiline", [INFO] [stdout] 1162 + "--count-matches", [INFO] [stdout] 1163 + r"(?s)def (\w+);(?=.*use \w+)", [INFO] [stdout] 1164 + "foo", [INFO] [stdout] 1165 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1181:14 [INFO] [stdout] | [INFO] [stdout] 1181 | cmd.args(&[r"-r${0}f", r".*", "test"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[r"-r${0}f", r".*", "test"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1212:14 [INFO] [stdout] | [INFO] [stdout] 1212 | cmd.args(&[r"x?", "--crlf", "--color", "always"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[r"x?", "--crlf", "--color", "always"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1226:24 [INFO] [stdout] | [INFO] [stdout] 1226 | dir.command().args(&[r"foo\x00?"]).assert_err(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `[r"foo\x00?"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1227:46 [INFO] [stdout] | [INFO] [stdout] 1227 | eqnice!("test:foo\n", dir.command().args(&["-a", r"foo\x00?"]).stdout()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-a", r"foo\x00?"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1233:14 [INFO] [stdout] | [INFO] [stdout] 1233 | cmd.args(&[ [INFO] [stdout] | ______________^ [INFO] [stdout] 1234 | | "--multiline", [INFO] [stdout] 1235 | | "--vimgrep", [INFO] [stdout] 1236 | | r"foobar\nfoobar\nfoo|quux", [INFO] [stdout] 1237 | | "test", [INFO] [stdout] 1238 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1233 ~ cmd.args([ [INFO] [stdout] 1234 + "--multiline", [INFO] [stdout] 1235 + "--vimgrep", [INFO] [stdout] 1236 + r"foobar\nfoobar\nfoo|quux", [INFO] [stdout] 1237 + "test", [INFO] [stdout] 1238 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1304:42 [INFO] [stdout] | [INFO] [stdout] 1304 | eqnice!("1:\n2:\n2:\n2:\n", cmd.args(&["-won", "", "test"]).stdout()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-won", "", "test"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1310:14 [INFO] [stdout] | [INFO] [stdout] 1310 | cmd.args(&[ [INFO] [stdout] | ______________^ [INFO] [stdout] 1311 | | "--no-line-number", [INFO] [stdout] 1312 | | "--no-filename", [INFO] [stdout] 1313 | | "--multiline", [INFO] [stdout] ... | [INFO] [stdout] 1318 | | "haystack", [INFO] [stdout] 1319 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1310 ~ cmd.args([ [INFO] [stdout] 1311 + "--no-line-number", [INFO] [stdout] 1312 + "--no-filename", [INFO] [stdout] 1313 + "--multiline", [INFO] [stdout] 1314 + "--max-count=1", [INFO] [stdout] 1315 + "--passthru", [INFO] [stdout] 1316 + "--replace=B", [INFO] [stdout] 1317 + "b", [INFO] [stdout] 1318 + "haystack", [INFO] [stdout] 1319 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1356:14 [INFO] [stdout] | [INFO] [stdout] 1356 | cmd.args(&[ [INFO] [stdout] | ______________^ [INFO] [stdout] 1357 | | "--line-number", [INFO] [stdout] 1358 | | "--multiline", [INFO] [stdout] 1359 | | "--only-matching", [INFO] [stdout] ... | [INFO] [stdout] 1363 | | "test", [INFO] [stdout] 1364 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1356 ~ cmd.args([ [INFO] [stdout] 1357 + "--line-number", [INFO] [stdout] 1358 + "--multiline", [INFO] [stdout] 1359 + "--only-matching", [INFO] [stdout] 1360 + "--replace", [INFO] [stdout] 1361 + "${value}", [INFO] [stdout] 1362 + r"^(?P\s*)a=(?P(?ms:[(].*?[)])|.*?)$", [INFO] [stdout] 1363 + "test", [INFO] [stdout] 1364 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1407:14 [INFO] [stdout] | [INFO] [stdout] 1407 | cmd.args(&[ [INFO] [stdout] | ______________^ [INFO] [stdout] 1408 | | "-N", [INFO] [stdout] 1409 | | "-U", [INFO] [stdout] 1410 | | "-r", "$usage", [INFO] [stdout] 1411 | | r#"^(?P\n?(# .*\n)*)(alias (?Ppipc)="[^"]+"|(?Ppipc) \(\) \{)( #(?P .+))?"#, [INFO] [stdout] 1412 | | "test", [INFO] [stdout] 1413 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1407 ~ cmd.args([ [INFO] [stdout] 1408 + "-N", [INFO] [stdout] 1409 + "-U", [INFO] [stdout] 1410 + "-r", "$usage", [INFO] [stdout] 1411 + r#"^(?P\n?(# .*\n)*)(alias (?Ppipc)="[^"]+"|(?Ppipc) \(\) \{)( #(?P .+))?"#, [INFO] [stdout] 1412 + "test", [INFO] [stdout] 1413 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1423:14 [INFO] [stdout] | [INFO] [stdout] 1423 | cmd.args(&["test"]).assert_err(); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `["test"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1431:14 [INFO] [stdout] | [INFO] [stdout] 1431 | cmd.args(&["-e", "", "file"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `["-e", "", "file"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1436:14 [INFO] [stdout] | [INFO] [stdout] 1436 | cmd.args(&["-e", ")(", "file"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-e", ")(", "file"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1441:14 [INFO] [stdout] | [INFO] [stdout] 1441 | cmd.args(&["--only-matching", "-e", "Foo", "-e", "Bar", "file"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--only-matching", "-e", "Foo", "-e", "Bar", "file"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1446:14 [INFO] [stdout] | [INFO] [stdout] 1446 | cmd.args(&["-e", "Fo(oB)a(r)", "--replace", "${0}_${1}_${2}${3}", "file"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-e", "Fo(oB)a(r)", "--replace", "${0}_${1}_${2}${3}", "file"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1451:14 [INFO] [stdout] | [INFO] [stdout] 1451 | cmd.args(&["--only-matching", "-e", "(?i)foo", "-e", "bar", "file"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--only-matching", "-e", "(?i)foo", "-e", "bar", "file"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1456:14 [INFO] [stdout] | [INFO] [stdout] 1456 | cmd.args(&["--only-matching", "-e", "(?i)notfoo", "-e", "bar", "file"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--only-matching", "-e", "(?i)notfoo", "-e", "bar", "file"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1464:15 [INFO] [stdout] | [INFO] [stdout] 1464 | .args(&[ [INFO] [stdout] | _______________^ [INFO] [stdout] 1465 | | "--no-filename", [INFO] [stdout] 1466 | | "--no-unicode", [INFO] [stdout] 1467 | | "-w", [INFO] [stdout] 1468 | | "-o", [INFO] [stdout] 1469 | | r"(\w+\.)*domain\.(\w+)", [INFO] [stdout] 1470 | | ]) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1464 ~ .args([ [INFO] [stdout] 1465 + "--no-filename", [INFO] [stdout] 1466 + "--no-unicode", [INFO] [stdout] 1467 + "-w", [INFO] [stdout] 1468 + "-o", [INFO] [stdout] 1469 + r"(\w+\.)*domain\.(\w+)", [INFO] [stdout] 1470 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1478:24 [INFO] [stdout] | [INFO] [stdout] 1478 | let got = cmd.args(&["--null-data", "--line-regexp", r"bar"]).stdout(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--null-data", "--line-regexp", r"bar"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1496:24 [INFO] [stdout] | [INFO] [stdout] 1496 | let got = cmd.args(&["--stats", "-m2", "foo", "."]).stdout(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--stats", "-m2", "foo", "."]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1508:34 [INFO] [stdout] | [INFO] [stdout] 1508 | let got = dir.command().args(&["--files", "-g", "!asdf/"]).stdout(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--files", "-g", "!asdf/"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1512:34 [INFO] [stdout] | [INFO] [stdout] 1512 | let got = dir.command().args(&["--files", "-g", "!asdf./"]).stdout(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--files", "-g", "!asdf./"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1534:24 [INFO] [stdout] | [INFO] [stdout] 1534 | dir.command().args(&["-q", "abc", "non-match"]).assert_exit_code(1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-q", "abc", "non-match"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1535:24 [INFO] [stdout] | [INFO] [stdout] 1535 | dir.command().args(&["-q", "abc", "yes-match"]).assert_exit_code(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-q", "abc", "yes-match"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1537:15 [INFO] [stdout] | [INFO] [stdout] 1537 | .args(&["--files-with-matches", "-q", "abc", "non-match"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--files-with-matches", "-q", "abc", "non-match"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1540:15 [INFO] [stdout] | [INFO] [stdout] 1540 | .args(&["--files-with-matches", "-q", "abc", "yes-match"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--files-with-matches", "-q", "abc", "yes-match"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1544:15 [INFO] [stdout] | [INFO] [stdout] 1544 | .args(&["--files-without-match", "abc", "non-match"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--files-without-match", "abc", "non-match"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1547:15 [INFO] [stdout] | [INFO] [stdout] 1547 | .args(&["--files-without-match", "abc", "yes-match"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--files-without-match", "abc", "yes-match"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1552:15 [INFO] [stdout] | [INFO] [stdout] 1552 | .args(&["--files-without-match", "abc", "non-match"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--files-without-match", "abc", "non-match"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1557:15 [INFO] [stdout] | [INFO] [stdout] 1557 | .args(&["--files-without-match", "-q", "abc", "non-match"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--files-without-match", "-q", "abc", "non-match"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1560:15 [INFO] [stdout] | [INFO] [stdout] 1560 | .args(&["--files-without-match", "-q", "abc", "yes-match"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--files-without-match", "-q", "abc", "yes-match"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1565:15 [INFO] [stdout] | [INFO] [stdout] 1565 | .args(&["--files-without-match", "-q", "abc", "non-match"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--files-without-match", "-q", "abc", "non-match"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1579:28 [INFO] [stdout] | [INFO] [stdout] 1579 | let got = cmd.args(&["--files"]).stdout(); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `["--files"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1591:18 [INFO] [stdout] | [INFO] [stdout] 1591 | cmd.args(&["--files", "-g", "[abc"]).assert_err(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--files", "-g", "[abc"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1614:19 [INFO] [stdout] | [INFO] [stdout] 1614 | .args(&[ [INFO] [stdout] | ___________________^ [INFO] [stdout] 1615 | | "--multiline", [INFO] [stdout] 1616 | | "--pcre2", [INFO] [stdout] 1617 | | r"(?s)Start(?=.*thing2)", [INFO] [stdout] 1618 | | "test", [INFO] [stdout] 1619 | | ]) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1614 ~ .args([ [INFO] [stdout] 1615 + "--multiline", [INFO] [stdout] 1616 + "--pcre2", [INFO] [stdout] 1617 + r"(?s)Start(?=.*thing2)", [INFO] [stdout] 1618 + "test", [INFO] [stdout] 1619 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1625:19 [INFO] [stdout] | [INFO] [stdout] 1625 | .args(&[ [INFO] [stdout] | ___________________^ [INFO] [stdout] 1626 | | "--multiline", [INFO] [stdout] 1627 | | "--pcre2", [INFO] [stdout] 1628 | | "--files-with-matches", [INFO] [stdout] 1629 | | r"(?s)Start(?=.*thing2)", [INFO] [stdout] 1630 | | "test", [INFO] [stdout] 1631 | | ]) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1625 ~ .args([ [INFO] [stdout] 1626 + "--multiline", [INFO] [stdout] 1627 + "--pcre2", [INFO] [stdout] 1628 + "--files-with-matches", [INFO] [stdout] 1629 + r"(?s)Start(?=.*thing2)", [INFO] [stdout] 1630 + "test", [INFO] [stdout] 1631 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1644:24 [INFO] [stdout] | [INFO] [stdout] 1644 | eqnice!(cmd().args(&["--files"]).stdout(), "subdir/.foo.txt\n"); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `["--files"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1645:24 [INFO] [stdout] | [INFO] [stdout] 1645 | eqnice!(cmd().args(&["--files", "."]).stdout(), "./subdir/.foo.txt\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `["--files", "."]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1646:24 [INFO] [stdout] | [INFO] [stdout] 1646 | eqnice!(cmd().args(&["--files", "./"]).stdout(), "./subdir/.foo.txt\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `["--files", "./"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1653:24 [INFO] [stdout] | [INFO] [stdout] 1653 | eqnice!(cmd().args(&["--files"]).stdout(), ".foo.txt\n"); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `["--files"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1654:24 [INFO] [stdout] | [INFO] [stdout] 1654 | eqnice!(cmd().args(&["--files", "."]).stdout(), "./.foo.txt\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `["--files", "."]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/regression.rs:1655:24 [INFO] [stdout] | [INFO] [stdout] 1655 | eqnice!(cmd().args(&["--files", "./"]).stdout(), "./.foo.txt\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `["--files", "./"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 20.75s [INFO] running `Command { std: "docker" "inspect" "8e839055055b8f679a2a1bc133309a3a5fec5047c7861b6dff77b24501248477", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8e839055055b8f679a2a1bc133309a3a5fec5047c7861b6dff77b24501248477", kill_on_drop: false }` [INFO] [stdout] 8e839055055b8f679a2a1bc133309a3a5fec5047c7861b6dff77b24501248477