[INFO] fetching crate ringbuff 0.1.7... [INFO] linting ringbuff-0.1.7 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate ringbuff 0.1.7 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate ringbuff 0.1.7 [INFO] finished tweaking crates.io crate ringbuff 0.1.7 [INFO] tweaked toml for crates.io crate ringbuff 0.1.7 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate ringbuff 0.1.7 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate ringbuff 0.1.7 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded test-fuzz-internal v7.2.4 [INFO] [stderr] Downloaded futures-test v0.3.31 [INFO] [stderr] Downloaded serde_combinators v0.1.0 [INFO] [stderr] Downloaded test-fuzz v7.2.4 [INFO] [stderr] Downloaded test-fuzz-runtime v7.2.4 [INFO] [stderr] Downloaded test-fuzz-macro v7.2.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 09bf0b0a9d91705d8fca816721bbe94b8bce7db726d58be011d612c6c33477dd [INFO] running `Command { std: "docker" "start" "-a" "09bf0b0a9d91705d8fca816721bbe94b8bce7db726d58be011d612c6c33477dd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "09bf0b0a9d91705d8fca816721bbe94b8bce7db726d58be011d612c6c33477dd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "09bf0b0a9d91705d8fca816721bbe94b8bce7db726d58be011d612c6c33477dd", kill_on_drop: false }` [INFO] [stdout] 09bf0b0a9d91705d8fca816721bbe94b8bce7db726d58be011d612c6c33477dd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bf943937af5afca4187dd665374ebe5a55ae1dc9d03f5cdcf3c86f525386f752 [INFO] running `Command { std: "docker" "start" "-a" "bf943937af5afca4187dd665374ebe5a55ae1dc9d03f5cdcf3c86f525386f752", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Compiling camino v1.1.12 [INFO] [stderr] Compiling semver v1.0.26 [INFO] [stderr] Compiling quote v1.0.41 [INFO] [stderr] Compiling serde_json v1.0.143 [INFO] [stderr] Compiling virtue v0.0.18 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking regex-syntax v0.8.6 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Compiling test-fuzz-internal v7.2.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking is-terminal v0.4.16 [INFO] [stderr] Compiling test-fuzz v7.2.4 [INFO] [stderr] Checking humantime v2.2.0 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Compiling bincode_derive v2.0.1 [INFO] [stderr] Checking regex-automata v0.4.10 [INFO] [stderr] Checking regex v1.11.2 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking pretty_env_logger v0.5.0 [INFO] [stderr] Compiling darling_core v0.21.3 [INFO] [stderr] Compiling prettyplease v0.2.37 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling thiserror-impl v2.0.16 [INFO] [stderr] Compiling pin-project-internal v1.1.10 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking pin-project v1.1.10 [INFO] [stderr] Checking thiserror v2.0.16 [INFO] [stderr] Compiling darling_macro v0.21.3 [INFO] [stderr] Compiling darling v0.21.3 [INFO] [stderr] Compiling test-fuzz-macro v7.2.4 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking futures-test v0.3.31 [INFO] [stderr] Checking ringbuff v0.1.7 (/opt/rustwide/workdir) [INFO] [stdout] warning: unsafe function's docs are missing a `# Safety` section [INFO] [stdout] --> src/ringbuf.rs:112:5 [INFO] [stdout] | [INFO] [stdout] 112 | pub unsafe fn writable_buf(&mut self) -> &mut [u8] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] = note: `#[warn(clippy::missing_safety_doc)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe function's docs are missing a `# Safety` section [INFO] [stdout] --> src/ringbuf.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 118 | pub unsafe fn readable_buf(&mut self) -> &[u8] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe function's docs are missing a `# Safety` section [INFO] [stdout] --> src/ringbuf.rs:124:5 [INFO] [stdout] | [INFO] [stdout] 124 | pub unsafe fn readable_consume(&mut self, amt: usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ringbuf.rs:127:13 [INFO] [stdout] | [INFO] [stdout] 127 | !(self.read_pos > self.write_pos), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.read_pos <= self.write_pos)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe function's docs are missing a `# Safety` section [INFO] [stdout] --> src/ringbuf.rs:133:5 [INFO] [stdout] | [INFO] [stdout] 133 | pub unsafe fn writable_consume(&mut self, amt: usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ringbuf.rs:136:13 [INFO] [stdout] | [INFO] [stdout] 136 | !((self.read_pos + self.memory_block.len() as u64) < self.write_pos), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((self.read_pos + self.memory_block.len() as u64) >= self.write_pos)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ringbuf.rs:145:13 [INFO] [stdout] | [INFO] [stdout] 145 | !(write_end_pos > self.read_pos + self.memory_block.len() as u64), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(write_end_pos <= self.read_pos + self.memory_block.len() as u64)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ringbuf.rs:166:17 [INFO] [stdout] | [INFO] [stdout] 166 | assert!(!(read_end_pos > self.write_pos), "read_size is overflow."); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(read_end_pos <= self.write_pos)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking cargo-platform v0.1.9 [INFO] [stderr] Checking bincode v2.0.1 [INFO] [stderr] Checking serde_combinators v0.1.0 [INFO] [stderr] Checking cargo_metadata v0.19.2 [INFO] [stderr] Checking test-fuzz-runtime v7.2.4 [INFO] [stdout] warning: unsafe function's docs are missing a `# Safety` section [INFO] [stdout] --> src/ringbuf.rs:112:5 [INFO] [stdout] | [INFO] [stdout] 112 | pub unsafe fn writable_buf(&mut self) -> &mut [u8] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] = note: `#[warn(clippy::missing_safety_doc)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe function's docs are missing a `# Safety` section [INFO] [stdout] --> src/ringbuf.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 118 | pub unsafe fn readable_buf(&mut self) -> &[u8] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe function's docs are missing a `# Safety` section [INFO] [stdout] --> src/ringbuf.rs:124:5 [INFO] [stdout] | [INFO] [stdout] 124 | pub unsafe fn readable_consume(&mut self, amt: usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ringbuf.rs:127:13 [INFO] [stdout] | [INFO] [stdout] 127 | !(self.read_pos > self.write_pos), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.read_pos <= self.write_pos)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe function's docs are missing a `# Safety` section [INFO] [stdout] --> src/ringbuf.rs:133:5 [INFO] [stdout] | [INFO] [stdout] 133 | pub unsafe fn writable_consume(&mut self, amt: usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ringbuf.rs:136:13 [INFO] [stdout] | [INFO] [stdout] 136 | !((self.read_pos + self.memory_block.len() as u64) < self.write_pos), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((self.read_pos + self.memory_block.len() as u64) >= self.write_pos)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ringbuf.rs:145:13 [INFO] [stdout] | [INFO] [stdout] 145 | !(write_end_pos > self.read_pos + self.memory_block.len() as u64), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(write_end_pos <= self.read_pos + self.memory_block.len() as u64)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ringbuf.rs:166:17 [INFO] [stdout] | [INFO] [stdout] 166 | assert!(!(read_end_pos > self.write_pos), "read_size is overflow."); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(read_end_pos <= self.write_pos)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 33.03s [INFO] running `Command { std: "docker" "inspect" "bf943937af5afca4187dd665374ebe5a55ae1dc9d03f5cdcf3c86f525386f752", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bf943937af5afca4187dd665374ebe5a55ae1dc9d03f5cdcf3c86f525386f752", kill_on_drop: false }` [INFO] [stdout] bf943937af5afca4187dd665374ebe5a55ae1dc9d03f5cdcf3c86f525386f752