[INFO] fetching crate ricecoder-images 0.1.71... [INFO] linting ricecoder-images-0.1.71 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate ricecoder-images 0.1.71 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate ricecoder-images 0.1.71 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate ricecoder-images 0.1.71 [INFO] tweaked toml for crates.io crate ricecoder-images 0.1.71 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate ricecoder-images 0.1.71 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate ricecoder-images 0.1.71 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded ricecoder-files v0.1.71 [INFO] [stderr] Downloaded ricecoder-providers v0.1.71 [INFO] [stderr] Downloaded ricecoder-storage v0.1.71 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2a613e4339be641c87b8616c8f508ec9170c2324c7c9094ec6b0cb13a1712e09 [INFO] running `Command { std: "docker" "start" "-a" "2a613e4339be641c87b8616c8f508ec9170c2324c7c9094ec6b0cb13a1712e09", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2a613e4339be641c87b8616c8f508ec9170c2324c7c9094ec6b0cb13a1712e09", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2a613e4339be641c87b8616c8f508ec9170c2324c7c9094ec6b0cb13a1712e09", kill_on_drop: false }` [INFO] [stdout] 2a613e4339be641c87b8616c8f508ec9170c2324c7c9094ec6b0cb13a1712e09 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cfb83971a24c3f10cb7cee5ba519b8ea295a8dc3fc6cad35ecc6e25276cde24e [INFO] running `Command { std: "docker" "start" "-a" "cfb83971a24c3f10cb7cee5ba519b8ea295a8dc3fc6cad35ecc6e25276cde24e", kill_on_drop: false }` [INFO] [stderr] Compiling zerocopy v0.8.31 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking signal-hook-registry v1.4.7 [INFO] [stderr] Checking indexmap v2.12.1 [INFO] [stderr] Checking tracing-core v0.1.35 [INFO] [stderr] Compiling cc v1.0.106 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling zerocopy-derive v0.8.31 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking tracing v0.1.43 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Compiling pulldown-cmark v0.9.6 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking inotify v0.9.6 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking crossbeam-channel v0.5.15 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Checking filetime v0.2.26 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking flate2 v1.1.5 [INFO] [stderr] Checking fdeflate v0.3.7 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking bytemuck v1.24.0 [INFO] [stderr] Checking notify v6.1.1 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Checking tempfile v3.23.0 [INFO] [stderr] Compiling async-stream-impl v0.3.6 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking tiff v0.9.1 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking uuid v1.18.1 [INFO] [stderr] Checking wait-timeout v0.2.1 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking rusty-fork v0.3.1 [INFO] [stderr] Checking async-stream v0.3.6 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking rand_xorshift v0.4.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Compiling openssl-sys v0.9.111 [INFO] [stderr] Compiling libz-sys v1.1.23 [INFO] [stderr] Compiling libssh2-sys v0.3.1 [INFO] [stderr] Compiling libgit2-sys v0.16.2+1.7.2 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Compiling openssl v0.10.75 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.1 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking exr v1.74.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking proptest v1.9.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking tokio-util v0.7.17 [INFO] [stderr] Checking ricecoder-storage v0.1.71 [INFO] [stderr] Checking tokio-stream v0.1.17 [INFO] [stderr] Checking tokio-test v0.4.4 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking git2 v0.18.3 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking ricecoder-files v0.1.71 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking ricecoder-providers v0.1.71 [INFO] [stderr] Checking ricecoder-images v0.1.71 (/opt/rustwide/workdir) [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/session_integration_tests.rs:147:19 [INFO] [stdout] | [INFO] [stdout] 147 | let formats = vec![ [INFO] [stdout] | ___________________^ [INFO] [stdout] 148 | | ImageFormat::Png, [INFO] [stdout] 149 | | ImageFormat::Jpeg, [INFO] [stdout] 150 | | ImageFormat::Gif, [INFO] [stdout] 151 | | ImageFormat::WebP, [INFO] [stdout] 152 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 147 ~ let formats = [ImageFormat::Png, [INFO] [stdout] 148 + ImageFormat::Jpeg, [INFO] [stdout] 149 + ImageFormat::Gif, [INFO] [stdout] 150 ~ ImageFormat::WebP]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/session_integration_tests.rs:174:17 [INFO] [stdout] | [INFO] [stdout] 174 | let sizes = vec![1024, 1024 * 1024, 5 * 1024 * 1024, 10 * 1024 * 1024]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[1024, 1024 * 1024, 5 * 1024 * 1024, 10 * 1024 * 1024]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/session_integration_tests.rs:196:22 [INFO] [stdout] | [INFO] [stdout] 196 | let dimensions = vec![ [INFO] [stdout] | ______________________^ [INFO] [stdout] 197 | | (640, 480), [INFO] [stdout] 198 | | (800, 600), [INFO] [stdout] 199 | | (1024, 768), [INFO] [stdout] 200 | | (1920, 1080), [INFO] [stdout] 201 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 196 ~ let dimensions = [(640, 480), [INFO] [stdout] 197 + (800, 600), [INFO] [stdout] 198 + (1024, 768), [INFO] [stdout] 199 ~ (1920, 1080)]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u64` is unnecessary [INFO] [stdout] --> tests/provider_integration_tests.rs:280:51 [INFO] [stdout] | [INFO] [stdout] 280 | assert_eq!(image_data.size_bytes, 10 * 1024 * 1024 as u64); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `1024_u64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/provider_integration_tests.rs:354:19 [INFO] [stdout] | [INFO] [stdout] 354 | let formats = vec![ [INFO] [stdout] | ___________________^ [INFO] [stdout] 355 | | ProviderImageFormat::OpenAi, [INFO] [stdout] 356 | | ProviderImageFormat::Anthropic, [INFO] [stdout] 357 | | ProviderImageFormat::Google, [INFO] [stdout] 358 | | ProviderImageFormat::Ollama, [INFO] [stdout] 359 | | ProviderImageFormat::Generic, [INFO] [stdout] 360 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 354 ~ let formats = [ProviderImageFormat::OpenAi, [INFO] [stdout] 355 + ProviderImageFormat::Anthropic, [INFO] [stdout] 356 + ProviderImageFormat::Google, [INFO] [stdout] 357 + ProviderImageFormat::Ollama, [INFO] [stdout] 358 ~ ProviderImageFormat::Generic]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/format_validation_properties.rs:38:13 [INFO] [stdout] | [INFO] [stdout] 38 | / !bytes.starts_with(&[0x89, 0x50, 0x4E, 0x47]) // PNG [INFO] [stdout] 39 | | && !bytes.starts_with(&[0xFF, 0xD8, 0xFF]) // JPEG [INFO] [stdout] 40 | | && !bytes.starts_with(b"GIF") // GIF [INFO] [stdout] 41 | | && !(bytes.len() >= 12 [INFO] [stdout] 42 | | && bytes.starts_with(b"RIFF") [INFO] [stdout] 43 | | && bytes[8..12] == *b"WEBP") // WebP [INFO] [stdout] | |________________________________________________^ help: try: `!(bytes.starts_with(&[0x89, 0x50, 0x4E, 0x47]) || bytes.starts_with(&[0xFF, 0xD8, 0xFF]) || bytes.starts_with(b"GIF") || bytes.len() >= 12 && bytes.starts_with(b"RIFF") && bytes[8..12] == *b"WEBP")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/analyzer.rs:540:17 [INFO] [stdout] | [INFO] [stdout] 540 | assert!(encoded.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!encoded.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/display.rs:368:17 [INFO] [stdout] | [INFO] [stdout] 368 | assert!(lines.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!lines.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/display.rs:472:17 [INFO] [stdout] | [INFO] [stdout] 472 | assert!(separator.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!separator.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/storage_integration_tests.rs:139:18 [INFO] [stdout] | [INFO] [stdout] 139 | let hashes = vec![ [INFO] [stdout] | __________________^ [INFO] [stdout] 140 | | format!("hash_diff_1_{}", test_id), [INFO] [stdout] 141 | | format!("hash_diff_2_{}", test_id), [INFO] [stdout] 142 | | format!("hash_diff_3_{}", test_id), [INFO] [stdout] 143 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 139 ~ let hashes = [format!("hash_diff_1_{}", test_id), [INFO] [stdout] 140 + format!("hash_diff_2_{}", test_id), [INFO] [stdout] 141 ~ format!("hash_diff_3_{}", test_id)]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/storage_integration_tests.rs:144:20 [INFO] [stdout] | [INFO] [stdout] 144 | let analyses = vec![ [INFO] [stdout] | ____________________^ [INFO] [stdout] 145 | | "Analysis of image 1", [INFO] [stdout] 146 | | "Analysis of image 2", [INFO] [stdout] 147 | | "Analysis of image 3", [INFO] [stdout] 148 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 144 ~ let analyses = ["Analysis of image 1", [INFO] [stdout] 145 + "Analysis of image 2", [INFO] [stdout] 146 ~ "Analysis of image 3"]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/storage_integration_tests.rs:203:24 [INFO] [stdout] | [INFO] [stdout] 203 | let token_counts = vec![50, 100, 200, 500]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[50, 100, 200, 500]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 54.26s [INFO] running `Command { std: "docker" "inspect" "cfb83971a24c3f10cb7cee5ba519b8ea295a8dc3fc6cad35ecc6e25276cde24e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cfb83971a24c3f10cb7cee5ba519b8ea295a8dc3fc6cad35ecc6e25276cde24e", kill_on_drop: false }` [INFO] [stdout] cfb83971a24c3f10cb7cee5ba519b8ea295a8dc3fc6cad35ecc6e25276cde24e