[INFO] fetching crate ricecoder-external-lsp 0.1.71... [INFO] linting ricecoder-external-lsp-0.1.71 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate ricecoder-external-lsp 0.1.71 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate ricecoder-external-lsp 0.1.71 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate ricecoder-external-lsp 0.1.71 [INFO] tweaked toml for crates.io crate ricecoder-external-lsp 0.1.71 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate ricecoder-external-lsp 0.1.71 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate ricecoder-external-lsp 0.1.71 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded ricecoder-lsp v0.1.71 [INFO] [stderr] Downloaded ricecoder-files v0.1.71 [INFO] [stderr] Downloaded ricecoder-refactoring v0.1.71 [INFO] [stderr] Downloaded ricecoder-completion v0.1.71 [INFO] [stderr] Downloaded tree-sitter v0.20.10 [INFO] [stderr] Downloaded ricecoder-storage v0.1.71 [INFO] [stderr] Downloaded tree-sitter-python v0.20.4 [INFO] [stderr] Downloaded tree-sitter-rust v0.20.4 [INFO] [stderr] Downloaded libz-sys v1.1.23 [INFO] [stderr] Downloaded tree-sitter-typescript v0.20.5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b160186ba32ab17f51d2aa8803869a5b2889f83b0544fedb84edc37beb95a2a1 [INFO] running `Command { std: "docker" "start" "-a" "b160186ba32ab17f51d2aa8803869a5b2889f83b0544fedb84edc37beb95a2a1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b160186ba32ab17f51d2aa8803869a5b2889f83b0544fedb84edc37beb95a2a1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b160186ba32ab17f51d2aa8803869a5b2889f83b0544fedb84edc37beb95a2a1", kill_on_drop: false }` [INFO] [stdout] b160186ba32ab17f51d2aa8803869a5b2889f83b0544fedb84edc37beb95a2a1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 523d56941d61f5c51376c73f44a8a5a435b1fb494c2b3e40003b28df0d51f595 [INFO] running `Command { std: "docker" "start" "-a" "523d56941d61f5c51376c73f44a8a5a435b1fb494c2b3e40003b28df0d51f595", kill_on_drop: false }` [INFO] [stderr] Compiling once_cell v1.21.3 [INFO] [stderr] Compiling libc v0.2.177 [INFO] [stderr] Checking log v0.4.28 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking tracing-core v0.1.35 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Compiling pulldown-cmark v0.9.6 [INFO] [stderr] Checking toml_write v0.1.2 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking serde_json v1.0.145 [INFO] [stderr] Checking filetime v0.2.26 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking inotify v0.9.6 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking rustix v1.1.2 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Compiling async-stream-impl v0.3.6 [INFO] [stderr] Checking wait-timeout v0.2.1 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking rand_xorshift v0.4.0 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking uuid v1.18.1 [INFO] [stderr] Checking async-stream v0.3.6 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking crossbeam-channel v0.5.15 [INFO] [stderr] Checking tracing v0.1.43 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Checking notify v6.1.1 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Compiling cc v1.0.106 [INFO] [stderr] Compiling libz-sys v1.1.23 [INFO] [stderr] Compiling openssl-sys v0.9.111 [INFO] [stderr] Compiling libssh2-sys v0.3.1 [INFO] [stderr] Compiling tree-sitter v0.20.10 [INFO] [stderr] Compiling libgit2-sys v0.16.2+1.7.2 [INFO] [stderr] Compiling tree-sitter-rust v0.20.4 [INFO] [stderr] Compiling tree-sitter-typescript v0.20.5 [INFO] [stderr] Compiling tree-sitter-python v0.20.4 [INFO] [stderr] Checking tempfile v3.23.0 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking rusty-fork v0.3.1 [INFO] [stderr] Checking proptest v1.9.0 [INFO] [stderr] Checking ricecoder-storage v0.1.71 [INFO] [stderr] Checking tokio-stream v0.1.17 [INFO] [stderr] Checking tokio-test v0.4.4 [INFO] [stderr] Checking ricecoder-completion v0.1.71 [INFO] [stderr] Checking git2 v0.18.3 [INFO] [stderr] Checking ricecoder-files v0.1.71 [INFO] [stderr] Checking ricecoder-refactoring v0.1.71 [INFO] [stderr] Checking ricecoder-lsp v0.1.71 [INFO] [stderr] Checking ricecoder-external-lsp v0.1.71 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mapping/transformer.rs:336:17 [INFO] [stdout] | [INFO] [stdout] 336 | assert!(!results[0].get("detail").is_some() || results[0]["detail"].is_null()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `results[0].get("detail").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mapping/hover.rs:205:17 [INFO] [stdout] | [INFO] [stdout] 205 | assert!(!result.get("language").is_some() || result["language"].is_null()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `result.get("language").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `request_id_strategy` is never used [INFO] [stdout] --> tests/lsp_client_property_tests.rs:11:4 [INFO] [stdout] | [INFO] [stdout] 11 | fn request_id_strategy() -> impl Strategy { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's keys [INFO] [stdout] --> tests/output_mapping_property_tests.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | / map.into_iter() [INFO] [stdout] 29 | | .map(|(k, _)| { [INFO] [stdout] 30 | | let v = match k.as_str() { [INFO] [stdout] 31 | | "label" => "$.label", [INFO] [stdout] ... | [INFO] [stdout] 38 | | (k, v.to_string()) [INFO] [stdout] 39 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] = note: `#[warn(clippy::iter_kv_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 28 ~ map.into_keys().map(|k| { [INFO] [stdout] 29 + let v = match k.as_str() { [INFO] [stdout] 30 + "label" => "$.label", [INFO] [stdout] 31 + "detail" => "$.detail", [INFO] [stdout] 32 + "kind" => "$.kind", [INFO] [stdout] 33 + "message" => "$.message", [INFO] [stdout] 34 + "severity" => "$.severity", [INFO] [stdout] 35 + _ => "$.value", [INFO] [stdout] 36 + }; [INFO] [stdout] 37 + (k, v.to_string()) [INFO] [stdout] 38 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/output_mapping_property_tests.rs:398:22 [INFO] [stdout] | [INFO] [stdout] 398 | prop_assert!(!items[0].get("detail").is_some() || items[0]["detail"].is_null()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `items[0].get("detail").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 49.94s [INFO] running `Command { std: "docker" "inspect" "523d56941d61f5c51376c73f44a8a5a435b1fb494c2b3e40003b28df0d51f595", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "523d56941d61f5c51376c73f44a8a5a435b1fb494c2b3e40003b28df0d51f595", kill_on_drop: false }` [INFO] [stdout] 523d56941d61f5c51376c73f44a8a5a435b1fb494c2b3e40003b28df0d51f595