[INFO] fetching crate rfs_br 1.0.2... [INFO] linting rfs_br-1.0.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate rfs_br 1.0.2 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate rfs_br 1.0.2 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate rfs_br 1.0.2 [INFO] tweaked toml for crates.io crate rfs_br 1.0.2 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate rfs_br 1.0.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate rfs_br 1.0.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ea1b7dcd938323c82340d733fdaf6366e537bf85d83b042510ee80f1362035d2 [INFO] running `Command { std: "docker" "start" "-a" "ea1b7dcd938323c82340d733fdaf6366e537bf85d83b042510ee80f1362035d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ea1b7dcd938323c82340d733fdaf6366e537bf85d83b042510ee80f1362035d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ea1b7dcd938323c82340d733fdaf6366e537bf85d83b042510ee80f1362035d2", kill_on_drop: false }` [INFO] [stdout] ea1b7dcd938323c82340d733fdaf6366e537bf85d83b042510ee80f1362035d2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 75262fd8a848ed7e22d8d5d02534e81587b4ae88ab6340c24d3c037cc2c4add4 [INFO] running `Command { std: "docker" "start" "-a" "75262fd8a848ed7e22d8d5d02534e81587b4ae88ab6340c24d3c037cc2c4add4", kill_on_drop: false }` [INFO] [stderr] Checking rfs_br v1.0.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary use of `.write(true)` because there is `.append(true)` [INFO] [stdout] --> src/file_system.rs:60:43 [INFO] [stdout] | [INFO] [stdout] 60 | let mut f = fs::OpenOptions::new().write(true).append(true).open(file)?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove `.write(true)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options [INFO] [stdout] = note: `#[warn(clippy::ineffective_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `.write(true)` because there is `.append(true)` [INFO] [stdout] --> src/file_system.rs:60:43 [INFO] [stdout] | [INFO] [stdout] 60 | let mut f = fs::OpenOptions::new().write(true).append(true).open(file)?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove `.write(true)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options [INFO] [stdout] = note: `#[warn(clippy::ineffective_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/file_system_test.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | assert!(!file_system.read_file(&(test_dir.to_owned()+ "/"+ file)).is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `file_system.read_file(&(test_dir.to_owned()+ "/"+ file)).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/file_system_test.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | return content.as_bytes(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return content.as_bytes(); [INFO] [stdout] 22 + content.as_bytes() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.22s [INFO] running `Command { std: "docker" "inspect" "75262fd8a848ed7e22d8d5d02534e81587b4ae88ab6340c24d3c037cc2c4add4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "75262fd8a848ed7e22d8d5d02534e81587b4ae88ab6340c24d3c037cc2c4add4", kill_on_drop: false }` [INFO] [stdout] 75262fd8a848ed7e22d8d5d02534e81587b4ae88ab6340c24d3c037cc2c4add4