[INFO] fetching crate rfc9839-rs 0.0.3... [INFO] linting rfc9839-rs-0.0.3 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate rfc9839-rs 0.0.3 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate rfc9839-rs 0.0.3 [INFO] finished tweaking crates.io crate rfc9839-rs 0.0.3 [INFO] tweaked toml for crates.io crate rfc9839-rs 0.0.3 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate rfc9839-rs 0.0.3 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate rfc9839-rs 0.0.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5c2cdf4e28fae16693e1741140a289c595b09cea89a775952e2503d3d5bb485b [INFO] running `Command { std: "docker" "start" "-a" "5c2cdf4e28fae16693e1741140a289c595b09cea89a775952e2503d3d5bb485b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5c2cdf4e28fae16693e1741140a289c595b09cea89a775952e2503d3d5bb485b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5c2cdf4e28fae16693e1741140a289c595b09cea89a775952e2503d3d5bb485b", kill_on_drop: false }` [INFO] [stdout] 5c2cdf4e28fae16693e1741140a289c595b09cea89a775952e2503d3d5bb485b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7a62de793394d29311c5dc50221238ba18e0b90a798f7033b6893430c9a4d8f7 [INFO] running `Command { std: "docker" "start" "-a" "7a62de793394d29311c5dc50221238ba18e0b90a798f7033b6893430c9a4d8f7", kill_on_drop: false }` [INFO] [stderr] Checking rfc9839-rs v0.0.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: this OR pattern can be rewritten using a range [INFO] [stdout] --> src/lib.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 11 | matches!(c, 0xd800..=0xdbff | 0xdc00..=0xdfff) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `0xd800..=0xdfff` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_patterns [INFO] [stdout] = note: `#[warn(clippy::manual_range_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | / !(control::is_c0_control(c) [INFO] [stdout] 103 | | && !control::is_useful_control(c)) [INFO] [stdout] 104 | | && !is_unicode_surrotate(c) [INFO] [stdout] 105 | | && !matches!(c, 0xfffe..=0xffff) [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 102 - !(control::is_c0_control(c) [INFO] [stdout] 103 - && !control::is_useful_control(c)) [INFO] [stdout] 104 - && !is_unicode_surrotate(c) [INFO] [stdout] 105 - && !matches!(c, 0xfffe..=0xffff) [INFO] [stdout] 102 + !(is_unicode_surrotate(c) || matches!(c, 0xfffe..=0xffff) || control::is_c0_control(c) && !control::is_useful_control(c)) [INFO] [stdout] | [INFO] [stdout] 102 - !(control::is_c0_control(c) [INFO] [stdout] 103 - && !control::is_useful_control(c)) [INFO] [stdout] 104 - && !is_unicode_surrotate(c) [INFO] [stdout] 105 - && !matches!(c, 0xfffe..=0xffff) [INFO] [stdout] 102 + (control::is_useful_control(c) || !control::is_c0_control(c)) && !matches!(c, 0xfffe..=0xffff) && !is_unicode_surrotate(c) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | / !(control::is_c0_control(c) [INFO] [stdout] 103 | | && !control::is_useful_control(c)) [INFO] [stdout] 104 | | && !is_unicode_surrotate(c) [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 102 - !(control::is_c0_control(c) [INFO] [stdout] 103 - && !control::is_useful_control(c)) [INFO] [stdout] 104 - && !is_unicode_surrotate(c) [INFO] [stdout] 102 + !(is_unicode_surrotate(c) || control::is_c0_control(c) && !control::is_useful_control(c)) [INFO] [stdout] | [INFO] [stdout] 102 - !(control::is_c0_control(c) [INFO] [stdout] 103 - && !control::is_useful_control(c)) [INFO] [stdout] 104 - && !is_unicode_surrotate(c) [INFO] [stdout] 102 + (control::is_useful_control(c) || !control::is_c0_control(c)) && !is_unicode_surrotate(c) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | / !(control::is_c0_control(c) [INFO] [stdout] 103 | | && !control::is_useful_control(c)) [INFO] [stdout] | |______________________________________________^ help: try: `!control::is_c0_control(c) || control::is_useful_control(c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | / c != 0x7f // del [INFO] [stdout] 115 | | && !(control::is_c0_control(c) [INFO] [stdout] 116 | | && !control::is_useful_control(c)) [INFO] [stdout] 117 | | && !control::is_c1_control(c) [INFO] [stdout] 118 | | && !is_unicode_surrotate(c) [INFO] [stdout] 119 | | && !is_noncharacter(c) [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 114 - c != 0x7f // del [INFO] [stdout] 115 - && !(control::is_c0_control(c) [INFO] [stdout] 116 - && !control::is_useful_control(c)) [INFO] [stdout] 117 - && !control::is_c1_control(c) [INFO] [stdout] 118 - && !is_unicode_surrotate(c) [INFO] [stdout] 119 - && !is_noncharacter(c) [INFO] [stdout] 114 + !(c == 0x7f || control::is_c1_control(c) || is_unicode_surrotate(c) || is_noncharacter(c) || control::is_c0_control(c) && !control::is_useful_control(c)) [INFO] [stdout] | [INFO] [stdout] 114 - c != 0x7f // del [INFO] [stdout] 115 - && !(control::is_c0_control(c) [INFO] [stdout] 116 - && !control::is_useful_control(c)) [INFO] [stdout] 117 - && !control::is_c1_control(c) [INFO] [stdout] 118 - && !is_unicode_surrotate(c) [INFO] [stdout] 119 - && !is_noncharacter(c) [INFO] [stdout] 114 + (control::is_useful_control(c) || !control::is_c0_control(c)) && !is_noncharacter(c) && !is_unicode_surrotate(c) && !control::is_c1_control(c) && c != 0x7f [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | / c != 0x7f // del [INFO] [stdout] 115 | | && !(control::is_c0_control(c) [INFO] [stdout] 116 | | && !control::is_useful_control(c)) [INFO] [stdout] 117 | | && !control::is_c1_control(c) [INFO] [stdout] 118 | | && !is_unicode_surrotate(c) [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 114 - c != 0x7f // del [INFO] [stdout] 115 - && !(control::is_c0_control(c) [INFO] [stdout] 116 - && !control::is_useful_control(c)) [INFO] [stdout] 117 - && !control::is_c1_control(c) [INFO] [stdout] 118 - && !is_unicode_surrotate(c) [INFO] [stdout] 114 + !(c == 0x7f || control::is_c1_control(c) || is_unicode_surrotate(c) || control::is_c0_control(c) && !control::is_useful_control(c)) [INFO] [stdout] | [INFO] [stdout] 114 - c != 0x7f // del [INFO] [stdout] 115 - && !(control::is_c0_control(c) [INFO] [stdout] 116 - && !control::is_useful_control(c)) [INFO] [stdout] 117 - && !control::is_c1_control(c) [INFO] [stdout] 118 - && !is_unicode_surrotate(c) [INFO] [stdout] 114 + (control::is_useful_control(c) || !control::is_c0_control(c)) && !is_unicode_surrotate(c) && !control::is_c1_control(c) && c != 0x7f [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | / c != 0x7f // del [INFO] [stdout] 115 | | && !(control::is_c0_control(c) [INFO] [stdout] 116 | | && !control::is_useful_control(c)) [INFO] [stdout] 117 | | && !control::is_c1_control(c) [INFO] [stdout] | |_____________________________________^ help: try: `(control::is_useful_control(c) || !control::is_c0_control(c)) && !control::is_c1_control(c) && c != 0x7f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | / c != 0x7f // del [INFO] [stdout] 115 | | && !(control::is_c0_control(c) [INFO] [stdout] 116 | | && !control::is_useful_control(c)) [INFO] [stdout] | |______________________________________________^ help: try: `(control::is_useful_control(c) || !control::is_c0_control(c)) && c != 0x7f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:115:12 [INFO] [stdout] | [INFO] [stdout] 115 | && !(control::is_c0_control(c) [INFO] [stdout] | ____________^ [INFO] [stdout] 116 | | && !control::is_useful_control(c)) [INFO] [stdout] | |______________________________________________^ help: try: `!control::is_c0_control(c) || control::is_useful_control(c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this OR pattern can be rewritten using a range [INFO] [stdout] --> src/lib.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 11 | matches!(c, 0xd800..=0xdbff | 0xdc00..=0xdfff) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `0xd800..=0xdfff` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_patterns [INFO] [stdout] = note: `#[warn(clippy::manual_range_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | / !(control::is_c0_control(c) [INFO] [stdout] 103 | | && !control::is_useful_control(c)) [INFO] [stdout] 104 | | && !is_unicode_surrotate(c) [INFO] [stdout] 105 | | && !matches!(c, 0xfffe..=0xffff) [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 102 - !(control::is_c0_control(c) [INFO] [stdout] 103 - && !control::is_useful_control(c)) [INFO] [stdout] 104 - && !is_unicode_surrotate(c) [INFO] [stdout] 105 - && !matches!(c, 0xfffe..=0xffff) [INFO] [stdout] 102 + !(is_unicode_surrotate(c) || matches!(c, 0xfffe..=0xffff) || control::is_c0_control(c) && !control::is_useful_control(c)) [INFO] [stdout] | [INFO] [stdout] 102 - !(control::is_c0_control(c) [INFO] [stdout] 103 - && !control::is_useful_control(c)) [INFO] [stdout] 104 - && !is_unicode_surrotate(c) [INFO] [stdout] 105 - && !matches!(c, 0xfffe..=0xffff) [INFO] [stdout] 102 + (control::is_useful_control(c) || !control::is_c0_control(c)) && !matches!(c, 0xfffe..=0xffff) && !is_unicode_surrotate(c) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | / !(control::is_c0_control(c) [INFO] [stdout] 103 | | && !control::is_useful_control(c)) [INFO] [stdout] 104 | | && !is_unicode_surrotate(c) [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 102 - !(control::is_c0_control(c) [INFO] [stdout] 103 - && !control::is_useful_control(c)) [INFO] [stdout] 104 - && !is_unicode_surrotate(c) [INFO] [stdout] 102 + !(is_unicode_surrotate(c) || control::is_c0_control(c) && !control::is_useful_control(c)) [INFO] [stdout] | [INFO] [stdout] 102 - !(control::is_c0_control(c) [INFO] [stdout] 103 - && !control::is_useful_control(c)) [INFO] [stdout] 104 - && !is_unicode_surrotate(c) [INFO] [stdout] 102 + (control::is_useful_control(c) || !control::is_c0_control(c)) && !is_unicode_surrotate(c) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | / !(control::is_c0_control(c) [INFO] [stdout] 103 | | && !control::is_useful_control(c)) [INFO] [stdout] | |______________________________________________^ help: try: `!control::is_c0_control(c) || control::is_useful_control(c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | / c != 0x7f // del [INFO] [stdout] 115 | | && !(control::is_c0_control(c) [INFO] [stdout] 116 | | && !control::is_useful_control(c)) [INFO] [stdout] 117 | | && !control::is_c1_control(c) [INFO] [stdout] 118 | | && !is_unicode_surrotate(c) [INFO] [stdout] 119 | | && !is_noncharacter(c) [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 114 - c != 0x7f // del [INFO] [stdout] 115 - && !(control::is_c0_control(c) [INFO] [stdout] 116 - && !control::is_useful_control(c)) [INFO] [stdout] 117 - && !control::is_c1_control(c) [INFO] [stdout] 118 - && !is_unicode_surrotate(c) [INFO] [stdout] 119 - && !is_noncharacter(c) [INFO] [stdout] 114 + !(c == 0x7f || control::is_c1_control(c) || is_unicode_surrotate(c) || is_noncharacter(c) || control::is_c0_control(c) && !control::is_useful_control(c)) [INFO] [stdout] | [INFO] [stdout] 114 - c != 0x7f // del [INFO] [stdout] 115 - && !(control::is_c0_control(c) [INFO] [stdout] 116 - && !control::is_useful_control(c)) [INFO] [stdout] 117 - && !control::is_c1_control(c) [INFO] [stdout] 118 - && !is_unicode_surrotate(c) [INFO] [stdout] 119 - && !is_noncharacter(c) [INFO] [stdout] 114 + (control::is_useful_control(c) || !control::is_c0_control(c)) && !is_noncharacter(c) && !is_unicode_surrotate(c) && !control::is_c1_control(c) && c != 0x7f [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | / c != 0x7f // del [INFO] [stdout] 115 | | && !(control::is_c0_control(c) [INFO] [stdout] 116 | | && !control::is_useful_control(c)) [INFO] [stdout] 117 | | && !control::is_c1_control(c) [INFO] [stdout] 118 | | && !is_unicode_surrotate(c) [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 114 - c != 0x7f // del [INFO] [stdout] 115 - && !(control::is_c0_control(c) [INFO] [stdout] 116 - && !control::is_useful_control(c)) [INFO] [stdout] 117 - && !control::is_c1_control(c) [INFO] [stdout] 118 - && !is_unicode_surrotate(c) [INFO] [stdout] 114 + !(c == 0x7f || control::is_c1_control(c) || is_unicode_surrotate(c) || control::is_c0_control(c) && !control::is_useful_control(c)) [INFO] [stdout] | [INFO] [stdout] 114 - c != 0x7f // del [INFO] [stdout] 115 - && !(control::is_c0_control(c) [INFO] [stdout] 116 - && !control::is_useful_control(c)) [INFO] [stdout] 117 - && !control::is_c1_control(c) [INFO] [stdout] 118 - && !is_unicode_surrotate(c) [INFO] [stdout] 114 + (control::is_useful_control(c) || !control::is_c0_control(c)) && !is_unicode_surrotate(c) && !control::is_c1_control(c) && c != 0x7f [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | / c != 0x7f // del [INFO] [stdout] 115 | | && !(control::is_c0_control(c) [INFO] [stdout] 116 | | && !control::is_useful_control(c)) [INFO] [stdout] 117 | | && !control::is_c1_control(c) [INFO] [stdout] | |_____________________________________^ help: try: `(control::is_useful_control(c) || !control::is_c0_control(c)) && !control::is_c1_control(c) && c != 0x7f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | / c != 0x7f // del [INFO] [stdout] 115 | | && !(control::is_c0_control(c) [INFO] [stdout] 116 | | && !control::is_useful_control(c)) [INFO] [stdout] | |______________________________________________^ help: try: `(control::is_useful_control(c) || !control::is_c0_control(c)) && c != 0x7f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:115:12 [INFO] [stdout] | [INFO] [stdout] 115 | && !(control::is_c0_control(c) [INFO] [stdout] | ____________^ [INFO] [stdout] 116 | | && !control::is_useful_control(c)) [INFO] [stdout] | |______________________________________________^ help: try: `!control::is_c0_control(c) || control::is_useful_control(c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/lib.rs:134:21 [INFO] [stdout] | [INFO] [stdout] 134 | p(i) == false, [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `!p(i)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/lib.rs:150:17 [INFO] [stdout] | [INFO] [stdout] 150 | p(i) == false, [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `!p(i)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.26s [INFO] running `Command { std: "docker" "inspect" "7a62de793394d29311c5dc50221238ba18e0b90a798f7033b6893430c9a4d8f7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7a62de793394d29311c5dc50221238ba18e0b90a798f7033b6893430c9a4d8f7", kill_on_drop: false }` [INFO] [stdout] 7a62de793394d29311c5dc50221238ba18e0b90a798f7033b6893430c9a4d8f7