[INFO] fetching crate reproto-core 0.3.36... [INFO] linting reproto-core-0.3.36 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate reproto-core 0.3.36 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate reproto-core 0.3.36 [INFO] finished tweaking crates.io crate reproto-core 0.3.36 [INFO] tweaked toml for crates.io crate reproto-core 0.3.36 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate reproto-core 0.3.36 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 39 packages to latest compatible versions [INFO] [stderr] Adding num-bigint v0.1.45 (available: v0.4.6) [INFO] [stderr] Adding num-traits v0.1.43 (available: v0.2.19) [INFO] [stderr] Adding relative-path v0.3.7 (available: v2.0.1) [INFO] [stderr] Adding ropey v0.6.3 (available: v1.6.1) [INFO] [stderr] Adding url v1.7.2 (available: v2.5.8) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `num-bigint` dependency) [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `num-integer` dependency) [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `num-traits` dependency) [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f3f474744cbc1d17e119eb7eabf4e6a2dc3d9052c20d1275b87d1dd37ca635e2 [INFO] running `Command { std: "docker" "start" "-a" "f3f474744cbc1d17e119eb7eabf4e6a2dc3d9052c20d1275b87d1dd37ca635e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f3f474744cbc1d17e119eb7eabf4e6a2dc3d9052c20d1275b87d1dd37ca635e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f3f474744cbc1d17e119eb7eabf4e6a2dc3d9052c20d1275b87d1dd37ca635e2", kill_on_drop: false }` [INFO] [stdout] f3f474744cbc1d17e119eb7eabf4e6a2dc3d9052c20d1275b87d1dd37ca635e2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 302551dd094cdef7c3b9401c8e3b90f9c6da40e234cb0ef01287b03f3af2bf66 [INFO] running `Command { std: "docker" "start" "-a" "302551dd094cdef7c3b9401c8e3b90f9c6da40e234cb0ef01287b03f3af2bf66", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `num-bigint` dependency) [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `num-integer` dependency) [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `num-traits` dependency) [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling object v0.37.3 [INFO] [stderr] Compiling num-bigint v0.1.45 [INFO] [stderr] Checking unicode-bidi v0.3.18 [INFO] [stderr] Checking memchr v2.8.0 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Checking gimli v0.32.3 [INFO] [stderr] Checking tinyvec v1.11.0 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking percent-encoding v1.0.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking rustc-demangle v0.1.27 [INFO] [stderr] Checking unicode-segmentation v1.12.0 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Checking unicode-normalization v0.1.25 [INFO] [stderr] Checking ropey v0.6.3 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking addr2line v0.25.1 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking relative-path v0.3.7 [INFO] [stderr] Checking reproto-semver v0.3.36 [INFO] [stderr] Checking backtrace v0.3.76 [INFO] [stderr] Checking reproto-core v0.3.36 (/opt/rustwide/workdir) [INFO] [stdout] warning: lint name `linkedlist` is deprecated and may not have an effect in the future [INFO] [stdout] --> src/rp_file.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | #[allow(linkedlist)] [INFO] [stdout] | ^^^^^^^^^^ help: change it to: `clippy::linkedlist` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint name `linkedlist` is deprecated and may not have an effect in the future [INFO] [stdout] --> src/rp_file.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | #[allow(linkedlist)] [INFO] [stdout] | ^^^^^^^^^^ help: change it to: `clippy::linkedlist` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/attributes.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | words: words, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `words` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/attributes.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | values: values, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/attributes.rs:45:17 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn take(&mut self, key: &Q) -> Option> [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 48 | Q: Hash + Eq, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] = note: `#[warn(clippy::multiple_bound_locations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/attributes.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 86 | words: words, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `words` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/attributes.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 87 | selections: selections, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `selections` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/attributes.rs:92:22 [INFO] [stdout] | [INFO] [stdout] 92 | pub fn take_word(&mut self, key: &Q) -> bool [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 95 | Q: Hash + Eq, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/attributes.rs:101:27 [INFO] [stdout] | [INFO] [stdout] 101 | pub fn take_selection(&mut self, key: &Q) -> Option> [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 104 | Q: Hash + Eq, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/fs.rs:48:41 [INFO] [stdout] | [INFO] [stdout] 48 | return Ok(Box::new(RealHandle { root: root })); [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/import.rs:8:26 [INFO] [stdout] | [INFO] [stdout] 8 | fn import(&mut self, &RpRequiredPackage) -> Result>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &RpRequiredPackage` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(anonymous_parameters)]` (part of `#[warn(rust_2018_compatibility)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/loc.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | inner: inner, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_decl.rs:112:17 [INFO] [stdout] | [INFO] [stdout] 112 | Decls { iter: iter } [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_endpoint.rs:289:13 [INFO] [stdout] | [INFO] [stdout] 289 | request: request, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_endpoint.rs:290:13 [INFO] [stdout] | [INFO] [stdout] 290 | response: response, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `response` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_endpoint.rs:291:13 [INFO] [stdout] | [INFO] [stdout] 291 | path: path, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_endpoint.rs:292:13 [INFO] [stdout] | [INFO] [stdout] 292 | method: method, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `method` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_enum.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_enum.rs:158:13 [INFO] [stdout] | [INFO] [stdout] 158 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_enum.rs:283:29 [INFO] [stdout] | [INFO] [stdout] 283 | span: span, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `span` [INFO] [stdout] ... [INFO] [stdout] 298 | let variants: Vec<_> = variants!(self, String, Number); [INFO] [stdout] | ------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: this warning originates in the macro `variants` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_field.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | ty: ty, [INFO] [stdout] | ^^^^^^ help: replace it with: `ty` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_file.rs:52:23 [INFO] [stdout] | [INFO] [stdout] 52 | ForEachDecl { queue: queue } [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `queue` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_interface.rs:110:13 [INFO] [stdout] | [INFO] [stdout] 110 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_interface.rs:179:13 [INFO] [stdout] | [INFO] [stdout] 179 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_name.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | prefix: prefix, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `prefix` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_name.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | package: package, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `package` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_name.rs:31:13 [INFO] [stdout] | [INFO] [stdout] 31 | parts: parts, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `parts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_name.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | parts: parts, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `parts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_name.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 56 | parts: parts, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `parts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_name.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 76 | package: package, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `package` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_name.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 86 | parts: parts, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `parts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_package.rs:53:21 [INFO] [stdout] | [INFO] [stdout] 53 | RpPackage { parts: parts } [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `parts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/rp_reg.rs:19:38 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn ident( [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 28 | F: Flavor, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_required_package.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | package: package, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `package` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_required_package.rs:17:13 [INFO] [stdout] | [INFO] [stdout] 17 | range: range, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `range` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_service.rs:38:13 [INFO] [stdout] | [INFO] [stdout] 38 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_service.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | endpoints: endpoints, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `endpoints` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_tuple.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_type_model.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_versioned_package.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | package: package, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `package` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_versioned_package.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | version: version, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/attributes.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | words: words, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `words` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/attributes.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | values: values, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/attributes.rs:45:17 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn take(&mut self, key: &Q) -> Option> [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 48 | Q: Hash + Eq, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] = note: `#[warn(clippy::multiple_bound_locations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/attributes.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 86 | words: words, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `words` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/attributes.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 87 | selections: selections, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `selections` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/attributes.rs:92:22 [INFO] [stdout] | [INFO] [stdout] 92 | pub fn take_word(&mut self, key: &Q) -> bool [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 95 | Q: Hash + Eq, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/attributes.rs:101:27 [INFO] [stdout] | [INFO] [stdout] 101 | pub fn take_selection(&mut self, key: &Q) -> Option> [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 104 | Q: Hash + Eq, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/translator.rs:166:9 [INFO] [stdout] | [INFO] [stdout] 166 | ::Package, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: ::Package` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/translator.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 173 | ::Type, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: ::Type` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/translator.rs:180:9 [INFO] [stdout] | [INFO] [stdout] 180 | ::Field, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: ::Field` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/translator.rs:187:9 [INFO] [stdout] | [INFO] [stdout] 187 | ::Endpoint, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: ::Endpoint` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/fs.rs:48:41 [INFO] [stdout] | [INFO] [stdout] 48 | return Ok(Box::new(RealHandle { root: root })); [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/import.rs:8:26 [INFO] [stdout] | [INFO] [stdout] 8 | fn import(&mut self, &RpRequiredPackage) -> Result>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &RpRequiredPackage` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(anonymous_parameters)]` (part of `#[warn(rust_2018_compatibility)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/loc.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | inner: inner, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_decl.rs:112:17 [INFO] [stdout] | [INFO] [stdout] 112 | Decls { iter: iter } [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_endpoint.rs:289:13 [INFO] [stdout] | [INFO] [stdout] 289 | request: request, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_endpoint.rs:290:13 [INFO] [stdout] | [INFO] [stdout] 290 | response: response, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `response` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_endpoint.rs:291:13 [INFO] [stdout] | [INFO] [stdout] 291 | path: path, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_endpoint.rs:292:13 [INFO] [stdout] | [INFO] [stdout] 292 | method: method, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `method` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_enum.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_enum.rs:158:13 [INFO] [stdout] | [INFO] [stdout] 158 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_enum.rs:283:29 [INFO] [stdout] | [INFO] [stdout] 283 | span: span, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `span` [INFO] [stdout] ... [INFO] [stdout] 298 | let variants: Vec<_> = variants!(self, String, Number); [INFO] [stdout] | ------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: this warning originates in the macro `variants` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_field.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | ty: ty, [INFO] [stdout] | ^^^^^^ help: replace it with: `ty` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_file.rs:52:23 [INFO] [stdout] | [INFO] [stdout] 52 | ForEachDecl { queue: queue } [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `queue` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_interface.rs:110:13 [INFO] [stdout] | [INFO] [stdout] 110 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_interface.rs:179:13 [INFO] [stdout] | [INFO] [stdout] 179 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_name.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | prefix: prefix, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `prefix` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_name.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | package: package, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `package` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_name.rs:31:13 [INFO] [stdout] | [INFO] [stdout] 31 | parts: parts, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `parts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_name.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | parts: parts, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `parts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_name.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 56 | parts: parts, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `parts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_name.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 76 | package: package, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `package` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_name.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 86 | parts: parts, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `parts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_package.rs:53:21 [INFO] [stdout] | [INFO] [stdout] 53 | RpPackage { parts: parts } [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `parts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/rp_reg.rs:19:38 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn ident( [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 28 | F: Flavor, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_required_package.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | package: package, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `package` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_required_package.rs:17:13 [INFO] [stdout] | [INFO] [stdout] 17 | range: range, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `range` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_service.rs:38:13 [INFO] [stdout] | [INFO] [stdout] 38 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_service.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | endpoints: endpoints, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `endpoints` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_tuple.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_type_model.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_versioned_package.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | package: package, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `package` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rp_versioned_package.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | version: version, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/translator.rs:166:9 [INFO] [stdout] | [INFO] [stdout] 166 | ::Package, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: ::Package` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/translator.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 173 | ::Type, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: ::Type` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/translator.rs:180:9 [INFO] [stdout] | [INFO] [stdout] 180 | ::Field, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: ::Field` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/translator.rs:187:9 [INFO] [stdout] | [INFO] [stdout] 187 | ::Endpoint, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: ::Endpoint` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::atomic::ATOMIC_USIZE_INIT`: the `new` function is now preferred [INFO] [stdout] --> src/errors.rs:131:55 [INFO] [stdout] | [INFO] [stdout] 131 | static ENABLED: atomic::AtomicUsize = atomic::ATOMIC_USIZE_INIT; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] help: replace the use of the deprecated constant [INFO] [stdout] | [INFO] [stdout] 131 - static ENABLED: atomic::AtomicUsize = atomic::ATOMIC_USIZE_INIT; [INFO] [stdout] 131 + static ENABLED: atomic::AtomicUsize = atomic::AtomicUsize::new(0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/context.rs:25:24 [INFO] [stdout] | [INFO] [stdout] 25 | filesystem: Rc>, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 25 | filesystem: Rc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/fs.rs:29:60 [INFO] [stdout] | [INFO] [stdout] 29 | fn open_root(&self, root: Option<&Path>) -> Result>; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 29 | fn open_root(&self, root: Option<&Path>) -> Result>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::atomic::ATOMIC_USIZE_INIT`: the `new` function is now preferred [INFO] [stdout] --> src/errors.rs:131:55 [INFO] [stdout] | [INFO] [stdout] 131 | static ENABLED: atomic::AtomicUsize = atomic::ATOMIC_USIZE_INIT; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] help: replace the use of the deprecated constant [INFO] [stdout] | [INFO] [stdout] 131 - static ENABLED: atomic::AtomicUsize = atomic::ATOMIC_USIZE_INIT; [INFO] [stdout] 131 + static ENABLED: atomic::AtomicUsize = atomic::AtomicUsize::new(0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/fs.rs:23:57 [INFO] [stdout] | [INFO] [stdout] 23 | fn create(&self, path: &RelativePath) -> Result>; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 23 | fn create(&self, path: &RelativePath) -> Result>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/context.rs:25:24 [INFO] [stdout] | [INFO] [stdout] 25 | filesystem: Rc>, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 25 | filesystem: Rc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/fs.rs:42:60 [INFO] [stdout] | [INFO] [stdout] 42 | fn open_root(&self, root: Option<&Path>) -> Result> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 42 | fn open_root(&self, root: Option<&Path>) -> Result> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/fs.rs:68:65 [INFO] [stdout] | [INFO] [stdout] 68 | fn create(&self, path: &RelativePath) -> Result> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 68 | fn create(&self, path: &RelativePath) -> Result> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/fs.rs:104:61 [INFO] [stdout] | [INFO] [stdout] 104 | fn open_root(&self, _root: Option<&Path>) -> Result> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 104 | fn open_root(&self, _root: Option<&Path>) -> Result> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/fs.rs:129:57 [INFO] [stdout] | [INFO] [stdout] 129 | fn create(&self, path: &RelativePath) -> Result> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 129 | fn create(&self, path: &RelativePath) -> Result> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/fs.rs:29:60 [INFO] [stdout] | [INFO] [stdout] 29 | fn open_root(&self, root: Option<&Path>) -> Result>; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 29 | fn open_root(&self, root: Option<&Path>) -> Result>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/fs.rs:23:57 [INFO] [stdout] | [INFO] [stdout] 23 | fn create(&self, path: &RelativePath) -> Result>; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 23 | fn create(&self, path: &RelativePath) -> Result>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/utils.rs:16:31 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn find_line<'a, R: AsMut>( [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 16 | pub fn find_line<'a, R: AsMut>( [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/utils.rs:63:32 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn find_range<'a, R: AsMut, S: Into>( [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 63 | pub fn find_range<'a, R: AsMut, S: Into>( [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/context.rs:32:32 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn new(filesystem: Box) -> Context { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 32 | pub fn new(filesystem: Box) -> Context { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/context.rs:47:26 [INFO] [stdout] | [INFO] [stdout] 47 | F: FnOnce(Rc>) -> Box, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 47 | F: FnOnce(Rc>) -> Box, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/context.rs:47:47 [INFO] [stdout] | [INFO] [stdout] 47 | F: FnOnce(Rc>) -> Box, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 47 | F: FnOnce(Rc>) -> Box, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/context.rs:56:65 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn filesystem(&self, root: Option<&Path>) -> Result> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 56 | pub fn filesystem(&self, root: Option<&Path>) -> Result> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/fs.rs:91:37 [INFO] [stdout] | [INFO] [stdout] 91 | pub fn filesystem(&self) -> Box { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 91 | pub fn filesystem(&self) -> Box { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/fs.rs:42:60 [INFO] [stdout] | [INFO] [stdout] 42 | fn open_root(&self, root: Option<&Path>) -> Result> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 42 | fn open_root(&self, root: Option<&Path>) -> Result> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/fs.rs:68:65 [INFO] [stdout] | [INFO] [stdout] 68 | fn create(&self, path: &RelativePath) -> Result> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 68 | fn create(&self, path: &RelativePath) -> Result> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/fs.rs:104:61 [INFO] [stdout] | [INFO] [stdout] 104 | fn open_root(&self, _root: Option<&Path>) -> Result> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 104 | fn open_root(&self, _root: Option<&Path>) -> Result> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/fs.rs:129:57 [INFO] [stdout] | [INFO] [stdout] 129 | fn create(&self, path: &RelativePath) -> Result> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 129 | fn create(&self, path: &RelativePath) -> Result> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/source.rs:23:34 [INFO] [stdout] | [INFO] [stdout] 23 | fn read(&self) -> Result> { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 23 | fn read(&self) -> Result> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/source.rs:171:38 [INFO] [stdout] | [INFO] [stdout] 171 | pub fn read(&self) -> Result> { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 171 | pub fn read(&self) -> Result> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/utils.rs:16:31 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn find_line<'a, R: AsMut>( [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 16 | pub fn find_line<'a, R: AsMut>( [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/utils.rs:63:32 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn find_range<'a, R: AsMut, S: Into>( [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 63 | pub fn find_range<'a, R: AsMut, S: Into>( [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/context.rs:32:32 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn new(filesystem: Box) -> Context { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 32 | pub fn new(filesystem: Box) -> Context { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/context.rs:47:26 [INFO] [stdout] | [INFO] [stdout] 47 | F: FnOnce(Rc>) -> Box, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 47 | F: FnOnce(Rc>) -> Box, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/context.rs:47:47 [INFO] [stdout] | [INFO] [stdout] 47 | F: FnOnce(Rc>) -> Box, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 47 | F: FnOnce(Rc>) -> Box, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/context.rs:56:65 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn filesystem(&self, root: Option<&Path>) -> Result> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 56 | pub fn filesystem(&self, root: Option<&Path>) -> Result> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/fs.rs:91:37 [INFO] [stdout] | [INFO] [stdout] 91 | pub fn filesystem(&self) -> Box { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 91 | pub fn filesystem(&self) -> Box { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/source.rs:23:34 [INFO] [stdout] | [INFO] [stdout] 23 | fn read(&self) -> Result> { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 23 | fn read(&self) -> Result> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/source.rs:171:38 [INFO] [stdout] | [INFO] [stdout] 171 | pub fn read(&self) -> Result> { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 171 | pub fn read(&self) -> Result> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/source.rs:26:22 [INFO] [stdout] | [INFO] [stdout] 26 | let out: Box = match *self { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 26 | let out: Box = match *self { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/source.rs:26:22 [INFO] [stdout] | [INFO] [stdout] 26 | let out: Box = match *self { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 26 | let out: Box = match *self { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `AsLoc` is never used [INFO] [stdout] --> src/as_loc.rs:6:11 [INFO] [stdout] | [INFO] [stdout] 6 | pub trait AsLoc { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `as_*` usually take `self` by reference or `self` by mutable reference [INFO] [stdout] --> src/as_loc.rs:9:15 [INFO] [stdout] | [INFO] [stdout] 9 | fn as_loc(self) -> Loc; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `std::mem::take` [INFO] [stdout] --> src/attributes.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | mem::replace(&mut self.words, vec![]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::mem::take(&mut self.words)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] = note: `#[warn(clippy::mem_replace_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/attributes.rs:66:48 [INFO] [stdout] | [INFO] [stdout] 66 | positions.extend(self.words.iter().map(|v| Loc::span(v))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Loc::span` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/diagnostics.rs:54:38 [INFO] [stdout] | [INFO] [stdout] 54 | self.items.iter().any(|item| match *item { [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 55 | | Diagnostic::Error(_, _) => true, [INFO] [stdout] 56 | | _ => false, [INFO] [stdout] 57 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 54 - self.items.iter().any(|item| match *item { [INFO] [stdout] 55 - Diagnostic::Error(_, _) => true, [INFO] [stdout] 56 - _ => false, [INFO] [stdout] 57 - }) [INFO] [stdout] 54 + self.items.iter().any(|item| matches!(*item, Diagnostic::Error(_, _))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/errors.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 103 | / match get_var(RUST_BACKTRACE) { [INFO] [stdout] 104 | | Some(ref val) if val != "0" => true, [INFO] [stdout] 105 | | _ => false, [INFO] [stdout] 106 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 103 - match get_var(RUST_BACKTRACE) { [INFO] [stdout] 104 - Some(ref val) if val != "0" => true, [INFO] [stdout] 105 - _ => false, [INFO] [stdout] 106 - } [INFO] [stdout] 103 + matches!(get_var(RUST_BACKTRACE), Some(ref val) if val != "0") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/errors.rs:147:9 [INFO] [stdout] | [INFO] [stdout] 147 | return Some(Backtrace::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 147 - return Some(Backtrace::new()); [INFO] [stdout] 147 + Some(Backtrace::new()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `RealFilesystem` [INFO] [stdout] --> src/fs.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | / pub fn new() -> RealFilesystem { [INFO] [stdout] 37 | | Self {} [INFO] [stdout] 38 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 35 + impl Default for RealFilesystem { [INFO] [stdout] 36 + fn default() -> Self { [INFO] [stdout] 37 + Self::new() [INFO] [stdout] 38 + } [INFO] [stdout] 39 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/fs.rs:43:20 [INFO] [stdout] | [INFO] [stdout] 43 | let root = root.ok_or_else(|| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 44 | | "Missing root directory, specify using `--out`, or `output` key in manifest" [INFO] [stdout] 45 | | })? [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 43 ~ let root = root.ok_or({ [INFO] [stdout] 44 + "Missing root directory, specify using `--out`, or `output` key in manifest" [INFO] [stdout] 45 ~ })? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CapturingFilesystem` [INFO] [stdout] --> src/fs.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 84 | / pub fn new() -> CapturingFilesystem { [INFO] [stdout] 85 | | Self { [INFO] [stdout] 86 | | files: Rc::new(RefCell::new(LinkedHashMap::new())), [INFO] [stdout] 87 | | } [INFO] [stdout] 88 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 83 + impl Default for CapturingFilesystem { [INFO] [stdout] 84 + fn default() -> Self { [INFO] [stdout] 85 + Self::new() [INFO] [stdout] 86 + } [INFO] [stdout] 87 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/fs.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 105 | / return Ok(Box::new(CapturingHandle { [INFO] [stdout] 106 | | files: self.files.clone(), [INFO] [stdout] 107 | | })); [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 105 ~ Ok(Box::new(CapturingHandle { [INFO] [stdout] 106 + files: self.files.clone(), [INFO] [stdout] 107 ~ })) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `borrow` can be confused for the standard trait method `std::borrow::Borrow::borrow` [INFO] [stdout] --> src/loc.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | / pub fn borrow(loc: &Loc) -> &T { [INFO] [stdout] 44 | | &loc.inner [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::borrow::Borrow` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Span` which implements the `Copy` trait [INFO] [stdout] --> src/loc.rs:55:33 [INFO] [stdout] | [INFO] [stdout] 55 | Loc::new(op(loc.inner), loc.span.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `loc.span` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Span` which implements the `Copy` trait [INFO] [stdout] --> src/loc.rs:59:30 [INFO] [stdout] | [INFO] [stdout] 59 | Loc::new(&loc.inner, loc.span.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `loc.span` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Span` which implements the `Copy` trait [INFO] [stdout] --> src/loc.rs:67:47 [INFO] [stdout] | [INFO] [stdout] 67 | op(inner).map(|value| Loc::new(value, span.clone())) [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `span` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/loc.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | &**self [INFO] [stdout] | ^^^^^^^ help: try: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Span` which implements the `Copy` trait [INFO] [stdout] --> src/loc.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | Loc::span(value).clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `Loc::span(value)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/options.rs:15:39 [INFO] [stdout] | [INFO] [stdout] 15 | .map(|option| Loc::as_ref(&option)) [INFO] [stdout] | ^^^^^^^ help: change this to: `option` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/options.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | fn find_all_strings(&self, diag: &mut Diagnostics, name: &str) -> Result>, ()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] = note: `#[warn(clippy::result_unit_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/options.rs:27:60 [INFO] [stdout] | [INFO] [stdout] 27 | let string = value.as_string().with_span(diag, &span)?; [INFO] [stdout] | ^^^^^ help: change this to: `span` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/options.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | fn find_all_u32(&self, diag: &mut Diagnostics, name: &str) -> Result>, ()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/options.rs:39:60 [INFO] [stdout] | [INFO] [stdout] 39 | let number = value.as_number().with_span(diag, &span)?; [INFO] [stdout] | ^^^^^ help: change this to: `span` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/options.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | / fn find_all_identifiers( [INFO] [stdout] 51 | | &self, [INFO] [stdout] 52 | | diag: &mut Diagnostics, [INFO] [stdout] 53 | | name: &str, [INFO] [stdout] 54 | | ) -> Result>, ()> { [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/options.rs:59:68 [INFO] [stdout] | [INFO] [stdout] 59 | let identifier = value.as_identifier().with_span(diag, &span)?; [INFO] [stdout] | ^^^^^ help: change this to: `span` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/options.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | / fn find_one_identifier( [INFO] [stdout] 71 | | &self, [INFO] [stdout] 72 | | diag: &mut Diagnostics, [INFO] [stdout] 73 | | name: &str, [INFO] [stdout] 74 | | ) -> Result>, ()> { [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/options.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | / fn find_one_string( [INFO] [stdout] 79 | | &self, [INFO] [stdout] 80 | | diag: &mut Diagnostics, [INFO] [stdout] 81 | | name: &str, [INFO] [stdout] 82 | | ) -> Result>, ()> { [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/options.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 86 | / fn find_one_u32( [INFO] [stdout] 87 | | &self, [INFO] [stdout] 88 | | diag: &mut Diagnostics, [INFO] [stdout] 89 | | name: &str, [INFO] [stdout] 90 | | ) -> Result>, ()> { [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/rp_decl.rs:52:18 [INFO] [stdout] | [INFO] [stdout] 52 | Type(ref body) => &body.name, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 52 - Type(ref body) => &body.name, [INFO] [stdout] 52 + Type(body) => &body.name, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/rp_decl.rs:53:19 [INFO] [stdout] | [INFO] [stdout] 53 | Tuple(ref tuple) => &tuple.name, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 53 - Tuple(ref tuple) => &tuple.name, [INFO] [stdout] 53 + Tuple(tuple) => &tuple.name, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/rp_decl.rs:54:23 [INFO] [stdout] | [INFO] [stdout] 54 | Interface(ref interface) => &interface.name, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 54 - Interface(ref interface) => &interface.name, [INFO] [stdout] 54 + Interface(interface) => &interface.name, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/rp_decl.rs:55:21 [INFO] [stdout] | [INFO] [stdout] 55 | SubType(ref sub_type) => &sub_type.name, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 55 - SubType(ref sub_type) => &sub_type.name, [INFO] [stdout] 55 + SubType(sub_type) => &sub_type.name, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/rp_decl.rs:56:18 [INFO] [stdout] | [INFO] [stdout] 56 | Enum(ref en) => &en.name, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 56 - Enum(ref en) => &en.name, [INFO] [stdout] 56 + Enum(en) => &en.name, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/rp_decl.rs:58:21 [INFO] [stdout] | [INFO] [stdout] 58 | Service(ref service) => &service.name, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 58 - Service(ref service) => &service.name, [INFO] [stdout] 58 + Service(service) => &service.name, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/rp_decl.rs:67:18 [INFO] [stdout] | [INFO] [stdout] 67 | Type(ref body) => Loc::span(body), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 67 - Type(ref body) => Loc::span(body), [INFO] [stdout] 67 + Type(body) => Loc::span(body), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/rp_decl.rs:68:19 [INFO] [stdout] | [INFO] [stdout] 68 | Tuple(ref tuple) => Loc::span(tuple), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 68 - Tuple(ref tuple) => Loc::span(tuple), [INFO] [stdout] 68 + Tuple(tuple) => Loc::span(tuple), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/rp_decl.rs:69:23 [INFO] [stdout] | [INFO] [stdout] 69 | Interface(ref interface) => Loc::span(interface), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 69 - Interface(ref interface) => Loc::span(interface), [INFO] [stdout] 69 + Interface(interface) => Loc::span(interface), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/rp_decl.rs:70:21 [INFO] [stdout] | [INFO] [stdout] 70 | SubType(ref sub_type) => Loc::span(sub_type), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 70 - SubType(ref sub_type) => Loc::span(sub_type), [INFO] [stdout] 70 + SubType(sub_type) => Loc::span(sub_type), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/rp_decl.rs:71:18 [INFO] [stdout] | [INFO] [stdout] 71 | Enum(ref en) => Loc::span(en), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 71 - Enum(ref en) => Loc::span(en), [INFO] [stdout] 71 + Enum(en) => Loc::span(en), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/rp_decl.rs:73:21 [INFO] [stdout] | [INFO] [stdout] 73 | Service(ref service) => Loc::span(service), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 73 - Service(ref service) => Loc::span(service), [INFO] [stdout] 73 + Service(service) => Loc::span(service), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Span` which implements the `Copy` trait [INFO] [stdout] --> src/rp_decl.rs:296:9 [INFO] [stdout] | [INFO] [stdout] 296 | value.span().clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `value.span()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/rp_endpoint.rs:44:1 [INFO] [stdout] | [INFO] [stdout] 44 | / impl default::Default for RpAccept { [INFO] [stdout] 45 | | fn default() -> Self { [INFO] [stdout] 46 | | RpAccept::Json [INFO] [stdout] 47 | | } [INFO] [stdout] 48 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 37 + #[derive(Default)] [INFO] [stdout] 38 | pub enum RpAccept { [INFO] [stdout] 39 | #[serde(rename = "json")] [INFO] [stdout] 40 ~ #[default] [INFO] [stdout] 41 ~ Json, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|s| s.as_str())` on an `Option` value [INFO] [stdout] --> src/rp_endpoint.rs:189:9 [INFO] [stdout] | [INFO] [stdout] 189 | / self.name [INFO] [stdout] 190 | | .as_ref() [INFO] [stdout] 191 | | .map(|s| s.as_str()) [INFO] [stdout] | |________________________________^ help: consider using as_deref: `self.name.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] = note: `#[warn(clippy::option_as_ref_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|s| s.as_str())` on an `Option` value [INFO] [stdout] --> src/rp_endpoint.rs:197:9 [INFO] [stdout] | [INFO] [stdout] 197 | / self.safe_ident [INFO] [stdout] 198 | | .as_ref() [INFO] [stdout] 199 | | .map(|s| s.as_str()) [INFO] [stdout] | |________________________________^ help: consider using as_deref: `self.safe_ident.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rp_endpoint.rs:210:12 [INFO] [stdout] | [INFO] [stdout] 210 | if !self.http.path.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.http.path.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rp_endpoint.rs:288:9 [INFO] [stdout] | [INFO] [stdout] 288 | / return Some(RpEndpointHttp1 { [INFO] [stdout] 289 | | request: request, [INFO] [stdout] 290 | | response: response, [INFO] [stdout] 291 | | path: path, [INFO] [stdout] 292 | | method: method, [INFO] [stdout] 293 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 288 ~ Some(RpEndpointHttp1 { [INFO] [stdout] 289 + request: request, [INFO] [stdout] 290 + response: response, [INFO] [stdout] 291 + path: path, [INFO] [stdout] 292 + method: method, [INFO] [stdout] 293 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/rp_endpoint.rs:269:58 [INFO] [stdout] | [INFO] [stdout] 269 | let response_ty = endpoint.response.as_ref().map(|r| Loc::borrow(r)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Loc::borrow` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a struct pattern where every field's pattern takes a reference [INFO] [stdout] --> src/rp_endpoint.rs:272:19 [INFO] [stdout] | [INFO] [stdout] 272 | (Some(&Unary { ty: ref request }), Some(&Unary { ty: ref response })) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] = note: `#[warn(clippy::needless_borrowed_reference)]` on by default [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 272 - (Some(&Unary { ty: ref request }), Some(&Unary { ty: ref response })) => { [INFO] [stdout] 272 + (Some(Unary { ty: request }), Some(&Unary { ty: ref response })) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a struct pattern where every field's pattern takes a reference [INFO] [stdout] --> src/rp_endpoint.rs:272:53 [INFO] [stdout] | [INFO] [stdout] 272 | (Some(&Unary { ty: ref request }), Some(&Unary { ty: ref response })) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 272 - (Some(&Unary { ty: ref request }), Some(&Unary { ty: ref response })) => { [INFO] [stdout] 272 + (Some(&Unary { ty: ref request }), Some(Unary { ty: response })) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a struct pattern where every field's pattern takes a reference [INFO] [stdout] --> src/rp_endpoint.rs:275:25 [INFO] [stdout] | [INFO] [stdout] 275 | (None, Some(&Unary { ty: ref response })) => (None, Some(response.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 275 - (None, Some(&Unary { ty: ref response })) => (None, Some(response.clone())), [INFO] [stdout] 275 + (None, Some(Unary { ty: response })) => (None, Some(response.clone())), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a struct pattern where every field's pattern takes a reference [INFO] [stdout] --> src/rp_endpoint.rs:276:19 [INFO] [stdout] | [INFO] [stdout] 276 | (Some(&Unary { ty: ref request }), None) => (Some(request.clone()), None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 276 - (Some(&Unary { ty: ref request }), None) => (Some(request.clone()), None), [INFO] [stdout] 276 + (Some(Unary { ty: request }), None) => (Some(request.clone()), None), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/rp_enum.rs:122:6 [INFO] [stdout] | [INFO] [stdout] 122 | impl<'a, F: 'static, V> RpVariant [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/rp_enum.rs:180:9 [INFO] [stdout] | [INFO] [stdout] 180 | / match (self, value) { [INFO] [stdout] 181 | | (&String, &RpValue::String(_)) => true, [INFO] [stdout] 182 | | (&U32, &RpValue::Number(_)) => true, [INFO] [stdout] 183 | | (&U64, &RpValue::Number(_)) => true, [INFO] [stdout] ... | [INFO] [stdout] 186 | | _ => false, [INFO] [stdout] 187 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 180 - match (self, value) { [INFO] [stdout] 181 - (&String, &RpValue::String(_)) => true, [INFO] [stdout] 182 - (&U32, &RpValue::Number(_)) => true, [INFO] [stdout] 183 - (&U64, &RpValue::Number(_)) => true, [INFO] [stdout] 184 - (&I32, &RpValue::Number(_)) => true, [INFO] [stdout] 185 - (&I64, &RpValue::Number(_)) => true, [INFO] [stdout] 186 - _ => false, [INFO] [stdout] 187 - } [INFO] [stdout] 180 + matches!((self, value), (&String, &RpValue::String(_)) | (&U32, &RpValue::Number(_)) | (&U64, &RpValue::Number(_)) | (&I32, &RpValue::Number(_)) | (&I64, &RpValue::Number(_))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rp_enum.rs:213:9 [INFO] [stdout] | [INFO] [stdout] 213 | return Err(format!("number is not within {} to {} (inclusive)", mn, mx).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 213 - return Err(format!("number is not within {} to {} (inclusive)", mn, mx).into()); [INFO] [stdout] 213 + Err(format!("number is not within {} to {} (inclusive)", mn, mx).into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/rp_enum.rs:200:34 [INFO] [stdout] | [INFO] [stdout] 200 | U32 => (0u32.into(), i32::max_value().into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 200 - U32 => (0u32.into(), i32::max_value().into()), [INFO] [stdout] 200 + U32 => (0u32.into(), i32::MAX.into()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/rp_enum.rs:202:21 [INFO] [stdout] | [INFO] [stdout] 202 | I32 => (i32::min_value().into(), i32::max_value().into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 202 - I32 => (i32::min_value().into(), i32::max_value().into()), [INFO] [stdout] 202 + I32 => (i32::MIN.into(), i32::max_value().into()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/rp_enum.rs:202:46 [INFO] [stdout] | [INFO] [stdout] 202 | I32 => (i32::min_value().into(), i32::max_value().into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 202 - I32 => (i32::min_value().into(), i32::max_value().into()), [INFO] [stdout] 202 + I32 => (i32::min_value().into(), i32::MAX.into()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/rp_enum.rs:206:17 [INFO] [stdout] | [INFO] [stdout] 206 | let n = number.to_bigint().ok_or_else(|| "not a whole number")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 206 - let n = number.to_bigint().ok_or_else(|| "not a whole number")?; [INFO] [stdout] 206 + let n = number.to_bigint().ok_or("not a whole number")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `AsLoc` is never used [INFO] [stdout] --> src/as_loc.rs:6:11 [INFO] [stdout] | [INFO] [stdout] 6 | pub trait AsLoc { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `as_*` usually take `self` by reference or `self` by mutable reference [INFO] [stdout] --> src/as_loc.rs:9:15 [INFO] [stdout] | [INFO] [stdout] 9 | fn as_loc(self) -> Loc; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `std::mem::take` [INFO] [stdout] --> src/attributes.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | mem::replace(&mut self.words, vec![]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::mem::take(&mut self.words)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] = note: `#[warn(clippy::mem_replace_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/attributes.rs:66:48 [INFO] [stdout] | [INFO] [stdout] 66 | positions.extend(self.words.iter().map(|v| Loc::span(v))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Loc::span` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `RpPackage` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/rp_package.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/diagnostics.rs:54:38 [INFO] [stdout] | [INFO] [stdout] 54 | self.items.iter().any(|item| match *item { [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 55 | | Diagnostic::Error(_, _) => true, [INFO] [stdout] 56 | | _ => false, [INFO] [stdout] 57 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 54 - self.items.iter().any(|item| match *item { [INFO] [stdout] 55 - Diagnostic::Error(_, _) => true, [INFO] [stdout] 56 - _ => false, [INFO] [stdout] 57 - }) [INFO] [stdout] 54 + self.items.iter().any(|item| matches!(*item, Diagnostic::Error(_, _))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/errors.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 103 | / match get_var(RUST_BACKTRACE) { [INFO] [stdout] 104 | | Some(ref val) if val != "0" => true, [INFO] [stdout] 105 | | _ => false, [INFO] [stdout] 106 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 103 - match get_var(RUST_BACKTRACE) { [INFO] [stdout] 104 - Some(ref val) if val != "0" => true, [INFO] [stdout] 105 - _ => false, [INFO] [stdout] 106 - } [INFO] [stdout] 103 + matches!(get_var(RUST_BACKTRACE), Some(ref val) if val != "0") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/errors.rs:147:9 [INFO] [stdout] | [INFO] [stdout] 147 | return Some(Backtrace::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 147 - return Some(Backtrace::new()); [INFO] [stdout] 147 + Some(Backtrace::new()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/rp_reg.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | / match *self { [INFO] [stdout] 55 | | Enum => true, [INFO] [stdout] 56 | | _ => false, [INFO] [stdout] 57 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 54 - match *self { [INFO] [stdout] 55 - Enum => true, [INFO] [stdout] 56 - _ => false, [INFO] [stdout] 57 - } [INFO] [stdout] 54 + matches!(*self, Enum) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `RealFilesystem` [INFO] [stdout] --> src/fs.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | / pub fn new() -> RealFilesystem { [INFO] [stdout] 37 | | Self {} [INFO] [stdout] 38 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 35 + impl Default for RealFilesystem { [INFO] [stdout] 36 + fn default() -> Self { [INFO] [stdout] 37 + Self::new() [INFO] [stdout] 38 + } [INFO] [stdout] 39 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/fs.rs:43:20 [INFO] [stdout] | [INFO] [stdout] 43 | let root = root.ok_or_else(|| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 44 | | "Missing root directory, specify using `--out`, or `output` key in manifest" [INFO] [stdout] 45 | | })? [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 43 ~ let root = root.ok_or({ [INFO] [stdout] 44 + "Missing root directory, specify using `--out`, or `output` key in manifest" [INFO] [stdout] 45 ~ })? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CapturingFilesystem` [INFO] [stdout] --> src/fs.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 84 | / pub fn new() -> CapturingFilesystem { [INFO] [stdout] 85 | | Self { [INFO] [stdout] 86 | | files: Rc::new(RefCell::new(LinkedHashMap::new())), [INFO] [stdout] 87 | | } [INFO] [stdout] 88 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 83 + impl Default for CapturingFilesystem { [INFO] [stdout] 84 + fn default() -> Self { [INFO] [stdout] 85 + Self::new() [INFO] [stdout] 86 + } [INFO] [stdout] 87 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/fs.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 105 | / return Ok(Box::new(CapturingHandle { [INFO] [stdout] 106 | | files: self.files.clone(), [INFO] [stdout] 107 | | })); [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 105 ~ Ok(Box::new(CapturingHandle { [INFO] [stdout] 106 + files: self.files.clone(), [INFO] [stdout] 107 ~ })) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::SplitN<'_, char>` [INFO] [stdout] --> src/rp_required_package.rs:23:22 [INFO] [stdout] | [INFO] [stdout] 23 | let mut it = input.splitn(2, '@').into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `input.splitn(2, '@')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `borrow` can be confused for the standard trait method `std::borrow::Borrow::borrow` [INFO] [stdout] --> src/loc.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | / pub fn borrow(loc: &Loc) -> &T { [INFO] [stdout] 44 | | &loc.inner [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::borrow::Borrow` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Span` which implements the `Copy` trait [INFO] [stdout] --> src/loc.rs:55:33 [INFO] [stdout] | [INFO] [stdout] 55 | Loc::new(op(loc.inner), loc.span.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `loc.span` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Span` which implements the `Copy` trait [INFO] [stdout] --> src/loc.rs:59:30 [INFO] [stdout] | [INFO] [stdout] 59 | Loc::new(&loc.inner, loc.span.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `loc.span` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Span` which implements the `Copy` trait [INFO] [stdout] --> src/loc.rs:67:47 [INFO] [stdout] | [INFO] [stdout] 67 | op(inner).map(|value| Loc::new(value, span.clone())) [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `span` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/loc.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | &**self [INFO] [stdout] | ^^^^^^^ help: try: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Span` which implements the `Copy` trait [INFO] [stdout] --> src/loc.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | Loc::span(value).clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `Loc::span(value)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/options.rs:15:39 [INFO] [stdout] | [INFO] [stdout] 15 | .map(|option| Loc::as_ref(&option)) [INFO] [stdout] | ^^^^^^^ help: change this to: `option` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/options.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | fn find_all_strings(&self, diag: &mut Diagnostics, name: &str) -> Result>, ()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] = note: `#[warn(clippy::result_unit_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/options.rs:27:60 [INFO] [stdout] | [INFO] [stdout] 27 | let string = value.as_string().with_span(diag, &span)?; [INFO] [stdout] | ^^^^^ help: change this to: `span` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/options.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | fn find_all_u32(&self, diag: &mut Diagnostics, name: &str) -> Result>, ()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/options.rs:39:60 [INFO] [stdout] | [INFO] [stdout] 39 | let number = value.as_number().with_span(diag, &span)?; [INFO] [stdout] | ^^^^^ help: change this to: `span` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/options.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | / fn find_all_identifiers( [INFO] [stdout] 51 | | &self, [INFO] [stdout] 52 | | diag: &mut Diagnostics, [INFO] [stdout] 53 | | name: &str, [INFO] [stdout] 54 | | ) -> Result>, ()> { [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/options.rs:59:68 [INFO] [stdout] | [INFO] [stdout] 59 | let identifier = value.as_identifier().with_span(diag, &span)?; [INFO] [stdout] | ^^^^^ help: change this to: `span` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/options.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | / fn find_one_identifier( [INFO] [stdout] 71 | | &self, [INFO] [stdout] 72 | | diag: &mut Diagnostics, [INFO] [stdout] 73 | | name: &str, [INFO] [stdout] 74 | | ) -> Result>, ()> { [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/options.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | / fn find_one_string( [INFO] [stdout] 79 | | &self, [INFO] [stdout] 80 | | diag: &mut Diagnostics, [INFO] [stdout] 81 | | name: &str, [INFO] [stdout] 82 | | ) -> Result>, ()> { [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/options.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 86 | / fn find_one_u32( [INFO] [stdout] 87 | | &self, [INFO] [stdout] 88 | | diag: &mut Diagnostics, [INFO] [stdout] 89 | | name: &str, [INFO] [stdout] 90 | | ) -> Result>, ()> { [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/rp_decl.rs:52:18 [INFO] [stdout] | [INFO] [stdout] 52 | Type(ref body) => &body.name, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 52 - Type(ref body) => &body.name, [INFO] [stdout] 52 + Type(body) => &body.name, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/rp_decl.rs:53:19 [INFO] [stdout] | [INFO] [stdout] 53 | Tuple(ref tuple) => &tuple.name, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 53 - Tuple(ref tuple) => &tuple.name, [INFO] [stdout] 53 + Tuple(tuple) => &tuple.name, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/rp_decl.rs:54:23 [INFO] [stdout] | [INFO] [stdout] 54 | Interface(ref interface) => &interface.name, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 54 - Interface(ref interface) => &interface.name, [INFO] [stdout] 54 + Interface(interface) => &interface.name, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/rp_decl.rs:55:21 [INFO] [stdout] | [INFO] [stdout] 55 | SubType(ref sub_type) => &sub_type.name, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 55 - SubType(ref sub_type) => &sub_type.name, [INFO] [stdout] 55 + SubType(sub_type) => &sub_type.name, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/rp_decl.rs:56:18 [INFO] [stdout] | [INFO] [stdout] 56 | Enum(ref en) => &en.name, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 56 - Enum(ref en) => &en.name, [INFO] [stdout] 56 + Enum(en) => &en.name, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/rp_decl.rs:58:21 [INFO] [stdout] | [INFO] [stdout] 58 | Service(ref service) => &service.name, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 58 - Service(ref service) => &service.name, [INFO] [stdout] 58 + Service(service) => &service.name, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/rp_decl.rs:67:18 [INFO] [stdout] | [INFO] [stdout] 67 | Type(ref body) => Loc::span(body), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 67 - Type(ref body) => Loc::span(body), [INFO] [stdout] 67 + Type(body) => Loc::span(body), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/rp_decl.rs:68:19 [INFO] [stdout] | [INFO] [stdout] 68 | Tuple(ref tuple) => Loc::span(tuple), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 68 - Tuple(ref tuple) => Loc::span(tuple), [INFO] [stdout] 68 + Tuple(tuple) => Loc::span(tuple), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/rp_decl.rs:69:23 [INFO] [stdout] | [INFO] [stdout] 69 | Interface(ref interface) => Loc::span(interface), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 69 - Interface(ref interface) => Loc::span(interface), [INFO] [stdout] 69 + Interface(interface) => Loc::span(interface), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/rp_decl.rs:70:21 [INFO] [stdout] | [INFO] [stdout] 70 | SubType(ref sub_type) => Loc::span(sub_type), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 70 - SubType(ref sub_type) => Loc::span(sub_type), [INFO] [stdout] 70 + SubType(sub_type) => Loc::span(sub_type), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/rp_decl.rs:71:18 [INFO] [stdout] | [INFO] [stdout] 71 | Enum(ref en) => Loc::span(en), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 71 - Enum(ref en) => Loc::span(en), [INFO] [stdout] 71 + Enum(en) => Loc::span(en), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/rp_decl.rs:73:21 [INFO] [stdout] | [INFO] [stdout] 73 | Service(ref service) => Loc::span(service), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 73 - Service(ref service) => Loc::span(service), [INFO] [stdout] 73 + Service(service) => Loc::span(service), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/rp_value.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | / match *self { [INFO] [stdout] 80 | | String(_) => true, [INFO] [stdout] 81 | | _ => false, [INFO] [stdout] 82 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 79 - match *self { [INFO] [stdout] 80 - String(_) => true, [INFO] [stdout] 81 - _ => false, [INFO] [stdout] 82 - } [INFO] [stdout] 79 + matches!(*self, String(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/source.rs:28:75 [INFO] [stdout] | [INFO] [stdout] 28 | Bytes(ref bytes) => Box::new(Cursor::new(ArcCursor(Arc::clone(&bytes)))), [INFO] [stdout] | ^^^^^^ help: change this to: `bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Span` which implements the `Copy` trait [INFO] [stdout] --> src/rp_decl.rs:296:9 [INFO] [stdout] | [INFO] [stdout] 296 | value.span().clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `value.span()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/rp_endpoint.rs:44:1 [INFO] [stdout] | [INFO] [stdout] 44 | / impl default::Default for RpAccept { [INFO] [stdout] 45 | | fn default() -> Self { [INFO] [stdout] 46 | | RpAccept::Json [INFO] [stdout] 47 | | } [INFO] [stdout] 48 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 37 + #[derive(Default)] [INFO] [stdout] 38 | pub enum RpAccept { [INFO] [stdout] 39 | #[serde(rename = "json")] [INFO] [stdout] 40 ~ #[default] [INFO] [stdout] 41 ~ Json, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/source.rs:143:13 [INFO] [stdout] | [INFO] [stdout] 143 | / match Url::from_file_path(path) { [INFO] [stdout] 144 | | Ok(url) => return Some(url), [INFO] [stdout] 145 | | Err(_) => {} [INFO] [stdout] 146 | | } [INFO] [stdout] | |_____________^ help: try: `if let Ok(url) = Url::from_file_path(path) { return Some(url) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|s| s.as_str())` on an `Option` value [INFO] [stdout] --> src/rp_endpoint.rs:189:9 [INFO] [stdout] | [INFO] [stdout] 189 | / self.name [INFO] [stdout] 190 | | .as_ref() [INFO] [stdout] 191 | | .map(|s| s.as_str()) [INFO] [stdout] | |________________________________^ help: consider using as_deref: `self.name.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] = note: `#[warn(clippy::option_as_ref_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|s| s.as_str())` on an `Option` value [INFO] [stdout] --> src/rp_endpoint.rs:197:9 [INFO] [stdout] | [INFO] [stdout] 197 | / self.safe_ident [INFO] [stdout] 198 | | .as_ref() [INFO] [stdout] 199 | | .map(|s| s.as_str()) [INFO] [stdout] | |________________________________^ help: consider using as_deref: `self.safe_ident.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rp_endpoint.rs:210:12 [INFO] [stdout] | [INFO] [stdout] 210 | if !self.http.path.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.http.path.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/translator.rs:327:9 [INFO] [stdout] | [INFO] [stdout] 327 | return Ok(reg.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 327 - return Ok(reg.clone()); [INFO] [stdout] 327 + Ok(reg.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/translator.rs:310:21 [INFO] [stdout] | [INFO] [stdout] 310 | let decls = self.decls.as_ref().ok_or_else(|| "no declarations")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 310 - let decls = self.decls.as_ref().ok_or_else(|| "no declarations")?; [INFO] [stdout] 310 + let decls = self.decls.as_ref().ok_or("no declarations")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/translator.rs:313:9 [INFO] [stdout] | [INFO] [stdout] 313 | / match decls.get(&key) { [INFO] [stdout] 314 | | Some(reg) => return Ok(reg.clone()), [INFO] [stdout] 315 | | None => {} [INFO] [stdout] 316 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(reg) = decls.get(&key) { return Ok(reg.clone()) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rp_endpoint.rs:288:9 [INFO] [stdout] | [INFO] [stdout] 288 | / return Some(RpEndpointHttp1 { [INFO] [stdout] 289 | | request: request, [INFO] [stdout] 290 | | response: response, [INFO] [stdout] 291 | | path: path, [INFO] [stdout] 292 | | method: method, [INFO] [stdout] 293 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 288 ~ Some(RpEndpointHttp1 { [INFO] [stdout] 289 + request: request, [INFO] [stdout] 290 + response: response, [INFO] [stdout] 291 + path: path, [INFO] [stdout] 292 + method: method, [INFO] [stdout] 293 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/rp_endpoint.rs:269:58 [INFO] [stdout] | [INFO] [stdout] 269 | let response_ty = endpoint.response.as_ref().map(|r| Loc::borrow(r)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Loc::borrow` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a struct pattern where every field's pattern takes a reference [INFO] [stdout] --> src/rp_endpoint.rs:272:19 [INFO] [stdout] | [INFO] [stdout] 272 | (Some(&Unary { ty: ref request }), Some(&Unary { ty: ref response })) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] = note: `#[warn(clippy::needless_borrowed_reference)]` on by default [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 272 - (Some(&Unary { ty: ref request }), Some(&Unary { ty: ref response })) => { [INFO] [stdout] 272 + (Some(Unary { ty: request }), Some(&Unary { ty: ref response })) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a struct pattern where every field's pattern takes a reference [INFO] [stdout] --> src/rp_endpoint.rs:272:53 [INFO] [stdout] | [INFO] [stdout] 272 | (Some(&Unary { ty: ref request }), Some(&Unary { ty: ref response })) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 272 - (Some(&Unary { ty: ref request }), Some(&Unary { ty: ref response })) => { [INFO] [stdout] 272 + (Some(&Unary { ty: ref request }), Some(Unary { ty: response })) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a struct pattern where every field's pattern takes a reference [INFO] [stdout] --> src/rp_endpoint.rs:275:25 [INFO] [stdout] | [INFO] [stdout] 275 | (None, Some(&Unary { ty: ref response })) => (None, Some(response.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 275 - (None, Some(&Unary { ty: ref response })) => (None, Some(response.clone())), [INFO] [stdout] 275 + (None, Some(Unary { ty: response })) => (None, Some(response.clone())), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a struct pattern where every field's pattern takes a reference [INFO] [stdout] --> src/rp_endpoint.rs:276:19 [INFO] [stdout] | [INFO] [stdout] 276 | (Some(&Unary { ty: ref request }), None) => (Some(request.clone()), None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 276 - (Some(&Unary { ty: ref request }), None) => (Some(request.clone()), None), [INFO] [stdout] 276 + (Some(Unary { ty: request }), None) => (Some(request.clone()), None), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/utils.rs:5:16 [INFO] [stdout] | [INFO] [stdout] 5 | const NL: u8 = '\n' as u8; [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\n'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/utils.rs:6:16 [INFO] [stdout] | [INFO] [stdout] 6 | const CR: u8 = '\r' as u8; [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\r'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling .bytes() is very inefficient when data is not in memory [INFO] [stdout] --> src/utils.rs:29:18 [INFO] [stdout] | [INFO] [stdout] 29 | let mut it = r.bytes().peekable(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `BufReader` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unbuffered_bytes [INFO] [stdout] = note: `#[warn(clippy::unbuffered_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/utils.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | while let Some(b) = it.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for b in it` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling .bytes() is very inefficient when data is not in memory [INFO] [stdout] --> src/utils.rs:80:18 [INFO] [stdout] | [INFO] [stdout] 80 | let mut it = r.bytes().enumerate().peekable(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `BufReader` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unbuffered_bytes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/rp_enum.rs:122:6 [INFO] [stdout] | [INFO] [stdout] 122 | impl<'a, F: 'static, V> RpVariant [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/with_span.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | fn with_span>(self, diag: &mut Diagnostics, span: S) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/rp_enum.rs:180:9 [INFO] [stdout] | [INFO] [stdout] 180 | / match (self, value) { [INFO] [stdout] 181 | | (&String, &RpValue::String(_)) => true, [INFO] [stdout] 182 | | (&U32, &RpValue::Number(_)) => true, [INFO] [stdout] 183 | | (&U64, &RpValue::Number(_)) => true, [INFO] [stdout] ... | [INFO] [stdout] 186 | | _ => false, [INFO] [stdout] 187 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 180 - match (self, value) { [INFO] [stdout] 181 - (&String, &RpValue::String(_)) => true, [INFO] [stdout] 182 - (&U32, &RpValue::Number(_)) => true, [INFO] [stdout] 183 - (&U64, &RpValue::Number(_)) => true, [INFO] [stdout] 184 - (&I32, &RpValue::Number(_)) => true, [INFO] [stdout] 185 - (&I64, &RpValue::Number(_)) => true, [INFO] [stdout] 186 - _ => false, [INFO] [stdout] 187 - } [INFO] [stdout] 180 + matches!((self, value), (&String, &RpValue::String(_)) | (&U32, &RpValue::Number(_)) | (&U64, &RpValue::Number(_)) | (&I32, &RpValue::Number(_)) | (&I64, &RpValue::Number(_))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/context.rs:71:18 [INFO] [stdout] | [INFO] [stdout] 71 | pub fn items(&self) -> result::Result>, BorrowError> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 71 | pub fn items(&self) -> result::Result>, BorrowError> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/diagnostics.rs:82:18 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn items(&self) -> Items { [INFO] [stdout] | ^^^^^ ^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 82 | pub fn items(&self) -> Items<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rp_enum.rs:213:9 [INFO] [stdout] | [INFO] [stdout] 213 | return Err(format!("number is not within {} to {} (inclusive)", mn, mx).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 213 - return Err(format!("number is not within {} to {} (inclusive)", mn, mx).into()); [INFO] [stdout] 213 + Err(format!("number is not within {} to {} (inclusive)", mn, mx).into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/errors.rs:161:20 [INFO] [stdout] | [INFO] [stdout] 161 | pub fn display(&self) -> Display { [INFO] [stdout] | ^^^^^ ^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 161 | pub fn display(&self) -> Display<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/rp_enum.rs:200:34 [INFO] [stdout] | [INFO] [stdout] 200 | U32 => (0u32.into(), i32::max_value().into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 200 - U32 => (0u32.into(), i32::max_value().into()), [INFO] [stdout] 200 + U32 => (0u32.into(), i32::MAX.into()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/errors.rs:188:19 [INFO] [stdout] | [INFO] [stdout] 188 | pub fn causes(&self) -> Causes { [INFO] [stdout] | ^^^^^ ^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 188 | pub fn causes(&self) -> Causes<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/rp_enum.rs:202:21 [INFO] [stdout] | [INFO] [stdout] 202 | I32 => (i32::min_value().into(), i32::max_value().into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 202 - I32 => (i32::min_value().into(), i32::max_value().into()), [INFO] [stdout] 202 + I32 => (i32::MIN.into(), i32::max_value().into()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/rp_enum.rs:202:46 [INFO] [stdout] | [INFO] [stdout] 202 | I32 => (i32::min_value().into(), i32::max_value().into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 202 - I32 => (i32::min_value().into(), i32::max_value().into()), [INFO] [stdout] 202 + I32 => (i32::min_value().into(), i32::MAX.into()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/rp_enum.rs:206:17 [INFO] [stdout] | [INFO] [stdout] 206 | let n = number.to_bigint().ok_or_else(|| "not a whole number")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 206 - let n = number.to_bigint().ok_or_else(|| "not a whole number")?; [INFO] [stdout] 206 + let n = number.to_bigint().ok_or("not a whole number")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/rp_decl.rs:97:18 [INFO] [stdout] | [INFO] [stdout] 97 | pub fn decls(&self) -> Decls { [INFO] [stdout] | ^^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 97 | pub fn decls(&self) -> Decls<'_, F> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/rp_decl.rs:188:21 [INFO] [stdout] | [INFO] [stdout] 188 | pub fn to_named(&self) -> Vec> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 188 | pub fn to_named(&self) -> Vec> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/rp_enum.rs:269:17 [INFO] [stdout] | [INFO] [stdout] 269 | pub fn iter(&self) -> RpVariantsIter { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 269 | pub fn iter(&self) -> RpVariantsIter<'_, F> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/rp_file.rs:49:26 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn for_each_decl(&self) -> ForEachDecl { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 49 | pub fn for_each_decl(&self) -> ForEachDecl<'_, F> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/rp_interface.rs:84:19 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn fields(&self) -> Fields { [INFO] [stdout] | ^^^^^ ^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 84 | pub fn fields(&self) -> Fields<'_, F> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/rp_interface.rs:152:34 [INFO] [stdout] | [INFO] [stdout] 152 | pub fn discriminating_fields(&self) -> DiscriminatingFields { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 152 | pub fn discriminating_fields(&self) -> DiscriminatingFields<'_, F> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/rp_package.rs:121:17 [INFO] [stdout] | [INFO] [stdout] 121 | mem::replace(p, keyword.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 121 | let _ = mem::replace(p, keyword.to_string()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/rp_package.rs:135:13 [INFO] [stdout] | [INFO] [stdout] 135 | mem::replace(p, new_name); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 135 | let _ = mem::replace(p, new_name); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/rp_package.rs:142:18 [INFO] [stdout] | [INFO] [stdout] 142 | pub fn parts(&self) -> Parts { [INFO] [stdout] | ^^^^^ ^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 142 | pub fn parts(&self) -> Parts<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/rp_path_spec.rs:100:17 [INFO] [stdout] | [INFO] [stdout] 100 | pub fn vars(&self) -> Vars { [INFO] [stdout] | ^^^^^ ^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 100 | pub fn vars(&self) -> Vars<'_, F> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/rp_tuple.rs:36:19 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn fields(&self) -> Fields { [INFO] [stdout] | ^^^^^ ^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 36 | pub fn fields(&self) -> Fields<'_, F> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/rp_type_model.rs:36:19 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn fields(&self) -> Fields { [INFO] [stdout] | ^^^^^ ^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 36 | pub fn fields(&self) -> Fields<'_, F> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `RpPackage` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/rp_package.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/rp_reg.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | / match *self { [INFO] [stdout] 55 | | Enum => true, [INFO] [stdout] 56 | | _ => false, [INFO] [stdout] 57 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 54 - match *self { [INFO] [stdout] 55 - Enum => true, [INFO] [stdout] 56 - _ => false, [INFO] [stdout] 57 - } [INFO] [stdout] 54 + matches!(*self, Enum) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::SplitN<'_, char>` [INFO] [stdout] --> src/rp_required_package.rs:23:22 [INFO] [stdout] | [INFO] [stdout] 23 | let mut it = input.splitn(2, '@').into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `input.splitn(2, '@')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/rp_value.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | / match *self { [INFO] [stdout] 80 | | String(_) => true, [INFO] [stdout] 81 | | _ => false, [INFO] [stdout] 82 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 79 - match *self { [INFO] [stdout] 80 - String(_) => true, [INFO] [stdout] 81 - _ => false, [INFO] [stdout] 82 - } [INFO] [stdout] 79 + matches!(*self, String(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/source.rs:28:75 [INFO] [stdout] | [INFO] [stdout] 28 | Bytes(ref bytes) => Box::new(Cursor::new(ArcCursor(Arc::clone(&bytes)))), [INFO] [stdout] | ^^^^^^ help: change this to: `bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/source.rs:143:13 [INFO] [stdout] | [INFO] [stdout] 143 | / match Url::from_file_path(path) { [INFO] [stdout] 144 | | Ok(url) => return Some(url), [INFO] [stdout] 145 | | Err(_) => {} [INFO] [stdout] 146 | | } [INFO] [stdout] | |_____________^ help: try: `if let Ok(url) = Url::from_file_path(path) { return Some(url) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/translator.rs:327:9 [INFO] [stdout] | [INFO] [stdout] 327 | return Ok(reg.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 327 - return Ok(reg.clone()); [INFO] [stdout] 327 + Ok(reg.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/translator.rs:310:21 [INFO] [stdout] | [INFO] [stdout] 310 | let decls = self.decls.as_ref().ok_or_else(|| "no declarations")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 310 - let decls = self.decls.as_ref().ok_or_else(|| "no declarations")?; [INFO] [stdout] 310 + let decls = self.decls.as_ref().ok_or("no declarations")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/translator.rs:313:9 [INFO] [stdout] | [INFO] [stdout] 313 | / match decls.get(&key) { [INFO] [stdout] 314 | | Some(reg) => return Ok(reg.clone()), [INFO] [stdout] 315 | | None => {} [INFO] [stdout] 316 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(reg) = decls.get(&key) { return Ok(reg.clone()) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/utils.rs:5:16 [INFO] [stdout] | [INFO] [stdout] 5 | const NL: u8 = '\n' as u8; [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\n'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/utils.rs:6:16 [INFO] [stdout] | [INFO] [stdout] 6 | const CR: u8 = '\r' as u8; [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\r'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling .bytes() is very inefficient when data is not in memory [INFO] [stdout] --> src/utils.rs:29:18 [INFO] [stdout] | [INFO] [stdout] 29 | let mut it = r.bytes().peekable(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `BufReader` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unbuffered_bytes [INFO] [stdout] = note: `#[warn(clippy::unbuffered_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/utils.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | while let Some(b) = it.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for b in it` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling .bytes() is very inefficient when data is not in memory [INFO] [stdout] --> src/utils.rs:80:18 [INFO] [stdout] | [INFO] [stdout] 80 | let mut it = r.bytes().enumerate().peekable(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `BufReader` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unbuffered_bytes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/with_span.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | fn with_span>(self, diag: &mut Diagnostics, span: S) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/context.rs:71:18 [INFO] [stdout] | [INFO] [stdout] 71 | pub fn items(&self) -> result::Result>, BorrowError> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 71 | pub fn items(&self) -> result::Result>, BorrowError> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/diagnostics.rs:82:18 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn items(&self) -> Items { [INFO] [stdout] | ^^^^^ ^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 82 | pub fn items(&self) -> Items<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/errors.rs:161:20 [INFO] [stdout] | [INFO] [stdout] 161 | pub fn display(&self) -> Display { [INFO] [stdout] | ^^^^^ ^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 161 | pub fn display(&self) -> Display<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/errors.rs:188:19 [INFO] [stdout] | [INFO] [stdout] 188 | pub fn causes(&self) -> Causes { [INFO] [stdout] | ^^^^^ ^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 188 | pub fn causes(&self) -> Causes<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/rp_decl.rs:97:18 [INFO] [stdout] | [INFO] [stdout] 97 | pub fn decls(&self) -> Decls { [INFO] [stdout] | ^^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 97 | pub fn decls(&self) -> Decls<'_, F> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/rp_decl.rs:188:21 [INFO] [stdout] | [INFO] [stdout] 188 | pub fn to_named(&self) -> Vec> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 188 | pub fn to_named(&self) -> Vec> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/rp_enum.rs:269:17 [INFO] [stdout] | [INFO] [stdout] 269 | pub fn iter(&self) -> RpVariantsIter { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 269 | pub fn iter(&self) -> RpVariantsIter<'_, F> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/rp_file.rs:49:26 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn for_each_decl(&self) -> ForEachDecl { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 49 | pub fn for_each_decl(&self) -> ForEachDecl<'_, F> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/rp_interface.rs:84:19 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn fields(&self) -> Fields { [INFO] [stdout] | ^^^^^ ^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 84 | pub fn fields(&self) -> Fields<'_, F> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/rp_interface.rs:152:34 [INFO] [stdout] | [INFO] [stdout] 152 | pub fn discriminating_fields(&self) -> DiscriminatingFields { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 152 | pub fn discriminating_fields(&self) -> DiscriminatingFields<'_, F> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/rp_package.rs:121:17 [INFO] [stdout] | [INFO] [stdout] 121 | mem::replace(p, keyword.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 121 | let _ = mem::replace(p, keyword.to_string()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/rp_package.rs:135:13 [INFO] [stdout] | [INFO] [stdout] 135 | mem::replace(p, new_name); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 135 | let _ = mem::replace(p, new_name); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/rp_package.rs:142:18 [INFO] [stdout] | [INFO] [stdout] 142 | pub fn parts(&self) -> Parts { [INFO] [stdout] | ^^^^^ ^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 142 | pub fn parts(&self) -> Parts<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/rp_path_spec.rs:100:17 [INFO] [stdout] | [INFO] [stdout] 100 | pub fn vars(&self) -> Vars { [INFO] [stdout] | ^^^^^ ^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 100 | pub fn vars(&self) -> Vars<'_, F> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/rp_tuple.rs:36:19 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn fields(&self) -> Fields { [INFO] [stdout] | ^^^^^ ^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 36 | pub fn fields(&self) -> Fields<'_, F> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/rp_type_model.rs:36:19 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn fields(&self) -> Fields { [INFO] [stdout] | ^^^^^ ^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 36 | pub fn fields(&self) -> Fields<'_, F> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 16.57s [INFO] running `Command { std: "docker" "inspect" "302551dd094cdef7c3b9401c8e3b90f9c6da40e234cb0ef01287b03f3af2bf66", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "302551dd094cdef7c3b9401c8e3b90f9c6da40e234cb0ef01287b03f3af2bf66", kill_on_drop: false }` [INFO] [stdout] 302551dd094cdef7c3b9401c8e3b90f9c6da40e234cb0ef01287b03f3af2bf66