[INFO] fetching crate renix 0.1.0... [INFO] linting renix-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate renix 0.1.0 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate renix 0.1.0 [INFO] finished tweaking crates.io crate renix 0.1.0 [INFO] tweaked toml for crates.io crate renix 0.1.0 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate renix 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate renix 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tabled_derive v0.8.0 [INFO] [stderr] Downloaded papergrid v0.12.0 [INFO] [stderr] Downloaded tabled v0.16.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e2f40c1ed85028696bd8ba5becfd3c14f692e37f161bd95aadbb57674f4a81a6 [INFO] running `Command { std: "docker" "start" "-a" "e2f40c1ed85028696bd8ba5becfd3c14f692e37f161bd95aadbb57674f4a81a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e2f40c1ed85028696bd8ba5becfd3c14f692e37f161bd95aadbb57674f4a81a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e2f40c1ed85028696bd8ba5becfd3c14f692e37f161bd95aadbb57674f4a81a6", kill_on_drop: false }` [INFO] [stdout] e2f40c1ed85028696bd8ba5becfd3c14f692e37f161bd95aadbb57674f4a81a6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 01dfc18d45ec84f389cd20d272f681b23983693b7ee215e694a6d6d4ece71926 [INFO] running `Command { std: "docker" "start" "-a" "01dfc18d45ec84f389cd20d272f681b23983693b7ee215e694a6d6d4ece71926", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking bytecount v0.6.8 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking papergrid v0.12.0 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking clap_builder v4.5.17 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Compiling tabled_derive v0.8.0 [INFO] [stderr] Checking tabled v0.16.0 [INFO] [stderr] Checking clap v4.5.17 [INFO] [stderr] Checking renix v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: function `rename_files` is never used [INFO] [stdout] --> src/file.rs:197:8 [INFO] [stdout] | [INFO] [stdout] 197 | pub fn rename_files(old_paths: Vec, new_paths: Vec) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/file.rs:19:24 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn get_files(path: &path::PathBuf) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 19 - pub fn get_files(path: &path::PathBuf) -> Vec { [INFO] [stdout] 19 + pub fn get_files(path: &Path) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/file.rs:34:31 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn print_table(old_paths: &Vec, new_paths: Vec) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 34 - pub fn print_table(old_paths: &Vec, new_paths: Vec) -> String { [INFO] [stdout] 34 + pub fn print_table(old_paths: &[path::PathBuf], new_paths: Vec) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4 - eprintln!("{}: {}", "error".red().bold(), msg.red()); [INFO] [stdout] 5 - return; [INFO] [stdout] 4 + eprintln!("{}: {}", "error".red().bold(), msg.red()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:60:8 [INFO] [stdout] | [INFO] [stdout] 60 | if !args.path.read_dir().unwrap().next().is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.path.read_dir().unwrap().next().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args.case` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:96:20 [INFO] [stdout] | [INFO] [stdout] 95 | if args.case.is_some() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = args.case` [INFO] [stdout] 96 | let case = args.case.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args.replace` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:101:23 [INFO] [stdout] | [INFO] [stdout] 100 | if args.replace.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = args.replace` [INFO] [stdout] 101 | let replace = args.replace.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | &exclude, [INFO] [stdout] | ^^^^^^^^ help: change this to: `exclude` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:91:13 [INFO] [stdout] | [INFO] [stdout] 91 | &exclude, [INFO] [stdout] | ^^^^^^^^ help: change this to: `exclude` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `rename_files` is never used [INFO] [stdout] --> src/file.rs:197:8 [INFO] [stdout] | [INFO] [stdout] 197 | pub fn rename_files(old_paths: Vec, new_paths: Vec) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/file.rs:19:24 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn get_files(path: &path::PathBuf) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 19 - pub fn get_files(path: &path::PathBuf) -> Vec { [INFO] [stdout] 19 + pub fn get_files(path: &Path) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/file.rs:34:31 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn print_table(old_paths: &Vec, new_paths: Vec) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 34 - pub fn print_table(old_paths: &Vec, new_paths: Vec) -> String { [INFO] [stdout] 34 + pub fn print_table(old_paths: &[path::PathBuf], new_paths: Vec) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4 - eprintln!("{}: {}", "error".red().bold(), msg.red()); [INFO] [stdout] 5 - return; [INFO] [stdout] 4 + eprintln!("{}: {}", "error".red().bold(), msg.red()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:60:8 [INFO] [stdout] | [INFO] [stdout] 60 | if !args.path.read_dir().unwrap().next().is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.path.read_dir().unwrap().next().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args.case` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:96:20 [INFO] [stdout] | [INFO] [stdout] 95 | if args.case.is_some() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = args.case` [INFO] [stdout] 96 | let case = args.case.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args.replace` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:101:23 [INFO] [stdout] | [INFO] [stdout] 100 | if args.replace.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = args.replace` [INFO] [stdout] 101 | let replace = args.replace.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | &exclude, [INFO] [stdout] | ^^^^^^^^ help: change this to: `exclude` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:91:13 [INFO] [stdout] | [INFO] [stdout] 91 | &exclude, [INFO] [stdout] | ^^^^^^^^ help: change this to: `exclude` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.55s [INFO] running `Command { std: "docker" "inspect" "01dfc18d45ec84f389cd20d272f681b23983693b7ee215e694a6d6d4ece71926", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "01dfc18d45ec84f389cd20d272f681b23983693b7ee215e694a6d6d4ece71926", kill_on_drop: false }` [INFO] [stdout] 01dfc18d45ec84f389cd20d272f681b23983693b7ee215e694a6d6d4ece71926