[INFO] fetching crate rej 0.11.1... [INFO] linting rej-0.11.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate rej 0.11.1 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate rej 0.11.1 [INFO] finished tweaking crates.io crate rej 0.11.1 [INFO] tweaked toml for crates.io crate rej 0.11.1 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate rej 0.11.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 147 packages to latest compatible versions [INFO] [stderr] Adding chacha20 v0.9.1 (available: v0.10.0) [INFO] [stderr] Adding criterion v0.5.1 (available: v0.8.2) [INFO] [stderr] Adding fs4 v0.12.0 (available: v0.13.1) [INFO] [stderr] Adding generic-array v0.14.7 (available: v0.14.9) [INFO] [stderr] Adding rand v0.8.5 (available: v0.10.0) [INFO] [stderr] Adding windows-sys v0.59.0 (available: v0.61.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded digest v0.11.2 [INFO] [stderr] Downloaded crc64 v2.0.0 [INFO] [stderr] Downloaded keccak v0.2.0 [INFO] [stderr] Downloaded fs4 v0.12.0 [INFO] [stderr] Downloaded hkdf v0.13.0-rc.5 [INFO] [stderr] Downloaded sha3 v0.11.0-rc.8 [INFO] [stderr] Downloaded adiantum v0.1.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 025b03203c5be6743802dfc8aa9ee25af47a1597880a5e55ae0aa42170c4e7e7 [INFO] running `Command { std: "docker" "start" "-a" "025b03203c5be6743802dfc8aa9ee25af47a1597880a5e55ae0aa42170c4e7e7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "025b03203c5be6743802dfc8aa9ee25af47a1597880a5e55ae0aa42170c4e7e7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "025b03203c5be6743802dfc8aa9ee25af47a1597880a5e55ae0aa42170c4e7e7", kill_on_drop: false }` [INFO] [stdout] 025b03203c5be6743802dfc8aa9ee25af47a1597880a5e55ae0aa42170c4e7e7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 764b75d9a6c726deb74960987bf06c29a5caba5d7a1ba61dea12406e49f3ac3e [INFO] running `Command { std: "docker" "start" "-a" "764b75d9a6c726deb74960987bf06c29a5caba5d7a1ba61dea12406e49f3ac3e", kill_on_drop: false }` [INFO] [stderr] Compiling zerocopy v0.8.42 [INFO] [stderr] Checking anstyle v1.0.14 [INFO] [stderr] Compiling zerocopy-derive v0.8.42 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Checking clap_lex v1.1.0 [INFO] [stderr] Checking colorchoice v1.0.5 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking is-terminal v0.4.17 [INFO] [stderr] Checking clap_builder v4.6.0 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking crc64 v2.0.0 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking env_logger v0.11.9 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking clap v4.6.0 [INFO] [stderr] Checking fs4 v0.12.0 [INFO] [stderr] Checking rej v0.11.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/btree.rs:187:50 [INFO] [stdout] | [INFO] [stdout] 187 | if donor.can_donate() && right.as_ref().map_or(true, |r| r.le(donor)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 187 - if donor.can_donate() && right.as_ref().map_or(true, |r| r.le(donor)) { [INFO] [stdout] 187 + if donor.can_donate() && right.as_ref().is_none_or(|r| r.le(donor)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/btree.rs:235:28 [INFO] [stdout] | [INFO] [stdout] 235 | if right.as_ref().map_or(true, |r| r.gt(neighbor)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 235 - if right.as_ref().map_or(true, |r| r.gt(neighbor)) { [INFO] [stdout] 235 + if right.as_ref().is_none_or(|r| r.gt(neighbor)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing an `Option` with `Some(..)` [INFO] [stdout] --> src/db.rs:115:19 [INFO] [stdout] | [INFO] [stdout] 115 | let old = mem::replace(wal_lock.orphan_mut(), Some(ptr.cast())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider `Option::replace()` instead: `wal_lock.orphan_mut().replace(ptr.cast())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_option_with_some [INFO] [stdout] = note: `#[warn(clippy::mem_replace_option_with_some)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/btree.rs:187:50 [INFO] [stdout] | [INFO] [stdout] 187 | if donor.can_donate() && right.as_ref().map_or(true, |r| r.le(donor)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 187 - if donor.can_donate() && right.as_ref().map_or(true, |r| r.le(donor)) { [INFO] [stdout] 187 + if donor.can_donate() && right.as_ref().is_none_or(|r| r.le(donor)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/btree.rs:235:28 [INFO] [stdout] | [INFO] [stdout] 235 | if right.as_ref().map_or(true, |r| r.gt(neighbor)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 235 - if right.as_ref().map_or(true, |r| r.gt(neighbor)) { [INFO] [stdout] 235 + if right.as_ref().is_none_or(|r| r.gt(neighbor)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing an `Option` with `Some(..)` [INFO] [stdout] --> src/db.rs:115:19 [INFO] [stdout] | [INFO] [stdout] 115 | let old = mem::replace(wal_lock.orphan_mut(), Some(ptr.cast())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider `Option::replace()` instead: `wal_lock.orphan_mut().replace(ptr.cast())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_option_with_some [INFO] [stdout] = note: `#[warn(clippy::mem_replace_option_with_some)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tests/recovery.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | / false [INFO] [stdout] 43 | | || (cnt == 0 && stats.used <= 1) [INFO] [stdout] 44 | | || (cnt == 1 && stats.used <= 3) [INFO] [stdout] 45 | | || (cnt == 2 && stats.used <= 6) [INFO] [stdout] | |________________________________________^ help: try: `cnt == 0 && stats.used <= 1 || cnt == 1 && stats.used <= 3 || cnt == 2 && stats.used <= 6` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tests/recovery.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | / false [INFO] [stdout] 43 | | || (cnt == 0 && stats.used <= 1) [INFO] [stdout] 44 | | || (cnt == 1 && stats.used <= 3) [INFO] [stdout] | |________________________________________^ help: try: `cnt == 0 && stats.used <= 1 || cnt == 1 && stats.used <= 3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tests/recovery.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | / false [INFO] [stdout] 43 | | || (cnt == 0 && stats.used <= 1) [INFO] [stdout] | |________________________________________^ help: try: `cnt == 0 && stats.used <= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 16.74s [INFO] running `Command { std: "docker" "inspect" "764b75d9a6c726deb74960987bf06c29a5caba5d7a1ba61dea12406e49f3ac3e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "764b75d9a6c726deb74960987bf06c29a5caba5d7a1ba61dea12406e49f3ac3e", kill_on_drop: false }` [INFO] [stdout] 764b75d9a6c726deb74960987bf06c29a5caba5d7a1ba61dea12406e49f3ac3e