[INFO] fetching crate regexnight 0.2.0... [INFO] linting regexnight-0.2.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate regexnight 0.2.0 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate regexnight 0.2.0 [INFO] finished tweaking crates.io crate regexnight 0.2.0 [INFO] tweaked toml for crates.io crate regexnight 0.2.0 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate regexnight 0.2.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate regexnight 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded yare-macro v3.0.0 [INFO] [stderr] Downloaded insta v1.41.1 [INFO] [stderr] Downloaded lazy-regex v3.3.0 [INFO] [stderr] Downloaded tree-ds v0.1.5 [INFO] [stderr] Downloaded thiserror-impl v2.0.3 [INFO] [stderr] Downloaded sequential_gen v0.1.2 [INFO] [stderr] Downloaded yare v3.0.0 [INFO] [stderr] Downloaded lazy-regex-proc_macros v3.3.0 [INFO] [stderr] Downloaded thiserror v1.0.68 [INFO] [stderr] Downloaded anyhow v1.0.93 [INFO] [stderr] Downloaded thiserror v2.0.3 [INFO] [stderr] Downloaded thiserror-impl v1.0.68 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 154ca91d4ebdbea3a62f1a887df39b03bde57385ef647ca5b531a7b8810e6f85 [INFO] running `Command { std: "docker" "start" "-a" "154ca91d4ebdbea3a62f1a887df39b03bde57385ef647ca5b531a7b8810e6f85", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "154ca91d4ebdbea3a62f1a887df39b03bde57385ef647ca5b531a7b8810e6f85", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "154ca91d4ebdbea3a62f1a887df39b03bde57385ef647ca5b531a7b8810e6f85", kill_on_drop: false }` [INFO] [stdout] 154ca91d4ebdbea3a62f1a887df39b03bde57385ef647ca5b531a7b8810e6f85 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b0a7855ea4401d7a65dd4edcfa7e46074ed0dc210e6d532a2e984be407a5054b [INFO] running `Command { std: "docker" "start" "-a" "b0a7855ea4401d7a65dd4edcfa7e46074ed0dc210e6d532a2e984be407a5054b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.89 [INFO] [stderr] Compiling unicode-ident v1.0.13 [INFO] [stderr] Compiling libc v0.2.161 [INFO] [stderr] Compiling serde v1.0.214 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Compiling thiserror v1.0.68 [INFO] [stderr] Checking regex-automata v0.4.8 [INFO] [stderr] Compiling thiserror v2.0.3 [INFO] [stderr] Compiling anyhow v1.0.93 [INFO] [stderr] Checking clap_builder v4.5.20 [INFO] [stderr] Compiling serde_json v1.0.132 [INFO] [stderr] Checking nu-ansi-term v0.50.1 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking insta v1.41.1 [INFO] [stderr] Compiling syn v2.0.87 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Compiling serde_derive v1.0.214 [INFO] [stderr] Compiling thiserror-impl v1.0.68 [INFO] [stderr] Compiling thiserror-impl v2.0.3 [INFO] [stderr] Compiling clap_derive v4.5.18 [INFO] [stderr] Compiling yare-macro v3.0.0 [INFO] [stderr] Checking yare v3.0.0 [INFO] [stderr] Compiling lazy-regex-proc_macros v3.3.0 [INFO] [stderr] Checking lazy-regex v3.3.0 [INFO] [stderr] Checking clap v4.5.20 [INFO] [stderr] Checking uuid v1.11.0 [INFO] [stderr] Checking sequential_gen v0.1.2 [INFO] [stderr] Checking tree-ds v0.1.5 [INFO] [stderr] Checking regexnight v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct pattern is not needed for a unit variant [INFO] [stdout] --> src/tree.rs:87:31 [INFO] [stdout] | [INFO] [stdout] 87 | Token::Alternative {} => { [INFO] [stdout] | ^^^ help: remove the struct pattern [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern [INFO] [stdout] = note: `#[warn(clippy::unneeded_struct_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/parse.rs:453:13 [INFO] [stdout] | [INFO] [stdout] 453 | pattern: pattern, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `pattern` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/parse.rs:454:13 [INFO] [stdout] | [INFO] [stdout] 454 | tree: tree, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `tree` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/parse.rs:343:88 [INFO] [stdout] | [INFO] [stdout] 343 | fn fill_tree(builder: &mut Builder, parent_id: Option<&AutomatedId>, value: &Value) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/parse.rs:361:29 [INFO] [stdout] | [INFO] [stdout] 361 | None => "group".into(), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider removing `.into()`: `"group"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/parse.rs:368:37 [INFO] [stdout] | [INFO] [stdout] 368 | ... None => "".into(), [INFO] [stdout] | ^^^^^^^^^ help: consider removing `.into()`: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/parse.rs:381:37 [INFO] [stdout] | [INFO] [stdout] 381 | ... None => "".into(), [INFO] [stdout] | ^^^^^^^^^ help: consider removing `.into()`: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/parse.rs:390:37 [INFO] [stdout] | [INFO] [stdout] 390 | ... None => "".into(), [INFO] [stdout] | ^^^^^^^^^ help: consider removing `.into()`: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parse.rs:503:32 [INFO] [stdout] | [INFO] [stdout] 503 | if (node1.is_none() && !node2.is_none()) || (!node1.is_none() && node2.is_none()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `node2.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parse.rs:503:54 [INFO] [stdout] | [INFO] [stdout] 503 | if (node1.is_none() && !node2.is_none()) || (!node1.is_none() && node2.is_none()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `node1.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parse.rs:526:9 [INFO] [stdout] | [INFO] [stdout] 526 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 526 - return true; [INFO] [stdout] 526 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/print_tree.rs:282:32 [INFO] [stdout] | [INFO] [stdout] 282 | let tree = parse_regex(®ex).unwrap(); [INFO] [stdout] | ^^^^^^ help: change this to: `regex` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/print_tree.rs:297:32 [INFO] [stdout] | [INFO] [stdout] 297 | let tree = parse_regex(®ex).unwrap(); [INFO] [stdout] | ^^^^^^ help: change this to: `regex` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct pattern is not needed for a unit variant [INFO] [stdout] --> src/tree.rs:87:31 [INFO] [stdout] | [INFO] [stdout] 87 | Token::Alternative {} => { [INFO] [stdout] | ^^^ help: remove the struct pattern [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern [INFO] [stdout] = note: `#[warn(clippy::unneeded_struct_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 34.60s [INFO] running `Command { std: "docker" "inspect" "b0a7855ea4401d7a65dd4edcfa7e46074ed0dc210e6d532a2e984be407a5054b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b0a7855ea4401d7a65dd4edcfa7e46074ed0dc210e6d532a2e984be407a5054b", kill_on_drop: false }` [INFO] [stdout] b0a7855ea4401d7a65dd4edcfa7e46074ed0dc210e6d532a2e984be407a5054b