[INFO] fetching crate redox-scheme 0.11.0... [INFO] linting redox-scheme-0.11.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate redox-scheme 0.11.0 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate redox-scheme 0.11.0 [INFO] finished tweaking crates.io crate redox-scheme 0.11.0 [INFO] tweaked toml for crates.io crate redox-scheme 0.11.0 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate redox-scheme 0.11.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate redox-scheme 0.11.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded libredox v0.1.13 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f290d1c93b419b4246073bda2e5f0de55f6220d52883db20b392da3967f898a3 [INFO] running `Command { std: "docker" "start" "-a" "f290d1c93b419b4246073bda2e5f0de55f6220d52883db20b392da3967f898a3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f290d1c93b419b4246073bda2e5f0de55f6220d52883db20b392da3967f898a3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f290d1c93b419b4246073bda2e5f0de55f6220d52883db20b392da3967f898a3", kill_on_drop: false }` [INFO] [stdout] f290d1c93b419b4246073bda2e5f0de55f6220d52883db20b392da3967f898a3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 99dece67c2ab1aeb3030d714a56957d46e02d3a6c19d5b14e10b4ca5543af9a6 [INFO] running `Command { std: "docker" "start" "-a" "99dece67c2ab1aeb3030d714a56957d46e02d3a6c19d5b14e10b4ca5543af9a6", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.182 [INFO] [stderr] Checking redox_syscall v0.7.3 [INFO] [stderr] Checking libredox v0.1.13 [INFO] [stderr] Checking redox-scheme v0.11.0 (/opt/rustwide/workdir) [INFO] [stdout] warning[E0133]: call to unsafe function `std::str::from_utf8_unchecked` is unsafe and requires unsafe block [INFO] [stdout] --> src/scheme.rs:252:27 [INFO] [stdout] | [INFO] [stdout] 252 | path: str::from_utf8_unchecked(slice::from_raw_parts(b as *const u8, c)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/scheme.rs:238:5 [INFO] [stdout] | [INFO] [stdout] 238 | pub unsafe fn from_sqe_unchecked(sqe: &Sqe) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(unsafe_op_in_unsafe_fn)]` (part of `#[warn(rust_2024_compatibility)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::slice::from_raw_parts` is unsafe and requires unsafe block [INFO] [stdout] --> src/scheme.rs:252:52 [INFO] [stdout] | [INFO] [stdout] 252 | path: str::from_utf8_unchecked(slice::from_raw_parts(b as *const u8, c)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::str::from_utf8_unchecked` is unsafe and requires unsafe block [INFO] [stdout] --> src/scheme.rs:261:27 [INFO] [stdout] | [INFO] [stdout] 261 | path: str::from_utf8_unchecked(slice::from_raw_parts(b as *const u8, c)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::slice::from_raw_parts` is unsafe and requires unsafe block [INFO] [stdout] --> src/scheme.rs:261:52 [INFO] [stdout] | [INFO] [stdout] 261 | path: str::from_utf8_unchecked(slice::from_raw_parts(b as *const u8, c)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::slice::from_raw_parts` is unsafe and requires unsafe block [INFO] [stdout] --> src/scheme.rs:268:22 [INFO] [stdout] | [INFO] [stdout] 268 | buf: slice::from_raw_parts(b as *const u8, c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::slice::from_raw_parts_mut` is unsafe and requires unsafe block [INFO] [stdout] --> src/scheme.rs:273:22 [INFO] [stdout] | [INFO] [stdout] 273 | buf: slice::from_raw_parts_mut(b as *mut u8, c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::slice::from_raw_parts` is unsafe and requires unsafe block [INFO] [stdout] --> src/scheme.rs:280:22 [INFO] [stdout] | [INFO] [stdout] 280 | buf: slice::from_raw_parts(b as *const u8, c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::str::from_utf8_unchecked` is unsafe and requires unsafe block [INFO] [stdout] --> src/scheme.rs:312:22 [INFO] [stdout] | [INFO] [stdout] 312 | buf: str::from_utf8_unchecked(slice::from_raw_parts(b as *const u8, c)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::slice::from_raw_parts` is unsafe and requires unsafe block [INFO] [stdout] --> src/scheme.rs:312:47 [INFO] [stdout] | [INFO] [stdout] 312 | buf: str::from_utf8_unchecked(slice::from_raw_parts(b as *const u8, c)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::slice::from_raw_parts_mut` is unsafe and requires unsafe block [INFO] [stdout] --> src/scheme.rs:317:22 [INFO] [stdout] | [INFO] [stdout] 317 | buf: slice::from_raw_parts_mut(b as *mut u8, c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::str::from_utf8_unchecked` is unsafe and requires unsafe block [INFO] [stdout] --> src/scheme.rs:322:22 [INFO] [stdout] | [INFO] [stdout] 322 | buf: str::from_utf8_unchecked(slice::from_raw_parts(b as *const u8, c)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::slice::from_raw_parts` is unsafe and requires unsafe block [INFO] [stdout] --> src/scheme.rs:322:47 [INFO] [stdout] | [INFO] [stdout] 322 | buf: str::from_utf8_unchecked(slice::from_raw_parts(b as *const u8, c)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block [INFO] [stdout] --> src/scheme.rs:329:31 [INFO] [stdout] | [INFO] [stdout] 329 | buf: &mut *(b as *mut Stat), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ dereference of raw pointer [INFO] [stdout] | [INFO] [stdout] = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block [INFO] [stdout] --> src/scheme.rs:337:31 [INFO] [stdout] | [INFO] [stdout] 337 | buf: &mut *(b as *mut StatVfs), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ dereference of raw pointer [INFO] [stdout] | [INFO] [stdout] = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::slice::from_raw_parts` is unsafe and requires unsafe block [INFO] [stdout] --> src/scheme.rs:351:26 [INFO] [stdout] | [INFO] [stdout] 351 | buf: slice::from_raw_parts(b as *const TimeSpec, c / size_of::()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::slice::from_raw_parts_mut` is unsafe and requires unsafe block [INFO] [stdout] --> src/scheme.rs:358:26 [INFO] [stdout] | [INFO] [stdout] 358 | payload: slice::from_raw_parts_mut(b as *mut u8, c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::slice::from_raw_parts_mut` is unsafe and requires unsafe block [INFO] [stdout] --> src/scheme.rs:364:26 [INFO] [stdout] | [INFO] [stdout] 364 | payload: slice::from_raw_parts_mut(b as *mut u8, c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::slice::from_raw_parts_mut` is unsafe and requires unsafe block [INFO] [stdout] --> src/scheme.rs:370:22 [INFO] [stdout] | [INFO] [stdout] 370 | buf: slice::from_raw_parts_mut(b as *mut u8, c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::str::from_utf8_unchecked` is unsafe and requires unsafe block [INFO] [stdout] --> src/scheme.rs:252:27 [INFO] [stdout] | [INFO] [stdout] 252 | path: str::from_utf8_unchecked(slice::from_raw_parts(b as *const u8, c)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/scheme.rs:238:5 [INFO] [stdout] | [INFO] [stdout] 238 | pub unsafe fn from_sqe_unchecked(sqe: &Sqe) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(unsafe_op_in_unsafe_fn)]` (part of `#[warn(rust_2024_compatibility)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/advisory_flock.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | /// open for *reading*. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 34 | /// open for *reading*. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/advisory_flock.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | /// not open for *writing*. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 37 | /// not open for *writing*. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::slice::from_raw_parts` is unsafe and requires unsafe block [INFO] [stdout] --> src/scheme.rs:252:52 [INFO] [stdout] | [INFO] [stdout] 252 | path: str::from_utf8_unchecked(slice::from_raw_parts(b as *const u8, c)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::str::from_utf8_unchecked` is unsafe and requires unsafe block [INFO] [stdout] --> src/scheme.rs:261:27 [INFO] [stdout] | [INFO] [stdout] 261 | path: str::from_utf8_unchecked(slice::from_raw_parts(b as *const u8, c)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::slice::from_raw_parts` is unsafe and requires unsafe block [INFO] [stdout] --> src/scheme.rs:261:52 [INFO] [stdout] | [INFO] [stdout] 261 | path: str::from_utf8_unchecked(slice::from_raw_parts(b as *const u8, c)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::slice::from_raw_parts` is unsafe and requires unsafe block [INFO] [stdout] --> src/scheme.rs:268:22 [INFO] [stdout] | [INFO] [stdout] 268 | buf: slice::from_raw_parts(b as *const u8, c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::slice::from_raw_parts_mut` is unsafe and requires unsafe block [INFO] [stdout] --> src/scheme.rs:273:22 [INFO] [stdout] | [INFO] [stdout] 273 | buf: slice::from_raw_parts_mut(b as *mut u8, c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::slice::from_raw_parts` is unsafe and requires unsafe block [INFO] [stdout] --> src/scheme.rs:280:22 [INFO] [stdout] | [INFO] [stdout] 280 | buf: slice::from_raw_parts(b as *const u8, c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::str::from_utf8_unchecked` is unsafe and requires unsafe block [INFO] [stdout] --> src/scheme.rs:312:22 [INFO] [stdout] | [INFO] [stdout] 312 | buf: str::from_utf8_unchecked(slice::from_raw_parts(b as *const u8, c)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::slice::from_raw_parts` is unsafe and requires unsafe block [INFO] [stdout] --> src/scheme.rs:312:47 [INFO] [stdout] | [INFO] [stdout] 312 | buf: str::from_utf8_unchecked(slice::from_raw_parts(b as *const u8, c)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::slice::from_raw_parts_mut` is unsafe and requires unsafe block [INFO] [stdout] --> src/scheme.rs:317:22 [INFO] [stdout] | [INFO] [stdout] 317 | buf: slice::from_raw_parts_mut(b as *mut u8, c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::str::from_utf8_unchecked` is unsafe and requires unsafe block [INFO] [stdout] --> src/scheme.rs:322:22 [INFO] [stdout] | [INFO] [stdout] 322 | buf: str::from_utf8_unchecked(slice::from_raw_parts(b as *const u8, c)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::slice::from_raw_parts` is unsafe and requires unsafe block [INFO] [stdout] --> src/scheme.rs:322:47 [INFO] [stdout] | [INFO] [stdout] 322 | buf: str::from_utf8_unchecked(slice::from_raw_parts(b as *const u8, c)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block [INFO] [stdout] --> src/scheme.rs:329:31 [INFO] [stdout] | [INFO] [stdout] 329 | buf: &mut *(b as *mut Stat), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ dereference of raw pointer [INFO] [stdout] | [INFO] [stdout] = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block [INFO] [stdout] --> src/scheme.rs:337:31 [INFO] [stdout] | [INFO] [stdout] 337 | buf: &mut *(b as *mut StatVfs), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ dereference of raw pointer [INFO] [stdout] | [INFO] [stdout] = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::slice::from_raw_parts` is unsafe and requires unsafe block [INFO] [stdout] --> src/scheme.rs:351:26 [INFO] [stdout] | [INFO] [stdout] 351 | buf: slice::from_raw_parts(b as *const TimeSpec, c / size_of::()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::slice::from_raw_parts_mut` is unsafe and requires unsafe block [INFO] [stdout] --> src/scheme.rs:358:26 [INFO] [stdout] | [INFO] [stdout] 358 | payload: slice::from_raw_parts_mut(b as *mut u8, c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::slice::from_raw_parts_mut` is unsafe and requires unsafe block [INFO] [stdout] --> src/scheme.rs:364:26 [INFO] [stdout] | [INFO] [stdout] 364 | payload: slice::from_raw_parts_mut(b as *mut u8, c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::slice::from_raw_parts_mut` is unsafe and requires unsafe block [INFO] [stdout] --> src/scheme.rs:370:22 [INFO] [stdout] | [INFO] [stdout] 370 | buf: slice::from_raw_parts_mut(b as *mut u8, c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly casting the result of `from_raw_parts` to `*const [u8]` [INFO] [stdout] --> src/scheme.rs:268:22 [INFO] [stdout] | [INFO] [stdout] 268 | buf: slice::from_raw_parts(b as *const u8, c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace_with: `std::ptr::slice_from_raw_parts(b as *const u8, c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_slice_from_raw_parts [INFO] [stdout] = note: `#[warn(clippy::cast_slice_from_raw_parts)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly casting the result of `from_raw_parts_mut` to `*mut [u8]` [INFO] [stdout] --> src/scheme.rs:273:22 [INFO] [stdout] | [INFO] [stdout] 273 | buf: slice::from_raw_parts_mut(b as *mut u8, c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace_with: `std::ptr::slice_from_raw_parts_mut(b as *mut u8, c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_slice_from_raw_parts [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly casting the result of `from_raw_parts` to `*const [u8]` [INFO] [stdout] --> src/scheme.rs:280:22 [INFO] [stdout] | [INFO] [stdout] 280 | buf: slice::from_raw_parts(b as *const u8, c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace_with: `std::ptr::slice_from_raw_parts(b as *const u8, c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_slice_from_raw_parts [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly casting the result of `from_raw_parts_mut` to `*mut [u8]` [INFO] [stdout] --> src/scheme.rs:317:22 [INFO] [stdout] | [INFO] [stdout] 317 | buf: slice::from_raw_parts_mut(b as *mut u8, c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace_with: `std::ptr::slice_from_raw_parts_mut(b as *mut u8, c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_slice_from_raw_parts [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly casting the result of `from_raw_parts` to `*const [syscall::TimeSpec]` [INFO] [stdout] --> src/scheme.rs:351:26 [INFO] [stdout] | [INFO] [stdout] 351 | buf: slice::from_raw_parts(b as *const TimeSpec, c / size_of::()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace_with: `std::ptr::slice_from_raw_parts(b as *const TimeSpec, c / size_of::())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_slice_from_raw_parts [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly casting the result of `from_raw_parts_mut` to `*mut [u8]` [INFO] [stdout] --> src/scheme.rs:358:26 [INFO] [stdout] | [INFO] [stdout] 358 | payload: slice::from_raw_parts_mut(b as *mut u8, c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace_with: `std::ptr::slice_from_raw_parts_mut(b as *mut u8, c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_slice_from_raw_parts [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly casting the result of `from_raw_parts_mut` to `*mut [u8]` [INFO] [stdout] --> src/scheme.rs:364:26 [INFO] [stdout] | [INFO] [stdout] 364 | payload: slice::from_raw_parts_mut(b as *mut u8, c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace_with: `std::ptr::slice_from_raw_parts_mut(b as *mut u8, c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_slice_from_raw_parts [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly casting the result of `from_raw_parts_mut` to `*mut [u8]` [INFO] [stdout] --> src/scheme.rs:370:22 [INFO] [stdout] | [INFO] [stdout] 370 | buf: slice::from_raw_parts_mut(b as *mut u8, c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace_with: `std::ptr::slice_from_raw_parts_mut(b as *mut u8, c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_slice_from_raw_parts [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scheme.rs:540:17 [INFO] [stdout] | [INFO] [stdout] 540 | return SchemeResponse::Opened(res); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 540 - return SchemeResponse::Opened(res); [INFO] [stdout] 540 + SchemeResponse::Opened(res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scheme.rs:548:17 [INFO] [stdout] | [INFO] [stdout] 548 | return SchemeResponse::Opened(res); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 548 - return SchemeResponse::Opened(res); [INFO] [stdout] 548 + SchemeResponse::Opened(res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scheme.rs:619:21 [INFO] [stdout] | [INFO] [stdout] 619 | return resp; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 619 - return resp; [INFO] [stdout] 619 + resp [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scheme.rs:638:17 [INFO] [stdout] | [INFO] [stdout] 638 | return SchemeResponse::Opened(res); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 638 - return SchemeResponse::Opened(res); [INFO] [stdout] 638 + SchemeResponse::Opened(res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:538:21 [INFO] [stdout] | [INFO] [stdout] 538 | &caller, [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:543:64 [INFO] [stdout] | [INFO] [stdout] 543 | .unlinkat(req.fd, req.path(), req.inner.flags, &caller) [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:547:52 [INFO] [stdout] | [INFO] [stdout] 547 | let res = s.dup(req.fd, req.buf(), &caller); [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:554:54 [INFO] [stdout] | [INFO] [stdout] 554 | s.read(fd, req.buf(), offset, flags, &caller).into() [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:557:66 [INFO] [stdout] | [INFO] [stdout] 557 | .write(req.fd, req.buf(), req.offset, req.flags, &caller) [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:561:49 [INFO] [stdout] | [INFO] [stdout] 561 | Op::Fsize { fd, .. } => s.fsize(fd, &caller).map(|l| l as usize).into(), [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:563:71 [INFO] [stdout] | [INFO] [stdout] 563 | Op::Fchmod { fd, new_mode, .. } => s.fchmod(fd, new_mode, &caller).map(|()| 0).into(), [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:569:49 [INFO] [stdout] | [INFO] [stdout] 569 | } => s.fchown(fd, new_uid, new_gid, &caller).map(|()| 0).into(), [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:570:69 [INFO] [stdout] | [INFO] [stdout] 570 | Op::Fcntl { fd, cmd, arg, .. } => s.fcntl(fd, cmd, arg, &caller).into(), [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:572:41 [INFO] [stdout] | [INFO] [stdout] 572 | s.fevent(fd, req_flags, &caller).map(|f| f.bits()).into() [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:574:62 [INFO] [stdout] | [INFO] [stdout] 574 | Op::Flink(ref req) => s.flink(req.fd, req.buf(), &caller).into(), [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:575:66 [INFO] [stdout] | [INFO] [stdout] 575 | Op::Fpath(ref mut req) => s.fpath(req.fd, req.buf(), &caller).into(), [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:576:66 [INFO] [stdout] | [INFO] [stdout] 576 | Op::Frename(ref req) => s.frename(req.fd, req.buf(), &caller).into(), [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:577:66 [INFO] [stdout] | [INFO] [stdout] 577 | Op::Fstat(ref mut req) => s.fstat(req.fd, req.buf(), &caller).map(|()| 0).into(), [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:578:72 [INFO] [stdout] | [INFO] [stdout] 578 | Op::FstatVfs(ref mut req) => s.fstatvfs(req.fd, req.buf(), &caller).map(|()| 0).into(), [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:579:49 [INFO] [stdout] | [INFO] [stdout] 579 | Op::Fsync { fd, .. } => s.fsync(fd, &caller).map(|()| 0).into(), [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:580:73 [INFO] [stdout] | [INFO] [stdout] 580 | Op::Ftruncate { fd, new_sz, .. } => s.ftruncate(fd, new_sz, &caller).map(|()| 0).into(), [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:581:68 [INFO] [stdout] | [INFO] [stdout] 581 | Op::Futimens(ref req) => s.futimens(req.fd, req.buf(), &caller).map(|()| 0).into(), [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:589:54 [INFO] [stdout] | [INFO] [stdout] 589 | } => s.mmap_prep(fd, offset, len, flags, &caller).into(), [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:596:51 [INFO] [stdout] | [INFO] [stdout] 596 | } => s.munmap(fd, offset, len, flags, &caller).map(|()| 0).into(), [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:601:47 [INFO] [stdout] | [INFO] [stdout] 601 | s.call(fd, payload, metadata, &caller).into() [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:617:21 [INFO] [stdout] | [INFO] [stdout] 617 | &caller, [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:621:87 [INFO] [stdout] | [INFO] [stdout] 621 | s.translate_std_fs_call_sync(fd, kind, payload, std_fs_call_meta, &caller) [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::result::Result` [INFO] [stdout] --> src/scheme.rs:665:17 [INFO] [stdout] | [INFO] [stdout] 665 | / s.unlinkat(req.fd, req.path(), req.inner.flags, &caller) [INFO] [stdout] 666 | | .await [INFO] [stdout] 667 | | .map(|()| 0) [INFO] [stdout] 668 | | .into(), [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 665 ~ s.unlinkat(req.fd, req.path(), req.inner.flags, &caller) [INFO] [stdout] 666 + .await [INFO] [stdout] 667 ~ .map(|()| 0), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/advisory_flock.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | /// open for *reading*. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 34 | /// open for *reading*. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/advisory_flock.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | /// not open for *writing*. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 37 | /// not open for *writing*. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:997:59 [INFO] [stdout] | [INFO] [stdout] 997 | .std_fs_call(id, kind, payload, metadata, &ctx) [INFO] [stdout] | ^^^^ help: change this to: `ctx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/advisory_flock.rs:294:13 [INFO] [stdout] | [INFO] [stdout] 294 | / !set.lock(LockKind::Shared, LockOwner::Resource { fd: 1 }, 0, 2) [INFO] [stdout] 295 | | .is_ok() [INFO] [stdout] | |________________________^ help: try: `set.lock(LockKind::Shared, LockOwner::Resource { fd: 1 }, 0, 2).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/advisory_flock.rs:298:13 [INFO] [stdout] | [INFO] [stdout] 298 | / !set.lock(LockKind::Exclusive, LockOwner::Resource { fd: 1 }, 0, 2) [INFO] [stdout] 299 | | .is_ok() [INFO] [stdout] | |________________________^ help: try: `set.lock(LockKind::Exclusive, LockOwner::Resource { fd: 1 }, 0, 2).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/advisory_flock.rs:303:13 [INFO] [stdout] | [INFO] [stdout] 303 | / !set.lock( [INFO] [stdout] 304 | | LockKind::Shared, [INFO] [stdout] 305 | | LockOwner::Process { pid: 2, inode: 2 }, [INFO] [stdout] 306 | | 0, [INFO] [stdout] ... | [INFO] [stdout] 309 | | .is_ok() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 303 ~ set.lock( [INFO] [stdout] 304 + LockKind::Shared, [INFO] [stdout] 305 + LockOwner::Process { pid: 2, inode: 2 }, [INFO] [stdout] 306 + 0, [INFO] [stdout] 307 + 2 [INFO] [stdout] 308 + ).is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/advisory_flock.rs:312:13 [INFO] [stdout] | [INFO] [stdout] 312 | / !set.lock( [INFO] [stdout] 313 | | LockKind::Exclusive, [INFO] [stdout] 314 | | LockOwner::Process { pid: 2, inode: 2 }, [INFO] [stdout] 315 | | 0, [INFO] [stdout] ... | [INFO] [stdout] 318 | | .is_ok() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 312 ~ set.lock( [INFO] [stdout] 313 + LockKind::Exclusive, [INFO] [stdout] 314 + LockOwner::Process { pid: 2, inode: 2 }, [INFO] [stdout] 315 + 0, [INFO] [stdout] 316 + 2 [INFO] [stdout] 317 + ).is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/advisory_flock.rs:333:13 [INFO] [stdout] | [INFO] [stdout] 333 | / !set.lock( [INFO] [stdout] 334 | | LockKind::Exclusive, [INFO] [stdout] 335 | | LockOwner::Process { pid: 2, inode: 2 }, [INFO] [stdout] 336 | | 2, [INFO] [stdout] ... | [INFO] [stdout] 339 | | .is_ok() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 333 ~ set.lock( [INFO] [stdout] 334 + LockKind::Exclusive, [INFO] [stdout] 335 + LockOwner::Process { pid: 2, inode: 2 }, [INFO] [stdout] 336 + 2, [INFO] [stdout] 337 + 2 [INFO] [stdout] 338 + ).is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/advisory_flock.rs:342:13 [INFO] [stdout] | [INFO] [stdout] 342 | / !set.lock(LockKind::Exclusive, LockOwner::Resource { fd: 1 }, 2, 2) [INFO] [stdout] 343 | | .is_ok() [INFO] [stdout] | |________________________^ help: try: `set.lock(LockKind::Exclusive, LockOwner::Resource { fd: 1 }, 2, 2).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `SchemeState` [INFO] [stdout] --> src/scheme.rs:1476:5 [INFO] [stdout] | [INFO] [stdout] 1476 | / pub fn new() -> Self { [INFO] [stdout] 1477 | | Self { [INFO] [stdout] 1478 | | flocks: LockSet::new(), [INFO] [stdout] 1479 | | } [INFO] [stdout] 1480 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 1475 + impl Default for SchemeState { [INFO] [stdout] 1476 + fn default() -> Self { [INFO] [stdout] 1477 + Self::new() [INFO] [stdout] 1478 + } [INFO] [stdout] 1479 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly casting the result of `from_raw_parts` to `*const [u8]` [INFO] [stdout] --> src/scheme.rs:268:22 [INFO] [stdout] | [INFO] [stdout] 268 | buf: slice::from_raw_parts(b as *const u8, c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace_with: `std::ptr::slice_from_raw_parts(b as *const u8, c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_slice_from_raw_parts [INFO] [stdout] = note: `#[warn(clippy::cast_slice_from_raw_parts)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly casting the result of `from_raw_parts_mut` to `*mut [u8]` [INFO] [stdout] --> src/scheme.rs:273:22 [INFO] [stdout] | [INFO] [stdout] 273 | buf: slice::from_raw_parts_mut(b as *mut u8, c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace_with: `std::ptr::slice_from_raw_parts_mut(b as *mut u8, c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_slice_from_raw_parts [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/scheme.rs:1580:38 [INFO] [stdout] | [INFO] [stdout] 1580 | payload[0] = lck.start as u64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `lck.start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly casting the result of `from_raw_parts` to `*const [u8]` [INFO] [stdout] --> src/scheme.rs:280:22 [INFO] [stdout] | [INFO] [stdout] 280 | buf: slice::from_raw_parts(b as *const u8, c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace_with: `std::ptr::slice_from_raw_parts(b as *const u8, c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_slice_from_raw_parts [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly casting the result of `from_raw_parts_mut` to `*mut [u8]` [INFO] [stdout] --> src/scheme.rs:317:22 [INFO] [stdout] | [INFO] [stdout] 317 | buf: slice::from_raw_parts_mut(b as *mut u8, c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace_with: `std::ptr::slice_from_raw_parts_mut(b as *mut u8, c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_slice_from_raw_parts [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/scheme.rs:1582:29 [INFO] [stdout] | [INFO] [stdout] 1582 | ... lck.len() as u64 | if lck.kind.is_exclusive() { 1 << 63 } else { 0 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `lck.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/wrappers.rs:48:25 [INFO] [stdout] | [INFO] [stdout] 48 | Err(err) => return Err(err), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - Err(err) => return Err(err), [INFO] [stdout] 48 + Err(err) => Err(err), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly casting the result of `from_raw_parts` to `*const [syscall::TimeSpec]` [INFO] [stdout] --> src/scheme.rs:351:26 [INFO] [stdout] | [INFO] [stdout] 351 | buf: slice::from_raw_parts(b as *const TimeSpec, c / size_of::()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace_with: `std::ptr::slice_from_raw_parts(b as *const TimeSpec, c / size_of::())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_slice_from_raw_parts [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly casting the result of `from_raw_parts_mut` to `*mut [u8]` [INFO] [stdout] --> src/scheme.rs:358:26 [INFO] [stdout] | [INFO] [stdout] 358 | payload: slice::from_raw_parts_mut(b as *mut u8, c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace_with: `std::ptr::slice_from_raw_parts_mut(b as *mut u8, c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_slice_from_raw_parts [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly casting the result of `from_raw_parts_mut` to `*mut [u8]` [INFO] [stdout] --> src/scheme.rs:364:26 [INFO] [stdout] | [INFO] [stdout] 364 | payload: slice::from_raw_parts_mut(b as *mut u8, c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace_with: `std::ptr::slice_from_raw_parts_mut(b as *mut u8, c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_slice_from_raw_parts [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly casting the result of `from_raw_parts_mut` to `*mut [u8]` [INFO] [stdout] --> src/scheme.rs:370:22 [INFO] [stdout] | [INFO] [stdout] 370 | buf: slice::from_raw_parts_mut(b as *mut u8, c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace_with: `std::ptr::slice_from_raw_parts_mut(b as *mut u8, c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_slice_from_raw_parts [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/wrappers.rs:210:25 [INFO] [stdout] | [INFO] [stdout] 210 | Err(err) => return Err(LError::from(err).into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 210 - Err(err) => return Err(LError::from(err).into()), [INFO] [stdout] 210 + Err(err) => Err(LError::from(err).into()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scheme.rs:540:17 [INFO] [stdout] | [INFO] [stdout] 540 | return SchemeResponse::Opened(res); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 540 - return SchemeResponse::Opened(res); [INFO] [stdout] 540 + SchemeResponse::Opened(res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scheme.rs:548:17 [INFO] [stdout] | [INFO] [stdout] 548 | return SchemeResponse::Opened(res); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 548 - return SchemeResponse::Opened(res); [INFO] [stdout] 548 + SchemeResponse::Opened(res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scheme.rs:619:21 [INFO] [stdout] | [INFO] [stdout] 619 | return resp; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 619 - return resp; [INFO] [stdout] 619 + resp [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scheme.rs:638:17 [INFO] [stdout] | [INFO] [stdout] 638 | return SchemeResponse::Opened(res); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 638 - return SchemeResponse::Opened(res); [INFO] [stdout] 638 + SchemeResponse::Opened(res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:538:21 [INFO] [stdout] | [INFO] [stdout] 538 | &caller, [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:543:64 [INFO] [stdout] | [INFO] [stdout] 543 | .unlinkat(req.fd, req.path(), req.inner.flags, &caller) [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:547:52 [INFO] [stdout] | [INFO] [stdout] 547 | let res = s.dup(req.fd, req.buf(), &caller); [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:554:54 [INFO] [stdout] | [INFO] [stdout] 554 | s.read(fd, req.buf(), offset, flags, &caller).into() [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:557:66 [INFO] [stdout] | [INFO] [stdout] 557 | .write(req.fd, req.buf(), req.offset, req.flags, &caller) [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:561:49 [INFO] [stdout] | [INFO] [stdout] 561 | Op::Fsize { fd, .. } => s.fsize(fd, &caller).map(|l| l as usize).into(), [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:563:71 [INFO] [stdout] | [INFO] [stdout] 563 | Op::Fchmod { fd, new_mode, .. } => s.fchmod(fd, new_mode, &caller).map(|()| 0).into(), [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:569:49 [INFO] [stdout] | [INFO] [stdout] 569 | } => s.fchown(fd, new_uid, new_gid, &caller).map(|()| 0).into(), [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:570:69 [INFO] [stdout] | [INFO] [stdout] 570 | Op::Fcntl { fd, cmd, arg, .. } => s.fcntl(fd, cmd, arg, &caller).into(), [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual slice size calculation [INFO] [stdout] --> src/lib.rs:155:17 [INFO] [stdout] | [INFO] [stdout] 155 | dst_fds.len() * mem::size_of::(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::mem::size_of_val(dst_fds)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_slice_size_calculation [INFO] [stdout] = note: `#[warn(clippy::manual_slice_size_calculation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:572:41 [INFO] [stdout] | [INFO] [stdout] 572 | s.fevent(fd, req_flags, &caller).map(|f| f.bits()).into() [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:574:62 [INFO] [stdout] | [INFO] [stdout] 574 | Op::Flink(ref req) => s.flink(req.fd, req.buf(), &caller).into(), [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:575:66 [INFO] [stdout] | [INFO] [stdout] 575 | Op::Fpath(ref mut req) => s.fpath(req.fd, req.buf(), &caller).into(), [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:576:66 [INFO] [stdout] | [INFO] [stdout] 576 | Op::Frename(ref req) => s.frename(req.fd, req.buf(), &caller).into(), [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:577:66 [INFO] [stdout] | [INFO] [stdout] 577 | Op::Fstat(ref mut req) => s.fstat(req.fd, req.buf(), &caller).map(|()| 0).into(), [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual slice size calculation [INFO] [stdout] --> src/lib.rs:192:17 [INFO] [stdout] | [INFO] [stdout] 192 | fds.len() * mem::size_of::(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::mem::size_of_val(fds)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_slice_size_calculation [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:578:72 [INFO] [stdout] | [INFO] [stdout] 578 | Op::FstatVfs(ref mut req) => s.fstatvfs(req.fd, req.buf(), &caller).map(|()| 0).into(), [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:579:49 [INFO] [stdout] | [INFO] [stdout] 579 | Op::Fsync { fd, .. } => s.fsync(fd, &caller).map(|()| 0).into(), [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:580:73 [INFO] [stdout] | [INFO] [stdout] 580 | Op::Ftruncate { fd, new_sz, .. } => s.ftruncate(fd, new_sz, &caller).map(|()| 0).into(), [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:581:68 [INFO] [stdout] | [INFO] [stdout] 581 | Op::Futimens(ref req) => s.futimens(req.fd, req.buf(), &caller).map(|()| 0).into(), [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:589:54 [INFO] [stdout] | [INFO] [stdout] 589 | } => s.mmap_prep(fd, offset, len, flags, &caller).into(), [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:596:51 [INFO] [stdout] | [INFO] [stdout] 596 | } => s.munmap(fd, offset, len, flags, &caller).map(|()| 0).into(), [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:601:47 [INFO] [stdout] | [INFO] [stdout] 601 | s.call(fd, payload, metadata, &caller).into() [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:617:21 [INFO] [stdout] | [INFO] [stdout] 617 | &caller, [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:621:87 [INFO] [stdout] | [INFO] [stdout] 621 | s.translate_std_fs_call_sync(fd, kind, payload, std_fs_call_meta, &caller) [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe function's docs are missing a `# Safety` section [INFO] [stdout] --> src/lib.rs:277:5 [INFO] [stdout] | [INFO] [stdout] 277 | pub unsafe fn from_fd(fd: libredox::Fd) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] = note: `#[warn(clippy::missing_safety_doc)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::result::Result` [INFO] [stdout] --> src/scheme.rs:665:17 [INFO] [stdout] | [INFO] [stdout] 665 | / s.unlinkat(req.fd, req.path(), req.inner.flags, &caller) [INFO] [stdout] 666 | | .await [INFO] [stdout] 667 | | .map(|()| 0) [INFO] [stdout] 668 | | .into(), [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 665 ~ s.unlinkat(req.fd, req.path(), req.inner.flags, &caller) [INFO] [stdout] 666 + .await [INFO] [stdout] 667 ~ .map(|()| 0), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe function's docs are missing a `# Safety` section [INFO] [stdout] --> src/lib.rs:468:1 [INFO] [stdout] | [INFO] [stdout] 468 | / pub unsafe fn write_responses( [INFO] [stdout] 469 | | socket: usize, [INFO] [stdout] 470 | | buf: &[Response], [INFO] [stdout] 471 | | behavior: SignalBehavior, [INFO] [stdout] 472 | | ) -> Result { [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scheme.rs:997:59 [INFO] [stdout] | [INFO] [stdout] 997 | .std_fs_call(id, kind, payload, metadata, &ctx) [INFO] [stdout] | ^^^^ help: change this to: `ctx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `SchemeState` [INFO] [stdout] --> src/scheme.rs:1476:5 [INFO] [stdout] | [INFO] [stdout] 1476 | / pub fn new() -> Self { [INFO] [stdout] 1477 | | Self { [INFO] [stdout] 1478 | | flocks: LockSet::new(), [INFO] [stdout] 1479 | | } [INFO] [stdout] 1480 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 1475 + impl Default for SchemeState { [INFO] [stdout] 1476 + fn default() -> Self { [INFO] [stdout] 1477 + Self::new() [INFO] [stdout] 1478 + } [INFO] [stdout] 1479 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/scheme.rs:1580:38 [INFO] [stdout] | [INFO] [stdout] 1580 | payload[0] = lck.start as u64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `lck.start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/scheme.rs:1582:29 [INFO] [stdout] | [INFO] [stdout] 1582 | ... lck.len() as u64 | if lck.kind.is_exclusive() { 1 << 63 } else { 0 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `lck.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/wrappers.rs:48:25 [INFO] [stdout] | [INFO] [stdout] 48 | Err(err) => return Err(err), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - Err(err) => return Err(err), [INFO] [stdout] 48 + Err(err) => Err(err), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/wrappers.rs:210:25 [INFO] [stdout] | [INFO] [stdout] 210 | Err(err) => return Err(LError::from(err).into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 210 - Err(err) => return Err(LError::from(err).into()), [INFO] [stdout] 210 + Err(err) => Err(LError::from(err).into()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual slice size calculation [INFO] [stdout] --> src/lib.rs:155:17 [INFO] [stdout] | [INFO] [stdout] 155 | dst_fds.len() * mem::size_of::(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::mem::size_of_val(dst_fds)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_slice_size_calculation [INFO] [stdout] = note: `#[warn(clippy::manual_slice_size_calculation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual slice size calculation [INFO] [stdout] --> src/lib.rs:192:17 [INFO] [stdout] | [INFO] [stdout] 192 | fds.len() * mem::size_of::(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::mem::size_of_val(fds)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_slice_size_calculation [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe function's docs are missing a `# Safety` section [INFO] [stdout] --> src/lib.rs:277:5 [INFO] [stdout] | [INFO] [stdout] 277 | pub unsafe fn from_fd(fd: libredox::Fd) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] = note: `#[warn(clippy::missing_safety_doc)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe function's docs are missing a `# Safety` section [INFO] [stdout] --> src/lib.rs:468:1 [INFO] [stdout] | [INFO] [stdout] 468 | / pub unsafe fn write_responses( [INFO] [stdout] 469 | | socket: usize, [INFO] [stdout] 470 | | buf: &[Response], [INFO] [stdout] 471 | | behavior: SignalBehavior, [INFO] [stdout] 472 | | ) -> Result { [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.58s [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "99dece67c2ab1aeb3030d714a56957d46e02d3a6c19d5b14e10b4ca5543af9a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "99dece67c2ab1aeb3030d714a56957d46e02d3a6c19d5b14e10b4ca5543af9a6", kill_on_drop: false }` [INFO] [stdout] 99dece67c2ab1aeb3030d714a56957d46e02d3a6c19d5b14e10b4ca5543af9a6