[INFO] fetching crate redb_model_derive 0.12.1... [INFO] linting redb_model_derive-0.12.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate redb_model_derive 0.12.1 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate redb_model_derive 0.12.1 [INFO] finished tweaking crates.io crate redb_model_derive 0.12.1 [INFO] tweaked toml for crates.io crate redb_model_derive 0.12.1 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate redb_model_derive 0.12.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 13 packages to latest compatible versions [INFO] [stderr] Adding darling v0.20.11 (available: v0.23.0) [INFO] [stderr] Adding redb_model_trait v0.8.0 (available: v0.9.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `proc_macro` is deprecated in favor of `proc-macro` and will not work in the 2024 edition [INFO] [stderr] (in the `redb_model_derive` library target) [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded redb_model_trait v0.8.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7785f39ff97e44eb037c2dda809621309f840b4245e8368550c21fc553da86de [INFO] running `Command { std: "docker" "start" "-a" "7785f39ff97e44eb037c2dda809621309f840b4245e8368550c21fc553da86de", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7785f39ff97e44eb037c2dda809621309f840b4245e8368550c21fc553da86de", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7785f39ff97e44eb037c2dda809621309f840b4245e8368550c21fc553da86de", kill_on_drop: false }` [INFO] [stdout] 7785f39ff97e44eb037c2dda809621309f840b4245e8368550c21fc553da86de [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] db4a879233ccd040fb0c2829ab04af17f616ec4653f059e804afe81e1151a31a [INFO] running `Command { std: "docker" "start" "-a" "db4a879233ccd040fb0c2829ab04af17f616ec4653f059e804afe81e1151a31a", kill_on_drop: false }` [INFO] [stderr] warning: `proc_macro` is deprecated in favor of `proc-macro` and will not work in the 2024 edition [INFO] [stderr] (in the `redb_model_derive` library target) [INFO] [stderr] Checking unicode-ident v1.0.24 [INFO] [stderr] Compiling redb v2.6.3 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking ident_case v1.0.1 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking libc v0.2.183 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking proc-macro2 v1.0.106 [INFO] [stderr] Checking quote v1.0.45 [INFO] [stderr] Checking darling_core v0.20.11 [INFO] [stderr] Checking redb_model_trait v0.8.0 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Checking darling v0.20.11 [INFO] [stderr] Checking redb_model_derive v0.12.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/var.rs:21:23 [INFO] [stdout] | [INFO] [stdout] 21 | pub(crate) fn new(fields: I) -> Self [INFO] [stdout] | ^ [INFO] [stdout] 22 | where [INFO] [stdout] 23 | I: IntoIterator, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] = note: `#[warn(clippy::multiple_bound_locations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/var.rs:21:23 [INFO] [stdout] | [INFO] [stdout] 21 | pub(crate) fn new(fields: I) -> Self [INFO] [stdout] | ^ [INFO] [stdout] 22 | where [INFO] [stdout] 23 | I: IntoIterator, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] = note: `#[warn(clippy::multiple_bound_locations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `ident_ref` is never used [INFO] [stdout] --> src/args/entry.rs:46:12 [INFO] [stdout] | [INFO] [stdout] 34 | impl EntryArgs { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 46 | pub fn ident_ref(&self) -> Expr { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/args/entry.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | &self.ident.as_ref().expect("Named struct") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.ident.as_ref().expect("Named struct")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `from_*` usually take no `self` [INFO] [stdout] --> src/args/entry.rs:86:20 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn from_op(&self) -> Expr { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `ident_ref` is never used [INFO] [stdout] --> src/args/entry.rs:46:12 [INFO] [stdout] | [INFO] [stdout] 34 | impl EntryArgs { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 46 | pub fn ident_ref(&self) -> Expr { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `into_*` usually take `self` by value [INFO] [stdout] --> src/args/entry.rs:120:20 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn into_op(&self) -> Expr { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/args/entry.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | &self.ident.as_ref().expect("Named struct") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.ident.as_ref().expect("Named struct")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `from_*` usually take no `self` [INFO] [stdout] --> src/args/entry.rs:86:20 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn from_op(&self) -> Expr { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `into_*` usually take `self` by value [INFO] [stdout] --> src/args/entry.rs:120:20 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn into_op(&self) -> Expr { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/model.rs:24:40 [INFO] [stdout] | [INFO] [stdout] 24 | let table_ty = args.table_type.unwrap_or(Default::default()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/var.rs:30:19 [INFO] [stdout] | [INFO] [stdout] 30 | Self::new(a.iter().chain(b.iter()).map(|var| *var)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `a.iter().chain(b.iter()).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `from_*` usually take no `self` [INFO] [stdout] --> src/var.rs:85:32 [INFO] [stdout] | [INFO] [stdout] 85 | pub(crate) fn from_methods(&'a self) -> impl ExactSizeIterator + 'a { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `into_*` usually take `self` by value [INFO] [stdout] --> src/var.rs:90:32 [INFO] [stdout] | [INFO] [stdout] 90 | pub(crate) fn into_methods(&'a self) -> impl ExactSizeIterator + 'a { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_from.rs:12:40 [INFO] [stdout] | [INFO] [stdout] 12 | let from_values = impl_from_values(&m, &k, &v); [INFO] [stdout] | ^^ help: change this to: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_from.rs:12:44 [INFO] [stdout] | [INFO] [stdout] 12 | let from_values = impl_from_values(&m, &k, &v); [INFO] [stdout] | ^^ help: change this to: `k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_from.rs:12:48 [INFO] [stdout] | [INFO] [stdout] 12 | let from_values = impl_from_values(&m, &k, &v); [INFO] [stdout] | ^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_from.rs:13:40 [INFO] [stdout] | [INFO] [stdout] 13 | let from_guards = impl_from_guards(&m, &k, &v); [INFO] [stdout] | ^^ help: change this to: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_from.rs:13:44 [INFO] [stdout] | [INFO] [stdout] 13 | let from_guards = impl_from_guards(&m, &k, &v); [INFO] [stdout] | ^^ help: change this to: `k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_from.rs:13:48 [INFO] [stdout] | [INFO] [stdout] 13 | let from_guards = impl_from_guards(&m, &k, &v); [INFO] [stdout] | ^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/model.rs:24:40 [INFO] [stdout] | [INFO] [stdout] 24 | let table_ty = args.table_type.unwrap_or(Default::default()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/var.rs:30:19 [INFO] [stdout] | [INFO] [stdout] 30 | Self::new(a.iter().chain(b.iter()).map(|var| *var)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `a.iter().chain(b.iter()).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `from_*` usually take no `self` [INFO] [stdout] --> src/var.rs:85:32 [INFO] [stdout] | [INFO] [stdout] 85 | pub(crate) fn from_methods(&'a self) -> impl ExactSizeIterator + 'a { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `into_*` usually take `self` by value [INFO] [stdout] --> src/var.rs:90:32 [INFO] [stdout] | [INFO] [stdout] 90 | pub(crate) fn into_methods(&'a self) -> impl ExactSizeIterator + 'a { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_from.rs:12:40 [INFO] [stdout] | [INFO] [stdout] 12 | let from_values = impl_from_values(&m, &k, &v); [INFO] [stdout] | ^^ help: change this to: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_from.rs:12:44 [INFO] [stdout] | [INFO] [stdout] 12 | let from_values = impl_from_values(&m, &k, &v); [INFO] [stdout] | ^^ help: change this to: `k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_from.rs:12:48 [INFO] [stdout] | [INFO] [stdout] 12 | let from_values = impl_from_values(&m, &k, &v); [INFO] [stdout] | ^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_from.rs:13:40 [INFO] [stdout] | [INFO] [stdout] 13 | let from_guards = impl_from_guards(&m, &k, &v); [INFO] [stdout] | ^^ help: change this to: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_from.rs:13:44 [INFO] [stdout] | [INFO] [stdout] 13 | let from_guards = impl_from_guards(&m, &k, &v); [INFO] [stdout] | ^^ help: change this to: `k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_from.rs:13:48 [INFO] [stdout] | [INFO] [stdout] 13 | let from_guards = impl_from_guards(&m, &k, &v); [INFO] [stdout] | ^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_model_ext.rs:14:37 [INFO] [stdout] | [INFO] [stdout] 14 | let redb_alias = def_redb_alias(&k, &v); [INFO] [stdout] | ^^ help: change this to: `k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_model_ext.rs:14:41 [INFO] [stdout] | [INFO] [stdout] 14 | let redb_alias = def_redb_alias(&k, &v); [INFO] [stdout] | ^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_model_ext.rs:15:39 [INFO] [stdout] | [INFO] [stdout] 15 | let model_alias = def_model_alias(&k, &v); [INFO] [stdout] | ^^ help: change this to: `k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_model_ext.rs:15:43 [INFO] [stdout] | [INFO] [stdout] 15 | let model_alias = def_model_alias(&k, &v); [INFO] [stdout] | ^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_model_ext.rs:17:39 [INFO] [stdout] | [INFO] [stdout] 17 | let from_values = def_from_values(&m, &k, &v); [INFO] [stdout] | ^^ help: change this to: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_model_ext.rs:17:43 [INFO] [stdout] | [INFO] [stdout] 17 | let from_values = def_from_values(&m, &k, &v); [INFO] [stdout] | ^^ help: change this to: `k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_model_ext.rs:17:47 [INFO] [stdout] | [INFO] [stdout] 17 | let from_values = def_from_values(&m, &k, &v); [INFO] [stdout] | ^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_model_ext.rs:18:39 [INFO] [stdout] | [INFO] [stdout] 18 | let from_guards = def_from_guards(&m, &k, &v); [INFO] [stdout] | ^^ help: change this to: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_model_ext.rs:18:43 [INFO] [stdout] | [INFO] [stdout] 18 | let from_guards = def_from_guards(&m, &k, &v); [INFO] [stdout] | ^^ help: change this to: `k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_model_ext.rs:18:47 [INFO] [stdout] | [INFO] [stdout] 18 | let from_guards = def_from_guards(&m, &k, &v); [INFO] [stdout] | ^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_model_ext.rs:19:53 [INFO] [stdout] | [INFO] [stdout] 19 | let from_key_and_guard = def_from_key_and_guard(&m, &k, &v); [INFO] [stdout] | ^^ help: change this to: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_model_ext.rs:19:57 [INFO] [stdout] | [INFO] [stdout] 19 | let from_key_and_guard = def_from_key_and_guard(&m, &k, &v); [INFO] [stdout] | ^^ help: change this to: `k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_model_ext.rs:19:61 [INFO] [stdout] | [INFO] [stdout] 19 | let from_key_and_guard = def_from_key_and_guard(&m, &k, &v); [INFO] [stdout] | ^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_model_ext.rs:20:29 [INFO] [stdout] | [INFO] [stdout] 20 | let as_key = def_as_key(&k); [INFO] [stdout] | ^^ help: change this to: `k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_model_ext.rs:21:33 [INFO] [stdout] | [INFO] [stdout] 21 | let as_value = def_as_value(&v); [INFO] [stdout] | ^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_model_ext.rs:22:42 [INFO] [stdout] | [INFO] [stdout] 22 | let as_values = def_as_key_and_value(&k, &v); [INFO] [stdout] | ^^ help: change this to: `k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_model_ext.rs:22:46 [INFO] [stdout] | [INFO] [stdout] 22 | let as_values = def_as_key_and_value(&k, &v); [INFO] [stdout] | ^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_model_ext.rs:14:37 [INFO] [stdout] | [INFO] [stdout] 14 | let redb_alias = def_redb_alias(&k, &v); [INFO] [stdout] | ^^ help: change this to: `k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_model_ext.rs:14:41 [INFO] [stdout] | [INFO] [stdout] 14 | let redb_alias = def_redb_alias(&k, &v); [INFO] [stdout] | ^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_model_ext.rs:15:39 [INFO] [stdout] | [INFO] [stdout] 15 | let model_alias = def_model_alias(&k, &v); [INFO] [stdout] | ^^ help: change this to: `k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_model_ext.rs:15:43 [INFO] [stdout] | [INFO] [stdout] 15 | let model_alias = def_model_alias(&k, &v); [INFO] [stdout] | ^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_model_ext.rs:17:39 [INFO] [stdout] | [INFO] [stdout] 17 | let from_values = def_from_values(&m, &k, &v); [INFO] [stdout] | ^^ help: change this to: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_model_ext.rs:17:43 [INFO] [stdout] | [INFO] [stdout] 17 | let from_values = def_from_values(&m, &k, &v); [INFO] [stdout] | ^^ help: change this to: `k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_model_ext.rs:17:47 [INFO] [stdout] | [INFO] [stdout] 17 | let from_values = def_from_values(&m, &k, &v); [INFO] [stdout] | ^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_model_ext.rs:18:39 [INFO] [stdout] | [INFO] [stdout] 18 | let from_guards = def_from_guards(&m, &k, &v); [INFO] [stdout] | ^^ help: change this to: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_model_ext.rs:18:43 [INFO] [stdout] | [INFO] [stdout] 18 | let from_guards = def_from_guards(&m, &k, &v); [INFO] [stdout] | ^^ help: change this to: `k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_model_ext.rs:18:47 [INFO] [stdout] | [INFO] [stdout] 18 | let from_guards = def_from_guards(&m, &k, &v); [INFO] [stdout] | ^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_model_ext.rs:19:53 [INFO] [stdout] | [INFO] [stdout] 19 | let from_key_and_guard = def_from_key_and_guard(&m, &k, &v); [INFO] [stdout] | ^^ help: change this to: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_model_ext.rs:19:57 [INFO] [stdout] | [INFO] [stdout] 19 | let from_key_and_guard = def_from_key_and_guard(&m, &k, &v); [INFO] [stdout] | ^^ help: change this to: `k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_model_ext.rs:19:61 [INFO] [stdout] | [INFO] [stdout] 19 | let from_key_and_guard = def_from_key_and_guard(&m, &k, &v); [INFO] [stdout] | ^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_model_ext.rs:20:29 [INFO] [stdout] | [INFO] [stdout] 20 | let as_key = def_as_key(&k); [INFO] [stdout] | ^^ help: change this to: `k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_model_ext.rs:21:33 [INFO] [stdout] | [INFO] [stdout] 21 | let as_value = def_as_value(&v); [INFO] [stdout] | ^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_model_ext.rs:22:42 [INFO] [stdout] | [INFO] [stdout] 22 | let as_values = def_as_key_and_value(&k, &v); [INFO] [stdout] | ^^ help: change this to: `k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impl_model_ext.rs:22:46 [INFO] [stdout] | [INFO] [stdout] 22 | let as_values = def_as_key_and_value(&k, &v); [INFO] [stdout] | ^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 67 | if !(Some(true) == impl_ext) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(Some(true) != impl_ext)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/lib.rs:40:21 [INFO] [stdout] | [INFO] [stdout] 40 | .into_iter() [INFO] [stdout] | _____________________^ [INFO] [stdout] 41 | | .map(|mut arg| { [INFO] [stdout] 42 | | #[cfg(any(feature = "uuid", feature = "secrecy"))] [INFO] [stdout] 43 | | if let Some(op) = arg._external_type_op() { [INFO] [stdout] ... | [INFO] [stdout] 46 | | arg [INFO] [stdout] 47 | | }) [INFO] [stdout] | |__________^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] = note: `#[warn(clippy::map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 67 | if !(Some(true) == impl_ext) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(Some(true) != impl_ext)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/lib.rs:40:21 [INFO] [stdout] | [INFO] [stdout] 40 | .into_iter() [INFO] [stdout] | _____________________^ [INFO] [stdout] 41 | | .map(|mut arg| { [INFO] [stdout] 42 | | #[cfg(any(feature = "uuid", feature = "secrecy"))] [INFO] [stdout] 43 | | if let Some(op) = arg._external_type_op() { [INFO] [stdout] ... | [INFO] [stdout] 46 | | arg [INFO] [stdout] 47 | | }) [INFO] [stdout] | |__________^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] = note: `#[warn(clippy::map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.56s [INFO] running `Command { std: "docker" "inspect" "db4a879233ccd040fb0c2829ab04af17f616ec4653f059e804afe81e1151a31a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "db4a879233ccd040fb0c2829ab04af17f616ec4653f059e804afe81e1151a31a", kill_on_drop: false }` [INFO] [stdout] db4a879233ccd040fb0c2829ab04af17f616ec4653f059e804afe81e1151a31a