[INFO] fetching crate recrypt 0.16.0... [INFO] linting recrypt-0.16.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate recrypt 0.16.0 into /workspace/builds/worker-2-tc1/source [INFO] removed /workspace/builds/worker-2-tc1/source/.cargo/config.toml [INFO] removed /workspace/builds/worker-2-tc1/source/rust-toolchain.toml [INFO] started tweaking crates.io crate recrypt 0.16.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate recrypt 0.16.0 [INFO] tweaked toml for crates.io crate recrypt 0.16.0 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate recrypt 0.16.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate recrypt 0.16.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded digest v0.11.1 [INFO] [stderr] Downloaded signature v3.0.0-rc.10 [INFO] [stderr] Downloaded ed25519 v3.0.0-rc.4 [INFO] [stderr] Downloaded rand_chacha v0.10.0 [INFO] [stderr] Downloaded rand_core v0.9.4 [INFO] [stderr] Downloaded gridiron v0.12.2 [INFO] [stderr] Downloaded ed25519-dalek v3.0.0-pre.6 [INFO] [stderr] Downloaded curve25519-dalek v5.0.0-pre.6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8573ca275af8e606721db811d29efeda210e813916b04cdabf17223a4ac2ffa3 [INFO] running `Command { std: "docker" "start" "-a" "8573ca275af8e606721db811d29efeda210e813916b04cdabf17223a4ac2ffa3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8573ca275af8e606721db811d29efeda210e813916b04cdabf17223a4ac2ffa3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8573ca275af8e606721db811d29efeda210e813916b04cdabf17223a4ac2ffa3", kill_on_drop: false }` [INFO] [stdout] 8573ca275af8e606721db811d29efeda210e813916b04cdabf17223a4ac2ffa3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 84e2c5bd38e5131035eae423f2b1668874d3276bf33446f9908c328660073a25 [INFO] running `Command { std: "docker" "start" "-a" "84e2c5bd38e5131035eae423f2b1668874d3276bf33446f9908c328660073a25", kill_on_drop: false }` [INFO] [stderr] Checking cfg-if v1.0.4 [INFO] [stderr] Compiling zerocopy v0.8.33 [INFO] [stderr] Compiling find-msvc-tools v0.1.7 [INFO] [stderr] Checking rand_core v0.10.0 [INFO] [stderr] Compiling zmij v1.0.13 [INFO] [stderr] Compiling libc v0.2.180 [INFO] [stderr] Compiling typenum v1.19.0 [INFO] [stderr] Compiling zerocopy-derive v0.8.33 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Checking cpufeatures v0.2.17 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Compiling curve25519-dalek v5.0.0-pre.6 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling getrandom v0.4.2 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking regex-syntax v0.8.8 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Compiling cc v1.2.52 [INFO] [stderr] Compiling rayon-core v1.13.0 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking once_cell v1.21.3 [INFO] [stderr] Checking signature v3.0.0-rc.10 [INFO] [stderr] Checking clap_lex v0.7.6 [INFO] [stderr] Checking cpufeatures v0.3.0 [INFO] [stderr] Checking memchr v2.7.6 [INFO] [stderr] Checking fastrand v2.3.0 [INFO] [stderr] Checking anstyle v1.0.13 [INFO] [stderr] Checking itoa v1.0.17 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking plotters-backend v0.3.7 [INFO] [stderr] Checking hybrid-array v0.4.7 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking clap_builder v4.5.54 [INFO] [stderr] Checking chacha20 v0.10.0 [INFO] [stderr] Checking ed25519 v3.0.0-rc.4 [INFO] [stderr] Checking crossbeam-deque v0.8.6 [INFO] [stderr] Checking plotters-svg v0.3.7 [INFO] [stderr] Checking wait-timeout v0.2.1 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking rand_core v0.9.4 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking bit-vec v0.8.0 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking rand_xorshift v0.4.0 [INFO] [stderr] Checking bit-set v0.8.0 [INFO] [stderr] Checking block-buffer v0.12.0 [INFO] [stderr] Checking crypto-common v0.2.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking rand v0.10.0 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking page_size v0.6.0 [INFO] [stderr] Checking gridiron v0.12.2 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Compiling clear_on_drop v0.2.5 [INFO] [stderr] Compiling alloca v0.4.0 [INFO] [stderr] Checking oorandom v11.1.5 [INFO] [stderr] Checking unarray v0.1.4 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking digest v0.11.1 [INFO] [stderr] Checking tempfile v3.24.0 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking clap v4.5.54 [INFO] [stderr] Checking sha2 v0.11.0-rc.5 [INFO] [stderr] Checking rusty-fork v0.3.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking rand_chacha v0.10.0 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking criterion-plot v0.8.1 [INFO] [stderr] Checking proptest v1.9.0 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking ed25519-dalek v3.0.0-pre.6 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Checking criterion v0.8.1 [INFO] [stderr] Checking recrypt v0.16.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/internal/fp.rs:98:1 [INFO] [stdout] | [INFO] [stdout] 98 | / fp62!( [INFO] [stdout] 99 | | fr_256, // Name of mod [INFO] [stdout] 100 | | Fr256, // Name of class [INFO] [stdout] 101 | | 256, // Number of bits for prime [INFO] [stdout] ... | [INFO] [stdout] 143 | | 388461543364775519 [INFO] [stdout] 144 | | ); [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] = note: this warning originates in the macro `fp62` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: suspicious use of `|` in `AddAssign` impl [INFO] [stdout] --> src/internal/fp.rs:98:1 [INFO] [stdout] | [INFO] [stdout] 98 | / fp62!( [INFO] [stdout] 99 | | fr_256, // Name of mod [INFO] [stdout] 100 | | Fr256, // Name of class [INFO] [stdout] 101 | | 256, // Number of bits for prime [INFO] [stdout] ... | [INFO] [stdout] 143 | | 388461543364775519 [INFO] [stdout] 144 | | ); [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stdout] = note: `#[warn(clippy::suspicious_op_assign_impl)]` on by default [INFO] [stdout] = note: this warning originates in the macro `fp62` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: suspicious use of `|` in `AddAssign` impl [INFO] [stdout] --> src/internal/fp.rs:98:1 [INFO] [stdout] | [INFO] [stdout] 98 | / fp62!( [INFO] [stdout] 99 | | fr_256, // Name of mod [INFO] [stdout] 100 | | Fr256, // Name of class [INFO] [stdout] 101 | | 256, // Number of bits for prime [INFO] [stdout] ... | [INFO] [stdout] 143 | | 388461543364775519 [INFO] [stdout] 144 | | ); [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stdout] = note: this warning originates in the macro `fp62` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/internal/fp.rs:147:1 [INFO] [stdout] | [INFO] [stdout] 147 | / fp62!( [INFO] [stdout] 148 | | fr_480, // Name of mod [INFO] [stdout] 149 | | Fr480, // Name of class [INFO] [stdout] 150 | | 480, // Number of bits for prime [INFO] [stdout] ... | [INFO] [stdout] 204 | | 124432205055238639 [INFO] [stdout] 205 | | ); [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: this warning originates in the macro `fp62` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: suspicious use of `|` in `AddAssign` impl [INFO] [stdout] --> src/internal/fp.rs:147:1 [INFO] [stdout] | [INFO] [stdout] 147 | / fp62!( [INFO] [stdout] 148 | | fr_480, // Name of mod [INFO] [stdout] 149 | | Fr480, // Name of class [INFO] [stdout] 150 | | 480, // Number of bits for prime [INFO] [stdout] ... | [INFO] [stdout] 204 | | 124432205055238639 [INFO] [stdout] 205 | | ); [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stdout] = note: this warning originates in the macro `fp62` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: suspicious use of `|` in `AddAssign` impl [INFO] [stdout] --> src/internal/fp.rs:147:1 [INFO] [stdout] | [INFO] [stdout] 147 | / fp62!( [INFO] [stdout] 148 | | fr_480, // Name of mod [INFO] [stdout] 149 | | Fr480, // Name of class [INFO] [stdout] 150 | | 480, // Number of bits for prime [INFO] [stdout] ... | [INFO] [stdout] 204 | | 124432205055238639 [INFO] [stdout] 205 | | ); [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stdout] = note: this warning originates in the macro `fp62` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/internal/fp.rs:330:27 [INFO] [stdout] | [INFO] [stdout] 330 | let even_hex_str = if hex_str.len() % 2 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!hex_str.len().is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/internal/fp.rs:353:27 [INFO] [stdout] | [INFO] [stdout] 353 | let even_hex_str = if hex_str.len() % 2 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!hex_str.len().is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: suspicious use of `*` in `Div` impl [INFO] [stdout] --> src/internal/fp12elem.rs:153:14 [INFO] [stdout] | [INFO] [stdout] 153 | self * other.inv() [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stdout] = note: `#[warn(clippy::suspicious_arithmetic_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (12/7) [INFO] [stdout] --> src/internal/fp12elem.rs:296:5 [INFO] [stdout] | [INFO] [stdout] 296 | / pub fn create_from_t( [INFO] [stdout] 297 | | one: T, [INFO] [stdout] 298 | | two: T, [INFO] [stdout] 299 | | three: T, [INFO] [stdout] ... | [INFO] [stdout] 308 | | twelve: T, [INFO] [stdout] 309 | | ) -> Fp12Elem { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/internal/fp12elem.rs:358:27 [INFO] [stdout] | [INFO] [stdout] 358 | pub fn to_bytes_fp256(&self) -> [u8; Fp12Elem::::ENCODED_SIZE_BYTES] { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/internal/fp12elem.rs:366:27 [INFO] [stdout] | [INFO] [stdout] 366 | pub fn to_bytes_fp480(&self) -> [u8; Fp12Elem::::ENCODED_SIZE_BYTES] { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: suspicious use of `*` in `Div` impl [INFO] [stdout] --> src/internal/fp2elem.rs:149:14 [INFO] [stdout] | [INFO] [stdout] 149 | self * other.inv() [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: suspicious use of `*` in `Div` impl [INFO] [stdout] --> src/internal/fp6elem.rs:249:14 [INFO] [stdout] | [INFO] [stdout] 249 | self * other.inv() [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual slice size calculation [INFO] [stdout] --> src/internal/memlock.rs:116:5 [INFO] [stdout] | [INFO] [stdout] 116 | slice.len() * std::mem::size_of::() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::mem::size_of_val(slice)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_slice_size_calculation [INFO] [stdout] = note: `#[warn(clippy::manual_slice_size_calculation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/internal/schnorr.rs:148:8 [INFO] [stdout] | [INFO] [stdout] 148 | /// then None should be passed here. [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] = note: `#[warn(clippy::doc_overindented_list_items)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/internal/mod.rs:88:31 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn to_byte_vectors_32(&self) -> Option<([u8; 32], [u8; 32])> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/internal/mod.rs:96:31 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn to_byte_vectors_60(&self) -> Option<([u8; 60], [u8; 60])> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/internal/mod.rs:520:1 [INFO] [stdout] | [INFO] [stdout] 520 | / pub fn encrypt( [INFO] [stdout] 521 | | to_public_key: PublicKey, [INFO] [stdout] 522 | | plaintext: Fp12Elem, // @clintfred can this be any fp12? or an rth root? [INFO] [stdout] 523 | | encrypting_key: PrivateKey, [INFO] [stdout] ... | [INFO] [stdout] 530 | | where [INFO] [stdout] 531 | | T: ExtensionField + PairingConfig + BitRepr + Hashable + ConstantSwap + Clone, [INFO] [stdout] | |____________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/internal/mod.rs:778:1 [INFO] [stdout] | [INFO] [stdout] 778 | / pub fn generate_reencryption_key( [INFO] [stdout] 779 | | from_private_key: PrivateKey, [INFO] [stdout] 780 | | to_public_key: PublicKey, [INFO] [stdout] 781 | | reencryption_private_key: PrivateKey, [INFO] [stdout] ... | [INFO] [stdout] 797 | | H: Sha256Hashing, [INFO] [stdout] 798 | | S: Ed25519Signing, [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/internal/mod.rs:931:1 [INFO] [stdout] | [INFO] [stdout] 931 | / pub fn reencrypt( [INFO] [stdout] 932 | | signed_reencryption_key: SignedValue>, [INFO] [stdout] 933 | | signed_encrypted_value: SignedValue>, [INFO] [stdout] 934 | | rand_re_priv_key: PrivateKey, [INFO] [stdout] ... | [INFO] [stdout] 950 | | H: Sha256Hashing, [INFO] [stdout] 951 | | S: Ed25519Signing, [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/api.rs:225:1 [INFO] [stdout] | [INFO] [stdout] 225 | / pub enum EncryptedValue { [INFO] [stdout] 226 | | /// Value which has been encrypted, but not transformed [INFO] [stdout] 227 | | /// `ephemeral_public_key` - public key of the ephemeral private key that was used to encrypt [INFO] [stdout] 228 | | /// `encrypted_message` - encrypted symmetric key [INFO] [stdout] ... | [INFO] [stdout] 232 | | / EncryptedOnceValue { [INFO] [stdout] 233 | | | ephemeral_public_key: PublicKey, [INFO] [stdout] 234 | | | encrypted_message: EncryptedMessage, [INFO] [stdout] 235 | | | auth_hash: AuthHash, [INFO] [stdout] 236 | | | public_signing_key: PublicSigningKey, [INFO] [stdout] 237 | | | signature: Ed25519Signature, [INFO] [stdout] 238 | | | }, [INFO] [stdout] | | |_____- the second-largest variant contains at least 696 bytes [INFO] [stdout] ... | [INFO] [stdout] 246 | | / TransformedValue { [INFO] [stdout] 247 | | | ephemeral_public_key: PublicKey, [INFO] [stdout] 248 | | | encrypted_message: EncryptedMessage, [INFO] [stdout] 249 | | | auth_hash: AuthHash, [INFO] [stdout] ... | | [INFO] [stdout] 252 | | | signature: Ed25519Signature, [INFO] [stdout] 253 | | | }, [INFO] [stdout] | | |_____- the largest variant contains at least 4016 bytes [INFO] [stdout] 254 | | } [INFO] [stdout] | |___^ the entire enum is at least 4016 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 250 - transform_blocks: NonEmptyVec, [INFO] [stdout] 250 + transform_blocks: Box>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/api.rs:618:8 [INFO] [stdout] | [INFO] [stdout] 618 | /// None if no augmentation was done. [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using ` ` (3 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/api_480.rs:225:1 [INFO] [stdout] | [INFO] [stdout] 225 | / pub enum EncryptedValue { [INFO] [stdout] 226 | | /// Value which has been encrypted, but not transformed [INFO] [stdout] 227 | | /// `ephemeral_public_key` - public key of the ephemeral private key that was used to encrypt [INFO] [stdout] 228 | | /// `encrypted_message` - encrypted symmetric key [INFO] [stdout] ... | [INFO] [stdout] 232 | | / EncryptedOnceValue { [INFO] [stdout] 233 | | | ephemeral_public_key: PublicKey, [INFO] [stdout] 234 | | | encrypted_message: EncryptedMessage, [INFO] [stdout] 235 | | | auth_hash: AuthHash, [INFO] [stdout] 236 | | | public_signing_key: PublicSigningKey, [INFO] [stdout] 237 | | | signature: Ed25519Signature, [INFO] [stdout] 238 | | | }, [INFO] [stdout] | | |_____- the second-largest variant contains at least 1160 bytes [INFO] [stdout] ... | [INFO] [stdout] 246 | | / TransformedValue { [INFO] [stdout] 247 | | | ephemeral_public_key: PublicKey, [INFO] [stdout] 248 | | | encrypted_message: EncryptedMessage, [INFO] [stdout] 249 | | | auth_hash: AuthHash, [INFO] [stdout] ... | | [INFO] [stdout] 252 | | | signature: Ed25519Signature, [INFO] [stdout] 253 | | | }, [INFO] [stdout] | | |_____- the largest variant contains at least 6704 bytes [INFO] [stdout] 254 | | } [INFO] [stdout] | |___^ the entire enum is at least 6704 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 250 - transform_blocks: NonEmptyVec, [INFO] [stdout] 250 + transform_blocks: Box>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/api_480.rs:619:8 [INFO] [stdout] | [INFO] [stdout] 619 | /// None if no augmentation was done. [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using ` ` (3 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/internal/homogeneouspoint.rs:711:40 [INFO] [stdout] | [INFO] [stdout] 711 | TwistedHPoint { x: x, y: y, z: zero()}, [INFO] [stdout] | ^^^^ help: replace it with: `x` [INFO] [stdout] ... [INFO] [stdout] 745 | / fp_proptest!( [INFO] [stdout] 746 | | Monty256, [INFO] [stdout] 747 | | arb_fp256, [INFO] [stdout] 748 | | arb_homogeneous_256, [INFO] [stdout] 749 | | arb_homogeneous_fp2_256, [INFO] [stdout] 750 | | fp256 [INFO] [stdout] 751 | | ); [INFO] [stdout] | |_____- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] = note: this warning originates in the macro `fp_proptest` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/internal/homogeneouspoint.rs:711:46 [INFO] [stdout] | [INFO] [stdout] 711 | TwistedHPoint { x: x, y: y, z: zero()}, [INFO] [stdout] | ^^^^ help: replace it with: `y` [INFO] [stdout] ... [INFO] [stdout] 745 | / fp_proptest!( [INFO] [stdout] 746 | | Monty256, [INFO] [stdout] 747 | | arb_fp256, [INFO] [stdout] 748 | | arb_homogeneous_256, [INFO] [stdout] 749 | | arb_homogeneous_fp2_256, [INFO] [stdout] 750 | | fp256 [INFO] [stdout] 751 | | ); [INFO] [stdout] | |_____- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: this warning originates in the macro `fp_proptest` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/internal/homogeneouspoint.rs:711:40 [INFO] [stdout] | [INFO] [stdout] 711 | TwistedHPoint { x: x, y: y, z: zero()}, [INFO] [stdout] | ^^^^ help: replace it with: `x` [INFO] [stdout] ... [INFO] [stdout] 752 | / fp_proptest!( [INFO] [stdout] 753 | | Monty480, [INFO] [stdout] 754 | | arb_fp480, [INFO] [stdout] 755 | | arb_homogeneous_480, [INFO] [stdout] 756 | | arb_homogeneous_fp2_480, [INFO] [stdout] 757 | | fp480 [INFO] [stdout] 758 | | ); [INFO] [stdout] | |_____- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: this warning originates in the macro `fp_proptest` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/internal/homogeneouspoint.rs:711:46 [INFO] [stdout] | [INFO] [stdout] 711 | TwistedHPoint { x: x, y: y, z: zero()}, [INFO] [stdout] | ^^^^ help: replace it with: `y` [INFO] [stdout] ... [INFO] [stdout] 752 | / fp_proptest!( [INFO] [stdout] 753 | | Monty480, [INFO] [stdout] 754 | | arb_fp480, [INFO] [stdout] 755 | | arb_homogeneous_480, [INFO] [stdout] 756 | | arb_homogeneous_fp2_480, [INFO] [stdout] 757 | | fp480 [INFO] [stdout] 758 | | ); [INFO] [stdout] | |_____- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: this warning originates in the macro `fp_proptest` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[u8; 64]` which implements the `Copy` trait [INFO] [stdout] --> src/internal/ed25519.rs:237:30 [INFO] [stdout] | [INFO] [stdout] 237 | let key_pair_bytes = key_pair.bytes().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*key_pair.bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/internal/fp.rs:98:1 [INFO] [stdout] | [INFO] [stdout] 98 | / fp62!( [INFO] [stdout] 99 | | fr_256, // Name of mod [INFO] [stdout] 100 | | Fr256, // Name of class [INFO] [stdout] 101 | | 256, // Number of bits for prime [INFO] [stdout] ... | [INFO] [stdout] 143 | | 388461543364775519 [INFO] [stdout] 144 | | ); [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] = note: this warning originates in the macro `fp62` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: suspicious use of `|` in `AddAssign` impl [INFO] [stdout] --> src/internal/fp.rs:98:1 [INFO] [stdout] | [INFO] [stdout] 98 | / fp62!( [INFO] [stdout] 99 | | fr_256, // Name of mod [INFO] [stdout] 100 | | Fr256, // Name of class [INFO] [stdout] 101 | | 256, // Number of bits for prime [INFO] [stdout] ... | [INFO] [stdout] 143 | | 388461543364775519 [INFO] [stdout] 144 | | ); [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stdout] = note: `#[warn(clippy::suspicious_op_assign_impl)]` on by default [INFO] [stdout] = note: this warning originates in the macro `fp62` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: suspicious use of `|` in `AddAssign` impl [INFO] [stdout] --> src/internal/fp.rs:98:1 [INFO] [stdout] | [INFO] [stdout] 98 | / fp62!( [INFO] [stdout] 99 | | fr_256, // Name of mod [INFO] [stdout] 100 | | Fr256, // Name of class [INFO] [stdout] 101 | | 256, // Number of bits for prime [INFO] [stdout] ... | [INFO] [stdout] 143 | | 388461543364775519 [INFO] [stdout] 144 | | ); [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stdout] = note: this warning originates in the macro `fp62` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/internal/fp.rs:147:1 [INFO] [stdout] | [INFO] [stdout] 147 | / fp62!( [INFO] [stdout] 148 | | fr_480, // Name of mod [INFO] [stdout] 149 | | Fr480, // Name of class [INFO] [stdout] 150 | | 480, // Number of bits for prime [INFO] [stdout] ... | [INFO] [stdout] 204 | | 124432205055238639 [INFO] [stdout] 205 | | ); [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: this warning originates in the macro `fp62` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: suspicious use of `|` in `AddAssign` impl [INFO] [stdout] --> src/internal/fp.rs:147:1 [INFO] [stdout] | [INFO] [stdout] 147 | / fp62!( [INFO] [stdout] 148 | | fr_480, // Name of mod [INFO] [stdout] 149 | | Fr480, // Name of class [INFO] [stdout] 150 | | 480, // Number of bits for prime [INFO] [stdout] ... | [INFO] [stdout] 204 | | 124432205055238639 [INFO] [stdout] 205 | | ); [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stdout] = note: this warning originates in the macro `fp62` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: suspicious use of `|` in `AddAssign` impl [INFO] [stdout] --> src/internal/fp.rs:147:1 [INFO] [stdout] | [INFO] [stdout] 147 | / fp62!( [INFO] [stdout] 148 | | fr_480, // Name of mod [INFO] [stdout] 149 | | Fr480, // Name of class [INFO] [stdout] 150 | | 480, // Number of bits for prime [INFO] [stdout] ... | [INFO] [stdout] 204 | | 124432205055238639 [INFO] [stdout] 205 | | ); [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stdout] = note: this warning originates in the macro `fp62` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/internal/fp.rs:330:27 [INFO] [stdout] | [INFO] [stdout] 330 | let even_hex_str = if hex_str.len() % 2 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!hex_str.len().is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/internal/fp.rs:353:27 [INFO] [stdout] | [INFO] [stdout] 353 | let even_hex_str = if hex_str.len() % 2 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!hex_str.len().is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: suspicious use of `*` in `Div` impl [INFO] [stdout] --> src/internal/fp12elem.rs:153:14 [INFO] [stdout] | [INFO] [stdout] 153 | self * other.inv() [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stdout] = note: `#[warn(clippy::suspicious_arithmetic_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (12/7) [INFO] [stdout] --> src/internal/fp12elem.rs:296:5 [INFO] [stdout] | [INFO] [stdout] 296 | / pub fn create_from_t( [INFO] [stdout] 297 | | one: T, [INFO] [stdout] 298 | | two: T, [INFO] [stdout] 299 | | three: T, [INFO] [stdout] ... | [INFO] [stdout] 308 | | twelve: T, [INFO] [stdout] 309 | | ) -> Fp12Elem { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/internal/fp12elem.rs:358:27 [INFO] [stdout] | [INFO] [stdout] 358 | pub fn to_bytes_fp256(&self) -> [u8; Fp12Elem::::ENCODED_SIZE_BYTES] { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/internal/fp12elem.rs:366:27 [INFO] [stdout] | [INFO] [stdout] 366 | pub fn to_bytes_fp480(&self) -> [u8; Fp12Elem::::ENCODED_SIZE_BYTES] { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: suspicious use of `*` in `Div` impl [INFO] [stdout] --> src/internal/fp2elem.rs:149:14 [INFO] [stdout] | [INFO] [stdout] 149 | self * other.inv() [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: suspicious use of `*` in `Div` impl [INFO] [stdout] --> src/internal/fp6elem.rs:249:14 [INFO] [stdout] | [INFO] [stdout] 249 | self * other.inv() [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/internal/hashable.rs:183:29 [INFO] [stdout] | [INFO] [stdout] 183 | assert_eq!(vec![v.clone()], hashable); [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be written as a `let` statement [INFO] [stdout] --> src/internal/homogeneouspoint.rs:482:13 [INFO] [stdout] | [INFO] [stdout] 482 | / match (*self, *other) { [INFO] [stdout] 483 | | ( [INFO] [stdout] 484 | | HomogeneousPoint { [INFO] [stdout] 485 | | x: x1, [INFO] [stdout] ... | [INFO] [stdout] 494 | | ) => x1 * z2 == x2 * z1 && y1 * z2 == y2 * z1, [INFO] [stdout] 495 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] help: consider using a `let` statement [INFO] [stdout] | [INFO] [stdout] 482 ~ let ( [INFO] [stdout] 483 + HomogeneousPoint { [INFO] [stdout] 484 + x: x1, [INFO] [stdout] 485 + y: y1, [INFO] [stdout] 486 + z: z1, [INFO] [stdout] 487 + }, [INFO] [stdout] 488 + HomogeneousPoint { [INFO] [stdout] 489 + x: x2, [INFO] [stdout] 490 + y: y2, [INFO] [stdout] 491 + z: z2, [INFO] [stdout] 492 + }, [INFO] [stdout] 493 + ) = (*self, *other); [INFO] [stdout] 494 + x1 * z2 == x2 * z1 && y1 * z2 == y2 * z1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be written as a `let` statement [INFO] [stdout] --> src/internal/homogeneouspoint.rs:506:13 [INFO] [stdout] | [INFO] [stdout] 506 | / match (*self, *other) { [INFO] [stdout] 507 | | ( [INFO] [stdout] 508 | | TwistedHPoint { [INFO] [stdout] 509 | | x: x1, [INFO] [stdout] ... | [INFO] [stdout] 518 | | ) => x1 * z2 == x2 * z1 && y1 * z2 == y2 * z1, [INFO] [stdout] 519 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using a `let` statement [INFO] [stdout] | [INFO] [stdout] 506 ~ let ( [INFO] [stdout] 507 + TwistedHPoint { [INFO] [stdout] 508 + x: x1, [INFO] [stdout] 509 + y: y1, [INFO] [stdout] 510 + z: z1, [INFO] [stdout] 511 + }, [INFO] [stdout] 512 + TwistedHPoint { [INFO] [stdout] 513 + x: x2, [INFO] [stdout] 514 + y: y2, [INFO] [stdout] 515 + z: z2, [INFO] [stdout] 516 + }, [INFO] [stdout] 517 + ) = (*self, *other); [INFO] [stdout] 518 + x1 * z2 == x2 * z1 && y1 * z2 == y2 * z1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/internal/homogeneouspoint.rs:576:14 [INFO] [stdout] | [INFO] [stdout] 576 | .map(&|fp: gridiron::fp_256::Fp256| fp.to_monty()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `|fp: gridiron::fp_256::Fp256| fp.to_monty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual slice size calculation [INFO] [stdout] --> src/internal/memlock.rs:116:5 [INFO] [stdout] | [INFO] [stdout] 116 | slice.len() * std::mem::size_of::() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::mem::size_of_val(slice)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_slice_size_calculation [INFO] [stdout] = note: `#[warn(clippy::manual_slice_size_calculation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `TwistedHPoint` which implements the `Copy` trait [INFO] [stdout] --> src/internal/pairing.rs:412:17 [INFO] [stdout] | [INFO] [stdout] 412 | GOOD_TWISTED_HPOINT_MONTY.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*GOOD_TWISTED_HPOINT_MONTY` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `TwistedHPoint` which implements the `Copy` trait [INFO] [stdout] --> src/internal/pairing.rs:465:17 [INFO] [stdout] | [INFO] [stdout] 465 | GOOD_TWISTED_HPOINT_MONTY.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*GOOD_TWISTED_HPOINT_MONTY` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Monty` which implements the `Copy` trait [INFO] [stdout] --> src/internal/pairing.rs:528:13 [INFO] [stdout] | [INFO] [stdout] 528 | BASE_POINT_X.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*BASE_POINT_X` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Monty` which implements the `Copy` trait [INFO] [stdout] --> src/internal/pairing.rs:529:13 [INFO] [stdout] | [INFO] [stdout] 529 | BASE_POINT_Y.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*BASE_POINT_Y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `TwistedHPoint` which implements the `Copy` trait [INFO] [stdout] --> src/internal/pairing.rs:530:13 [INFO] [stdout] | [INFO] [stdout] 530 | GOOD_TWISTED_HPOINT_MONTY.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*GOOD_TWISTED_HPOINT_MONTY` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Monty` which implements the `Copy` trait [INFO] [stdout] --> src/internal/pairing.rs:658:13 [INFO] [stdout] | [INFO] [stdout] 658 | BASE_POINT_X.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*BASE_POINT_X` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Monty` which implements the `Copy` trait [INFO] [stdout] --> src/internal/pairing.rs:659:13 [INFO] [stdout] | [INFO] [stdout] 659 | BASE_POINT_Y.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*BASE_POINT_Y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `TwistedHPoint` which implements the `Copy` trait [INFO] [stdout] --> src/internal/pairing.rs:660:13 [INFO] [stdout] | [INFO] [stdout] 660 | GOOD_TWISTED_HPOINT_MONTY.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*GOOD_TWISTED_HPOINT_MONTY` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/internal/pairing.rs:754:64 [INFO] [stdout] | [INFO] [stdout] 754 | fn law_bilinearity(a in any::().prop_filter("", |a| !(*a == 0))) { [INFO] [stdout] | ^^^^^^^^^^ help: try: `(*a != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/internal/pairing.rs:776:70 [INFO] [stdout] | [INFO] [stdout] 776 | fn fp480_law_bilinearity(a in any::().prop_filter("", |a| !(*a == 0))) { [INFO] [stdout] | ^^^^^^^^^^ help: try: `(*a != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/internal/schnorr.rs:148:8 [INFO] [stdout] | [INFO] [stdout] 148 | /// then None should be passed here. [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] = note: `#[warn(clippy::doc_overindented_list_items)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/internal/mod.rs:88:31 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn to_byte_vectors_32(&self) -> Option<([u8; 32], [u8; 32])> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/internal/mod.rs:96:31 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn to_byte_vectors_60(&self) -> Option<([u8; 60], [u8; 60])> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/internal/mod.rs:520:1 [INFO] [stdout] | [INFO] [stdout] 520 | / pub fn encrypt( [INFO] [stdout] 521 | | to_public_key: PublicKey, [INFO] [stdout] 522 | | plaintext: Fp12Elem, // @clintfred can this be any fp12? or an rth root? [INFO] [stdout] 523 | | encrypting_key: PrivateKey, [INFO] [stdout] ... | [INFO] [stdout] 530 | | where [INFO] [stdout] 531 | | T: ExtensionField + PairingConfig + BitRepr + Hashable + ConstantSwap + Clone, [INFO] [stdout] | |____________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/internal/mod.rs:778:1 [INFO] [stdout] | [INFO] [stdout] 778 | / pub fn generate_reencryption_key( [INFO] [stdout] 779 | | from_private_key: PrivateKey, [INFO] [stdout] 780 | | to_public_key: PublicKey, [INFO] [stdout] 781 | | reencryption_private_key: PrivateKey, [INFO] [stdout] ... | [INFO] [stdout] 797 | | H: Sha256Hashing, [INFO] [stdout] 798 | | S: Ed25519Signing, [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/internal/mod.rs:931:1 [INFO] [stdout] | [INFO] [stdout] 931 | / pub fn reencrypt( [INFO] [stdout] 932 | | signed_reencryption_key: SignedValue>, [INFO] [stdout] 933 | | signed_encrypted_value: SignedValue>, [INFO] [stdout] 934 | | rand_re_priv_key: PrivateKey, [INFO] [stdout] ... | [INFO] [stdout] 950 | | H: Sha256Hashing, [INFO] [stdout] 951 | | S: Ed25519Signing, [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stdout] --> src/internal/mod.rs:1280:17 [INFO] [stdout] | [INFO] [stdout] 1280 | let ref curve_points = *curve::FP_256_CURVE_POINTS; [INFO] [stdout] | ----^^^^^^^^^^^^^^^^------------------------------- help: try: `let curve_points = &*curve::FP_256_CURVE_POINTS;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stdout] = note: `#[warn(clippy::toplevel_ref_arg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stdout] --> src/internal/mod.rs:1281:17 [INFO] [stdout] | [INFO] [stdout] 1281 | let ref sha256 = sha256::Sha256; [INFO] [stdout] | ----^^^^^^^^^^------------------ help: try: `let sha256 = &sha256::Sha256;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stdout] --> src/internal/mod.rs:1282:17 [INFO] [stdout] | [INFO] [stdout] 1282 | let ref ed25519 = api::test::DummyEd25519; [INFO] [stdout] | ----^^^^^^^^^^^--------------------------- help: try: `let ed25519 = &api::test::DummyEd25519;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stdout] --> src/internal/mod.rs:1441:13 [INFO] [stdout] | [INFO] [stdout] 1441 | let ref curve_points = *curve::FP_256_CURVE_POINTS; [INFO] [stdout] | ----^^^^^^^^^^^^^^^^------------------------------- help: try: `let curve_points = &*curve::FP_256_CURVE_POINTS;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stdout] --> src/internal/mod.rs:1442:13 [INFO] [stdout] | [INFO] [stdout] 1442 | let ref sha256 = sha256::Sha256; [INFO] [stdout] | ----^^^^^^^^^^------------------ help: try: `let sha256 = &sha256::Sha256;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stdout] --> src/internal/mod.rs:1443:13 [INFO] [stdout] | [INFO] [stdout] 1443 | let ref ed25519 = api::test::DummyEd25519; [INFO] [stdout] | ----^^^^^^^^^^^--------------------------- help: try: `let ed25519 = &api::test::DummyEd25519;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stdout] --> src/internal/mod.rs:1522:13 [INFO] [stdout] | [INFO] [stdout] 1522 | let ref curve_points = *curve::FP_256_CURVE_POINTS; [INFO] [stdout] | ----^^^^^^^^^^^^^^^^------------------------------- help: try: `let curve_points = &*curve::FP_256_CURVE_POINTS;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stdout] --> src/internal/mod.rs:1523:13 [INFO] [stdout] | [INFO] [stdout] 1523 | let ref sha256 = sha256::Sha256; [INFO] [stdout] | ----^^^^^^^^^^------------------ help: try: `let sha256 = &sha256::Sha256;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/internal/mod.rs:1559:13 [INFO] [stdout] | [INFO] [stdout] 1559 | assert!(false, "Error should have been returned") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stdout] --> src/internal/mod.rs:1566:13 [INFO] [stdout] | [INFO] [stdout] 1566 | let ref curve_points = *curve::FP_256_CURVE_POINTS; [INFO] [stdout] | ----^^^^^^^^^^^^^^^^------------------------------- help: try: `let curve_points = &*curve::FP_256_CURVE_POINTS;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stdout] --> src/internal/mod.rs:1567:13 [INFO] [stdout] | [INFO] [stdout] 1567 | let ref sha256 = sha256::Sha256; [INFO] [stdout] | ----^^^^^^^^^^------------------ help: try: `let sha256 = &sha256::Sha256;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/internal/mod.rs:1606:13 [INFO] [stdout] | [INFO] [stdout] 1606 | assert!(false, "Auth hash check should fail") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stdout] --> src/internal/mod.rs:1688:13 [INFO] [stdout] | [INFO] [stdout] 1688 | let ref curve_points = *curve::FP_256_CURVE_POINTS; [INFO] [stdout] | ----^^^^^^^^^^^^^^^^------------------------------- help: try: `let curve_points = &*curve::FP_256_CURVE_POINTS;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stdout] --> src/internal/mod.rs:1689:13 [INFO] [stdout] | [INFO] [stdout] 1689 | let ref sha256 = sha256::Sha256; [INFO] [stdout] | ----^^^^^^^^^^------------------ help: try: `let sha256 = &sha256::Sha256;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stdout] --> src/internal/mod.rs:1690:13 [INFO] [stdout] | [INFO] [stdout] 1690 | let ref ed25519 = api::test::DummyEd25519; [INFO] [stdout] | ----^^^^^^^^^^^--------------------------- help: try: `let ed25519 = &api::test::DummyEd25519;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/internal/mod.rs:1812:13 [INFO] [stdout] | [INFO] [stdout] 1812 | assert!(false, "This should be a reencrypted value") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/internal/mod.rs:1842:13 [INFO] [stdout] | [INFO] [stdout] 1842 | assert!(false, "Private key should have caused an auth hash failure") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting the result of `i32::abs()` to u32 [INFO] [stdout] --> src/internal/mod.rs:1890:34 [INFO] [stdout] | [INFO] [stdout] 1890 | -sum_n(x as i64, n.abs() as u32) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace with: `n.unsigned_abs()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_abs_to_unsigned [INFO] [stdout] = note: `#[warn(clippy::cast_abs_to_unsigned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/internal/mod.rs:1927:72 [INFO] [stdout] | [INFO] [stdout] 1927 | pub fn arb_priv_key()(fp256 in arb_fp256().prop_filter("", |a| !(*a == Zero::zero()))) -> PrivateKey { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(*a != Zero::zero())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/internal/mod.rs:1948:17 [INFO] [stdout] | [INFO] [stdout] 1948 | &curve_points, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `curve_points` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/api.rs:225:1 [INFO] [stdout] | [INFO] [stdout] 225 | / pub enum EncryptedValue { [INFO] [stdout] 226 | | /// Value which has been encrypted, but not transformed [INFO] [stdout] 227 | | /// `ephemeral_public_key` - public key of the ephemeral private key that was used to encrypt [INFO] [stdout] 228 | | /// `encrypted_message` - encrypted symmetric key [INFO] [stdout] ... | [INFO] [stdout] 232 | | / EncryptedOnceValue { [INFO] [stdout] 233 | | | ephemeral_public_key: PublicKey, [INFO] [stdout] 234 | | | encrypted_message: EncryptedMessage, [INFO] [stdout] 235 | | | auth_hash: AuthHash, [INFO] [stdout] 236 | | | public_signing_key: PublicSigningKey, [INFO] [stdout] 237 | | | signature: Ed25519Signature, [INFO] [stdout] 238 | | | }, [INFO] [stdout] | | |_____- the second-largest variant contains at least 696 bytes [INFO] [stdout] ... | [INFO] [stdout] 246 | | / TransformedValue { [INFO] [stdout] 247 | | | ephemeral_public_key: PublicKey, [INFO] [stdout] 248 | | | encrypted_message: EncryptedMessage, [INFO] [stdout] 249 | | | auth_hash: AuthHash, [INFO] [stdout] ... | | [INFO] [stdout] 252 | | | signature: Ed25519Signature, [INFO] [stdout] 253 | | | }, [INFO] [stdout] | | |_____- the largest variant contains at least 4016 bytes [INFO] [stdout] 254 | | } [INFO] [stdout] | |___^ the entire enum is at least 4016 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 250 - transform_blocks: NonEmptyVec, [INFO] [stdout] 250 + transform_blocks: Box>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/api.rs:618:8 [INFO] [stdout] | [INFO] [stdout] 618 | /// None if no augmentation was done. [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using ` ` (3 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/api.rs:1103:14 [INFO] [stdout] | [INFO] [stdout] 1103 | [std::u8::MAX; 32] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1103 - [std::u8::MAX; 32] [INFO] [stdout] 1103 + [u8::MAX; 32] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/api_480.rs:225:1 [INFO] [stdout] | [INFO] [stdout] 225 | / pub enum EncryptedValue { [INFO] [stdout] 226 | | /// Value which has been encrypted, but not transformed [INFO] [stdout] 227 | | /// `ephemeral_public_key` - public key of the ephemeral private key that was used to encrypt [INFO] [stdout] 228 | | /// `encrypted_message` - encrypted symmetric key [INFO] [stdout] ... | [INFO] [stdout] 232 | | / EncryptedOnceValue { [INFO] [stdout] 233 | | | ephemeral_public_key: PublicKey, [INFO] [stdout] 234 | | | encrypted_message: EncryptedMessage, [INFO] [stdout] 235 | | | auth_hash: AuthHash, [INFO] [stdout] 236 | | | public_signing_key: PublicSigningKey, [INFO] [stdout] 237 | | | signature: Ed25519Signature, [INFO] [stdout] 238 | | | }, [INFO] [stdout] | | |_____- the second-largest variant contains at least 1160 bytes [INFO] [stdout] ... | [INFO] [stdout] 246 | | / TransformedValue { [INFO] [stdout] 247 | | | ephemeral_public_key: PublicKey, [INFO] [stdout] 248 | | | encrypted_message: EncryptedMessage, [INFO] [stdout] 249 | | | auth_hash: AuthHash, [INFO] [stdout] ... | | [INFO] [stdout] 252 | | | signature: Ed25519Signature, [INFO] [stdout] 253 | | | }, [INFO] [stdout] | | |_____- the largest variant contains at least 6704 bytes [INFO] [stdout] 254 | | } [INFO] [stdout] | |___^ the entire enum is at least 6704 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 250 - transform_blocks: NonEmptyVec, [INFO] [stdout] 250 + transform_blocks: Box>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/api_480.rs:619:8 [INFO] [stdout] | [INFO] [stdout] 619 | /// None if no augmentation was done. [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using ` ` (3 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/api_480.rs:1145:14 [INFO] [stdout] | [INFO] [stdout] 1145 | [std::u8::MAX; 32] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1145 - [std::u8::MAX; 32] [INFO] [stdout] 1145 + [u8::MAX; 32] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/api_480.rs:1149:14 [INFO] [stdout] | [INFO] [stdout] 1149 | [std::u8::MAX; 60] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1149 - [std::u8::MAX; 60] [INFO] [stdout] 1149 + [u8::MAX; 60] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [optimized + debuginfo] target(s) in 22.04s [INFO] running `Command { std: "docker" "inspect" "84e2c5bd38e5131035eae423f2b1668874d3276bf33446f9908c328660073a25", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "84e2c5bd38e5131035eae423f2b1668874d3276bf33446f9908c328660073a25", kill_on_drop: false }` [INFO] [stdout] 84e2c5bd38e5131035eae423f2b1668874d3276bf33446f9908c328660073a25