[INFO] fetching crate reckoner 0.3.0... [INFO] linting reckoner-0.3.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate reckoner 0.3.0 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate reckoner 0.3.0 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate reckoner 0.3.0 [INFO] tweaked toml for crates.io crate reckoner 0.3.0 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate reckoner 0.3.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate reckoner 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded creachadair-imath-sys v0.3.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 30c066c1c5965137dfb2da295c4a3cad4bf98a51b895db4a46476248eb322a03 [INFO] running `Command { std: "docker" "start" "-a" "30c066c1c5965137dfb2da295c4a3cad4bf98a51b895db4a46476248eb322a03", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "30c066c1c5965137dfb2da295c4a3cad4bf98a51b895db4a46476248eb322a03", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "30c066c1c5965137dfb2da295c4a3cad4bf98a51b895db4a46476248eb322a03", kill_on_drop: false }` [INFO] [stdout] 30c066c1c5965137dfb2da295c4a3cad4bf98a51b895db4a46476248eb322a03 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 32eee79f9b2f3774eb78ebc0f5d99f0fe23ba8aa0722e232bfb00b713cd31604 [INFO] running `Command { std: "docker" "start" "-a" "32eee79f9b2f3774eb78ebc0f5d99f0fe23ba8aa0722e232bfb00b713cd31604", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling libc v0.2.150 [INFO] [stderr] Compiling regex-syntax v0.8.2 [INFO] [stderr] Compiling memchr v2.6.4 [INFO] [stderr] Compiling bindgen v0.70.1 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling shlex v1.2.0 [INFO] [stderr] Compiling bitflags v2.4.1 [INFO] [stderr] Compiling dunce v1.0.4 [INFO] [stderr] Compiling clang-sys v1.6.1 [INFO] [stderr] Compiling libloading v0.7.4 [INFO] [stderr] Compiling itertools v0.13.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling regex-automata v0.4.3 [INFO] [stderr] Compiling syn v2.0.39 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Compiling regex v1.10.2 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Compiling creachadair-imath-sys v0.3.0 [INFO] [stderr] Checking reckoner v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/integer/comparison.rs:158:17 [INFO] [stdout] | [INFO] [stdout] 158 | assert!(!(a < b)); [INFO] [stdout] | ^^^^^^^^ help: try: `(a >= b)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/integer/comparison.rs:163:17 [INFO] [stdout] | [INFO] [stdout] 163 | assert!(!(b > a)); [INFO] [stdout] | ^^^^^^^^ help: try: `(b <= a)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rational/comparisons.rs:144:17 [INFO] [stdout] | [INFO] [stdout] 144 | assert!(!(a < b)); [INFO] [stdout] | ^^^^^^^^ help: try: `(a >= b)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rational/comparisons.rs:149:17 [INFO] [stdout] | [INFO] [stdout] 149 | assert!(!(b > a)); [INFO] [stdout] | ^^^^^^^^ help: try: `(b <= a)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `idx` is only used to index `arr` [INFO] [stdout] --> tests/creachadair_imath.rs:54:16 [INFO] [stdout] | [INFO] [stdout] 54 | for idx in 0..N { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 54 - for idx in 0..N { [INFO] [stdout] 54 + for in arr.iter_mut().take(N) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/creachadair_imath.rs:80:5 [INFO] [stdout] | [INFO] [stdout] 80 | return !(trimmed.starts_with('#') || trimmed.is_empty()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 80 - return !(trimmed.starts_with('#') || trimmed.is_empty()); [INFO] [stdout] 80 + !(trimmed.starts_with('#') || trimmed.is_empty()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 25.46s [INFO] running `Command { std: "docker" "inspect" "32eee79f9b2f3774eb78ebc0f5d99f0fe23ba8aa0722e232bfb00b713cd31604", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "32eee79f9b2f3774eb78ebc0f5d99f0fe23ba8aa0722e232bfb00b713cd31604", kill_on_drop: false }` [INFO] [stdout] 32eee79f9b2f3774eb78ebc0f5d99f0fe23ba8aa0722e232bfb00b713cd31604