[INFO] fetching crate rdf-proofs 0.11.1... [INFO] linting rdf-proofs-0.11.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate rdf-proofs 0.11.1 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate rdf-proofs 0.11.1 [INFO] finished tweaking crates.io crate rdf-proofs 0.11.1 [INFO] tweaked toml for crates.io crate rdf-proofs 0.11.1 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate rdf-proofs 0.11.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate rdf-proofs 0.11.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded schnorr_pok v0.22.0 [INFO] [stderr] Downloaded dock_merlin v3.0.0 [INFO] [stderr] Downloaded secret_sharing_and_dkg v0.15.0 [INFO] [stderr] Downloaded verifiable_encryption v0.2.0 [INFO] [stderr] Downloaded ark-snark v0.4.0 [INFO] [stderr] Downloaded cranelift-control v0.110.3 [INFO] [stderr] Downloaded cranelift-bitset v0.110.3 [INFO] [stderr] Downloaded cc v1.2.26 [INFO] [stderr] Downloaded serde-wasm-bindgen v0.4.5 [INFO] [stderr] Downloaded wasmer-derive v5.0.6 [INFO] [stderr] Downloaded smc_range_proof v0.8.0 [INFO] [stderr] Downloaded oxttl v0.1.8 [INFO] [stderr] Downloaded bulletproofs_plus_plus v0.8.0 [INFO] [stderr] Downloaded cranelift-codegen-meta v0.110.3 [INFO] [stderr] Downloaded wasmer-compiler v5.0.6 [INFO] [stderr] Downloaded legogroth16 v0.17.0 [INFO] [stderr] Downloaded rkyv v0.8.10 [INFO] [stderr] Downloaded wasmparser v0.233.0 [INFO] [stderr] Downloaded prettyplease v0.2.33 [INFO] [stderr] Downloaded wasm-encoder v0.233.0 [INFO] [stderr] Downloaded ark-r1cs-std v0.4.0 [INFO] [stderr] Downloaded cranelift-isle v0.110.2 [INFO] [stderr] Downloaded vb_accumulator v0.28.0 [INFO] [stderr] Downloaded rdf-canon v0.15.2 [INFO] [stderr] Downloaded wasmer v5.0.6 [INFO] [stderr] Downloaded wasmparser v0.216.1 [INFO] [stderr] Downloaded proof_system v0.33.0 [INFO] [stderr] Downloaded corosensei v0.2.2 [INFO] [stderr] Downloaded wasmer-vm v5.0.6 [INFO] [stderr] Downloaded kvac v0.7.0 [INFO] [stderr] Downloaded short_group_sig v0.6.0 [INFO] [stderr] Downloaded wasmer-types v5.0.6 [INFO] [stderr] Downloaded saver v0.20.0 [INFO] [stderr] Downloaded coconut-crypto v0.13.0 [INFO] [stderr] Downloaded ark-groth16 v0.4.0 [INFO] [stderr] Downloaded cranelift-codegen v0.110.2 [INFO] [stderr] Downloaded ark-relations v0.4.0 [INFO] [stderr] Downloaded xattr v1.5.0 [INFO] [stderr] Downloaded cranelift-codegen-shared v0.110.3 [INFO] [stderr] Downloaded wasmer-compiler-cranelift v5.0.6 [INFO] [stderr] Downloaded wast v233.0.0 [INFO] [stderr] Downloaded munge v0.4.4 [INFO] [stderr] Downloaded oblivious_transfer_protocols v0.11.0 [INFO] [stderr] Downloaded bbs_plus v0.24.0 [INFO] [stderr] Downloaded ark-crypto-primitives v0.4.0 [INFO] [stderr] Downloaded cranelift-bforest v0.110.2 [INFO] [stderr] Downloaded cranelift-entity v0.110.2 [INFO] [stderr] Downloaded bytecheck_derive v0.8.1 [INFO] [stderr] Downloaded rancor v0.1.0 [INFO] [stderr] Downloaded rkyv_derive v0.8.10 [INFO] [stderr] Downloaded enumset v1.1.6 [INFO] [stderr] Downloaded cranelift-frontend v0.110.2 [INFO] [stderr] Downloaded enumset_derive v0.11.0 [INFO] [stderr] Downloaded munge_macro v0.4.4 [INFO] [stderr] Downloaded rend v0.5.2 [INFO] [stderr] Downloaded wat v1.233.0 [INFO] [stderr] Downloaded bytecheck v0.8.1 [INFO] [stderr] Downloaded ark-secp256r1 v0.4.0 [INFO] [stderr] Downloaded dock_crypto_utils v0.22.0 [INFO] [stderr] Downloaded oxrdf v0.2.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cefd269381eb7b13853ea38f3f3702ba0e855699a788cd2536ae0eed0c2cab72 [INFO] running `Command { std: "docker" "start" "-a" "cefd269381eb7b13853ea38f3f3702ba0e855699a788cd2536ae0eed0c2cab72", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cefd269381eb7b13853ea38f3f3702ba0e855699a788cd2536ae0eed0c2cab72", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cefd269381eb7b13853ea38f3f3702ba0e855699a788cd2536ae0eed0c2cab72", kill_on_drop: false }` [INFO] [stdout] cefd269381eb7b13853ea38f3f3702ba0e855699a788cd2536ae0eed0c2cab72 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dd9cb0384ba87a4368dc2c1d68002ba2552e120b258d9d5b383933dfc7ed4460 [INFO] running `Command { std: "docker" "start" "-a" "dd9cb0384ba87a4368dc2c1d68002ba2552e120b258d9d5b383933dfc7ed4460", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Compiling cc v1.2.26 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling stable_deref_trait v1.2.0 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Compiling zerofrom v0.1.6 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Compiling writeable v0.6.1 [INFO] [stderr] Compiling litemap v0.8.0 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking hashbrown v0.13.2 [INFO] [stderr] Compiling ptr_meta_derive v0.3.0 [INFO] [stderr] Compiling icu_properties_data v2.0.1 [INFO] [stderr] Compiling icu_normalizer_data v2.0.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling num-integer v0.1.46 [INFO] [stderr] Checking smallvec v1.15.0 [INFO] [stderr] Checking ptr_meta v0.3.0 [INFO] [stderr] Compiling target-lexicon v0.12.16 [INFO] [stderr] Checking simdutf8 v0.1.5 [INFO] [stderr] Checking rancor v0.1.0 [INFO] [stderr] Compiling rustls-pki-types v1.12.0 [INFO] [stderr] Compiling num-bigint v0.4.6 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Compiling bytecheck_derive v0.8.1 [INFO] [stderr] Compiling yoke v0.8.0 [INFO] [stderr] Compiling cranelift-isle v0.110.2 [INFO] [stderr] Compiling glob v0.3.2 [INFO] [stderr] Compiling zerotrie v0.2.2 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Compiling zerovec v0.11.2 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Compiling lock_api v0.4.13 [INFO] [stderr] Compiling munge_macro v0.4.4 [INFO] [stderr] Compiling rustix v1.0.7 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling bytecheck v0.6.12 [INFO] [stderr] Checking ark-std v0.4.0 [INFO] [stderr] Compiling bitflags v2.9.1 [INFO] [stderr] Compiling object v0.36.7 [INFO] [stderr] Checking bytecheck v0.8.1 [INFO] [stderr] Compiling prettyplease v0.2.33 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Compiling clang-sys v1.8.1 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling cranelift-codegen-shared v0.110.3 [INFO] [stderr] Compiling cranelift-codegen-meta v0.110.3 [INFO] [stderr] Checking rend v0.5.2 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Checking munge v0.4.4 [INFO] [stderr] Compiling corosensei v0.2.2 [INFO] [stderr] Compiling rkyv_derive v0.8.10 [INFO] [stderr] Compiling rustls v0.23.27 [INFO] [stderr] Compiling adler2 v2.0.0 [INFO] [stderr] Checking bumpalo v3.18.1 [INFO] [stderr] Compiling linux-raw-sys v0.9.4 [INFO] [stderr] Compiling percent-encoding v2.3.1 [INFO] [stderr] Checking gimli v0.31.1 [INFO] [stderr] Compiling semver v1.0.26 [INFO] [stderr] Compiling log v0.4.27 [INFO] [stderr] Checking cranelift-bitset v0.110.3 [INFO] [stderr] Compiling form_urlencoded v1.2.1 [INFO] [stderr] Compiling miniz_oxide v0.8.8 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking cranelift-entity v0.110.2 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Compiling webpki-roots v1.0.0 [INFO] [stderr] Checking tracing-subscriber v0.2.25 [INFO] [stderr] Compiling crc32fast v1.4.2 [INFO] [stderr] Compiling tinystr v0.8.1 [INFO] [stderr] Compiling potential_utf v0.1.2 [INFO] [stderr] Compiling derive_more v0.99.20 [INFO] [stderr] Compiling icu_locale_core v2.0.0 [INFO] [stderr] Checking slice-group-by v0.3.1 [INFO] [stderr] Compiling icu_collections v2.0.0 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking arbitrary v1.4.1 [INFO] [stderr] Compiling wasm-encoder v0.233.0 [INFO] [stderr] Checking more-asserts v0.2.2 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking xxhash-rust v0.8.15 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking regalloc2 v0.9.3 [INFO] [stderr] Compiling bindgen v0.70.1 [INFO] [stderr] Checking region v3.0.2 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Compiling enumset_derive v0.11.0 [INFO] [stderr] Compiling flate2 v1.1.1 [INFO] [stderr] Compiling icu_provider v2.0.0 [INFO] [stderr] Checking dashmap v6.1.0 [INFO] [stderr] Checking cranelift-control v0.110.3 [INFO] [stderr] Checking enumset v1.1.6 [INFO] [stderr] Checking addr2line v0.24.2 [INFO] [stderr] Compiling webpki-roots v0.26.11 [INFO] [stderr] Compiling xattr v1.5.0 [INFO] [stderr] Checking cranelift-bforest v0.110.2 [INFO] [stderr] Compiling icu_properties v2.0.1 [INFO] [stderr] Compiling icu_normalizer v2.0.0 [INFO] [stderr] Compiling oblivious_transfer_protocols v0.11.0 [INFO] [stderr] Compiling filetime v0.2.25 [INFO] [stderr] Checking crossbeam-queue v0.3.12 [INFO] [stderr] Checking memmap2 v0.6.2 [INFO] [stderr] Checking wasmparser v0.216.1 [INFO] [stderr] Compiling tar v0.4.44 [INFO] [stderr] Compiling darling_core v0.13.4 [INFO] [stderr] Checking shared-buffer v0.1.4 [INFO] [stderr] Compiling cranelift-codegen v0.110.2 [INFO] [stderr] Checking ruzstd v0.5.0 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Compiling cmake v0.1.54 [INFO] [stderr] Compiling proc-macro-error-attr2 v2.0.0 [INFO] [stderr] Checking self_cell v1.2.0 [INFO] [stderr] Compiling wasmer-compiler-cranelift v5.0.6 [INFO] [stderr] Checking leb128 v0.2.5 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Compiling proc-macro-error2 v2.0.1 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking wast v233.0.0 [INFO] [stderr] Checking oxilangtag v0.1.5 [INFO] [stderr] Compiling idna_adapter v1.2.1 [INFO] [stderr] Checking backtrace v0.3.75 [INFO] [stderr] Compiling idna v1.0.3 [INFO] [stderr] Checking oxiri v0.2.11 [INFO] [stderr] Compiling rustls-webpki v0.103.3 [INFO] [stderr] Compiling data-encoding v2.9.0 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking oxrdf v0.2.4 [INFO] [stderr] Checking rkyv v0.8.10 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling url v2.5.4 [INFO] [stderr] Compiling ark-serialize-derive v0.4.2 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling ark-ff-macros v0.4.2 [INFO] [stderr] Compiling ark-ff-asm v0.4.2 [INFO] [stderr] Compiling ptr_meta_derive v0.1.4 [INFO] [stderr] Compiling enum-iterator-derive v0.7.0 [INFO] [stderr] Checking ark-serialize v0.4.2 [INFO] [stderr] Compiling bytecheck_derive v0.6.12 [INFO] [stderr] Checking dock_merlin v3.0.0 [INFO] [stderr] Checking ptr_meta v0.1.4 [INFO] [stderr] Checking enum-iterator v0.7.0 [INFO] [stderr] Compiling wasmer-derive v5.0.6 [INFO] [stderr] Compiling data-encoding-macro-internal v0.1.16 [INFO] [stderr] Checking half v2.6.0 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking chacha20poly1305 v0.10.1 [INFO] [stderr] Compiling serde_with_macros v3.12.0 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Compiling darling_macro v0.13.4 [INFO] [stderr] Checking base-x v0.2.11 [INFO] [stderr] Checking chrono v0.4.41 [INFO] [stderr] Checking rdf-canon v0.15.2 [INFO] [stderr] Checking data-encoding-macro v0.1.18 [INFO] [stderr] Compiling darling v0.13.4 [INFO] [stderr] Checking multibase v0.9.1 [INFO] [stderr] Compiling serde_with_macros v1.5.2 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking oxttl v0.1.8 [INFO] [stderr] Checking oxsdatatypes v0.2.2 [INFO] [stderr] Checking unsigned-varint v0.8.0 [INFO] [stderr] Checking ark-ff v0.4.2 [INFO] [stderr] Checking wasmer-types v5.0.6 [INFO] [stderr] Checking serde_with v1.14.0 [INFO] [stderr] Checking serde_with v3.12.0 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking wat v1.233.0 [INFO] [stderr] Checking wasmer-vm v5.0.6 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking wasmer-compiler v5.0.6 [INFO] [stderr] Compiling ureq v2.12.1 [INFO] [stderr] Compiling wasmer v5.0.6 [INFO] [stderr] Checking ark-poly v0.4.2 [INFO] [stderr] Checking ark-relations v0.4.0 [INFO] [stderr] Checking ark-snark v0.4.0 [INFO] [stderr] Checking ark-ec v0.4.2 [INFO] [stderr] Checking dock_crypto_utils v0.22.0 [INFO] [stderr] Checking ark-crypto-primitives v0.4.0 [INFO] [stderr] Checking ark-secp256r1 v0.4.0 [INFO] [stderr] Checking ark-r1cs-std v0.4.0 [INFO] [stderr] Checking ark-bls12-381 v0.4.0 [INFO] [stderr] Checking ark-groth16 v0.4.0 [INFO] [stderr] Checking schnorr_pok v0.22.0 [INFO] [stderr] Checking bulletproofs_plus_plus v0.8.0 [INFO] [stderr] Checking secret_sharing_and_dkg v0.15.0 [INFO] [stderr] Checking kvac v0.7.0 [INFO] [stderr] Checking coconut-crypto v0.13.0 [INFO] [stderr] Checking verifiable_encryption v0.2.0 [INFO] [stderr] Checking short_group_sig v0.6.0 [INFO] [stderr] Checking bbs_plus v0.24.0 [INFO] [stderr] Checking vb_accumulator v0.28.0 [INFO] [stderr] Checking smc_range_proof v0.8.0 [INFO] [stderr] Checking cranelift-frontend v0.110.2 [INFO] [stderr] Checking legogroth16 v0.17.0 [INFO] [stderr] Checking saver v0.20.0 [INFO] [stderr] Checking proof_system v0.33.0 [INFO] [stderr] Checking rdf-proofs v0.11.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/common.rs:53:1 [INFO] [stdout] | [INFO] [stdout] 53 | use unsigned_varint; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/vc.rs:56:28 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn add_proof_value(self: &mut Self, proof_value: String) -> Result<(), RDFProofsError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] = note: `#[warn(clippy::needless_arbitrary_self_type)]` on by default [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 56 - pub fn add_proof_value(self: &mut Self, proof_value: String) -> Result<(), RDFProofsError> { [INFO] [stdout] 56 + pub fn add_proof_value(&mut self, proof_value: String) -> Result<(), RDFProofsError> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/common.rs:53:1 [INFO] [stdout] | [INFO] [stdout] 53 | use unsigned_varint; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/vc.rs:71:32 [INFO] [stdout] | [INFO] [stdout] 71 | pub fn replace_proof_value(self: &mut Self, proof_value: String) -> Result<(), RDFProofsError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 71 - pub fn replace_proof_value(self: &mut Self, proof_value: String) -> Result<(), RDFProofsError> { [INFO] [stdout] 71 + pub fn replace_proof_value(&mut self, proof_value: String) -> Result<(), RDFProofsError> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/vc.rs:95:28 [INFO] [stdout] | [INFO] [stdout] 95 | pub fn get_proof_value(self: &Self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 95 - pub fn get_proof_value(self: &Self) -> Result { [INFO] [stdout] 95 + pub fn get_proof_value(&self) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/vc.rs:114:29 [INFO] [stdout] | [INFO] [stdout] 114 | pub fn get_proof_config(self: &Self) -> Graph { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 114 - pub fn get_proof_config(self: &Self) -> Graph { [INFO] [stdout] 114 + pub fn get_proof_config(&self) -> Graph { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/vc.rs:370:28 [INFO] [stdout] | [INFO] [stdout] 370 | pub fn get_proof_value(self: &Self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 370 - pub fn get_proof_value(self: &Self) -> Result { [INFO] [stdout] 370 + pub fn get_proof_value(&self) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/vc.rs:390:9 [INFO] [stdout] | [INFO] [stdout] 390 | self: &Self, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 390 - self: &Self, [INFO] [stdout] 390 + &self, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/vc.rs:56:28 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn add_proof_value(self: &mut Self, proof_value: String) -> Result<(), RDFProofsError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] = note: `#[warn(clippy::needless_arbitrary_self_type)]` on by default [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 56 - pub fn add_proof_value(self: &mut Self, proof_value: String) -> Result<(), RDFProofsError> { [INFO] [stdout] 56 + pub fn add_proof_value(&mut self, proof_value: String) -> Result<(), RDFProofsError> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/vc.rs:71:32 [INFO] [stdout] | [INFO] [stdout] 71 | pub fn replace_proof_value(self: &mut Self, proof_value: String) -> Result<(), RDFProofsError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 71 - pub fn replace_proof_value(self: &mut Self, proof_value: String) -> Result<(), RDFProofsError> { [INFO] [stdout] 71 + pub fn replace_proof_value(&mut self, proof_value: String) -> Result<(), RDFProofsError> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/vc.rs:95:28 [INFO] [stdout] | [INFO] [stdout] 95 | pub fn get_proof_value(self: &Self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 95 - pub fn get_proof_value(self: &Self) -> Result { [INFO] [stdout] 95 + pub fn get_proof_value(&self) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/vc.rs:114:29 [INFO] [stdout] | [INFO] [stdout] 114 | pub fn get_proof_config(self: &Self) -> Graph { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 114 - pub fn get_proof_config(self: &Self) -> Graph { [INFO] [stdout] 114 + pub fn get_proof_config(&self) -> Graph { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/vc.rs:370:28 [INFO] [stdout] | [INFO] [stdout] 370 | pub fn get_proof_value(self: &Self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 370 - pub fn get_proof_value(self: &Self) -> Result { [INFO] [stdout] 370 + pub fn get_proof_value(&self) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/vc.rs:390:9 [INFO] [stdout] | [INFO] [stdout] 390 | self: &Self, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 390 - self: &Self, [INFO] [stdout] 390 + &self, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `OrderedNamedOrBlankNodeRef` is never constructed [INFO] [stdout] --> src/ordered_triple.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 74 | pub struct OrderedNamedOrBlankNodeRef<'a>(NamedOrBlankNodeRef<'a>); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/blind_signature.rs:63:20 [INFO] [stdout] | [INFO] [stdout] 63 | let skip_pok = match skip_pok { [INFO] [stdout] | ____________________^ [INFO] [stdout] 64 | | Some(v) => v, [INFO] [stdout] 65 | | None => false, [INFO] [stdout] 66 | | }; [INFO] [stdout] | |_____^ help: replace it with: `skip_pok.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Affine` which implements the `Copy` trait [INFO] [stdout] --> src/blind_signature.rs:149:9 [INFO] [stdout] | [INFO] [stdout] 149 | commitment.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*commitment` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/blind_signature.rs:208:37 [INFO] [stdout] | [INFO] [stdout] 208 | .map(|t| format!("{} .\n", t.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/blind_signature.rs:259:21 [INFO] [stdout] | [INFO] [stdout] 259 | .enumerate() [INFO] [stdout] | _____________________^ [INFO] [stdout] 260 | | .map(|(i, m)| (i, m)) [INFO] [stdout] | |_____________________________^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] = note: `#[warn(clippy::map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/blind_signature.rs:308:38 [INFO] [stdout] | [INFO] [stdout] 308 | .map(|t| format!("{} . \n", t.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/common.rs:201:26 [INFO] [stdout] | [INFO] [stdout] 201 | statement_index_map: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 201 ~ statement_index_map: &[StatementIndexMap], [INFO] [stdout] 202 | ) -> Result, RDFProofsError> { [INFO] [stdout] 203 | let serialized_vp = rdf_canon::serialize(&vp); [INFO] [stdout] 204 ~ let serialized_vp_with_index_map = ProofSpecContext(serialized_vp, statement_index_map.to_owned()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/common.rs:203:46 [INFO] [stdout] | [INFO] [stdout] 203 | let serialized_vp = rdf_canon::serialize(&vp); [INFO] [stdout] | ^^^ help: change this to: `vp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/common.rs:280:12 [INFO] [stdout] | [INFO] [stdout] 280 | terms: &Vec, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 280 - terms: &Vec, [INFO] [stdout] 280 + terms: &[Term], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/common.rs:302:13 [INFO] [stdout] | [INFO] [stdout] 302 | Fr::try_from(timestamp) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `i64` to `Fp, 4>` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 302 - Fr::try_from(timestamp) [INFO] [stdout] 302 + From::from(timestamp) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/common.rs:311:13 [INFO] [stdout] | [INFO] [stdout] 311 | Fr::try_from(timestamp) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `i64` to `Fp, 4>` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 311 - Fr::try_from(timestamp) [INFO] [stdout] 311 + From::from(timestamp) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/common.rs:361:33 [INFO] [stdout] | [INFO] [stdout] 361 | .or_insert_with(|| BlankNode::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `BlankNode::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/common.rs:370:33 [INFO] [stdout] | [INFO] [stdout] 370 | .or_insert_with(|| BlankNode::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `BlankNode::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/common.rs:391:33 [INFO] [stdout] | [INFO] [stdout] 391 | .or_insert_with(|| BlankNode::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `BlankNode::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/common.rs:400:33 [INFO] [stdout] | [INFO] [stdout] 400 | .or_insert_with(|| BlankNode::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `BlankNode::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `oxrdf::NamedOrBlankNode` [INFO] [stdout] --> src/common.rs:613:43 [INFO] [stdout] | [INFO] [stdout] 613 | result.push((var.value().to_string(), val.into())); [INFO] [stdout] | ^^^^^^^^^^ help: consider removing `.into()`: `val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (11/7) [INFO] [stdout] --> src/derive_proof.rs:49:1 [INFO] [stdout] | [INFO] [stdout] 49 | / pub fn derive_proof( [INFO] [stdout] 50 | | rng: &mut R, [INFO] [stdout] 51 | | vc_pairs: &Vec, [INFO] [stdout] 52 | | deanon_map: &HashMap, [INFO] [stdout] ... | [INFO] [stdout] 60 | | circuits: HashMap, [INFO] [stdout] 61 | | ) -> Result { [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/derive_proof.rs:71:42 [INFO] [stdout] | [INFO] [stdout] 71 | || with_ppid.is_some_and(|x| x == false) [INFO] [stdout] | ^^^^^^^^^^ help: try: `!x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/derive_proof.rs:74:39 [INFO] [stdout] | [INFO] [stdout] 74 | || domain.is_some_and(|x| x == "")) [INFO] [stdout] | ^^^^^^^ help: using `is_empty` is clearer and more explicit: `x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `.map().collect()` can be replaced with `.try_for_each()` [INFO] [stdout] --> src/derive_proof.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | / vc_pairs [INFO] [stdout] 91 | | .iter() [INFO] [stdout] 92 | | .map( [INFO] [stdout] 93 | | |VcPair { original: vc, .. }| match (vc.is_bound(), secret) { [INFO] [stdout] ... | [INFO] [stdout] 100 | | .collect::>()?; [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_collect_result_unit [INFO] [stdout] = note: `#[warn(clippy::map_collect_result_unit)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 90 ~ vc_pairs [INFO] [stdout] 91 + .iter().try_for_each(|VcPair { original: vc, .. }| match (vc.is_bound(), secret) { [INFO] [stdout] 92 + (Ok(false), _) => verify(vc, key_graph), [INFO] [stdout] 93 + (Ok(true), Some(s)) => blind_verify(s, vc, key_graph), [INFO] [stdout] 94 + (Ok(true), None) => Err(RDFProofsError::MissingSecret), [INFO] [stdout] 95 + _ => Err(RDFProofsError::VCWithUnsupportedCryptosuite), [INFO] [stdout] 96 ~ })?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/derive_proof.rs:196:29 [INFO] [stdout] | [INFO] [stdout] 196 | println!("{}: {}", f.to_string(), t.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/derive_proof.rs:196:44 [INFO] [stdout] | [INFO] [stdout] 196 | println!("{}: {}", f.to_string(), t.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/derive_proof.rs:198:5 [INFO] [stdout] | [INFO] [stdout] 198 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/derive_proof.rs:216:45 [INFO] [stdout] | [INFO] [stdout] 216 | .map(|t| format!("{} .\n", t.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/derive_proof.rs:224:45 [INFO] [stdout] | [INFO] [stdout] 224 | .map(|t| format!("{} .\n", t.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/derive_proof.rs:235:45 [INFO] [stdout] | [INFO] [stdout] 235 | .map(|t| format!("{} .\n", t.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/derive_proof.rs:243:45 [INFO] [stdout] | [INFO] [stdout] 243 | .map(|t| format!("{} .\n", t.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (11/7) [INFO] [stdout] --> src/derive_proof.rs:288:1 [INFO] [stdout] | [INFO] [stdout] 288 | / pub fn derive_proof_string( [INFO] [stdout] 289 | | rng: &mut R, [INFO] [stdout] 290 | | vc_pairs: &Vec, [INFO] [stdout] 291 | | deanon_map: &HashMap, [INFO] [stdout] ... | [INFO] [stdout] 299 | | circuits: Option<&HashMap>, [INFO] [stdout] 300 | | ) -> Result { [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/derive_proof.rs:290:15 [INFO] [stdout] | [INFO] [stdout] 290 | vc_pairs: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 290 - vc_pairs: &Vec, [INFO] [stdout] 290 + vc_pairs: &[VcPairString], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/derive_proof.rs:330:30 [INFO] [stdout] | [INFO] [stdout] 330 | .map(|predicate| Ok(get_graph_from_ntriples(predicate)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 330 - .map(|predicate| Ok(get_graph_from_ntriples(predicate)?)) [INFO] [stdout] 330 + .map(|predicate| get_graph_from_ntriples(predicate)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/derive_proof.rs:371:20 [INFO] [stdout] | [INFO] [stdout] 371 | let with_nym = match with_nym { [INFO] [stdout] | ____________________^ [INFO] [stdout] 372 | | Some(v) => v, [INFO] [stdout] 373 | | None => false, [INFO] [stdout] 374 | | }; [INFO] [stdout] | |_____^ help: replace it with: `with_nym.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/derive_proof.rs:473:10 [INFO] [stdout] | [INFO] [stdout] 473 | vcs: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 473 - vcs: &Vec, [INFO] [stdout] 473 + vcs: &[VerifiableCredential], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/derive_proof.rs:512:6 [INFO] [stdout] | [INFO] [stdout] 512 | ) -> Result<(Dataset, HashMap, Vec), RDFProofsError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/derive_proof.rs:560:44 [INFO] [stdout] | [INFO] [stdout] 560 | LiteralRef::new_simple_literal(*challenge), [INFO] [stdout] | ^^^^^^^^^^ help: try: `challenge` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/derive_proof.rs:570:44 [INFO] [stdout] | [INFO] [stdout] 570 | LiteralRef::new_simple_literal(*domain), [INFO] [stdout] | ^^^^^^^ help: try: `domain` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/derive_proof.rs:693:61 [INFO] [stdout] | [INFO] [stdout] 693 | println!("vp draft (before canonicalization):\n{}\n", vp.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `HashMap` [INFO] [stdout] --> src/derive_proof.rs:715:10 [INFO] [stdout] | [INFO] [stdout] 715 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/derive_proof.rs:746:6 [INFO] [stdout] | [INFO] [stdout] 746 | ) -> Result< [INFO] [stdout] | ______^ [INFO] [stdout] 747 | | ( [INFO] [stdout] 748 | | Vec, [INFO] [stdout] 749 | | Vec, [INFO] [stdout] ... | [INFO] [stdout] 753 | | RDFProofsError, [INFO] [stdout] 754 | | > { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/derive_proof.rs:741:33 [INFO] [stdout] | [INFO] [stdout] 741 | canonicalized_original_vcs: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 741 - canonicalized_original_vcs: &Vec, [INFO] [stdout] 741 + canonicalized_original_vcs: &[VerifiableCredential], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/derive_proof.rs:745:30 [INFO] [stdout] | [INFO] [stdout] 745 | vc_document_graph_names: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 745 - vc_document_graph_names: &Vec, [INFO] [stdout] 745 + vc_document_graph_names: &[BlankNode], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/derive_proof.rs:797:27 [INFO] [stdout] | [INFO] [stdout] 797 | let original_vc_vec = ordered_original_vcs [INFO] [stdout] | ___________________________^ [INFO] [stdout] 798 | | .into_iter() [INFO] [stdout] 799 | | .map(|(_, v)| v.into()) [INFO] [stdout] | |_______________________________^ help: try: `ordered_original_vcs.into_values().map(|v| v.into())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] = note: `#[warn(clippy::iter_kv_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/derive_proof.rs:801:28 [INFO] [stdout] | [INFO] [stdout] 801 | let disclosed_vc_vec = canonicalized_disclosed_vc_graphs [INFO] [stdout] | ____________________________^ [INFO] [stdout] 802 | | .into_iter() [INFO] [stdout] 803 | | .map(|(_, v)| v.into()) [INFO] [stdout] | |_______________________________^ help: try: `canonicalized_disclosed_vc_graphs.into_values().map(|v| v.into())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `BTreeMap` [INFO] [stdout] --> src/derive_proof.rs:802:10 [INFO] [stdout] | [INFO] [stdout] 802 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/derive_proof.rs:805:31 [INFO] [stdout] | [INFO] [stdout] 805 | let vc_proof_values_vec = ordered_proof_values [INFO] [stdout] | _______________________________^ [INFO] [stdout] 806 | | .into_iter() [INFO] [stdout] 807 | | .map(|(_, v)| v.into()) [INFO] [stdout] | |_______________________________^ help: try: `ordered_proof_values.into_values().map(|v| v.into())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/derive_proof.rs:809:24 [INFO] [stdout] | [INFO] [stdout] 809 | let is_bound_vec = ordered_is_bounds [INFO] [stdout] | ________________________^ [INFO] [stdout] 810 | | .into_iter() [INFO] [stdout] 811 | | .map(|(_, v)| v) [INFO] [stdout] | |________________________^ help: try: `ordered_is_bounds.into_values()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter_mut()` and will not consume the `Vec` [INFO] [stdout] --> src/derive_proof.rs:831:32 [INFO] [stdout] | [INFO] [stdout] 831 | for triple in document.into_iter() { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter_mut()` and will not consume the `Vec` [INFO] [stdout] --> src/derive_proof.rs:836:29 [INFO] [stdout] | [INFO] [stdout] 836 | for triple in proof.into_iter() { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/derive_proof.rs:848:45 [INFO] [stdout] | [INFO] [stdout] 848 | .map(|t| format!("{} .\n", t.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/derive_proof.rs:856:45 [INFO] [stdout] | [INFO] [stdout] 856 | .map(|t| format!("{} .\n", t.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (15/7) [INFO] [stdout] --> src/derive_proof.rs:910:1 [INFO] [stdout] | [INFO] [stdout] 910 | / fn derive_proof_value( [INFO] [stdout] 911 | | rng: &mut R, [INFO] [stdout] 912 | | secret: Option<&[u8]>, [INFO] [stdout] 913 | | original_vc_triples: Vec, [INFO] [stdout] ... | [INFO] [stdout] 925 | | extended_deanon_map: &HashMap, [INFO] [stdout] 926 | | ) -> Result { [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/derive_proof.rs:1116:47 [INFO] [stdout] | [INFO] [stdout] 1116 | let context = generate_proof_spec_context(&canonicalized_vp, &index_map)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `canonicalized_vp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/derive_proof.rs:1196:16 [INFO] [stdout] | [INFO] [stdout] 1196 | index_map: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1196 ~ index_map: &[StatementIndexMap], [INFO] [stdout] 1197 | ) -> Result { [INFO] [stdout] ... [INFO] [stdout] 1201 | proof, [INFO] [stdout] 1202 ~ index_map: index_map.to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/derive_proof.rs:1294:1 [INFO] [stdout] | [INFO] [stdout] 1294 | / fn build_disclosed_and_undisclosed_terms( [INFO] [stdout] 1295 | | disclosed_triple: &Option, [INFO] [stdout] 1296 | | subject_index: usize, [INFO] [stdout] 1297 | | vc_index: usize, [INFO] [stdout] ... | [INFO] [stdout] 1302 | | hasher: &BBSPlusDefaultFieldHasher, [INFO] [stdout] 1303 | | ) -> Result<(), RDFProofsError> { [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `oxrdf::BlankNode` [INFO] [stdout] --> src/derive_proof.rs:1317:60 [INFO] [stdout] | [INFO] [stdout] 1317 | .entry(NamedOrBlankNode::BlankNode(b.clone().into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `b.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `oxrdf::NamedNode` [INFO] [stdout] --> src/derive_proof.rs:1324:60 [INFO] [stdout] | [INFO] [stdout] 1324 | .entry(NamedOrBlankNode::NamedNode(n.clone().into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `n.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `oxrdf::NamedNode` [INFO] [stdout] --> src/derive_proof.rs:1338:56 [INFO] [stdout] | [INFO] [stdout] 1338 | .entry(NamedOrBlankNode::NamedNode(triple.predicate.clone().into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `triple.predicate.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `oxrdf::BlankNode` [INFO] [stdout] --> src/derive_proof.rs:1349:60 [INFO] [stdout] | [INFO] [stdout] 1349 | .entry(NamedOrBlankNode::BlankNode(b.clone().into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `b.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `oxrdf::NamedNode` [INFO] [stdout] --> src/derive_proof.rs:1356:60 [INFO] [stdout] | [INFO] [stdout] 1356 | .entry(NamedOrBlankNode::NamedNode(n.clone().into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `n.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `OrderedNamedOrBlankNodeRef` is never constructed [INFO] [stdout] --> src/ordered_triple.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 74 | pub struct OrderedNamedOrBlankNodeRef<'a>(NamedOrBlankNodeRef<'a>); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `ark_ec::short_weierstrass::Affine` [INFO] [stdout] --> src/key_gen.rs:69:19 [INFO] [stdout] | [INFO] [stdout] 69 | base: base.into(), [INFO] [stdout] | ^^^^^^^^^^^ help: consider removing `.into()`: `base` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `ark_ec::short_weierstrass::Affine` [INFO] [stdout] --> src/key_gen.rs:83:19 [INFO] [stdout] | [INFO] [stdout] 83 | base: base.into(), [INFO] [stdout] | ^^^^^^^^^^^ help: consider removing `.into()`: `base` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/blind_signature.rs:63:20 [INFO] [stdout] | [INFO] [stdout] 63 | let skip_pok = match skip_pok { [INFO] [stdout] | ____________________^ [INFO] [stdout] 64 | | Some(v) => v, [INFO] [stdout] 65 | | None => false, [INFO] [stdout] 66 | | }; [INFO] [stdout] | |_____^ help: replace it with: `skip_pok.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/ordered_triple.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 | / impl PartialOrd for OrderedGraphNameRef<'_> { [INFO] [stdout] 20 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 21 | | self.0.to_string().partial_cmp(&other.0.to_string()) [INFO] [stdout] 22 | | } [INFO] [stdout] 23 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 20 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 21 - self.0.to_string().partial_cmp(&other.0.to_string()) [INFO] [stdout] 22 - } [INFO] [stdout] 20 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/ordered_triple.rs:61:1 [INFO] [stdout] | [INFO] [stdout] 61 | / impl PartialOrd for OrderedNamedOrBlankNode { [INFO] [stdout] 62 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 63 | | self.0.to_string().partial_cmp(&other.0.to_string()) [INFO] [stdout] 64 | | } [INFO] [stdout] 65 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 62 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 63 - self.0.to_string().partial_cmp(&other.0.to_string()) [INFO] [stdout] 64 - } [INFO] [stdout] 62 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/ordered_triple.rs:80:1 [INFO] [stdout] | [INFO] [stdout] 80 | / impl PartialOrd for OrderedNamedOrBlankNodeRef<'_> { [INFO] [stdout] 81 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 82 | | self.0.to_string().partial_cmp(&other.0.to_string()) [INFO] [stdout] 83 | | } [INFO] [stdout] 84 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 81 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 82 - self.0.to_string().partial_cmp(&other.0.to_string()) [INFO] [stdout] 83 - } [INFO] [stdout] 81 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Affine` which implements the `Copy` trait [INFO] [stdout] --> src/blind_signature.rs:149:9 [INFO] [stdout] | [INFO] [stdout] 149 | commitment.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*commitment` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/signature.rs:39:37 [INFO] [stdout] | [INFO] [stdout] 39 | .map(|t| format!("{} .\n", t.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signature.rs:54:40 [INFO] [stdout] | [INFO] [stdout] 54 | let proof_config = configure_proof(&proof_option)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `proof_option` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/blind_signature.rs:208:37 [INFO] [stdout] | [INFO] [stdout] 208 | .map(|t| format!("{} .\n", t.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/blind_signature.rs:259:21 [INFO] [stdout] | [INFO] [stdout] 259 | .enumerate() [INFO] [stdout] | _____________________^ [INFO] [stdout] 260 | | .map(|(i, m)| (i, m)) [INFO] [stdout] | |_____________________________^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] = note: `#[warn(clippy::map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/blind_signature.rs:308:38 [INFO] [stdout] | [INFO] [stdout] 308 | .map(|t| format!("{} . \n", t.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `writeln!` args [INFO] [stdout] --> src/vc.rs:128:34 [INFO] [stdout] | [INFO] [stdout] 128 | writeln!(f, "{} .", t.to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `writeln!` args [INFO] [stdout] --> src/vc.rs:132:34 [INFO] [stdout] | [INFO] [stdout] 132 | writeln!(f, "{} .", t.to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `vc::VcPair` [INFO] [stdout] --> src/vc.rs:261:5 [INFO] [stdout] | [INFO] [stdout] 261 | / pub fn to_string(&self) -> String { [INFO] [stdout] 262 | | format!( [INFO] [stdout] 263 | | "vc:\n{}vc_proof:\n{}\ndisclosed_vc:\n{}disclosed_vc_proof:\n{}\n", [INFO] [stdout] 264 | | &self [INFO] [stdout] ... | [INFO] [stdout] 289 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `vc::VcPair` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] = note: `#[warn(clippy::inherent_to_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/vc.rs:268:45 [INFO] [stdout] | [INFO] [stdout] 268 | .map(|q| format!("{} .\n", q.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/vc.rs:274:45 [INFO] [stdout] | [INFO] [stdout] 274 | .map(|q| format!("{} .\n", q.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/vc.rs:280:45 [INFO] [stdout] | [INFO] [stdout] 280 | .map(|q| format!("{} .\n", q.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/vc.rs:286:45 [INFO] [stdout] | [INFO] [stdout] 286 | .map(|q| format!("{} .\n", q.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/common.rs:201:26 [INFO] [stdout] | [INFO] [stdout] 201 | statement_index_map: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 201 ~ statement_index_map: &[StatementIndexMap], [INFO] [stdout] 202 | ) -> Result, RDFProofsError> { [INFO] [stdout] 203 | let serialized_vp = rdf_canon::serialize(&vp); [INFO] [stdout] 204 ~ let serialized_vp_with_index_map = ProofSpecContext(serialized_vp, statement_index_map.to_owned()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/common.rs:203:46 [INFO] [stdout] | [INFO] [stdout] 203 | let serialized_vp = rdf_canon::serialize(&vp); [INFO] [stdout] | ^^^ help: change this to: `vp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/verify_proof.rs:117:23 [INFO] [stdout] | [INFO] [stdout] 117 | let public_keys = c14n_disclosed_vc_graphs [INFO] [stdout] | _______________________^ [INFO] [stdout] 118 | | .iter() [INFO] [stdout] 119 | | .map(|(_, vc)| key_graph.get_public_key_from_proof_graph_view(&vc.proof)) [INFO] [stdout] | |_________________________________________________________________________________^ help: try: `c14n_disclosed_vc_graphs.values().map(|vc| key_graph.get_public_key_from_proof_graph_view(&vc.proof))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/verify_proof.rs:124:21 [INFO] [stdout] | [INFO] [stdout] 124 | let is_bounds = c14n_disclosed_vc_graphs [INFO] [stdout] | _____________________^ [INFO] [stdout] 125 | | .iter() [INFO] [stdout] 126 | | .map(|(_, vc)| vc.is_bound()) [INFO] [stdout] | |_____________________________________^ help: try: `c14n_disclosed_vc_graphs.values().map(|vc| vc.is_bound())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/verify_proof.rs:130:25 [INFO] [stdout] | [INFO] [stdout] 130 | let disclosed_vec = c14n_disclosed_vc_graphs [INFO] [stdout] | _________________________^ [INFO] [stdout] 131 | | .into_iter() [INFO] [stdout] 132 | | .map(|(_, v)| v.into()) [INFO] [stdout] | |_______________________________^ help: try: `c14n_disclosed_vc_graphs.into_values().map(|v| v.into())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/common.rs:280:12 [INFO] [stdout] | [INFO] [stdout] 280 | terms: &Vec, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 280 - terms: &Vec, [INFO] [stdout] 280 + terms: &[Term], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/verify_proof.rs:418:34 [INFO] [stdout] | [INFO] [stdout] 418 | for (_, disclosed_triple) in disclosed_document { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 418 - for (_, disclosed_triple) in disclosed_document { [INFO] [stdout] 418 + for disclosed_triple in disclosed_document.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/common.rs:302:13 [INFO] [stdout] | [INFO] [stdout] 302 | Fr::try_from(timestamp) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `i64` to `Fp, 4>` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 302 - Fr::try_from(timestamp) [INFO] [stdout] 302 + From::from(timestamp) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/verify_proof.rs:433:34 [INFO] [stdout] | [INFO] [stdout] 433 | for (_, disclosed_triple) in disclosed_proof { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 433 - for (_, disclosed_triple) in disclosed_proof { [INFO] [stdout] 433 + for disclosed_triple in disclosed_proof.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/common.rs:311:13 [INFO] [stdout] | [INFO] [stdout] 311 | Fr::try_from(timestamp) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `i64` to `Fp, 4>` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 311 - Fr::try_from(timestamp) [INFO] [stdout] 311 + From::from(timestamp) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/verify_proof.rs:462:5 [INFO] [stdout] | [INFO] [stdout] 462 | / match disclosed_triple { [INFO] [stdout] 463 | | Some(triple) => { [INFO] [stdout] 464 | | match &triple.subject { [INFO] [stdout] 465 | | Subject::BlankNode(b) => { [INFO] [stdout] ... | [INFO] [stdout] 521 | | None => {} [INFO] [stdout] 522 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 462 ~ if let Some(triple) = disclosed_triple { [INFO] [stdout] 463 + match &triple.subject { [INFO] [stdout] 464 + Subject::BlankNode(b) => { [INFO] [stdout] 465 + equivs [INFO] [stdout] 466 + .entry(NamedOrBlankNode::BlankNode(b.clone().into())) [INFO] [stdout] 467 + .or_default() [INFO] [stdout] 468 + .push((vc_index, subject_index)); [INFO] [stdout] 469 + } [INFO] [stdout] 470 + Subject::NamedNode(n) if is_nym(n) => { [INFO] [stdout] 471 + equivs [INFO] [stdout] 472 + .entry(NamedOrBlankNode::NamedNode(n.clone().into())) [INFO] [stdout] 473 + .or_default() [INFO] [stdout] 474 + .push((vc_index, subject_index)); [INFO] [stdout] 475 + } [INFO] [stdout] 476 + Subject::NamedNode(n) => { [INFO] [stdout] 477 + let subject_fr = hash_term_to_field(n.into(), &hasher)?; [INFO] [stdout] 478 + disclosed_terms.insert(subject_index, subject_fr); [INFO] [stdout] 479 + } [INFO] [stdout] 480 + #[cfg(feature = "rdf-star")] [INFO] [stdout] 481 + Subject::Triple(_) => return Err(RDFProofsError::RDFStarUnsupported), [INFO] [stdout] 482 + }; [INFO] [stdout] 483 + [INFO] [stdout] 484 + if is_nym(&triple.predicate) { [INFO] [stdout] 485 + equivs [INFO] [stdout] 486 + .entry(NamedOrBlankNode::NamedNode(triple.predicate.clone().into())) [INFO] [stdout] 487 + .or_default() [INFO] [stdout] 488 + .push((vc_index, predicate_index)); [INFO] [stdout] 489 + } else { [INFO] [stdout] 490 + let predicate_fr = hash_term_to_field((&triple.predicate).into(), &hasher)?; [INFO] [stdout] 491 + disclosed_terms.insert(predicate_index, predicate_fr); [INFO] [stdout] 492 + }; [INFO] [stdout] 493 + [INFO] [stdout] 494 + match &triple.object { [INFO] [stdout] 495 + Term::BlankNode(b) => { [INFO] [stdout] 496 + equivs [INFO] [stdout] 497 + .entry(NamedOrBlankNode::BlankNode(b.clone().into())) [INFO] [stdout] 498 + .or_default() [INFO] [stdout] 499 + .push((vc_index, object_index)); [INFO] [stdout] 500 + } [INFO] [stdout] 501 + Term::NamedNode(n) if is_nym(n) => { [INFO] [stdout] 502 + equivs [INFO] [stdout] 503 + .entry(NamedOrBlankNode::NamedNode(n.clone().into())) [INFO] [stdout] 504 + .or_default() [INFO] [stdout] 505 + .push((vc_index, object_index)); [INFO] [stdout] 506 + } [INFO] [stdout] 507 + Term::NamedNode(n) => { [INFO] [stdout] 508 + let object_fr = hash_term_to_field(n.into(), &hasher)?; [INFO] [stdout] 509 + disclosed_terms.insert(object_index, object_fr); [INFO] [stdout] 510 + } [INFO] [stdout] 511 + Term::Literal(v) => { [INFO] [stdout] 512 + let object_fr = hash_term_to_field(v.into(), &hasher)?; [INFO] [stdout] 513 + disclosed_terms.insert(object_index, object_fr); [INFO] [stdout] 514 + } [INFO] [stdout] 515 + #[cfg(feature = "rdf-star")] [INFO] [stdout] 516 + Term::Triple(_) => return Err(RDFProofsError::DeriveProofValue), [INFO] [stdout] 517 + }; [INFO] [stdout] 518 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/common.rs:361:33 [INFO] [stdout] | [INFO] [stdout] 361 | .or_insert_with(|| BlankNode::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `BlankNode::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/common.rs:370:33 [INFO] [stdout] | [INFO] [stdout] 370 | .or_insert_with(|| BlankNode::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `BlankNode::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `oxrdf::BlankNode` [INFO] [stdout] --> src/verify_proof.rs:467:60 [INFO] [stdout] | [INFO] [stdout] 467 | .entry(NamedOrBlankNode::BlankNode(b.clone().into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `b.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `oxrdf::NamedNode` [INFO] [stdout] --> src/verify_proof.rs:473:60 [INFO] [stdout] | [INFO] [stdout] 473 | .entry(NamedOrBlankNode::NamedNode(n.clone().into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `n.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `oxrdf::NamedNode` [INFO] [stdout] --> src/verify_proof.rs:487:56 [INFO] [stdout] | [INFO] [stdout] 487 | .entry(NamedOrBlankNode::NamedNode(triple.predicate.clone().into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `triple.predicate.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/common.rs:391:33 [INFO] [stdout] | [INFO] [stdout] 391 | .or_insert_with(|| BlankNode::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `BlankNode::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `oxrdf::BlankNode` [INFO] [stdout] --> src/verify_proof.rs:498:60 [INFO] [stdout] | [INFO] [stdout] 498 | .entry(NamedOrBlankNode::BlankNode(b.clone().into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `b.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/common.rs:400:33 [INFO] [stdout] | [INFO] [stdout] 400 | .or_insert_with(|| BlankNode::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `BlankNode::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `oxrdf::NamedNode` [INFO] [stdout] --> src/verify_proof.rs:504:60 [INFO] [stdout] | [INFO] [stdout] 504 | .entry(NamedOrBlankNode::NamedNode(n.clone().into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `n.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/common.rs:340:20 [INFO] [stdout] | [INFO] [stdout] 340 | proof_options: &Graph, [INFO] [stdout] | ^^^^^^ the lifetime is elided here [INFO] [stdout] 341 | ) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 341 | ) -> Result, RDFProofsError> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `oxrdf::NamedOrBlankNode` [INFO] [stdout] --> src/common.rs:613:43 [INFO] [stdout] | [INFO] [stdout] 613 | result.push((var.value().to_string(), val.into())); [INFO] [stdout] | ^^^^^^^^^^ help: consider removing `.into()`: `val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/vc.rs:412:41 [INFO] [stdout] | [INFO] [stdout] 412 | fn dataset_into_ordered_graphs(dataset: &Dataset) -> OrderedGraphViews { [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 412 | fn dataset_into_ordered_graphs(dataset: &Dataset) -> OrderedGraphViews<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (11/7) [INFO] [stdout] --> src/derive_proof.rs:49:1 [INFO] [stdout] | [INFO] [stdout] 49 | / pub fn derive_proof( [INFO] [stdout] 50 | | rng: &mut R, [INFO] [stdout] 51 | | vc_pairs: &Vec, [INFO] [stdout] 52 | | deanon_map: &HashMap, [INFO] [stdout] ... | [INFO] [stdout] 60 | | circuits: HashMap, [INFO] [stdout] 61 | | ) -> Result { [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/derive_proof.rs:71:42 [INFO] [stdout] | [INFO] [stdout] 71 | || with_ppid.is_some_and(|x| x == false) [INFO] [stdout] | ^^^^^^^^^^ help: try: `!x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/derive_proof.rs:74:39 [INFO] [stdout] | [INFO] [stdout] 74 | || domain.is_some_and(|x| x == "")) [INFO] [stdout] | ^^^^^^^ help: using `is_empty` is clearer and more explicit: `x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `.map().collect()` can be replaced with `.try_for_each()` [INFO] [stdout] --> src/derive_proof.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | / vc_pairs [INFO] [stdout] 91 | | .iter() [INFO] [stdout] 92 | | .map( [INFO] [stdout] 93 | | |VcPair { original: vc, .. }| match (vc.is_bound(), secret) { [INFO] [stdout] ... | [INFO] [stdout] 100 | | .collect::>()?; [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_collect_result_unit [INFO] [stdout] = note: `#[warn(clippy::map_collect_result_unit)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 90 ~ vc_pairs [INFO] [stdout] 91 + .iter().try_for_each(|VcPair { original: vc, .. }| match (vc.is_bound(), secret) { [INFO] [stdout] 92 + (Ok(false), _) => verify(vc, key_graph), [INFO] [stdout] 93 + (Ok(true), Some(s)) => blind_verify(s, vc, key_graph), [INFO] [stdout] 94 + (Ok(true), None) => Err(RDFProofsError::MissingSecret), [INFO] [stdout] 95 + _ => Err(RDFProofsError::VCWithUnsupportedCryptosuite), [INFO] [stdout] 96 ~ })?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/derive_proof.rs:196:29 [INFO] [stdout] | [INFO] [stdout] 196 | println!("{}: {}", f.to_string(), t.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/derive_proof.rs:196:44 [INFO] [stdout] | [INFO] [stdout] 196 | println!("{}: {}", f.to_string(), t.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/derive_proof.rs:198:5 [INFO] [stdout] | [INFO] [stdout] 198 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/derive_proof.rs:216:45 [INFO] [stdout] | [INFO] [stdout] 216 | .map(|t| format!("{} .\n", t.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/derive_proof.rs:224:45 [INFO] [stdout] | [INFO] [stdout] 224 | .map(|t| format!("{} .\n", t.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/derive_proof.rs:235:45 [INFO] [stdout] | [INFO] [stdout] 235 | .map(|t| format!("{} .\n", t.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/derive_proof.rs:243:45 [INFO] [stdout] | [INFO] [stdout] 243 | .map(|t| format!("{} .\n", t.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (11/7) [INFO] [stdout] --> src/derive_proof.rs:288:1 [INFO] [stdout] | [INFO] [stdout] 288 | / pub fn derive_proof_string( [INFO] [stdout] 289 | | rng: &mut R, [INFO] [stdout] 290 | | vc_pairs: &Vec, [INFO] [stdout] 291 | | deanon_map: &HashMap, [INFO] [stdout] ... | [INFO] [stdout] 299 | | circuits: Option<&HashMap>, [INFO] [stdout] 300 | | ) -> Result { [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/derive_proof.rs:290:15 [INFO] [stdout] | [INFO] [stdout] 290 | vc_pairs: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 290 - vc_pairs: &Vec, [INFO] [stdout] 290 + vc_pairs: &[VcPairString], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/derive_proof.rs:330:30 [INFO] [stdout] | [INFO] [stdout] 330 | .map(|predicate| Ok(get_graph_from_ntriples(predicate)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 330 - .map(|predicate| Ok(get_graph_from_ntriples(predicate)?)) [INFO] [stdout] 330 + .map(|predicate| get_graph_from_ntriples(predicate)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/derive_proof.rs:371:20 [INFO] [stdout] | [INFO] [stdout] 371 | let with_nym = match with_nym { [INFO] [stdout] | ____________________^ [INFO] [stdout] 372 | | Some(v) => v, [INFO] [stdout] 373 | | None => false, [INFO] [stdout] 374 | | }; [INFO] [stdout] | |_____^ help: replace it with: `with_nym.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/derive_proof.rs:473:10 [INFO] [stdout] | [INFO] [stdout] 473 | vcs: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 473 - vcs: &Vec, [INFO] [stdout] 473 + vcs: &[VerifiableCredential], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/derive_proof.rs:512:6 [INFO] [stdout] | [INFO] [stdout] 512 | ) -> Result<(Dataset, HashMap, Vec), RDFProofsError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/derive_proof.rs:560:44 [INFO] [stdout] | [INFO] [stdout] 560 | LiteralRef::new_simple_literal(*challenge), [INFO] [stdout] | ^^^^^^^^^^ help: try: `challenge` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/derive_proof.rs:570:44 [INFO] [stdout] | [INFO] [stdout] 570 | LiteralRef::new_simple_literal(*domain), [INFO] [stdout] | ^^^^^^^ help: try: `domain` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/derive_proof.rs:693:61 [INFO] [stdout] | [INFO] [stdout] 693 | println!("vp draft (before canonicalization):\n{}\n", vp.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `HashMap` [INFO] [stdout] --> src/derive_proof.rs:715:10 [INFO] [stdout] | [INFO] [stdout] 715 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/derive_proof.rs:746:6 [INFO] [stdout] | [INFO] [stdout] 746 | ) -> Result< [INFO] [stdout] | ______^ [INFO] [stdout] 747 | | ( [INFO] [stdout] 748 | | Vec, [INFO] [stdout] 749 | | Vec, [INFO] [stdout] ... | [INFO] [stdout] 753 | | RDFProofsError, [INFO] [stdout] 754 | | > { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/derive_proof.rs:741:33 [INFO] [stdout] | [INFO] [stdout] 741 | canonicalized_original_vcs: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 741 - canonicalized_original_vcs: &Vec, [INFO] [stdout] 741 + canonicalized_original_vcs: &[VerifiableCredential], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/derive_proof.rs:745:30 [INFO] [stdout] | [INFO] [stdout] 745 | vc_document_graph_names: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 745 - vc_document_graph_names: &Vec, [INFO] [stdout] 745 + vc_document_graph_names: &[BlankNode], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/derive_proof.rs:797:27 [INFO] [stdout] | [INFO] [stdout] 797 | let original_vc_vec = ordered_original_vcs [INFO] [stdout] | ___________________________^ [INFO] [stdout] 798 | | .into_iter() [INFO] [stdout] 799 | | .map(|(_, v)| v.into()) [INFO] [stdout] | |_______________________________^ help: try: `ordered_original_vcs.into_values().map(|v| v.into())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] = note: `#[warn(clippy::iter_kv_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/derive_proof.rs:801:28 [INFO] [stdout] | [INFO] [stdout] 801 | let disclosed_vc_vec = canonicalized_disclosed_vc_graphs [INFO] [stdout] | ____________________________^ [INFO] [stdout] 802 | | .into_iter() [INFO] [stdout] 803 | | .map(|(_, v)| v.into()) [INFO] [stdout] | |_______________________________^ help: try: `canonicalized_disclosed_vc_graphs.into_values().map(|v| v.into())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `BTreeMap` [INFO] [stdout] --> src/derive_proof.rs:802:10 [INFO] [stdout] | [INFO] [stdout] 802 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/derive_proof.rs:805:31 [INFO] [stdout] | [INFO] [stdout] 805 | let vc_proof_values_vec = ordered_proof_values [INFO] [stdout] | _______________________________^ [INFO] [stdout] 806 | | .into_iter() [INFO] [stdout] 807 | | .map(|(_, v)| v.into()) [INFO] [stdout] | |_______________________________^ help: try: `ordered_proof_values.into_values().map(|v| v.into())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/derive_proof.rs:809:24 [INFO] [stdout] | [INFO] [stdout] 809 | let is_bound_vec = ordered_is_bounds [INFO] [stdout] | ________________________^ [INFO] [stdout] 810 | | .into_iter() [INFO] [stdout] 811 | | .map(|(_, v)| v) [INFO] [stdout] | |________________________^ help: try: `ordered_is_bounds.into_values()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter_mut()` and will not consume the `Vec` [INFO] [stdout] --> src/derive_proof.rs:831:32 [INFO] [stdout] | [INFO] [stdout] 831 | for triple in document.into_iter() { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter_mut()` and will not consume the `Vec` [INFO] [stdout] --> src/derive_proof.rs:836:29 [INFO] [stdout] | [INFO] [stdout] 836 | for triple in proof.into_iter() { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/derive_proof.rs:848:45 [INFO] [stdout] | [INFO] [stdout] 848 | .map(|t| format!("{} .\n", t.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/derive_proof.rs:856:45 [INFO] [stdout] | [INFO] [stdout] 856 | .map(|t| format!("{} .\n", t.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (15/7) [INFO] [stdout] --> src/derive_proof.rs:910:1 [INFO] [stdout] | [INFO] [stdout] 910 | / fn derive_proof_value( [INFO] [stdout] 911 | | rng: &mut R, [INFO] [stdout] 912 | | secret: Option<&[u8]>, [INFO] [stdout] 913 | | original_vc_triples: Vec, [INFO] [stdout] ... | [INFO] [stdout] 925 | | extended_deanon_map: &HashMap, [INFO] [stdout] 926 | | ) -> Result { [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/derive_proof.rs:1116:47 [INFO] [stdout] | [INFO] [stdout] 1116 | let context = generate_proof_spec_context(&canonicalized_vp, &index_map)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `canonicalized_vp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/derive_proof.rs:1196:16 [INFO] [stdout] | [INFO] [stdout] 1196 | index_map: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1196 ~ index_map: &[StatementIndexMap], [INFO] [stdout] 1197 | ) -> Result { [INFO] [stdout] ... [INFO] [stdout] 1201 | proof, [INFO] [stdout] 1202 ~ index_map: index_map.to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/derive_proof.rs:1294:1 [INFO] [stdout] | [INFO] [stdout] 1294 | / fn build_disclosed_and_undisclosed_terms( [INFO] [stdout] 1295 | | disclosed_triple: &Option, [INFO] [stdout] 1296 | | subject_index: usize, [INFO] [stdout] 1297 | | vc_index: usize, [INFO] [stdout] ... | [INFO] [stdout] 1302 | | hasher: &BBSPlusDefaultFieldHasher, [INFO] [stdout] 1303 | | ) -> Result<(), RDFProofsError> { [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `oxrdf::BlankNode` [INFO] [stdout] --> src/derive_proof.rs:1317:60 [INFO] [stdout] | [INFO] [stdout] 1317 | .entry(NamedOrBlankNode::BlankNode(b.clone().into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `b.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `oxrdf::NamedNode` [INFO] [stdout] --> src/derive_proof.rs:1324:60 [INFO] [stdout] | [INFO] [stdout] 1324 | .entry(NamedOrBlankNode::NamedNode(n.clone().into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `n.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `oxrdf::NamedNode` [INFO] [stdout] --> src/derive_proof.rs:1338:56 [INFO] [stdout] | [INFO] [stdout] 1338 | .entry(NamedOrBlankNode::NamedNode(triple.predicate.clone().into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `triple.predicate.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `oxrdf::BlankNode` [INFO] [stdout] --> src/derive_proof.rs:1349:60 [INFO] [stdout] | [INFO] [stdout] 1349 | .entry(NamedOrBlankNode::BlankNode(b.clone().into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `b.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `oxrdf::NamedNode` [INFO] [stdout] --> src/derive_proof.rs:1356:60 [INFO] [stdout] | [INFO] [stdout] 1356 | .entry(NamedOrBlankNode::NamedNode(n.clone().into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `n.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/derive_proof.rs:2129:36 [INFO] [stdout] | [INFO] [stdout] 2129 | get_deanon_map_from_string(&&get_example_deanon_map_string_with_hidden_literal()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&get_example_deanon_map_string_with_hidden_literal()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `ark_ec::short_weierstrass::Affine` [INFO] [stdout] --> src/key_gen.rs:69:19 [INFO] [stdout] | [INFO] [stdout] 69 | base: base.into(), [INFO] [stdout] | ^^^^^^^^^^^ help: consider removing `.into()`: `base` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `ark_ec::short_weierstrass::Affine` [INFO] [stdout] --> src/key_gen.rs:83:19 [INFO] [stdout] | [INFO] [stdout] 83 | base: base.into(), [INFO] [stdout] | ^^^^^^^^^^^ help: consider removing `.into()`: `base` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/key_gen.rs:117:27 [INFO] [stdout] | [INFO] [stdout] 117 | fn key_gen_base58btc() -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/key_gen.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | assert!(true); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `oxrdf::Graph` [INFO] [stdout] --> src/key_graph.rs:202:34 [INFO] [stdout] | [INFO] [stdout] 202 | let proof_graph: Graph = get_graph_from_ntriples(INVALID_PROOF).unwrap().into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `get_graph_from_ntriples(INVALID_PROOF).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `oxrdf::Graph` [INFO] [stdout] --> src/key_graph.rs:221:34 [INFO] [stdout] | [INFO] [stdout] 221 | let proof_graph: Graph = get_graph_from_ntriples(INVALID_PROOF).unwrap().into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `get_graph_from_ntriples(INVALID_PROOF).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/ordered_triple.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 | / impl PartialOrd for OrderedGraphNameRef<'_> { [INFO] [stdout] 20 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 21 | | self.0.to_string().partial_cmp(&other.0.to_string()) [INFO] [stdout] 22 | | } [INFO] [stdout] 23 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 20 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 21 - self.0.to_string().partial_cmp(&other.0.to_string()) [INFO] [stdout] 22 - } [INFO] [stdout] 20 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/ordered_triple.rs:61:1 [INFO] [stdout] | [INFO] [stdout] 61 | / impl PartialOrd for OrderedNamedOrBlankNode { [INFO] [stdout] 62 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 63 | | self.0.to_string().partial_cmp(&other.0.to_string()) [INFO] [stdout] 64 | | } [INFO] [stdout] 65 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 62 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 63 - self.0.to_string().partial_cmp(&other.0.to_string()) [INFO] [stdout] 64 - } [INFO] [stdout] 62 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/ordered_triple.rs:80:1 [INFO] [stdout] | [INFO] [stdout] 80 | / impl PartialOrd for OrderedNamedOrBlankNodeRef<'_> { [INFO] [stdout] 81 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 82 | | self.0.to_string().partial_cmp(&other.0.to_string()) [INFO] [stdout] 83 | | } [INFO] [stdout] 84 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 81 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 82 - self.0.to_string().partial_cmp(&other.0.to_string()) [INFO] [stdout] 83 - } [INFO] [stdout] 81 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/signature.rs:39:37 [INFO] [stdout] | [INFO] [stdout] 39 | .map(|t| format!("{} .\n", t.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signature.rs:54:40 [INFO] [stdout] | [INFO] [stdout] 54 | let proof_config = configure_proof(&proof_option)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `proof_option` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `writeln!` args [INFO] [stdout] --> src/vc.rs:128:34 [INFO] [stdout] | [INFO] [stdout] 128 | writeln!(f, "{} .", t.to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `writeln!` args [INFO] [stdout] --> src/vc.rs:132:34 [INFO] [stdout] | [INFO] [stdout] 132 | writeln!(f, "{} .", t.to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `vc::VcPair` [INFO] [stdout] --> src/vc.rs:261:5 [INFO] [stdout] | [INFO] [stdout] 261 | / pub fn to_string(&self) -> String { [INFO] [stdout] 262 | | format!( [INFO] [stdout] 263 | | "vc:\n{}vc_proof:\n{}\ndisclosed_vc:\n{}disclosed_vc_proof:\n{}\n", [INFO] [stdout] 264 | | &self [INFO] [stdout] ... | [INFO] [stdout] 289 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `vc::VcPair` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] = note: `#[warn(clippy::inherent_to_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/vc.rs:268:45 [INFO] [stdout] | [INFO] [stdout] 268 | .map(|q| format!("{} .\n", q.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/vc.rs:274:45 [INFO] [stdout] | [INFO] [stdout] 274 | .map(|q| format!("{} .\n", q.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/vc.rs:280:45 [INFO] [stdout] | [INFO] [stdout] 280 | .map(|q| format!("{} .\n", q.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/vc.rs:286:45 [INFO] [stdout] | [INFO] [stdout] 286 | .map(|q| format!("{} .\n", q.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/verify_proof.rs:117:23 [INFO] [stdout] | [INFO] [stdout] 117 | let public_keys = c14n_disclosed_vc_graphs [INFO] [stdout] | _______________________^ [INFO] [stdout] 118 | | .iter() [INFO] [stdout] 119 | | .map(|(_, vc)| key_graph.get_public_key_from_proof_graph_view(&vc.proof)) [INFO] [stdout] | |_________________________________________________________________________________^ help: try: `c14n_disclosed_vc_graphs.values().map(|vc| key_graph.get_public_key_from_proof_graph_view(&vc.proof))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/verify_proof.rs:124:21 [INFO] [stdout] | [INFO] [stdout] 124 | let is_bounds = c14n_disclosed_vc_graphs [INFO] [stdout] | _____________________^ [INFO] [stdout] 125 | | .iter() [INFO] [stdout] 126 | | .map(|(_, vc)| vc.is_bound()) [INFO] [stdout] | |_____________________________________^ help: try: `c14n_disclosed_vc_graphs.values().map(|vc| vc.is_bound())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/verify_proof.rs:130:25 [INFO] [stdout] | [INFO] [stdout] 130 | let disclosed_vec = c14n_disclosed_vc_graphs [INFO] [stdout] | _________________________^ [INFO] [stdout] 131 | | .into_iter() [INFO] [stdout] 132 | | .map(|(_, v)| v.into()) [INFO] [stdout] | |_______________________________^ help: try: `c14n_disclosed_vc_graphs.into_values().map(|v| v.into())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/verify_proof.rs:418:34 [INFO] [stdout] | [INFO] [stdout] 418 | for (_, disclosed_triple) in disclosed_document { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 418 - for (_, disclosed_triple) in disclosed_document { [INFO] [stdout] 418 + for disclosed_triple in disclosed_document.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/verify_proof.rs:433:34 [INFO] [stdout] | [INFO] [stdout] 433 | for (_, disclosed_triple) in disclosed_proof { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 433 - for (_, disclosed_triple) in disclosed_proof { [INFO] [stdout] 433 + for disclosed_triple in disclosed_proof.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/verify_proof.rs:462:5 [INFO] [stdout] | [INFO] [stdout] 462 | / match disclosed_triple { [INFO] [stdout] 463 | | Some(triple) => { [INFO] [stdout] 464 | | match &triple.subject { [INFO] [stdout] 465 | | Subject::BlankNode(b) => { [INFO] [stdout] ... | [INFO] [stdout] 521 | | None => {} [INFO] [stdout] 522 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 462 ~ if let Some(triple) = disclosed_triple { [INFO] [stdout] 463 + match &triple.subject { [INFO] [stdout] 464 + Subject::BlankNode(b) => { [INFO] [stdout] 465 + equivs [INFO] [stdout] 466 + .entry(NamedOrBlankNode::BlankNode(b.clone().into())) [INFO] [stdout] 467 + .or_default() [INFO] [stdout] 468 + .push((vc_index, subject_index)); [INFO] [stdout] 469 + } [INFO] [stdout] 470 + Subject::NamedNode(n) if is_nym(n) => { [INFO] [stdout] 471 + equivs [INFO] [stdout] 472 + .entry(NamedOrBlankNode::NamedNode(n.clone().into())) [INFO] [stdout] 473 + .or_default() [INFO] [stdout] 474 + .push((vc_index, subject_index)); [INFO] [stdout] 475 + } [INFO] [stdout] 476 + Subject::NamedNode(n) => { [INFO] [stdout] 477 + let subject_fr = hash_term_to_field(n.into(), &hasher)?; [INFO] [stdout] 478 + disclosed_terms.insert(subject_index, subject_fr); [INFO] [stdout] 479 + } [INFO] [stdout] 480 + #[cfg(feature = "rdf-star")] [INFO] [stdout] 481 + Subject::Triple(_) => return Err(RDFProofsError::RDFStarUnsupported), [INFO] [stdout] 482 + }; [INFO] [stdout] 483 + [INFO] [stdout] 484 + if is_nym(&triple.predicate) { [INFO] [stdout] 485 + equivs [INFO] [stdout] 486 + .entry(NamedOrBlankNode::NamedNode(triple.predicate.clone().into())) [INFO] [stdout] 487 + .or_default() [INFO] [stdout] 488 + .push((vc_index, predicate_index)); [INFO] [stdout] 489 + } else { [INFO] [stdout] 490 + let predicate_fr = hash_term_to_field((&triple.predicate).into(), &hasher)?; [INFO] [stdout] 491 + disclosed_terms.insert(predicate_index, predicate_fr); [INFO] [stdout] 492 + }; [INFO] [stdout] 493 + [INFO] [stdout] 494 + match &triple.object { [INFO] [stdout] 495 + Term::BlankNode(b) => { [INFO] [stdout] 496 + equivs [INFO] [stdout] 497 + .entry(NamedOrBlankNode::BlankNode(b.clone().into())) [INFO] [stdout] 498 + .or_default() [INFO] [stdout] 499 + .push((vc_index, object_index)); [INFO] [stdout] 500 + } [INFO] [stdout] 501 + Term::NamedNode(n) if is_nym(n) => { [INFO] [stdout] 502 + equivs [INFO] [stdout] 503 + .entry(NamedOrBlankNode::NamedNode(n.clone().into())) [INFO] [stdout] 504 + .or_default() [INFO] [stdout] 505 + .push((vc_index, object_index)); [INFO] [stdout] 506 + } [INFO] [stdout] 507 + Term::NamedNode(n) => { [INFO] [stdout] 508 + let object_fr = hash_term_to_field(n.into(), &hasher)?; [INFO] [stdout] 509 + disclosed_terms.insert(object_index, object_fr); [INFO] [stdout] 510 + } [INFO] [stdout] 511 + Term::Literal(v) => { [INFO] [stdout] 512 + let object_fr = hash_term_to_field(v.into(), &hasher)?; [INFO] [stdout] 513 + disclosed_terms.insert(object_index, object_fr); [INFO] [stdout] 514 + } [INFO] [stdout] 515 + #[cfg(feature = "rdf-star")] [INFO] [stdout] 516 + Term::Triple(_) => return Err(RDFProofsError::DeriveProofValue), [INFO] [stdout] 517 + }; [INFO] [stdout] 518 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `oxrdf::BlankNode` [INFO] [stdout] --> src/verify_proof.rs:467:60 [INFO] [stdout] | [INFO] [stdout] 467 | .entry(NamedOrBlankNode::BlankNode(b.clone().into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `b.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `oxrdf::NamedNode` [INFO] [stdout] --> src/verify_proof.rs:473:60 [INFO] [stdout] | [INFO] [stdout] 473 | .entry(NamedOrBlankNode::NamedNode(n.clone().into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `n.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `oxrdf::NamedNode` [INFO] [stdout] --> src/verify_proof.rs:487:56 [INFO] [stdout] | [INFO] [stdout] 487 | .entry(NamedOrBlankNode::NamedNode(triple.predicate.clone().into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `triple.predicate.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `oxrdf::BlankNode` [INFO] [stdout] --> src/verify_proof.rs:498:60 [INFO] [stdout] | [INFO] [stdout] 498 | .entry(NamedOrBlankNode::BlankNode(b.clone().into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `b.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `oxrdf::NamedNode` [INFO] [stdout] --> src/verify_proof.rs:504:60 [INFO] [stdout] | [INFO] [stdout] 504 | .entry(NamedOrBlankNode::NamedNode(n.clone().into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `n.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/common.rs:340:20 [INFO] [stdout] | [INFO] [stdout] 340 | proof_options: &Graph, [INFO] [stdout] | ^^^^^^ the lifetime is elided here [INFO] [stdout] 341 | ) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 341 | ) -> Result, RDFProofsError> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/vc.rs:412:41 [INFO] [stdout] | [INFO] [stdout] 412 | fn dataset_into_ordered_graphs(dataset: &Dataset) -> OrderedGraphViews { [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 412 | fn dataset_into_ordered_graphs(dataset: &Dataset) -> OrderedGraphViews<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 55s [INFO] running `Command { std: "docker" "inspect" "dd9cb0384ba87a4368dc2c1d68002ba2552e120b258d9d5b383933dfc7ed4460", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dd9cb0384ba87a4368dc2c1d68002ba2552e120b258d9d5b383933dfc7ed4460", kill_on_drop: false }` [INFO] [stdout] dd9cb0384ba87a4368dc2c1d68002ba2552e120b258d9d5b383933dfc7ed4460