[INFO] fetching crate rav1d-safe 0.3.1... [INFO] linting rav1d-safe-0.3.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate rav1d-safe 0.3.1 into /workspace/builds/worker-3-tc1/source [INFO] removed /workspace/builds/worker-3-tc1/source/rust-toolchain.toml [INFO] started tweaking crates.io crate rav1d-safe 0.3.1 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate rav1d-safe 0.3.1 [INFO] tweaked toml for crates.io crate rav1d-safe 0.3.1 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate rav1d-safe 0.3.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate rav1d-safe 0.3.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded bitreader v0.3.11 [INFO] [stderr] Downloaded enough v0.3.1 [INFO] [stderr] Downloaded glob-match v0.2.1 [INFO] [stderr] Downloaded to_method v1.1.0 [INFO] [stderr] Downloaded tango-bench v0.6.0 [INFO] [stderr] Downloaded colorz v1.1.4 [INFO] [stderr] Downloaded nasm-rs v0.3.2 [INFO] [stderr] Downloaded fallible_collections v0.5.1 [INFO] [stderr] Downloaded atomig-macro v0.4.0 [INFO] [stderr] Downloaded archmage-macros v0.8.4 [INFO] [stderr] Downloaded atomig v0.4.3 [INFO] [stderr] Downloaded safe_unaligned_simd v0.2.4 [INFO] [stderr] Downloaded rav1d-disjoint-mut v0.3.0 [INFO] [stderr] Downloaded goblin v0.7.1 [INFO] [stderr] Downloaded zenavif-parse v0.3.0 [INFO] [stderr] Downloaded archmage v0.8.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6403a47a5528d6eac4a76f3c1f11100168f7786238de284a49e4000dd3668349 [INFO] running `Command { std: "docker" "start" "-a" "6403a47a5528d6eac4a76f3c1f11100168f7786238de284a49e4000dd3668349", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6403a47a5528d6eac4a76f3c1f11100168f7786238de284a49e4000dd3668349", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6403a47a5528d6eac4a76f3c1f11100168f7786238de284a49e4000dd3668349", kill_on_drop: false }` [INFO] [stdout] 6403a47a5528d6eac4a76f3c1f11100168f7786238de284a49e4000dd3668349 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 72ef2d1eace50b7995c3c5dd64bee298953dd08ad04f7be31a4e9223dfb05989 [INFO] running `Command { std: "docker" "start" "-a" "72ef2d1eace50b7995c3c5dd64bee298953dd08ad04f7be31a4e9223dfb05989", kill_on_drop: false }` [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Checking cfg-if v1.0.4 [INFO] [stderr] Checking libc v0.2.182 [INFO] [stderr] Compiling syn v2.0.115 [INFO] [stderr] Checking bitflags v2.11.0 [INFO] [stderr] Compiling nasm-rs v0.3.2 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Compiling tango-bench v0.6.0 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking anstyle-parse v0.2.7 [INFO] [stderr] Checking anstyle-query v1.1.5 [INFO] [stderr] Checking colorchoice v1.0.4 [INFO] [stderr] Checking is_terminal_polyfill v1.70.2 [INFO] [stderr] Checking anstyle v1.0.13 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking clap_lex v1.0.0 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking stable_deref_trait v1.2.1 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking as-slice v0.2.1 [INFO] [stderr] Compiling rav1d-safe v0.3.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Checking is_ci v1.2.0 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking lock_api v0.4.14 [INFO] [stderr] Checking supports-color v3.0.2 [INFO] [stderr] Checking aligned v0.4.3 [INFO] [stderr] Checking fastrand v2.3.0 [INFO] [stderr] Checking once_cell v1.21.3 [INFO] [stderr] Checking plain v0.2.3 [INFO] [stderr] Checking safe_unaligned_simd v0.2.4 [INFO] [stderr] Checking colorz v1.1.4 [INFO] [stderr] Checking raw-cpuid v11.6.0 [INFO] [stderr] Checking libloading v0.8.9 [INFO] [stderr] Checking bitreader v0.3.11 [INFO] [stderr] Checking alloca v0.4.0 [INFO] [stderr] Checking anyhow v1.0.101 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking getrandom v0.4.1 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking num-traits v0.2.19 [INFO] [stderr] Checking condtype v1.3.0 [INFO] [stderr] Checking leb128 v0.2.5 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking fallible_collections v0.5.1 [INFO] [stderr] Checking glob-match v0.2.1 [INFO] [stderr] Checking to_method v1.1.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking assert_matches v1.5.0 [INFO] [stderr] Checking regex-lite v0.1.9 [INFO] [stderr] Checking enough v0.3.1 [INFO] [stderr] Checking zenavif-parse v0.3.0 [INFO] [stderr] Checking md5 v0.8.0 [INFO] [stderr] Checking terminal_size v0.4.3 [INFO] [stderr] Checking tempfile v3.25.0 [INFO] [stderr] Checking clap_builder v4.5.58 [INFO] [stderr] Compiling zerocopy-derive v0.8.39 [INFO] [stderr] Compiling equator-macro v0.4.2 [INFO] [stderr] Compiling scroll_derive v0.11.1 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Compiling atomig-macro v0.4.0 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling strum_macros v0.27.2 [INFO] [stderr] Compiling archmage-macros v0.8.4 [INFO] [stderr] Compiling divan-macros v0.1.21 [INFO] [stderr] Checking equator v0.4.2 [INFO] [stderr] Checking scroll v0.11.0 [INFO] [stderr] Checking aligned-vec v0.6.4 [INFO] [stderr] Checking goblin v0.7.1 [INFO] [stderr] Checking atomig v0.4.3 [INFO] [stderr] Checking zerocopy v0.8.39 [INFO] [stderr] Checking archmage v0.8.4 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking clap v4.5.58 [INFO] [stderr] Checking divan v0.1.21 [INFO] [stderr] Checking strum v0.27.2 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rav1d-disjoint-mut v0.3.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> examples/demo_simple.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | / match decoder.decode(frame_data)? { [INFO] [stdout] 56 | | Some(frame) => { [INFO] [stdout] 57 | | println!("Frame {}:", i + 1); [INFO] [stdout] 58 | | println!(" Size: {}x{}", frame.width(), frame.height()); [INFO] [stdout] ... | [INFO] [stdout] 97 | | None => {} [INFO] [stdout] 98 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 55 ~ if let Some(frame) = decoder.decode(frame_data)? { [INFO] [stdout] 56 + println!("Frame {}:", i + 1); [INFO] [stdout] 57 + println!(" Size: {}x{}", frame.width(), frame.height()); [INFO] [stdout] 58 + println!(" Bit depth: {}", frame.bit_depth()); [INFO] [stdout] 59 + println!(" Layout: {:?}", frame.pixel_layout()); [INFO] [stdout] 60 + [INFO] [stdout] 61 + // Color info [INFO] [stdout] 62 + let color = frame.color_info(); [INFO] [stdout] 63 + println!(" Color primaries: {:?}", color.primaries); [INFO] [stdout] 64 + println!(" Transfer: {:?}", color.transfer_characteristics); [INFO] [stdout] 65 + [INFO] [stdout] 66 + // HDR metadata [INFO] [stdout] 67 + if let Some(cll) = frame.content_light() { [INFO] [stdout] 68 + println!(" HDR Max CLL: {} nits", cll.max_content_light_level); [INFO] [stdout] 69 + } [INFO] [stdout] 70 + [INFO] [stdout] 71 + // Zero-copy pixel access [INFO] [stdout] 72 + match frame.planes() { [INFO] [stdout] 73 + Planes::Depth8(planes) => { [INFO] [stdout] 74 + let y = planes.y(); [INFO] [stdout] 75 + println!( [INFO] [stdout] 76 + " Y plane: {}x{} (stride={})", [INFO] [stdout] 77 + y.width(), [INFO] [stdout] 78 + y.height(), [INFO] [stdout] 79 + y.stride() [INFO] [stdout] 80 + ); [INFO] [stdout] 81 + println!(" First pixel: {}", y.pixel(0, 0)); [INFO] [stdout] 82 + } [INFO] [stdout] 83 + Planes::Depth16(planes) => { [INFO] [stdout] 84 + let y = planes.y(); [INFO] [stdout] 85 + println!( [INFO] [stdout] 86 + " Y plane: {}x{} (stride={})", [INFO] [stdout] 87 + y.width(), [INFO] [stdout] 88 + y.height(), [INFO] [stdout] 89 + y.stride() [INFO] [stdout] 90 + ); [INFO] [stdout] 91 + println!(" First pixel: {}", y.pixel(0, 0)); [INFO] [stdout] 92 + } [INFO] [stdout] 93 + } [INFO] [stdout] 94 + println!(); [INFO] [stdout] 95 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> benches/decode.rs:106:5 [INFO] [stdout] | [INFO] [stdout] 106 | entries.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 106 - entries.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] 106 + entries.sort_by_key(|b| std::cmp::Reverse(b.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> benches/decode.rs:123:41 [INFO] [stdout] | [INFO] [stdout] 123 | let rel = path.strip_prefix(&vectors_dir()).unwrap_or(&path).display(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `vectors_dir()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> benches/decode.rs:129:27 [INFO] [stdout] | [INFO] [stdout] 129 | .strip_prefix(&vectors_dir()) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `vectors_dir()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 48s [INFO] running `Command { std: "docker" "inspect" "72ef2d1eace50b7995c3c5dd64bee298953dd08ad04f7be31a4e9223dfb05989", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "72ef2d1eace50b7995c3c5dd64bee298953dd08ad04f7be31a4e9223dfb05989", kill_on_drop: false }` [INFO] [stdout] 72ef2d1eace50b7995c3c5dd64bee298953dd08ad04f7be31a4e9223dfb05989