[INFO] fetching crate ratelimit_meter 5.0.0... [INFO] linting ratelimit_meter-5.0.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate ratelimit_meter 5.0.0 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate ratelimit_meter 5.0.0 [INFO] finished tweaking crates.io crate ratelimit_meter 5.0.0 [INFO] tweaked toml for crates.io crate ratelimit_meter 5.0.0 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate ratelimit_meter 5.0.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 68 packages to latest compatible versions [INFO] [stderr] Adding criterion v0.2.11 (available: v0.8.2) [INFO] [stderr] Adding evmap v6.0.1 (available: v11.0.0) [INFO] [stderr] Adding nonzero_ext v0.1.5 (available: v0.3.0) [INFO] [stderr] Adding parking_lot v0.9.0 (available: v0.12.5) [INFO] [stderr] Adding spin v0.5.2 (available: v0.10.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded evmap v6.0.1 [INFO] [stderr] Downloaded nonzero_ext v0.1.5 [INFO] [stderr] Downloaded hashbrown v0.5.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a39520f6f36996b5f6dae1cc7e142b37c28c6b235d36822253520c8055d9a330 [INFO] running `Command { std: "docker" "start" "-a" "a39520f6f36996b5f6dae1cc7e142b37c28c6b235d36822253520c8055d9a330", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a39520f6f36996b5f6dae1cc7e142b37c28c6b235d36822253520c8055d9a330", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a39520f6f36996b5f6dae1cc7e142b37c28c6b235d36822253520c8055d9a330", kill_on_drop: false }` [INFO] [stdout] a39520f6f36996b5f6dae1cc7e142b37c28c6b235d36822253520c8055d9a330 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 80edb95df5eed29cce97dcb6cb2fc69b5b70a730ccbebd6aa1a98c90673dab0a [INFO] running `Command { std: "docker" "start" "-a" "80edb95df5eed29cce97dcb6cb2fc69b5b70a730ccbebd6aa1a98c90673dab0a", kill_on_drop: false }` [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling cast v0.2.7 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking csv-core v0.1.13 [INFO] [stderr] Checking hashbrown v0.5.0 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking nonzero_ext v0.1.5 [INFO] [stderr] Checking rand_xoshiro v0.1.0 [INFO] [stderr] Checking evmap v6.0.1 [INFO] [stderr] Checking ratelimit_meter v5.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: `feature = "cargo-clippy"` was replaced by `clippy` [INFO] [stdout] --> src/lib.rs:218:13 [INFO] [stdout] | [INFO] [stdout] 218 | #![cfg_attr(feature = "cargo-clippy", deny(warnings))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `clippy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_clippy_cfg_attr [INFO] [stdout] = note: `#[warn(clippy::deprecated_clippy_cfg_attr)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/lib.rs:218:13 [INFO] [stdout] | [INFO] [stdout] 218 | #![cfg_attr(feature = "cargo-clippy", deny(warnings))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `evmap`, `no_std`, `parking_lot`, `spin`, and `std` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous glob re-exports [INFO] [stdout] --> src/algorithms.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub use self::gcra::*; [INFO] [stdout] | ^^^^^^^^^^^^^ the name `State` in the type namespace is first re-exported here [INFO] [stdout] 7 | pub use self::leaky_bucket::*; [INFO] [stdout] | --------------------- but the name `State` in the type namespace is also re-exported here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `v.get(0)` [INFO] [stdout] --> src/state/keyed.rs:292:34 [INFO] [stdout] | [INFO] [stdout] 292 | if let Some(state) = v.get(0) { [INFO] [stdout] | ^^^^^^^^ help: try: `v.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.map_capacity` after checking its variant with `is_some` [INFO] [stdout] --> src/state/keyed.rs:401:32 [INFO] [stdout] | [INFO] [stdout] 399 | let (r, mut w) = if self.map_capacity.is_some() { [INFO] [stdout] | ------------------------------ help: try: `if let Some() = self.map_capacity` [INFO] [stdout] 400 | map_opts [INFO] [stdout] 401 | .with_capacity(self.map_capacity.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking criterion-plot v0.3.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking csv v1.4.0 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.2.11 [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/keyed.rs:77:13 [INFO] [stdout] | [INFO] [stdout] 77 | assert!(!lim.check_at("foo", now + ms * 2).is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `lim.check_at("foo", now + ms * 2).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `feature = "cargo-clippy"` was replaced by `clippy` [INFO] [stdout] --> src/lib.rs:218:13 [INFO] [stdout] | [INFO] [stdout] 218 | #![cfg_attr(feature = "cargo-clippy", deny(warnings))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `clippy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_clippy_cfg_attr [INFO] [stdout] = note: `#[warn(clippy::deprecated_clippy_cfg_attr)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> tests/gcra.rs:15:61 [INFO] [stdout] | [INFO] [stdout] 15 | let state = ::BucketState::default();; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> tests/gcra.rs:23:61 [INFO] [stdout] | [INFO] [stdout] 23 | let state = ::BucketState::default();; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> tests/gcra.rs:39:61 [INFO] [stdout] | [INFO] [stdout] 39 | let state = ::BucketState::default();; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> tests/gcra.rs:53:61 [INFO] [stdout] | [INFO] [stdout] 53 | let state = ::BucketState::default();; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> tests/gcra.rs:75:61 [INFO] [stdout] | [INFO] [stdout] 75 | let state = ::BucketState::default();; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/leaky_bucket.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 104 | assert!(!lim.check_at(now + ms * 2).is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `lim.check_at(now + ms * 2).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> tests/leaky_bucket.rs:121:9 [INFO] [stdout] | [INFO] [stdout] 121 | assert!(false, "Second attempt should fail"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/gcra.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | assert!(!gcra.test_n_and_update(&state, 2, now + ms).is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `gcra.test_n_and_update(&state, 2, now + ms).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/gcra.rs:80:13 [INFO] [stdout] | [INFO] [stdout] 80 | assert!(!gcra.test_and_update(&state, now + ms * 10).is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `gcra.test_and_update(&state, now + ms * 10).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> tests/gcra.rs:151:32 [INFO] [stdout] | [INFO] [stdout] 151 | .map(|(n, c)| c.join().expect(&format!("thread {} panicked", n))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("thread {} panicked", n))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> tests/gcra.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 174 | assert!(false, "Second attempt should fail"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/lib.rs:218:13 [INFO] [stdout] | [INFO] [stdout] 218 | #![cfg_attr(feature = "cargo-clippy", deny(warnings))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `evmap`, `no_std`, `parking_lot`, `spin`, and `std` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous glob re-exports [INFO] [stdout] --> src/algorithms.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub use self::gcra::*; [INFO] [stdout] | ^^^^^^^^^^^^^ the name `State` in the type namespace is first re-exported here [INFO] [stdout] 7 | pub use self::leaky_bucket::*; [INFO] [stdout] | --------------------- but the name `State` in the type namespace is also re-exported here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `v.get(0)` [INFO] [stdout] --> src/state/keyed.rs:292:34 [INFO] [stdout] | [INFO] [stdout] 292 | if let Some(state) = v.get(0) { [INFO] [stdout] | ^^^^^^^^ help: try: `v.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.map_capacity` after checking its variant with `is_some` [INFO] [stdout] --> src/state/keyed.rs:401:32 [INFO] [stdout] | [INFO] [stdout] 399 | let (r, mut w) = if self.map_capacity.is_some() { [INFO] [stdout] | ------------------------------ help: try: `if let Some() = self.map_capacity` [INFO] [stdout] 400 | map_opts [INFO] [stdout] 401 | .with_capacity(self.map_capacity.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.22s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: criterion v0.2.11 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 3` [INFO] running `Command { std: "docker" "inspect" "80edb95df5eed29cce97dcb6cb2fc69b5b70a730ccbebd6aa1a98c90673dab0a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "80edb95df5eed29cce97dcb6cb2fc69b5b70a730ccbebd6aa1a98c90673dab0a", kill_on_drop: false }` [INFO] [stdout] 80edb95df5eed29cce97dcb6cb2fc69b5b70a730ccbebd6aa1a98c90673dab0a