[INFO] fetching crate rapid-web 0.4.9... [INFO] linting rapid-web-0.4.9 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate rapid-web 0.4.9 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate rapid-web 0.4.9 [INFO] finished tweaking crates.io crate rapid-web 0.4.9 [INFO] tweaked toml for crates.io crate rapid-web 0.4.9 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate rapid-web 0.4.9 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 348 packages to latest compatible versions [INFO] [stderr] Adding actix-cors v0.6.5 (available: v0.7.1) [INFO] [stderr] Adding clerk-rs v0.1.9 (available: v0.4.2) [INFO] [stderr] Adding colorful v0.2.2 (available: v0.3.2) [INFO] [stderr] Adding generic-array v0.14.7 (available: v0.14.9) [INFO] [stderr] Adding spinach v2.1.0 (available: v3.2.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tiny-gradient v0.1.0 [INFO] [stderr] Downloaded rust-embed-utils v7.8.1 [INFO] [stderr] Downloaded rapid-web-codegen v0.2.8 [INFO] [stderr] Downloaded terminal-emoji v0.4.1 [INFO] [stderr] Downloaded terminal-supports-emoji v0.1.3 [INFO] [stderr] Downloaded rust-embed-impl v6.8.1 [INFO] [stderr] Downloaded actix-cors v0.6.5 [INFO] [stderr] Downloaded actix-web-httpauth v0.8.2 [INFO] [stderr] Downloaded actix-files v0.6.10 [INFO] [stderr] Downloaded colorful v0.2.2 [INFO] [stderr] Downloaded spinach v2.1.0 [INFO] [stderr] Downloaded tui v0.19.0 [INFO] [stderr] Downloaded clerk-rs v0.1.9 [INFO] [stderr] Downloaded rapid-cli v0.6.0 [INFO] [stderr] Downloaded rust-embed v6.8.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e63fed27980d0327c1f255b245d3b6df5acd03d957c4ca5a7f78f3b2b629cad8 [INFO] running `Command { std: "docker" "start" "-a" "e63fed27980d0327c1f255b245d3b6df5acd03d957c4ca5a7f78f3b2b629cad8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e63fed27980d0327c1f255b245d3b6df5acd03d957c4ca5a7f78f3b2b629cad8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e63fed27980d0327c1f255b245d3b6df5acd03d957c4ca5a7f78f3b2b629cad8", kill_on_drop: false }` [INFO] [stdout] e63fed27980d0327c1f255b245d3b6df5acd03d957c4ca5a7f78f3b2b629cad8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0d7b850aa0f41f4705b6b01ba2ae852782b24900faca43bb5cd7f9c81ac8fcb7 [INFO] running `Command { std: "docker" "start" "-a" "0d7b850aa0f41f4705b6b01ba2ae852782b24900faca43bb5cd7f9c81ac8fcb7", kill_on_drop: false }` [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Compiling cc v1.2.57 [INFO] [stderr] Compiling num-conv v0.2.0 [INFO] [stderr] Compiling time-core v0.1.8 [INFO] [stderr] Checking deranged v0.5.8 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking local-waker v0.1.4 [INFO] [stderr] Compiling pin-project-lite v0.2.17 [INFO] [stderr] Compiling bytes v1.11.1 [INFO] [stderr] Checking bytestring v1.5.0 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking actix-utils v3.0.1 [INFO] [stderr] Compiling tracing v0.1.44 [INFO] [stderr] Checking rand_core v0.9.5 [INFO] [stderr] Checking actix-service v2.0.3 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling cookie v0.16.2 [INFO] [stderr] Compiling time-macros v0.2.27 [INFO] [stderr] Compiling regex-lite v0.1.9 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking local-channel v0.1.5 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking signal-hook v0.3.18 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking language-tags v0.3.2 [INFO] [stderr] Checking foldhash v0.1.5 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Checking impl-more v0.1.9 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Compiling actix-router v0.5.4 [INFO] [stderr] Checking anstyle-parse v1.0.0 [INFO] [stderr] Compiling nix v0.31.2 [INFO] [stderr] Compiling include_dir_macros v0.7.4 [INFO] [stderr] Checking signal-hook-mio v0.2.5 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking futures-channel v0.3.32 [INFO] [stderr] Checking crossterm v0.25.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking colorchoice v1.0.5 [INFO] [stderr] Checking anstyle v1.0.14 [INFO] [stderr] Checking textwrap v0.15.2 [INFO] [stderr] Compiling rust-embed-utils v7.8.1 [INFO] [stderr] Checking getrandom v0.4.2 [INFO] [stderr] Checking is-terminal v0.4.17 [INFO] [stderr] Compiling v_htmlescape v0.15.8 [INFO] [stderr] Checking clap_lex v1.1.0 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking anstream v1.0.0 [INFO] [stderr] Checking tempfile v3.27.0 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking terminal-supports-emoji v0.1.3 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking time v0.3.47 [INFO] [stderr] Checking shell-words v1.1.1 [INFO] [stderr] Checking terminal-emoji v0.4.1 [INFO] [stderr] Checking clap_builder v4.6.0 [INFO] [stderr] Checking requestty-ui v0.5.0 [INFO] [stderr] Checking tui v0.19.0 [INFO] [stderr] Checking tiny-gradient v0.1.0 [INFO] [stderr] Compiling include_dir v0.7.4 [INFO] [stderr] Checking pretty_env_logger v0.5.0 [INFO] [stderr] Checking strum v0.24.1 [INFO] [stderr] Checking colorful v0.2.2 [INFO] [stderr] Checking http-range v0.1.5 [INFO] [stderr] Checking spinach v2.1.0 [INFO] [stderr] Compiling zstd-sys v2.0.16+zstd.1.5.7 [INFO] [stderr] Compiling openssl-sys v0.9.112 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking requestty v0.5.0 [INFO] [stderr] Checking ctrlc v3.5.2 [INFO] [stderr] Compiling openssl v0.10.76 [INFO] [stderr] Compiling native-tls v0.2.18 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Compiling strum_macros v0.24.3 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling futures-macro v0.3.32 [INFO] [stderr] Compiling actix-macros v0.2.4 [INFO] [stderr] Compiling derive_more-impl v2.1.1 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling actix-web-codegen v4.3.0 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Checking actix-rt v2.11.0 [INFO] [stderr] Compiling rust-embed-impl v6.8.1 [INFO] [stderr] Compiling clap_derive v4.6.0 [INFO] [stderr] Compiling derive_more v0.99.20 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Compiling rapid-web-codegen v0.2.8 [INFO] [stderr] Checking rust-embed v6.8.1 [INFO] [stderr] Compiling zstd-safe v7.2.4 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Checking simple_asn1 v0.6.4 [INFO] [stderr] Checking actix-codec v0.5.2 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Compiling serde_with_macros v2.3.3 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking clap v4.6.0 [INFO] [stderr] Checking derive_more v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Checking actix-server v2.6.0 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking jsonwebtoken v8.3.0 [INFO] [stderr] Checking serde_with v2.3.3 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking toml_edit v0.19.15 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking toml v0.7.8 [INFO] [stderr] Checking rapid-cli v0.6.0 [INFO] [stderr] Checking actix-http v3.12.0 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking actix-web v4.13.0 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking clerk-rs v0.1.9 [INFO] [stderr] Checking actix-cors v0.6.5 [INFO] [stderr] Checking actix-files v0.6.10 [INFO] [stderr] Checking actix-web-httpauth v0.8.2 [INFO] [stderr] Checking rapid-web v0.4.9 (/opt/rustwide/workdir) [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/server.rs:52:4 [INFO] [stdout] | [INFO] [stdout] 52 | /// RapidServer::router(None).route("/", web::get().to(route)) [INFO] [stdout] | ^^^^^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] = note: `#[warn(clippy::tabs_in_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/shift/generate.rs:349:5 [INFO] [stdout] | [INFO] [stdout] 349 | /// index: '/' [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/server.rs:52:4 [INFO] [stdout] | [INFO] [stdout] 52 | /// RapidServer::router(None).route("/", web::get().to(route)) [INFO] [stdout] | ^^^^^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] = note: `#[warn(clippy::tabs_in_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/util.rs:10:30 [INFO] [stdout] | [INFO] [stdout] 10 | pub const REMIX_ROUTE_PATH: &'static str = "app/api/routes"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/util.rs:11:31 [INFO] [stdout] | [INFO] [stdout] 11 | pub const NEXTJS_ROUTE_PATH: &'static str = "pages/api/routes"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/shift/generate.rs:349:5 [INFO] [stdout] | [INFO] [stdout] 349 | /// index: '/' [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/util.rs:10:30 [INFO] [stdout] | [INFO] [stdout] 10 | pub const REMIX_ROUTE_PATH: &'static str = "app/api/routes"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/util.rs:11:31 [INFO] [stdout] | [INFO] [stdout] 11 | pub const NEXTJS_ROUTE_PATH: &'static str = "pages/api/routes"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `format!` args [INFO] [stdout] --> src/logger.rs:105:14 [INFO] [stdout] | [INFO] [stdout] 105 | let logs = format!( [INFO] [stdout] | ____________________^ [INFO] [stdout] 106 | | "REQUEST {} {} {} {:?} {} {} {}", [INFO] [stdout] 107 | | request_method, [INFO] [stdout] 108 | | request_path, [INFO] [stdout] ... | [INFO] [stdout] 113 | | format!("{}{}", "agent=".color(Color::LightBlue), agent) [INFO] [stdout] 114 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `format!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/logger.rs:127:7 [INFO] [stdout] | [INFO] [stdout] 127 | if headers.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `headers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `format!` args [INFO] [stdout] --> src/logger.rs:138:14 [INFO] [stdout] | [INFO] [stdout] 138 | let logs = format!( [INFO] [stdout] | ____________________^ [INFO] [stdout] 139 | | "RESPONSE {} {}", [INFO] [stdout] 140 | | response_status, [INFO] [stdout] 141 | | format!("{}{:?}", "headers=".color(Color::LightCyan), response_headers) [INFO] [stdout] 142 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `format!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `LoggerType` which implements the `Copy` trait [INFO] [stdout] --> src/logger.rs:216:25 [INFO] [stdout] | [INFO] [stdout] 216 | let cloned_log_type = self.log_type.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.log_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/server.rs:78:18 [INFO] [stdout] | [INFO] [stdout] 78 | .wrap(cors.unwrap_or(Cors::default())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/server.rs:82:18 [INFO] [stdout] | [INFO] [stdout] 82 | .wrap(cors.unwrap_or(Cors::default())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/server.rs:88:17 [INFO] [stdout] | [INFO] [stdout] 88 | .wrap(cors.unwrap_or(Cors::default())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> src/server.rs:185:22 [INFO] [stdout] | [INFO] [stdout] 185 | let fallback_port = match port { [INFO] [stdout] | _________________________^ [INFO] [stdout] 186 | | Some(value) => value, [INFO] [stdout] 187 | | None => 8080, [INFO] [stdout] 188 | | }; [INFO] [stdout] | |_____^ help: replace with: `port.unwrap_or(8080)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/server.rs:227:37 [INFO] [stdout] | [INFO] [stdout] 227 | let type_generation_directory = if every_dir_types_gen != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!every_dir_types_gen.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `format!` args [INFO] [stdout] --> src/logger.rs:105:14 [INFO] [stdout] | [INFO] [stdout] 105 | let logs = format!( [INFO] [stdout] | ____________________^ [INFO] [stdout] 106 | | "REQUEST {} {} {} {:?} {} {} {}", [INFO] [stdout] 107 | | request_method, [INFO] [stdout] 108 | | request_path, [INFO] [stdout] ... | [INFO] [stdout] 113 | | format!("{}{}", "agent=".color(Color::LightBlue), agent) [INFO] [stdout] 114 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `format!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/logger.rs:127:7 [INFO] [stdout] | [INFO] [stdout] 127 | if headers.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `headers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `format!` args [INFO] [stdout] --> src/logger.rs:138:14 [INFO] [stdout] | [INFO] [stdout] 138 | let logs = format!( [INFO] [stdout] | ____________________^ [INFO] [stdout] 139 | | "RESPONSE {} {}", [INFO] [stdout] 140 | | response_status, [INFO] [stdout] 141 | | format!("{}{:?}", "headers=".color(Color::LightCyan), response_headers) [INFO] [stdout] 142 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `format!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/shift/convert.rs:292:3 [INFO] [stdout] | [INFO] [stdout] 292 | self.store.push_str("}"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `self.store.push('}')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/shift/convert.rs:302:6 [INFO] [stdout] | [INFO] [stdout] 302 | if !(get_rust_typename(&primitive) == converted.typescript_type) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(get_rust_typename(&primitive) != converted.typescript_type)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/shift/convert.rs:381:8 [INFO] [stdout] | [INFO] [stdout] 381 | if !(path.extension().unwrap_or(OsStr::new("")).to_str().unwrap_or("") == "rs") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(path.extension().unwrap_or(OsStr::new("")).to_str().unwrap_or("") != "rs")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/shift/convert.rs:386:31 [INFO] [stdout] | [INFO] [stdout] 386 | let mut file = File::open(&path).expect("Could not open file while attempting to generate Typescript types!"); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/shift/convert.rs:411:11 [INFO] [stdout] | [INFO] [stdout] 411 | ... if val.ident.to_string() == "RapidOutput" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `val.ident` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/shift/generate.rs:73:29 [INFO] [stdout] | [INFO] [stdout] 73 | let mut file = File::open(&entry.path()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `entry.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/shift/generate.rs:97:8 [INFO] [stdout] | [INFO] [stdout] 97 | if val.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!val.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `LoggerType` which implements the `Copy` trait [INFO] [stdout] --> src/logger.rs:216:25 [INFO] [stdout] | [INFO] [stdout] 216 | let cloned_log_type = self.log_type.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.log_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/shift/generate.rs:184:5 [INFO] [stdout] | [INFO] [stdout] 184 | if handlers.len() < 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `handlers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/server.rs:78:18 [INFO] [stdout] | [INFO] [stdout] 78 | .wrap(cors.unwrap_or(Cors::default())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/server.rs:82:18 [INFO] [stdout] | [INFO] [stdout] 82 | .wrap(cors.unwrap_or(Cors::default())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/server.rs:88:17 [INFO] [stdout] | [INFO] [stdout] 88 | .wrap(cors.unwrap_or(Cors::default())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> src/server.rs:185:22 [INFO] [stdout] | [INFO] [stdout] 185 | let fallback_port = match port { [INFO] [stdout] | _________________________^ [INFO] [stdout] 186 | | Some(value) => value, [INFO] [stdout] 187 | | None => 8080, [INFO] [stdout] 188 | | }; [INFO] [stdout] | |_____^ help: replace with: `port.unwrap_or(8080)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/server.rs:227:37 [INFO] [stdout] | [INFO] [stdout] 227 | let type_generation_directory = if every_dir_types_gen != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!every_dir_types_gen.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/shift/generate.rs:251:23 [INFO] [stdout] | [INFO] [stdout] 251 | ts_type.push_str(&format!("\t\t}},\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\t\t},\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/shift/generate.rs:315:23 [INFO] [stdout] | [INFO] [stdout] 315 | ts_type.push_str(&format!("\t\t}}\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\t\t}\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/shift/generate.rs:331:31 [INFO] [stdout] | [INFO] [stdout] 331 | let mut handlers_interface = format!("\n\nexport interface Handlers {{\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\n\nexport interface Handlers {\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/shift/generate.rs:335:2 [INFO] [stdout] | [INFO] [stdout] 335 | handlers_interface.push_str("}"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `handlers_interface.push('}')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/shift/generate.rs:367:29 [INFO] [stdout] | [INFO] [stdout] 367 | let mut file = File::open(&entry.path()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `entry.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/shift/convert.rs:292:3 [INFO] [stdout] | [INFO] [stdout] 292 | self.store.push_str("}"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `self.store.push('}')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/shift/convert.rs:302:6 [INFO] [stdout] | [INFO] [stdout] 302 | if !(get_rust_typename(&primitive) == converted.typescript_type) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(get_rust_typename(&primitive) != converted.typescript_type)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/shift/convert.rs:381:8 [INFO] [stdout] | [INFO] [stdout] 381 | if !(path.extension().unwrap_or(OsStr::new("")).to_str().unwrap_or("") == "rs") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(path.extension().unwrap_or(OsStr::new("")).to_str().unwrap_or("") != "rs")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/shift/util.rs:181:8 [INFO] [stdout] | [INFO] [stdout] 181 | if item_const.ident.to_string() == "ROUTE_KEY" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `item_const.ident` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/shift/convert.rs:386:31 [INFO] [stdout] | [INFO] [stdout] 386 | let mut file = File::open(&path).expect("Could not open file while attempting to generate Typescript types!"); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/shift/convert.rs:411:11 [INFO] [stdout] | [INFO] [stdout] 411 | ... if val.ident.to_string() == "RapidOutput" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `val.ident` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/shift/util.rs:229:2 [INFO] [stdout] | [INFO] [stdout] 229 | return fallback_alias; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 229 - return fallback_alias; [INFO] [stdout] 229 + fallback_alias [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/shift/util.rs:222:7 [INFO] [stdout] | [INFO] [stdout] 222 | if item_type.ident.to_string() == "RapidOutput" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `item_type.ident` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/shift/convert.rs:442:3 [INFO] [stdout] | [INFO] [stdout] 442 | assert_eq!(converted.is_optional, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 442 - assert_eq!(converted.is_optional, false); [INFO] [stdout] 442 + assert!(!converted.is_optional); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/shift/convert.rs:446:3 [INFO] [stdout] | [INFO] [stdout] 446 | assert_eq!(converted.is_optional, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 446 - assert_eq!(converted.is_optional, false); [INFO] [stdout] 446 + assert!(!converted.is_optional); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/shift/convert.rs:450:3 [INFO] [stdout] | [INFO] [stdout] 450 | assert_eq!(converted.is_optional, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 450 - assert_eq!(converted.is_optional, false); [INFO] [stdout] 450 + assert!(!converted.is_optional); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/shift/convert.rs:454:3 [INFO] [stdout] | [INFO] [stdout] 454 | assert_eq!(converted.is_optional, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 454 - assert_eq!(converted.is_optional, false); [INFO] [stdout] 454 + assert!(!converted.is_optional); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/shift/convert.rs:458:3 [INFO] [stdout] | [INFO] [stdout] 458 | assert_eq!(converted.is_optional, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 458 - assert_eq!(converted.is_optional, false); [INFO] [stdout] 458 + assert!(!converted.is_optional); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/shift/convert.rs:462:3 [INFO] [stdout] | [INFO] [stdout] 462 | assert_eq!(converted.is_optional, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 462 - assert_eq!(converted.is_optional, false); [INFO] [stdout] 462 + assert!(!converted.is_optional); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/shift/convert.rs:466:3 [INFO] [stdout] | [INFO] [stdout] 466 | assert_eq!(converted.is_optional, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 466 - assert_eq!(converted.is_optional, false); [INFO] [stdout] 466 + assert!(!converted.is_optional); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/util.rs:43:47 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn validate_route_handler(handler_source: &String) -> bool { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 43 ~ pub fn validate_route_handler(handler_source: &str) -> bool { [INFO] [stdout] 44 | // Check if the file is actually valid rust code [INFO] [stdout] ... [INFO] [stdout] 52 | // -- however, it wont happen because this case is caught in the if-statement above [INFO] [stdout] 53 ~ let parsed_file: SynFile = parse_str(handler_source).expect("An error occurred when attempting to parse a rapid route handler file."); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/util.rs:75:44 [INFO] [stdout] | [INFO] [stdout] 75 | if file_contents.contains("async fn get") { [INFO] [stdout] | _______________________________________________^ [INFO] [stdout] 76 | | return true; [INFO] [stdout] 77 | | } else if file_contents.contains("async fn post") { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/util.rs:77:52 [INFO] [stdout] | [INFO] [stdout] 77 | } else if file_contents.contains("async fn post") { [INFO] [stdout] | _______________________________________________________^ [INFO] [stdout] 78 | | return true; [INFO] [stdout] 79 | | } else if file_contents.contains("async fn delete") { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/shift/convert.rs:470:3 [INFO] [stdout] | [INFO] [stdout] 470 | assert_eq!(converted.is_optional, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 470 - assert_eq!(converted.is_optional, false); [INFO] [stdout] 470 + assert!(!converted.is_optional); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/util.rs:77:52 [INFO] [stdout] | [INFO] [stdout] 77 | } else if file_contents.contains("async fn post") { [INFO] [stdout] | _______________________________________________________^ [INFO] [stdout] 78 | | return true; [INFO] [stdout] 79 | | } else if file_contents.contains("async fn delete") { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/util.rs:79:54 [INFO] [stdout] | [INFO] [stdout] 79 | } else if file_contents.contains("async fn delete") { [INFO] [stdout] | _________________________________________________________^ [INFO] [stdout] 80 | | return true; [INFO] [stdout] 81 | | } else if file_contents.contains("async fn put") { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/util.rs:79:54 [INFO] [stdout] | [INFO] [stdout] 79 | } else if file_contents.contains("async fn delete") { [INFO] [stdout] | _________________________________________________________^ [INFO] [stdout] 80 | | return true; [INFO] [stdout] 81 | | } else if file_contents.contains("async fn put") { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/util.rs:81:51 [INFO] [stdout] | [INFO] [stdout] 81 | } else if file_contents.contains("async fn put") { [INFO] [stdout] | ______________________________________________________^ [INFO] [stdout] 82 | | return true; [INFO] [stdout] 83 | | } else if file_contents.contains("async fn patch") { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/util.rs:81:51 [INFO] [stdout] | [INFO] [stdout] 81 | } else if file_contents.contains("async fn put") { [INFO] [stdout] | ______________________________________________________^ [INFO] [stdout] 82 | | return true; [INFO] [stdout] 83 | | } else if file_contents.contains("async fn patch") { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/util.rs:83:53 [INFO] [stdout] | [INFO] [stdout] 83 | } else if file_contents.contains("async fn patch") { [INFO] [stdout] | ________________________________________________________^ [INFO] [stdout] 84 | | return true; [INFO] [stdout] 85 | | } else if file_contents.contains("async fn query") { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/util.rs:83:53 [INFO] [stdout] | [INFO] [stdout] 83 | } else if file_contents.contains("async fn patch") { [INFO] [stdout] | ________________________________________________________^ [INFO] [stdout] 84 | | return true; [INFO] [stdout] 85 | | } else if file_contents.contains("async fn query") { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/util.rs:85:53 [INFO] [stdout] | [INFO] [stdout] 85 | } else if file_contents.contains("async fn query") { [INFO] [stdout] | ________________________________________________________^ [INFO] [stdout] 86 | | return true; [INFO] [stdout] 87 | | } else if file_contents.contains("async fn mutation") { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/util.rs:85:53 [INFO] [stdout] | [INFO] [stdout] 85 | } else if file_contents.contains("async fn query") { [INFO] [stdout] | ________________________________________________________^ [INFO] [stdout] 86 | | return true; [INFO] [stdout] 87 | | } else if file_contents.contains("async fn mutation") { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/util.rs:87:56 [INFO] [stdout] | [INFO] [stdout] 87 | } else if file_contents.contains("async fn mutation") { [INFO] [stdout] | ___________________________________________________________^ [INFO] [stdout] 88 | | return true; [INFO] [stdout] 89 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/shift/convert.rs:474:3 [INFO] [stdout] | [INFO] [stdout] 474 | assert_eq!(converted.is_optional, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 474 - assert_eq!(converted.is_optional, false); [INFO] [stdout] 474 + assert!(!converted.is_optional); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/shift/convert.rs:478:3 [INFO] [stdout] | [INFO] [stdout] 478 | assert_eq!(converted.is_optional, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 478 - assert_eq!(converted.is_optional, false); [INFO] [stdout] 478 + assert!(!converted.is_optional); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> src/util.rs:141:20 [INFO] [stdout] | [INFO] [stdout] 141 | Some(server) => match server.typescript_generation.clone() { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 142 | | Some(val) => val, [INFO] [stdout] 143 | | None => true, [INFO] [stdout] 144 | | }, [INFO] [stdout] | |_____________^ help: replace with: `server.typescript_generation.clone().unwrap_or(true)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/util.rs:141:26 [INFO] [stdout] | [INFO] [stdout] 141 | Some(server) => match server.typescript_generation.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `server.typescript_generation` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> src/util.rs:148:19 [INFO] [stdout] | [INFO] [stdout] 148 | Some(remix) => match remix.typescript_generation.clone() { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 149 | | Some(val) => val, [INFO] [stdout] 150 | | None => true, [INFO] [stdout] 151 | | }, [INFO] [stdout] | |_____________^ help: replace with: `remix.typescript_generation.clone().unwrap_or(true)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/util.rs:148:25 [INFO] [stdout] | [INFO] [stdout] 148 | Some(remix) => match remix.typescript_generation.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `remix.typescript_generation` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> src/util.rs:155:20 [INFO] [stdout] | [INFO] [stdout] 155 | Some(nextjs) => match nextjs.typescript_generation.clone() { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 156 | | Some(val) => val, [INFO] [stdout] 157 | | None => true, [INFO] [stdout] 158 | | }, [INFO] [stdout] | |_____________^ help: replace with: `nextjs.typescript_generation.clone().unwrap_or(true)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/util.rs:155:26 [INFO] [stdout] | [INFO] [stdout] 155 | Some(nextjs) => match nextjs.typescript_generation.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `nextjs.typescript_generation` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/shift/generate.rs:355:43 [INFO] [stdout] | [INFO] [stdout] 355 | for route_file in WalkDir::new(routes_dir.clone()) { [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/shift/generate.rs:73:29 [INFO] [stdout] | [INFO] [stdout] 73 | let mut file = File::open(&entry.path()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `entry.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/shift/generate.rs:97:8 [INFO] [stdout] | [INFO] [stdout] 97 | if val.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!val.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/shift/generate.rs:184:5 [INFO] [stdout] | [INFO] [stdout] 184 | if handlers.len() < 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `handlers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/shift/generate.rs:251:23 [INFO] [stdout] | [INFO] [stdout] 251 | ts_type.push_str(&format!("\t\t}},\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\t\t},\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/shift/generate.rs:315:23 [INFO] [stdout] | [INFO] [stdout] 315 | ts_type.push_str(&format!("\t\t}}\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\t\t}\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/shift/generate.rs:331:31 [INFO] [stdout] | [INFO] [stdout] 331 | let mut handlers_interface = format!("\n\nexport interface Handlers {{\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\n\nexport interface Handlers {\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/shift/generate.rs:335:2 [INFO] [stdout] | [INFO] [stdout] 335 | handlers_interface.push_str("}"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `handlers_interface.push('}')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/shift/generate.rs:367:29 [INFO] [stdout] | [INFO] [stdout] 367 | let mut file = File::open(&entry.path()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `entry.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/shift/util.rs:181:8 [INFO] [stdout] | [INFO] [stdout] 181 | if item_const.ident.to_string() == "ROUTE_KEY" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `item_const.ident` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/shift/util.rs:229:2 [INFO] [stdout] | [INFO] [stdout] 229 | return fallback_alias; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 229 - return fallback_alias; [INFO] [stdout] 229 + fallback_alias [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/shift/util.rs:222:7 [INFO] [stdout] | [INFO] [stdout] 222 | if item_type.ident.to_string() == "RapidOutput" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `item_type.ident` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/shift/util.rs:264:3 [INFO] [stdout] | [INFO] [stdout] 264 | assert_eq!(is_dynamic_route(test_string), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 264 - assert_eq!(is_dynamic_route(test_string), true); [INFO] [stdout] 264 + assert!(is_dynamic_route(test_string)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/shift/util.rs:265:3 [INFO] [stdout] | [INFO] [stdout] 265 | assert_eq!(is_dynamic_route(test_string_2), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 265 - assert_eq!(is_dynamic_route(test_string_2), false); [INFO] [stdout] 265 + assert!(!is_dynamic_route(test_string_2)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/util.rs:43:47 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn validate_route_handler(handler_source: &String) -> bool { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 43 ~ pub fn validate_route_handler(handler_source: &str) -> bool { [INFO] [stdout] 44 | // Check if the file is actually valid rust code [INFO] [stdout] ... [INFO] [stdout] 52 | // -- however, it wont happen because this case is caught in the if-statement above [INFO] [stdout] 53 ~ let parsed_file: SynFile = parse_str(handler_source).expect("An error occurred when attempting to parse a rapid route handler file."); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/util.rs:75:44 [INFO] [stdout] | [INFO] [stdout] 75 | if file_contents.contains("async fn get") { [INFO] [stdout] | _______________________________________________^ [INFO] [stdout] 76 | | return true; [INFO] [stdout] 77 | | } else if file_contents.contains("async fn post") { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/util.rs:77:52 [INFO] [stdout] | [INFO] [stdout] 77 | } else if file_contents.contains("async fn post") { [INFO] [stdout] | _______________________________________________________^ [INFO] [stdout] 78 | | return true; [INFO] [stdout] 79 | | } else if file_contents.contains("async fn delete") { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/util.rs:77:52 [INFO] [stdout] | [INFO] [stdout] 77 | } else if file_contents.contains("async fn post") { [INFO] [stdout] | _______________________________________________________^ [INFO] [stdout] 78 | | return true; [INFO] [stdout] 79 | | } else if file_contents.contains("async fn delete") { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/util.rs:79:54 [INFO] [stdout] | [INFO] [stdout] 79 | } else if file_contents.contains("async fn delete") { [INFO] [stdout] | _________________________________________________________^ [INFO] [stdout] 80 | | return true; [INFO] [stdout] 81 | | } else if file_contents.contains("async fn put") { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/util.rs:79:54 [INFO] [stdout] | [INFO] [stdout] 79 | } else if file_contents.contains("async fn delete") { [INFO] [stdout] | _________________________________________________________^ [INFO] [stdout] 80 | | return true; [INFO] [stdout] 81 | | } else if file_contents.contains("async fn put") { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/util.rs:81:51 [INFO] [stdout] | [INFO] [stdout] 81 | } else if file_contents.contains("async fn put") { [INFO] [stdout] | ______________________________________________________^ [INFO] [stdout] 82 | | return true; [INFO] [stdout] 83 | | } else if file_contents.contains("async fn patch") { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/util.rs:81:51 [INFO] [stdout] | [INFO] [stdout] 81 | } else if file_contents.contains("async fn put") { [INFO] [stdout] | ______________________________________________________^ [INFO] [stdout] 82 | | return true; [INFO] [stdout] 83 | | } else if file_contents.contains("async fn patch") { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/util.rs:83:53 [INFO] [stdout] | [INFO] [stdout] 83 | } else if file_contents.contains("async fn patch") { [INFO] [stdout] | ________________________________________________________^ [INFO] [stdout] 84 | | return true; [INFO] [stdout] 85 | | } else if file_contents.contains("async fn query") { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/util.rs:83:53 [INFO] [stdout] | [INFO] [stdout] 83 | } else if file_contents.contains("async fn patch") { [INFO] [stdout] | ________________________________________________________^ [INFO] [stdout] 84 | | return true; [INFO] [stdout] 85 | | } else if file_contents.contains("async fn query") { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/util.rs:85:53 [INFO] [stdout] | [INFO] [stdout] 85 | } else if file_contents.contains("async fn query") { [INFO] [stdout] | ________________________________________________________^ [INFO] [stdout] 86 | | return true; [INFO] [stdout] 87 | | } else if file_contents.contains("async fn mutation") { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/util.rs:85:53 [INFO] [stdout] | [INFO] [stdout] 85 | } else if file_contents.contains("async fn query") { [INFO] [stdout] | ________________________________________________________^ [INFO] [stdout] 86 | | return true; [INFO] [stdout] 87 | | } else if file_contents.contains("async fn mutation") { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/util.rs:87:56 [INFO] [stdout] | [INFO] [stdout] 87 | } else if file_contents.contains("async fn mutation") { [INFO] [stdout] | ___________________________________________________________^ [INFO] [stdout] 88 | | return true; [INFO] [stdout] 89 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> src/util.rs:141:20 [INFO] [stdout] | [INFO] [stdout] 141 | Some(server) => match server.typescript_generation.clone() { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 142 | | Some(val) => val, [INFO] [stdout] 143 | | None => true, [INFO] [stdout] 144 | | }, [INFO] [stdout] | |_____________^ help: replace with: `server.typescript_generation.clone().unwrap_or(true)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/util.rs:141:26 [INFO] [stdout] | [INFO] [stdout] 141 | Some(server) => match server.typescript_generation.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `server.typescript_generation` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> src/util.rs:148:19 [INFO] [stdout] | [INFO] [stdout] 148 | Some(remix) => match remix.typescript_generation.clone() { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 149 | | Some(val) => val, [INFO] [stdout] 150 | | None => true, [INFO] [stdout] 151 | | }, [INFO] [stdout] | |_____________^ help: replace with: `remix.typescript_generation.clone().unwrap_or(true)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/util.rs:148:25 [INFO] [stdout] | [INFO] [stdout] 148 | Some(remix) => match remix.typescript_generation.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `remix.typescript_generation` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> src/util.rs:155:20 [INFO] [stdout] | [INFO] [stdout] 155 | Some(nextjs) => match nextjs.typescript_generation.clone() { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 156 | | Some(val) => val, [INFO] [stdout] 157 | | None => true, [INFO] [stdout] 158 | | }, [INFO] [stdout] | |_____________^ help: replace with: `nextjs.typescript_generation.clone().unwrap_or(true)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/util.rs:155:26 [INFO] [stdout] | [INFO] [stdout] 155 | Some(nextjs) => match nextjs.typescript_generation.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `nextjs.typescript_generation` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/util.rs:260:3 [INFO] [stdout] | [INFO] [stdout] 260 | assert_eq!(is_valid_route_function(valid_handler), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 260 - assert_eq!(is_valid_route_function(valid_handler), true); [INFO] [stdout] 260 + assert!(is_valid_route_function(valid_handler)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/util.rs:261:3 [INFO] [stdout] | [INFO] [stdout] 261 | assert_eq!(is_valid_route_function(invalid_handler), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 261 - assert_eq!(is_valid_route_function(invalid_handler), false); [INFO] [stdout] 261 + assert!(!is_valid_route_function(invalid_handler)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/util.rs:305:3 [INFO] [stdout] | [INFO] [stdout] 305 | assert_eq!(validate_route_handler(&valid_handler.to_string()), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 305 - assert_eq!(validate_route_handler(&valid_handler.to_string()), true); [INFO] [stdout] 305 + assert!(validate_route_handler(&valid_handler.to_string())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/util.rs:306:3 [INFO] [stdout] | [INFO] [stdout] 306 | assert_eq!(validate_route_handler(&invalid_handler.to_string()), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 306 - assert_eq!(validate_route_handler(&invalid_handler.to_string()), false); [INFO] [stdout] 306 + assert!(!validate_route_handler(&invalid_handler.to_string())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/shift/generate.rs:355:43 [INFO] [stdout] | [INFO] [stdout] 355 | for route_file in WalkDir::new(routes_dir.clone()) { [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 30.59s [INFO] running `Command { std: "docker" "inspect" "0d7b850aa0f41f4705b6b01ba2ae852782b24900faca43bb5cd7f9c81ac8fcb7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0d7b850aa0f41f4705b6b01ba2ae852782b24900faca43bb5cd7f9c81ac8fcb7", kill_on_drop: false }` [INFO] [stdout] 0d7b850aa0f41f4705b6b01ba2ae852782b24900faca43bb5cd7f9c81ac8fcb7