[INFO] fetching crate random_password_generator 0.1.0... [INFO] linting random_password_generator-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate random_password_generator 0.1.0 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate random_password_generator 0.1.0 [INFO] finished tweaking crates.io crate random_password_generator 0.1.0 [INFO] tweaked toml for crates.io crate random_password_generator 0.1.0 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate random_password_generator 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 14 packages to latest compatible versions [INFO] [stderr] Adding rand v0.8.5 (available: v0.10.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e1429299530769e87bf5f678c7959f22865ed3f2371e57e980c13bf2d3422b4c [INFO] running `Command { std: "docker" "start" "-a" "e1429299530769e87bf5f678c7959f22865ed3f2371e57e980c13bf2d3422b4c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e1429299530769e87bf5f678c7959f22865ed3f2371e57e980c13bf2d3422b4c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e1429299530769e87bf5f678c7959f22865ed3f2371e57e980c13bf2d3422b4c", kill_on_drop: false }` [INFO] [stdout] e1429299530769e87bf5f678c7959f22865ed3f2371e57e980c13bf2d3422b4c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4724b075d01ee9a792376fe5ca62b2e81cb6353582e72c47cf08f1dfe4fcf45e [INFO] running `Command { std: "docker" "start" "-a" "4724b075d01ee9a792376fe5ca62b2e81cb6353582e72c47cf08f1dfe4fcf45e", kill_on_drop: false }` [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking random_password_generator v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:22:14 [INFO] [stdout] | [INFO] [stdout] 22 | }else if alphabet && numeric || alphabet && characters || numeric && characters { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 22 - }else if alphabet && numeric || alphabet && characters || numeric && characters { [INFO] [stdout] 22 + }else if !(!alphabet || !numeric && !characters) || numeric && characters { [INFO] [stdout] | [INFO] [stdout] 22 - }else if alphabet && numeric || alphabet && characters || numeric && characters { [INFO] [stdout] 22 + }else if (characters || numeric) && alphabet || numeric && characters { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/lib.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | / let mut vec = Vec::with_capacity(1); [INFO] [stdout] 26 | | vec.push(size); [INFO] [stdout] | |_______________________^ help: consider using the `vec![]` macro: `let vec = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 119 | num1 = num1 - 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace it with: `num1 -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:22:14 [INFO] [stdout] | [INFO] [stdout] 22 | }else if alphabet && numeric || alphabet && characters || numeric && characters { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 22 - }else if alphabet && numeric || alphabet && characters || numeric && characters { [INFO] [stdout] 22 + }else if !(!alphabet || !numeric && !characters) || numeric && characters { [INFO] [stdout] | [INFO] [stdout] 22 - }else if alphabet && numeric || alphabet && characters || numeric && characters { [INFO] [stdout] 22 + }else if (characters || numeric) && alphabet || numeric && characters { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/lib.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | / let mut vec = Vec::with_capacity(1); [INFO] [stdout] 26 | | vec.push(size); [INFO] [stdout] | |_______________________^ help: consider using the `vec![]` macro: `let vec = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 119 | num1 = num1 - 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace it with: `num1 -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.57s [INFO] running `Command { std: "docker" "inspect" "4724b075d01ee9a792376fe5ca62b2e81cb6353582e72c47cf08f1dfe4fcf45e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4724b075d01ee9a792376fe5ca62b2e81cb6353582e72c47cf08f1dfe4fcf45e", kill_on_drop: false }` [INFO] [stdout] 4724b075d01ee9a792376fe5ca62b2e81cb6353582e72c47cf08f1dfe4fcf45e