[INFO] fetching crate random_name_generator 0.3.6... [INFO] linting random_name_generator-0.3.6 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate random_name_generator 0.3.6 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate random_name_generator 0.3.6 [INFO] finished tweaking crates.io crate random_name_generator 0.3.6 [INFO] tweaked toml for crates.io crate random_name_generator 0.3.6 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate random_name_generator 0.3.6 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate random_name_generator 0.3.6 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded fastrand v2.0.0 [INFO] [stderr] Downloaded rust-embed-impl v8.0.0 [INFO] [stderr] Downloaded titlecase v2.2.1 [INFO] [stderr] Downloaded relative-path v1.9.0 [INFO] [stderr] Downloaded rust-embed-utils v8.0.0 [INFO] [stderr] Downloaded tempfile v3.8.0 [INFO] [stderr] Downloaded proptest v1.2.0 [INFO] [stderr] Downloaded syn v2.0.35 [INFO] [stderr] Downloaded rust-embed v8.0.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f7f0fe65281dd29c5221fb0ef4816af8ed5675318e6ffa990d89aad6c44a9e26 [INFO] running `Command { std: "docker" "start" "-a" "f7f0fe65281dd29c5221fb0ef4816af8ed5675318e6ffa990d89aad6c44a9e26", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f7f0fe65281dd29c5221fb0ef4816af8ed5675318e6ffa990d89aad6c44a9e26", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f7f0fe65281dd29c5221fb0ef4816af8ed5675318e6ffa990d89aad6c44a9e26", kill_on_drop: false }` [INFO] [stdout] f7f0fe65281dd29c5221fb0ef4816af8ed5675318e6ffa990d89aad6c44a9e26 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 32fffced847901cf931adb72817d4caa99bb1d5089353155f5d42b31f38c615c [INFO] running `Command { std: "docker" "start" "-a" "32fffced847901cf931adb72817d4caa99bb1d5089353155f5d42b31f38c615c", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.67 [INFO] [stderr] Compiling libc v0.2.148 [INFO] [stderr] Checking memchr v2.6.3 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Compiling semver v1.0.18 [INFO] [stderr] Compiling rustix v0.38.13 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Compiling cpufeatures v0.2.9 [INFO] [stderr] Compiling libm v0.2.7 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking regex-syntax v0.7.5 [INFO] [stderr] Checking linux-raw-sys v0.4.7 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Checking anstyle v1.0.3 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Checking clap_lex v0.5.1 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking aho-corasick v1.0.5 [INFO] [stderr] Checking anstream v0.5.0 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking clap_builder v4.4.2 [INFO] [stderr] Compiling rayon-core v1.11.0 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking sha2 v0.10.7 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Compiling rstest_macros v0.18.2 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Compiling syn v2.0.35 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking joinery v2.1.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking fastrand v2.0.0 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Compiling rust-embed-utils v8.0.0 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking ciborium-io v0.2.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking ciborium-ll v0.2.1 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Compiling relative-path v1.9.0 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Checking regex-automata v0.3.8 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Checking futures-timer v3.0.2 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking rayon v1.7.0 [INFO] [stderr] Checking tempfile v3.8.0 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Checking proptest v1.2.0 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking regex v1.9.5 [INFO] [stderr] Checking titlecase v2.2.1 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Compiling clap_derive v4.4.2 [INFO] [stderr] Compiling rust-embed-impl v8.0.0 [INFO] [stderr] Checking rust-embed v8.0.0 [INFO] [stderr] Checking futures-util v0.3.28 [INFO] [stderr] Checking clap v4.4.3 [INFO] [stderr] Checking random_name_generator v0.3.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `BadSyllable` is never constructed [INFO] [stdout] --> src/rng_syllable.rs:180:12 [INFO] [stdout] | [INFO] [stdout] 180 | pub struct BadSyllable; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking futures-executor v0.3.28 [INFO] [stderr] Checking futures v0.3.28 [INFO] [stderr] Checking rstest v0.18.2 [INFO] [stderr] Checking ciborium v0.2.1 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stdout] warning: struct `BadSyllable` is never constructed [INFO] [stdout] --> src/rng_syllable.rs:180:12 [INFO] [stdout] | [INFO] [stdout] 180 | pub struct BadSyllable; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty String is being created manually [INFO] [stdout] --> src/rng_joiner.rs:98:40 [INFO] [stdout] | [INFO] [stdout] 98 | assert_eq!(j.value_previous(), "".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using: `String::new()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_string_new [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:1:9 [INFO] [stdout] | [INFO] [stdout] 1 | #![warn(clippy::pedantic)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(clippy::manual_string_new)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty String is being created manually [INFO] [stdout] --> src/rng_joiner.rs:99:51 [INFO] [stdout] | [INFO] [stdout] 99 | assert_eq!(Joiner::SOME.value_previous(), "".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using: `String::new()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_string_new [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty String is being created manually [INFO] [stdout] --> src/rng_joiner.rs:124:36 [INFO] [stdout] | [INFO] [stdout] 124 | assert_eq!(j.value_next(), "".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using: `String::new()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_string_new [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty String is being created manually [INFO] [stdout] --> src/rng_joiner.rs:125:47 [INFO] [stdout] | [INFO] [stdout] 125 | assert_eq!(Joiner::SOME.value_next(), "".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using: `String::new()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_string_new [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/rng_syllable.rs:319:9 [INFO] [stdout] | [INFO] [stdout] 319 | assert_eq!(false, actual.unwrap().starts_with_vowel()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 319 - assert_eq!(false, actual.unwrap().starts_with_vowel()); [INFO] [stdout] 319 + assert!(!actual.unwrap().starts_with_vowel()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/rng_syllable.rs:326:9 [INFO] [stdout] | [INFO] [stdout] 326 | assert_eq!(true, actual.unwrap().starts_with_vowel()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 326 - assert_eq!(true, actual.unwrap().starts_with_vowel()); [INFO] [stdout] 326 + assert!(actual.unwrap().starts_with_vowel()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/rng_syllable.rs:333:9 [INFO] [stdout] | [INFO] [stdout] 333 | assert_eq!(true, actual.unwrap().ends_with_vowel()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 333 - assert_eq!(true, actual.unwrap().ends_with_vowel()); [INFO] [stdout] 333 + assert!(actual.unwrap().ends_with_vowel()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/rng_syllable.rs:340:9 [INFO] [stdout] | [INFO] [stdout] 340 | assert_eq!(false, actual.unwrap().ends_with_vowel()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 340 - assert_eq!(false, actual.unwrap().ends_with_vowel()); [INFO] [stdout] 340 + assert!(!actual.unwrap().ends_with_vowel()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/rng_syllable.rs:410:9 [INFO] [stdout] | [INFO] [stdout] 410 | assert!(!FULL_RE.is_match(input)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `assert!(!FULL_RE.is_match(input));` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] = note: `#[warn(clippy::semicolon_if_nothing_returned)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty String is being created manually [INFO] [stdout] --> src/rng_syllable.rs:436:52 [INFO] [stdout] | [INFO] [stdout] 436 | assert_eq!(syl.jprevious.value_previous(), "".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using: `String::new()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_string_new [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty String is being created manually [INFO] [stdout] --> src/rng_syllable.rs:441:38 [INFO] [stdout] | [INFO] [stdout] 441 | case(Classification::Center, "".to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using: `String::new()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_string_new [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `all.get(0)` [INFO] [stdout] --> src/rng_syllables.rs:154:20 [INFO] [stdout] | [INFO] [stdout] 154 | assert_eq!(all.get(0).unwrap(), &Syllable::from_str("ch").unwrap()); [INFO] [stdout] | ^^^^^^^^^^ help: try: `all.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless use of `for_each` [INFO] [stdout] --> src/rng_weighted_rnd.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | / chain [INFO] [stdout] 41 | | .iter() [INFO] [stdout] 42 | | .for_each(|i| assert!(NORMAL_WEIGHT.counts.contains(i))); [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_for_each [INFO] [stdout] = note: `#[warn(clippy::needless_for_each)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 40 ~ for i in chain [INFO] [stdout] 41 + .iter() { assert!(NORMAL_WEIGHT.counts.contains(i)); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless use of `for_each` [INFO] [stdout] --> src/rng_weighted_rnd.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | chain.iter().for_each(|i| assert!(!non.contains(i))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for i in chain.iter() { assert!(!non.contains(i)); }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_for_each [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless use of `for_each` [INFO] [stdout] --> src/rng_weighted_rnd.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | / chain [INFO] [stdout] 52 | | .iter() [INFO] [stdout] 53 | | .for_each(|i| assert!(SHORT_WEIGHT.counts.contains(i))); [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_for_each [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 51 ~ for i in chain [INFO] [stdout] 52 + .iter() { assert!(SHORT_WEIGHT.counts.contains(i)); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless use of `for_each` [INFO] [stdout] --> src/rng_weighted_rnd.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | chain.iter().for_each(|i| assert!(!non.contains(i))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for i in chain.iter() { assert!(!non.contains(i)); }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_for_each [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/lib.rs:244:19 [INFO] [stdout] | [INFO] [stdout] 244 | let rng = RNG::try_from(&Language::Fantasy).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `&Language` to `RNG` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 244 - let rng = RNG::try_from(&Language::Fantasy).unwrap(); [INFO] [stdout] 244 + let rng = RNG::from(&Language::Fantasy); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/lib.rs:247:17 [INFO] [stdout] | [INFO] [stdout] 247 | assert!(rng.bad_syllables.len() < 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rng.bad_syllables.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:248:17 [INFO] [stdout] | [INFO] [stdout] 248 | assert!(rng.prefixes.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!rng.prefixes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:249:17 [INFO] [stdout] | [INFO] [stdout] 249 | assert!(rng.centers.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!rng.centers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:250:17 [INFO] [stdout] | [INFO] [stdout] 250 | assert!(rng.suffixes.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!rng.suffixes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/lib.rs:257:17 [INFO] [stdout] | [INFO] [stdout] 257 | assert!(rng.bad_syllables.len() < 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rng.bad_syllables.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:258:17 [INFO] [stdout] | [INFO] [stdout] 258 | assert!(rng.prefixes.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!rng.prefixes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:259:17 [INFO] [stdout] | [INFO] [stdout] 259 | assert!(rng.centers.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!rng.centers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:260:17 [INFO] [stdout] | [INFO] [stdout] 260 | assert!(rng.suffixes.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!rng.suffixes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/lib.rs:265:22 [INFO] [stdout] | [INFO] [stdout] 265 | let result = RNG::try_from(&Language::Goblin).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `&Language` to `RNG` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 265 - let result = RNG::try_from(&Language::Goblin).unwrap(); [INFO] [stdout] 265 + let result = RNG::from(&Language::Goblin); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/lib.rs:268:17 [INFO] [stdout] | [INFO] [stdout] 268 | assert!(result.bad_syllables.len() < 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `result.bad_syllables.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:269:17 [INFO] [stdout] | [INFO] [stdout] 269 | assert!(result.prefixes.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!result.prefixes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:270:17 [INFO] [stdout] | [INFO] [stdout] 270 | assert!(result.centers.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!result.centers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:271:17 [INFO] [stdout] | [INFO] [stdout] 271 | assert!(result.suffixes.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!result.suffixes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/lib.rs:276:22 [INFO] [stdout] | [INFO] [stdout] 276 | let result = RNG::try_from(&Language::Roman).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `&Language` to `RNG` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 276 - let result = RNG::try_from(&Language::Roman).unwrap(); [INFO] [stdout] 276 + let result = RNG::from(&Language::Roman); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/lib.rs:279:17 [INFO] [stdout] | [INFO] [stdout] 279 | assert!(result.bad_syllables.len() < 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `result.bad_syllables.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:280:17 [INFO] [stdout] | [INFO] [stdout] 280 | assert!(result.prefixes.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!result.prefixes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:281:17 [INFO] [stdout] | [INFO] [stdout] 281 | assert!(result.centers.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!result.centers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:282:17 [INFO] [stdout] | [INFO] [stdout] 282 | assert!(result.suffixes.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!result.suffixes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/lib.rs:287:22 [INFO] [stdout] | [INFO] [stdout] 287 | let result = RNG::try_from(&Language::Фантазия).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `&Language` to `RNG` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 287 - let result = RNG::try_from(&Language::Фантазия).unwrap(); [INFO] [stdout] 287 + let result = RNG::from(&Language::Фантазия); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/lib.rs:290:17 [INFO] [stdout] | [INFO] [stdout] 290 | assert!(result.bad_syllables.len() < 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `result.bad_syllables.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:291:17 [INFO] [stdout] | [INFO] [stdout] 291 | assert!(result.prefixes.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!result.prefixes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:292:17 [INFO] [stdout] | [INFO] [stdout] 292 | assert!(result.centers.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!result.centers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:293:17 [INFO] [stdout] | [INFO] [stdout] 293 | assert!(result.suffixes.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!result.suffixes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:303:17 [INFO] [stdout] | [INFO] [stdout] 303 | assert!(!rng.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `rng.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:318:17 [INFO] [stdout] | [INFO] [stdout] 318 | assert!(!rng.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `rng.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:342:17 [INFO] [stdout] | [INFO] [stdout] 342 | assert!(!rng.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `rng.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless use of `for_each` [INFO] [stdout] --> src/lib.rs:403:9 [INFO] [stdout] | [INFO] [stdout] 403 | / chain [INFO] [stdout] 404 | | .iter() [INFO] [stdout] 405 | | .for_each(|name| assert!(name.as_str().starts_with("A"))); [INFO] [stdout] | |______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_for_each [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 403 ~ for name in chain [INFO] [stdout] 404 + .iter() { assert!(name.as_str().starts_with("A")); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: single-character string constant used as pattern [INFO] [stdout] --> src/lib.rs:405:64 [INFO] [stdout] | [INFO] [stdout] 405 | .for_each(|name| assert!(name.as_str().starts_with("A"))); [INFO] [stdout] | ^^^ help: consider using a `char`: `'A'` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stdout] = note: `#[warn(clippy::single_char_pattern)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless use of `for_each` [INFO] [stdout] --> src/lib.rs:406:9 [INFO] [stdout] | [INFO] [stdout] 406 | / chain [INFO] [stdout] 407 | | .iter() [INFO] [stdout] 408 | | .for_each(|name| assert!(name.as_str().ends_with("c"))); [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_for_each [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 406 ~ for name in chain [INFO] [stdout] 407 + .iter() { assert!(name.as_str().ends_with("c")); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: single-character string constant used as pattern [INFO] [stdout] --> src/lib.rs:408:62 [INFO] [stdout] | [INFO] [stdout] 408 | .for_each(|name| assert!(name.as_str().ends_with("c"))); [INFO] [stdout] | ^^^ help: consider using a `char`: `'c'` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/lib.rs:413:19 [INFO] [stdout] | [INFO] [stdout] 413 | let rng = RNG::try_from(&Language::Roman).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `&Language` to `RNG` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 413 - let rng = RNG::try_from(&Language::Roman).unwrap(); [INFO] [stdout] 413 + let rng = RNG::from(&Language::Roman); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/lib.rs:422:19 [INFO] [stdout] | [INFO] [stdout] 422 | let rng = RNG::try_from(&Language::Demonic).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `&Language` to `RNG` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 422 - let rng = RNG::try_from(&Language::Demonic).unwrap(); [INFO] [stdout] 422 + let rng = RNG::from(&Language::Demonic); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless use of `for_each` [INFO] [stdout] --> src/lib.rs:435:9 [INFO] [stdout] | [INFO] [stdout] 435 | / chain [INFO] [stdout] 436 | | .iter() [INFO] [stdout] 437 | | .for_each(|name| assert!(name.as_str().starts_with("A"))); [INFO] [stdout] | |______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_for_each [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 435 ~ for name in chain [INFO] [stdout] 436 + .iter() { assert!(name.as_str().starts_with("A")); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: single-character string constant used as pattern [INFO] [stdout] --> src/lib.rs:437:64 [INFO] [stdout] | [INFO] [stdout] 437 | .for_each(|name| assert!(name.as_str().starts_with("A"))); [INFO] [stdout] | ^^^ help: consider using a `char`: `'A'` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless use of `for_each` [INFO] [stdout] --> src/lib.rs:438:9 [INFO] [stdout] | [INFO] [stdout] 438 | / chain [INFO] [stdout] 439 | | .iter() [INFO] [stdout] 440 | | .for_each(|name| assert!(name.as_str().ends_with("c"))); [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_for_each [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 438 ~ for name in chain [INFO] [stdout] 439 + .iter() { assert!(name.as_str().ends_with("c")); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: single-character string constant used as pattern [INFO] [stdout] --> src/lib.rs:440:62 [INFO] [stdout] | [INFO] [stdout] 440 | .for_each(|name| assert!(name.as_str().ends_with("c"))); [INFO] [stdout] | ^^^ help: consider using a `char`: `'c'` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless use of `for_each` [INFO] [stdout] --> src/lib.rs:451:9 [INFO] [stdout] | [INFO] [stdout] 451 | / chain [INFO] [stdout] 452 | | .iter() [INFO] [stdout] 453 | | .for_each(|name| assert!(name.as_str().starts_with("A"))); [INFO] [stdout] | |______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_for_each [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 451 ~ for name in chain [INFO] [stdout] 452 + .iter() { assert!(name.as_str().starts_with("A")); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: single-character string constant used as pattern [INFO] [stdout] --> src/lib.rs:453:64 [INFO] [stdout] | [INFO] [stdout] 453 | .for_each(|name| assert!(name.as_str().starts_with("A"))); [INFO] [stdout] | ^^^ help: consider using a `char`: `'A'` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless use of `for_each` [INFO] [stdout] --> src/lib.rs:454:9 [INFO] [stdout] | [INFO] [stdout] 454 | / chain [INFO] [stdout] 455 | | .iter() [INFO] [stdout] 456 | | .for_each(|name| assert!(name.as_str().ends_with("c"))); [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_for_each [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 454 ~ for name in chain [INFO] [stdout] 455 + .iter() { assert!(name.as_str().ends_with("c")); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: single-character string constant used as pattern [INFO] [stdout] --> src/lib.rs:456:62 [INFO] [stdout] | [INFO] [stdout] 456 | .for_each(|name| assert!(name.as_str().ends_with("c"))); [INFO] [stdout] | ^^^ help: consider using a `char`: `'c'` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/lib.rs:461:19 [INFO] [stdout] | [INFO] [stdout] 461 | let rng = RNG::try_from(&Language::Elven).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `&Language` to `RNG` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 461 - let rng = RNG::try_from(&Language::Elven).unwrap(); [INFO] [stdout] 461 + let rng = RNG::from(&Language::Elven); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless use of `for_each` [INFO] [stdout] --> src/lib.rs:466:9 [INFO] [stdout] | [INFO] [stdout] 466 | / chain [INFO] [stdout] 467 | | .iter() [INFO] [stdout] 468 | | .for_each(|i| assert!(NORMAL_WEIGHT.counts.contains(&(i.len() as u8)))); [INFO] [stdout] | |____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_for_each [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 466 ~ for i in chain [INFO] [stdout] 467 + .iter() { assert!(NORMAL_WEIGHT.counts.contains(&(i.len() as u8))); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting `usize` to `u8` may truncate the value [INFO] [stdout] --> src/lib.rs:468:66 [INFO] [stdout] | [INFO] [stdout] 468 | .for_each(|i| assert!(NORMAL_WEIGHT.counts.contains(&(i.len() as u8)))); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ... [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation [INFO] [stdout] = note: `#[warn(clippy::cast_possible_truncation)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] help: ... or use `try_from` and handle the error accordingly [INFO] [stdout] | [INFO] [stdout] 468 - .for_each(|i| assert!(NORMAL_WEIGHT.counts.contains(&(i.len() as u8)))); [INFO] [stdout] 468 + .for_each(|i| assert!(NORMAL_WEIGHT.counts.contains(&u8::try_from(i.len())))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless use of `for_each` [INFO] [stdout] --> src/lib.rs:469:9 [INFO] [stdout] | [INFO] [stdout] 469 | / chain [INFO] [stdout] 470 | | .iter() [INFO] [stdout] 471 | | .for_each(|i| assert!(!non.contains(&(i.len() as u8)))); [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_for_each [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 469 ~ for i in chain [INFO] [stdout] 470 + .iter() { assert!(!non.contains(&(i.len() as u8))); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting `usize` to `u8` may truncate the value [INFO] [stdout] --> src/lib.rs:471:50 [INFO] [stdout] | [INFO] [stdout] 471 | .for_each(|i| assert!(!non.contains(&(i.len() as u8)))); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ... [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation [INFO] [stdout] help: ... or use `try_from` and handle the error accordingly [INFO] [stdout] | [INFO] [stdout] 471 - .for_each(|i| assert!(!non.contains(&(i.len() as u8)))); [INFO] [stdout] 471 + .for_each(|i| assert!(!non.contains(&u8::try_from(i.len())))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty String is being created manually [INFO] [stdout] --> src/lib.rs:476:28 [INFO] [stdout] | [INFO] [stdout] 476 | assert!(RNG::empty("".to_string()).is_empty()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using: `String::new()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_string_new [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/lib.rs:483:9 [INFO] [stdout] | [INFO] [stdout] 483 | assert!(min.is_valid()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `assert!(min.is_valid());` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/lib.rs:495:9 [INFO] [stdout] | [INFO] [stdout] 495 | assert!(!bad.is_valid()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `assert!(!bad.is_valid());` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this argument is passed by value, but not consumed in the function body [INFO] [stdout] --> src/lib.rs:579:52 [INFO] [stdout] | [INFO] [stdout] 579 | fn general_generate_dialects_asserts(language: Language, count: usize) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: or consider marking this type as `Copy` [INFO] [stdout] --> src/lib.rs:622:1 [INFO] [stdout] | [INFO] [stdout] 622 | pub enum Language { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value [INFO] [stdout] = note: `#[warn(clippy::needless_pass_by_value)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] help: consider taking a reference instead [INFO] [stdout] | [INFO] [stdout] 579 | fn general_generate_dialects_asserts(language: &Language, count: usize) { [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/lib.rs:581:23 [INFO] [stdout] | [INFO] [stdout] 581 | let rng = RNG::try_from(&language).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `&Language` to `RNG` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 581 - let rng = RNG::try_from(&language).unwrap(); [INFO] [stdout] 581 + let rng = RNG::from(&language); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting `usize` to `u8` may truncate the value [INFO] [stdout] --> src/lib.rs:583:56 [INFO] [stdout] | [INFO] [stdout] 583 | let name = rng.generate_syllables_by_count(count as u8); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ... [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation [INFO] [stdout] help: ... or use `try_from` and handle the error accordingly [INFO] [stdout] | [INFO] [stdout] 583 - let name = rng.generate_syllables_by_count(count as u8); [INFO] [stdout] 583 + let name = rng.generate_syllables_by_count(u8::try_from(count)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variables can be used directly in the `format!` string [INFO] [stdout] --> src/lib.rs:614:13 [INFO] [stdout] | [INFO] [stdout] 614 | assert!((count < 6) && (count > 1), "count of {} should be less than 6 and greater than 1", count); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args [INFO] [stdout] = note: `#[warn(clippy::uninlined_format_args)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 614 - assert!((count < 6) && (count > 1), "count of {} should be less than 6 and greater than 1", count); [INFO] [stdout] 614 + assert!((count < 6) && (count > 1), "count of {count} should be less than 6 and greater than 1"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 27.19s [INFO] running `Command { std: "docker" "inspect" "32fffced847901cf931adb72817d4caa99bb1d5089353155f5d42b31f38c615c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "32fffced847901cf931adb72817d4caa99bb1d5089353155f5d42b31f38c615c", kill_on_drop: false }` [INFO] [stdout] 32fffced847901cf931adb72817d4caa99bb1d5089353155f5d42b31f38c615c