[INFO] fetching crate ramify 0.9.1... [INFO] linting ramify-0.9.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate ramify 0.9.1 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate ramify 0.9.1 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate ramify 0.9.1 [INFO] tweaked toml for crates.io crate ramify 0.9.1 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate ramify 0.9.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate ramify 0.9.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rand_xoshiro v0.7.0 [INFO] [stderr] Downloaded zmij v0.1.8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9acc99fae028cac3c49b6339d3b9de5cc195bd43752067a3ce897f4a9b8dfe21 [INFO] running `Command { std: "docker" "start" "-a" "9acc99fae028cac3c49b6339d3b9de5cc195bd43752067a3ce897f4a9b8dfe21", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9acc99fae028cac3c49b6339d3b9de5cc195bd43752067a3ce897f4a9b8dfe21", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9acc99fae028cac3c49b6339d3b9de5cc195bd43752067a3ce897f4a9b8dfe21", kill_on_drop: false }` [INFO] [stdout] 9acc99fae028cac3c49b6339d3b9de5cc195bd43752067a3ce897f4a9b8dfe21 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2745b88dca5c09b1f985e78a069e1ea8ef82d47285b2d10cee588e896f62bd1e [INFO] running `Command { std: "docker" "start" "-a" "2745b88dca5c09b1f985e78a069e1ea8ef82d47285b2d10cee588e896f62bd1e", kill_on_drop: false }` [INFO] [stderr] Compiling zerocopy-derive v0.8.31 [INFO] [stderr] Compiling cc v1.2.50 [INFO] [stderr] Checking zmij v0.1.8 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking clap_builder v4.5.53 [INFO] [stderr] Compiling argh_shared v0.1.13 [INFO] [stderr] Checking page_size v0.6.0 [INFO] [stderr] Checking rust-fuzzy-search v0.1.1 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking ramify v0.9.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking rand_xoshiro v0.7.0 [INFO] [stderr] Checking serde_json v1.0.147 [INFO] [stderr] Compiling argh_derive v0.1.13 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Compiling alloca v0.4.0 [INFO] [stderr] Checking zerocopy v0.8.31 [INFO] [stderr] Checking argh v0.1.13 [INFO] [stderr] Checking clap v4.5.53 [INFO] [stderr] Checking criterion-plot v0.8.1 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking criterion v0.8.1 [INFO] [stderr] Checking rand_distr v0.5.1 [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> examples/basic.rs:51:22 [INFO] [stdout] | [INFO] [stdout] 51 | buf.push_str(&vtx.annotation); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `vtx.annotation` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> examples/numbered.rs:54:22 [INFO] [stdout] | [INFO] [stdout] 54 | buf.push_str(&vtx.annotation); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `vtx.annotation` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> tests/vtx.rs:104:21 [INFO] [stdout] | [INFO] [stdout] 104 | Err(().into()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] = note: `#[warn(clippy::unit_arg)]` on by default [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 104 ~ let _: () = ().into(); [INFO] [stdout] 105 + Err(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `()` [INFO] [stdout] --> tests/vtx.rs:104:25 [INFO] [stdout] | [INFO] [stdout] 104 | Err(().into()) [INFO] [stdout] | ^^^^^^^^^ help: consider removing `.into()`: `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> examples/cascade.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | / impl PartialOrd for Key { [INFO] [stdout] 25 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 26 | | Some(self.0.total_cmp(&other.0)) [INFO] [stdout] 27 | | } [INFO] [stdout] 28 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 25 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 26 - Some(self.0.total_cmp(&other.0)) [INFO] [stdout] 27 - } [INFO] [stdout] 25 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> tests/vtx.rs:104:21 [INFO] [stdout] | [INFO] [stdout] 104 | Err(().into()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] = note: `#[warn(clippy::unit_arg)]` on by default [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 104 ~ let _: () = ().into(); [INFO] [stdout] 105 + Err(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `()` [INFO] [stdout] --> tests/vtx.rs:104:25 [INFO] [stdout] | [INFO] [stdout] 104 | Err(().into()) [INFO] [stdout] | ^^^^^^^^^ help: consider removing `.into()`: `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> tests/vtx.rs:104:21 [INFO] [stdout] | [INFO] [stdout] 104 | Err(().into()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] = note: `#[warn(clippy::unit_arg)]` on by default [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 104 ~ let _: () = ().into(); [INFO] [stdout] 105 + Err(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `()` [INFO] [stdout] --> tests/vtx.rs:104:25 [INFO] [stdout] | [INFO] [stdout] 104 | Err(().into()) [INFO] [stdout] | ^^^^^^^^^ help: consider removing `.into()`: `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> tests/vtx.rs:104:21 [INFO] [stdout] | [INFO] [stdout] 104 | Err(().into()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] = note: `#[warn(clippy::unit_arg)]` on by default [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 104 ~ let _: () = ().into(); [INFO] [stdout] 105 + Err(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `()` [INFO] [stdout] --> tests/vtx.rs:104:25 [INFO] [stdout] | [INFO] [stdout] 104 | Err(().into()) [INFO] [stdout] | ^^^^^^^^^ help: consider removing `.into()`: `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> tests/vtx.rs:104:21 [INFO] [stdout] | [INFO] [stdout] 104 | Err(().into()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] = note: `#[warn(clippy::unit_arg)]` on by default [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 104 ~ let _: () = ().into(); [INFO] [stdout] 105 + Err(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `()` [INFO] [stdout] --> tests/vtx.rs:104:25 [INFO] [stdout] | [INFO] [stdout] 104 | Err(().into()) [INFO] [stdout] | ^^^^^^^^^ help: consider removing `.into()`: `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> examples/inverted.rs:50:22 [INFO] [stdout] | [INFO] [stdout] 50 | buf.push_str(&vtx.annotation) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `vtx.annotation` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> tests/vtx.rs:104:21 [INFO] [stdout] | [INFO] [stdout] 104 | Err(().into()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] = note: `#[warn(clippy::unit_arg)]` on by default [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 104 ~ let _: () = ().into(); [INFO] [stdout] 105 + Err(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `()` [INFO] [stdout] --> tests/vtx.rs:104:25 [INFO] [stdout] | [INFO] [stdout] 104 | Err(().into()) [INFO] [stdout] | ^^^^^^^^^ help: consider removing `.into()`: `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> tests/vtx.rs:104:21 [INFO] [stdout] | [INFO] [stdout] 104 | Err(().into()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] = note: `#[warn(clippy::unit_arg)]` on by default [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 104 ~ let _: () = ().into(); [INFO] [stdout] 105 + Err(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `()` [INFO] [stdout] --> tests/vtx.rs:104:25 [INFO] [stdout] | [INFO] [stdout] 104 | Err(().into()) [INFO] [stdout] | ^^^^^^^^^ help: consider removing `.into()`: `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/columns/iter/tests.rs:32:19 [INFO] [stdout] | [INFO] [stdout] 32 | expected: [(usize, std::ops::Range, Option, &[usize]); N], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/columns/iter/tests.rs:128:12 [INFO] [stdout] | [INFO] [stdout] 128 | if !ct.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `ct.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.05s [INFO] running `Command { std: "docker" "inspect" "2745b88dca5c09b1f985e78a069e1ea8ef82d47285b2d10cee588e896f62bd1e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2745b88dca5c09b1f985e78a069e1ea8ef82d47285b2d10cee588e896f62bd1e", kill_on_drop: false }` [INFO] [stdout] 2745b88dca5c09b1f985e78a069e1ea8ef82d47285b2d10cee588e896f62bd1e