[INFO] fetching crate ra_ap_completion 0.0.38... [INFO] linting ra_ap_completion-0.0.38 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate ra_ap_completion 0.0.38 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate ra_ap_completion 0.0.38 [INFO] finished tweaking crates.io crate ra_ap_completion 0.0.38 [INFO] tweaked toml for crates.io crate ra_ap_completion 0.0.38 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate ra_ap_completion 0.0.38 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 136 packages to latest compatible versions [INFO] [stderr] Adding itertools v0.10.5 (available: v0.14.0) [INFO] [stderr] Adding ra_ap_base_db v0.0.38 (available: v0.0.324) [INFO] [stderr] Adding ra_ap_hir v0.0.38 (available: v0.0.324) [INFO] [stderr] Adding ra_ap_ide_db v0.0.38 (available: v0.0.324) [INFO] [stderr] Adding ra_ap_profile v0.0.38 (available: v0.0.324) [INFO] [stderr] Adding ra_ap_stdx v0.0.38 (available: v0.0.324) [INFO] [stderr] Adding ra_ap_syntax v0.0.38 (available: v0.0.324) [INFO] [stderr] Adding ra_ap_test_utils v0.0.38 (available: v0.0.324) [INFO] [stderr] Adding ra_ap_text_edit v0.0.38 (available: v0.0.241) [INFO] [stderr] Adding rustc-hash v1.1.0 (available: v2.1.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded ra_ap_test_utils v0.0.38 [INFO] [stderr] Downloaded rustc-hash v1.1.0 [INFO] [stderr] Downloaded ra_ap_text_edit v0.0.38 [INFO] [stderr] Downloaded text-size v1.1.1 [INFO] [stderr] Downloaded quote v1.0.45 [INFO] [stderr] Downloaded chalk-derive v0.56.0 [INFO] [stderr] Downloaded expect-test v1.5.1 [INFO] [stderr] Downloaded salsa-macros v0.16.0 [INFO] [stderr] Downloaded ra_ap_tt v0.0.38 [INFO] [stderr] Downloaded instant v0.1.13 [INFO] [stderr] Downloaded num_cpus v1.17.0 [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.114 [INFO] [stderr] Downloaded crossbeam-utils v0.8.21 [INFO] [stderr] Downloaded fixedbitset v0.2.0 [INFO] [stderr] Downloaded anymap v0.12.1 [INFO] [stderr] Downloaded chalk-recursive v0.56.0 [INFO] [stderr] Downloaded thread_local v1.1.9 [INFO] [stderr] Downloaded synstructure v0.12.6 [INFO] [stderr] Downloaded wasm-bindgen v0.2.114 [INFO] [stderr] Downloaded chalk-ir v0.56.0 [INFO] [stderr] Downloaded cc v1.2.57 [INFO] [stderr] Downloaded itertools v0.9.0 [INFO] [stderr] Downloaded tracing-subscriber v0.2.25 [INFO] [stderr] Downloaded regex-automata v0.1.10 [INFO] [stderr] Downloaded ra_ap_hir_ty v0.0.38 [INFO] [stderr] Downloaded regex v1.12.3 [INFO] [stderr] Downloaded ra_ap_hir_def v0.0.38 [INFO] [stderr] Downloaded rayon v1.11.0 [INFO] [stderr] Downloaded chrono v0.4.44 [INFO] [stderr] Downloaded ra_ap_syntax v0.0.38 [INFO] [stderr] Downloaded syn v2.0.117 [INFO] [stderr] Downloaded itertools v0.10.5 [INFO] [stderr] Downloaded regex-syntax v0.6.29 [INFO] [stderr] Downloaded petgraph v0.5.1 [INFO] [stderr] Downloaded regex-syntax v0.8.10 [INFO] [stderr] Downloaded js-sys v0.3.91 [INFO] [stderr] Downloaded bumpalo v3.20.2 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.114 [INFO] [stderr] Downloaded salsa v0.16.1 [INFO] [stderr] Downloaded chalk-solve v0.56.0 [INFO] [stderr] Downloaded unicode-segmentation v1.12.0 [INFO] [stderr] Downloaded hashbrown v0.12.3 [INFO] [stderr] Downloaded tracing-core v0.1.36 [INFO] [stderr] Downloaded regex-automata v0.4.14 [INFO] [stderr] Downloaded tracing v0.1.44 [INFO] [stderr] Downloaded parking_lot v0.11.2 [INFO] [stderr] Downloaded rayon-core v1.13.0 [INFO] [stderr] Downloaded rowan v0.12.6 [INFO] [stderr] Downloaded once_cell v1.21.4 [INFO] [stderr] Downloaded perf-event-open-sys v6.0.0 [INFO] [stderr] Downloaded memchr v2.8.0 [INFO] [stderr] Downloaded sharded-slab v0.1.7 [INFO] [stderr] Downloaded tracing-attributes v0.1.31 [INFO] [stderr] Downloaded tracing-tree v0.1.11 [INFO] [stderr] Downloaded dissimilar v1.0.11 [INFO] [stderr] Downloaded hermit-abi v0.5.2 [INFO] [stderr] Downloaded dashmap v4.0.2 [INFO] [stderr] Downloaded hermit-abi v0.1.19 [INFO] [stderr] Downloaded ansi_term v0.12.1 [INFO] [stderr] Downloaded find-msvc-tools v0.1.9 [INFO] [stderr] Downloaded iana-time-zone v0.1.65 [INFO] [stderr] Downloaded pin-project-lite v0.2.17 [INFO] [stderr] Downloaded tracing-log v0.1.4 [INFO] [stderr] Downloaded ra_ap_parser v0.0.38 [INFO] [stderr] Downloaded valuable v0.1.1 [INFO] [stderr] Downloaded libc v0.2.183 [INFO] [stderr] Downloaded ena v0.14.4 [INFO] [stderr] Downloaded oorandom v11.1.5 [INFO] [stderr] Downloaded ra_ap_ide_db v0.0.38 [INFO] [stderr] Downloaded indexmap v1.9.3 [INFO] [stderr] Downloaded rustc-ap-rustc_lexer v705.0.0 [INFO] [stderr] Downloaded countme v2.0.4 [INFO] [stderr] Downloaded perf-event v0.4.9 [INFO] [stderr] Downloaded ra_ap_cfg v0.0.38 [INFO] [stderr] Downloaded ra_ap_vfs v0.0.38 [INFO] [stderr] Downloaded bitflags v1.3.2 [INFO] [stderr] Downloaded parking_lot_core v0.8.6 [INFO] [stderr] Downloaded ra_ap_mbe v0.0.38 [INFO] [stderr] Downloaded ra_ap_hir_expand v0.0.38 [INFO] [stderr] Downloaded crossbeam-epoch v0.9.18 [INFO] [stderr] Downloaded memoffset v0.6.5 [INFO] [stderr] Downloaded bitflags v2.11.0 [INFO] [stderr] Downloaded ra_ap_profile v0.0.38 [INFO] [stderr] Downloaded ra_ap_stdx v0.0.38 [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.114 [INFO] [stderr] Downloaded tracing-serde v0.1.3 [INFO] [stderr] Downloaded ra_ap_paths v0.0.38 [INFO] [stderr] Downloaded drop_bomb v0.1.5 [INFO] [stderr] Downloaded unicode-xid v0.2.6 [INFO] [stderr] Downloaded smol_str v0.1.24 [INFO] [stderr] Downloaded ra_ap_la-arena v0.0.38 [INFO] [stderr] Downloaded always-assert v0.1.3 [INFO] [stderr] Downloaded matchers v0.0.1 [INFO] [stderr] Downloaded redox_syscall v0.2.16 [INFO] [stderr] Downloaded ra_ap_hir v0.0.38 [INFO] [stderr] Downloaded crossbeam-deque v0.8.6 [INFO] [stderr] Downloaded either v1.15.0 [INFO] [stderr] Downloaded ra_ap_base_db v0.0.38 [INFO] [stderr] Downloaded heck v0.3.3 [INFO] [stderr] Downloaded scoped-tls v1.0.1 [INFO] [stderr] Downloaded proc-macro2 v1.0.106 [INFO] [stderr] Downloaded unicode-ident v1.0.24 [INFO] [stderr] Downloaded zmij v1.0.21 [INFO] [stderr] Downloaded fst v0.4.7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7a13c05598c42da41c4b72374203215f7abdf96495ec52cb01fa09a402fa852f [INFO] running `Command { std: "docker" "start" "-a" "7a13c05598c42da41c4b72374203215f7abdf96495ec52cb01fa09a402fa852f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7a13c05598c42da41c4b72374203215f7abdf96495ec52cb01fa09a402fa852f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7a13c05598c42da41c4b72374203215f7abdf96495ec52cb01fa09a402fa852f", kill_on_drop: false }` [INFO] [stdout] 7a13c05598c42da41c4b72374203215f7abdf96495ec52cb01fa09a402fa852f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bc790b0aa8829b5979832472d27ad14fcc115861c3aaa6d9aacf0f29c09a51c8 [INFO] running `Command { std: "docker" "start" "-a" "bc790b0aa8829b5979832472d27ad14fcc115861c3aaa6d9aacf0f29c09a51c8", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Compiling unicode-ident v1.0.24 [INFO] [stderr] Compiling autocfg v1.5.0 [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Checking cfg-if v1.0.4 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking once_cell v1.21.4 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Compiling zmij v1.0.21 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking itoa v1.0.17 [INFO] [stderr] Checking memchr v2.8.0 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Checking always-assert v0.1.3 [INFO] [stderr] Checking bitflags v2.11.0 [INFO] [stderr] Checking ra_ap_stdx v0.0.38 [INFO] [stderr] Checking text-size v1.1.1 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Checking ra_ap_la-arena v0.0.38 [INFO] [stderr] Checking dissimilar v1.0.11 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Compiling unicode-segmentation v1.12.0 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling fst v0.4.7 [INFO] [stderr] Checking regex-syntax v0.8.10 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking drop_bomb v0.1.5 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking hashbrown v0.9.1 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking unicode-xid v0.2.6 [INFO] [stderr] Checking ra_ap_parser v0.0.38 [INFO] [stderr] Checking lock_api v0.4.14 [INFO] [stderr] Checking rustc-ap-rustc_lexer v705.0.0 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking ra_ap_text_edit v0.0.38 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking pin-project-lite v0.2.17 [INFO] [stderr] Checking iana-time-zone v0.1.65 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking tracing-log v0.1.4 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking thread_local v1.1.9 [INFO] [stderr] Checking ra_ap_paths v0.0.38 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking oorandom v11.1.5 [INFO] [stderr] Checking fixedbitset v0.2.0 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking ena v0.14.4 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling rayon-core v1.13.0 [INFO] [stderr] Checking petgraph v0.5.1 [INFO] [stderr] Checking anymap v0.12.1 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Checking expect-test v1.5.1 [INFO] [stderr] Checking crossbeam-deque v0.8.6 [INFO] [stderr] Checking ra_ap_vfs v0.0.38 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Checking perf-event-open-sys v6.0.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking dashmap v4.0.2 [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stderr] Checking perf-event v0.4.9 [INFO] [stderr] Checking countme v2.0.4 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking ra_ap_profile v0.0.38 [INFO] [stderr] Checking rowan v0.12.6 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking matchers v0.0.1 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking ra_ap_test_utils v0.0.38 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling salsa-macros v0.16.0 [INFO] [stderr] Compiling chalk-derive v0.56.0 [INFO] [stderr] Checking chalk-ir v0.56.0 [INFO] [stderr] Checking salsa v0.16.1 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking smol_str v0.1.24 [INFO] [stderr] Checking tracing-serde v0.1.3 [INFO] [stderr] Checking ra_ap_tt v0.0.38 [INFO] [stderr] Checking ra_ap_syntax v0.0.38 [INFO] [stderr] Checking tracing-subscriber v0.2.25 [INFO] [stderr] Checking ra_ap_cfg v0.0.38 [INFO] [stderr] Checking ra_ap_mbe v0.0.38 [INFO] [stderr] Checking ra_ap_base_db v0.0.38 [INFO] [stderr] Checking tracing-tree v0.1.11 [INFO] [stderr] Checking chalk-solve v0.56.0 [INFO] [stderr] Checking ra_ap_hir_expand v0.0.38 [INFO] [stderr] Checking ra_ap_hir_def v0.0.38 [INFO] [stderr] Checking chalk-recursive v0.56.0 [INFO] [stderr] Checking ra_ap_hir_ty v0.0.38 [INFO] [stderr] Checking ra_ap_hir v0.0.38 [INFO] [stderr] Checking ra_ap_ide_db v0.0.38 [INFO] [stderr] Checking ra_ap_completion v0.0.38 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/render/enum_variant.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 25 | struct EnumRender<'a> { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 26 | ctx: RenderContext<'a>, [INFO] [stdout] 27 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `EnumRender` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/item.rs:193:5 [INFO] [stdout] | [INFO] [stdout] 193 | / pub(crate) fn new( [INFO] [stdout] 194 | | completion_kind: CompletionKind, [INFO] [stdout] 195 | | source_range: TextRange, [INFO] [stdout] 196 | | label: impl Into, [INFO] [stdout] ... | [INFO] [stdout] 216 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `splitn` [INFO] [stdout] --> src/item.rs:408:36 [INFO] [stdout] | [INFO] [stdout] 408 | self.detail = Some(detail.splitn(2, '\n').next().unwrap().to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `detail.split('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_splitn [INFO] [stdout] = note: `#[warn(clippy::needless_splitn)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `ra_ap_hir::Documentation` [INFO] [stdout] --> src/item.rs:418:34 [INFO] [stdout] | [INFO] [stdout] 418 | self.documentation = docs.map(Into::into); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider removing [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/item.rs:446:1 [INFO] [stdout] | [INFO] [stdout] 446 | impl<'a> Into for Builder { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 446 ~ impl<'a> From for CompletionItem { [INFO] [stdout] 447 ~ fn from(val: Builder) -> Self { [INFO] [stdout] 448 ~ val.build() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/item.rs:446:6 [INFO] [stdout] | [INFO] [stdout] 446 | impl<'a> Into for Builder { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/context.rs:269:48 [INFO] [stdout] | [INFO] [stdout] 269 | find_node_at_offset::(&file_with_fake_ident, offset) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `file_with_fake_ident` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/context.rs:274:13 [INFO] [stdout] | [INFO] [stdout] 274 | / syntax_element.ancestors().take(6).find_map(ast::LetStmt::cast).map_or(false, |it| { [INFO] [stdout] 275 | | it.syntax().text_range().end() == syntax_element.text_range().end() [INFO] [stdout] 276 | | }); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 274 - syntax_element.ancestors().take(6).find_map(ast::LetStmt::cast).map_or(false, |it| { [INFO] [stdout] 274 + syntax_element.ancestors().take(6).find_map(ast::LetStmt::cast).is_some_and(|it| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/context.rs:323:63 [INFO] [stdout] | [INFO] [stdout] 323 | self.sema.find_node_at_offset_with_macros(&original_file, offset); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `original_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/context.rs:366:63 [INFO] [stdout] | [INFO] [stdout] 366 | self.sema.find_node_at_offset_with_macros(&original_file, offset); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `original_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/context.rs:378:33 [INFO] [stdout] | [INFO] [stdout] 378 | find_node_at_offset(&original_file, name_ref.syntax().text_range().start()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `original_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/context.rs:382:59 [INFO] [stdout] | [INFO] [stdout] 382 | self.sema.find_node_at_offset_with_macros(&original_file, offset); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `original_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/patterns.rs:95:8 [INFO] [stdout] | [INFO] [stdout] 95 | if !ancestor.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `ancestor.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/patterns.rs:121:19 [INFO] [stdout] | [INFO] [stdout] 121 | .and_then(|it| previous_non_trivia_token(it)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `previous_non_trivia_token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/patterns.rs:133:19 [INFO] [stdout] | [INFO] [stdout] 133 | .and_then(|it| previous_non_trivia_token(it)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `previous_non_trivia_token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/patterns.rs:141:19 [INFO] [stdout] | [INFO] [stdout] 141 | .and_then(|it| previous_non_trivia_token(it)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `previous_non_trivia_token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/patterns.rs:156:19 [INFO] [stdout] | [INFO] [stdout] 156 | .and_then(|it| previous_non_trivia_token(it)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `previous_non_trivia_token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/patterns.rs:155:19 [INFO] [stdout] | [INFO] [stdout] 155 | .and_then(|it| previous_non_trivia_token(it)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `previous_non_trivia_token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/render/macro_.rs:44:85 [INFO] [stdout] | [INFO] [stdout] 44 | CompletionItem::new(CompletionKind::Reference, self.ctx.source_range(), &self.label()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `self.label()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `ra_ap_syntax::ast::AstChildren` [INFO] [stdout] --> src/render/function.rs:91:21 [INFO] [stdout] | [INFO] [stdout] 91 | .extend(ast_params.params().into_iter().map(|it| it.pat().map(|it| it.to_string()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `ast_params.params()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/render/enum_variant.rs:97:80 [INFO] [stdout] | [INFO] [stdout] 97 | .map(|(n, t)| format!("{}: {}", n, t.display(self.ctx.db()).to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/render/pattern.rs:17:10 [INFO] [stdout] | [INFO] [stdout] 17 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/render/pattern.rs:96:33 [INFO] [stdout] | [INFO] [stdout] 96 | render_tuple_as_pat(&fields, &name, fields_omitted) [INFO] [stdout] | ^^^^^^^ help: change this to: `fields` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/render/pattern.rs:96:42 [INFO] [stdout] | [INFO] [stdout] 96 | render_tuple_as_pat(&fields, &name, fields_omitted) [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/render/pattern.rs:99:63 [INFO] [stdout] | [INFO] [stdout] 99 | render_record_as_pat(ctx.db(), ctx.snippet_cap(), &fields, &name, fields_omitted) [INFO] [stdout] | ^^^^^^^ help: change this to: `fields` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/render/pattern.rs:99:72 [INFO] [stdout] | [INFO] [stdout] 99 | render_record_as_pat(ctx.db(), ctx.snippet_cap(), &fields, &name, fields_omitted) [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/render/pattern.rs:107:22 [INFO] [stdout] | [INFO] [stdout] 107 | pat.push_str(&name); [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/render.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | self.completion.config.snippet_cap.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.completion.config.snippet_cap` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/render.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | &self.completion.db [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `self.completion.db` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/render.rs:154:55 [INFO] [stdout] | [INFO] [stdout] 154 | if let Some(score) = compute_score(&self.ctx, &ty, &name.to_string()) { [INFO] [stdout] | ^^^ help: change this to: `ty` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/render.rs:344:60 [INFO] [stdout] | [INFO] [stdout] 344 | let score = compute_score_from_active(&derefed_active, &active_name, &ty, &name)?; [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `active_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/render.rs:344:74 [INFO] [stdout] | [INFO] [stdout] 344 | let score = compute_score_from_active(&derefed_active, &active_name, &ty, &name)?; [INFO] [stdout] | ^^^ help: change this to: `ty` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/render.rs:344:79 [INFO] [stdout] | [INFO] [stdout] 344 | let score = compute_score_from_active(&derefed_active, &active_name, &ty, &name)?; [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/completions/attribute.rs:191:14 [INFO] [stdout] | [INFO] [stdout] 191 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/completions/dot.rs:16:51 [INFO] [stdout] | [INFO] [stdout] 16 | let receiver_ty = match ctx.sema.type_of_expr(&dot_receiver) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `dot_receiver` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/completions/dot.rs:32:16 [INFO] [stdout] | [INFO] [stdout] 32 | if ctx.scope.module().map_or(false, |m| !field.is_visible_from(ctx.db, m)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 32 - if ctx.scope.module().map_or(false, |m| !field.is_visible_from(ctx.db, m)) { [INFO] [stdout] 32 + if ctx.scope.module().is_some_and(|m| !field.is_visible_from(ctx.db, m)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/completions/dot.rs:52:20 [INFO] [stdout] | [INFO] [stdout] 52 | && ctx.scope.module().map_or(true, |m| func.is_visible_from(ctx.db, m)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 52 - && ctx.scope.module().map_or(true, |m| func.is_visible_from(ctx.db, m)) [INFO] [stdout] 52 + && ctx.scope.module().is_none_or(|m| func.is_visible_from(ctx.db, m)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Struct` which implements the `Copy` trait [INFO] [stdout] --> src/completions/pattern.rs:26:45 [INFO] [stdout] | [INFO] [stdout] 26 | acc.add_struct_pat(ctx, strukt.clone(), Some(name.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*strukt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Variant` which implements the `Copy` trait [INFO] [stdout] --> src/completions/pattern.rs:30:46 [INFO] [stdout] | [INFO] [stdout] 30 | acc.add_variant_pat(ctx, variant.clone(), Some(name.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*variant` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/completions/qualified_path.rs:80:24 [INFO] [stdout] | [INFO] [stdout] 80 | if context_module.map_or(false, |m| !item.is_visible_from(ctx.db, m)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 80 - if context_module.map_or(false, |m| !item.is_visible_from(ctx.db, m)) { [INFO] [stdout] 80 + if context_module.is_some_and(|m| !item.is_visible_from(ctx.db, m)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/completions/qualified_path.rs:95:24 [INFO] [stdout] | [INFO] [stdout] 95 | if context_module.map_or(false, |m| !item.is_visible_from(ctx.db, m)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 95 - if context_module.map_or(false, |m| !item.is_visible_from(ctx.db, m)) { [INFO] [stdout] 95 + if context_module.is_some_and(|m| !item.is_visible_from(ctx.db, m)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/completions/qualified_path.rs:109:20 [INFO] [stdout] | [INFO] [stdout] 109 | if context_module.map_or(false, |m| !item.is_visible_from(ctx.db, m)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 109 - if context_module.map_or(false, |m| !item.is_visible_from(ctx.db, m)) { [INFO] [stdout] 109 + if context_module.is_some_and(|m| !item.is_visible_from(ctx.db, m)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/completions/qualified_path.rs:138:24 [INFO] [stdout] | [INFO] [stdout] 138 | if context_module.map_or(false, |m| !item.is_visible_from(ctx.db, m)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 138 - if context_module.map_or(false, |m| !item.is_visible_from(ctx.db, m)) { [INFO] [stdout] 138 + if context_module.is_some_and(|m| !item.is_visible_from(ctx.db, m)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/completions/postfix/format_like.rs:54:39 [INFO] [stdout] | [INFO] [stdout] 54 | postfix_snippet(ctx, cap, &dot_receiver, label, macro_name, &snippet).add_to(acc); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `dot_receiver` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/completions/postfix/format_like.rs:92:20 [INFO] [stdout] | [INFO] [stdout] 92 | input: input.into(), [INFO] [stdout] | ^^^^^^^^^^^^ help: consider removing `.into()`: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `into_*` usually take `self` by value [INFO] [stdout] --> src/completions/postfix/format_like.rs:202:35 [INFO] [stdout] | [INFO] [stdout] 202 | pub(crate) fn into_suggestion(&self, macro_name: &str) -> String { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/completions/postfix.rs:33:51 [INFO] [stdout] | [INFO] [stdout] 33 | let receiver_ty = match ctx.sema.type_of_expr(&dot_receiver) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `dot_receiver` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/completions/postfix.rs:52:21 [INFO] [stdout] | [INFO] [stdout] 52 | &dot_receiver, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `dot_receiver` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/completions/postfix.rs:62:21 [INFO] [stdout] | [INFO] [stdout] 62 | &dot_receiver, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `dot_receiver` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/completions/postfix.rs:73:21 [INFO] [stdout] | [INFO] [stdout] 73 | &dot_receiver, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `dot_receiver` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/completions/postfix.rs:83:21 [INFO] [stdout] | [INFO] [stdout] 83 | &dot_receiver, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `dot_receiver` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/completions/postfix.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 95 | &dot_receiver, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `dot_receiver` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/completions/postfix.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 104 | &dot_receiver, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `dot_receiver` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/completions/postfix.rs:110:35 [INFO] [stdout] | [INFO] [stdout] 110 | postfix_snippet(ctx, cap, &dot_receiver, "not", "!expr", &format!("!{}", receiver_text)) [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `dot_receiver` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/completions/postfix.rs:114:31 [INFO] [stdout] | [INFO] [stdout] 114 | postfix_snippet(ctx, cap, &dot_receiver, "ref", "&expr", &format!("&{}", receiver_text)) [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `dot_receiver` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/completions/postfix.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 119 | &dot_receiver, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `dot_receiver` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/completions.rs:43:1 [INFO] [stdout] | [INFO] [stdout] 43 | impl Into> for Completions { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 43 ~ impl From for Vec { [INFO] [stdout] 44 ~ fn from(val: Completions) -> Self { [INFO] [stdout] 45 ~ val.buf [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `item::CompletionItem` [INFO] [stdout] --> src/completions.rs:59:23 [INFO] [stdout] | [INFO] [stdout] 59 | self.buf.push(item.into()) [INFO] [stdout] | ^^^^^^^^^^^ help: consider removing `.into()`: `item` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/render/enum_variant.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 25 | struct EnumRender<'a> { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 26 | ctx: RenderContext<'a>, [INFO] [stdout] 27 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `EnumRender` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/item.rs:193:5 [INFO] [stdout] | [INFO] [stdout] 193 | / pub(crate) fn new( [INFO] [stdout] 194 | | completion_kind: CompletionKind, [INFO] [stdout] 195 | | source_range: TextRange, [INFO] [stdout] 196 | | label: impl Into, [INFO] [stdout] ... | [INFO] [stdout] 216 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `splitn` [INFO] [stdout] --> src/item.rs:408:36 [INFO] [stdout] | [INFO] [stdout] 408 | self.detail = Some(detail.splitn(2, '\n').next().unwrap().to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `detail.split('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_splitn [INFO] [stdout] = note: `#[warn(clippy::needless_splitn)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `ra_ap_hir::Documentation` [INFO] [stdout] --> src/item.rs:418:34 [INFO] [stdout] | [INFO] [stdout] 418 | self.documentation = docs.map(Into::into); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider removing [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/item.rs:446:1 [INFO] [stdout] | [INFO] [stdout] 446 | impl<'a> Into for Builder { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 446 ~ impl<'a> From for CompletionItem { [INFO] [stdout] 447 ~ fn from(val: Builder) -> Self { [INFO] [stdout] 448 ~ val.build() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/item.rs:446:6 [INFO] [stdout] | [INFO] [stdout] 446 | impl<'a> Into for Builder { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/context.rs:269:48 [INFO] [stdout] | [INFO] [stdout] 269 | find_node_at_offset::(&file_with_fake_ident, offset) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `file_with_fake_ident` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/context.rs:274:13 [INFO] [stdout] | [INFO] [stdout] 274 | / syntax_element.ancestors().take(6).find_map(ast::LetStmt::cast).map_or(false, |it| { [INFO] [stdout] 275 | | it.syntax().text_range().end() == syntax_element.text_range().end() [INFO] [stdout] 276 | | }); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 274 - syntax_element.ancestors().take(6).find_map(ast::LetStmt::cast).map_or(false, |it| { [INFO] [stdout] 274 + syntax_element.ancestors().take(6).find_map(ast::LetStmt::cast).is_some_and(|it| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/context.rs:323:63 [INFO] [stdout] | [INFO] [stdout] 323 | self.sema.find_node_at_offset_with_macros(&original_file, offset); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `original_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/context.rs:366:63 [INFO] [stdout] | [INFO] [stdout] 366 | self.sema.find_node_at_offset_with_macros(&original_file, offset); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `original_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/context.rs:378:33 [INFO] [stdout] | [INFO] [stdout] 378 | find_node_at_offset(&original_file, name_ref.syntax().text_range().start()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `original_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/context.rs:382:59 [INFO] [stdout] | [INFO] [stdout] 382 | self.sema.find_node_at_offset_with_macros(&original_file, offset); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `original_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/patterns.rs:95:8 [INFO] [stdout] | [INFO] [stdout] 95 | if !ancestor.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `ancestor.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/patterns.rs:121:19 [INFO] [stdout] | [INFO] [stdout] 121 | .and_then(|it| previous_non_trivia_token(it)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `previous_non_trivia_token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/patterns.rs:133:19 [INFO] [stdout] | [INFO] [stdout] 133 | .and_then(|it| previous_non_trivia_token(it)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `previous_non_trivia_token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/patterns.rs:141:19 [INFO] [stdout] | [INFO] [stdout] 141 | .and_then(|it| previous_non_trivia_token(it)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `previous_non_trivia_token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/patterns.rs:156:19 [INFO] [stdout] | [INFO] [stdout] 156 | .and_then(|it| previous_non_trivia_token(it)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `previous_non_trivia_token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/patterns.rs:155:19 [INFO] [stdout] | [INFO] [stdout] 155 | .and_then(|it| previous_non_trivia_token(it)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `previous_non_trivia_token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/render/macro_.rs:44:85 [INFO] [stdout] | [INFO] [stdout] 44 | CompletionItem::new(CompletionKind::Reference, self.ctx.source_range(), &self.label()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `self.label()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `ra_ap_syntax::ast::AstChildren` [INFO] [stdout] --> src/render/function.rs:91:21 [INFO] [stdout] | [INFO] [stdout] 91 | .extend(ast_params.params().into_iter().map(|it| it.pat().map(|it| it.to_string()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `ast_params.params()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/render/enum_variant.rs:97:80 [INFO] [stdout] | [INFO] [stdout] 97 | .map(|(n, t)| format!("{}: {}", n, t.display(self.ctx.db()).to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/render/pattern.rs:17:10 [INFO] [stdout] | [INFO] [stdout] 17 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/render/pattern.rs:96:33 [INFO] [stdout] | [INFO] [stdout] 96 | render_tuple_as_pat(&fields, &name, fields_omitted) [INFO] [stdout] | ^^^^^^^ help: change this to: `fields` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/render/pattern.rs:96:42 [INFO] [stdout] | [INFO] [stdout] 96 | render_tuple_as_pat(&fields, &name, fields_omitted) [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/render/pattern.rs:99:63 [INFO] [stdout] | [INFO] [stdout] 99 | render_record_as_pat(ctx.db(), ctx.snippet_cap(), &fields, &name, fields_omitted) [INFO] [stdout] | ^^^^^^^ help: change this to: `fields` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/render/pattern.rs:99:72 [INFO] [stdout] | [INFO] [stdout] 99 | render_record_as_pat(ctx.db(), ctx.snippet_cap(), &fields, &name, fields_omitted) [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/render/pattern.rs:107:22 [INFO] [stdout] | [INFO] [stdout] 107 | pat.push_str(&name); [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/render.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | self.completion.config.snippet_cap.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.completion.config.snippet_cap` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/render.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | &self.completion.db [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `self.completion.db` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/render.rs:154:55 [INFO] [stdout] | [INFO] [stdout] 154 | if let Some(score) = compute_score(&self.ctx, &ty, &name.to_string()) { [INFO] [stdout] | ^^^ help: change this to: `ty` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/render.rs:344:60 [INFO] [stdout] | [INFO] [stdout] 344 | let score = compute_score_from_active(&derefed_active, &active_name, &ty, &name)?; [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `active_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/render.rs:344:74 [INFO] [stdout] | [INFO] [stdout] 344 | let score = compute_score_from_active(&derefed_active, &active_name, &ty, &name)?; [INFO] [stdout] | ^^^ help: change this to: `ty` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/render.rs:344:79 [INFO] [stdout] | [INFO] [stdout] 344 | let score = compute_score_from_active(&derefed_active, &active_name, &ty, &name)?; [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/render.rs:378:25 [INFO] [stdout] | [INFO] [stdout] 378 | None => "[]".into(), [INFO] [stdout] | ^^^^^^^^^^^ help: consider removing `.into()`: `"[]"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/completions/attribute.rs:191:14 [INFO] [stdout] | [INFO] [stdout] 191 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/completions/dot.rs:16:51 [INFO] [stdout] | [INFO] [stdout] 16 | let receiver_ty = match ctx.sema.type_of_expr(&dot_receiver) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `dot_receiver` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/completions/dot.rs:32:16 [INFO] [stdout] | [INFO] [stdout] 32 | if ctx.scope.module().map_or(false, |m| !field.is_visible_from(ctx.db, m)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 32 - if ctx.scope.module().map_or(false, |m| !field.is_visible_from(ctx.db, m)) { [INFO] [stdout] 32 + if ctx.scope.module().is_some_and(|m| !field.is_visible_from(ctx.db, m)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/completions/dot.rs:52:20 [INFO] [stdout] | [INFO] [stdout] 52 | && ctx.scope.module().map_or(true, |m| func.is_visible_from(ctx.db, m)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 52 - && ctx.scope.module().map_or(true, |m| func.is_visible_from(ctx.db, m)) [INFO] [stdout] 52 + && ctx.scope.module().is_none_or(|m| func.is_visible_from(ctx.db, m)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Struct` which implements the `Copy` trait [INFO] [stdout] --> src/completions/pattern.rs:26:45 [INFO] [stdout] | [INFO] [stdout] 26 | acc.add_struct_pat(ctx, strukt.clone(), Some(name.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*strukt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Variant` which implements the `Copy` trait [INFO] [stdout] --> src/completions/pattern.rs:30:46 [INFO] [stdout] | [INFO] [stdout] 30 | acc.add_variant_pat(ctx, variant.clone(), Some(name.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*variant` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/completions/qualified_path.rs:80:24 [INFO] [stdout] | [INFO] [stdout] 80 | if context_module.map_or(false, |m| !item.is_visible_from(ctx.db, m)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 80 - if context_module.map_or(false, |m| !item.is_visible_from(ctx.db, m)) { [INFO] [stdout] 80 + if context_module.is_some_and(|m| !item.is_visible_from(ctx.db, m)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/completions/qualified_path.rs:95:24 [INFO] [stdout] | [INFO] [stdout] 95 | if context_module.map_or(false, |m| !item.is_visible_from(ctx.db, m)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 95 - if context_module.map_or(false, |m| !item.is_visible_from(ctx.db, m)) { [INFO] [stdout] 95 + if context_module.is_some_and(|m| !item.is_visible_from(ctx.db, m)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/completions/qualified_path.rs:109:20 [INFO] [stdout] | [INFO] [stdout] 109 | if context_module.map_or(false, |m| !item.is_visible_from(ctx.db, m)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 109 - if context_module.map_or(false, |m| !item.is_visible_from(ctx.db, m)) { [INFO] [stdout] 109 + if context_module.is_some_and(|m| !item.is_visible_from(ctx.db, m)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/completions/qualified_path.rs:138:24 [INFO] [stdout] | [INFO] [stdout] 138 | if context_module.map_or(false, |m| !item.is_visible_from(ctx.db, m)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 138 - if context_module.map_or(false, |m| !item.is_visible_from(ctx.db, m)) { [INFO] [stdout] 138 + if context_module.is_some_and(|m| !item.is_visible_from(ctx.db, m)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/completions/postfix/format_like.rs:54:39 [INFO] [stdout] | [INFO] [stdout] 54 | postfix_snippet(ctx, cap, &dot_receiver, label, macro_name, &snippet).add_to(acc); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `dot_receiver` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/completions/postfix/format_like.rs:92:20 [INFO] [stdout] | [INFO] [stdout] 92 | input: input.into(), [INFO] [stdout] | ^^^^^^^^^^^^ help: consider removing `.into()`: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `into_*` usually take `self` by value [INFO] [stdout] --> src/completions/postfix/format_like.rs:202:35 [INFO] [stdout] | [INFO] [stdout] 202 | pub(crate) fn into_suggestion(&self, macro_name: &str) -> String { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/completions/postfix/format_like.rs:284:48 [INFO] [stdout] | [INFO] [stdout] 284 | assert_eq!(&parser.into_suggestion(*kind), output); [INFO] [stdout] | ^^^^^ help: try: `kind` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/completions/postfix.rs:33:51 [INFO] [stdout] | [INFO] [stdout] 33 | let receiver_ty = match ctx.sema.type_of_expr(&dot_receiver) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `dot_receiver` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/completions/postfix.rs:52:21 [INFO] [stdout] | [INFO] [stdout] 52 | &dot_receiver, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `dot_receiver` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/completions/postfix.rs:62:21 [INFO] [stdout] | [INFO] [stdout] 62 | &dot_receiver, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `dot_receiver` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/completions/postfix.rs:73:21 [INFO] [stdout] | [INFO] [stdout] 73 | &dot_receiver, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `dot_receiver` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/completions/postfix.rs:83:21 [INFO] [stdout] | [INFO] [stdout] 83 | &dot_receiver, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `dot_receiver` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/completions/postfix.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 95 | &dot_receiver, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `dot_receiver` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/completions/postfix.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 104 | &dot_receiver, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `dot_receiver` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/completions/postfix.rs:110:35 [INFO] [stdout] | [INFO] [stdout] 110 | postfix_snippet(ctx, cap, &dot_receiver, "not", "!expr", &format!("!{}", receiver_text)) [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `dot_receiver` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/completions/postfix.rs:114:31 [INFO] [stdout] | [INFO] [stdout] 114 | postfix_snippet(ctx, cap, &dot_receiver, "ref", "&expr", &format!("&{}", receiver_text)) [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `dot_receiver` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/completions/postfix.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 119 | &dot_receiver, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `dot_receiver` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/completions.rs:43:1 [INFO] [stdout] | [INFO] [stdout] 43 | impl Into> for Completions { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 43 ~ impl From for Vec { [INFO] [stdout] 44 ~ fn from(val: Completions) -> Self { [INFO] [stdout] 45 ~ val.buf [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `item::CompletionItem` [INFO] [stdout] --> src/completions.rs:59:23 [INFO] [stdout] | [INFO] [stdout] 59 | self.buf.push(item.into()) [INFO] [stdout] | ^^^^^^^^^^^ help: consider removing `.into()`: `item` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 32.68s [INFO] running `Command { std: "docker" "inspect" "bc790b0aa8829b5979832472d27ad14fcc115861c3aaa6d9aacf0f29c09a51c8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bc790b0aa8829b5979832472d27ad14fcc115861c3aaa6d9aacf0f29c09a51c8", kill_on_drop: false }` [INFO] [stdout] bc790b0aa8829b5979832472d27ad14fcc115861c3aaa6d9aacf0f29c09a51c8