[INFO] fetching crate r2t 0.4.0... [INFO] linting r2t-0.4.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate r2t 0.4.0 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate r2t 0.4.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate r2t 0.4.0 [INFO] tweaked toml for crates.io crate r2t 0.4.0 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate r2t 0.4.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate r2t 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded lcov2cobertura v1.0.6 [INFO] [stderr] Downloaded ignore v0.4.24 [INFO] [stderr] Downloaded opener v0.8.3 [INFO] [stderr] Downloaded cargo-config2 v0.1.39 [INFO] [stderr] Downloaded cargo-llvm-cov v0.6.21 [INFO] [stderr] Downloaded ptree v0.5.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a5ccf30a1e64fd3280deaeac9ef4c1e8d2c2f8bd69ea97fa6fb420f995f5d839 [INFO] running `Command { std: "docker" "start" "-a" "a5ccf30a1e64fd3280deaeac9ef4c1e8d2c2f8bd69ea97fa6fb420f995f5d839", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a5ccf30a1e64fd3280deaeac9ef4c1e8d2c2f8bd69ea97fa6fb420f995f5d839", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a5ccf30a1e64fd3280deaeac9ef4c1e8d2c2f8bd69ea97fa6fb420f995f5d839", kill_on_drop: false }` [INFO] [stdout] a5ccf30a1e64fd3280deaeac9ef4c1e8d2c2f8bd69ea97fa6fb420f995f5d839 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a6d4eee0dea7671dd2970f2e8b6c11331024dcf9e125305c1864000b37f0d379 [INFO] running `Command { std: "docker" "start" "-a" "a6d4eee0dea7671dd2970f2e8b6c11331024dcf9e125305c1864000b37f0d379", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.20 [INFO] [stderr] Compiling quote v1.0.41 [INFO] [stderr] Compiling libc v0.2.177 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking winnow v0.7.13 [INFO] [stderr] Compiling memchr v2.7.6 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Checking rustix v1.1.2 [INFO] [stderr] Checking pest v2.8.3 [INFO] [stderr] Checking predicates-core v1.0.9 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking float-cmp v0.10.0 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking toml_datetime v0.7.3 [INFO] [stderr] Checking serde_spanned v1.0.3 [INFO] [stderr] Compiling proc-macro2 v1.0.103 [INFO] [stderr] Compiling fs-err v3.1.3 [INFO] [stderr] Compiling camino v1.2.1 [INFO] [stderr] Compiling doc-comment v0.3.4 [INFO] [stderr] Compiling mockall_derive v0.13.1 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking pathdiff v0.2.3 [INFO] [stderr] Checking uuid v1.18.1 [INFO] [stderr] Checking clap_builder v4.5.50 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking predicates-tree v1.0.12 [INFO] [stderr] Checking directories v5.0.1 [INFO] [stderr] Checking tint v1.0.1 [INFO] [stderr] Compiling syn v2.0.108 [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking filetime v0.2.26 [INFO] [stderr] Checking shared_child v1.1.1 [INFO] [stderr] Checking os_pipe v1.2.3 [INFO] [stderr] Checking cfb v0.7.3 [INFO] [stderr] Checking quick-xml v0.37.5 [INFO] [stderr] Checking shared_thread v0.2.0 [INFO] [stderr] Compiling assert_cmd v2.0.17 [INFO] [stderr] Checking rustc-demangle v0.1.26 [INFO] [stderr] Checking duct v1.1.0 [INFO] [stderr] Checking directories v6.0.0 [INFO] [stderr] Checking toml_parser v1.0.4 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking hashlink v0.8.4 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking wait-timeout v0.2.1 [INFO] [stderr] Checking infer v0.19.0 [INFO] [stderr] Checking fragile v2.0.1 [INFO] [stderr] Checking shell-escape v0.1.5 [INFO] [stderr] Checking yaml-rust2 v0.8.1 [INFO] [stderr] Checking toml v0.9.8 [INFO] [stderr] Compiling getrandom v0.2.16 [INFO] [stderr] Checking ruzstd v0.8.1 [INFO] [stderr] Checking downcast v0.11.0 [INFO] [stderr] Checking crossbeam-deque v0.8.6 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Checking const-random v0.1.18 [INFO] [stderr] Checking dlv-list v0.5.2 [INFO] [stderr] Checking xattr v1.6.1 [INFO] [stderr] Checking tempfile v3.23.0 [INFO] [stderr] Checking tar v0.4.44 [INFO] [stderr] Compiling pest_meta v2.8.3 [INFO] [stderr] Checking ordered-multimap v0.7.3 [INFO] [stderr] Checking rust-ini v0.20.0 [INFO] [stderr] Checking bstr v1.12.1 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking predicates v3.1.3 [INFO] [stderr] Checking lcov2cobertura v1.0.6 [INFO] [stderr] Compiling pest_generator v2.8.3 [INFO] [stderr] Checking globset v0.4.18 [INFO] [stderr] Checking opener v0.8.3 [INFO] [stderr] Checking ignore v0.4.24 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Compiling pest_derive v2.8.3 [INFO] [stderr] Checking clap v4.5.50 [INFO] [stderr] Checking mockall v0.13.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking ron v0.8.1 [INFO] [stderr] Checking json5 v0.4.1 [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking cargo-config2 v0.1.39 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking cargo-llvm-cov v0.6.21 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking config v0.14.1 [INFO] [stderr] Checking ptree v0.5.2 [INFO] [stderr] Checking r2t v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/processor.rs:50:22 [INFO] [stdout] | [INFO] [stdout] 50 | let is_dir = entry.file_type().map_or(false, |ft| ft.is_dir()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 50 - let is_dir = entry.file_type().map_or(false, |ft| ft.is_dir()); [INFO] [stdout] 50 + let is_dir = entry.file_type().is_some_and(|ft| ft.is_dir()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/processor.rs:50:22 [INFO] [stdout] | [INFO] [stdout] 50 | let is_dir = entry.file_type().map_or(false, |ft| ft.is_dir()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 50 - let is_dir = entry.file_type().map_or(false, |ft| ft.is_dir()); [INFO] [stdout] 50 + let is_dir = entry.file_type().is_some_and(|ft| ft.is_dir()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/processor.rs:211:10 [INFO] [stdout] | [INFO] [stdout] 211 | ) -> Result<(HashMap>, Vec)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/processor.rs:211:10 [INFO] [stdout] | [INFO] [stdout] 211 | ) -> Result<(HashMap>, Vec)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/stripper.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 12 | if !path.extension().is_some_and(|ext| ext == "rs") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `path.extension().is_none_or(|ext| ext != "rs")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/stripper.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | / if trimmed == "#[cfg(test)]" { [INFO] [stdout] 75 | | if let Some(next) = next_line { [INFO] [stdout] 76 | | return next.trim().starts_with("mod ") && next.contains('{'); [INFO] [stdout] 77 | | } [INFO] [stdout] 78 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 74 ~ if trimmed == "#[cfg(test)]" [INFO] [stdout] 75 ~ && let Some(next) = next_line { [INFO] [stdout] 76 | return next.trim().starts_with("mod ") && next.contains('{'); [INFO] [stdout] 77 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/stripper.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | next_line.map(|s| *s).unwrap_or("") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `next_line.copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/stripper.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 12 | if !path.extension().is_some_and(|ext| ext == "rs") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `path.extension().is_none_or(|ext| ext != "rs")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/stripper.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | / if trimmed == "#[cfg(test)]" { [INFO] [stdout] 75 | | if let Some(next) = next_line { [INFO] [stdout] 76 | | return next.trim().starts_with("mod ") && next.contains('{'); [INFO] [stdout] 77 | | } [INFO] [stdout] 78 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 74 ~ if trimmed == "#[cfg(test)]" [INFO] [stdout] 75 ~ && let Some(next) = next_line { [INFO] [stdout] 76 | return next.trim().starts_with("mod ") && next.contains('{'); [INFO] [stdout] 77 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/stripper.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | next_line.map(|s| *s).unwrap_or("") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `next_line.copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 27.00s [INFO] running `Command { std: "docker" "inspect" "a6d4eee0dea7671dd2970f2e8b6c11331024dcf9e125305c1864000b37f0d379", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a6d4eee0dea7671dd2970f2e8b6c11331024dcf9e125305c1864000b37f0d379", kill_on_drop: false }` [INFO] [stdout] a6d4eee0dea7671dd2970f2e8b6c11331024dcf9e125305c1864000b37f0d379