[INFO] fetching crate quakeml 0.1.8... [INFO] linting quakeml-0.1.8 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate quakeml 0.1.8 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate quakeml 0.1.8 [INFO] finished tweaking crates.io crate quakeml 0.1.8 [INFO] tweaked toml for crates.io crate quakeml 0.1.8 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate quakeml 0.1.8 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate quakeml 0.1.8 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded quote v1.0.10 [INFO] [stderr] Downloaded tokio-macros v1.6.0 [INFO] [stderr] Downloaded parking_lot_core v0.8.5 [INFO] [stderr] Downloaded pin-project-lite v0.2.7 [INFO] [stderr] Downloaded futures-task v0.3.18 [INFO] [stderr] Downloaded tower-service v0.3.1 [INFO] [stderr] Downloaded rand_hc v0.3.1 [INFO] [stderr] Downloaded hyper-tls v0.5.0 [INFO] [stderr] Downloaded futures-sink v0.3.18 [INFO] [stderr] Downloaded core-foundation v0.9.2 [INFO] [stderr] Downloaded futures-core v0.3.18 [INFO] [stderr] Downloaded env_logger v0.9.0 [INFO] [stderr] Downloaded httparse v1.5.1 [INFO] [stderr] Downloaded indexmap v1.7.0 [INFO] [stderr] Downloaded rand v0.8.4 [INFO] [stderr] Downloaded unicode-segmentation v1.8.0 [INFO] [stderr] Downloaded http v0.2.5 [INFO] [stderr] Downloaded quick-xml v0.21.0 [INFO] [stderr] Downloaded h2 v0.3.9 [INFO] [stderr] Downloaded futures-util v0.3.18 [INFO] [stderr] Downloaded hyper v0.14.16 [INFO] [stderr] Downloaded wasm-bindgen v0.2.78 [INFO] [stderr] Downloaded reqwest v0.11.7 [INFO] [stderr] Downloaded syn v1.0.82 [INFO] [stderr] Downloaded serde_json v1.0.73 [INFO] [stderr] Downloaded ntapi v0.3.6 [INFO] [stderr] Downloaded js-sys v0.3.55 [INFO] [stderr] Downloaded bumpalo v3.8.0 [INFO] [stderr] Downloaded serde_derive v1.0.130 [INFO] [stderr] Downloaded serde v1.0.130 [INFO] [stderr] Downloaded structopt v0.3.25 [INFO] [stderr] Downloaded tracing v0.1.29 [INFO] [stderr] Downloaded security-framework v2.4.2 [INFO] [stderr] Downloaded socket2 v0.4.2 [INFO] [stderr] Downloaded tracing-core v0.1.21 [INFO] [stderr] Downloaded tokio v1.14.0 [INFO] [stderr] Downloaded futures-channel v0.3.18 [INFO] [stderr] Downloaded libc v0.2.109 [INFO] [stderr] Downloaded ipnet v2.3.1 [INFO] [stderr] Downloaded ppv-lite86 v0.2.15 [INFO] [stderr] Downloaded wasm-bindgen-backend v0.2.78 [INFO] [stderr] Downloaded winreg v0.7.0 [INFO] [stderr] Downloaded once_cell v1.8.0 [INFO] [stderr] Downloaded lock_api v0.4.5 [INFO] [stderr] Downloaded smallvec v1.7.0 [INFO] [stderr] Downloaded http-body v0.4.4 [INFO] [stderr] Downloaded getrandom v0.2.3 [INFO] [stderr] Downloaded wasm-bindgen-futures v0.4.28 [INFO] [stderr] Downloaded web-sys v0.3.55 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.78 [INFO] [stderr] Downloaded itoa v0.4.8 [INFO] [stderr] Downloaded serde_urlencoded v0.7.0 [INFO] [stderr] Downloaded security-framework-sys v2.4.2 [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.78 [INFO] [stderr] Downloaded proc-macro2 v1.0.33 [INFO] [stderr] Downloaded xml-rs v0.8.4 [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.78 [INFO] [stderr] Downloaded encoding_rs v0.8.30 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6bb15b81fe4fcc667a049c4ce650df368a3028592bc06be626cf87c0473b7a7b [INFO] running `Command { std: "docker" "start" "-a" "6bb15b81fe4fcc667a049c4ce650df368a3028592bc06be626cf87c0473b7a7b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6bb15b81fe4fcc667a049c4ce650df368a3028592bc06be626cf87c0473b7a7b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6bb15b81fe4fcc667a049c4ce650df368a3028592bc06be626cf87c0473b7a7b", kill_on_drop: false }` [INFO] [stdout] 6bb15b81fe4fcc667a049c4ce650df368a3028592bc06be626cf87c0473b7a7b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fcc47ff0ac7c802dd7a2fe5858de8f5bd449b312939070cef9f3c8ce91fceadf [INFO] running `Command { std: "docker" "start" "-a" "fcc47ff0ac7c802dd7a2fe5858de8f5bd449b312939070cef9f3c8ce91fceadf", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.109 [INFO] [stderr] Compiling proc-macro2 v1.0.33 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.82 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Checking pin-project-lite v0.2.7 [INFO] [stderr] Compiling pkg-config v0.3.24 [INFO] [stderr] Compiling cc v1.0.72 [INFO] [stderr] Compiling parking_lot_core v0.8.5 [INFO] [stderr] Compiling futures-core v0.3.18 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking once_cell v1.8.0 [INFO] [stderr] Checking smallvec v1.7.0 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Compiling tokio v1.14.0 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling futures-task v0.3.18 [INFO] [stderr] Checking lock_api v0.4.5 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling serde_derive v1.0.130 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Compiling openssl v0.10.38 [INFO] [stderr] Compiling futures-util v0.3.18 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking tracing-core v0.1.21 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling native-tls v0.2.8 [INFO] [stderr] Compiling httparse v1.5.1 [INFO] [stderr] Checking futures-sink v0.3.18 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Checking http v0.2.5 [INFO] [stderr] Compiling futures-channel v0.3.18 [INFO] [stderr] Checking tinyvec v1.5.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking slab v0.4.5 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking tracing v0.1.29 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking mio v0.7.14 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking openssl-probe v0.1.4 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking socket2 v0.4.2 [INFO] [stderr] Compiling unicode-segmentation v1.8.0 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Compiling openssl-sys v0.9.72 [INFO] [stderr] Checking tower-service v0.3.1 [INFO] [stderr] Compiling encoding_rs v0.8.30 [INFO] [stderr] Checking unicode-bidi v0.3.7 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking ipnet v2.3.1 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking mime v0.3.16 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking xml-rs v0.8.4 [INFO] [stderr] Checking num-integer v0.1.44 [INFO] [stderr] Checking http-body v0.4.4 [INFO] [stderr] Checking xmltree v0.10.3 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Compiling tokio-macros v1.6.0 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Checking structopt v0.3.25 [INFO] [stderr] Checking tokio-util v0.6.9 [INFO] [stderr] Checking tokio-native-tls v0.3.0 [INFO] [stderr] Checking h2 v0.3.9 [INFO] [stderr] Checking serde_urlencoded v0.7.0 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking quick-xml v0.21.0 [INFO] [stderr] Checking hyper v0.14.16 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.7 [INFO] [stderr] Checking quakeml v0.1.8 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `preferred_origin` is never used [INFO] [stdout] --> src/quakeml.rs:130:8 [INFO] [stdout] | [INFO] [stdout] 126 | impl Event { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 130 | fn preferred_origin(&self) -> Option<&Origin> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/quakeml.rs:132:13 [INFO] [stdout] | [INFO] [stdout] 132 | return Some(&self.origin[0]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 132 - return Some(&self.origin[0]); [INFO] [stdout] 132 + Some(&self.origin[0]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/quakeml.rs:139:18 [INFO] [stdout] | [INFO] [stdout] 139 | Some(&preferred_origin) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `preferred_origin` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/quakeml.rs:147:12 [INFO] [stdout] | [INFO] [stdout] 147 | if self.magnitudes.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.magnitudes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/quakeml.rs:181:5 [INFO] [stdout] | [INFO] [stdout] 181 | / pub fn from_str(data: &String) -> Self { [INFO] [stdout] 182 | | let quakeml: QuakeML = from_str(data).expect("something went wrong"); [INFO] [stdout] 183 | | quakeml [INFO] [stdout] 184 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/quakeml.rs:181:27 [INFO] [stdout] | [INFO] [stdout] 181 | pub fn from_str(data: &String) -> Self { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 181 - pub fn from_str(data: &String) -> Self { [INFO] [stdout] 181 + pub fn from_str(data: &str) -> Self { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/quakeml.rs:199:9 [INFO] [stdout] | [INFO] [stdout] 199 | return min_mag_event.unwrap().preferred_magnitude(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 199 - return min_mag_event.unwrap().preferred_magnitude(); [INFO] [stdout] 199 + min_mag_event.unwrap().preferred_magnitude() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/quakeml.rs:192:25 [INFO] [stdout] | [INFO] [stdout] 192 | .filter(|a| !a.preferred_magnitude().is_none()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `a.preferred_magnitude().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/quakeml.rs:215:9 [INFO] [stdout] | [INFO] [stdout] 215 | return max_mag_event.unwrap().preferred_magnitude(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 215 - return max_mag_event.unwrap().preferred_magnitude(); [INFO] [stdout] 215 + max_mag_event.unwrap().preferred_magnitude() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/quakeml.rs:208:25 [INFO] [stdout] | [INFO] [stdout] 208 | .filter(|a| !a.preferred_magnitude().is_none()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `a.preferred_magnitude().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `preferred_origin` is never used [INFO] [stdout] --> src/quakeml.rs:130:8 [INFO] [stdout] | [INFO] [stdout] 126 | impl Event { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 130 | fn preferred_origin(&self) -> Option<&Origin> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/quakeml.rs:132:13 [INFO] [stdout] | [INFO] [stdout] 132 | return Some(&self.origin[0]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 132 - return Some(&self.origin[0]); [INFO] [stdout] 132 + Some(&self.origin[0]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/quakeml.rs:139:18 [INFO] [stdout] | [INFO] [stdout] 139 | Some(&preferred_origin) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `preferred_origin` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/quakeml.rs:147:12 [INFO] [stdout] | [INFO] [stdout] 147 | if self.magnitudes.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.magnitudes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/quakeml.rs:181:5 [INFO] [stdout] | [INFO] [stdout] 181 | / pub fn from_str(data: &String) -> Self { [INFO] [stdout] 182 | | let quakeml: QuakeML = from_str(data).expect("something went wrong"); [INFO] [stdout] 183 | | quakeml [INFO] [stdout] 184 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/quakeml.rs:181:27 [INFO] [stdout] | [INFO] [stdout] 181 | pub fn from_str(data: &String) -> Self { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 181 - pub fn from_str(data: &String) -> Self { [INFO] [stdout] 181 + pub fn from_str(data: &str) -> Self { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/quakeml.rs:199:9 [INFO] [stdout] | [INFO] [stdout] 199 | return min_mag_event.unwrap().preferred_magnitude(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 199 - return min_mag_event.unwrap().preferred_magnitude(); [INFO] [stdout] 199 + min_mag_event.unwrap().preferred_magnitude() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/quakeml.rs:192:25 [INFO] [stdout] | [INFO] [stdout] 192 | .filter(|a| !a.preferred_magnitude().is_none()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `a.preferred_magnitude().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/quakeml.rs:215:9 [INFO] [stdout] | [INFO] [stdout] 215 | return max_mag_event.unwrap().preferred_magnitude(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 215 - return max_mag_event.unwrap().preferred_magnitude(); [INFO] [stdout] 215 + max_mag_event.unwrap().preferred_magnitude() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/quakeml.rs:208:25 [INFO] [stdout] | [INFO] [stdout] 208 | .filter(|a| !a.preferred_magnitude().is_none()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `a.preferred_magnitude().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Level`, `debug`, `error`, `info`, and `log_enabled` [INFO] [stdout] --> src/main.rs:1:11 [INFO] [stdout] | [INFO] [stdout] 1 | use log::{debug, error, info, log_enabled, Level}; [INFO] [stdout] | ^^^^^ ^^^^^ ^^^^ ^^^^^^^^^^^ ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | use quakeml; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Duration` [INFO] [stdout] --> src/main.rs:3:17 [INFO] [stdout] | [INFO] [stdout] 3 | use std::time::{Duration, Instant}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Level`, `debug`, `error`, `info`, and `log_enabled` [INFO] [stdout] --> src/main.rs:1:11 [INFO] [stdout] | [INFO] [stdout] 1 | use log::{debug, error, info, log_enabled, Level}; [INFO] [stdout] | ^^^^^ ^^^^^ ^^^^ ^^^^^^^^^^^ ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | use quakeml; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Duration` [INFO] [stdout] --> src/main.rs:3:17 [INFO] [stdout] | [INFO] [stdout] 3 | use std::time::{Duration, Instant}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `debug` [INFO] [stdout] --> src/usgs.rs:8:11 [INFO] [stdout] | [INFO] [stdout] 8 | use log::{debug, info}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `debug` [INFO] [stdout] --> src/usgs.rs:8:11 [INFO] [stdout] | [INFO] [stdout] 8 | use log::{debug, info}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/usgs.rs:84:37 [INFO] [stdout] | [INFO] [stdout] 84 | let mut out_file = File::create(&out_filename).expect("failed to create file"); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `out_filename` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/usgs.rs:99:8 [INFO] [stdout] | [INFO] [stdout] 99 | if verbose == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `verbose` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/usgs.rs:84:37 [INFO] [stdout] | [INFO] [stdout] 84 | let mut out_file = File::create(&out_filename).expect("failed to create file"); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `out_filename` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/usgs.rs:99:8 [INFO] [stdout] | [INFO] [stdout] 99 | if verbose == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `verbose` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 27.39s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: quick-xml v0.21.0 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "fcc47ff0ac7c802dd7a2fe5858de8f5bd449b312939070cef9f3c8ce91fceadf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fcc47ff0ac7c802dd7a2fe5858de8f5bd449b312939070cef9f3c8ce91fceadf", kill_on_drop: false }` [INFO] [stdout] fcc47ff0ac7c802dd7a2fe5858de8f5bd449b312939070cef9f3c8ce91fceadf