[INFO] fetching crate qsc-cranelift-jit 0.104.0... [INFO] linting qsc-cranelift-jit-0.104.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate qsc-cranelift-jit 0.104.0 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate qsc-cranelift-jit 0.104.0 [INFO] finished tweaking crates.io crate qsc-cranelift-jit 0.104.0 [INFO] tweaked toml for crates.io crate qsc-cranelift-jit 0.104.0 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate qsc-cranelift-jit 0.104.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 56 packages to latest compatible versions [INFO] [stderr] Adding cranelift v0.101.4 (available: v0.129.1) [INFO] [stderr] Adding cranelift-codegen v0.101.4 (available: v0.129.1) [INFO] [stderr] Adding cranelift-control v0.101.4 (available: v0.129.1) [INFO] [stderr] Adding cranelift-entity v0.101.4 (available: v0.129.1) [INFO] [stderr] Adding cranelift-frontend v0.101.4 (available: v0.129.1) [INFO] [stderr] Adding cranelift-module v0.101.4 (available: v0.129.1) [INFO] [stderr] Adding cranelift-native v0.101.4 (available: v0.129.1) [INFO] [stderr] Adding memmap2 v0.2.3 (available: v0.9.10) [INFO] [stderr] Adding region v2.2.0 (available: v3.0.2) [INFO] [stderr] Adding target-lexicon v0.12.16 (available: v0.13.5) [INFO] [stderr] Adding wasmtime-jit-icache-coherence v14.0.4 (available: v34.0.2) [INFO] [stderr] Adding windows-sys v0.48.0 (available: v0.61.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded cranelift-native v0.101.4 [INFO] [stderr] Downloaded wasmtime-jit-icache-coherence v14.0.4 [INFO] [stderr] Downloaded cranelift-control v0.101.4 [INFO] [stderr] Downloaded memmap2 v0.2.3 [INFO] [stderr] Downloaded cranelift-codegen-shared v0.101.4 [INFO] [stderr] Downloaded cranelift-entity v0.101.4 [INFO] [stderr] Downloaded region v2.2.0 [INFO] [stderr] Downloaded cranelift-isle v0.101.4 [INFO] [stderr] Downloaded cranelift v0.101.4 [INFO] [stderr] Downloaded cranelift-bforest v0.101.4 [INFO] [stderr] Downloaded cranelift-frontend v0.101.4 [INFO] [stderr] Downloaded cranelift-module v0.101.4 [INFO] [stderr] Downloaded cranelift-codegen-meta v0.101.4 [INFO] [stderr] Downloaded cranelift-codegen v0.101.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5dcc9219d5ab929ae0eef63139e16b6bf2b0d46f1c1432b1466f3d23a9814dc3 [INFO] running `Command { std: "docker" "start" "-a" "5dcc9219d5ab929ae0eef63139e16b6bf2b0d46f1c1432b1466f3d23a9814dc3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5dcc9219d5ab929ae0eef63139e16b6bf2b0d46f1c1432b1466f3d23a9814dc3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5dcc9219d5ab929ae0eef63139e16b6bf2b0d46f1c1432b1466f3d23a9814dc3", kill_on_drop: false }` [INFO] [stdout] 5dcc9219d5ab929ae0eef63139e16b6bf2b0d46f1c1432b1466f3d23a9814dc3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 03c6f6edf8c7b053ac82e5d849216c121457ffc86e4766a0d398fade74a6b025 [INFO] running `Command { std: "docker" "start" "-a" "03c6f6edf8c7b053ac82e5d849216c121457ffc86e4766a0d398fade74a6b025", kill_on_drop: false }` [INFO] [stderr] Compiling cranelift-isle v0.101.4 [INFO] [stderr] Compiling cranelift-codegen-shared v0.101.4 [INFO] [stderr] Checking once_cell v1.21.4 [INFO] [stderr] Compiling target-lexicon v0.12.16 [INFO] [stderr] Checking cranelift-entity v0.101.4 [INFO] [stderr] Checking bumpalo v3.20.2 [INFO] [stderr] Checking cranelift-control v0.101.4 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Checking wasmtime-jit-icache-coherence v14.0.4 [INFO] [stderr] Checking region v2.2.0 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Compiling cranelift-codegen-meta v0.101.4 [INFO] [stderr] Checking hashbrown v0.13.2 [INFO] [stderr] Checking cranelift-bforest v0.101.4 [INFO] [stderr] Checking regalloc2 v0.9.3 [INFO] [stderr] Compiling cranelift-codegen v0.101.4 [INFO] [stderr] Checking cranelift-frontend v0.101.4 [INFO] [stderr] Checking cranelift-module v0.101.4 [INFO] [stderr] Checking cranelift-native v0.101.4 [INFO] [stderr] Checking qsc-cranelift-jit v0.104.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking cranelift v0.101.4 [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/backend.rs:32:21 [INFO] [stdout] | [INFO] [stdout] 32 | lookup_symbols: Vec Option<*const u8>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/backend.rs:46:10 [INFO] [stdout] | [INFO] [stdout] 46 | ) -> ModuleResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `cranelift_module::ModuleError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/backend.rs:59:10 [INFO] [stdout] | [INFO] [stdout] 59 | ) -> ModuleResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `cranelift_module::ModuleError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/backend.rs:144:27 [INFO] [stdout] | [INFO] [stdout] 144 | symbol_lookup_fn: Box Option<*const u8>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/backend.rs:177:21 [INFO] [stdout] | [INFO] [stdout] 177 | lookup_symbols: Vec Option<*const u8>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion has a constant value [INFO] [stdout] --> src/backend.rs:289:9 [INFO] [stdout] | [INFO] [stdout] 289 | / assert!( [INFO] [stdout] 290 | | cfg!(target_arch = "x86_64"), [INFO] [stdout] 291 | | "PLT is currently only supported on x86_64" [INFO] [stdout] 292 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: consider moving this into a const block: `const { assert!(..) }` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `0 as *const _` detected [INFO] [stdout] --> src/backend.rs:335:21 [INFO] [stdout] | [INFO] [stdout] 335 | 0 as *const u8 [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `std::ptr::null::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stdout] = note: `#[warn(clippy::zero_ptr)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/backend.rs:407:14 [INFO] [stdout] | [INFO] [stdout] 407 | !self.functions_to_finalize.iter().any(|x| *x == func_id), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.functions_to_finalize.contains(&func_id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] = note: `#[warn(clippy::manual_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/backend.rs:425:14 [INFO] [stdout] | [INFO] [stdout] 425 | !self.data_objects_to_finalize.iter().any(|x| *x == data_id), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.data_objects_to_finalize.contains(&data_id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/backend.rs:460:47 [INFO] [stdout] | [INFO] [stdout] 460 | pub fn finalize_definitions(&mut self) -> ModuleResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ the `Err`-variant is at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `cranelift_module::ModuleError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/backend.rs:563:73 [INFO] [stdout] | [INFO] [stdout] 563 | pub fn prepare_for_function_redefine(&mut self, func_id: FuncId) -> ModuleResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ the `Err`-variant is at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `cranelift_module::ModuleError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/backend.rs:671:12 [INFO] [stdout] | [INFO] [stdout] 671 | if !self.compiled_functions[id].is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.compiled_functions[id].is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/backend.rs:685:17 [INFO] [stdout] | [INFO] [stdout] 685 | / match gv { [INFO] [stdout] 686 | | ir::GlobalValueData::Symbol { colocated, .. } => *colocated = false, [INFO] [stdout] 687 | | _ => {} [INFO] [stdout] 688 | | } [INFO] [stdout] | |_________________^ help: try: `if let ir::GlobalValueData::Symbol { colocated, .. } = gv { *colocated = false }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/backend.rs:775:12 [INFO] [stdout] | [INFO] [stdout] 775 | if !self.compiled_functions[id].is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.compiled_functions[id].is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/backend.rs:839:12 [INFO] [stdout] | [INFO] [stdout] 839 | if !self.compiled_data_objects[id].is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.compiled_data_objects[id].is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/backend.rs:979:23 [INFO] [stdout] | [INFO] [stdout] 979 | fn use_bti(isa_flags: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 979 - fn use_bti(isa_flags: &Vec) -> bool { [INFO] [stdout] 979 + fn use_bti(isa_flags: &[settings::Value]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/backend.rs:980:5 [INFO] [stdout] | [INFO] [stdout] 980 | / isa_flags [INFO] [stdout] 981 | | .iter() [INFO] [stdout] 982 | | .find(|&f| f.name == "use_bti") [INFO] [stdout] 983 | | .map_or(false, |f| f.as_bool().unwrap_or(false)) [INFO] [stdout] | |________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 983 - .map_or(false, |f| f.as_bool().unwrap_or(false)) [INFO] [stdout] 983 + .is_some_and(|f| f.as_bool().unwrap_or(false)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BTI` contains a capitalized acronym [INFO] [stdout] --> src/memory.rs:121:5 [INFO] [stdout] | [INFO] [stdout] 121 | BTI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bti` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/memory.rs:155:12 [INFO] [stdout] | [INFO] [stdout] 155 | if self.position % align != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!self.position.is_multiple_of(align)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/memory.rs:157:27 [INFO] [stdout] | [INFO] [stdout] 157 | debug_assert!(self.position % align == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.position.is_multiple_of(align)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/memory.rs:177:61 [INFO] [stdout] | [INFO] [stdout] 177 | pub(crate) fn set_readable_and_executable(&mut self) -> ModuleResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ the `Err`-variant is at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `cranelift_module::ModuleError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/memory.rs:191:64 [INFO] [stdout] | [INFO] [stdout] 191 | let set_region_readable_and_executable = |ptr, len| -> ModuleResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ the `Err`-variant is at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `cranelift_module::ModuleError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/memory.rs:232:46 [INFO] [stdout] | [INFO] [stdout] 232 | pub(crate) fn set_readonly(&mut self) -> ModuleResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ the `Err`-variant is at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `cranelift_module::ModuleError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `std::mem::take` [INFO] [stdout] --> src/memory.rs:271:9 [INFO] [stdout] | [INFO] [stdout] 271 | mem::replace(&mut self.allocations, Vec::new()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::mem::take(&mut self.allocations)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] = note: `#[warn(clippy::mem_replace_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/backend.rs:32:21 [INFO] [stdout] | [INFO] [stdout] 32 | lookup_symbols: Vec Option<*const u8>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/backend.rs:46:10 [INFO] [stdout] | [INFO] [stdout] 46 | ) -> ModuleResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `cranelift_module::ModuleError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/backend.rs:59:10 [INFO] [stdout] | [INFO] [stdout] 59 | ) -> ModuleResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `cranelift_module::ModuleError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/backend.rs:144:27 [INFO] [stdout] | [INFO] [stdout] 144 | symbol_lookup_fn: Box Option<*const u8>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/backend.rs:177:21 [INFO] [stdout] | [INFO] [stdout] 177 | lookup_symbols: Vec Option<*const u8>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion has a constant value [INFO] [stdout] --> src/backend.rs:289:9 [INFO] [stdout] | [INFO] [stdout] 289 | / assert!( [INFO] [stdout] 290 | | cfg!(target_arch = "x86_64"), [INFO] [stdout] 291 | | "PLT is currently only supported on x86_64" [INFO] [stdout] 292 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: consider moving this into a const block: `const { assert!(..) }` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `0 as *const _` detected [INFO] [stdout] --> src/backend.rs:335:21 [INFO] [stdout] | [INFO] [stdout] 335 | 0 as *const u8 [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `std::ptr::null::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stdout] = note: `#[warn(clippy::zero_ptr)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/backend.rs:407:14 [INFO] [stdout] | [INFO] [stdout] 407 | !self.functions_to_finalize.iter().any(|x| *x == func_id), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.functions_to_finalize.contains(&func_id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] = note: `#[warn(clippy::manual_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/backend.rs:425:14 [INFO] [stdout] | [INFO] [stdout] 425 | !self.data_objects_to_finalize.iter().any(|x| *x == data_id), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.data_objects_to_finalize.contains(&data_id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/backend.rs:460:47 [INFO] [stdout] | [INFO] [stdout] 460 | pub fn finalize_definitions(&mut self) -> ModuleResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ the `Err`-variant is at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `cranelift_module::ModuleError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/backend.rs:563:73 [INFO] [stdout] | [INFO] [stdout] 563 | pub fn prepare_for_function_redefine(&mut self, func_id: FuncId) -> ModuleResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ the `Err`-variant is at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `cranelift_module::ModuleError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/backend.rs:671:12 [INFO] [stdout] | [INFO] [stdout] 671 | if !self.compiled_functions[id].is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.compiled_functions[id].is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/backend.rs:685:17 [INFO] [stdout] | [INFO] [stdout] 685 | / match gv { [INFO] [stdout] 686 | | ir::GlobalValueData::Symbol { colocated, .. } => *colocated = false, [INFO] [stdout] 687 | | _ => {} [INFO] [stdout] 688 | | } [INFO] [stdout] | |_________________^ help: try: `if let ir::GlobalValueData::Symbol { colocated, .. } = gv { *colocated = false }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/backend.rs:775:12 [INFO] [stdout] | [INFO] [stdout] 775 | if !self.compiled_functions[id].is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.compiled_functions[id].is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/backend.rs:839:12 [INFO] [stdout] | [INFO] [stdout] 839 | if !self.compiled_data_objects[id].is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.compiled_data_objects[id].is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/backend.rs:979:23 [INFO] [stdout] | [INFO] [stdout] 979 | fn use_bti(isa_flags: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 979 - fn use_bti(isa_flags: &Vec) -> bool { [INFO] [stdout] 979 + fn use_bti(isa_flags: &[settings::Value]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/backend.rs:980:5 [INFO] [stdout] | [INFO] [stdout] 980 | / isa_flags [INFO] [stdout] 981 | | .iter() [INFO] [stdout] 982 | | .find(|&f| f.name == "use_bti") [INFO] [stdout] 983 | | .map_or(false, |f| f.as_bool().unwrap_or(false)) [INFO] [stdout] | |________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 983 - .map_or(false, |f| f.as_bool().unwrap_or(false)) [INFO] [stdout] 983 + .is_some_and(|f| f.as_bool().unwrap_or(false)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BTI` contains a capitalized acronym [INFO] [stdout] --> src/memory.rs:121:5 [INFO] [stdout] | [INFO] [stdout] 121 | BTI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bti` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/memory.rs:155:12 [INFO] [stdout] | [INFO] [stdout] 155 | if self.position % align != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!self.position.is_multiple_of(align)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/memory.rs:157:27 [INFO] [stdout] | [INFO] [stdout] 157 | debug_assert!(self.position % align == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.position.is_multiple_of(align)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/memory.rs:177:61 [INFO] [stdout] | [INFO] [stdout] 177 | pub(crate) fn set_readable_and_executable(&mut self) -> ModuleResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ the `Err`-variant is at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `cranelift_module::ModuleError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/memory.rs:191:64 [INFO] [stdout] | [INFO] [stdout] 191 | let set_region_readable_and_executable = |ptr, len| -> ModuleResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ the `Err`-variant is at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `cranelift_module::ModuleError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/memory.rs:232:46 [INFO] [stdout] | [INFO] [stdout] 232 | pub(crate) fn set_readonly(&mut self) -> ModuleResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ the `Err`-variant is at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `cranelift_module::ModuleError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `std::mem::take` [INFO] [stdout] --> src/memory.rs:271:9 [INFO] [stdout] | [INFO] [stdout] 271 | mem::replace(&mut self.allocations, Vec::new()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::mem::take(&mut self.allocations)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] = note: `#[warn(clippy::mem_replace_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/basic.rs:200:64 [INFO] [stdout] | [INFO] [stdout] 200 | let local_callee = module.declare_func_in_func(callee, &mut bcx.func); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `bcx.func` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 21.85s [INFO] running `Command { std: "docker" "inspect" "03c6f6edf8c7b053ac82e5d849216c121457ffc86e4766a0d398fade74a6b025", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "03c6f6edf8c7b053ac82e5d849216c121457ffc86e4766a0d398fade74a6b025", kill_on_drop: false }` [INFO] [stdout] 03c6f6edf8c7b053ac82e5d849216c121457ffc86e4766a0d398fade74a6b025