[INFO] fetching crate qmassa 1.3.1... [INFO] linting qmassa-1.3.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate qmassa 1.3.1 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate qmassa 1.3.1 [INFO] finished tweaking crates.io crate qmassa 1.3.1 [INFO] tweaked toml for crates.io crate qmassa 1.3.1 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate qmassa 1.3.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate qmassa 1.3.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rstest_macros v0.23.0 [INFO] [stderr] Downloaded tui-scrollview v0.5.1 [INFO] [stderr] Downloaded udev v0.9.3 [INFO] [stderr] Downloaded rstest v0.23.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c9a69bf6bed3b599717f2bd34966cf70dca34e7b14f96cb19da19f82d3d4c9e5 [INFO] running `Command { std: "docker" "start" "-a" "c9a69bf6bed3b599717f2bd34966cf70dca34e7b14f96cb19da19f82d3d4c9e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c9a69bf6bed3b599717f2bd34966cf70dca34e7b14f96cb19da19f82d3d4c9e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c9a69bf6bed3b599717f2bd34966cf70dca34e7b14f96cb19da19f82d3d4c9e5", kill_on_drop: false }` [INFO] [stdout] c9a69bf6bed3b599717f2bd34966cf70dca34e7b14f96cb19da19f82d3d4c9e5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2b7471c421fc5cba8443788a90b56ddc78598c551ab340113aa72f1012cbcf0a [INFO] running `Command { std: "docker" "start" "-a" "2b7471c421fc5cba8443788a90b56ddc78598c551ab340113aa72f1012cbcf0a", kill_on_drop: false }` [INFO] [stderr] Compiling indexmap v2.11.4 [INFO] [stderr] Compiling rstest_macros v0.23.0 [INFO] [stderr] Checking signal-hook-registry v1.4.7 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling libudev-sys v0.1.4 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Compiling relative-path v1.9.3 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Checking jiff v0.2.16 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking signal-hook v0.3.18 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking signal-hook-mio v0.2.5 [INFO] [stderr] Compiling toml_edit v0.22.27 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking udev v0.9.3 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Checking clap v4.5.53 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Compiling instability v0.3.10 [INFO] [stderr] Checking ratatui v0.29.0 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stderr] Compiling proc-macro-crate v3.2.0 [INFO] [stderr] Checking rstest v0.23.0 [INFO] [stderr] Checking tui-scrollview v0.5.1 [INFO] [stderr] Checking qmassa v1.3.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | use env_logger; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:15:1 [INFO] [stdout] | [INFO] [stdout] 15 | use libc; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/perf_event.rs:14:1 [INFO] [stdout] | [INFO] [stdout] 14 | use libc; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/drm_devices.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use libc; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/drm_devices.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | use udev; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/drm_devices.rs:286:13 [INFO] [stdout] | [INFO] [stdout] 286 | devnode: devnode, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `devnode` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/drm_drivers/intel_power.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | use libc; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/drm_fdinfo.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use libc; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/proc_info.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | use libc; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/app_data.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | use serde_json; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | use env_logger; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:15:1 [INFO] [stdout] | [INFO] [stdout] 15 | use libc; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/perf_event.rs:14:1 [INFO] [stdout] | [INFO] [stdout] 14 | use libc; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/drm_devices.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use libc; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/drm_devices.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | use udev; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/drm_devices.rs:286:13 [INFO] [stdout] | [INFO] [stdout] 286 | devnode: devnode, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `devnode` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/drm_drivers/intel_power.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | use libc; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/drm_fdinfo.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use libc; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/proc_info.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | use libc; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/app_data.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | use serde_json; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:168:18 [INFO] [stdout] | [INFO] [stdout] 168 | unsafe { ::std::mem::transmute(self._bitfield_1.get(0usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] = note: `#[warn(clippy::useless_transmute)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:168:40 [INFO] [stdout] | [INFO] [stdout] 168 | unsafe { ::std::mem::transmute(self._bitfield_1.get(0usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(0usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:174:28 [INFO] [stdout] | [INFO] [stdout] 174 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:181:18 [INFO] [stdout] | [INFO] [stdout] 181 | unsafe { ::std::mem::transmute(self._bitfield_1.get(1usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:181:40 [INFO] [stdout] | [INFO] [stdout] 181 | unsafe { ::std::mem::transmute(self._bitfield_1.get(1usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(1usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:187:28 [INFO] [stdout] | [INFO] [stdout] 187 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:194:18 [INFO] [stdout] | [INFO] [stdout] 194 | unsafe { ::std::mem::transmute(self._bitfield_1.get(2usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:194:40 [INFO] [stdout] | [INFO] [stdout] 194 | unsafe { ::std::mem::transmute(self._bitfield_1.get(2usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(2usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:200:28 [INFO] [stdout] | [INFO] [stdout] 200 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:207:18 [INFO] [stdout] | [INFO] [stdout] 207 | unsafe { ::std::mem::transmute(self._bitfield_1.get(3usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:207:40 [INFO] [stdout] | [INFO] [stdout] 207 | unsafe { ::std::mem::transmute(self._bitfield_1.get(3usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(3usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:213:28 [INFO] [stdout] | [INFO] [stdout] 213 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:220:18 [INFO] [stdout] | [INFO] [stdout] 220 | unsafe { ::std::mem::transmute(self._bitfield_1.get(4usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:220:40 [INFO] [stdout] | [INFO] [stdout] 220 | unsafe { ::std::mem::transmute(self._bitfield_1.get(4usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(4usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:226:28 [INFO] [stdout] | [INFO] [stdout] 226 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:233:18 [INFO] [stdout] | [INFO] [stdout] 233 | unsafe { ::std::mem::transmute(self._bitfield_1.get(5usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:233:40 [INFO] [stdout] | [INFO] [stdout] 233 | unsafe { ::std::mem::transmute(self._bitfield_1.get(5usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(5usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:239:28 [INFO] [stdout] | [INFO] [stdout] 239 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:246:18 [INFO] [stdout] | [INFO] [stdout] 246 | unsafe { ::std::mem::transmute(self._bitfield_1.get(6usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:246:40 [INFO] [stdout] | [INFO] [stdout] 246 | unsafe { ::std::mem::transmute(self._bitfield_1.get(6usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(6usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:252:28 [INFO] [stdout] | [INFO] [stdout] 252 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:259:18 [INFO] [stdout] | [INFO] [stdout] 259 | unsafe { ::std::mem::transmute(self._bitfield_1.get(7usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:259:40 [INFO] [stdout] | [INFO] [stdout] 259 | unsafe { ::std::mem::transmute(self._bitfield_1.get(7usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(7usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:265:28 [INFO] [stdout] | [INFO] [stdout] 265 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:272:18 [INFO] [stdout] | [INFO] [stdout] 272 | unsafe { ::std::mem::transmute(self._bitfield_1.get(8usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:272:40 [INFO] [stdout] | [INFO] [stdout] 272 | unsafe { ::std::mem::transmute(self._bitfield_1.get(8usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(8usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:278:28 [INFO] [stdout] | [INFO] [stdout] 278 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:285:18 [INFO] [stdout] | [INFO] [stdout] 285 | unsafe { ::std::mem::transmute(self._bitfield_1.get(9usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:285:40 [INFO] [stdout] | [INFO] [stdout] 285 | unsafe { ::std::mem::transmute(self._bitfield_1.get(9usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(9usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:291:28 [INFO] [stdout] | [INFO] [stdout] 291 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:298:18 [INFO] [stdout] | [INFO] [stdout] 298 | unsafe { ::std::mem::transmute(self._bitfield_1.get(10usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:298:40 [INFO] [stdout] | [INFO] [stdout] 298 | unsafe { ::std::mem::transmute(self._bitfield_1.get(10usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(10usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:304:28 [INFO] [stdout] | [INFO] [stdout] 304 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:311:18 [INFO] [stdout] | [INFO] [stdout] 311 | unsafe { ::std::mem::transmute(self._bitfield_1.get(11usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:311:40 [INFO] [stdout] | [INFO] [stdout] 311 | unsafe { ::std::mem::transmute(self._bitfield_1.get(11usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(11usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:317:28 [INFO] [stdout] | [INFO] [stdout] 317 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:324:18 [INFO] [stdout] | [INFO] [stdout] 324 | unsafe { ::std::mem::transmute(self._bitfield_1.get(12usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:324:40 [INFO] [stdout] | [INFO] [stdout] 324 | unsafe { ::std::mem::transmute(self._bitfield_1.get(12usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(12usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:330:28 [INFO] [stdout] | [INFO] [stdout] 330 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:337:18 [INFO] [stdout] | [INFO] [stdout] 337 | unsafe { ::std::mem::transmute(self._bitfield_1.get(13usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:337:40 [INFO] [stdout] | [INFO] [stdout] 337 | unsafe { ::std::mem::transmute(self._bitfield_1.get(13usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(13usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:343:28 [INFO] [stdout] | [INFO] [stdout] 343 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:350:18 [INFO] [stdout] | [INFO] [stdout] 350 | unsafe { ::std::mem::transmute(self._bitfield_1.get(14usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:350:40 [INFO] [stdout] | [INFO] [stdout] 350 | unsafe { ::std::mem::transmute(self._bitfield_1.get(14usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(14usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:356:28 [INFO] [stdout] | [INFO] [stdout] 356 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:363:18 [INFO] [stdout] | [INFO] [stdout] 363 | unsafe { ::std::mem::transmute(self._bitfield_1.get(15usize, 2u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:363:40 [INFO] [stdout] | [INFO] [stdout] 363 | unsafe { ::std::mem::transmute(self._bitfield_1.get(15usize, 2u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(15usize, 2u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:369:28 [INFO] [stdout] | [INFO] [stdout] 369 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:376:18 [INFO] [stdout] | [INFO] [stdout] 376 | unsafe { ::std::mem::transmute(self._bitfield_1.get(17usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:376:40 [INFO] [stdout] | [INFO] [stdout] 376 | unsafe { ::std::mem::transmute(self._bitfield_1.get(17usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(17usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:382:28 [INFO] [stdout] | [INFO] [stdout] 382 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:389:18 [INFO] [stdout] | [INFO] [stdout] 389 | unsafe { ::std::mem::transmute(self._bitfield_1.get(18usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:389:40 [INFO] [stdout] | [INFO] [stdout] 389 | unsafe { ::std::mem::transmute(self._bitfield_1.get(18usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(18usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:395:28 [INFO] [stdout] | [INFO] [stdout] 395 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:402:18 [INFO] [stdout] | [INFO] [stdout] 402 | unsafe { ::std::mem::transmute(self._bitfield_1.get(19usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:402:40 [INFO] [stdout] | [INFO] [stdout] 402 | unsafe { ::std::mem::transmute(self._bitfield_1.get(19usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(19usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:408:28 [INFO] [stdout] | [INFO] [stdout] 408 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:415:18 [INFO] [stdout] | [INFO] [stdout] 415 | unsafe { ::std::mem::transmute(self._bitfield_1.get(20usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:415:40 [INFO] [stdout] | [INFO] [stdout] 415 | unsafe { ::std::mem::transmute(self._bitfield_1.get(20usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(20usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:421:28 [INFO] [stdout] | [INFO] [stdout] 421 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:428:18 [INFO] [stdout] | [INFO] [stdout] 428 | unsafe { ::std::mem::transmute(self._bitfield_1.get(21usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:428:40 [INFO] [stdout] | [INFO] [stdout] 428 | unsafe { ::std::mem::transmute(self._bitfield_1.get(21usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(21usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:434:28 [INFO] [stdout] | [INFO] [stdout] 434 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:441:18 [INFO] [stdout] | [INFO] [stdout] 441 | unsafe { ::std::mem::transmute(self._bitfield_1.get(22usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:441:40 [INFO] [stdout] | [INFO] [stdout] 441 | unsafe { ::std::mem::transmute(self._bitfield_1.get(22usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(22usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:447:28 [INFO] [stdout] | [INFO] [stdout] 447 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:454:18 [INFO] [stdout] | [INFO] [stdout] 454 | unsafe { ::std::mem::transmute(self._bitfield_1.get(23usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:454:40 [INFO] [stdout] | [INFO] [stdout] 454 | unsafe { ::std::mem::transmute(self._bitfield_1.get(23usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(23usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:460:28 [INFO] [stdout] | [INFO] [stdout] 460 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:467:18 [INFO] [stdout] | [INFO] [stdout] 467 | unsafe { ::std::mem::transmute(self._bitfield_1.get(24usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:467:40 [INFO] [stdout] | [INFO] [stdout] 467 | unsafe { ::std::mem::transmute(self._bitfield_1.get(24usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(24usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:473:28 [INFO] [stdout] | [INFO] [stdout] 473 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:480:18 [INFO] [stdout] | [INFO] [stdout] 480 | unsafe { ::std::mem::transmute(self._bitfield_1.get(25usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:480:40 [INFO] [stdout] | [INFO] [stdout] 480 | unsafe { ::std::mem::transmute(self._bitfield_1.get(25usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(25usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:486:28 [INFO] [stdout] | [INFO] [stdout] 486 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:493:18 [INFO] [stdout] | [INFO] [stdout] 493 | unsafe { ::std::mem::transmute(self._bitfield_1.get(26usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:493:40 [INFO] [stdout] | [INFO] [stdout] 493 | unsafe { ::std::mem::transmute(self._bitfield_1.get(26usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(26usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:499:28 [INFO] [stdout] | [INFO] [stdout] 499 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:506:18 [INFO] [stdout] | [INFO] [stdout] 506 | unsafe { ::std::mem::transmute(self._bitfield_1.get(27usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:506:40 [INFO] [stdout] | [INFO] [stdout] 506 | unsafe { ::std::mem::transmute(self._bitfield_1.get(27usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(27usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:512:28 [INFO] [stdout] | [INFO] [stdout] 512 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:519:18 [INFO] [stdout] | [INFO] [stdout] 519 | unsafe { ::std::mem::transmute(self._bitfield_1.get(28usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:519:40 [INFO] [stdout] | [INFO] [stdout] 519 | unsafe { ::std::mem::transmute(self._bitfield_1.get(28usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(28usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:525:28 [INFO] [stdout] | [INFO] [stdout] 525 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:532:18 [INFO] [stdout] | [INFO] [stdout] 532 | unsafe { ::std::mem::transmute(self._bitfield_1.get(29usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:532:40 [INFO] [stdout] | [INFO] [stdout] 532 | unsafe { ::std::mem::transmute(self._bitfield_1.get(29usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(29usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:538:28 [INFO] [stdout] | [INFO] [stdout] 538 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:545:18 [INFO] [stdout] | [INFO] [stdout] 545 | unsafe { ::std::mem::transmute(self._bitfield_1.get(30usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:545:40 [INFO] [stdout] | [INFO] [stdout] 545 | unsafe { ::std::mem::transmute(self._bitfield_1.get(30usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(30usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:551:28 [INFO] [stdout] | [INFO] [stdout] 551 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:558:18 [INFO] [stdout] | [INFO] [stdout] 558 | unsafe { ::std::mem::transmute(self._bitfield_1.get(31usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:558:40 [INFO] [stdout] | [INFO] [stdout] 558 | unsafe { ::std::mem::transmute(self._bitfield_1.get(31usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(31usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:564:28 [INFO] [stdout] | [INFO] [stdout] 564 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:571:18 [INFO] [stdout] | [INFO] [stdout] 571 | unsafe { ::std::mem::transmute(self._bitfield_1.get(32usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:571:40 [INFO] [stdout] | [INFO] [stdout] 571 | unsafe { ::std::mem::transmute(self._bitfield_1.get(32usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(32usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:577:28 [INFO] [stdout] | [INFO] [stdout] 577 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:584:18 [INFO] [stdout] | [INFO] [stdout] 584 | unsafe { ::std::mem::transmute(self._bitfield_1.get(33usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:584:40 [INFO] [stdout] | [INFO] [stdout] 584 | unsafe { ::std::mem::transmute(self._bitfield_1.get(33usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(33usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:590:28 [INFO] [stdout] | [INFO] [stdout] 590 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:597:18 [INFO] [stdout] | [INFO] [stdout] 597 | unsafe { ::std::mem::transmute(self._bitfield_1.get(34usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:597:40 [INFO] [stdout] | [INFO] [stdout] 597 | unsafe { ::std::mem::transmute(self._bitfield_1.get(34usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(34usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:603:28 [INFO] [stdout] | [INFO] [stdout] 603 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:610:18 [INFO] [stdout] | [INFO] [stdout] 610 | unsafe { ::std::mem::transmute(self._bitfield_1.get(35usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:610:40 [INFO] [stdout] | [INFO] [stdout] 610 | unsafe { ::std::mem::transmute(self._bitfield_1.get(35usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(35usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:616:28 [INFO] [stdout] | [INFO] [stdout] 616 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:623:18 [INFO] [stdout] | [INFO] [stdout] 623 | unsafe { ::std::mem::transmute(self._bitfield_1.get(36usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:623:40 [INFO] [stdout] | [INFO] [stdout] 623 | unsafe { ::std::mem::transmute(self._bitfield_1.get(36usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(36usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:629:28 [INFO] [stdout] | [INFO] [stdout] 629 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:636:18 [INFO] [stdout] | [INFO] [stdout] 636 | unsafe { ::std::mem::transmute(self._bitfield_1.get(37usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:636:40 [INFO] [stdout] | [INFO] [stdout] 636 | unsafe { ::std::mem::transmute(self._bitfield_1.get(37usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(37usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:642:28 [INFO] [stdout] | [INFO] [stdout] 642 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:649:18 [INFO] [stdout] | [INFO] [stdout] 649 | unsafe { ::std::mem::transmute(self._bitfield_1.get(38usize, 26u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:649:40 [INFO] [stdout] | [INFO] [stdout] 649 | unsafe { ::std::mem::transmute(self._bitfield_1.get(38usize, 26u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(38usize, 26u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:655:28 [INFO] [stdout] | [INFO] [stdout] 655 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (38/7) [INFO] [stdout] --> src/perf_event.rs:661:5 [INFO] [stdout] | [INFO] [stdout] 661 | / pub fn new_bitfield_1( [INFO] [stdout] 662 | | disabled: u64, [INFO] [stdout] 663 | | inherit: u64, [INFO] [stdout] 664 | | pinned: u64, [INFO] [stdout] ... | [INFO] [stdout] 699 | | __reserved_1: u64, [INFO] [stdout] 700 | | ) -> __BindgenBitfieldUnit<[u8; 8usize]> { [INFO] [stdout] | |____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:703:42 [INFO] [stdout] | [INFO] [stdout] 703 | let disabled: u64 = unsafe { ::std::mem::transmute(disabled) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:707:41 [INFO] [stdout] | [INFO] [stdout] 707 | let inherit: u64 = unsafe { ::std::mem::transmute(inherit) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:711:40 [INFO] [stdout] | [INFO] [stdout] 711 | let pinned: u64 = unsafe { ::std::mem::transmute(pinned) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:715:43 [INFO] [stdout] | [INFO] [stdout] 715 | let exclusive: u64 = unsafe { ::std::mem::transmute(exclusive) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:719:46 [INFO] [stdout] | [INFO] [stdout] 719 | let exclude_user: u64 = unsafe { ::std::mem::transmute(exclude_user) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:723:48 [INFO] [stdout] | [INFO] [stdout] 723 | let exclude_kernel: u64 = unsafe { ::std::mem::transmute(exclude_kernel) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:727:44 [INFO] [stdout] | [INFO] [stdout] 727 | let exclude_hv: u64 = unsafe { ::std::mem::transmute(exclude_hv) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:731:46 [INFO] [stdout] | [INFO] [stdout] 731 | let exclude_idle: u64 = unsafe { ::std::mem::transmute(exclude_idle) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:735:38 [INFO] [stdout] | [INFO] [stdout] 735 | let mmap: u64 = unsafe { ::std::mem::transmute(mmap) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:739:38 [INFO] [stdout] | [INFO] [stdout] 739 | let comm: u64 = unsafe { ::std::mem::transmute(comm) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:743:38 [INFO] [stdout] | [INFO] [stdout] 743 | let freq: u64 = unsafe { ::std::mem::transmute(freq) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:747:46 [INFO] [stdout] | [INFO] [stdout] 747 | let inherit_stat: u64 = unsafe { ::std::mem::transmute(inherit_stat) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:751:48 [INFO] [stdout] | [INFO] [stdout] 751 | let enable_on_exec: u64 = unsafe { ::std::mem::transmute(enable_on_exec) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:755:38 [INFO] [stdout] | [INFO] [stdout] 755 | let task: u64 = unsafe { ::std::mem::transmute(task) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:759:43 [INFO] [stdout] | [INFO] [stdout] 759 | let watermark: u64 = unsafe { ::std::mem::transmute(watermark) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:763:44 [INFO] [stdout] | [INFO] [stdout] 763 | let precise_ip: u64 = unsafe { ::std::mem::transmute(precise_ip) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:767:43 [INFO] [stdout] | [INFO] [stdout] 767 | let mmap_data: u64 = unsafe { ::std::mem::transmute(mmap_data) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:771:47 [INFO] [stdout] | [INFO] [stdout] 771 | let sample_id_all: u64 = unsafe { ::std::mem::transmute(sample_id_all) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:775:46 [INFO] [stdout] | [INFO] [stdout] 775 | let exclude_host: u64 = unsafe { ::std::mem::transmute(exclude_host) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:779:47 [INFO] [stdout] | [INFO] [stdout] 779 | let exclude_guest: u64 = unsafe { ::std::mem::transmute(exclude_guest) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:784:26 [INFO] [stdout] | [INFO] [stdout] 784 | unsafe { ::std::mem::transmute(exclude_callchain_kernel) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:789:26 [INFO] [stdout] | [INFO] [stdout] 789 | unsafe { ::std::mem::transmute(exclude_callchain_user) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:793:39 [INFO] [stdout] | [INFO] [stdout] 793 | let mmap2: u64 = unsafe { ::std::mem::transmute(mmap2) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:797:43 [INFO] [stdout] | [INFO] [stdout] 797 | let comm_exec: u64 = unsafe { ::std::mem::transmute(comm_exec) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:801:45 [INFO] [stdout] | [INFO] [stdout] 801 | let use_clockid: u64 = unsafe { ::std::mem::transmute(use_clockid) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:805:48 [INFO] [stdout] | [INFO] [stdout] 805 | let context_switch: u64 = unsafe { ::std::mem::transmute(context_switch) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:809:48 [INFO] [stdout] | [INFO] [stdout] 809 | let write_backward: u64 = unsafe { ::std::mem::transmute(write_backward) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:813:44 [INFO] [stdout] | [INFO] [stdout] 813 | let namespaces: u64 = unsafe { ::std::mem::transmute(namespaces) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:817:41 [INFO] [stdout] | [INFO] [stdout] 817 | let ksymbol: u64 = unsafe { ::std::mem::transmute(ksymbol) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:821:43 [INFO] [stdout] | [INFO] [stdout] 821 | let bpf_event: u64 = unsafe { ::std::mem::transmute(bpf_event) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:825:44 [INFO] [stdout] | [INFO] [stdout] 825 | let aux_output: u64 = unsafe { ::std::mem::transmute(aux_output) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:829:40 [INFO] [stdout] | [INFO] [stdout] 829 | let cgroup: u64 = unsafe { ::std::mem::transmute(cgroup) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:833:43 [INFO] [stdout] | [INFO] [stdout] 833 | let text_poke: u64 = unsafe { ::std::mem::transmute(text_poke) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:837:42 [INFO] [stdout] | [INFO] [stdout] 837 | let build_id: u64 = unsafe { ::std::mem::transmute(build_id) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:841:48 [INFO] [stdout] | [INFO] [stdout] 841 | let inherit_thread: u64 = unsafe { ::std::mem::transmute(inherit_thread) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:845:48 [INFO] [stdout] | [INFO] [stdout] 845 | let remove_on_exec: u64 = unsafe { ::std::mem::transmute(remove_on_exec) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:849:41 [INFO] [stdout] | [INFO] [stdout] 849 | let sigtrap: u64 = unsafe { ::std::mem::transmute(sigtrap) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:853:46 [INFO] [stdout] | [INFO] [stdout] 853 | let __reserved_1: u64 = unsafe { ::std::mem::transmute(__reserved_1) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/perf_event.rs:1055:19 [INFO] [stdout] | [INFO] [stdout] 1055 | .join(&format!("{}.scale", evt)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}.scale", evt)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/perf_event.rs:1067:19 [INFO] [stdout] | [INFO] [stdout] 1067 | .join(&format!("{}.unit", evt)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}.unit", evt)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/perf_event.rs:1095:16 [INFO] [stdout] | [INFO] [stdout] 1095 | if keys.iter().any(|&k| k == key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `keys.contains(&key)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] = note: `#[warn(clippy::manual_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::fs::ReadDir` [INFO] [stdout] --> src/hwmon.rs:117:26 [INFO] [stdout] | [INFO] [stdout] 117 | let hwmon_path = fs::read_dir(root_dir)? [INFO] [stdout] | __________________________^ [INFO] [stdout] 118 | | .into_iter() [INFO] [stdout] | |________________________^ help: consider removing `.into_iter()`: `fs::read_dir(root_dir)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `VFIO` contains a capitalized acronym [INFO] [stdout] --> src/drm_devices.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | VFIO, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Vfio` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/drm_devices.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | / match self { [INFO] [stdout] 40 | | DrmDeviceType::Discrete(_) => true, [INFO] [stdout] 41 | | _ => false [INFO] [stdout] 42 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 39 - match self { [INFO] [stdout] 40 - DrmDeviceType::Discrete(_) => true, [INFO] [stdout] 41 - _ => false [INFO] [stdout] 42 - } [INFO] [stdout] 39 + matches!(self, DrmDeviceType::Discrete(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/drm_devices.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | / match self { [INFO] [stdout] 48 | | DrmDeviceType::Integrated(_) => true, [INFO] [stdout] 49 | | _ => false [INFO] [stdout] 50 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 47 - match self { [INFO] [stdout] 48 - DrmDeviceType::Integrated(_) => true, [INFO] [stdout] 49 - _ => false [INFO] [stdout] 50 - } [INFO] [stdout] 47 + matches!(self, DrmDeviceType::Integrated(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/drm_devices.rs:53:22 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn to_string(&self) -> String [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `drm_devices::DrmDeviceType` [INFO] [stdout] --> src/drm_devices.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | / pub fn to_string(&self) -> String [INFO] [stdout] 54 | | { [INFO] [stdout] 55 | | let mut ret = String::new(); [INFO] [stdout] ... | [INFO] [stdout] 79 | | ret [INFO] [stdout] 80 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `drm_devices::DrmDeviceType` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] = note: `#[warn(clippy::inherent_to_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/drm_devices.rs:210:17 [INFO] [stdout] | [INFO] [stdout] 210 | format!("{}", &sensor.stype["temp".len()..]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `(&sensor.stype["temp".len()..]).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/drm_devices.rs:247:17 [INFO] [stdout] | [INFO] [stdout] 247 | format!("{}", &sensor.stype["fan".len()..]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `(&sensor.stype["fan".len()..]).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/drm_devices.rs:358:9 [INFO] [stdout] | [INFO] [stdout] 358 | / if !self.engs_utilization.is_empty() { [INFO] [stdout] 359 | | if self.engs_utilization.contains_key(eng) { [INFO] [stdout] 360 | | return self.engs_utilization[eng]; [INFO] [stdout] 361 | | } [INFO] [stdout] 362 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 358 ~ if !self.engs_utilization.is_empty() [INFO] [stdout] 359 ~ && self.engs_utilization.contains_key(eng) { [INFO] [stdout] 360 | return self.engs_utilization[eng]; [INFO] [stdout] 361 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/drm_devices.rs:372:20 [INFO] [stdout] | [INFO] [stdout] 372 | engs = self.engs_utilization.keys() [INFO] [stdout] | ____________________^ [INFO] [stdout] 373 | | .map(|nm| nm.clone()) [INFO] [stdout] | |_____________________________________^ help: consider calling the dedicated `cloned` method: `self.engs_utilization.keys().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/drm_devices.rs:384:39 [INFO] [stdout] | [INFO] [stdout] 384 | return Some(Rc::downgrade(&vref)); [INFO] [stdout] | ^^^^^ help: change this to: `vref` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/drm_devices.rs:534:31 [INFO] [stdout] | [INFO] [stdout] 534 | fn vendor_name(vendor_id: &String) -> String [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 534 ~ fn vendor_name(vendor_id: &str) -> String [INFO] [stdout] 535 | { [INFO] [stdout] ... [INFO] [stdout] 545 | [INFO] [stdout] 546 ~ vendor_id.to_owned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/drm_devices.rs:549:31 [INFO] [stdout] | [INFO] [stdout] 549 | fn device_name(vendor_id: &String, device_id: &String) -> String [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 549 - fn device_name(vendor_id: &String, device_id: &String) -> String [INFO] [stdout] 549 + fn device_name(vendor_id: &str, device_id: &String) -> String [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/drm_devices.rs:549:51 [INFO] [stdout] | [INFO] [stdout] 549 | fn device_name(vendor_id: &String, device_id: &String) -> String [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 549 ~ fn device_name(vendor_id: &String, device_id: &str) -> String [INFO] [stdout] 550 | { [INFO] [stdout] ... [INFO] [stdout] 561 | [INFO] [stdout] 562 ~ device_id.to_owned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/drm_devices.rs:601:38 [INFO] [stdout] | [INFO] [stdout] 601 | String::from(&rev_str[2..]) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/drm_devices.rs:600:32 [INFO] [stdout] | [INFO] [stdout] 600 | revision = if rev_str.starts_with("0x") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 600 ~ revision = if let Some() = rev_str.strip_prefix("0x") { [INFO] [stdout] 601 ~ String::from() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/drm_drivers/intel_common.rs:40:17 [INFO] [stdout] | [INFO] [stdout] 40 | self.opts = self.opts | iopt_mask; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.opts |= iopt_mask` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/drm_drivers/intel_common.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | self.opts = self.opts | other.opts; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.opts |= other.opts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/drm_drivers/intel_common.rs:66:31 [INFO] [stdout] | [INFO] [stdout] 66 | devslot = &opt["devslot=".len()..]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/drm_drivers/intel_common.rs:65:17 [INFO] [stdout] | [INFO] [stdout] 65 | if opt.starts_with("devslot=") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 65 ~ if let Some() = opt.strip_prefix("devslot=") { [INFO] [stdout] 66 ~ devslot = ; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/drm_drivers/intel_power.rs:131:10 [INFO] [stdout] | [INFO] [stdout] 131 | ) -> Option<( [INFO] [stdout] | __________^ [INFO] [stdout] 132 | | fn(&mut DGpuPowerIntel, hwmon: &Hwmon) -> Result, [INFO] [stdout] 133 | | SensorSet [INFO] [stdout] 134 | | )> [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/drm_drivers/intel_power.rs:214:9 [INFO] [stdout] | [INFO] [stdout] 214 | return Ok(Some(Box::new(pwr))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 214 - return Ok(Some(Box::new(pwr))); [INFO] [stdout] 214 + Ok(Some(Box::new(pwr))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> src/drm_drivers/intel_power.rs:262:9 [INFO] [stdout] | [INFO] [stdout] 262 | / if !self.sums.contains_key(&offset) { [INFO] [stdout] 263 | | self.sums.insert(offset, MsrSum { sum: 0, last: 0, }); [INFO] [stdout] 264 | | } [INFO] [stdout] | |_________^ help: try: `self.sums.entry(offset).or_insert(MsrSum { sum: 0, last: 0, });` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] = note: `#[warn(clippy::map_entry)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/drm_drivers/intel_power.rs:280:9 [INFO] [stdout] | [INFO] [stdout] 280 | / match self.read(offset) { [INFO] [stdout] 281 | | Err(_) => false, [INFO] [stdout] 282 | | _ => true [INFO] [stdout] 283 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 280 - match self.read(offset) { [INFO] [stdout] 281 - Err(_) => false, [INFO] [stdout] 282 - _ => true [INFO] [stdout] 283 - } [INFO] [stdout] 280 + !matches!(self.read(offset), Err(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/drm_drivers/intel_power.rs:280:9 [INFO] [stdout] | [INFO] [stdout] 280 | / match self.read(offset) { [INFO] [stdout] 281 | | Err(_) => false, [INFO] [stdout] 282 | | _ => true [INFO] [stdout] 283 | | } [INFO] [stdout] | |_________^ help: try: `self.read(offset).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:168:18 [INFO] [stdout] | [INFO] [stdout] 168 | unsafe { ::std::mem::transmute(self._bitfield_1.get(0usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] = note: `#[warn(clippy::useless_transmute)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:168:40 [INFO] [stdout] | [INFO] [stdout] 168 | unsafe { ::std::mem::transmute(self._bitfield_1.get(0usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(0usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:174:28 [INFO] [stdout] | [INFO] [stdout] 174 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:181:18 [INFO] [stdout] | [INFO] [stdout] 181 | unsafe { ::std::mem::transmute(self._bitfield_1.get(1usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:181:40 [INFO] [stdout] | [INFO] [stdout] 181 | unsafe { ::std::mem::transmute(self._bitfield_1.get(1usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(1usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:187:28 [INFO] [stdout] | [INFO] [stdout] 187 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:194:18 [INFO] [stdout] | [INFO] [stdout] 194 | unsafe { ::std::mem::transmute(self._bitfield_1.get(2usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:194:40 [INFO] [stdout] | [INFO] [stdout] 194 | unsafe { ::std::mem::transmute(self._bitfield_1.get(2usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(2usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:200:28 [INFO] [stdout] | [INFO] [stdout] 200 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:207:18 [INFO] [stdout] | [INFO] [stdout] 207 | unsafe { ::std::mem::transmute(self._bitfield_1.get(3usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:207:40 [INFO] [stdout] | [INFO] [stdout] 207 | unsafe { ::std::mem::transmute(self._bitfield_1.get(3usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(3usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:213:28 [INFO] [stdout] | [INFO] [stdout] 213 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:220:18 [INFO] [stdout] | [INFO] [stdout] 220 | unsafe { ::std::mem::transmute(self._bitfield_1.get(4usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:220:40 [INFO] [stdout] | [INFO] [stdout] 220 | unsafe { ::std::mem::transmute(self._bitfield_1.get(4usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(4usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/drm_drivers/intel_power.rs:439:5 [INFO] [stdout] | [INFO] [stdout] 439 | / pub fn new(mut use_msr: bool) -> Result>> [INFO] [stdout] 440 | | { [INFO] [stdout] 441 | | let mut pf_evt: Option = None; [INFO] [stdout] 442 | | let mut msr: Option = None; [INFO] [stdout] ... | [INFO] [stdout] 480 | | }))) [INFO] [stdout] 481 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:226:28 [INFO] [stdout] | [INFO] [stdout] 226 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:233:18 [INFO] [stdout] | [INFO] [stdout] 233 | unsafe { ::std::mem::transmute(self._bitfield_1.get(5usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:233:40 [INFO] [stdout] | [INFO] [stdout] 233 | unsafe { ::std::mem::transmute(self._bitfield_1.get(5usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(5usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:239:28 [INFO] [stdout] | [INFO] [stdout] 239 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:246:18 [INFO] [stdout] | [INFO] [stdout] 246 | unsafe { ::std::mem::transmute(self._bitfield_1.get(6usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:246:40 [INFO] [stdout] | [INFO] [stdout] 246 | unsafe { ::std::mem::transmute(self._bitfield_1.get(6usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(6usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:252:28 [INFO] [stdout] | [INFO] [stdout] 252 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:259:18 [INFO] [stdout] | [INFO] [stdout] 259 | unsafe { ::std::mem::transmute(self._bitfield_1.get(7usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:259:40 [INFO] [stdout] | [INFO] [stdout] 259 | unsafe { ::std::mem::transmute(self._bitfield_1.get(7usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(7usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:265:28 [INFO] [stdout] | [INFO] [stdout] 265 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:272:18 [INFO] [stdout] | [INFO] [stdout] 272 | unsafe { ::std::mem::transmute(self._bitfield_1.get(8usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:272:40 [INFO] [stdout] | [INFO] [stdout] 272 | unsafe { ::std::mem::transmute(self._bitfield_1.get(8usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(8usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:278:28 [INFO] [stdout] | [INFO] [stdout] 278 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:285:18 [INFO] [stdout] | [INFO] [stdout] 285 | unsafe { ::std::mem::transmute(self._bitfield_1.get(9usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:285:40 [INFO] [stdout] | [INFO] [stdout] 285 | unsafe { ::std::mem::transmute(self._bitfield_1.get(9usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(9usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:291:28 [INFO] [stdout] | [INFO] [stdout] 291 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:298:18 [INFO] [stdout] | [INFO] [stdout] 298 | unsafe { ::std::mem::transmute(self._bitfield_1.get(10usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:298:40 [INFO] [stdout] | [INFO] [stdout] 298 | unsafe { ::std::mem::transmute(self._bitfield_1.get(10usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(10usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:304:28 [INFO] [stdout] | [INFO] [stdout] 304 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:311:18 [INFO] [stdout] | [INFO] [stdout] 311 | unsafe { ::std::mem::transmute(self._bitfield_1.get(11usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:311:40 [INFO] [stdout] | [INFO] [stdout] 311 | unsafe { ::std::mem::transmute(self._bitfield_1.get(11usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(11usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:317:28 [INFO] [stdout] | [INFO] [stdout] 317 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:324:18 [INFO] [stdout] | [INFO] [stdout] 324 | unsafe { ::std::mem::transmute(self._bitfield_1.get(12usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:324:40 [INFO] [stdout] | [INFO] [stdout] 324 | unsafe { ::std::mem::transmute(self._bitfield_1.get(12usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(12usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:330:28 [INFO] [stdout] | [INFO] [stdout] 330 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:337:18 [INFO] [stdout] | [INFO] [stdout] 337 | unsafe { ::std::mem::transmute(self._bitfield_1.get(13usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:337:40 [INFO] [stdout] | [INFO] [stdout] 337 | unsafe { ::std::mem::transmute(self._bitfield_1.get(13usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(13usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/drm_drivers/xe.rs:133:50 [INFO] [stdout] | [INFO] [stdout] 133 | fn xe_sriov_pf_dev_from(pci_dev: &str, dev_path: &PathBuf) -> Result [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 133 - fn xe_sriov_pf_dev_from(pci_dev: &str, dev_path: &PathBuf) -> Result [INFO] [stdout] 133 + fn xe_sriov_pf_dev_from(pci_dev: &str, dev_path: &Path) -> Result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:343:28 [INFO] [stdout] | [INFO] [stdout] 343 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:350:18 [INFO] [stdout] | [INFO] [stdout] 350 | unsafe { ::std::mem::transmute(self._bitfield_1.get(14usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:350:40 [INFO] [stdout] | [INFO] [stdout] 350 | unsafe { ::std::mem::transmute(self._bitfield_1.get(14usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(14usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:356:28 [INFO] [stdout] | [INFO] [stdout] 356 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:363:18 [INFO] [stdout] | [INFO] [stdout] 363 | unsafe { ::std::mem::transmute(self._bitfield_1.get(15usize, 2u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:363:40 [INFO] [stdout] | [INFO] [stdout] 363 | unsafe { ::std::mem::transmute(self._bitfield_1.get(15usize, 2u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(15usize, 2u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:369:28 [INFO] [stdout] | [INFO] [stdout] 369 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:376:18 [INFO] [stdout] | [INFO] [stdout] 376 | unsafe { ::std::mem::transmute(self._bitfield_1.get(17usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:376:40 [INFO] [stdout] | [INFO] [stdout] 376 | unsafe { ::std::mem::transmute(self._bitfield_1.get(17usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(17usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/drm_drivers/xe.rs:163:46 [INFO] [stdout] | [INFO] [stdout] 163 | fn xe_sriov_fn_from(pci_dev: &str, dev_path: &PathBuf) -> Result [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 163 - fn xe_sriov_fn_from(pci_dev: &str, dev_path: &PathBuf) -> Result [INFO] [stdout] 163 + fn xe_sriov_fn_from(pci_dev: &str, dev_path: &Path) -> Result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:382:28 [INFO] [stdout] | [INFO] [stdout] 382 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:389:18 [INFO] [stdout] | [INFO] [stdout] 389 | unsafe { ::std::mem::transmute(self._bitfield_1.get(18usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:389:40 [INFO] [stdout] | [INFO] [stdout] 389 | unsafe { ::std::mem::transmute(self._bitfield_1.get(18usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(18usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:395:28 [INFO] [stdout] | [INFO] [stdout] 395 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:402:18 [INFO] [stdout] | [INFO] [stdout] 402 | unsafe { ::std::mem::transmute(self._bitfield_1.get(19usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:402:40 [INFO] [stdout] | [INFO] [stdout] 402 | unsafe { ::std::mem::transmute(self._bitfield_1.get(19usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(19usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:408:28 [INFO] [stdout] | [INFO] [stdout] 408 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:415:18 [INFO] [stdout] | [INFO] [stdout] 415 | unsafe { ::std::mem::transmute(self._bitfield_1.get(20usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:415:40 [INFO] [stdout] | [INFO] [stdout] 415 | unsafe { ::std::mem::transmute(self._bitfield_1.get(20usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(20usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:421:28 [INFO] [stdout] | [INFO] [stdout] 421 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:428:18 [INFO] [stdout] | [INFO] [stdout] 428 | unsafe { ::std::mem::transmute(self._bitfield_1.get(21usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:428:40 [INFO] [stdout] | [INFO] [stdout] 428 | unsafe { ::std::mem::transmute(self._bitfield_1.get(21usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(21usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:434:28 [INFO] [stdout] | [INFO] [stdout] 434 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:441:18 [INFO] [stdout] | [INFO] [stdout] 441 | unsafe { ::std::mem::transmute(self._bitfield_1.get(22usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:441:40 [INFO] [stdout] | [INFO] [stdout] 441 | unsafe { ::std::mem::transmute(self._bitfield_1.get(22usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(22usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:447:28 [INFO] [stdout] | [INFO] [stdout] 447 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:454:18 [INFO] [stdout] | [INFO] [stdout] 454 | unsafe { ::std::mem::transmute(self._bitfield_1.get(23usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:454:40 [INFO] [stdout] | [INFO] [stdout] 454 | unsafe { ::std::mem::transmute(self._bitfield_1.get(23usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(23usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:460:28 [INFO] [stdout] | [INFO] [stdout] 460 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:467:18 [INFO] [stdout] | [INFO] [stdout] 467 | unsafe { ::std::mem::transmute(self._bitfield_1.get(24usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:467:40 [INFO] [stdout] | [INFO] [stdout] 467 | unsafe { ::std::mem::transmute(self._bitfield_1.get(24usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(24usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:473:28 [INFO] [stdout] | [INFO] [stdout] 473 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:480:18 [INFO] [stdout] | [INFO] [stdout] 480 | unsafe { ::std::mem::transmute(self._bitfield_1.get(25usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:480:40 [INFO] [stdout] | [INFO] [stdout] 480 | unsafe { ::std::mem::transmute(self._bitfield_1.get(25usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(25usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:486:28 [INFO] [stdout] | [INFO] [stdout] 486 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:493:18 [INFO] [stdout] | [INFO] [stdout] 493 | unsafe { ::std::mem::transmute(self._bitfield_1.get(26usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:493:40 [INFO] [stdout] | [INFO] [stdout] 493 | unsafe { ::std::mem::transmute(self._bitfield_1.get(26usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(26usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:499:28 [INFO] [stdout] | [INFO] [stdout] 499 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:506:18 [INFO] [stdout] | [INFO] [stdout] 506 | unsafe { ::std::mem::transmute(self._bitfield_1.get(27usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `cn` is used to index `xe_engine_class_name` [INFO] [stdout] --> src/drm_drivers/xe.rs:290:19 [INFO] [stdout] | [INFO] [stdout] 290 | for cn in 0..self.nr_engs { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 290 - for cn in 0..self.nr_engs { [INFO] [stdout] 290 + for (cn, ) in xe_engine_class_name.iter().enumerate().take(self.nr_engs) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:506:40 [INFO] [stdout] | [INFO] [stdout] 506 | unsafe { ::std::mem::transmute(self._bitfield_1.get(27usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(27usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:512:28 [INFO] [stdout] | [INFO] [stdout] 512 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:519:18 [INFO] [stdout] | [INFO] [stdout] 519 | unsafe { ::std::mem::transmute(self._bitfield_1.get(28usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:519:40 [INFO] [stdout] | [INFO] [stdout] 519 | unsafe { ::std::mem::transmute(self._bitfield_1.get(28usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(28usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:525:28 [INFO] [stdout] | [INFO] [stdout] 525 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:532:18 [INFO] [stdout] | [INFO] [stdout] 532 | unsafe { ::std::mem::transmute(self._bitfield_1.get(29usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:532:40 [INFO] [stdout] | [INFO] [stdout] 532 | unsafe { ::std::mem::transmute(self._bitfield_1.get(29usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(29usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:538:28 [INFO] [stdout] | [INFO] [stdout] 538 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:545:18 [INFO] [stdout] | [INFO] [stdout] 545 | unsafe { ::std::mem::transmute(self._bitfield_1.get(30usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:545:40 [INFO] [stdout] | [INFO] [stdout] 545 | unsafe { ::std::mem::transmute(self._bitfield_1.get(30usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(30usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:551:28 [INFO] [stdout] | [INFO] [stdout] 551 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:558:18 [INFO] [stdout] | [INFO] [stdout] 558 | unsafe { ::std::mem::transmute(self._bitfield_1.get(31usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:558:40 [INFO] [stdout] | [INFO] [stdout] 558 | unsafe { ::std::mem::transmute(self._bitfield_1.get(31usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(31usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:564:28 [INFO] [stdout] | [INFO] [stdout] 564 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:571:18 [INFO] [stdout] | [INFO] [stdout] 571 | unsafe { ::std::mem::transmute(self._bitfield_1.get(32usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:571:40 [INFO] [stdout] | [INFO] [stdout] 571 | unsafe { ::std::mem::transmute(self._bitfield_1.get(32usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(32usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:577:28 [INFO] [stdout] | [INFO] [stdout] 577 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:584:18 [INFO] [stdout] | [INFO] [stdout] 584 | unsafe { ::std::mem::transmute(self._bitfield_1.get(33usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:584:40 [INFO] [stdout] | [INFO] [stdout] 584 | unsafe { ::std::mem::transmute(self._bitfield_1.get(33usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(33usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:590:28 [INFO] [stdout] | [INFO] [stdout] 590 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:597:18 [INFO] [stdout] | [INFO] [stdout] 597 | unsafe { ::std::mem::transmute(self._bitfield_1.get(34usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:597:40 [INFO] [stdout] | [INFO] [stdout] 597 | unsafe { ::std::mem::transmute(self._bitfield_1.get(34usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(34usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:603:28 [INFO] [stdout] | [INFO] [stdout] 603 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:610:18 [INFO] [stdout] | [INFO] [stdout] 610 | unsafe { ::std::mem::transmute(self._bitfield_1.get(35usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:610:40 [INFO] [stdout] | [INFO] [stdout] 610 | unsafe { ::std::mem::transmute(self._bitfield_1.get(35usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(35usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:616:28 [INFO] [stdout] | [INFO] [stdout] 616 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/drm_drivers/xe.rs:407:45 [INFO] [stdout] | [INFO] [stdout] 407 | fn freqs(&mut self, gt_nr: usize, data: &Vec) -> Result<(u64, u64)> [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 407 - fn freqs(&mut self, gt_nr: usize, data: &Vec) -> Result<(u64, u64)> [INFO] [stdout] 407 + fn freqs(&mut self, gt_nr: usize, data: &[u64]) -> Result<(u64, u64)> [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:623:18 [INFO] [stdout] | [INFO] [stdout] 623 | unsafe { ::std::mem::transmute(self._bitfield_1.get(36usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:623:40 [INFO] [stdout] | [INFO] [stdout] 623 | unsafe { ::std::mem::transmute(self._bitfield_1.get(36usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(36usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:629:28 [INFO] [stdout] | [INFO] [stdout] 629 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:636:18 [INFO] [stdout] | [INFO] [stdout] 636 | unsafe { ::std::mem::transmute(self._bitfield_1.get(37usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:636:40 [INFO] [stdout] | [INFO] [stdout] 636 | unsafe { ::std::mem::transmute(self._bitfield_1.get(37usize, 1u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(37usize, 1u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:642:28 [INFO] [stdout] | [INFO] [stdout] 642 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:649:18 [INFO] [stdout] | [INFO] [stdout] 649 | unsafe { ::std::mem::transmute(self._bitfield_1.get(38usize, 26u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/perf_event.rs:649:40 [INFO] [stdout] | [INFO] [stdout] 649 | unsafe { ::std::mem::transmute(self._bitfield_1.get(38usize, 26u8) as u64) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self._bitfield_1.get(38usize, 26u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/drm_drivers/xe.rs:438:27 [INFO] [stdout] | [INFO] [stdout] 438 | fn from(base_gts_dir: &PathBuf, src: &str) -> Result [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 438 - fn from(base_gts_dir: &PathBuf, src: &str) -> Result [INFO] [stdout] 438 + fn from(base_gts_dir: &Path, src: &str) -> Result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:655:28 [INFO] [stdout] | [INFO] [stdout] 655 | let val: u64 = ::std::mem::transmute(val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (38/7) [INFO] [stdout] --> src/perf_event.rs:661:5 [INFO] [stdout] | [INFO] [stdout] 661 | / pub fn new_bitfield_1( [INFO] [stdout] 662 | | disabled: u64, [INFO] [stdout] 663 | | inherit: u64, [INFO] [stdout] 664 | | pinned: u64, [INFO] [stdout] ... | [INFO] [stdout] 699 | | __reserved_1: u64, [INFO] [stdout] 700 | | ) -> __BindgenBitfieldUnit<[u8; 8usize]> { [INFO] [stdout] | |____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/drm_drivers/xe.rs:491:45 [INFO] [stdout] | [INFO] [stdout] 491 | fn xe_dev_type_from(dn_fd: RawFd, dev_path: &PathBuf) -> Result [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 491 - fn xe_dev_type_from(dn_fd: RawFd, dev_path: &PathBuf) -> Result [INFO] [stdout] 491 + fn xe_dev_type_from(dn_fd: RawFd, dev_path: &Path) -> Result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DrmDeviceType` which implements the `Copy` trait [INFO] [stdout] --> src/drm_drivers/xe.rs:571:12 [INFO] [stdout] | [INFO] [stdout] 571 | Ok(self.dev_type.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.dev_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/drm_drivers/xe.rs:604:5 [INFO] [stdout] | [INFO] [stdout] 604 | / pub fn new(qmd: &DrmDeviceInfo, [INFO] [stdout] 605 | | _opts: Option<&Vec<&str>>) -> Result>> [INFO] [stdout] 606 | | { [INFO] [stdout] 607 | | let mut vpath = String::from("/sys/class/vfio-dev/"); [INFO] [stdout] ... | [INFO] [stdout] 650 | | Ok(Rc::new(RefCell::new(xe_vfio))) [INFO] [stdout] 651 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:703:42 [INFO] [stdout] | [INFO] [stdout] 703 | let disabled: u64 = unsafe { ::std::mem::transmute(disabled) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:707:41 [INFO] [stdout] | [INFO] [stdout] 707 | let inherit: u64 = unsafe { ::std::mem::transmute(inherit) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:711:40 [INFO] [stdout] | [INFO] [stdout] 711 | let pinned: u64 = unsafe { ::std::mem::transmute(pinned) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `pmu_src_res` after checking its variant with `is_err` [INFO] [stdout] --> src/drm_drivers/xe.rs:631:27 [INFO] [stdout] | [INFO] [stdout] 627 | if pmu_src_res.is_err() { [INFO] [stdout] | ----------------------- help: try: `if let Ok() = pmu_src_res` [INFO] [stdout] ... [INFO] [stdout] 631 | let pmu_src = pmu_src_res.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:715:43 [INFO] [stdout] | [INFO] [stdout] 715 | let exclusive: u64 = unsafe { ::std::mem::transmute(exclusive) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `res` after checking its variant with `is_err` [INFO] [stdout] --> src/drm_drivers/xe.rs:641:33 [INFO] [stdout] | [INFO] [stdout] 637 | if res.is_err() { [INFO] [stdout] | --------------- help: try: `if let Ok() = res` [INFO] [stdout] ... [INFO] [stdout] 641 | engs_pmu = Some(res.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:719:46 [INFO] [stdout] | [INFO] [stdout] 719 | let exclude_user: u64 = unsafe { ::std::mem::transmute(exclude_user) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:723:48 [INFO] [stdout] | [INFO] [stdout] 723 | let exclude_kernel: u64 = unsafe { ::std::mem::transmute(exclude_kernel) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:727:44 [INFO] [stdout] | [INFO] [stdout] 727 | let exclude_hv: u64 = unsafe { ::std::mem::transmute(exclude_hv) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:731:46 [INFO] [stdout] | [INFO] [stdout] 731 | let exclude_idle: u64 = unsafe { ::std::mem::transmute(exclude_idle) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:735:38 [INFO] [stdout] | [INFO] [stdout] 735 | let mmap: u64 = unsafe { ::std::mem::transmute(mmap) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:739:38 [INFO] [stdout] | [INFO] [stdout] 739 | let comm: u64 = unsafe { ::std::mem::transmute(comm) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:743:38 [INFO] [stdout] | [INFO] [stdout] 743 | let freq: u64 = unsafe { ::std::mem::transmute(freq) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:747:46 [INFO] [stdout] | [INFO] [stdout] 747 | let inherit_stat: u64 = unsafe { ::std::mem::transmute(inherit_stat) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:751:48 [INFO] [stdout] | [INFO] [stdout] 751 | let enable_on_exec: u64 = unsafe { ::std::mem::transmute(enable_on_exec) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:755:38 [INFO] [stdout] | [INFO] [stdout] 755 | let task: u64 = unsafe { ::std::mem::transmute(task) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:759:43 [INFO] [stdout] | [INFO] [stdout] 759 | let watermark: u64 = unsafe { ::std::mem::transmute(watermark) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:763:44 [INFO] [stdout] | [INFO] [stdout] 763 | let precise_ip: u64 = unsafe { ::std::mem::transmute(precise_ip) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:767:43 [INFO] [stdout] | [INFO] [stdout] 767 | let mmap_data: u64 = unsafe { ::std::mem::transmute(mmap_data) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:771:47 [INFO] [stdout] | [INFO] [stdout] 771 | let sample_id_all: u64 = unsafe { ::std::mem::transmute(sample_id_all) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:775:46 [INFO] [stdout] | [INFO] [stdout] 775 | let exclude_host: u64 = unsafe { ::std::mem::transmute(exclude_host) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:779:47 [INFO] [stdout] | [INFO] [stdout] 779 | let exclude_guest: u64 = unsafe { ::std::mem::transmute(exclude_guest) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:784:26 [INFO] [stdout] | [INFO] [stdout] 784 | unsafe { ::std::mem::transmute(exclude_callchain_kernel) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:789:26 [INFO] [stdout] | [INFO] [stdout] 789 | unsafe { ::std::mem::transmute(exclude_callchain_user) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:793:39 [INFO] [stdout] | [INFO] [stdout] 793 | let mmap2: u64 = unsafe { ::std::mem::transmute(mmap2) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:797:43 [INFO] [stdout] | [INFO] [stdout] 797 | let comm_exec: u64 = unsafe { ::std::mem::transmute(comm_exec) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:801:45 [INFO] [stdout] | [INFO] [stdout] 801 | let use_clockid: u64 = unsafe { ::std::mem::transmute(use_clockid) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:805:48 [INFO] [stdout] | [INFO] [stdout] 805 | let context_switch: u64 = unsafe { ::std::mem::transmute(context_switch) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:809:48 [INFO] [stdout] | [INFO] [stdout] 809 | let write_backward: u64 = unsafe { ::std::mem::transmute(write_backward) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:813:44 [INFO] [stdout] | [INFO] [stdout] 813 | let namespaces: u64 = unsafe { ::std::mem::transmute(namespaces) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:817:41 [INFO] [stdout] | [INFO] [stdout] 817 | let ksymbol: u64 = unsafe { ::std::mem::transmute(ksymbol) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:821:43 [INFO] [stdout] | [INFO] [stdout] 821 | let bpf_event: u64 = unsafe { ::std::mem::transmute(bpf_event) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:825:44 [INFO] [stdout] | [INFO] [stdout] 825 | let aux_output: u64 = unsafe { ::std::mem::transmute(aux_output) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:829:40 [INFO] [stdout] | [INFO] [stdout] 829 | let cgroup: u64 = unsafe { ::std::mem::transmute(cgroup) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DrmDeviceType` which implements the `Copy` trait [INFO] [stdout] --> src/drm_drivers/xe.rs:676:12 [INFO] [stdout] | [INFO] [stdout] 676 | Ok(self.dev_type.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.dev_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:833:43 [INFO] [stdout] | [INFO] [stdout] 833 | let text_poke: u64 = unsafe { ::std::mem::transmute(text_poke) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:837:42 [INFO] [stdout] | [INFO] [stdout] 837 | let build_id: u64 = unsafe { ::std::mem::transmute(build_id) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:841:48 [INFO] [stdout] | [INFO] [stdout] 841 | let inherit_thread: u64 = unsafe { ::std::mem::transmute(inherit_thread) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:845:48 [INFO] [stdout] | [INFO] [stdout] 845 | let remove_on_exec: u64 = unsafe { ::std::mem::transmute(remove_on_exec) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:849:41 [INFO] [stdout] | [INFO] [stdout] 849 | let sigtrap: u64 = unsafe { ::std::mem::transmute(sigtrap) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute from a type (`u64`) to itself [INFO] [stdout] --> src/perf_event.rs:853:46 [INFO] [stdout] | [INFO] [stdout] 853 | let __reserved_1: u64 = unsafe { ::std::mem::transmute(__reserved_1) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.freqs_pmu` after checking its variant with `is_none` [INFO] [stdout] --> src/drm_drivers/xe.rs:809:17 [INFO] [stdout] | [INFO] [stdout] 798 | let (cur_val, act_val) = if self.freqs_pmu.is_none() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = &mut self.freqs_pmu` [INFO] [stdout] ... [INFO] [stdout] 809 | / self.freqs_pmu [INFO] [stdout] 810 | | .as_mut().unwrap() [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/perf_event.rs:1055:19 [INFO] [stdout] | [INFO] [stdout] 1055 | .join(&format!("{}.scale", evt)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}.scale", evt)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/perf_event.rs:1067:19 [INFO] [stdout] | [INFO] [stdout] 1067 | .join(&format!("{}.unit", evt)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}.unit", evt)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/perf_event.rs:1095:16 [INFO] [stdout] | [INFO] [stdout] 1095 | if keys.iter().any(|&k| k == key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `keys.contains(&key)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] = note: `#[warn(clippy::manual_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/drm_drivers/xe.rs:933:5 [INFO] [stdout] | [INFO] [stdout] 933 | / pub fn new(qmd: &DrmDeviceInfo, [INFO] [stdout] 934 | | opts_vec: Option<&Vec<&str>>) -> Result>> [INFO] [stdout] 935 | | { [INFO] [stdout] 936 | | let file = File::open(&qmd.dev_nodes[0].devnode)?; [INFO] [stdout] ... | [INFO] [stdout] 1015 | | Ok(Rc::new(RefCell::new(xe))) [INFO] [stdout] 1016 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `res` after checking its variant with `is_err` [INFO] [stdout] --> src/drm_drivers/xe.rs:999:40 [INFO] [stdout] | [INFO] [stdout] 995 | if res.is_err() { [INFO] [stdout] | --------------- help: try: `if let Ok() = res` [INFO] [stdout] ... [INFO] [stdout] 999 | xe.engs_pmu = Some(res.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `res` after checking its variant with `is_err` [INFO] [stdout] --> src/drm_drivers/xe.rs:1010:41 [INFO] [stdout] | [INFO] [stdout] 1006 | if res.is_err() { [INFO] [stdout] | --------------- help: try: `if let Ok() = res` [INFO] [stdout] ... [INFO] [stdout] 1010 | xe.freqs_pmu = Some(res.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/drm_drivers/xe.rs:987:35 [INFO] [stdout] | [INFO] [stdout] 987 | let pmu_src = pmu_src_res.unwrap_or(String::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::fs::ReadDir` [INFO] [stdout] --> src/hwmon.rs:117:26 [INFO] [stdout] | [INFO] [stdout] 117 | let hwmon_path = fs::read_dir(root_dir)? [INFO] [stdout] | __________________________^ [INFO] [stdout] 118 | | .into_iter() [INFO] [stdout] | |________________________^ help: consider removing `.into_iter()`: `fs::read_dir(root_dir)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `VFIO` contains a capitalized acronym [INFO] [stdout] --> src/drm_devices.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | VFIO, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Vfio` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `cn` is used to index `i915_engine_class_name` [INFO] [stdout] --> src/drm_drivers/i915.rs:154:19 [INFO] [stdout] | [INFO] [stdout] 154 | for cn in 0..self.nr_engs { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 154 - for cn in 0..self.nr_engs { [INFO] [stdout] 154 + for (cn, ) in i915_engine_class_name.iter().enumerate().take(self.nr_engs) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/drm_devices.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | / match self { [INFO] [stdout] 40 | | DrmDeviceType::Discrete(_) => true, [INFO] [stdout] 41 | | _ => false [INFO] [stdout] 42 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 39 - match self { [INFO] [stdout] 40 - DrmDeviceType::Discrete(_) => true, [INFO] [stdout] 41 - _ => false [INFO] [stdout] 42 - } [INFO] [stdout] 39 + matches!(self, DrmDeviceType::Discrete(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/drm_devices.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | / match self { [INFO] [stdout] 48 | | DrmDeviceType::Integrated(_) => true, [INFO] [stdout] 49 | | _ => false [INFO] [stdout] 50 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 47 - match self { [INFO] [stdout] 48 - DrmDeviceType::Integrated(_) => true, [INFO] [stdout] 49 - _ => false [INFO] [stdout] 50 - } [INFO] [stdout] 47 + matches!(self, DrmDeviceType::Integrated(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/drm_devices.rs:53:22 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn to_string(&self) -> String [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `drm_devices::DrmDeviceType` [INFO] [stdout] --> src/drm_devices.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | / pub fn to_string(&self) -> String [INFO] [stdout] 54 | | { [INFO] [stdout] 55 | | let mut ret = String::new(); [INFO] [stdout] ... | [INFO] [stdout] 79 | | ret [INFO] [stdout] 80 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `drm_devices::DrmDeviceType` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] = note: `#[warn(clippy::inherent_to_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/drm_drivers/i915.rs:205:45 [INFO] [stdout] | [INFO] [stdout] 205 | fn freqs(&mut self, gt_nr: usize, data: &Vec) -> Result<(u64, u64)> [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 205 - fn freqs(&mut self, gt_nr: usize, data: &Vec) -> Result<(u64, u64)> [INFO] [stdout] 205 + fn freqs(&mut self, gt_nr: usize, data: &[u64]) -> Result<(u64, u64)> [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DrmDeviceType` which implements the `Copy` trait [INFO] [stdout] --> src/drm_drivers/i915.rs:268:12 [INFO] [stdout] | [INFO] [stdout] 268 | Ok(self.dev_type.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.dev_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.freqs_pmu` after checking its variant with `is_none` [INFO] [stdout] --> src/drm_drivers/i915.rs:341:17 [INFO] [stdout] | [INFO] [stdout] 330 | let (cur_val, act_val) = if self.freqs_pmu.is_none() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = &mut self.freqs_pmu` [INFO] [stdout] ... [INFO] [stdout] 341 | / self.freqs_pmu [INFO] [stdout] 342 | | .as_mut().unwrap() [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/drm_drivers/i915.rs:621:13 [INFO] [stdout] | [INFO] [stdout] 621 | src.push_str("_"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `src.push('_')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/drm_drivers/i915.rs:721:5 [INFO] [stdout] | [INFO] [stdout] 721 | / pub fn new(qmd: &DrmDeviceInfo, [INFO] [stdout] 722 | | opts_vec: Option<&Vec<&str>>) -> Result>> [INFO] [stdout] 723 | | { [INFO] [stdout] 724 | | let file = File::open(&qmd.dev_nodes[0].devnode)?; [INFO] [stdout] ... | [INFO] [stdout] 799 | | Ok(Rc::new(RefCell::new(i915))) [INFO] [stdout] 800 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/drm_drivers/i915.rs:776:35 [INFO] [stdout] | [INFO] [stdout] 776 | let pmu_src = pmu_src_res.unwrap_or(String::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/drm_devices.rs:210:17 [INFO] [stdout] | [INFO] [stdout] 210 | format!("{}", &sensor.stype["temp".len()..]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `(&sensor.stype["temp".len()..]).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DrmDeviceType` which implements the `Copy` trait [INFO] [stdout] --> src/drm_drivers/amdgpu.rs:328:12 [INFO] [stdout] | [INFO] [stdout] 328 | Ok(self.dev_type.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.dev_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/drm_devices.rs:247:17 [INFO] [stdout] | [INFO] [stdout] 247 | format!("{}", &sensor.stype["fan".len()..]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `(&sensor.stype["fan".len()..]).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.hwmon` after checking its variant with `is_some` [INFO] [stdout] --> src/drm_drivers/amdgpu.rs:461:46 [INFO] [stdout] | [INFO] [stdout] 460 | if self.hwmon.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = &self.hwmon` [INFO] [stdout] 461 | DrmDeviceTemperature::from_hwmon(self.hwmon.as_ref().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.hwmon` after checking its variant with `is_some` [INFO] [stdout] --> src/drm_drivers/amdgpu.rs:470:38 [INFO] [stdout] | [INFO] [stdout] 469 | if self.hwmon.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = &self.hwmon` [INFO] [stdout] 470 | DrmDeviceFan::from_hwmon(self.hwmon.as_ref().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/drm_devices.rs:358:9 [INFO] [stdout] | [INFO] [stdout] 358 | / if !self.engs_utilization.is_empty() { [INFO] [stdout] 359 | | if self.engs_utilization.contains_key(eng) { [INFO] [stdout] 360 | | return self.engs_utilization[eng]; [INFO] [stdout] 361 | | } [INFO] [stdout] 362 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 358 ~ if !self.engs_utilization.is_empty() [INFO] [stdout] 359 ~ && self.engs_utilization.contains_key(eng) { [INFO] [stdout] 360 | return self.engs_utilization[eng]; [INFO] [stdout] 361 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/drm_devices.rs:372:20 [INFO] [stdout] | [INFO] [stdout] 372 | engs = self.engs_utilization.keys() [INFO] [stdout] | ____________________^ [INFO] [stdout] 373 | | .map(|nm| nm.clone()) [INFO] [stdout] | |_____________________________________^ help: consider calling the dedicated `cloned` method: `self.engs_utilization.keys().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/drm_drivers/amdgpu.rs:519:5 [INFO] [stdout] | [INFO] [stdout] 519 | / pub fn new(qmd: &DrmDeviceInfo, [INFO] [stdout] 520 | | _opts: Option<&Vec<&str>>) -> Result>> [INFO] [stdout] 521 | | { [INFO] [stdout] 522 | | let mut dn: &str = ""; [INFO] [stdout] ... | [INFO] [stdout] 566 | | Ok(Rc::new(RefCell::new(amdgpu))) [INFO] [stdout] 567 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/drm_devices.rs:384:39 [INFO] [stdout] | [INFO] [stdout] 384 | return Some(Rc::downgrade(&vref)); [INFO] [stdout] | ^^^^^ help: change this to: `vref` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/drm_drivers.rs:95:20 [INFO] [stdout] | [INFO] [stdout] 95 | const ALL_DRIVERS: &[(&str, fn(&DrmDeviceInfo, Option<&Vec<&str>>) -> Result>>)] = &[ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same prefix: `Kv` [INFO] [stdout] --> src/drm_fdinfo.rs:24:1 [INFO] [stdout] | [INFO] [stdout] 24 | / enum EngKvType [INFO] [stdout] 25 | | { [INFO] [stdout] 26 | | KvTime, [INFO] [stdout] 27 | | KvCapacity, [INFO] [stdout] 28 | | KvCycles, [INFO] [stdout] 29 | | KvTotCycles, [INFO] [stdout] 30 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/drm_devices.rs:534:31 [INFO] [stdout] | [INFO] [stdout] 534 | fn vendor_name(vendor_id: &String) -> String [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 534 ~ fn vendor_name(vendor_id: &str) -> String [INFO] [stdout] 535 | { [INFO] [stdout] ... [INFO] [stdout] 545 | [INFO] [stdout] 546 ~ vendor_id.to_owned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same prefix: `Kv` [INFO] [stdout] --> src/drm_fdinfo.rs:77:1 [INFO] [stdout] | [INFO] [stdout] 77 | / enum MemRegKvType [INFO] [stdout] 78 | | { [INFO] [stdout] 79 | | KvTotal, [INFO] [stdout] 80 | | KvShared, [INFO] [stdout] ... | [INFO] [stdout] 83 | | KvActive, [INFO] [stdout] 84 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/drm_fdinfo.rs:86:1 [INFO] [stdout] | [INFO] [stdout] 86 | / impl Default for DrmMemRegion [INFO] [stdout] 87 | | { [INFO] [stdout] 88 | | fn default() -> DrmMemRegion [INFO] [stdout] ... | [INFO] [stdout] 99 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 67 + #[derive(Default)] [INFO] [stdout] 68 | pub struct DrmMemRegion [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/drm_devices.rs:549:31 [INFO] [stdout] | [INFO] [stdout] 549 | fn device_name(vendor_id: &String, device_id: &String) -> String [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 549 - fn device_name(vendor_id: &String, device_id: &String) -> String [INFO] [stdout] 549 + fn device_name(vendor_id: &str, device_id: &String) -> String [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/drm_devices.rs:549:51 [INFO] [stdout] | [INFO] [stdout] 549 | fn device_name(vendor_id: &String, device_id: &String) -> String [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 549 ~ fn device_name(vendor_id: &String, device_id: &str) -> String [INFO] [stdout] 550 | { [INFO] [stdout] ... [INFO] [stdout] 561 | [INFO] [stdout] 562 ~ device_id.to_owned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/drm_fdinfo.rs:162:9 [INFO] [stdout] | [INFO] [stdout] 162 | let eng: &mut DrmEngine; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 167 | eng = self.engines.get_mut(eng_name).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `eng` here [INFO] [stdout] | [INFO] [stdout] 162 ~ [INFO] [stdout] 163 | [INFO] [stdout] ... [INFO] [stdout] 166 | } [INFO] [stdout] 167 ~ let eng: &mut DrmEngine = self.engines.get_mut(eng_name).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/drm_devices.rs:601:38 [INFO] [stdout] | [INFO] [stdout] 601 | String::from(&rev_str[2..]) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/drm_devices.rs:600:32 [INFO] [stdout] | [INFO] [stdout] 600 | revision = if rev_str.starts_with("0x") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 600 ~ revision = if let Some() = rev_str.strip_prefix("0x") { [INFO] [stdout] 601 ~ String::from() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/drm_fdinfo.rs:200:9 [INFO] [stdout] | [INFO] [stdout] 200 | let mrg: &mut DrmMemRegion; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 205 | mrg = self.mem_regions.get_mut(mr_name).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `mrg` here [INFO] [stdout] | [INFO] [stdout] 200 ~ [INFO] [stdout] 201 | [INFO] [stdout] ... [INFO] [stdout] 204 | } [INFO] [stdout] 205 ~ let mrg: &mut DrmMemRegion = self.mem_regions.get_mut(mr_name).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/drm_fdinfo.rs:267:26 [INFO] [stdout] | [INFO] [stdout] 267 | let en = &k["drm-engine-capacity-".len()..]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/drm_fdinfo.rs:266:20 [INFO] [stdout] | [INFO] [stdout] 266 | } else if k.starts_with("drm-engine-capacity-") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 266 ~ } else if let Some(en) = k.strip_prefix("drm-engine-capacity-") { [INFO] [stdout] 267 ~ info.update_engine(EngKvType::KvCapacity, en, v)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/drm_fdinfo.rs:270:26 [INFO] [stdout] | [INFO] [stdout] 270 | let en = &k["drm-engine-".len()..]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/drm_fdinfo.rs:269:20 [INFO] [stdout] | [INFO] [stdout] 269 | } else if k.starts_with("drm-engine-") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 269 ~ } else if let Some(en) = k.strip_prefix("drm-engine-") { [INFO] [stdout] 270 ~ info.update_engine(EngKvType::KvTime, en, v)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/drm_fdinfo.rs:273:26 [INFO] [stdout] | [INFO] [stdout] 273 | let en = &k["drm-cycles-".len()..]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/drm_fdinfo.rs:272:20 [INFO] [stdout] | [INFO] [stdout] 272 | } else if k.starts_with("drm-cycles-") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 272 ~ } else if let Some(en) = k.strip_prefix("drm-cycles-") { [INFO] [stdout] 273 ~ info.update_engine(EngKvType::KvCycles, en, v)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/drm_fdinfo.rs:276:26 [INFO] [stdout] | [INFO] [stdout] 276 | let en = &k["drm-total-cycles-".len()..]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/drm_fdinfo.rs:275:20 [INFO] [stdout] | [INFO] [stdout] 275 | } else if k.starts_with("drm-total-cycles-") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 275 ~ } else if let Some(en) = k.strip_prefix("drm-total-cycles-") { [INFO] [stdout] 276 ~ info.update_engine(EngKvType::KvTotCycles, en, v)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/drm_fdinfo.rs:279:27 [INFO] [stdout] | [INFO] [stdout] 279 | let mrn = &k["drm-total-".len()..]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/drm_fdinfo.rs:278:20 [INFO] [stdout] | [INFO] [stdout] 278 | } else if k.starts_with("drm-total-") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 278 ~ } else if let Some(mrn) = k.strip_prefix("drm-total-") { [INFO] [stdout] 279 ~ info.update_mem_region(MemRegKvType::KvTotal, mrn, v)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/drm_fdinfo.rs:282:27 [INFO] [stdout] | [INFO] [stdout] 282 | let mrn = &k["drm-shared-".len()..]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/drm_fdinfo.rs:281:20 [INFO] [stdout] | [INFO] [stdout] 281 | } else if k.starts_with("drm-shared-") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 281 ~ } else if let Some(mrn) = k.strip_prefix("drm-shared-") { [INFO] [stdout] 282 ~ info.update_mem_region(MemRegKvType::KvShared, mrn, v)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/drm_fdinfo.rs:285:27 [INFO] [stdout] | [INFO] [stdout] 285 | let mrn = &k["drm-resident-".len()..]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/drm_fdinfo.rs:284:20 [INFO] [stdout] | [INFO] [stdout] 284 | } else if k.starts_with("drm-resident-") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 284 ~ } else if let Some(mrn) = k.strip_prefix("drm-resident-") { [INFO] [stdout] 285 ~ info.update_mem_region(MemRegKvType::KvResident, mrn, v)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/drm_drivers/intel_common.rs:40:17 [INFO] [stdout] | [INFO] [stdout] 40 | self.opts = self.opts | iopt_mask; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.opts |= iopt_mask` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/drm_fdinfo.rs:288:27 [INFO] [stdout] | [INFO] [stdout] 288 | let mrn = &k["drm-purgeable-".len()..]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/drm_fdinfo.rs:287:20 [INFO] [stdout] | [INFO] [stdout] 287 | } else if k.starts_with("drm-purgeable-") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 287 ~ } else if let Some(mrn) = k.strip_prefix("drm-purgeable-") { [INFO] [stdout] 288 ~ info.update_mem_region(MemRegKvType::KvPurgeable, mrn, v)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/drm_drivers/intel_common.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | self.opts = self.opts | other.opts; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.opts |= other.opts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/drm_fdinfo.rs:291:27 [INFO] [stdout] | [INFO] [stdout] 291 | let mrn = &k["drm-active-".len()..]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/drm_fdinfo.rs:290:20 [INFO] [stdout] | [INFO] [stdout] 290 | } else if k.starts_with("drm-active-") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 290 ~ } else if let Some(mrn) = k.strip_prefix("drm-active-") { [INFO] [stdout] 291 ~ info.update_mem_region(MemRegKvType::KvActive, mrn, v)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/drm_drivers/intel_common.rs:66:31 [INFO] [stdout] | [INFO] [stdout] 66 | devslot = &opt["devslot=".len()..]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/drm_drivers/intel_common.rs:65:17 [INFO] [stdout] | [INFO] [stdout] 65 | if opt.starts_with("devslot=") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 65 ~ if let Some() = opt.strip_prefix("devslot=") { [INFO] [stdout] 66 ~ devslot = ; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/proc_info.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | / if nval.is_none() { [INFO] [stdout] 34 | | return None; [INFO] [stdout] 35 | | } [INFO] [stdout] | |_____________^ help: replace it with: `nval.as_ref()?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/proc_info.rs:49:17 [INFO] [stdout] | [INFO] [stdout] 49 | if !fp.chars().next().unwrap().is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fp.chars().next().unwrap().is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/proc_info.rs:112:13 [INFO] [stdout] | [INFO] [stdout] 112 | if !pid.chars().next().unwrap().is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `pid.chars().next().unwrap().is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/drm_drivers/intel_power.rs:131:10 [INFO] [stdout] | [INFO] [stdout] 131 | ) -> Option<( [INFO] [stdout] | __________^ [INFO] [stdout] 132 | | fn(&mut DGpuPowerIntel, hwmon: &Hwmon) -> Result, [INFO] [stdout] 133 | | SensorSet [INFO] [stdout] 134 | | )> [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/drm_drivers/intel_power.rs:214:9 [INFO] [stdout] | [INFO] [stdout] 214 | return Ok(Some(Box::new(pwr))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 214 - return Ok(Some(Box::new(pwr))); [INFO] [stdout] 214 + Ok(Some(Box::new(pwr))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> src/drm_drivers/intel_power.rs:262:9 [INFO] [stdout] | [INFO] [stdout] 262 | / if !self.sums.contains_key(&offset) { [INFO] [stdout] 263 | | self.sums.insert(offset, MsrSum { sum: 0, last: 0, }); [INFO] [stdout] 264 | | } [INFO] [stdout] | |_________^ help: try: `self.sums.entry(offset).or_insert(MsrSum { sum: 0, last: 0, });` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] = note: `#[warn(clippy::map_entry)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/drm_drivers/intel_power.rs:280:9 [INFO] [stdout] | [INFO] [stdout] 280 | / match self.read(offset) { [INFO] [stdout] 281 | | Err(_) => false, [INFO] [stdout] 282 | | _ => true [INFO] [stdout] 283 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 280 - match self.read(offset) { [INFO] [stdout] 281 - Err(_) => false, [INFO] [stdout] 282 - _ => true [INFO] [stdout] 283 - } [INFO] [stdout] 280 + !matches!(self.read(offset), Err(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/drm_drivers/intel_power.rs:280:9 [INFO] [stdout] | [INFO] [stdout] 280 | / match self.read(offset) { [INFO] [stdout] 281 | | Err(_) => false, [INFO] [stdout] 282 | | _ => true [INFO] [stdout] 283 | | } [INFO] [stdout] | |_________^ help: try: `self.read(offset).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/proc_info.rs:246:23 [INFO] [stdout] | [INFO] [stdout] 246 | pub fn from(npid: &String) -> Result [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 246 ~ pub fn from(npid: &str) -> Result [INFO] [stdout] 247 | { [INFO] [stdout] ... [INFO] [stdout] 251 | cmdline: String::new(), [INFO] [stdout] 252 ~ proc_dir: Path::new("/proc").join(npid), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/drm_drivers/intel_power.rs:439:5 [INFO] [stdout] | [INFO] [stdout] 439 | / pub fn new(mut use_msr: bool) -> Result>> [INFO] [stdout] 440 | | { [INFO] [stdout] 441 | | let mut pf_evt: Option = None; [INFO] [stdout] 442 | | let mut msr: Option = None; [INFO] [stdout] ... | [INFO] [stdout] 480 | | }))) [INFO] [stdout] 481 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/drm_drivers/xe.rs:133:50 [INFO] [stdout] | [INFO] [stdout] 133 | fn xe_sriov_pf_dev_from(pci_dev: &str, dev_path: &PathBuf) -> Result [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 133 - fn xe_sriov_pf_dev_from(pci_dev: &str, dev_path: &PathBuf) -> Result [INFO] [stdout] 133 + fn xe_sriov_pf_dev_from(pci_dev: &str, dev_path: &Path) -> Result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/drm_drivers/xe.rs:163:46 [INFO] [stdout] | [INFO] [stdout] 163 | fn xe_sriov_fn_from(pci_dev: &str, dev_path: &PathBuf) -> Result [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 163 - fn xe_sriov_fn_from(pci_dev: &str, dev_path: &PathBuf) -> Result [INFO] [stdout] 163 + fn xe_sriov_fn_from(pci_dev: &str, dev_path: &Path) -> Result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `cn` is used to index `xe_engine_class_name` [INFO] [stdout] --> src/drm_drivers/xe.rs:290:19 [INFO] [stdout] | [INFO] [stdout] 290 | for cn in 0..self.nr_engs { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 290 - for cn in 0..self.nr_engs { [INFO] [stdout] 290 + for (cn, ) in xe_engine_class_name.iter().enumerate().take(self.nr_engs) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> src/drm_clients.rs:393:9 [INFO] [stdout] | [INFO] [stdout] 393 | / if !map.contains_key(&dev) { [INFO] [stdout] 394 | | let mut vlst: Vec = Vec::new(); [INFO] [stdout] 395 | | vlst.push(cli); [INFO] [stdout] 396 | | map.insert(dev, Rc::new(RefCell::new(vlst))); [INFO] [stdout] ... | [INFO] [stdout] 399 | | vref.push(cli); [INFO] [stdout] 400 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: consider using the `Entry` API: https://doc.rust-lang.org/std/collections/struct.HashMap.html#entry-api [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/drm_clients.rs:394:13 [INFO] [stdout] | [INFO] [stdout] 394 | / let mut vlst: Vec = Vec::new(); [INFO] [stdout] 395 | | vlst.push(cli); [INFO] [stdout] | |___________________________^ help: consider using the `vec![]` macro: `let vlst: Vec = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/drm_drivers/xe.rs:407:45 [INFO] [stdout] | [INFO] [stdout] 407 | fn freqs(&mut self, gt_nr: usize, data: &Vec) -> Result<(u64, u64)> [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 407 - fn freqs(&mut self, gt_nr: usize, data: &Vec) -> Result<(u64, u64)> [INFO] [stdout] 407 + fn freqs(&mut self, gt_nr: usize, data: &[u64]) -> Result<(u64, u64)> [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/drm_drivers/xe.rs:438:27 [INFO] [stdout] | [INFO] [stdout] 438 | fn from(base_gts_dir: &PathBuf, src: &str) -> Result [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 438 - fn from(base_gts_dir: &PathBuf, src: &str) -> Result [INFO] [stdout] 438 + fn from(base_gts_dir: &Path, src: &str) -> Result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/drm_drivers/xe.rs:491:45 [INFO] [stdout] | [INFO] [stdout] 491 | fn xe_dev_type_from(dn_fd: RawFd, dev_path: &PathBuf) -> Result [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 491 - fn xe_dev_type_from(dn_fd: RawFd, dev_path: &PathBuf) -> Result [INFO] [stdout] 491 + fn xe_dev_type_from(dn_fd: RawFd, dev_path: &Path) -> Result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DrmDeviceType` which implements the `Copy` trait [INFO] [stdout] --> src/drm_drivers/xe.rs:571:12 [INFO] [stdout] | [INFO] [stdout] 571 | Ok(self.dev_type.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.dev_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/drm_drivers/xe.rs:604:5 [INFO] [stdout] | [INFO] [stdout] 604 | / pub fn new(qmd: &DrmDeviceInfo, [INFO] [stdout] 605 | | _opts: Option<&Vec<&str>>) -> Result>> [INFO] [stdout] 606 | | { [INFO] [stdout] 607 | | let mut vpath = String::from("/sys/class/vfio-dev/"); [INFO] [stdout] ... | [INFO] [stdout] 650 | | Ok(Rc::new(RefCell::new(xe_vfio))) [INFO] [stdout] 651 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `pmu_src_res` after checking its variant with `is_err` [INFO] [stdout] --> src/drm_drivers/xe.rs:631:27 [INFO] [stdout] | [INFO] [stdout] 627 | if pmu_src_res.is_err() { [INFO] [stdout] | ----------------------- help: try: `if let Ok() = pmu_src_res` [INFO] [stdout] ... [INFO] [stdout] 631 | let pmu_src = pmu_src_res.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `res` after checking its variant with `is_err` [INFO] [stdout] --> src/drm_drivers/xe.rs:641:33 [INFO] [stdout] | [INFO] [stdout] 637 | if res.is_err() { [INFO] [stdout] | --------------- help: try: `if let Ok() = res` [INFO] [stdout] ... [INFO] [stdout] 641 | engs_pmu = Some(res.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DrmDeviceType` which implements the `Copy` trait [INFO] [stdout] --> src/drm_drivers/xe.rs:676:12 [INFO] [stdout] | [INFO] [stdout] 676 | Ok(self.dev_type.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.dev_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/app_data.rs:54:16 [INFO] [stdout] | [INFO] [stdout] 54 | if !dinfo.power.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `dinfo.power.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/app_data.rs:58:16 [INFO] [stdout] | [INFO] [stdout] 58 | if !dinfo.mem_info.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dinfo.mem_info.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `dinfo.power` after checking its variant with `is_none` [INFO] [stdout] --> src/app_data.rs:55:26 [INFO] [stdout] | [INFO] [stdout] 54 | if !dinfo.power.is_none() { [INFO] [stdout] | --------------------- the check is happening here [INFO] [stdout] 55 | let np = dinfo.power.as_ref().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `dinfo.mem_info` after checking its variant with `is_none` [INFO] [stdout] --> src/app_data.rs:59:27 [INFO] [stdout] | [INFO] [stdout] 58 | if !dinfo.mem_info.is_none() { [INFO] [stdout] | ------------------------ the check is happening here [INFO] [stdout] 59 | let nmi = dinfo.mem_info.as_ref().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/app_data.rs:48:20 [INFO] [stdout] | [INFO] [stdout] 48 | eng_names: &Vec, dinfo: &DrmDeviceInfo) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 48 - eng_names: &Vec, dinfo: &DrmDeviceInfo) [INFO] [stdout] 48 + eng_names: &[String], dinfo: &DrmDeviceInfo) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app_data.rs:69:30 [INFO] [stdout] | [INFO] [stdout] 69 | limited_vec_push(&mut est, dinfo.eng_utilization(en)); [INFO] [stdout] | ^^^^^^^^ help: change this to: `est` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/app_data.rs:80:23 [INFO] [stdout] | [INFO] [stdout] 80 | fn new(eng_names: &Vec) -> AppDataDeviceStats [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 80 - fn new(eng_names: &Vec) -> AppDataDeviceStats [INFO] [stdout] 80 + fn new(eng_names: &[String]) -> AppDataDeviceStats [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.freqs_pmu` after checking its variant with `is_none` [INFO] [stdout] --> src/drm_drivers/xe.rs:809:17 [INFO] [stdout] | [INFO] [stdout] 798 | let (cur_val, act_val) = if self.freqs_pmu.is_none() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = &mut self.freqs_pmu` [INFO] [stdout] ... [INFO] [stdout] 809 | / self.freqs_pmu [INFO] [stdout] 810 | | .as_mut().unwrap() [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/drm_drivers/xe.rs:933:5 [INFO] [stdout] | [INFO] [stdout] 933 | / pub fn new(qmd: &DrmDeviceInfo, [INFO] [stdout] 934 | | opts_vec: Option<&Vec<&str>>) -> Result>> [INFO] [stdout] 935 | | { [INFO] [stdout] 936 | | let file = File::open(&qmd.dev_nodes[0].devnode)?; [INFO] [stdout] ... | [INFO] [stdout] 1015 | | Ok(Rc::new(RefCell::new(xe))) [INFO] [stdout] 1016 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `res` after checking its variant with `is_err` [INFO] [stdout] --> src/drm_drivers/xe.rs:999:40 [INFO] [stdout] | [INFO] [stdout] 995 | if res.is_err() { [INFO] [stdout] | --------------- help: try: `if let Ok() = res` [INFO] [stdout] ... [INFO] [stdout] 999 | xe.engs_pmu = Some(res.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `res` after checking its variant with `is_err` [INFO] [stdout] --> src/drm_drivers/xe.rs:1010:41 [INFO] [stdout] | [INFO] [stdout] 1006 | if res.is_err() { [INFO] [stdout] | --------------- help: try: `if let Ok() = res` [INFO] [stdout] ... [INFO] [stdout] 1010 | xe.freqs_pmu = Some(res.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/drm_drivers/xe.rs:987:35 [INFO] [stdout] | [INFO] [stdout] 987 | let pmu_src = pmu_src_res.unwrap_or(String::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/app_data.rs:218:20 [INFO] [stdout] | [INFO] [stdout] 218 | eng_names: &Vec, cinfo: &DrmClientInfo) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 218 - eng_names: &Vec, cinfo: &DrmClientInfo) [INFO] [stdout] 218 + eng_names: &[String], cinfo: &DrmClientInfo) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app_data.rs:227:30 [INFO] [stdout] | [INFO] [stdout] 227 | limited_vec_push(&mut est, cinfo.eng_utilization(en)); [INFO] [stdout] | ^^^^^^^^ help: change this to: `est` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/app_data.rs:234:24 [INFO] [stdout] | [INFO] [stdout] 234 | fn from(eng_names: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 234 - fn from(eng_names: &Vec, [INFO] [stdout] 234 + fn from(eng_names: &[String], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `cn` is used to index `i915_engine_class_name` [INFO] [stdout] --> src/drm_drivers/i915.rs:154:19 [INFO] [stdout] | [INFO] [stdout] 154 | for cn in 0..self.nr_engs { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 154 - for cn in 0..self.nr_engs { [INFO] [stdout] 154 + for (cn, ) in i915_engine_class_name.iter().enumerate().take(self.nr_engs) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/drm_drivers/i915.rs:205:45 [INFO] [stdout] | [INFO] [stdout] 205 | fn freqs(&mut self, gt_nr: usize, data: &Vec) -> Result<(u64, u64)> [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 205 - fn freqs(&mut self, gt_nr: usize, data: &Vec) -> Result<(u64, u64)> [INFO] [stdout] 205 + fn freqs(&mut self, gt_nr: usize, data: &[u64]) -> Result<(u64, u64)> [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DrmDeviceType` which implements the `Copy` trait [INFO] [stdout] --> src/drm_drivers/i915.rs:268:12 [INFO] [stdout] | [INFO] [stdout] 268 | Ok(self.dev_type.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.dev_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.freqs_pmu` after checking its variant with `is_none` [INFO] [stdout] --> src/drm_drivers/i915.rs:341:17 [INFO] [stdout] | [INFO] [stdout] 330 | let (cur_val, act_val) = if self.freqs_pmu.is_none() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = &mut self.freqs_pmu` [INFO] [stdout] ... [INFO] [stdout] 341 | / self.freqs_pmu [INFO] [stdout] 342 | | .as_mut().unwrap() [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/app_data.rs:314:9 [INFO] [stdout] | [INFO] [stdout] 314 | / for cst in self.clis_stats.iter() { [INFO] [stdout] 315 | | if cst.is_single_client() && [INFO] [stdout] 316 | | cst.pid == pid && cst.client_key() == client_key { [INFO] [stdout] 317 | | return Some(cst); [INFO] [stdout] ... | [INFO] [stdout] 321 | | None [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] = note: `#[warn(clippy::manual_find)]` on by default [INFO] [stdout] help: replace with an iterator [INFO] [stdout] | [INFO] [stdout] 314 ~ self.clis_stats.iter().find(|&cst| cst.is_single_client() && [INFO] [stdout] 315 + cst.pid == pid && cst.client_key() == client_key).map(|v| v as _) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/app_data.rs:400:28 [INFO] [stdout] | [INFO] [stdout] 400 | fn fname_from(devnode: &String) -> &str [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 400 - fn fname_from(devnode: &String) -> &str [INFO] [stdout] 400 + fn fname_from(devnode: &str) -> &str [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DrmDeviceType` which implements the `Copy` trait [INFO] [stdout] --> src/app_data.rs:438:23 [INFO] [stdout] | [INFO] [stdout] 438 | dev_type: dinfo.dev_type.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `dinfo.dev_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/drm_drivers/i915.rs:621:13 [INFO] [stdout] | [INFO] [stdout] 621 | src.push_str("_"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `src.push('_')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/app_data.rs:504:31 [INFO] [stdout] | [INFO] [stdout] 504 | fn get_device(&self, dev: &String) -> Option<&AppDataDeviceState>; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/app_data.rs:554:9 [INFO] [stdout] | [INFO] [stdout] 554 | / for ds in state.devs_state.iter() { [INFO] [stdout] 555 | | if ds.pci_dev == *dev { [INFO] [stdout] 556 | | return Some(ds); [INFO] [stdout] ... | [INFO] [stdout] 560 | | None [INFO] [stdout] | |____________^ help: replace with an iterator: `state.devs_state.iter().find(|&ds| ds.pci_dev == *dev).map(|v| v as _)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/drm_drivers/i915.rs:721:5 [INFO] [stdout] | [INFO] [stdout] 721 | / pub fn new(qmd: &DrmDeviceInfo, [INFO] [stdout] 722 | | opts_vec: Option<&Vec<&str>>) -> Result>> [INFO] [stdout] 723 | | { [INFO] [stdout] 724 | | let file = File::open(&qmd.dev_nodes[0].devnode)?; [INFO] [stdout] ... | [INFO] [stdout] 799 | | Ok(Rc::new(RefCell::new(i915))) [INFO] [stdout] 800 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/drm_drivers/i915.rs:776:35 [INFO] [stdout] | [INFO] [stdout] 776 | let pmu_src = pmu_src_res.unwrap_or(String::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/app_data.rs:728:9 [INFO] [stdout] | [INFO] [stdout] 728 | / for ds in self.state.devs_state.iter() { [INFO] [stdout] 729 | | if ds.pci_dev == *dev { [INFO] [stdout] 730 | | return Some(ds); [INFO] [stdout] ... | [INFO] [stdout] 734 | | None [INFO] [stdout] | |____________^ help: replace with an iterator: `self.state.devs_state.iter().find(|&ds| ds.pci_dev == *dev).map(|v| v as _)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app_data.rs:755:57 [INFO] [stdout] | [INFO] [stdout] 755 | if let Some(dst) = self.state.remove_device(&d) { [INFO] [stdout] | ^^ help: change this to: `d` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/app/main_screen.rs:90:40 [INFO] [stdout] | [INFO] [stdout] 90 | fn exec_next(&mut self, nr_charts: &Vec) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 90 - fn exec_next(&mut self, nr_charts: &Vec) [INFO] [stdout] 90 + fn exec_next(&mut self, nr_charts: &[u8]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/app/main_screen.rs:104:40 [INFO] [stdout] | [INFO] [stdout] 104 | fn exec_prev(&mut self, nr_charts: &Vec) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 104 - fn exec_prev(&mut self, nr_charts: &Vec) [INFO] [stdout] 104 + fn exec_prev(&mut self, nr_charts: &[u8]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DrmDeviceType` which implements the `Copy` trait [INFO] [stdout] --> src/drm_drivers/amdgpu.rs:328:12 [INFO] [stdout] | [INFO] [stdout] 328 | Ok(self.dev_type.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.dev_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.hwmon` after checking its variant with `is_some` [INFO] [stdout] --> src/drm_drivers/amdgpu.rs:461:46 [INFO] [stdout] | [INFO] [stdout] 460 | if self.hwmon.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = &self.hwmon` [INFO] [stdout] 461 | DrmDeviceTemperature::from_hwmon(self.hwmon.as_ref().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.hwmon` after checking its variant with `is_some` [INFO] [stdout] --> src/drm_drivers/amdgpu.rs:470:38 [INFO] [stdout] | [INFO] [stdout] 469 | if self.hwmon.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = &self.hwmon` [INFO] [stdout] 470 | DrmDeviceFan::from_hwmon(self.hwmon.as_ref().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/drm_drivers/amdgpu.rs:519:5 [INFO] [stdout] | [INFO] [stdout] 519 | / pub fn new(qmd: &DrmDeviceInfo, [INFO] [stdout] 520 | | _opts: Option<&Vec<&str>>) -> Result>> [INFO] [stdout] 521 | | { [INFO] [stdout] 522 | | let mut dn: &str = ""; [INFO] [stdout] ... | [INFO] [stdout] 566 | | Ok(Rc::new(RefCell::new(amdgpu))) [INFO] [stdout] 567 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/drm_drivers.rs:95:20 [INFO] [stdout] | [INFO] [stdout] 95 | const ALL_DRIVERS: &[(&str, fn(&DrmDeviceInfo, Option<&Vec<&str>>) -> Result>>)] = &[ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `row_nr` is used as a loop counter [INFO] [stdout] --> src/app/main_screen.rs:583:13 [INFO] [stdout] | [INFO] [stdout] 583 | for (cli, area) in cinfos.iter().zip(clis_area.iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (row_nr, (cli, area)) in cinfos.iter().zip(clis_area.iter()).enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same prefix: `Kv` [INFO] [stdout] --> src/drm_fdinfo.rs:24:1 [INFO] [stdout] | [INFO] [stdout] 24 | / enum EngKvType [INFO] [stdout] 25 | | { [INFO] [stdout] 26 | | KvTime, [INFO] [stdout] 27 | | KvCapacity, [INFO] [stdout] 28 | | KvCycles, [INFO] [stdout] 29 | | KvTotCycles, [INFO] [stdout] 30 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/app/main_screen.rs:612:44 [INFO] [stdout] | [INFO] [stdout] 612 | fn render_meminfo_chart(&self, x_vals: &Vec, x_axis: Axis, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 612 - fn render_meminfo_chart(&self, x_vals: &Vec, x_axis: Axis, [INFO] [stdout] 612 + fn render_meminfo_chart(&self, x_vals: &[f64], x_axis: Axis, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same prefix: `Kv` [INFO] [stdout] --> src/drm_fdinfo.rs:77:1 [INFO] [stdout] | [INFO] [stdout] 77 | / enum MemRegKvType [INFO] [stdout] 78 | | { [INFO] [stdout] 79 | | KvTotal, [INFO] [stdout] 80 | | KvShared, [INFO] [stdout] ... | [INFO] [stdout] 83 | | KvActive, [INFO] [stdout] 84 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/drm_fdinfo.rs:86:1 [INFO] [stdout] | [INFO] [stdout] 86 | / impl Default for DrmMemRegion [INFO] [stdout] 87 | | { [INFO] [stdout] 88 | | fn default() -> DrmMemRegion [INFO] [stdout] ... | [INFO] [stdout] 99 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 67 + #[derive(Default)] [INFO] [stdout] 68 | pub struct DrmMemRegion [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/app/main_screen.rs:653:23 [INFO] [stdout] | [INFO] [stdout] 653 | Span::raw(format!("{}", App::short_mem_string(miny))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `App::short_mem_string(miny).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/app/main_screen.rs:654:23 [INFO] [stdout] | [INFO] [stdout] 654 | Span::raw(format!("{}", App::short_mem_string((miny + maxy) / 2))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `App::short_mem_string((miny + maxy) / 2).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/app/main_screen.rs:655:23 [INFO] [stdout] | [INFO] [stdout] 655 | Span::raw(format!("{}", App::short_mem_string(maxy))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `App::short_mem_string(maxy).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/app/main_screen.rs:672:44 [INFO] [stdout] | [INFO] [stdout] 672 | fn render_engines_chart(&self, x_vals: &Vec, x_axis: Axis, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 672 - fn render_engines_chart(&self, x_vals: &Vec, x_axis: Axis, [INFO] [stdout] 672 + fn render_engines_chart(&self, x_vals: &[f64], x_axis: Axis, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/drm_fdinfo.rs:162:9 [INFO] [stdout] | [INFO] [stdout] 162 | let eng: &mut DrmEngine; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 167 | eng = self.engines.get_mut(eng_name).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `eng` here [INFO] [stdout] | [INFO] [stdout] 162 ~ [INFO] [stdout] 163 | [INFO] [stdout] ... [INFO] [stdout] 166 | } [INFO] [stdout] 167 ~ let eng: &mut DrmEngine = self.engines.get_mut(eng_name).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `x_vals` [INFO] [stdout] --> src/app/main_screen.rs:685:26 [INFO] [stdout] | [INFO] [stdout] 685 | for i in 0..idx { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 685 - for i in 0..idx { [INFO] [stdout] 685 + for in x_vals.iter().take(idx) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/drm_fdinfo.rs:200:9 [INFO] [stdout] | [INFO] [stdout] 200 | let mrg: &mut DrmMemRegion; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 205 | mrg = self.mem_regions.get_mut(mr_name).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `mrg` here [INFO] [stdout] | [INFO] [stdout] 200 ~ [INFO] [stdout] 201 | [INFO] [stdout] ... [INFO] [stdout] 204 | } [INFO] [stdout] 205 ~ let mrg: &mut DrmMemRegion = self.mem_regions.get_mut(mr_name).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `color_idx` is used as a loop counter [INFO] [stdout] --> src/app/main_screen.rs:699:9 [INFO] [stdout] | [INFO] [stdout] 699 | for (en, ed) in dinfo.eng_names.iter().zip(eng_vals.iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (color_idx, (en, ed)) in (1..).zip(dinfo.eng_names.iter().zip(eng_vals.iter()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/app/main_screen.rs:730:42 [INFO] [stdout] | [INFO] [stdout] 730 | fn render_power_chart(&self, x_vals: &Vec, x_axis: Axis, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 730 - fn render_power_chart(&self, x_vals: &Vec, x_axis: Axis, [INFO] [stdout] 730 + fn render_power_chart(&self, x_vals: &[f64], x_axis: Axis, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/drm_fdinfo.rs:267:26 [INFO] [stdout] | [INFO] [stdout] 267 | let en = &k["drm-engine-capacity-".len()..]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/drm_fdinfo.rs:266:20 [INFO] [stdout] | [INFO] [stdout] 266 | } else if k.starts_with("drm-engine-capacity-") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 266 ~ } else if let Some(en) = k.strip_prefix("drm-engine-capacity-") { [INFO] [stdout] 267 ~ info.update_engine(EngKvType::KvCapacity, en, v)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/drm_fdinfo.rs:270:26 [INFO] [stdout] | [INFO] [stdout] 270 | let en = &k["drm-engine-".len()..]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/drm_fdinfo.rs:269:20 [INFO] [stdout] | [INFO] [stdout] 269 | } else if k.starts_with("drm-engine-") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 269 ~ } else if let Some(en) = k.strip_prefix("drm-engine-") { [INFO] [stdout] 270 ~ info.update_engine(EngKvType::KvTime, en, v)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/drm_fdinfo.rs:273:26 [INFO] [stdout] | [INFO] [stdout] 273 | let en = &k["drm-cycles-".len()..]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/drm_fdinfo.rs:272:20 [INFO] [stdout] | [INFO] [stdout] 272 | } else if k.starts_with("drm-cycles-") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 272 ~ } else if let Some(en) = k.strip_prefix("drm-cycles-") { [INFO] [stdout] 273 ~ info.update_engine(EngKvType::KvCycles, en, v)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/app/main_screen.rs:786:42 [INFO] [stdout] | [INFO] [stdout] 786 | fn render_freqs_chart(&self, x_vals: &Vec, x_axis: Axis, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 786 - fn render_freqs_chart(&self, x_vals: &Vec, x_axis: Axis, [INFO] [stdout] 786 + fn render_freqs_chart(&self, x_vals: &[f64], x_axis: Axis, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/drm_fdinfo.rs:276:26 [INFO] [stdout] | [INFO] [stdout] 276 | let en = &k["drm-total-cycles-".len()..]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/drm_fdinfo.rs:275:20 [INFO] [stdout] | [INFO] [stdout] 275 | } else if k.starts_with("drm-total-cycles-") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 275 ~ } else if let Some(en) = k.strip_prefix("drm-total-cycles-") { [INFO] [stdout] 276 ~ info.update_engine(EngKvType::KvTotCycles, en, v)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/drm_fdinfo.rs:279:27 [INFO] [stdout] | [INFO] [stdout] 279 | let mrn = &k["drm-total-".len()..]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/drm_fdinfo.rs:278:20 [INFO] [stdout] | [INFO] [stdout] 278 | } else if k.starts_with("drm-total-") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 278 ~ } else if let Some(mrn) = k.strip_prefix("drm-total-") { [INFO] [stdout] 279 ~ info.update_mem_region(MemRegKvType::KvTotal, mrn, v)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/drm_fdinfo.rs:282:27 [INFO] [stdout] | [INFO] [stdout] 282 | let mrn = &k["drm-shared-".len()..]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/drm_fdinfo.rs:281:20 [INFO] [stdout] | [INFO] [stdout] 281 | } else if k.starts_with("drm-shared-") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 281 ~ } else if let Some(mrn) = k.strip_prefix("drm-shared-") { [INFO] [stdout] 282 ~ info.update_mem_region(MemRegKvType::KvShared, mrn, v)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/drm_fdinfo.rs:285:27 [INFO] [stdout] | [INFO] [stdout] 285 | let mrn = &k["drm-resident-".len()..]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/drm_fdinfo.rs:284:20 [INFO] [stdout] | [INFO] [stdout] 284 | } else if k.starts_with("drm-resident-") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 284 ~ } else if let Some(mrn) = k.strip_prefix("drm-resident-") { [INFO] [stdout] 285 ~ info.update_mem_region(MemRegKvType::KvResident, mrn, v)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/drm_fdinfo.rs:288:27 [INFO] [stdout] | [INFO] [stdout] 288 | let mrn = &k["drm-purgeable-".len()..]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/drm_fdinfo.rs:287:20 [INFO] [stdout] | [INFO] [stdout] 287 | } else if k.starts_with("drm-purgeable-") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 287 ~ } else if let Some(mrn) = k.strip_prefix("drm-purgeable-") { [INFO] [stdout] 288 ~ info.update_mem_region(MemRegKvType::KvPurgeable, mrn, v)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/drm_fdinfo.rs:291:27 [INFO] [stdout] | [INFO] [stdout] 291 | let mrn = &k["drm-active-".len()..]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/drm_fdinfo.rs:290:20 [INFO] [stdout] | [INFO] [stdout] 290 | } else if k.starts_with("drm-active-") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 290 ~ } else if let Some(mrn) = k.strip_prefix("drm-active-") { [INFO] [stdout] 291 ~ info.update_mem_region(MemRegKvType::KvActive, mrn, v)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/proc_info.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | / if nval.is_none() { [INFO] [stdout] 34 | | return None; [INFO] [stdout] 35 | | } [INFO] [stdout] | |_____________^ help: replace it with: `nval.as_ref()?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/app/main_screen.rs:863:42 [INFO] [stdout] | [INFO] [stdout] 863 | fn render_temps_chart(&self, x_vals: &Vec, x_axis: Axis, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 863 - fn render_temps_chart(&self, x_vals: &Vec, x_axis: Axis, [INFO] [stdout] 863 + fn render_temps_chart(&self, x_vals: &[f64], x_axis: Axis, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/proc_info.rs:49:17 [INFO] [stdout] | [INFO] [stdout] 49 | if !fp.chars().next().unwrap().is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fp.chars().next().unwrap().is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `color_idx` is used as a loop counter [INFO] [stdout] --> src/app/main_screen.rs:884:9 [INFO] [stdout] | [INFO] [stdout] 884 | for (tmp, td) in last_tmps.iter().zip(tmp_vals.iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (color_idx, (tmp, td)) in (1..).zip(last_tmps.iter().zip(tmp_vals.iter()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/proc_info.rs:112:13 [INFO] [stdout] | [INFO] [stdout] 112 | if !pid.chars().next().unwrap().is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `pid.chars().next().unwrap().is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/app/main_screen.rs:915:41 [INFO] [stdout] | [INFO] [stdout] 915 | fn render_fans_chart(&self, x_vals: &Vec, x_axis: Axis, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 915 - fn render_fans_chart(&self, x_vals: &Vec, x_axis: Axis, [INFO] [stdout] 915 + fn render_fans_chart(&self, x_vals: &[f64], x_axis: Axis, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `color_idx` is used as a loop counter [INFO] [stdout] --> src/app/main_screen.rs:936:9 [INFO] [stdout] | [INFO] [stdout] 936 | for (fan, fd) in last_fans.iter().zip(fan_vals.iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (color_idx, (fan, fd)) in (1..).zip(last_fans.iter().zip(fan_vals.iter()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/proc_info.rs:246:23 [INFO] [stdout] | [INFO] [stdout] 246 | pub fn from(npid: &String) -> Result [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 246 ~ pub fn from(npid: &str) -> Result [INFO] [stdout] 247 | { [INFO] [stdout] ... [INFO] [stdout] 251 | cmdline: String::new(), [INFO] [stdout] 252 ~ proc_dir: Path::new("/proc").join(npid), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/app/main_screen.rs:1435:5 [INFO] [stdout] | [INFO] [stdout] 1435 | / pub fn new(model: Rc>) -> Box [INFO] [stdout] 1436 | | { [INFO] [stdout] 1437 | | Box::new(MainScreen { [INFO] [stdout] 1438 | | model, [INFO] [stdout] ... | [INFO] [stdout] 1442 | | }) [INFO] [stdout] 1443 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> src/drm_clients.rs:393:9 [INFO] [stdout] | [INFO] [stdout] 393 | / if !map.contains_key(&dev) { [INFO] [stdout] 394 | | let mut vlst: Vec = Vec::new(); [INFO] [stdout] 395 | | vlst.push(cli); [INFO] [stdout] 396 | | map.insert(dev, Rc::new(RefCell::new(vlst))); [INFO] [stdout] ... | [INFO] [stdout] 399 | | vref.push(cli); [INFO] [stdout] 400 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: consider using the `Entry` API: https://doc.rust-lang.org/std/collections/struct.HashMap.html#entry-api [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/drm_clients.rs:394:13 [INFO] [stdout] | [INFO] [stdout] 394 | / let mut vlst: Vec = Vec::new(); [INFO] [stdout] 395 | | vlst.push(cli); [INFO] [stdout] | |___________________________^ help: consider using the `vec![]` macro: `let vlst: Vec = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.sel.client_key` after checking its variant with `is_some` [INFO] [stdout] --> src/app/drm_client_screen.rs:120:17 [INFO] [stdout] | [INFO] [stdout] 118 | let rows = if self.sel.client_key.is_some() { [INFO] [stdout] | -------------------------------- help: try: `if let Some() = &self.sel.client_key` [INFO] [stdout] 119 | let (drm_minor, client_id) = [INFO] [stdout] 120 | self.sel.client_key.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.sel.client_key` after checking its variant with `is_none` [INFO] [stdout] --> src/app/drm_client_screen.rs:175:48 [INFO] [stdout] | [INFO] [stdout] 172 | let sel_cli = if self.sel.client_key.is_none() { [INFO] [stdout] | -------------------------------- help: try: `if let Some() = self.sel.client_key` [INFO] [stdout] ... [INFO] [stdout] 175 | di.find_client_stats(self.sel.pid, self.sel.client_key.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/app/drm_client_screen.rs:379:44 [INFO] [stdout] | [INFO] [stdout] 379 | fn render_meminfo_chart(&self, x_vals: &Vec, x_axis: Axis, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 379 - fn render_meminfo_chart(&self, x_vals: &Vec, x_axis: Axis, [INFO] [stdout] 379 + fn render_meminfo_chart(&self, x_vals: &[f64], x_axis: Axis, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `x_vals` [INFO] [stdout] --> src/app/drm_client_screen.rs:394:22 [INFO] [stdout] | [INFO] [stdout] 394 | for i in 0..idx { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 394 - for i in 0..idx { [INFO] [stdout] 394 + for in x_vals.iter().take(idx) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `x_vals` [INFO] [stdout] --> src/app/drm_client_screen.rs:403:18 [INFO] [stdout] | [INFO] [stdout] 403 | for i in idx..nr_vals { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 403 - for i in idx..nr_vals { [INFO] [stdout] 403 + for (i, ) in x_vals.iter().enumerate().take(nr_vals).skip(idx) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/app_data.rs:54:16 [INFO] [stdout] | [INFO] [stdout] 54 | if !dinfo.power.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `dinfo.power.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/app/drm_client_screen.rs:447:23 [INFO] [stdout] | [INFO] [stdout] 447 | Span::raw(format!("{}", App::short_mem_string(miny))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `App::short_mem_string(miny).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/app_data.rs:58:16 [INFO] [stdout] | [INFO] [stdout] 58 | if !dinfo.mem_info.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dinfo.mem_info.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/app/drm_client_screen.rs:448:23 [INFO] [stdout] | [INFO] [stdout] 448 | Span::raw(format!("{}", App::short_mem_string((miny + maxy) / 2))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `App::short_mem_string((miny + maxy) / 2).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `dinfo.power` after checking its variant with `is_none` [INFO] [stdout] --> src/app_data.rs:55:26 [INFO] [stdout] | [INFO] [stdout] 54 | if !dinfo.power.is_none() { [INFO] [stdout] | --------------------- the check is happening here [INFO] [stdout] 55 | let np = dinfo.power.as_ref().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `dinfo.mem_info` after checking its variant with `is_none` [INFO] [stdout] --> src/app_data.rs:59:27 [INFO] [stdout] | [INFO] [stdout] 58 | if !dinfo.mem_info.is_none() { [INFO] [stdout] | ------------------------ the check is happening here [INFO] [stdout] 59 | let nmi = dinfo.mem_info.as_ref().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/app/drm_client_screen.rs:449:23 [INFO] [stdout] | [INFO] [stdout] 449 | Span::raw(format!("{}", App::short_mem_string(maxy))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `App::short_mem_string(maxy).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/app_data.rs:48:20 [INFO] [stdout] | [INFO] [stdout] 48 | eng_names: &Vec, dinfo: &DrmDeviceInfo) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 48 - eng_names: &Vec, dinfo: &DrmDeviceInfo) [INFO] [stdout] 48 + eng_names: &[String], dinfo: &DrmDeviceInfo) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/app/drm_client_screen.rs:466:44 [INFO] [stdout] | [INFO] [stdout] 466 | fn render_engines_chart(&self, x_vals: &Vec, x_axis: Axis, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 466 - fn render_engines_chart(&self, x_vals: &Vec, x_axis: Axis, [INFO] [stdout] 466 + fn render_engines_chart(&self, x_vals: &[f64], x_axis: Axis, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `x_vals` [INFO] [stdout] --> src/app/drm_client_screen.rs:479:26 [INFO] [stdout] | [INFO] [stdout] 479 | for i in 0..idx { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 479 - for i in 0..idx { [INFO] [stdout] 479 + for in x_vals.iter().take(idx) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app_data.rs:69:30 [INFO] [stdout] | [INFO] [stdout] 69 | limited_vec_push(&mut est, dinfo.eng_utilization(en)); [INFO] [stdout] | ^^^^^^^^ help: change this to: `est` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/app_data.rs:80:23 [INFO] [stdout] | [INFO] [stdout] 80 | fn new(eng_names: &Vec) -> AppDataDeviceStats [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 80 - fn new(eng_names: &Vec) -> AppDataDeviceStats [INFO] [stdout] 80 + fn new(eng_names: &[String]) -> AppDataDeviceStats [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `color_idx` is used as a loop counter [INFO] [stdout] --> src/app/drm_client_screen.rs:493:9 [INFO] [stdout] | [INFO] [stdout] 493 | for (en, ed) in cli.eng_usage.keys().sorted().zip(eng_vals.iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (color_idx, (en, ed)) in (1..).zip(cli.eng_usage.keys().sorted().zip(eng_vals.iter()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/app/drm_client_screen.rs:524:40 [INFO] [stdout] | [INFO] [stdout] 524 | fn render_cpu_chart(&self, x_vals: &Vec, x_axis: Axis, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 524 - fn render_cpu_chart(&self, x_vals: &Vec, x_axis: Axis, [INFO] [stdout] 524 + fn render_cpu_chart(&self, x_vals: &[f64], x_axis: Axis, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `x_vals` [INFO] [stdout] --> src/app/drm_client_screen.rs:534:22 [INFO] [stdout] | [INFO] [stdout] 534 | for i in 0..idx { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 534 - for i in 0..idx { [INFO] [stdout] 534 + for in x_vals.iter().take(idx) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `x_vals` [INFO] [stdout] --> src/app/drm_client_screen.rs:538:18 [INFO] [stdout] | [INFO] [stdout] 538 | for i in idx..nr_vals { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 538 - for i in idx..nr_vals { [INFO] [stdout] 538 + for (i, ) in x_vals.iter().enumerate().take(nr_vals).skip(idx) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/app/drm_client_screen.rs:627:5 [INFO] [stdout] | [INFO] [stdout] 627 | / pub fn new(model: Rc>, [INFO] [stdout] 628 | | sel: DrmClientSelected) -> Box [INFO] [stdout] 629 | | { [INFO] [stdout] 630 | | Box::new(DrmClientScreen { [INFO] [stdout] ... | [INFO] [stdout] 635 | | }) [INFO] [stdout] 636 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/app_data.rs:218:20 [INFO] [stdout] | [INFO] [stdout] 218 | eng_names: &Vec, cinfo: &DrmClientInfo) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 218 - eng_names: &Vec, cinfo: &DrmClientInfo) [INFO] [stdout] 218 + eng_names: &[String], cinfo: &DrmClientInfo) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app_data.rs:227:30 [INFO] [stdout] | [INFO] [stdout] 227 | limited_vec_push(&mut est, cinfo.eng_utilization(en)); [INFO] [stdout] | ^^^^^^^^ help: change this to: `est` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/app_data.rs:234:24 [INFO] [stdout] | [INFO] [stdout] 234 | fn from(eng_names: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 234 - fn from(eng_names: &Vec, [INFO] [stdout] 234 + fn from(eng_names: &[String], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/plotter.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | / fn plot_chart(&self, out_file: &str, title: &str, [INFO] [stdout] 53 | | x_desc: &str, y_desc: &str, x_max: f64, y_max: f64, [INFO] [stdout] 54 | | datasets: &Vec) -> Result<()> [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/plotter.rs:54:19 [INFO] [stdout] | [INFO] [stdout] 54 | datasets: &Vec) -> Result<()> [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 54 - datasets: &Vec) -> Result<()> [INFO] [stdout] 54 + datasets: &[StatData]) -> Result<()> [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/plotter.rs:76:21 [INFO] [stdout] | [INFO] [stdout] 76 | ds.points.iter().map(|&pt| pt), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `ds.points.iter().copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/plotter.rs:105:18 [INFO] [stdout] | [INFO] [stdout] 105 | !self.dev_slots.iter().any(|ds| di.pci_dev == *ds) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.dev_slots.contains(&di.pci_dev)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/plotter.rs:149:21 [INFO] [stdout] | [INFO] [stdout] 149 | / let mut nv = Vec::new(); [INFO] [stdout] 150 | | nv.push(StatData::new("MIN")); [INFO] [stdout] 151 | | nv.push(StatData::new("MAX")); [INFO] [stdout] 152 | | nv.push(StatData::new("REQ")); [INFO] [stdout] 153 | | nv.push(StatData::new("ACT")); [INFO] [stdout] | |__________________________________________________^ help: consider using the `vec![]` macro: `let nv = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/app_data.rs:314:9 [INFO] [stdout] | [INFO] [stdout] 314 | / for cst in self.clis_stats.iter() { [INFO] [stdout] 315 | | if cst.is_single_client() && [INFO] [stdout] 316 | | cst.pid == pid && cst.client_key() == client_key { [INFO] [stdout] 317 | | return Some(cst); [INFO] [stdout] ... | [INFO] [stdout] 321 | | None [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] = note: `#[warn(clippy::manual_find)]` on by default [INFO] [stdout] help: replace with an iterator [INFO] [stdout] | [INFO] [stdout] 314 ~ self.clis_stats.iter().find(|&cst| cst.is_single_client() && [INFO] [stdout] 315 + cst.pid == pid && cst.client_key() == client_key).map(|v| v as _) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/app_data.rs:400:28 [INFO] [stdout] | [INFO] [stdout] 400 | fn fname_from(devnode: &String) -> &str [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 400 - fn fname_from(devnode: &String) -> &str [INFO] [stdout] 400 + fn fname_from(devnode: &str) -> &str [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DrmDeviceType` which implements the `Copy` trait [INFO] [stdout] --> src/app_data.rs:438:23 [INFO] [stdout] | [INFO] [stdout] 438 | dev_type: dinfo.dev_type.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `dinfo.dev_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/app_data.rs:504:31 [INFO] [stdout] | [INFO] [stdout] 504 | fn get_device(&self, dev: &String) -> Option<&AppDataDeviceState>; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/app_data.rs:554:9 [INFO] [stdout] | [INFO] [stdout] 554 | / for ds in state.devs_state.iter() { [INFO] [stdout] 555 | | if ds.pci_dev == *dev { [INFO] [stdout] 556 | | return Some(ds); [INFO] [stdout] ... | [INFO] [stdout] 560 | | None [INFO] [stdout] | |____________^ help: replace with an iterator: `state.devs_state.iter().find(|&ds| ds.pci_dev == *dev).map(|v| v as _)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/app_data.rs:728:9 [INFO] [stdout] | [INFO] [stdout] 728 | / for ds in self.state.devs_state.iter() { [INFO] [stdout] 729 | | if ds.pci_dev == *dev { [INFO] [stdout] 730 | | return Some(ds); [INFO] [stdout] ... | [INFO] [stdout] 734 | | None [INFO] [stdout] | |____________^ help: replace with an iterator: `self.state.devs_state.iter().find(|&ds| ds.pci_dev == *dev).map(|v| v as _)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app_data.rs:755:57 [INFO] [stdout] | [INFO] [stdout] 755 | if let Some(dst) = self.state.remove_device(&d) { [INFO] [stdout] | ^^ help: change this to: `d` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/app/main_screen.rs:90:40 [INFO] [stdout] | [INFO] [stdout] 90 | fn exec_next(&mut self, nr_charts: &Vec) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 90 - fn exec_next(&mut self, nr_charts: &Vec) [INFO] [stdout] 90 + fn exec_next(&mut self, nr_charts: &[u8]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/app/main_screen.rs:104:40 [INFO] [stdout] | [INFO] [stdout] 104 | fn exec_prev(&mut self, nr_charts: &Vec) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 104 - fn exec_prev(&mut self, nr_charts: &Vec) [INFO] [stdout] 104 + fn exec_prev(&mut self, nr_charts: &[u8]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `row_nr` is used as a loop counter [INFO] [stdout] --> src/app/main_screen.rs:583:13 [INFO] [stdout] | [INFO] [stdout] 583 | for (cli, area) in cinfos.iter().zip(clis_area.iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (row_nr, (cli, area)) in cinfos.iter().zip(clis_area.iter()).enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/app/main_screen.rs:612:44 [INFO] [stdout] | [INFO] [stdout] 612 | fn render_meminfo_chart(&self, x_vals: &Vec, x_axis: Axis, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 612 - fn render_meminfo_chart(&self, x_vals: &Vec, x_axis: Axis, [INFO] [stdout] 612 + fn render_meminfo_chart(&self, x_vals: &[f64], x_axis: Axis, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/app/main_screen.rs:653:23 [INFO] [stdout] | [INFO] [stdout] 653 | Span::raw(format!("{}", App::short_mem_string(miny))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `App::short_mem_string(miny).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/app/main_screen.rs:654:23 [INFO] [stdout] | [INFO] [stdout] 654 | Span::raw(format!("{}", App::short_mem_string((miny + maxy) / 2))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `App::short_mem_string((miny + maxy) / 2).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/app/main_screen.rs:655:23 [INFO] [stdout] | [INFO] [stdout] 655 | Span::raw(format!("{}", App::short_mem_string(maxy))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `App::short_mem_string(maxy).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/app/main_screen.rs:672:44 [INFO] [stdout] | [INFO] [stdout] 672 | fn render_engines_chart(&self, x_vals: &Vec, x_axis: Axis, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 672 - fn render_engines_chart(&self, x_vals: &Vec, x_axis: Axis, [INFO] [stdout] 672 + fn render_engines_chart(&self, x_vals: &[f64], x_axis: Axis, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `x_vals` [INFO] [stdout] --> src/app/main_screen.rs:685:26 [INFO] [stdout] | [INFO] [stdout] 685 | for i in 0..idx { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 685 - for i in 0..idx { [INFO] [stdout] 685 + for in x_vals.iter().take(idx) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `color_idx` is used as a loop counter [INFO] [stdout] --> src/app/main_screen.rs:699:9 [INFO] [stdout] | [INFO] [stdout] 699 | for (en, ed) in dinfo.eng_names.iter().zip(eng_vals.iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (color_idx, (en, ed)) in (1..).zip(dinfo.eng_names.iter().zip(eng_vals.iter()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/app/main_screen.rs:730:42 [INFO] [stdout] | [INFO] [stdout] 730 | fn render_power_chart(&self, x_vals: &Vec, x_axis: Axis, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 730 - fn render_power_chart(&self, x_vals: &Vec, x_axis: Axis, [INFO] [stdout] 730 + fn render_power_chart(&self, x_vals: &[f64], x_axis: Axis, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/app/main_screen.rs:786:42 [INFO] [stdout] | [INFO] [stdout] 786 | fn render_freqs_chart(&self, x_vals: &Vec, x_axis: Axis, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 786 - fn render_freqs_chart(&self, x_vals: &Vec, x_axis: Axis, [INFO] [stdout] 786 + fn render_freqs_chart(&self, x_vals: &[f64], x_axis: Axis, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/app/main_screen.rs:863:42 [INFO] [stdout] | [INFO] [stdout] 863 | fn render_temps_chart(&self, x_vals: &Vec, x_axis: Axis, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 863 - fn render_temps_chart(&self, x_vals: &Vec, x_axis: Axis, [INFO] [stdout] 863 + fn render_temps_chart(&self, x_vals: &[f64], x_axis: Axis, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `color_idx` is used as a loop counter [INFO] [stdout] --> src/app/main_screen.rs:884:9 [INFO] [stdout] | [INFO] [stdout] 884 | for (tmp, td) in last_tmps.iter().zip(tmp_vals.iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (color_idx, (tmp, td)) in (1..).zip(last_tmps.iter().zip(tmp_vals.iter()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/app/main_screen.rs:915:41 [INFO] [stdout] | [INFO] [stdout] 915 | fn render_fans_chart(&self, x_vals: &Vec, x_axis: Axis, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 915 - fn render_fans_chart(&self, x_vals: &Vec, x_axis: Axis, [INFO] [stdout] 915 + fn render_fans_chart(&self, x_vals: &[f64], x_axis: Axis, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `color_idx` is used as a loop counter [INFO] [stdout] --> src/app/main_screen.rs:936:9 [INFO] [stdout] | [INFO] [stdout] 936 | for (fan, fd) in last_fans.iter().zip(fan_vals.iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (color_idx, (fan, fd)) in (1..).zip(last_fans.iter().zip(fan_vals.iter()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args.dev_slots` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:217:21 [INFO] [stdout] | [INFO] [stdout] 216 | if args.dev_slots.is_some() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = &args.dev_slots` [INFO] [stdout] 217 | slots_str = args.dev_slots.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args.drv_options` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:223:21 [INFO] [stdout] | [INFO] [stdout] 222 | if args.drv_options.is_some() { [INFO] [stdout] | ----------------------------- help: try: `if let Some() = &args.drv_options` [INFO] [stdout] 223 | for dopt in args.drv_options.as_ref().unwrap().iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:202:5 [INFO] [stdout] | [INFO] [stdout] 202 | let base_pid: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `base_pid` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 202 ~ [INFO] [stdout] 203 ~ let base_pid: String = if args.pid.is_some() { [INFO] [stdout] 204 ~ args.pid.clone().unwrap() [INFO] [stdout] 205 | } else { [INFO] [stdout] ... [INFO] [stdout] 209 | let euid: u32 = unsafe { libc::geteuid() }; [INFO] [stdout] 210 ~ if euid == 0 { String::from("1") } else { String::from("") } [INFO] [stdout] 211 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/main.rs:278:17 [INFO] [stdout] | [INFO] [stdout] 278 | fnstr.push_str("-"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `fnstr.push('-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/app/main_screen.rs:1435:5 [INFO] [stdout] | [INFO] [stdout] 1435 | / pub fn new(model: Rc>) -> Box [INFO] [stdout] 1436 | | { [INFO] [stdout] 1437 | | Box::new(MainScreen { [INFO] [stdout] 1438 | | model, [INFO] [stdout] ... | [INFO] [stdout] 1442 | | }) [INFO] [stdout] 1443 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.sel.client_key` after checking its variant with `is_some` [INFO] [stdout] --> src/app/drm_client_screen.rs:120:17 [INFO] [stdout] | [INFO] [stdout] 118 | let rows = if self.sel.client_key.is_some() { [INFO] [stdout] | -------------------------------- help: try: `if let Some() = &self.sel.client_key` [INFO] [stdout] 119 | let (drm_minor, client_id) = [INFO] [stdout] 120 | self.sel.client_key.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.sel.client_key` after checking its variant with `is_none` [INFO] [stdout] --> src/app/drm_client_screen.rs:175:48 [INFO] [stdout] | [INFO] [stdout] 172 | let sel_cli = if self.sel.client_key.is_none() { [INFO] [stdout] | -------------------------------- help: try: `if let Some() = self.sel.client_key` [INFO] [stdout] ... [INFO] [stdout] 175 | di.find_client_stats(self.sel.pid, self.sel.client_key.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/app/drm_client_screen.rs:379:44 [INFO] [stdout] | [INFO] [stdout] 379 | fn render_meminfo_chart(&self, x_vals: &Vec, x_axis: Axis, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 379 - fn render_meminfo_chart(&self, x_vals: &Vec, x_axis: Axis, [INFO] [stdout] 379 + fn render_meminfo_chart(&self, x_vals: &[f64], x_axis: Axis, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `x_vals` [INFO] [stdout] --> src/app/drm_client_screen.rs:394:22 [INFO] [stdout] | [INFO] [stdout] 394 | for i in 0..idx { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 394 - for i in 0..idx { [INFO] [stdout] 394 + for in x_vals.iter().take(idx) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `x_vals` [INFO] [stdout] --> src/app/drm_client_screen.rs:403:18 [INFO] [stdout] | [INFO] [stdout] 403 | for i in idx..nr_vals { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 403 - for i in idx..nr_vals { [INFO] [stdout] 403 + for (i, ) in x_vals.iter().enumerate().take(nr_vals).skip(idx) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/app/drm_client_screen.rs:447:23 [INFO] [stdout] | [INFO] [stdout] 447 | Span::raw(format!("{}", App::short_mem_string(miny))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `App::short_mem_string(miny).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/app/drm_client_screen.rs:448:23 [INFO] [stdout] | [INFO] [stdout] 448 | Span::raw(format!("{}", App::short_mem_string((miny + maxy) / 2))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `App::short_mem_string((miny + maxy) / 2).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/app/drm_client_screen.rs:449:23 [INFO] [stdout] | [INFO] [stdout] 449 | Span::raw(format!("{}", App::short_mem_string(maxy))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `App::short_mem_string(maxy).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/app/drm_client_screen.rs:466:44 [INFO] [stdout] | [INFO] [stdout] 466 | fn render_engines_chart(&self, x_vals: &Vec, x_axis: Axis, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 466 - fn render_engines_chart(&self, x_vals: &Vec, x_axis: Axis, [INFO] [stdout] 466 + fn render_engines_chart(&self, x_vals: &[f64], x_axis: Axis, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `x_vals` [INFO] [stdout] --> src/app/drm_client_screen.rs:479:26 [INFO] [stdout] | [INFO] [stdout] 479 | for i in 0..idx { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 479 - for i in 0..idx { [INFO] [stdout] 479 + for in x_vals.iter().take(idx) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `color_idx` is used as a loop counter [INFO] [stdout] --> src/app/drm_client_screen.rs:493:9 [INFO] [stdout] | [INFO] [stdout] 493 | for (en, ed) in cli.eng_usage.keys().sorted().zip(eng_vals.iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (color_idx, (en, ed)) in (1..).zip(cli.eng_usage.keys().sorted().zip(eng_vals.iter()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/app/drm_client_screen.rs:524:40 [INFO] [stdout] | [INFO] [stdout] 524 | fn render_cpu_chart(&self, x_vals: &Vec, x_axis: Axis, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 524 - fn render_cpu_chart(&self, x_vals: &Vec, x_axis: Axis, [INFO] [stdout] 524 + fn render_cpu_chart(&self, x_vals: &[f64], x_axis: Axis, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `x_vals` [INFO] [stdout] --> src/app/drm_client_screen.rs:534:22 [INFO] [stdout] | [INFO] [stdout] 534 | for i in 0..idx { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 534 - for i in 0..idx { [INFO] [stdout] 534 + for in x_vals.iter().take(idx) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `x_vals` [INFO] [stdout] --> src/app/drm_client_screen.rs:538:18 [INFO] [stdout] | [INFO] [stdout] 538 | for i in idx..nr_vals { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 538 - for i in idx..nr_vals { [INFO] [stdout] 538 + for (i, ) in x_vals.iter().enumerate().take(nr_vals).skip(idx) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/app/drm_client_screen.rs:627:5 [INFO] [stdout] | [INFO] [stdout] 627 | / pub fn new(model: Rc>, [INFO] [stdout] 628 | | sel: DrmClientSelected) -> Box [INFO] [stdout] 629 | | { [INFO] [stdout] 630 | | Box::new(DrmClientScreen { [INFO] [stdout] ... | [INFO] [stdout] 635 | | }) [INFO] [stdout] 636 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/plotter.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | / fn plot_chart(&self, out_file: &str, title: &str, [INFO] [stdout] 53 | | x_desc: &str, y_desc: &str, x_max: f64, y_max: f64, [INFO] [stdout] 54 | | datasets: &Vec) -> Result<()> [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/plotter.rs:54:19 [INFO] [stdout] | [INFO] [stdout] 54 | datasets: &Vec) -> Result<()> [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 54 - datasets: &Vec) -> Result<()> [INFO] [stdout] 54 + datasets: &[StatData]) -> Result<()> [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/plotter.rs:76:21 [INFO] [stdout] | [INFO] [stdout] 76 | ds.points.iter().map(|&pt| pt), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `ds.points.iter().copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/plotter.rs:105:18 [INFO] [stdout] | [INFO] [stdout] 105 | !self.dev_slots.iter().any(|ds| di.pci_dev == *ds) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.dev_slots.contains(&di.pci_dev)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/plotter.rs:149:21 [INFO] [stdout] | [INFO] [stdout] 149 | / let mut nv = Vec::new(); [INFO] [stdout] 150 | | nv.push(StatData::new("MIN")); [INFO] [stdout] 151 | | nv.push(StatData::new("MAX")); [INFO] [stdout] 152 | | nv.push(StatData::new("REQ")); [INFO] [stdout] 153 | | nv.push(StatData::new("ACT")); [INFO] [stdout] | |__________________________________________________^ help: consider using the `vec![]` macro: `let nv = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args.dev_slots` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:217:21 [INFO] [stdout] | [INFO] [stdout] 216 | if args.dev_slots.is_some() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = &args.dev_slots` [INFO] [stdout] 217 | slots_str = args.dev_slots.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args.drv_options` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:223:21 [INFO] [stdout] | [INFO] [stdout] 222 | if args.drv_options.is_some() { [INFO] [stdout] | ----------------------------- help: try: `if let Some() = &args.drv_options` [INFO] [stdout] 223 | for dopt in args.drv_options.as_ref().unwrap().iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:202:5 [INFO] [stdout] | [INFO] [stdout] 202 | let base_pid: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `base_pid` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 202 ~ [INFO] [stdout] 203 ~ let base_pid: String = if args.pid.is_some() { [INFO] [stdout] 204 ~ args.pid.clone().unwrap() [INFO] [stdout] 205 | } else { [INFO] [stdout] ... [INFO] [stdout] 209 | let euid: u32 = unsafe { libc::geteuid() }; [INFO] [stdout] 210 ~ if euid == 0 { String::from("1") } else { String::from("") } [INFO] [stdout] 211 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/main.rs:278:17 [INFO] [stdout] | [INFO] [stdout] 278 | fnstr.push_str("-"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `fnstr.push('-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 20.87s [INFO] running `Command { std: "docker" "inspect" "2b7471c421fc5cba8443788a90b56ddc78598c551ab340113aa72f1012cbcf0a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2b7471c421fc5cba8443788a90b56ddc78598c551ab340113aa72f1012cbcf0a", kill_on_drop: false }` [INFO] [stdout] 2b7471c421fc5cba8443788a90b56ddc78598c551ab340113aa72f1012cbcf0a