[INFO] fetching crate qldb 3.2.9... [INFO] linting qldb-3.2.9 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate qldb 3.2.9 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate qldb 3.2.9 [INFO] finished tweaking crates.io crate qldb 3.2.9 [INFO] tweaked toml for crates.io crate qldb 3.2.9 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate qldb 3.2.9 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 211 packages to latest compatible versions [INFO] [stderr] Adding async-channel v1.9.0 (available: v2.5.0) [INFO] [stderr] Adding async-io v1.13.0 (available: v2.6.0) [INFO] [stderr] Adding async-lock v2.8.0 (available: v3.4.2) [INFO] [stderr] Adding generic-array v0.14.7 (available: v0.14.9) [INFO] [stderr] Adding rand v0.8.5 (available: v0.10.0) [INFO] [stderr] Adding subtle v2.4.1 (available: v2.6.1) [INFO] [stderr] Adding thiserror v1.0.69 (available: v2.0.18) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `rusoto_core` dependency) [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `rusoto_qldb_session` dependency) [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded crypto-mac v0.11.1 [INFO] [stderr] Downloaded xml-rs v0.8.28 [INFO] [stderr] Downloaded md-5 v0.9.1 [INFO] [stderr] Downloaded rusoto_core v0.48.0 [INFO] [stderr] Downloaded rusoto_qldb_session v0.48.0 [INFO] [stderr] Downloaded rusoto_signature v0.48.0 [INFO] [stderr] Downloaded hermit-abi v0.3.9 [INFO] [stderr] Downloaded async-attributes v1.1.2 [INFO] [stderr] Downloaded rusoto_credential v0.48.0 [INFO] [stderr] Downloaded hyper-rustls v0.23.2 [INFO] [stderr] Downloaded async-compat v0.2.5 [INFO] [stderr] Downloaded io-lifetimes v1.0.11 [INFO] [stderr] Downloaded socket2 v0.4.10 [INFO] [stderr] Downloaded webpki v0.22.4 [INFO] [stderr] Downloaded async-io v1.13.0 [INFO] [stderr] Downloaded tokio-rustls v0.23.4 [INFO] [stderr] Downloaded hmac v0.11.0 [INFO] [stderr] Downloaded rustix v0.37.28 [INFO] [stderr] Downloaded async-lock v2.8.0 [INFO] [stderr] Downloaded bigdecimal v0.4.10 [INFO] [stderr] Downloaded ion-binary-rs v0.8.13 [INFO] [stderr] Downloaded rustls v0.20.9 [INFO] [stderr] Downloaded linux-raw-sys v0.3.8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4e34faf6e51a53a2ec03b4a2cd2b5debfc6c4ae053679114b41e7429942d9bbf [INFO] running `Command { std: "docker" "start" "-a" "4e34faf6e51a53a2ec03b4a2cd2b5debfc6c4ae053679114b41e7429942d9bbf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4e34faf6e51a53a2ec03b4a2cd2b5debfc6c4ae053679114b41e7429942d9bbf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4e34faf6e51a53a2ec03b4a2cd2b5debfc6c4ae053679114b41e7429942d9bbf", kill_on_drop: false }` [INFO] [stdout] 4e34faf6e51a53a2ec03b4a2cd2b5debfc6c4ae053679114b41e7429942d9bbf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 019af9025e716dcdfe555dd224ada1ce7932b04c1dda4a6eeba9222c6e2f24f9 [INFO] running `Command { std: "docker" "start" "-a" "019af9025e716dcdfe555dd224ada1ce7932b04c1dda4a6eeba9222c6e2f24f9", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `rusoto_core` dependency) [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `rusoto_qldb_session` dependency) [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking cpufeatures v0.2.17 [INFO] [stderr] Compiling rustls v0.20.9 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Compiling semver v1.0.27 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Checking shlex v1.3.0 [INFO] [stderr] Compiling libm v0.2.16 [INFO] [stderr] Compiling bigdecimal v0.4.10 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Compiling rustix v0.37.28 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling thiserror v1.0.69 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Checking rustls-native-certs v0.6.3 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Compiling eyre v0.6.12 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Compiling rusoto_core v0.48.0 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking xml-rs v0.8.28 [INFO] [stderr] Checking waker-fn v1.2.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking async-lock v2.8.0 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking indenter v0.3.4 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking crypto-mac v0.11.1 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking hmac v0.11.0 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking md-5 v0.9.1 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking socket2 v0.6.3 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling tokio-macros v2.6.1 [INFO] [stderr] Compiling futures-macro v0.3.32 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling async-attributes v1.1.2 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Checking webpki v0.22.4 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking futures-executor v0.3.32 [INFO] [stderr] Checking bytes v1.11.1 [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stderr] Checking futures v0.3.32 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking ion-binary-rs v0.8.13 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking tokio-rustls v0.23.4 [INFO] [stderr] Checking async-global-executor v2.4.1 [INFO] [stderr] Checking async-compat v0.2.5 [INFO] [stderr] Checking async-std v1.13.2 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking rusoto_credential v0.48.0 [INFO] [stderr] Checking hyper-rustls v0.23.2 [INFO] [stderr] Checking rusoto_signature v0.48.0 [INFO] [stderr] Checking rusoto_qldb_session v0.48.0 [INFO] [stderr] Checking qldb v3.2.9 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `log::error` [INFO] [stdout] --> src/session_pool/mod.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use log::error; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `log::error` [INFO] [stdout] --> src/session_pool/mod.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use log::error; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/cursor.rs:102:27 [INFO] [stdout] | [INFO] [stdout] 102 | result.extend(values.into_iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/collect.rs:416:17 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 102 - result.extend(values.into_iter()); [INFO] [stdout] 102 + result.extend(values); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/cursor.rs:102:27 [INFO] [stdout] | [INFO] [stdout] 102 | result.extend(values.into_iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/collect.rs:416:17 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 102 - result.extend(values.into_iter()); [INFO] [stdout] 102 + result.extend(values); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/query_builder.rs:142:32 [INFO] [stdout] | [INFO] [stdout] 142 | pub fn get_cursor(self) -> QldbResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/types.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | SendCommandError(#[from] RusotoError), [INFO] [stdout] | ------------------------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `types::QldbError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/query_builder.rs:185:59 [INFO] [stdout] | [INFO] [stdout] 185 | fn valueholders_to_ionvalues(values: Vec) -> QldbResult> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/types.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | SendCommandError(#[from] RusotoError), [INFO] [stdout] | ------------------------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `types::QldbError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/query_builder.rs:142:32 [INFO] [stdout] | [INFO] [stdout] 142 | pub fn get_cursor(self) -> QldbResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/types.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | SendCommandError(#[from] RusotoError), [INFO] [stdout] | ------------------------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `types::QldbError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/query_builder.rs:185:59 [INFO] [stdout] | [INFO] [stdout] 185 | fn valueholders_to_ionvalues(values: Vec) -> QldbResult> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/types.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | SendCommandError(#[from] RusotoError), [INFO] [stdout] | ------------------------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `types::QldbError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of an `Arc` that is not `Send` and `Sync` [INFO] [stdout] --> src/session_pool/session_pool_thread.rs:34:28 [INFO] [stdout] | [INFO] [stdout] 34 | let executor = Arc::new(LocalExecutor::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Arc>` is not `Send` and `Sync` as `LocalExecutor<'_>` is neither `Send` nor `Sync` [INFO] [stdout] = help: if the `Arc` will not be used across threads replace it with an `Rc` [INFO] [stdout] = help: otherwise make `LocalExecutor<'_>` `Send` and `Sync` or consider a wrapper type such as `Mutex` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync [INFO] [stdout] = note: `#[warn(clippy::arc_with_non_send_sync)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of an `Arc` that is not `Send` and `Sync` [INFO] [stdout] --> src/session_pool/session_pool_thread.rs:41:17 [INFO] [stdout] | [INFO] [stdout] 41 | Arc::new(move |fut| executor.spawn(Box::pin(fut)).detach()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Arc<{closure@session_pool_thread.rs:41:26}>` is not `Send` and `Sync` as `{closure@session_pool_thread.rs:41:26}` is neither `Send` nor `Sync` [INFO] [stdout] = help: if the `Arc` will not be used across threads replace it with an `Rc` [INFO] [stdout] = help: otherwise make `{closure@session_pool_thread.rs:41:26}` `Send` and `Sync` or consider a wrapper type such as `Mutex` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of an `Arc` that is not `Send` and `Sync` [INFO] [stdout] --> src/session_pool/session_pool_thread.rs:53:17 [INFO] [stdout] | [INFO] [stdout] 53 | Arc::new(move |fut| executor2.spawn(Box::pin(fut)).detach()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Arc<{closure@session_pool_thread.rs:53:26}>` is not `Send` and `Sync` as `{closure@session_pool_thread.rs:53:26}` is neither `Send` nor `Sync` [INFO] [stdout] = help: if the `Arc` will not be used across threads replace it with an `Rc` [INFO] [stdout] = help: otherwise make `{closure@session_pool_thread.rs:53:26}` `Send` and `Sync` or consider a wrapper type such as `Mutex` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of an `Arc` that is not `Send` and `Sync` [INFO] [stdout] --> src/session_pool/session_pool_thread.rs:34:28 [INFO] [stdout] | [INFO] [stdout] 34 | let executor = Arc::new(LocalExecutor::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Arc>` is not `Send` and `Sync` as `LocalExecutor<'_>` is neither `Send` nor `Sync` [INFO] [stdout] = help: if the `Arc` will not be used across threads replace it with an `Rc` [INFO] [stdout] = help: otherwise make `LocalExecutor<'_>` `Send` and `Sync` or consider a wrapper type such as `Mutex` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync [INFO] [stdout] = note: `#[warn(clippy::arc_with_non_send_sync)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of an `Arc` that is not `Send` and `Sync` [INFO] [stdout] --> src/session_pool/session_pool_thread.rs:41:17 [INFO] [stdout] | [INFO] [stdout] 41 | Arc::new(move |fut| executor.spawn(Box::pin(fut)).detach()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Arc<{closure@session_pool_thread.rs:41:26}>` is not `Send` and `Sync` as `{closure@session_pool_thread.rs:41:26}` is neither `Send` nor `Sync` [INFO] [stdout] = help: if the `Arc` will not be used across threads replace it with an `Rc` [INFO] [stdout] = help: otherwise make `{closure@session_pool_thread.rs:41:26}` `Send` and `Sync` or consider a wrapper type such as `Mutex` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of an `Arc` that is not `Send` and `Sync` [INFO] [stdout] --> src/session_pool/session_pool_thread.rs:53:17 [INFO] [stdout] | [INFO] [stdout] 53 | Arc::new(move |fut| executor2.spawn(Box::pin(fut)).detach()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Arc<{closure@session_pool_thread.rs:53:26}>` is not `Send` and `Sync` as `{closure@session_pool_thread.rs:53:26}` is neither `Send` nor `Sync` [INFO] [stdout] = help: if the `Arc` will not be used across threads replace it with an `Rc` [INFO] [stdout] = help: otherwise make `{closure@session_pool_thread.rs:53:26}` `Send` and `Sync` or consider a wrapper type such as `Mutex` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> tests/utils/cursor_utils.rs:66:31 [INFO] [stdout] | [INFO] [stdout] 66 | result.extend(values.into_iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/collect.rs:416:17 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 66 - result.extend(values.into_iter()); [INFO] [stdout] 66 + result.extend(values); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> tests/utils/cursor_utils.rs:66:31 [INFO] [stdout] | [INFO] [stdout] 66 | result.extend(values.into_iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/collect.rs:416:17 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 66 - result.extend(values.into_iter()); [INFO] [stdout] 66 + result.extend(values); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> tests/utils/cursor_utils.rs:66:31 [INFO] [stdout] | [INFO] [stdout] 66 | result.extend(values.into_iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/collect.rs:416:17 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 66 - result.extend(values.into_iter()); [INFO] [stdout] 66 + result.extend(values); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> tests/utils/cursor_utils.rs:66:31 [INFO] [stdout] | [INFO] [stdout] 66 | result.extend(values.into_iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/collect.rs:416:17 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 66 - result.extend(values.into_iter()); [INFO] [stdout] 66 + result.extend(values); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/document.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | assert_eq!(is_none, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 37 - assert_eq!(is_none, true); [INFO] [stdout] 37 + assert!(is_none); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> tests/document.rs:61:10 [INFO] [stdout] | [INFO] [stdout] 61 | .fold(0, |acc, val| acc + val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `sum::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fold)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> tests/utils/cursor_utils.rs:66:31 [INFO] [stdout] | [INFO] [stdout] 66 | result.extend(values.into_iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/collect.rs:416:17 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 66 - result.extend(values.into_iter()); [INFO] [stdout] 66 + result.extend(values); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/other_types.rs:145:29 [INFO] [stdout] | [INFO] [stdout] 145 | &IonValue::List(vec!["list", "of", "strings"].iter().map(|v| v.into()).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["list", "of", "strings"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/other_types.rs:156:30 [INFO] [stdout] | [INFO] [stdout] 156 | &IonValue::SExpr(vec!["list", "of", "strings"].iter().map(|v| v.into()).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["list", "of", "strings"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/other_types.rs:260:13 [INFO] [stdout] | [INFO] [stdout] 260 | vec!["list", "of", "strings"] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["list", "of", "strings"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> tests/utils/cursor_utils.rs:66:31 [INFO] [stdout] | [INFO] [stdout] 66 | result.extend(values.into_iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/collect.rs:416:17 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 66 - result.extend(values.into_iter()); [INFO] [stdout] 66 + result.extend(values); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> tests/utils/cursor_utils.rs:66:31 [INFO] [stdout] | [INFO] [stdout] 66 | result.extend(values.into_iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/collect.rs:416:17 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 66 - result.extend(values.into_iter()); [INFO] [stdout] 66 + result.extend(values); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> tests/utils/cursor_utils.rs:66:31 [INFO] [stdout] | [INFO] [stdout] 66 | result.extend(values.into_iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/collect.rs:416:17 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 66 - result.extend(values.into_iter()); [INFO] [stdout] 66 + result.extend(values); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/pool.rs:49:8 [INFO] [stdout] | [INFO] [stdout] 49 | if !result_b.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `result_b.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> tests/utils/cursor_utils.rs:66:31 [INFO] [stdout] | [INFO] [stdout] 66 | result.extend(values.into_iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/collect.rs:416:17 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 66 - result.extend(values.into_iter()); [INFO] [stdout] 66 + result.extend(values); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> tests/structs.rs:43:41 [INFO] [stdout] | [INFO] [stdout] 43 | "11n".into() => IonValue::Float(std::f64::MIN), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 43 - "11n".into() => IonValue::Float(std::f64::MIN), [INFO] [stdout] 43 + "11n".into() => IonValue::Float(f64::MIN), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 31.18s [INFO] running `Command { std: "docker" "inspect" "019af9025e716dcdfe555dd224ada1ce7932b04c1dda4a6eeba9222c6e2f24f9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "019af9025e716dcdfe555dd224ada1ce7932b04c1dda4a6eeba9222c6e2f24f9", kill_on_drop: false }` [INFO] [stdout] 019af9025e716dcdfe555dd224ada1ce7932b04c1dda4a6eeba9222c6e2f24f9