[INFO] fetching crate qapi-codegen 0.11.3... [INFO] linting qapi-codegen-0.11.3 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate qapi-codegen 0.11.3 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate qapi-codegen 0.11.3 [INFO] finished tweaking crates.io crate qapi-codegen 0.11.3 [INFO] tweaked toml for crates.io crate qapi-codegen 0.11.3 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate qapi-codegen 0.11.3 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 12 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded qapi-parser v0.11.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c1938fd956c9fa5ef772b4b60766ead6c4792465f91e7fd35d0e0cc39291a78c [INFO] running `Command { std: "docker" "start" "-a" "c1938fd956c9fa5ef772b4b60766ead6c4792465f91e7fd35d0e0cc39291a78c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c1938fd956c9fa5ef772b4b60766ead6c4792465f91e7fd35d0e0cc39291a78c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c1938fd956c9fa5ef772b4b60766ead6c4792465f91e7fd35d0e0cc39291a78c", kill_on_drop: false }` [INFO] [stdout] c1938fd956c9fa5ef772b4b60766ead6c4792465f91e7fd35d0e0cc39291a78c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 68c738094d66f6842d14f1ee3fc8a36fa1230b4d3ef5f9f944c9e00d9913a814 [INFO] running `Command { std: "docker" "start" "-a" "68c738094d66f6842d14f1ee3fc8a36fa1230b4d3ef5f9f944c9e00d9913a814", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.8.0 [INFO] [stderr] Compiling zmij v1.0.21 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Checking qapi-parser v0.11.0 [INFO] [stderr] Checking qapi-codegen v0.11.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:85:16 [INFO] [stdout] | [INFO] [stdout] 85 | let dict = value.ty.name == "any" && ( [INFO] [stdout] | ________________^ [INFO] [stdout] 86 | | (super_name == "object-add" && value.name == "props") || [INFO] [stdout] 87 | | (super_name == "CpuModelInfo" && value.name == "props") [INFO] [stdout] 88 | | ); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 85 - let dict = value.ty.name == "any" && ( [INFO] [stdout] 86 - (super_name == "object-add" && value.name == "props") || [INFO] [stdout] 87 - (super_name == "CpuModelInfo" && value.name == "props") [INFO] [stdout] 88 - ); [INFO] [stdout] 85 + let dict = !(value.ty.name != "any" || value.name != "props" || super_name != "object-add" && super_name != "CpuModelInfo"); [INFO] [stdout] | [INFO] [stdout] 85 - let dict = value.ty.name == "any" && ( [INFO] [stdout] 86 - (super_name == "object-add" && value.name == "props") || [INFO] [stdout] 87 - (super_name == "CpuModelInfo" && value.name == "props") [INFO] [stdout] 88 - ); [INFO] [stdout] 85 + let dict = (super_name == "CpuModelInfo" || super_name == "object-add") && value.name == "props" && value.ty.name == "any"; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:85:42 [INFO] [stdout] | [INFO] [stdout] 85 | let dict = value.ty.name == "any" && ( [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 86 | | (super_name == "object-add" && value.name == "props") || [INFO] [stdout] 87 | | (super_name == "CpuModelInfo" && value.name == "props") [INFO] [stdout] 88 | | ); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 85 - let dict = value.ty.name == "any" && ( [INFO] [stdout] 86 - (super_name == "object-add" && value.name == "props") || [INFO] [stdout] 87 - (super_name == "CpuModelInfo" && value.name == "props") [INFO] [stdout] 88 - ); [INFO] [stdout] 85 + let dict = value.ty.name == "any" && !(value.name != "props" || super_name != "object-add" && super_name != "CpuModelInfo"); [INFO] [stdout] | [INFO] [stdout] 85 - let dict = value.ty.name == "any" && ( [INFO] [stdout] 86 - (super_name == "object-add" && value.name == "props") || [INFO] [stdout] 87 - (super_name == "CpuModelInfo" && value.name == "props") [INFO] [stdout] 88 - ); [INFO] [stdout] 85 + let dict = value.ty.name == "any" && (super_name == "CpuModelInfo" || super_name == "object-add") && value.name == "props"; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:170:73 [INFO] [stdout] | [INFO] [stdout] 170 | ... writeln!(self.out, "\t{},", valuety(&data, true, &v.id))?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/lib.rs:220:33 [INFO] [stdout] | [INFO] [stdout] 220 | let boxed = if data.name == "definition" && data.ty.name == "BlockdevOptions" { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 221 | | true [INFO] [stdout] 222 | | } else { [INFO] [stdout] 223 | | false [INFO] [stdout] 224 | | }; [INFO] [stdout] | |_____________________^ help: you can reduce it to: `data.name == "definition" && data.ty.name == "BlockdevOptions"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:85:16 [INFO] [stdout] | [INFO] [stdout] 85 | let dict = value.ty.name == "any" && ( [INFO] [stdout] | ________________^ [INFO] [stdout] 86 | | (super_name == "object-add" && value.name == "props") || [INFO] [stdout] 87 | | (super_name == "CpuModelInfo" && value.name == "props") [INFO] [stdout] 88 | | ); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 85 - let dict = value.ty.name == "any" && ( [INFO] [stdout] 86 - (super_name == "object-add" && value.name == "props") || [INFO] [stdout] 87 - (super_name == "CpuModelInfo" && value.name == "props") [INFO] [stdout] 88 - ); [INFO] [stdout] 85 + let dict = !(value.ty.name != "any" || value.name != "props" || super_name != "object-add" && super_name != "CpuModelInfo"); [INFO] [stdout] | [INFO] [stdout] 85 - let dict = value.ty.name == "any" && ( [INFO] [stdout] 86 - (super_name == "object-add" && value.name == "props") || [INFO] [stdout] 87 - (super_name == "CpuModelInfo" && value.name == "props") [INFO] [stdout] 88 - ); [INFO] [stdout] 85 + let dict = (super_name == "CpuModelInfo" || super_name == "object-add") && value.name == "props" && value.ty.name == "any"; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:85:42 [INFO] [stdout] | [INFO] [stdout] 85 | let dict = value.ty.name == "any" && ( [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 86 | | (super_name == "object-add" && value.name == "props") || [INFO] [stdout] 87 | | (super_name == "CpuModelInfo" && value.name == "props") [INFO] [stdout] 88 | | ); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 85 - let dict = value.ty.name == "any" && ( [INFO] [stdout] 86 - (super_name == "object-add" && value.name == "props") || [INFO] [stdout] 87 - (super_name == "CpuModelInfo" && value.name == "props") [INFO] [stdout] 88 - ); [INFO] [stdout] 85 + let dict = value.ty.name == "any" && !(value.name != "props" || super_name != "object-add" && super_name != "CpuModelInfo"); [INFO] [stdout] | [INFO] [stdout] 85 - let dict = value.ty.name == "any" && ( [INFO] [stdout] 86 - (super_name == "object-add" && value.name == "props") || [INFO] [stdout] 87 - (super_name == "CpuModelInfo" && value.name == "props") [INFO] [stdout] 88 - ); [INFO] [stdout] 85 + let dict = value.ty.name == "any" && (super_name == "CpuModelInfo" || super_name == "object-add") && value.name == "props"; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `std::mem::take` [INFO] [stdout] --> src/lib.rs:328:26 [INFO] [stdout] | [INFO] [stdout] 328 | let fields = replace(&mut ty.data.fields, Vec::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::mem::take(&mut ty.data.fields)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] = note: `#[warn(clippy::mem_replace_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:170:73 [INFO] [stdout] | [INFO] [stdout] 170 | ... writeln!(self.out, "\t{},", valuety(&data, true, &v.id))?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:482:101 [INFO] [stdout] | [INFO] [stdout] 482 | write!(self.out, "\t#[serde(rename = \"{}\")]\n\t{}", variant_name, type_identifier(&variant_name))?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `variant_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:494:37 [INFO] [stdout] | [INFO] [stdout] 494 | ... valuety(&base, false, &u.id) [INFO] [stdout] | ^^^^^ help: change this to: `base` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/lib.rs:220:33 [INFO] [stdout] | [INFO] [stdout] 220 | let boxed = if data.name == "definition" && data.ty.name == "BlockdevOptions" { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 221 | | true [INFO] [stdout] 222 | | } else { [INFO] [stdout] 223 | | false [INFO] [stdout] 224 | | }; [INFO] [stdout] | |_____________________^ help: you can reduce it to: `data.name == "definition" && data.ty.name == "BlockdevOptions"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:496:81 [INFO] [stdout] | [INFO] [stdout] 496 | writeln!(self.out, "\t\t#[serde(flatten)] {},", valuety(&field, false, &u.id))?; [INFO] [stdout] | ^^^^^^ help: change this to: `field` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:513:57 [INFO] [stdout] | [INFO] [stdout] 513 | writeln!(self.out, "\t{},", valuety(&field, true, &u.id))?; [INFO] [stdout] | ^^^^^^ help: change this to: `field` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:522:39 [INFO] [stdout] | [INFO] [stdout] 522 | ", type_identifier(&u.id), identifier(&discrim), type_identifier(&discrim_ty.name))?; [INFO] [stdout] | ^^^^^^^^ help: change this to: `discrim` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:525:82 [INFO] [stdout] | [INFO] [stdout] 525 | ... {}::{} {{ .. }} => {}::{},", type_identifier(&u.id), type_identifier(&variant_name), type_identifier(&discrim_ty.name), type_... [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `variant_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:525:149 [INFO] [stdout] | [INFO] [stdout] 525 | ...ier(&discrim_ty.name), type_identifier(&variant_name))?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `variant_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `std::mem::take` [INFO] [stdout] --> src/lib.rs:328:26 [INFO] [stdout] | [INFO] [stdout] 328 | let fields = replace(&mut ty.data.fields, Vec::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::mem::take(&mut ty.data.fields)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] = note: `#[warn(clippy::mem_replace_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:482:101 [INFO] [stdout] | [INFO] [stdout] 482 | write!(self.out, "\t#[serde(rename = \"{}\")]\n\t{}", variant_name, type_identifier(&variant_name))?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `variant_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:494:37 [INFO] [stdout] | [INFO] [stdout] 494 | ... valuety(&base, false, &u.id) [INFO] [stdout] | ^^^^^ help: change this to: `base` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:496:81 [INFO] [stdout] | [INFO] [stdout] 496 | writeln!(self.out, "\t\t#[serde(flatten)] {},", valuety(&field, false, &u.id))?; [INFO] [stdout] | ^^^^^^ help: change this to: `field` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:513:57 [INFO] [stdout] | [INFO] [stdout] 513 | writeln!(self.out, "\t{},", valuety(&field, true, &u.id))?; [INFO] [stdout] | ^^^^^^ help: change this to: `field` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:522:39 [INFO] [stdout] | [INFO] [stdout] 522 | ", type_identifier(&u.id), identifier(&discrim), type_identifier(&discrim_ty.name))?; [INFO] [stdout] | ^^^^^^^^ help: change this to: `discrim` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:525:82 [INFO] [stdout] | [INFO] [stdout] 525 | ... {}::{} {{ .. }} => {}::{},", type_identifier(&u.id), type_identifier(&variant_name), type_identifier(&discrim_ty.name), type_... [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `variant_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:525:149 [INFO] [stdout] | [INFO] [stdout] 525 | ...ier(&discrim_ty.name), type_identifier(&variant_name))?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `variant_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.78s [INFO] running `Command { std: "docker" "inspect" "68c738094d66f6842d14f1ee3fc8a36fa1230b4d3ef5f9f944c9e00d9913a814", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "68c738094d66f6842d14f1ee3fc8a36fa1230b4d3ef5f9f944c9e00d9913a814", kill_on_drop: false }` [INFO] [stdout] 68c738094d66f6842d14f1ee3fc8a36fa1230b4d3ef5f9f944c9e00d9913a814