[INFO] fetching crate pyx 0.1.1... [INFO] linting pyx-0.1.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate pyx 0.1.1 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate pyx 0.1.1 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate pyx 0.1.1 [INFO] tweaked toml for crates.io crate pyx 0.1.1 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate pyx 0.1.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate pyx 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded lru v0.12.5 [INFO] [stderr] Downloaded http-range-header v0.4.2 [INFO] [stderr] Downloaded prometheus-client-derive-encode v0.4.2 [INFO] [stderr] Downloaded tokio-test v0.4.4 [INFO] [stderr] Downloaded compression-core v0.4.31 [INFO] [stderr] Downloaded h3-quinn v0.0.10 [INFO] [stderr] Downloaded nonzero_ext v0.3.0 [INFO] [stderr] Downloaded no-std-compat v0.4.1 [INFO] [stderr] Downloaded cmake v0.1.54 [INFO] [stderr] Downloaded zstd v0.13.3 [INFO] [stderr] Downloaded quanta v0.12.6 [INFO] [stderr] Downloaded spinning_top v0.3.0 [INFO] [stderr] Downloaded arc-swap v1.7.1 [INFO] [stderr] Downloaded mio v1.1.0 [INFO] [stderr] Downloaded raw-cpuid v11.6.0 [INFO] [stderr] Downloaded h3 v0.0.8 [INFO] [stderr] Downloaded governor v0.8.1 [INFO] [stderr] Downloaded webpki-root-certs v1.0.4 [INFO] [stderr] Downloaded icu_properties_data v2.1.1 [INFO] [stderr] Downloaded reqwest v0.12.24 [INFO] [stderr] Downloaded webpki-roots v1.0.4 [INFO] [stderr] Downloaded aws-lc-rs v1.15.1 [INFO] [stderr] Downloaded zerocopy v0.8.30 [INFO] [stderr] Downloaded iri-string v0.7.9 [INFO] [stderr] Downloaded h2 v0.4.12 [INFO] [stderr] Downloaded hdrhistogram v7.5.4 [INFO] [stderr] Downloaded tower-http v0.6.7 [INFO] [stderr] Downloaded rustls-webpki v0.103.8 [INFO] [stderr] Downloaded async-compression v0.4.34 [INFO] [stderr] Downloaded rustls v0.23.35 [INFO] [stderr] Downloaded hyper-util v0.1.18 [INFO] [stderr] Downloaded prometheus-client v0.23.1 [INFO] [stderr] Downloaded zerocopy-derive v0.8.30 [INFO] [stderr] Downloaded flate2 v1.1.5 [INFO] [stderr] Downloaded uuid v1.18.1 [INFO] [stderr] Downloaded icu_properties v2.1.1 [INFO] [stderr] Downloaded rustls-native-certs v0.8.2 [INFO] [stderr] Downloaded zstd-safe v7.2.4 [INFO] [stderr] Downloaded compression-codecs v0.4.33 [INFO] [stderr] Downloaded dtoa v1.0.10 [INFO] [stderr] Downloaded fastbloom v0.14.0 [INFO] [stderr] Downloaded rustls-pki-types v1.13.1 [INFO] [stderr] Downloaded aws-lc-sys v0.34.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ff4adc0dccfabae92678ae4f027439975a667315ada788a95bd9c54636ac4877 [INFO] running `Command { std: "docker" "start" "-a" "ff4adc0dccfabae92678ae4f027439975a667315ada788a95bd9c54636ac4877", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ff4adc0dccfabae92678ae4f027439975a667315ada788a95bd9c54636ac4877", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ff4adc0dccfabae92678ae4f027439975a667315ada788a95bd9c54636ac4877", kill_on_drop: false }` [INFO] [stdout] ff4adc0dccfabae92678ae4f027439975a667315ada788a95bd9c54636ac4877 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8f4b79885f240b5ba4c0807be4d67e28d5b01b5fc27bf861cf7b2207d677f11a [INFO] running `Command { std: "docker" "start" "-a" "8f4b79885f240b5ba4c0807be4d67e28d5b01b5fc27bf861cf7b2207d677f11a", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.103 [INFO] [stderr] Compiling quote v1.0.42 [INFO] [stderr] Compiling unicode-ident v1.0.22 [INFO] [stderr] Compiling libc v0.2.177 [INFO] [stderr] Compiling find-msvc-tools v0.1.5 [INFO] [stderr] Checking memchr v2.7.6 [INFO] [stderr] Checking bytes v1.11.0 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking log v0.4.28 [INFO] [stderr] Checking tracing-core v0.1.35 [INFO] [stderr] Compiling dunce v1.0.5 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Compiling zerocopy v0.8.30 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking rustls-pki-types v1.13.1 [INFO] [stderr] Compiling aws-lc-rs v1.15.1 [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling rustls v0.23.35 [INFO] [stderr] Compiling serde_json v1.0.145 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Compiling icu_properties_data v2.1.1 [INFO] [stderr] Checking alloc-no-stdlib v2.0.4 [INFO] [stderr] Compiling crc32fast v1.5.0 [INFO] [stderr] Checking regex-syntax v0.8.8 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Compiling zstd-safe v7.2.4 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking anstyle-parse v0.2.7 [INFO] [stderr] Compiling libm v0.2.15 [INFO] [stderr] Checking alloc-stdlib v0.2.2 [INFO] [stderr] Checking adler2 v2.0.1 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking anstyle-query v1.1.5 [INFO] [stderr] Checking colorchoice v1.0.4 [INFO] [stderr] Checking anstyle v1.0.13 [INFO] [stderr] Checking is_terminal_polyfill v1.70.2 [INFO] [stderr] Checking brotli-decompressor v5.0.0 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Compiling thiserror v2.0.17 [INFO] [stderr] Compiling openssl v0.10.75 [INFO] [stderr] Compiling quinn-udp v0.5.14 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking flate2 v1.1.5 [INFO] [stderr] Checking rustls-native-certs v0.8.2 [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking siphasher v1.0.1 [INFO] [stderr] Checking compression-core v0.4.31 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking tinyvec v1.10.0 [INFO] [stderr] Compiling quinn v0.11.9 [INFO] [stderr] Checking webpki-roots v1.0.4 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking clap_lex v0.7.6 [INFO] [stderr] Checking fastrand v2.3.0 [INFO] [stderr] Checking lru-slab v0.1.2 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking rustc-hash v2.1.1 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking socket2 v0.6.1 [INFO] [stderr] Checking mio v1.1.0 [INFO] [stderr] Checking signal-hook-registry v1.4.7 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking brotli v8.0.2 [INFO] [stderr] Compiling portable-atomic v1.11.1 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Checking clap_builder v4.5.53 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking uuid v1.18.1 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Compiling cc v1.2.48 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking hdrhistogram v7.5.4 [INFO] [stderr] Checking raw-cpuid v11.6.0 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking thread_local v1.1.9 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling prometheus-client v0.23.1 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking iri-string v0.7.9 [INFO] [stderr] Checking http-range-header v0.4.2 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Checking deadpool-runtime v0.1.4 [INFO] [stderr] Compiling anyhow v1.0.100 [INFO] [stderr] Checking nu-ansi-term v0.50.3 [INFO] [stderr] Checking plotters-backend v0.3.7 [INFO] [stderr] Checking foldhash v0.1.5 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Checking env_filter v0.1.4 [INFO] [stderr] Checking crossbeam-channel v0.5.15 [INFO] [stderr] Checking crossbeam-queue v0.3.12 [INFO] [stderr] Checking plotters-svg v0.3.7 [INFO] [stderr] Checking spinning_top v0.3.0 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking no-std-compat v0.4.1 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Checking web-time v1.1.0 [INFO] [stderr] Checking dtoa v1.0.10 [INFO] [stderr] Checking iana-time-zone v0.1.64 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Checking dashmap v6.1.0 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking nonzero_ext v0.3.0 [INFO] [stderr] Checking lru v0.12.5 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Compiling cmake v0.1.54 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking is-terminal v0.4.17 [INFO] [stderr] Checking webpki-roots v0.26.11 [INFO] [stderr] Checking rustls-pemfile v2.2.0 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking humantime v2.3.0 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking oorandom v11.1.5 [INFO] [stderr] Compiling aws-lc-sys v0.34.0 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling zstd-sys v2.0.16+zstd.1.5.7 [INFO] [stderr] Compiling openssl-sys v0.9.111 [INFO] [stderr] Checking quanta v0.12.6 [INFO] [stderr] Checking indexmap v2.12.1 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking tempfile v3.23.0 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerocopy-derive v0.8.30 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling async-stream-impl v0.3.6 [INFO] [stderr] Compiling prometheus-client-derive-encode v0.4.2 [INFO] [stderr] Checking compression-codecs v0.4.33 [INFO] [stderr] Compiling test-log-macros v0.2.19 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking async-stream v0.3.6 [INFO] [stderr] Checking tracing v0.1.43 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking clap v4.5.53 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.1 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking tracing-serde v0.2.0 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking assert-json-diff v2.0.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking tokio-util v0.7.17 [INFO] [stderr] Checking async-compression v0.4.34 [INFO] [stderr] Checking deadpool v0.12.3 [INFO] [stderr] Checking h3 v0.0.8 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tokio-stream v0.1.17 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking h2 v0.4.12 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking tokio-test v0.4.4 [INFO] [stderr] Checking fastbloom v0.14.0 [INFO] [stderr] Checking governor v0.8.1 [INFO] [stderr] Checking test-log v0.2.19 [INFO] [stderr] Checking tower-http v0.6.7 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking hyper-util v0.1.18 [INFO] [stderr] Checking rustls-webpki v0.103.8 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking wiremock v0.6.5 [INFO] [stderr] Checking rustls-platform-verifier v0.6.2 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking quinn-proto v0.11.13 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking reqwest v0.12.24 [INFO] [stderr] Checking h3-quinn v0.0.10 [INFO] [stderr] Checking pyx v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> tests/integration_tests.rs:271:40 [INFO] [stdout] | [INFO] [stdout] 271 | if *pattern == "/" { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 272 | | true // Root matches everything as fallback [INFO] [stdout] 273 | | } else if path == *pattern { [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> tests/integration_tests.rs:273:48 [INFO] [stdout] | [INFO] [stdout] 273 | } else if path == *pattern { [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 274 | | true // Exact match [INFO] [stdout] 275 | | } else if path.starts_with(pattern) { [INFO] [stdout] | |_____________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> tests/integration_tests.rs:277:41 [INFO] [stdout] | [INFO] [stdout] 277 | let remainder = &path[pattern.len()..]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> tests/integration_tests.rs:275:28 [INFO] [stdout] | [INFO] [stdout] 275 | } else if path.starts_with(pattern) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 275 ~ } else if let Some(remainder) = path.strip_prefix(pattern) { [INFO] [stdout] 276 | // Prefix match with boundary check [INFO] [stdout] 277 ~ remainder.is_empty() || remainder.starts_with('/') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> tests/integration_tests.rs:641:21 [INFO] [stdout] | [INFO] [stdout] 641 | assert!(code >= 400 && code < 600, "Should be error code: {}", code); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(400..600).contains(&code)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> tests/integration_tests.rs:657:17 [INFO] [stdout] | [INFO] [stdout] 657 | code >= 300 && code < 400, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(300..400).contains(&code)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/integration_tests.rs:247:22 [INFO] [stdout] | [INFO] [stdout] 247 | let routes = vec![ [INFO] [stdout] | ______________________^ [INFO] [stdout] 248 | | ("/", "root"), [INFO] [stdout] 249 | | ("/api", "api"), [INFO] [stdout] 250 | | ("/api/v1", "api_v1"), [INFO] [stdout] 251 | | ("/api/v1/users", "api_v1_users"), [INFO] [stdout] 252 | | ]; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 247 ~ let routes = [("/", "root"), [INFO] [stdout] 248 + ("/api", "api"), [INFO] [stdout] 249 + ("/api/v1", "api_v1"), [INFO] [stdout] 250 ~ ("/api/v1/users", "api_v1_users")]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/integration_tests.rs:298:24 [INFO] [stdout] | [INFO] [stdout] 298 | let patterns = vec!["/api", "/app", "/application"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["/api", "/app", "/application"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/integration_tests.rs:460:32 [INFO] [stdout] | [INFO] [stdout] 460 | let security_headers = vec![ [INFO] [stdout] | ________________________________^ [INFO] [stdout] 461 | | ("X-Xss-Protection", "1; mode=block"), [INFO] [stdout] 462 | | ("X-Content-Type-Options", "nosniff"), [INFO] [stdout] 463 | | ("Referrer-Policy", "origin"), [INFO] [stdout] 464 | | ]; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 460 ~ let security_headers = [("X-Xss-Protection", "1; mode=block"), [INFO] [stdout] 461 + ("X-Content-Type-Options", "nosniff"), [INFO] [stdout] 462 ~ ("Referrer-Policy", "origin")]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/integration_tests.rs:466:33 [INFO] [stdout] | [INFO] [stdout] 466 | let headers_to_remove = vec!["X-Powered-By", "Via", "x-varnish"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["X-Powered-By", "Via", "x-varnish"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> benches/middleware.rs:81:17 [INFO] [stdout] | [INFO] [stdout] 81 | / { [INFO] [stdout] 82 | | ", " [INFO] [stdout] 83 | | } else { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> benches/middleware.rs:83:24 [INFO] [stdout] | [INFO] [stdout] 83 | } else { [INFO] [stdout] | ________________________^ [INFO] [stdout] 84 | | ", " [INFO] [stdout] 85 | | }; [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> benches/middleware.rs:605:47 [INFO] [stdout] | [INFO] [stdout] 605 | group.bench_function("status", |b| b.iter(|| status_response())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `status_response` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `upstream` and `preserve_host` are never read [INFO] [stdout] --> benches/routing.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 51 | Proxy { [INFO] [stdout] | ----- fields in this variant [INFO] [stdout] 52 | upstream: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 53 | preserve_host: bool, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RouteAction` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `dir`, `index`, and `send_gzip` are never read [INFO] [stdout] --> benches/routing.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 55 | StaticFiles { [INFO] [stdout] | ----------- fields in this variant [INFO] [stdout] 56 | dir: PathBuf, [INFO] [stdout] | ^^^ [INFO] [stdout] 57 | index: Vec, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 58 | send_gzip: bool, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RouteAction` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Redirect` is never constructed [INFO] [stdout] --> benches/routing.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 50 | enum RouteAction { [INFO] [stdout] | ----------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 60 | Redirect { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RouteAction` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> benches/routing.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 78 | struct ResolvedHost { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 79 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ResolvedHost` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `exact` is never read [INFO] [stdout] --> benches/routing.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 85 | struct RouteEntry { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 86 | path: String, [INFO] [stdout] 87 | exact: bool, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `action`, `headers`, `proxy_headers`, and `matched_path` are never read [INFO] [stdout] --> benches/routing.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 101 | struct MatchResult { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 102 | action: RouteAction, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 103 | headers: HeaderRules, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 104 | proxy_headers: HeaderRules, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 105 | matched_path: String, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MatchResult` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> benches/routing.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | routes.sort_by(|a, b| b.path.len().cmp(&a.path.len())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 123 - routes.sort_by(|a, b| b.path.len().cmp(&a.path.len())); [INFO] [stdout] 123 + routes.sort_by_key(|b| std::cmp::Reverse(b.path.len())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> benches/routing.rs:170:29 [INFO] [stdout] | [INFO] [stdout] 170 | let remainder = &path[pattern.len()..]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> benches/routing.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 169 | if path.starts_with(pattern) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 169 ~ if let Some(remainder) = path.strip_prefix(pattern) { [INFO] [stdout] 170 ~ return remainder.is_empty() || remainder.starts_with('/'); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> benches/proxy.rs:25:74 [INFO] [stdout] | [INFO] [stdout] 25 | let final_path = if upstream_path == "/" || upstream_path.is_empty() { [INFO] [stdout] | __________________________________________________________________________^ [INFO] [stdout] 26 | | request_path.to_string() [INFO] [stdout] 27 | | } else if request_path.starts_with(upstream_path) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> benches/proxy.rs:27:55 [INFO] [stdout] | [INFO] [stdout] 27 | } else if request_path.starts_with(upstream_path) { [INFO] [stdout] | _______________________________________________________^ [INFO] [stdout] 28 | | request_path.to_string() [INFO] [stdout] 29 | | } else { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::PathBuf` [INFO] [stdout] --> src/http3.rs:506:9 [INFO] [stdout] | [INFO] [stdout] 506 | use std::path::PathBuf; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `PooledProtocol` is never used [INFO] [stdout] --> src/pool.rs:55:10 [INFO] [stdout] | [INFO] [stdout] 55 | pub enum PooledProtocol { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `is_websocket_headers` is never used [INFO] [stdout] --> src/proxy.rs:52:4 [INFO] [stdout] | [INFO] [stdout] 52 | fn is_websocket_headers(headers: &HeaderMap) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `stats` and `backend_states` are never used [INFO] [stdout] --> src/tcp_proxy.rs:664:12 [INFO] [stdout] | [INFO] [stdout] 224 | impl TcpProxy { [INFO] [stdout] | ------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 664 | pub fn stats(&self) -> &TcpProxyStats { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 669 | pub fn backend_states(&self) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `BackendInfo` is never constructed [INFO] [stdout] --> src/tcp_proxy.rs:688:12 [INFO] [stdout] | [INFO] [stdout] 688 | pub struct BackendInfo { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/tls.rs:89:12 [INFO] [stdout] | [INFO] [stdout] 87 | impl SniResolver { [INFO] [stdout] | ---------------- associated function in this implementation [INFO] [stdout] 88 | /// Create a new SNI resolver with default fallback disabled (secure by default) [INFO] [stdout] 89 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/tls.rs:147:12 [INFO] [stdout] | [INFO] [stdout] 145 | impl TlsManager { [INFO] [stdout] | --------------- associated function in this implementation [INFO] [stdout] 146 | /// Create a new TLS manager with default fallback disabled (secure by default) [INFO] [stdout] 147 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/config.rs:857:18 [INFO] [stdout] | [INFO] [stdout] 857 | .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/config.rs:865:18 [INFO] [stdout] | [INFO] [stdout] 865 | .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/config.rs:1055:13 [INFO] [stdout] | [INFO] [stdout] 1055 | paths.sort_by(|a, b| b.0.len().cmp(&a.0.len())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1055 - paths.sort_by(|a, b| b.0.len().cmp(&a.0.len())); [INFO] [stdout] 1055 + paths.sort_by_key(|b| std::cmp::Reverse(b.0.len())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/middleware.rs:206:10 [INFO] [stdout] | [INFO] [stdout] 206 | .replace('\r', "") [INFO] [stdout] | __________^ [INFO] [stdout] 207 | | .replace('\n', ""); [INFO] [stdout] | |__________________________^ help: replace with: `replace(['\r', '\n'], "")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] = note: `#[warn(clippy::collapsible_str_replace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/pool.rs:333:49 [INFO] [stdout] | [INFO] [stdout] 333 | .map_err(|_| PoolError::ConnectTimeout)? [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 334 | | .map_err(|e| e)?; [INFO] [stdout] | |_______________________^ help: remove the call to `map_err` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] = note: `#[warn(clippy::map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/pool.rs:418:49 [INFO] [stdout] | [INFO] [stdout] 418 | .map_err(|_| PoolError::ConnectTimeout)? [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 419 | | .map_err(|e| e)?; [INFO] [stdout] | |_______________________^ help: remove the call to `map_err` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/proxy.rs:110:5 [INFO] [stdout] | [INFO] [stdout] 110 | / pub async fn proxy( [INFO] [stdout] 111 | | &self, [INFO] [stdout] 112 | | request: Request, [INFO] [stdout] 113 | | upstream_url: &str, [INFO] [stdout] ... | [INFO] [stdout] 118 | | client_scheme: &str, [INFO] [stdout] 119 | | ) -> Result, ProxyError> { [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/proxy.rs:155:5 [INFO] [stdout] | [INFO] [stdout] 155 | / async fn proxy_streaming( [INFO] [stdout] 156 | | &self, [INFO] [stdout] 157 | | request: Request, [INFO] [stdout] 158 | | upstream_url: &str, [INFO] [stdout] ... | [INFO] [stdout] 163 | | client_scheme: &str, [INFO] [stdout] 164 | | ) -> Result, ProxyError> { [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/proxy.rs:271:5 [INFO] [stdout] | [INFO] [stdout] 271 | / async fn proxy_buffered( [INFO] [stdout] 272 | | &self, [INFO] [stdout] 273 | | mut request: Request, [INFO] [stdout] 274 | | upstream_url: &str, [INFO] [stdout] ... | [INFO] [stdout] 279 | | client_scheme: &str, [INFO] [stdout] 280 | | ) -> Result, ProxyError> { [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (11/7) [INFO] [stdout] --> src/proxy.rs:411:5 [INFO] [stdout] | [INFO] [stdout] 411 | / pub async fn proxy_with_body( [INFO] [stdout] 412 | | &self, [INFO] [stdout] 413 | | method: http::Method, [INFO] [stdout] 414 | | uri: &http::Uri, [INFO] [stdout] ... | [INFO] [stdout] 422 | | client_scheme: &str, [INFO] [stdout] 423 | | ) -> Result, ProxyError> { [INFO] [stdout] | |____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/proxy.rs:662:5 [INFO] [stdout] | [INFO] [stdout] 662 | / pub async fn proxy_websocket_with_info( [INFO] [stdout] 663 | | &self, [INFO] [stdout] 664 | | method: http::Method, [INFO] [stdout] 665 | | uri: &Uri, [INFO] [stdout] ... | [INFO] [stdout] 671 | | client_scheme: &str, [INFO] [stdout] 672 | | ) -> Result { [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/routing.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | routes.sort_by(|a, b| b.path.len().cmp(&a.path.len())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 50 - routes.sort_by(|a, b| b.path.len().cmp(&a.path.len())); [INFO] [stdout] 50 + routes.sort_by_key(|b| std::cmp::Reverse(b.path.len())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/routing.rs:105:29 [INFO] [stdout] | [INFO] [stdout] 105 | let remainder = &path[pattern.len()..]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/routing.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | if path.starts_with(pattern) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 99 ~ if let Some(remainder) = path.strip_prefix(pattern) { [INFO] [stdout] 100 | // If pattern ends with /, it's already a directory prefix - match anything under it [INFO] [stdout] ... [INFO] [stdout] 104 | // For patterns without trailing slash, ensure we match at path boundary [INFO] [stdout] 105 ~ return remainder.is_empty() || remainder.starts_with('/'); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/routing.rs:171:25 [INFO] [stdout] | [INFO] [stdout] 171 | (port == 443 && existing_port != 443) || (existing_port != 443 && port > existing_port) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 171 - (port == 443 && existing_port != 443) || (existing_port != 443 && port > existing_port) [INFO] [stdout] 171 + !(existing_port == 443 || port != 443 && port <= existing_port) [INFO] [stdout] | [INFO] [stdout] 171 - (port == 443 && existing_port != 443) || (existing_port != 443 && port > existing_port) [INFO] [stdout] 171 + (port > existing_port || port == 443) && existing_port != 443 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/server/static_files.rs:144:46 [INFO] [stdout] | [INFO] [stdout] 144 | let content_type = mime_guess::from_path(&final_path.to_string_lossy().replace(".gz", "")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `final_path.to_string_lossy().replace(".gz", "")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/server/static_files.rs:184:22 [INFO] [stdout] | [INFO] [stdout] 184 | .map(|bytes| Frame::data(bytes)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Frame::data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/server/static_files.rs:206:22 [INFO] [stdout] | [INFO] [stdout] 206 | .map(|bytes| Frame::data(bytes)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Frame::data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/server/static_files.rs:583:25 [INFO] [stdout] | [INFO] [stdout] 583 | let remainder = &path[prefix_trimmed.len()..]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/server/static_files.rs:582:5 [INFO] [stdout] | [INFO] [stdout] 582 | if path.starts_with(prefix_trimmed) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 582 ~ if let Some(remainder) = path.strip_prefix(prefix_trimmed) { [INFO] [stdout] 583 ~ // Strip leading slash from remainder if present [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/server/static_files.rs:821:46 [INFO] [stdout] | [INFO] [stdout] 821 | let content_type = mime_guess::from_path(&final_path.to_string_lossy().replace(".gz", "")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `final_path.to_string_lossy().replace(".gz", "")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `PooledProtocol` is never used [INFO] [stdout] --> src/pool.rs:55:10 [INFO] [stdout] | [INFO] [stdout] 55 | pub enum PooledProtocol { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `stats` and `backend_states` are never used [INFO] [stdout] --> src/tcp_proxy.rs:664:12 [INFO] [stdout] | [INFO] [stdout] 224 | impl TcpProxy { [INFO] [stdout] | ------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 664 | pub fn stats(&self) -> &TcpProxyStats { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 669 | pub fn backend_states(&self) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `BackendInfo` is never constructed [INFO] [stdout] --> src/tcp_proxy.rs:688:12 [INFO] [stdout] | [INFO] [stdout] 688 | pub struct BackendInfo { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/config.rs:857:18 [INFO] [stdout] | [INFO] [stdout] 857 | .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/config.rs:865:18 [INFO] [stdout] | [INFO] [stdout] 865 | .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/config.rs:1055:13 [INFO] [stdout] | [INFO] [stdout] 1055 | paths.sort_by(|a, b| b.0.len().cmp(&a.0.len())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1055 - paths.sort_by(|a, b| b.0.len().cmp(&a.0.len())); [INFO] [stdout] 1055 + paths.sort_by_key(|b| std::cmp::Reverse(b.0.len())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/config.rs:2013:13 [INFO] [stdout] | [INFO] [stdout] 2013 | / match &route.action { [INFO] [stdout] 2014 | | RouteAction::Proxy { [INFO] [stdout] 2015 | | preserve_host, [INFO] [stdout] 2016 | | upstream, [INFO] [stdout] ... | [INFO] [stdout] 2024 | | _ => {} [INFO] [stdout] 2025 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 2013 ~ if let RouteAction::Proxy { [INFO] [stdout] 2014 + preserve_host, [INFO] [stdout] 2015 + upstream, [INFO] [stdout] 2016 + } = &route.action { [INFO] [stdout] 2017 + if upstream.contains("api") { [INFO] [stdout] 2018 + assert!(*preserve_host, "api should preserve host"); [INFO] [stdout] 2019 + } else { [INFO] [stdout] 2020 + assert!(!*preserve_host, "external should not preserve host"); [INFO] [stdout] 2021 + } [INFO] [stdout] 2022 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/middleware.rs:206:10 [INFO] [stdout] | [INFO] [stdout] 206 | .replace('\r', "") [INFO] [stdout] | __________^ [INFO] [stdout] 207 | | .replace('\n', ""); [INFO] [stdout] | |__________________________^ help: replace with: `replace(['\r', '\n'], "")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] = note: `#[warn(clippy::collapsible_str_replace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/pool.rs:333:49 [INFO] [stdout] | [INFO] [stdout] 333 | .map_err(|_| PoolError::ConnectTimeout)? [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 334 | | .map_err(|e| e)?; [INFO] [stdout] | |_______________________^ help: remove the call to `map_err` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] = note: `#[warn(clippy::map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/pool.rs:418:49 [INFO] [stdout] | [INFO] [stdout] 418 | .map_err(|_| PoolError::ConnectTimeout)? [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 419 | | .map_err(|e| e)?; [INFO] [stdout] | |_______________________^ help: remove the call to `map_err` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/proxy.rs:110:5 [INFO] [stdout] | [INFO] [stdout] 110 | / pub async fn proxy( [INFO] [stdout] 111 | | &self, [INFO] [stdout] 112 | | request: Request, [INFO] [stdout] 113 | | upstream_url: &str, [INFO] [stdout] ... | [INFO] [stdout] 118 | | client_scheme: &str, [INFO] [stdout] 119 | | ) -> Result, ProxyError> { [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/proxy.rs:155:5 [INFO] [stdout] | [INFO] [stdout] 155 | / async fn proxy_streaming( [INFO] [stdout] 156 | | &self, [INFO] [stdout] 157 | | request: Request, [INFO] [stdout] 158 | | upstream_url: &str, [INFO] [stdout] ... | [INFO] [stdout] 163 | | client_scheme: &str, [INFO] [stdout] 164 | | ) -> Result, ProxyError> { [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/proxy.rs:271:5 [INFO] [stdout] | [INFO] [stdout] 271 | / async fn proxy_buffered( [INFO] [stdout] 272 | | &self, [INFO] [stdout] 273 | | mut request: Request, [INFO] [stdout] 274 | | upstream_url: &str, [INFO] [stdout] ... | [INFO] [stdout] 279 | | client_scheme: &str, [INFO] [stdout] 280 | | ) -> Result, ProxyError> { [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (11/7) [INFO] [stdout] --> src/proxy.rs:411:5 [INFO] [stdout] | [INFO] [stdout] 411 | / pub async fn proxy_with_body( [INFO] [stdout] 412 | | &self, [INFO] [stdout] 413 | | method: http::Method, [INFO] [stdout] 414 | | uri: &http::Uri, [INFO] [stdout] ... | [INFO] [stdout] 422 | | client_scheme: &str, [INFO] [stdout] 423 | | ) -> Result, ProxyError> { [INFO] [stdout] | |____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/proxy.rs:662:5 [INFO] [stdout] | [INFO] [stdout] 662 | / pub async fn proxy_websocket_with_info( [INFO] [stdout] 663 | | &self, [INFO] [stdout] 664 | | method: http::Method, [INFO] [stdout] 665 | | uri: &Uri, [INFO] [stdout] ... | [INFO] [stdout] 671 | | client_scheme: &str, [INFO] [stdout] 672 | | ) -> Result { [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/routing.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | routes.sort_by(|a, b| b.path.len().cmp(&a.path.len())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 50 - routes.sort_by(|a, b| b.path.len().cmp(&a.path.len())); [INFO] [stdout] 50 + routes.sort_by_key(|b| std::cmp::Reverse(b.path.len())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/routing.rs:105:29 [INFO] [stdout] | [INFO] [stdout] 105 | let remainder = &path[pattern.len()..]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/routing.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | if path.starts_with(pattern) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 99 ~ if let Some(remainder) = path.strip_prefix(pattern) { [INFO] [stdout] 100 | // If pattern ends with /, it's already a directory prefix - match anything under it [INFO] [stdout] ... [INFO] [stdout] 104 | // For patterns without trailing slash, ensure we match at path boundary [INFO] [stdout] 105 ~ return remainder.is_empty() || remainder.starts_with('/'); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/routing.rs:171:25 [INFO] [stdout] | [INFO] [stdout] 171 | (port == 443 && existing_port != 443) || (existing_port != 443 && port > existing_port) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 171 - (port == 443 && existing_port != 443) || (existing_port != 443 && port > existing_port) [INFO] [stdout] 171 + !(existing_port == 443 || port != 443 && port <= existing_port) [INFO] [stdout] | [INFO] [stdout] 171 - (port == 443 && existing_port != 443) || (existing_port != 443 && port > existing_port) [INFO] [stdout] 171 + (port > existing_port || port == 443) && existing_port != 443 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/server/static_files.rs:144:46 [INFO] [stdout] | [INFO] [stdout] 144 | let content_type = mime_guess::from_path(&final_path.to_string_lossy().replace(".gz", "")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `final_path.to_string_lossy().replace(".gz", "")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/server/static_files.rs:184:22 [INFO] [stdout] | [INFO] [stdout] 184 | .map(|bytes| Frame::data(bytes)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Frame::data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/server/static_files.rs:206:22 [INFO] [stdout] | [INFO] [stdout] 206 | .map(|bytes| Frame::data(bytes)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Frame::data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/server/static_files.rs:583:25 [INFO] [stdout] | [INFO] [stdout] 583 | let remainder = &path[prefix_trimmed.len()..]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/server/static_files.rs:582:5 [INFO] [stdout] | [INFO] [stdout] 582 | if path.starts_with(prefix_trimmed) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 582 ~ if let Some(remainder) = path.strip_prefix(prefix_trimmed) { [INFO] [stdout] 583 ~ // Strip leading slash from remainder if present [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/server/static_files.rs:821:46 [INFO] [stdout] | [INFO] [stdout] 821 | let content_type = mime_guess::from_path(&final_path.to_string_lossy().replace(".gz", "")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `final_path.to_string_lossy().replace(".gz", "")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/server/static_files.rs:1158:33 [INFO] [stdout] | [INFO] [stdout] 1158 | assert_eq!(parse_range(&format!("bytes=-1000"), large_size), Some((large_size - 1000, large_size - 1))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"bytes=-1000".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 11s [INFO] running `Command { std: "docker" "inspect" "8f4b79885f240b5ba4c0807be4d67e28d5b01b5fc27bf861cf7b2207d677f11a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8f4b79885f240b5ba4c0807be4d67e28d5b01b5fc27bf861cf7b2207d677f11a", kill_on_drop: false }` [INFO] [stdout] 8f4b79885f240b5ba4c0807be4d67e28d5b01b5fc27bf861cf7b2207d677f11a