[INFO] fetching crate pyth-min 0.1.2... [INFO] linting pyth-min-0.1.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate pyth-min 0.1.2 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate pyth-min 0.1.2 [INFO] finished tweaking crates.io crate pyth-min 0.1.2 [INFO] tweaked toml for crates.io crate pyth-min 0.1.2 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate pyth-min 0.1.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 58959d7263d266050e878d02127ef759f2da6ad65a4912090e58877920b9169e [INFO] running `Command { std: "docker" "start" "-a" "58959d7263d266050e878d02127ef759f2da6ad65a4912090e58877920b9169e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "58959d7263d266050e878d02127ef759f2da6ad65a4912090e58877920b9169e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "58959d7263d266050e878d02127ef759f2da6ad65a4912090e58877920b9169e", kill_on_drop: false }` [INFO] [stdout] 58959d7263d266050e878d02127ef759f2da6ad65a4912090e58877920b9169e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2f664424ca4c297dffdb60a4c707d1efd13af44665787758b9bf0a04b1fe11e4 [INFO] running `Command { std: "docker" "start" "-a" "2f664424ca4c297dffdb60a4c707d1efd13af44665787758b9bf0a04b1fe11e4", kill_on_drop: false }` [INFO] [stderr] Checking pyth-min v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: accessing first element with `v.get(0)` [INFO] [stdout] --> src/price_update.rs:47:15 [INFO] [stdout] | [INFO] [stdout] 47 | match v.get(0).unwrap() { [INFO] [stdout] | ^^^^^^^^ help: try: `v.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `feed_id` after checking its variant with `is_some` [INFO] [stdout] --> src/price_update.rs:137:47 [INFO] [stdout] | [INFO] [stdout] 136 | if feed_id.is_some() { [INFO] [stdout] | -------------------- help: try: `if let Some() = feed_id` [INFO] [stdout] 137 | if self.price_message.feed_id != *feed_id.unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/price_update.rs:136:9 [INFO] [stdout] | [INFO] [stdout] 136 | / if feed_id.is_some() { [INFO] [stdout] 137 | | if self.price_message.feed_id != *feed_id.unwrap() { [INFO] [stdout] 138 | | return Err(GetPriceError::MismatchedFeedId); [INFO] [stdout] 139 | | } [INFO] [stdout] 140 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 136 ~ if feed_id.is_some() [INFO] [stdout] 137 ~ && self.price_message.feed_id != *feed_id.unwrap() { [INFO] [stdout] 138 | return Err(GetPriceError::MismatchedFeedId); [INFO] [stdout] 139 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/price_update.rs:190:12 [INFO] [stdout] | [INFO] [stdout] 190 | if !(price [INFO] [stdout] | ____________^ [INFO] [stdout] 191 | | .publish_time [INFO] [stdout] 192 | | .saturating_add(maximum_age.try_into().unwrap()) [INFO] [stdout] 193 | | >= unix_timestamp) [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 190 ~ if (price [INFO] [stdout] 191 + .publish_time [INFO] [stdout] 192 + .saturating_add(maximum_age.try_into().unwrap()) < unix_timestamp) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `v.get(0)` [INFO] [stdout] --> src/price_update.rs:47:15 [INFO] [stdout] | [INFO] [stdout] 47 | match v.get(0).unwrap() { [INFO] [stdout] | ^^^^^^^^ help: try: `v.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `feed_id` after checking its variant with `is_some` [INFO] [stdout] --> src/price_update.rs:137:47 [INFO] [stdout] | [INFO] [stdout] 136 | if feed_id.is_some() { [INFO] [stdout] | -------------------- help: try: `if let Some() = feed_id` [INFO] [stdout] 137 | if self.price_message.feed_id != *feed_id.unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/price_update.rs:136:9 [INFO] [stdout] | [INFO] [stdout] 136 | / if feed_id.is_some() { [INFO] [stdout] 137 | | if self.price_message.feed_id != *feed_id.unwrap() { [INFO] [stdout] 138 | | return Err(GetPriceError::MismatchedFeedId); [INFO] [stdout] 139 | | } [INFO] [stdout] 140 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 136 ~ if feed_id.is_some() [INFO] [stdout] 137 ~ && self.price_message.feed_id != *feed_id.unwrap() { [INFO] [stdout] 138 | return Err(GetPriceError::MismatchedFeedId); [INFO] [stdout] 139 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/price_update.rs:190:12 [INFO] [stdout] | [INFO] [stdout] 190 | if !(price [INFO] [stdout] | ____________^ [INFO] [stdout] 191 | | .publish_time [INFO] [stdout] 192 | | .saturating_add(maximum_age.try_into().unwrap()) [INFO] [stdout] 193 | | >= unix_timestamp) [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 190 ~ if (price [INFO] [stdout] 191 + .publish_time [INFO] [stdout] 192 + .saturating_add(maximum_age.try_into().unwrap()) < unix_timestamp) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/price_update.rs:401:9 [INFO] [stdout] | [INFO] [stdout] 401 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 401 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 401 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/price_update.rs:443:9 [INFO] [stdout] | [INFO] [stdout] 443 | assert_eq!(result.is_err(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 443 - assert_eq!(result.is_err(), true); [INFO] [stdout] 443 + assert!(result.is_err()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/price_update.rs:483:9 [INFO] [stdout] | [INFO] [stdout] 483 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 483 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 483 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.20s [INFO] running `Command { std: "docker" "inspect" "2f664424ca4c297dffdb60a4c707d1efd13af44665787758b9bf0a04b1fe11e4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2f664424ca4c297dffdb60a4c707d1efd13af44665787758b9bf0a04b1fe11e4", kill_on_drop: false }` [INFO] [stdout] 2f664424ca4c297dffdb60a4c707d1efd13af44665787758b9bf0a04b1fe11e4