[INFO] fetching crate pyreq-rs 0.1.0... [INFO] linting pyreq-rs-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate pyreq-rs 0.1.0 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate pyreq-rs 0.1.0 [INFO] finished tweaking crates.io crate pyreq-rs 0.1.0 [INFO] tweaked toml for crates.io crate pyreq-rs 0.1.0 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate pyreq-rs 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 3 packages to latest compatible versions [INFO] [stderr] Adding nom v7.1.3 (available: v8.0.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c5c503765536b44eacdcf7a7f583b9bbae3fc0d4b6e0bf75fce10eb9aad0b605 [INFO] running `Command { std: "docker" "start" "-a" "c5c503765536b44eacdcf7a7f583b9bbae3fc0d4b6e0bf75fce10eb9aad0b605", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c5c503765536b44eacdcf7a7f583b9bbae3fc0d4b6e0bf75fce10eb9aad0b605", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c5c503765536b44eacdcf7a7f583b9bbae3fc0d4b6e0bf75fce10eb9aad0b605", kill_on_drop: false }` [INFO] [stdout] c5c503765536b44eacdcf7a7f583b9bbae3fc0d4b6e0bf75fce10eb9aad0b605 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d90a5e958d1ee5a5ae4ea16eb2ed142d6961dca781f38e8442f02e1090ee64b7 [INFO] running `Command { std: "docker" "start" "-a" "d90a5e958d1ee5a5ae4ea16eb2ed142d6961dca781f38e8442f02e1090ee64b7", kill_on_drop: false }` [INFO] [stderr] Checking pyreq-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/requirements.rs:306:33 [INFO] [stdout] | [INFO] [stdout] 306 | static INFINITY_PRE_POST_DEV: (&'static str, u64) = ("~", u64::MAX); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/requirements.rs:307:42 [INFO] [stdout] | [INFO] [stdout] 307 | static NEGATIVE_INFINITY_PRE_POST_DEV: (&'static str, u64) = ("!", 0); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/requirements.rs:306:33 [INFO] [stdout] | [INFO] [stdout] 306 | static INFINITY_PRE_POST_DEV: (&'static str, u64) = ("~", u64::MAX); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/requirements.rs:307:42 [INFO] [stdout] | [INFO] [stdout] 307 | static NEGATIVE_INFINITY_PRE_POST_DEV: (&'static str, u64) = ("!", 0); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/parser/requirement_specifier.rs:286:24 [INFO] [stdout] | [INFO] [stdout] 286 | version_specs: if let Some(j) = v { j } else { vec![] }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: ascribe the type std::vec::Vec and replace your expression with: `v.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a suffix manually [INFO] [stdout] --> src/requirements.rs:119:54 [INFO] [stdout] | [INFO] [stdout] 119 | if let Ok(("", spec_v)) = version_scheme(&spec[..spec.len() - 2]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the suffix was tested here [INFO] [stdout] --> src/requirements.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | if spec.ends_with(".*") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_suffix` method [INFO] [stdout] | [INFO] [stdout] 118 ~ if let Some() = spec.strip_suffix(".*") { [INFO] [stdout] 119 ~ if let Ok(("", spec_v)) = version_scheme() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/requirements.rs:171:16 [INFO] [stdout] | [INFO] [stdout] 171 | if !(prospective < &spec_v) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(prospective >= &spec_v)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/requirements.rs:174:13 [INFO] [stdout] | [INFO] [stdout] 174 | / if !spec_v.is_prerelease() && prospective.is_prerelease() { [INFO] [stdout] 175 | | if prospective.to_base() == spec_v.to_base() { [INFO] [stdout] 176 | | return false; [INFO] [stdout] 177 | | } [INFO] [stdout] 178 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 174 ~ if !spec_v.is_prerelease() && prospective.is_prerelease() [INFO] [stdout] 175 ~ && prospective.to_base() == spec_v.to_base() { [INFO] [stdout] 176 | return false; [INFO] [stdout] 177 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/requirements.rs:186:16 [INFO] [stdout] | [INFO] [stdout] 186 | if !(prospective > &spec_v) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(prospective <= &spec_v)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/requirements.rs:189:13 [INFO] [stdout] | [INFO] [stdout] 189 | / if !spec_v.is_postrelease() && prospective.is_postrelease() { [INFO] [stdout] 190 | | if prospective.to_base() == spec_v.to_base() { [INFO] [stdout] 191 | | return false; [INFO] [stdout] 192 | | } [INFO] [stdout] 193 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 189 ~ if !spec_v.is_postrelease() && prospective.is_postrelease() [INFO] [stdout] 190 ~ && prospective.to_base() == spec_v.to_base() { [INFO] [stdout] 191 | return false; [INFO] [stdout] 192 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/requirements.rs:194:13 [INFO] [stdout] | [INFO] [stdout] 194 | / if prospective.local.is_some() { [INFO] [stdout] 195 | | if prospective.to_base() == spec_v.to_base() { [INFO] [stdout] 196 | | return false; [INFO] [stdout] 197 | | } [INFO] [stdout] 198 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 194 ~ if prospective.local.is_some() [INFO] [stdout] 195 ~ && prospective.to_base() == spec_v.to_base() { [INFO] [stdout] 196 | return false; [INFO] [stdout] 197 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/requirements.rs:311:10 [INFO] [stdout] | [INFO] [stdout] 311 | ) -> ( [INFO] [stdout] | __________^ [INFO] [stdout] 312 | | u64, [INFO] [stdout] 313 | | Vec, [INFO] [stdout] 314 | | (&str, u64), [INFO] [stdout] ... | [INFO] [stdout] 317 | | &Vec, [INFO] [stdout] 318 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> src/requirements.rs:392:20 [INFO] [stdout] | [INFO] [stdout] 392 | epoch: self.epoch.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.epoch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> src/requirements.rs:403:20 [INFO] [stdout] | [INFO] [stdout] 403 | epoch: self.epoch.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.epoch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/requirements.rs:459:17 [INFO] [stdout] | [INFO] [stdout] 459 | parts.push_str("+"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `parts.push('+')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/parser/requirement_specifier.rs:286:24 [INFO] [stdout] | [INFO] [stdout] 286 | version_specs: if let Some(j) = v { j } else { vec![] }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: ascribe the type std::vec::Vec and replace your expression with: `v.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/requirements/tests.rs:144:21 [INFO] [stdout] | [INFO] [stdout] 144 | assert!(!(vers[i] < vers[j])); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `(vers[i] >= vers[j])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/requirements/tests.rs:149:21 [INFO] [stdout] | [INFO] [stdout] 149 | assert!(!(vers[i] <= vers[j])); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(vers[i] > vers[j])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/requirements/tests.rs:155:25 [INFO] [stdout] | [INFO] [stdout] 155 | assert!(!(vers[i] == vers[j])); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(vers[i] != vers[j])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/requirements/tests.rs:160:17 [INFO] [stdout] | [INFO] [stdout] 160 | assert!(!(vers[i] != vers[i])); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(vers[i] == vers[i])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/requirements/tests.rs:164:21 [INFO] [stdout] | [INFO] [stdout] 164 | assert!(!(vers[i] >= vers[j])); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(vers[i] < vers[j])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/requirements/tests.rs:169:21 [INFO] [stdout] | [INFO] [stdout] 169 | assert!(!(vers[i] > vers[j])); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `(vers[i] <= vers[j])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `vers` [INFO] [stdout] --> src/requirements/tests.rs:122:14 [INFO] [stdout] | [INFO] [stdout] 122 | for i in 0..vers.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 122 - for i in 0..vers.len() { [INFO] [stdout] 122 + for in &vers { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `vers` [INFO] [stdout] --> src/requirements/tests.rs:159:14 [INFO] [stdout] | [INFO] [stdout] 159 | for i in 0..vers.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 159 - for i in 0..vers.len() { [INFO] [stdout] 159 + for in &vers { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a suffix manually [INFO] [stdout] --> src/requirements.rs:119:54 [INFO] [stdout] | [INFO] [stdout] 119 | if let Ok(("", spec_v)) = version_scheme(&spec[..spec.len() - 2]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the suffix was tested here [INFO] [stdout] --> src/requirements.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | if spec.ends_with(".*") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_suffix` method [INFO] [stdout] | [INFO] [stdout] 118 ~ if let Some() = spec.strip_suffix(".*") { [INFO] [stdout] 119 ~ if let Ok(("", spec_v)) = version_scheme() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/requirements.rs:171:16 [INFO] [stdout] | [INFO] [stdout] 171 | if !(prospective < &spec_v) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(prospective >= &spec_v)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/requirements.rs:174:13 [INFO] [stdout] | [INFO] [stdout] 174 | / if !spec_v.is_prerelease() && prospective.is_prerelease() { [INFO] [stdout] 175 | | if prospective.to_base() == spec_v.to_base() { [INFO] [stdout] 176 | | return false; [INFO] [stdout] 177 | | } [INFO] [stdout] 178 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 174 ~ if !spec_v.is_prerelease() && prospective.is_prerelease() [INFO] [stdout] 175 ~ && prospective.to_base() == spec_v.to_base() { [INFO] [stdout] 176 | return false; [INFO] [stdout] 177 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/requirements.rs:186:16 [INFO] [stdout] | [INFO] [stdout] 186 | if !(prospective > &spec_v) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(prospective <= &spec_v)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/requirements.rs:189:13 [INFO] [stdout] | [INFO] [stdout] 189 | / if !spec_v.is_postrelease() && prospective.is_postrelease() { [INFO] [stdout] 190 | | if prospective.to_base() == spec_v.to_base() { [INFO] [stdout] 191 | | return false; [INFO] [stdout] 192 | | } [INFO] [stdout] 193 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 189 ~ if !spec_v.is_postrelease() && prospective.is_postrelease() [INFO] [stdout] 190 ~ && prospective.to_base() == spec_v.to_base() { [INFO] [stdout] 191 | return false; [INFO] [stdout] 192 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/requirements.rs:194:13 [INFO] [stdout] | [INFO] [stdout] 194 | / if prospective.local.is_some() { [INFO] [stdout] 195 | | if prospective.to_base() == spec_v.to_base() { [INFO] [stdout] 196 | | return false; [INFO] [stdout] 197 | | } [INFO] [stdout] 198 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 194 ~ if prospective.local.is_some() [INFO] [stdout] 195 ~ && prospective.to_base() == spec_v.to_base() { [INFO] [stdout] 196 | return false; [INFO] [stdout] 197 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/requirements.rs:311:10 [INFO] [stdout] | [INFO] [stdout] 311 | ) -> ( [INFO] [stdout] | __________^ [INFO] [stdout] 312 | | u64, [INFO] [stdout] 313 | | Vec, [INFO] [stdout] 314 | | (&str, u64), [INFO] [stdout] ... | [INFO] [stdout] 317 | | &Vec, [INFO] [stdout] 318 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> src/requirements.rs:392:20 [INFO] [stdout] | [INFO] [stdout] 392 | epoch: self.epoch.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.epoch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> src/requirements.rs:403:20 [INFO] [stdout] | [INFO] [stdout] 403 | epoch: self.epoch.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.epoch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/requirements.rs:459:17 [INFO] [stdout] | [INFO] [stdout] 459 | parts.push_str("+"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `parts.push('+')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.09s [INFO] running `Command { std: "docker" "inspect" "d90a5e958d1ee5a5ae4ea16eb2ed142d6961dca781f38e8442f02e1090ee64b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d90a5e958d1ee5a5ae4ea16eb2ed142d6961dca781f38e8442f02e1090ee64b7", kill_on_drop: false }` [INFO] [stdout] d90a5e958d1ee5a5ae4ea16eb2ed142d6961dca781f38e8442f02e1090ee64b7