[INFO] fetching crate punch 0.1.2...
[INFO] linting punch-0.1.2 against nightly for clippy-nonminimal_bool-denied
[INFO] extracting crate punch 0.1.2 into /workspace/builds/worker-5-tc1/source
[INFO] started tweaking crates.io crate punch 0.1.2
[INFO] finished tweaking crates.io crate punch 0.1.2
[INFO] tweaked toml for crates.io crate punch 0.1.2 written to /workspace/builds/worker-5-tc1/source/Cargo.toml
[INFO] validating manifest of crates.io crate punch 0.1.2 on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]      Locking 21 packages to latest compatible versions
[INFO] [stderr]       Adding chrono v0.2.25 (available: v0.4.44)
[INFO] [stderr]       Adding clap v2.34.0 (available: v4.6.0)
[INFO] [stderr]       Adding wasi v0.10.0+wasi-snapshot-preview1 (available: v0.10.2+wasi-snapshot-preview1)
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded chrono v0.2.25
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] b2f60a71296ca000b69cefa5993819a954ec51fb4c5a115397fbb8c496050c7a
[INFO] running `Command { std: "docker" "start" "-a" "b2f60a71296ca000b69cefa5993819a954ec51fb4c5a115397fbb8c496050c7a", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "b2f60a71296ca000b69cefa5993819a954ec51fb4c5a115397fbb8c496050c7a", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "b2f60a71296ca000b69cefa5993819a954ec51fb4c5a115397fbb8c496050c7a", kill_on_drop: false }`
[INFO] [stdout] b2f60a71296ca000b69cefa5993819a954ec51fb4c5a115397fbb8c496050c7a
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 268ae101c463ed8ac3c693cfd40eae7b67983d447a83b6d429e1cf2db3569651
[INFO] running `Command { std: "docker" "start" "-a" "268ae101c463ed8ac3c693cfd40eae7b67983d447a83b6d429e1cf2db3569651", kill_on_drop: false }`
[INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] [stderr]     Checking num-iter v0.1.45
[INFO] [stderr]     Checking atty v0.2.14
[INFO] [stderr]     Checking num v0.1.43
[INFO] [stderr]     Checking chrono v0.2.25
[INFO] [stderr]     Checking clap v2.34.0
[INFO] [stderr]     Checking punch v0.1.2 (/opt/rustwide/workdir)
[INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead
[INFO] [stdout]    --> src/main.rs:365:5
[INFO] [stdout]     |
[INFO] [stdout] 365 |     try!(dir_builder.create(config_path));
[INFO] [stdout]     |     ^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(deprecated)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead
[INFO] [stdout]    --> src/main.rs:365:5
[INFO] [stdout]     |
[INFO] [stdout] 365 |     try!(dir_builder.create(config_path));
[INFO] [stdout]     |     ^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(deprecated)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:155:6
[INFO] [stdout]     |
[INFO] [stdout] 155 |         if !read_attempt.is_ok() || record.timestamp < start_time {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^ help: try: `read_attempt.is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:297:2
[INFO] [stdout]     |
[INFO] [stdout] 297 | /     return seek_to_record_offset(config_file, offset_from_end).
[INFO] [stdout] 298 | |         and_then(|_| populate_record_at_current_offset(config_file, record))
[INFO] [stdout]     | |____________________________________________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 297 ~     seek_to_record_offset(config_file, offset_from_end).
[INFO] [stdout] 298 ~         and_then(|_| populate_record_at_current_offset(config_file, record))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting integer literal to `u8` is unnecessary
[INFO] [stdout]    --> src/main.rs:302:18
[INFO] [stdout]     |
[INFO] [stdout] 302 |     let mut data = [0 as u8; RECORD_LENGTH];
[INFO] [stdout]     |                     ^^^^^^^ help: try: `0_u8`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/main.rs:308:33
[INFO] [stdout]     |
[INFO] [stdout] 308 |     let timestamp = str::from_utf8(&ts_data).unwrap();
[INFO] [stdout]     |                                    ^^^^^^^^ help: change this to: `ts_data`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/main.rs:309:51
[INFO] [stdout]     |
[INFO] [stdout] 309 |     let parse_result = chrono::UTC.datetime_from_str(&timestamp, "%FT%T");
[INFO] [stdout]     |                                                      ^^^^^^^^^^ help: change this to: `timestamp`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/main.rs:313:37
[INFO] [stdout]     |
[INFO] [stdout] 313 |     let action_string = str::from_utf8(&rest).unwrap();
[INFO] [stdout]     |                                        ^^^^^ help: change this to: `rest`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:155:6
[INFO] [stdout]     |
[INFO] [stdout] 155 |         if !read_attempt.is_ok() || record.timestamp < start_time {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^ help: try: `read_attempt.is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:337:5
[INFO] [stdout]     |
[INFO] [stdout] 337 |     if !seek_result.is_ok() {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^ help: try: `seek_result.is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined
[INFO] [stdout]    --> src/main.rs:368:30
[INFO] [stdout]     |
[INFO] [stdout] 368 |     match OpenOptions::new().create(true).write(true).open(conf_file) {
[INFO] [stdout]     |                              ^^^^^^^^^^^^- help: add: `.truncate(true)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: if you intend to overwrite an existing file entirely, call `.truncate(true)`
[INFO] [stdout]     = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)`
[INFO] [stdout]     = help: alternatively, use `.append(true)` to append to the file instead of overwriting it
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options
[INFO] [stdout]     = note: `#[warn(clippy::suspicious_open_options)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:297:2
[INFO] [stdout]     |
[INFO] [stdout] 297 | /     return seek_to_record_offset(config_file, offset_from_end).
[INFO] [stdout] 298 | |         and_then(|_| populate_record_at_current_offset(config_file, record))
[INFO] [stdout]     | |____________________________________________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 297 ~     seek_to_record_offset(config_file, offset_from_end).
[INFO] [stdout] 298 ~         and_then(|_| populate_record_at_current_offset(config_file, record))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting integer literal to `u8` is unnecessary
[INFO] [stdout]    --> src/main.rs:302:18
[INFO] [stdout]     |
[INFO] [stdout] 302 |     let mut data = [0 as u8; RECORD_LENGTH];
[INFO] [stdout]     |                     ^^^^^^^ help: try: `0_u8`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/main.rs:308:33
[INFO] [stdout]     |
[INFO] [stdout] 308 |     let timestamp = str::from_utf8(&ts_data).unwrap();
[INFO] [stdout]     |                                    ^^^^^^^^ help: change this to: `ts_data`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/main.rs:309:51
[INFO] [stdout]     |
[INFO] [stdout] 309 |     let parse_result = chrono::UTC.datetime_from_str(&timestamp, "%FT%T");
[INFO] [stdout]     |                                                      ^^^^^^^^^^ help: change this to: `timestamp`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/main.rs:313:37
[INFO] [stdout]     |
[INFO] [stdout] 313 |     let action_string = str::from_utf8(&rest).unwrap();
[INFO] [stdout]     |                                        ^^^^^ help: change this to: `rest`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:337:5
[INFO] [stdout]     |
[INFO] [stdout] 337 |     if !seek_result.is_ok() {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^ help: try: `seek_result.is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined
[INFO] [stdout]    --> src/main.rs:368:30
[INFO] [stdout]     |
[INFO] [stdout] 368 |     match OpenOptions::new().create(true).write(true).open(conf_file) {
[INFO] [stdout]     |                              ^^^^^^^^^^^^- help: add: `.truncate(true)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: if you intend to overwrite an existing file entirely, call `.truncate(true)`
[INFO] [stdout]     = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)`
[INFO] [stdout]     = help: alternatively, use `.append(true)` to append to the file instead of overwriting it
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options
[INFO] [stdout]     = note: `#[warn(clippy::suspicious_open_options)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.69s
[INFO] running `Command { std: "docker" "inspect" "268ae101c463ed8ac3c693cfd40eae7b67983d447a83b6d429e1cf2db3569651", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "268ae101c463ed8ac3c693cfd40eae7b67983d447a83b6d429e1cf2db3569651", kill_on_drop: false }`
[INFO] [stdout] 268ae101c463ed8ac3c693cfd40eae7b67983d447a83b6d429e1cf2db3569651