[INFO] fetching crate puff 0.1.7... [INFO] linting puff-0.1.7 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate puff 0.1.7 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate puff 0.1.7 [INFO] finished tweaking crates.io crate puff 0.1.7 [INFO] tweaked toml for crates.io crate puff 0.1.7 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate puff 0.1.7 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate puff 0.1.7 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded symlink v0.1.0 [INFO] [stderr] Downloaded fastrand v1.6.0 [INFO] [stderr] Downloaded itoa v1.0.1 [INFO] [stderr] Downloaded tempfile v3.3.0 [INFO] [stderr] Downloaded proc-macro2 v1.0.36 [INFO] [stderr] Downloaded dirs-sys v0.3.6 [INFO] [stderr] Downloaded redox_users v0.4.0 [INFO] [stderr] Downloaded quote v1.0.14 [INFO] [stderr] Downloaded unicode-width v0.1.9 [INFO] [stderr] Downloaded ryu v1.0.9 [INFO] [stderr] Downloaded structopt v0.3.25 [INFO] [stderr] Downloaded serde_derive v1.0.133 [INFO] [stderr] Downloaded unicode-segmentation v1.8.0 [INFO] [stderr] Downloaded structopt-derive v0.4.18 [INFO] [stderr] Downloaded serde_json v1.0.74 [INFO] [stderr] Downloaded serde v1.0.133 [INFO] [stderr] Downloaded syn v1.0.85 [INFO] [stderr] Downloaded libc v0.2.112 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 11f75770015fcb67028258f88d35e4a0661f578061f7ab406191cb229b7aae9f [INFO] running `Command { std: "docker" "start" "-a" "11f75770015fcb67028258f88d35e4a0661f578061f7ab406191cb229b7aae9f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "11f75770015fcb67028258f88d35e4a0661f578061f7ab406191cb229b7aae9f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "11f75770015fcb67028258f88d35e4a0661f578061f7ab406191cb229b7aae9f", kill_on_drop: false }` [INFO] [stdout] 11f75770015fcb67028258f88d35e4a0661f578061f7ab406191cb229b7aae9f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0d2b0d9c9c42aadec599afb12617180f022b13f842de6c67b2ef3ca4be50e1c3 [INFO] running `Command { std: "docker" "start" "-a" "0d2b0d9c9c42aadec599afb12617180f022b13f842de6c67b2ef3ca4be50e1c3", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling libc v0.2.112 [INFO] [stderr] Compiling syn v1.0.85 [INFO] [stderr] Compiling serde_derive v1.0.133 [INFO] [stderr] Compiling serde v1.0.133 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling unicode-segmentation v1.8.0 [INFO] [stderr] Compiling serde_json v1.0.74 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Checking fastrand v1.6.0 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Checking symlink v0.1.0 [INFO] [stderr] Compiling quote v1.0.14 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking dirs-sys v0.3.6 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking directories v4.0.1 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Checking structopt v0.3.25 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking puff v0.1.7 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/error.rs:4:21 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct AppError(pub(crate) String); [INFO] [stdout] | -------- ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `AppError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/app_init.rs:39:43 [INFO] [stdout] | [INFO] [stdout] 39 | let mut file = match File::create(&file_path) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `file_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/commands/add_command.rs:60:23 [INFO] [stdout] | [INFO] [stdout] 60 | message = format!("It was symlinked to an existing file managed by puff."); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"It was symlinked to an existing file managed by puff.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/commands/add_command.rs:64:23 [INFO] [stdout] | [INFO] [stdout] 64 | message = format!("File's content has been persisted."); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"File's content has been persisted.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/add_command.rs:107:49 [INFO] [stdout] | [INFO] [stdout] 107 | if let Ok(symlink_path) = fs::read_link(&user_file) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `user_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/add_command.rs:153:18 [INFO] [stdout] | [INFO] [stdout] 153 | fs::copy(&user_path, &new_path)?; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `user_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commands/project_rm_command.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 85 | if !project_details.user_dir.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `project_details.user_dir.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/error.rs:4:21 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct AppError(pub(crate) String); [INFO] [stdout] | -------- ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `AppError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/app_init.rs:39:43 [INFO] [stdout] | [INFO] [stdout] 39 | let mut file = match File::create(&file_path) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `file_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `.write(true)` because there is `.append(true)` [INFO] [stdout] --> src/git_ignore.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | .write(true) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove `.write(true)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options [INFO] [stdout] = note: `#[warn(clippy::ineffective_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/commands/add_command.rs:14:36 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new(locations_provider: &LocationsProvider) -> AddCommand { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new(locations_provider: &LocationsProvider) -> AddCommand<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/commands/add_command.rs:60:23 [INFO] [stdout] | [INFO] [stdout] 60 | message = format!("It was symlinked to an existing file managed by puff."); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"It was symlinked to an existing file managed by puff.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/commands/add_command.rs:64:23 [INFO] [stdout] | [INFO] [stdout] 64 | message = format!("File's content has been persisted."); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"File's content has been persisted.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/add_command.rs:107:49 [INFO] [stdout] | [INFO] [stdout] 107 | if let Ok(symlink_path) = fs::read_link(&user_file) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `user_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/add_command.rs:153:18 [INFO] [stdout] | [INFO] [stdout] 153 | fs::copy(&user_path, &new_path)?; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `user_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/commands/add_command.rs:193:9 [INFO] [stdout] | [INFO] [stdout] 193 | let _project_dir = fs::create_dir_all(puff_dir.path().join("configs/proj1")).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 193 - let _project_dir = fs::create_dir_all(puff_dir.path().join("configs/proj1")).unwrap(); [INFO] [stdout] 193 + fs::create_dir_all(puff_dir.path().join("configs/proj1")).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commands/project_rm_command.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 85 | if !project_details.user_dir.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `project_details.user_dir.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/config/projects.rs:205:17 [INFO] [stdout] | [INFO] [stdout] 205 | assert!(result.len() == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `result.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/project_init/existing.rs:154:37 [INFO] [stdout] | [INFO] [stdout] 154 | let mut file = File::create(&path).unwrap(); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `.write(true)` because there is `.append(true)` [INFO] [stdout] --> src/git_ignore.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | .write(true) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove `.write(true)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options [INFO] [stdout] = note: `#[warn(clippy::ineffective_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/commands/add_command.rs:14:36 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new(locations_provider: &LocationsProvider) -> AddCommand { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new(locations_provider: &LocationsProvider) -> AddCommand<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 19.00s [INFO] running `Command { std: "docker" "inspect" "0d2b0d9c9c42aadec599afb12617180f022b13f842de6c67b2ef3ca4be50e1c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0d2b0d9c9c42aadec599afb12617180f022b13f842de6c67b2ef3ca4be50e1c3", kill_on_drop: false }` [INFO] [stdout] 0d2b0d9c9c42aadec599afb12617180f022b13f842de6c67b2ef3ca4be50e1c3