[INFO] fetching crate psi_device_tree 2.2.0... [INFO] linting psi_device_tree-2.2.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate psi_device_tree 2.2.0 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate psi_device_tree 2.2.0 [INFO] finished tweaking crates.io crate psi_device_tree 2.2.0 [INFO] tweaked toml for crates.io crate psi_device_tree 2.2.0 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate psi_device_tree 2.2.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate psi_device_tree 2.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serde v1.0.195 [INFO] [stderr] Downloaded proc-macro2 v1.0.76 [INFO] [stderr] Downloaded serde_derive v1.0.195 [INFO] [stderr] Downloaded syn v2.0.48 [INFO] [stderr] Downloaded serde_json v1.0.111 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fcae8b0ebd5fd8d70a49437b69adc79869d720382e74dd9f429ca18dd6a43a67 [INFO] running `Command { std: "docker" "start" "-a" "fcae8b0ebd5fd8d70a49437b69adc79869d720382e74dd9f429ca18dd6a43a67", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fcae8b0ebd5fd8d70a49437b69adc79869d720382e74dd9f429ca18dd6a43a67", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fcae8b0ebd5fd8d70a49437b69adc79869d720382e74dd9f429ca18dd6a43a67", kill_on_drop: false }` [INFO] [stdout] fcae8b0ebd5fd8d70a49437b69adc79869d720382e74dd9f429ca18dd6a43a67 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5b07314cce429ea706e9dfe413d1be5b36d66d07c8940e50ce633f329c9ef66a [INFO] running `Command { std: "docker" "start" "-a" "5b07314cce429ea706e9dfe413d1be5b36d66d07c8940e50ce633f329c9ef66a", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.76 [INFO] [stderr] Compiling serde v1.0.195 [INFO] [stderr] Compiling serde_json v1.0.111 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking ahash v0.8.7 [INFO] [stderr] Checking hashbrown v0.13.2 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Compiling serde_derive v1.0.195 [INFO] [stderr] Checking psi_device_tree v2.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/util.rs:18:6 [INFO] [stdout] | [INFO] [stdout] 18 | impl<'a> SliceRead for &'a [u8] { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 18 - impl<'a> SliceRead for &'a [u8] { [INFO] [stdout] 18 + impl SliceRead for &[u8] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/util.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 21 | if !(pos + 4 <= self.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(pos + 4 > self.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/util.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 33 | if !(pos + 8 <= self.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(pos + 8 > self.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/util.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 61 | if !(end < self.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(end >= self.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/util.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 78 | if pos % 4 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^ help: replace with: `!pos.is_multiple_of(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/util.rs:98:12 [INFO] [stdout] | [INFO] [stdout] 98 | if pos % 8 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^ help: replace with: `!pos.is_multiple_of(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> tests/roundtrip.rs:15:10 [INFO] [stdout] | [INFO] [stdout] 15 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> examples/dump.rs:17:10 [INFO] [stdout] | [INFO] [stdout] 17 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/util.rs:18:6 [INFO] [stdout] | [INFO] [stdout] 18 | impl<'a> SliceRead for &'a [u8] { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 18 - impl<'a> SliceRead for &'a [u8] { [INFO] [stdout] 18 + impl SliceRead for &[u8] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/util.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 21 | if !(pos + 4 <= self.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(pos + 4 > self.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/util.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 33 | if !(pos + 8 <= self.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(pos + 8 > self.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/util.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 61 | if !(end < self.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(end >= self.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/util.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 78 | if pos % 4 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^ help: replace with: `!pos.is_multiple_of(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/util.rs:98:12 [INFO] [stdout] | [INFO] [stdout] 98 | if pos % 8 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^ help: replace with: `!pos.is_multiple_of(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.13s [INFO] running `Command { std: "docker" "inspect" "5b07314cce429ea706e9dfe413d1be5b36d66d07c8940e50ce633f329c9ef66a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5b07314cce429ea706e9dfe413d1be5b36d66d07c8940e50ce633f329c9ef66a", kill_on_drop: false }` [INFO] [stdout] 5b07314cce429ea706e9dfe413d1be5b36d66d07c8940e50ce633f329c9ef66a