[INFO] fetching crate psa 0.1.1... [INFO] linting psa-0.1.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate psa 0.1.1 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate psa 0.1.1 [INFO] finished tweaking crates.io crate psa 0.1.1 [INFO] tweaked toml for crates.io crate psa 0.1.1 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate psa 0.1.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 23 packages to latest compatible versions [INFO] [stderr] Adding erased-serde v0.3.31 (available: v0.4.10) [INFO] [stderr] Adding maplit v0.1.6 (available: v1.0.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded maplit v0.1.6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 84a3f7670c057f24d03178d3964d758dfbf9ba2da2c0b7061605285092a9a83a [INFO] running `Command { std: "docker" "start" "-a" "84a3f7670c057f24d03178d3964d758dfbf9ba2da2c0b7061605285092a9a83a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "84a3f7670c057f24d03178d3964d758dfbf9ba2da2c0b7061605285092a9a83a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "84a3f7670c057f24d03178d3964d758dfbf9ba2da2c0b7061605285092a9a83a", kill_on_drop: false }` [INFO] [stdout] 84a3f7670c057f24d03178d3964d758dfbf9ba2da2c0b7061605285092a9a83a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cdedd4b3d9c48bad8556a882b23764299c58e084b1e6aa154dd3d10928623455 [INFO] running `Command { std: "docker" "start" "-a" "cdedd4b3d9c48bad8556a882b23764299c58e084b1e6aa154dd3d10928623455", kill_on_drop: false }` [INFO] [stderr] Checking maplit v0.1.6 [INFO] [stderr] Checking erased-serde v0.3.31 [INFO] [stderr] Checking psa v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/jvm/maven_module.rs:29:46 [INFO] [stdout] | [INFO] [stdout] 29 | self.detect_source_root(module_path, &mut module); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `module` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/jvm/maven_module.rs:30:48 [INFO] [stdout] | [INFO] [stdout] 30 | self.detect_resource_root(module_path, &mut module); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `module` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/jvm/maven_module.rs:31:51 [INFO] [stdout] | [INFO] [stdout] 31 | self.detect_test_source_root(module_path, &mut module); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `module` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/jvm/maven_module.rs:32:53 [INFO] [stdout] | [INFO] [stdout] 32 | self.detect_test_resource_root(module_path, &mut module); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `module` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/jvm/maven_module.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | / match source_root { [INFO] [stdout] 39 | | Some(source_root) => module.as_mut().unwrap().add_source_root(source_root), [INFO] [stdout] 40 | | _ => (), [INFO] [stdout] 41 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(source_root) = source_root { module.as_mut().unwrap().add_source_root(source_root) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/jvm/maven_module.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | / match resource_root { [INFO] [stdout] 48 | | Some(resource_root) => module.as_mut().unwrap().add_resource_root(resource_root), [INFO] [stdout] 49 | | _ => (), [INFO] [stdout] 50 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(resource_root) = resource_root { module.as_mut().unwrap().add_resource_root(resource_root) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/jvm/maven_module.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | / match test_source_root { [INFO] [stdout] 57 | | Some(test_source_root) => module [INFO] [stdout] 58 | | .as_mut() [INFO] [stdout] 59 | | .unwrap() [INFO] [stdout] 60 | | .add_test_source_root(test_source_root), [INFO] [stdout] 61 | | _ => (), [INFO] [stdout] 62 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 56 ~ if let Some(test_source_root) = test_source_root { module [INFO] [stdout] 57 + .as_mut() [INFO] [stdout] 58 + .unwrap() [INFO] [stdout] 59 + .add_test_source_root(test_source_root) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/jvm/maven_module.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | / match test_resource_root { [INFO] [stdout] 69 | | Some(test_resource_root) => module [INFO] [stdout] 70 | | .as_mut() [INFO] [stdout] 71 | | .unwrap() [INFO] [stdout] 72 | | .add_test_resource_root(test_resource_root), [INFO] [stdout] 73 | | _ => (), [INFO] [stdout] 74 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 68 ~ if let Some(test_resource_root) = test_resource_root { module [INFO] [stdout] 69 + .as_mut() [INFO] [stdout] 70 + .unwrap() [INFO] [stdout] 71 + .add_test_resource_root(test_resource_root) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/jvm/maven_module.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 81 | if !module.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `module.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/jvm/maven_module.rs:82:37 [INFO] [stdout] | [INFO] [stdout] 82 | self.detect_sub_modules(&module_path, &mut module); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `module_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/jvm/psa_jvm.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | / match module { [INFO] [stdout] 21 | | Some(module) => modules.push(module), [INFO] [stdout] 22 | | _ => (), [INFO] [stdout] 23 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(module) = module { modules.push(module) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/jvm/psa_jvm.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | / return match build_file.as_str() { [INFO] [stdout] 71 | | "pom.xml" => "maven".to_string(), [INFO] [stdout] 72 | | _ => "UnKnow".to_string(), [INFO] [stdout] 73 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 ~ match build_file.as_str() { [INFO] [stdout] 71 + "pom.xml" => "maven".to_string(), [INFO] [stdout] 72 + _ => "UnKnow".to_string(), [INFO] [stdout] 73 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/jvm/psa_jvm.rs:91:5 [INFO] [stdout] | [INFO] [stdout] 91 | / match file_name { [INFO] [stdout] 92 | | "pom.xml" => true, [INFO] [stdout] 93 | | "build.gradle" => true, [INFO] [stdout] 94 | | _ => false, [INFO] [stdout] 95 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 91 - match file_name { [INFO] [stdout] 92 - "pom.xml" => true, [INFO] [stdout] 93 - "build.gradle" => true, [INFO] [stdout] 94 - _ => false, [INFO] [stdout] 95 - } [INFO] [stdout] 91 + matches!(file_name, "pom.xml" | "build.gradle") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/pas_content_root.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 | / impl Default for ContentRoot { [INFO] [stdout] 27 | | fn default() -> Self { [INFO] [stdout] 28 | | ContentRoot { [INFO] [stdout] 29 | | source_root: vec![], [INFO] [stdout] ... | [INFO] [stdout] 35 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 1 + #[derive(Default)] [INFO] [stdout] 2 | pub struct ContentRoot { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/jvm/maven_module.rs:29:46 [INFO] [stdout] | [INFO] [stdout] 29 | self.detect_source_root(module_path, &mut module); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `module` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/jvm/maven_module.rs:30:48 [INFO] [stdout] | [INFO] [stdout] 30 | self.detect_resource_root(module_path, &mut module); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `module` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/jvm/maven_module.rs:31:51 [INFO] [stdout] | [INFO] [stdout] 31 | self.detect_test_source_root(module_path, &mut module); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `module` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/jvm/maven_module.rs:32:53 [INFO] [stdout] | [INFO] [stdout] 32 | self.detect_test_resource_root(module_path, &mut module); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `module` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/jvm/maven_module.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | / match source_root { [INFO] [stdout] 39 | | Some(source_root) => module.as_mut().unwrap().add_source_root(source_root), [INFO] [stdout] 40 | | _ => (), [INFO] [stdout] 41 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(source_root) = source_root { module.as_mut().unwrap().add_source_root(source_root) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/jvm/maven_module.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | / match resource_root { [INFO] [stdout] 48 | | Some(resource_root) => module.as_mut().unwrap().add_resource_root(resource_root), [INFO] [stdout] 49 | | _ => (), [INFO] [stdout] 50 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(resource_root) = resource_root { module.as_mut().unwrap().add_resource_root(resource_root) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/jvm/maven_module.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | / match test_source_root { [INFO] [stdout] 57 | | Some(test_source_root) => module [INFO] [stdout] 58 | | .as_mut() [INFO] [stdout] 59 | | .unwrap() [INFO] [stdout] 60 | | .add_test_source_root(test_source_root), [INFO] [stdout] 61 | | _ => (), [INFO] [stdout] 62 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 56 ~ if let Some(test_source_root) = test_source_root { module [INFO] [stdout] 57 + .as_mut() [INFO] [stdout] 58 + .unwrap() [INFO] [stdout] 59 + .add_test_source_root(test_source_root) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/jvm/maven_module.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | / match test_resource_root { [INFO] [stdout] 69 | | Some(test_resource_root) => module [INFO] [stdout] 70 | | .as_mut() [INFO] [stdout] 71 | | .unwrap() [INFO] [stdout] 72 | | .add_test_resource_root(test_resource_root), [INFO] [stdout] 73 | | _ => (), [INFO] [stdout] 74 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 68 ~ if let Some(test_resource_root) = test_resource_root { module [INFO] [stdout] 69 + .as_mut() [INFO] [stdout] 70 + .unwrap() [INFO] [stdout] 71 + .add_test_resource_root(test_resource_root) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/jvm/maven_module.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 81 | if !module.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `module.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/jvm/maven_module.rs:82:37 [INFO] [stdout] | [INFO] [stdout] 82 | self.detect_sub_modules(&module_path, &mut module); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `module_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/jvm/psa_jvm.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | / match module { [INFO] [stdout] 21 | | Some(module) => modules.push(module), [INFO] [stdout] 22 | | _ => (), [INFO] [stdout] 23 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(module) = module { modules.push(module) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/jvm/psa_jvm.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | / return match build_file.as_str() { [INFO] [stdout] 71 | | "pom.xml" => "maven".to_string(), [INFO] [stdout] 72 | | _ => "UnKnow".to_string(), [INFO] [stdout] 73 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 ~ match build_file.as_str() { [INFO] [stdout] 71 + "pom.xml" => "maven".to_string(), [INFO] [stdout] 72 + _ => "UnKnow".to_string(), [INFO] [stdout] 73 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/jvm/psa_jvm.rs:91:5 [INFO] [stdout] | [INFO] [stdout] 91 | / match file_name { [INFO] [stdout] 92 | | "pom.xml" => true, [INFO] [stdout] 93 | | "build.gradle" => true, [INFO] [stdout] 94 | | _ => false, [INFO] [stdout] 95 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 91 - match file_name { [INFO] [stdout] 92 - "pom.xml" => true, [INFO] [stdout] 93 - "build.gradle" => true, [INFO] [stdout] 94 - _ => false, [INFO] [stdout] 95 - } [INFO] [stdout] 91 + matches!(file_name, "pom.xml" | "build.gradle") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `modules.get(0)` [INFO] [stdout] --> src/jvm/psa_jvm.rs:116:30 [INFO] [stdout] | [INFO] [stdout] 116 | let project_module = modules.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `modules.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `project_module.sub_modules.get(0)` [INFO] [stdout] --> src/jvm/psa_jvm.rs:117:23 [INFO] [stdout] | [INFO] [stdout] 117 | let module1 = project_module.sub_modules.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `project_module.sub_modules.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `modules.get(0)` [INFO] [stdout] --> src/jvm/psa_jvm.rs:136:30 [INFO] [stdout] | [INFO] [stdout] 136 | let project_module = modules.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `modules.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `project_content_root.source_root.get(0)` [INFO] [stdout] --> src/jvm/psa_jvm.rs:143:13 [INFO] [stdout] | [INFO] [stdout] 143 | project_content_root.source_root.get(0).unwrap().as_str(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `project_content_root.source_root.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `project_content_root.resource_root.get(0)` [INFO] [stdout] --> src/jvm/psa_jvm.rs:153:13 [INFO] [stdout] | [INFO] [stdout] 153 | project_content_root.resource_root.get(0).unwrap().as_str(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `project_content_root.resource_root.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `project_content_root [INFO] [stdout] .test_source_root.get(0)` [INFO] [stdout] --> src/jvm/psa_jvm.rs:161:13 [INFO] [stdout] | [INFO] [stdout] 161 | / project_content_root [INFO] [stdout] 162 | | .test_source_root [INFO] [stdout] 163 | | .get(0) [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 161 ~ project_content_root [INFO] [stdout] 162 + .test_source_root.first() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `project_content_root.test_resource_root.get(0)` [INFO] [stdout] --> src/jvm/psa_jvm.rs:175:13 [INFO] [stdout] | [INFO] [stdout] 175 | project_content_root.test_resource_root.get(0).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `project_content_root.test_resource_root.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `modules.get(0)` [INFO] [stdout] --> src/jvm/psa_jvm.rs:190:30 [INFO] [stdout] | [INFO] [stdout] 190 | let project_module = modules.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `modules.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `project_module.sub_modules.get(0)` [INFO] [stdout] --> src/jvm/psa_jvm.rs:191:23 [INFO] [stdout] | [INFO] [stdout] 191 | let module1 = project_module.sub_modules.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `project_module.sub_modules.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `content_root.source_root.get(0)` [INFO] [stdout] --> src/jvm/psa_jvm.rs:196:13 [INFO] [stdout] | [INFO] [stdout] 196 | content_root.source_root.get(0).unwrap().as_str(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `content_root.source_root.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `content_root.test_source_root.get(0)` [INFO] [stdout] --> src/jvm/psa_jvm.rs:202:13 [INFO] [stdout] | [INFO] [stdout] 202 | content_root.test_source_root.get(0).unwrap().as_str(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `content_root.test_source_root.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `content_root.test_source_root.get(0)` [INFO] [stdout] --> src/jvm/psa_jvm.rs:208:13 [INFO] [stdout] | [INFO] [stdout] 208 | content_root.test_source_root.get(0).unwrap().as_str(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `content_root.test_source_root.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `content_root.test_resource_root.get(0)` [INFO] [stdout] --> src/jvm/psa_jvm.rs:215:13 [INFO] [stdout] | [INFO] [stdout] 215 | content_root.test_resource_root.get(0).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `content_root.test_resource_root.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/pas_content_root.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 | / impl Default for ContentRoot { [INFO] [stdout] 27 | | fn default() -> Self { [INFO] [stdout] 28 | | ContentRoot { [INFO] [stdout] 29 | | source_root: vec![], [INFO] [stdout] ... | [INFO] [stdout] 35 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 1 + #[derive(Default)] [INFO] [stdout] 2 | pub struct ContentRoot { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/project_structure_analyzer.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | assert_eq!(project.is_none(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 68 - assert_eq!(project.is_none(), true); [INFO] [stdout] 68 + assert!(project.is_none()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `module.libraries.get(0)` [INFO] [stdout] --> src/psa_module.rs:95:19 [INFO] [stdout] | [INFO] [stdout] 95 | let lib = module.libraries.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `module.libraries.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `module.sub_modules.get(0)` [INFO] [stdout] --> src/psa_module.rs:106:26 [INFO] [stdout] | [INFO] [stdout] 106 | let sub_module = module.sub_modules.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `module.sub_modules.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/psa_project.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | assert_eq!(project.modules.is_empty(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 40 - assert_eq!(project.modules.is_empty(), true); [INFO] [stdout] 40 + assert!(project.modules.is_empty()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.83s [INFO] running `Command { std: "docker" "inspect" "cdedd4b3d9c48bad8556a882b23764299c58e084b1e6aa154dd3d10928623455", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cdedd4b3d9c48bad8556a882b23764299c58e084b1e6aa154dd3d10928623455", kill_on_drop: false }` [INFO] [stdout] cdedd4b3d9c48bad8556a882b23764299c58e084b1e6aa154dd3d10928623455