[INFO] fetching crate ps-signalling 0.1.0... [INFO] linting ps-signalling-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate ps-signalling 0.1.0 into /workspace/builds/worker-5-tc1/source [INFO] started tweaking crates.io crate ps-signalling 0.1.0 [INFO] finished tweaking crates.io crate ps-signalling 0.1.0 [INFO] tweaked toml for crates.io crate ps-signalling 0.1.0 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate ps-signalling 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 219 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (available: v0.14.9) [INFO] [stderr] Adding warp v0.3.7 (available: v0.4.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded headers-core v0.2.0 [INFO] [stderr] Downloaded multer v2.1.0 [INFO] [stderr] Downloaded tokio-rustls v0.25.0 [INFO] [stderr] Downloaded protoc-rust v2.28.0 [INFO] [stderr] Downloaded env_filter v1.0.0 [INFO] [stderr] Downloaded protobuf-support v3.7.2 [INFO] [stderr] Downloaded protoc v2.28.0 [INFO] [stderr] Downloaded tokio-tungstenite v0.21.0 [INFO] [stderr] Downloaded colog v1.4.0 [INFO] [stderr] Downloaded env_logger v0.11.9 [INFO] [stderr] Downloaded protobuf-codegen v2.28.0 [INFO] [stderr] Downloaded protobuf-parse v3.7.2 [INFO] [stderr] Downloaded jiff-static v0.2.23 [INFO] [stderr] Downloaded warp v0.3.7 [INFO] [stderr] Downloaded protobuf-codegen v3.7.2 [INFO] [stderr] Downloaded headers v0.3.9 [INFO] [stderr] Downloaded protobuf v2.28.0 [INFO] [stderr] Downloaded tungstenite v0.21.0 [INFO] [stderr] Downloaded protobuf v3.7.2 [INFO] [stderr] Downloaded protobuf-json-mapping v3.7.2 [INFO] [stderr] Downloaded rustls v0.22.4 [INFO] [stderr] Downloaded jiff v0.2.23 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 53b9da356f57c4d0ecd46d39f251c97c28fe1570e5c5c4a97ba4c8deb06bafe1 [INFO] running `Command { std: "docker" "start" "-a" "53b9da356f57c4d0ecd46d39f251c97c28fe1570e5c5c4a97ba4c8deb06bafe1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "53b9da356f57c4d0ecd46d39f251c97c28fe1570e5c5c4a97ba4c8deb06bafe1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "53b9da356f57c4d0ecd46d39f251c97c28fe1570e5c5c4a97ba4c8deb06bafe1", kill_on_drop: false }` [INFO] [stdout] 53b9da356f57c4d0ecd46d39f251c97c28fe1570e5c5c4a97ba4c8deb06bafe1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 48dc899eb1e755cfec1893e4df5979f6f55bc7714f798d24dd56357716b0c6c4 [INFO] running `Command { std: "docker" "start" "-a" "48dc899eb1e755cfec1893e4df5979f6f55bc7714f798d24dd56357716b0c6c4", kill_on_drop: false }` [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking futures-core v0.3.32 [INFO] [stderr] Compiling bitflags v2.11.0 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Checking futures-sink v0.3.32 [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Checking socket2 v0.6.3 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Compiling protobuf v3.7.2 [INFO] [stderr] Compiling linux-raw-sys v0.4.15 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling rustix v1.1.4 [INFO] [stderr] Compiling cfg-if v1.0.4 [INFO] [stderr] Checking futures-task v0.3.32 [INFO] [stderr] Compiling either v1.15.0 [INFO] [stderr] Compiling home v0.5.12 [INFO] [stderr] Compiling linux-raw-sys v0.12.1 [INFO] [stderr] Compiling once_cell v1.21.4 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Checking is_terminal_polyfill v1.70.2 [INFO] [stderr] Checking anstyle-query v1.1.5 [INFO] [stderr] Checking colorchoice v1.0.5 [INFO] [stderr] Compiling fastrand v2.3.0 [INFO] [stderr] Compiling protobuf v2.28.0 [INFO] [stderr] Compiling memchr v2.8.0 [INFO] [stderr] Checking anstyle v1.0.14 [INFO] [stderr] Compiling anyhow v1.0.102 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking regex-syntax v0.8.10 [INFO] [stderr] Compiling hashbrown v0.16.1 [INFO] [stderr] Compiling getrandom v0.4.2 [INFO] [stderr] Compiling aho-corasick v1.1.4 [INFO] [stderr] Compiling equivalent v1.0.2 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking ring v0.17.14 [INFO] [stderr] Compiling indexmap v2.13.0 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Compiling which v4.4.2 [INFO] [stderr] Compiling tempfile v3.27.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling rustls v0.22.4 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rustls-webpki v0.102.8 [INFO] [stderr] Compiling protoc v2.28.0 [INFO] [stderr] Checking futures-channel v0.3.32 [INFO] [stderr] Checking anstyle-parse v1.0.0 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Compiling multer v2.1.0 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Checking data-encoding v2.10.0 [INFO] [stderr] Checking anstream v1.0.0 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking headers-core v0.2.0 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking clap_lex v1.1.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking env_filter v1.0.0 [INFO] [stderr] Checking jiff v0.2.23 [INFO] [stderr] Checking clap_builder v4.6.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking headers v0.3.9 [INFO] [stderr] Checking rustls-pemfile v2.2.0 [INFO] [stderr] Checking colored v3.1.1 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Checking futures-io v0.3.32 [INFO] [stderr] Checking futures v0.3.32 [INFO] [stderr] Checking uuid v1.22.0 [INFO] [stderr] Compiling protobuf-codegen v2.28.0 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tokio-macros v2.6.1 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling protoc-rust v2.28.0 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Compiling protobuf-support v3.7.2 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Compiling pin-project-internal v1.1.11 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking env_logger v0.11.9 [INFO] [stderr] Compiling clap_derive v4.6.0 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking pin-project v1.1.11 [INFO] [stderr] Checking colog v1.4.0 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking clap v4.6.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking protobuf-json-mapping v3.7.2 [INFO] [stderr] Checking tungstenite v0.21.0 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking tokio-rustls v0.25.0 [INFO] [stderr] Checking tokio-stream v0.1.18 [INFO] [stderr] Checking tokio-tungstenite v0.21.0 [INFO] [stderr] Compiling protobuf-parse v3.7.2 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Compiling protobuf-codegen v3.7.2 [INFO] [stderr] Compiling ps-signalling v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking warp v0.3.7 [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/signaller/context.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | sender: sender, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `sender` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/signaller/context.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | sender: sender, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `sender` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Context` [INFO] [stdout] --> src/signaller/context.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | / pub fn new() -> Context { [INFO] [stdout] 33 | | Context { [INFO] [stdout] 34 | | peers: HashMap::new(), [INFO] [stdout] 35 | | streamers: HashMap::new(), [INFO] [stdout] ... | [INFO] [stdout] 38 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 31 + impl Default for Context { [INFO] [stdout] 32 + fn default() -> Self { [INFO] [stdout] 33 + Self::new() [INFO] [stdout] 34 + } [INFO] [stdout] 35 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/context.rs:58:32 [INFO] [stdout] | [INFO] [stdout] 58 | streamer::on_connected(&context, &peer_id).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/context.rs:58:42 [INFO] [stdout] | [INFO] [stdout] 58 | streamer::on_connected(&context, &peer_id).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `peer_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/context.rs:60:39 [INFO] [stdout] | [INFO] [stdout] 60 | viewer::on_connected(context, &peer_id).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `peer_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/signaller/context.rs:73:17 [INFO] [stdout] | [INFO] [stdout] 73 | None => return, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: replace `return` with a unit value [INFO] [stdout] | [INFO] [stdout] 73 - None => return, [INFO] [stdout] 73 + None => (), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/streamer.rs:10:20 [INFO] [stdout] | [INFO] [stdout] 10 | send_to_client(&context, &peer_id, &config_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/streamer.rs:10:30 [INFO] [stdout] | [INFO] [stdout] 10 | send_to_client(&context, &peer_id, &config_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `peer_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/streamer.rs:13:20 [INFO] [stdout] | [INFO] [stdout] 13 | send_to_client(&context, &peer_id, &id_request_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/streamer.rs:13:30 [INFO] [stdout] | [INFO] [stdout] 13 | send_to_client(&context, &peer_id, &id_request_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `peer_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/streamer.rs:29:31 [INFO] [stdout] | [INFO] [stdout] 29 | match json_str_to_message(&msg) { [INFO] [stdout] | ^^^^ help: change this to: `msg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/streamer.rs:42:24 [INFO] [stdout] | [INFO] [stdout] 42 | send_to_client(&context, &peer_id, msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/streamer.rs:98:21 [INFO] [stdout] | [INFO] [stdout] 98 | viewer::send_to(&context, &viewer_id.to_string(), &*answer_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/streamer.rs:125:21 [INFO] [stdout] | [INFO] [stdout] 125 | viewer::send_to(&context, &viewer_id.to_string(), &*offer_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/streamer.rs:133:20 [INFO] [stdout] | [INFO] [stdout] 133 | send_to_client(&context, &from_id, &pong_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/streamer.rs:133:30 [INFO] [stdout] | [INFO] [stdout] 133 | send_to_client(&context, &from_id, &pong_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `from_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/viewer.rs:17:20 [INFO] [stdout] | [INFO] [stdout] 17 | send_to_client(&context, &peer_id, &config_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/viewer.rs:17:30 [INFO] [stdout] | [INFO] [stdout] 17 | send_to_client(&context, &peer_id, &config_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `peer_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/viewer.rs:36:31 [INFO] [stdout] | [INFO] [stdout] 36 | streamer::send_to(&context, &streamer_id, &disconnect_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/viewer.rs:43:31 [INFO] [stdout] | [INFO] [stdout] 43 | match json_str_to_message(&msg) { [INFO] [stdout] | ^^^^ help: change this to: `msg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/viewer.rs:56:24 [INFO] [stdout] | [INFO] [stdout] 56 | send_to_client(&context, &peer_id, msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/viewer.rs:96:31 [INFO] [stdout] | [INFO] [stdout] 96 | streamer::send_to(&context, &streamer_id, &*answer_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/viewer.rs:96:41 [INFO] [stdout] | [INFO] [stdout] 96 | streamer::send_to(&context, &streamer_id, &*answer_msg).await; [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `streamer_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/viewer.rs:113:31 [INFO] [stdout] | [INFO] [stdout] 113 | streamer::send_to(&context, &streamer_id, &*ice_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/viewer.rs:113:41 [INFO] [stdout] | [INFO] [stdout] 113 | streamer::send_to(&context, &streamer_id, &*ice_msg).await; [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `streamer_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/viewer.rs:124:13 [INFO] [stdout] | [INFO] [stdout] 124 | send_to(&context, &from_id, &list_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/viewer.rs:124:23 [INFO] [stdout] | [INFO] [stdout] 124 | send_to(&context, &from_id, &list_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `from_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/viewer.rs:132:31 [INFO] [stdout] | [INFO] [stdout] 132 | streamer::send_to(&context, &streamer_id, &*offer_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/viewer.rs:132:41 [INFO] [stdout] | [INFO] [stdout] 132 | streamer::send_to(&context, &streamer_id, &*offer_msg).await; [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `streamer_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/signaller/viewer.rs:163:8 [INFO] [stdout] | [INFO] [stdout] 163 | if !validated_streamer_id.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `validated_streamer_id.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/viewer.rs:153:27 [INFO] [stdout] | [INFO] [stdout] 153 | streamer::send_to(&context, &streamer_id, &disconnect_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/signaller/viewer.rs:158:9 [INFO] [stdout] | [INFO] [stdout] 158 | / match context.streamers.get(streamer_id) { [INFO] [stdout] 159 | | Some(streamer_id) => Some(streamer_id.clone()), [INFO] [stdout] 160 | | None => None, [INFO] [stdout] 161 | | } [INFO] [stdout] | |_________^ help: try: `context.streamers.get(streamer_id).map(|streamer_id| streamer_id.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/viewer.rs:171:27 [INFO] [stdout] | [INFO] [stdout] 171 | streamer::send_to(&context, &streamer_id.to_string(), &connect_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/viewer.rs:180:27 [INFO] [stdout] | [INFO] [stdout] 180 | streamer::send_to(&context, &streamer_id, &disconnect_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/signaller/protomessages.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | return msg; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return msg; [INFO] [stdout] 12 + msg [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/signaller/protomessages.rs:124:18 [INFO] [stdout] | [INFO] [stdout] 124 | Ok(m) => return Ok(MessagePair { type_name: message.type_().to_string(), message: m } ), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 124 ~ Ok(m) => Ok(MessagePair { type_name: message.type_().to_string(), message: m } ), [INFO] [stdout] 125 | Err(e) => return Err(format!("Message parse fail: {}", e)), [INFO] [stdout] 126 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/signaller/protomessages.rs:125:19 [INFO] [stdout] | [INFO] [stdout] 125 | Err(e) => return Err(format!("Message parse fail: {}", e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 125 ~ Err(e) => Err(format!("Message parse fail: {}", e)), [INFO] [stdout] 126 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/protomessages.rs:109:92 [INFO] [stdout] | [INFO] [stdout] 109 | let message = match protobuf_json_mapping::parse_from_str_with_options::(&msg, &parse_options) { [INFO] [stdout] | ^^^^ help: change this to: `msg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/protomessages.rs:117:83 [INFO] [stdout] | [INFO] [stdout] 117 | Some(descriptor) => protobuf_json_mapping::parse_dyn_from_str(descriptor, &msg), [INFO] [stdout] | ^^^^ help: change this to: `msg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/wstransport/ws.rs:159:62 [INFO] [stdout] | [INFO] [stdout] 159 | streamer::on_msg(&mut locked_context, &uuid, &msg).await; [INFO] [stdout] | ^^^^ help: change this to: `msg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/wstransport/ws.rs:161:60 [INFO] [stdout] | [INFO] [stdout] 161 | viewer::on_msg(&mut locked_context, &uuid, &msg).await; [INFO] [stdout] | ^^^^ help: change this to: `msg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Context` [INFO] [stdout] --> src/signaller/context.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | / pub fn new() -> Context { [INFO] [stdout] 33 | | Context { [INFO] [stdout] 34 | | peers: HashMap::new(), [INFO] [stdout] 35 | | streamers: HashMap::new(), [INFO] [stdout] ... | [INFO] [stdout] 38 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 31 + impl Default for Context { [INFO] [stdout] 32 + fn default() -> Self { [INFO] [stdout] 33 + Self::new() [INFO] [stdout] 34 + } [INFO] [stdout] 35 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/context.rs:58:32 [INFO] [stdout] | [INFO] [stdout] 58 | streamer::on_connected(&context, &peer_id).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/context.rs:58:42 [INFO] [stdout] | [INFO] [stdout] 58 | streamer::on_connected(&context, &peer_id).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `peer_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/context.rs:60:39 [INFO] [stdout] | [INFO] [stdout] 60 | viewer::on_connected(context, &peer_id).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `peer_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/signaller/context.rs:73:17 [INFO] [stdout] | [INFO] [stdout] 73 | None => return, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: replace `return` with a unit value [INFO] [stdout] | [INFO] [stdout] 73 - None => return, [INFO] [stdout] 73 + None => (), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/streamer.rs:10:20 [INFO] [stdout] | [INFO] [stdout] 10 | send_to_client(&context, &peer_id, &config_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/streamer.rs:10:30 [INFO] [stdout] | [INFO] [stdout] 10 | send_to_client(&context, &peer_id, &config_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `peer_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/streamer.rs:13:20 [INFO] [stdout] | [INFO] [stdout] 13 | send_to_client(&context, &peer_id, &id_request_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/streamer.rs:13:30 [INFO] [stdout] | [INFO] [stdout] 13 | send_to_client(&context, &peer_id, &id_request_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `peer_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/streamer.rs:29:31 [INFO] [stdout] | [INFO] [stdout] 29 | match json_str_to_message(&msg) { [INFO] [stdout] | ^^^^ help: change this to: `msg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/streamer.rs:42:24 [INFO] [stdout] | [INFO] [stdout] 42 | send_to_client(&context, &peer_id, msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/streamer.rs:98:21 [INFO] [stdout] | [INFO] [stdout] 98 | viewer::send_to(&context, &viewer_id.to_string(), &*answer_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/streamer.rs:125:21 [INFO] [stdout] | [INFO] [stdout] 125 | viewer::send_to(&context, &viewer_id.to_string(), &*offer_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/streamer.rs:133:20 [INFO] [stdout] | [INFO] [stdout] 133 | send_to_client(&context, &from_id, &pong_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/streamer.rs:133:30 [INFO] [stdout] | [INFO] [stdout] 133 | send_to_client(&context, &from_id, &pong_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `from_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/viewer.rs:17:20 [INFO] [stdout] | [INFO] [stdout] 17 | send_to_client(&context, &peer_id, &config_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/viewer.rs:17:30 [INFO] [stdout] | [INFO] [stdout] 17 | send_to_client(&context, &peer_id, &config_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `peer_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/viewer.rs:36:31 [INFO] [stdout] | [INFO] [stdout] 36 | streamer::send_to(&context, &streamer_id, &disconnect_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/viewer.rs:43:31 [INFO] [stdout] | [INFO] [stdout] 43 | match json_str_to_message(&msg) { [INFO] [stdout] | ^^^^ help: change this to: `msg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/viewer.rs:56:24 [INFO] [stdout] | [INFO] [stdout] 56 | send_to_client(&context, &peer_id, msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/viewer.rs:96:31 [INFO] [stdout] | [INFO] [stdout] 96 | streamer::send_to(&context, &streamer_id, &*answer_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/viewer.rs:96:41 [INFO] [stdout] | [INFO] [stdout] 96 | streamer::send_to(&context, &streamer_id, &*answer_msg).await; [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `streamer_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/viewer.rs:113:31 [INFO] [stdout] | [INFO] [stdout] 113 | streamer::send_to(&context, &streamer_id, &*ice_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/viewer.rs:113:41 [INFO] [stdout] | [INFO] [stdout] 113 | streamer::send_to(&context, &streamer_id, &*ice_msg).await; [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `streamer_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/viewer.rs:124:13 [INFO] [stdout] | [INFO] [stdout] 124 | send_to(&context, &from_id, &list_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/viewer.rs:124:23 [INFO] [stdout] | [INFO] [stdout] 124 | send_to(&context, &from_id, &list_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `from_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/viewer.rs:132:31 [INFO] [stdout] | [INFO] [stdout] 132 | streamer::send_to(&context, &streamer_id, &*offer_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/viewer.rs:132:41 [INFO] [stdout] | [INFO] [stdout] 132 | streamer::send_to(&context, &streamer_id, &*offer_msg).await; [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `streamer_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/signaller/viewer.rs:163:8 [INFO] [stdout] | [INFO] [stdout] 163 | if !validated_streamer_id.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `validated_streamer_id.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/viewer.rs:153:27 [INFO] [stdout] | [INFO] [stdout] 153 | streamer::send_to(&context, &streamer_id, &disconnect_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/signaller/viewer.rs:158:9 [INFO] [stdout] | [INFO] [stdout] 158 | / match context.streamers.get(streamer_id) { [INFO] [stdout] 159 | | Some(streamer_id) => Some(streamer_id.clone()), [INFO] [stdout] 160 | | None => None, [INFO] [stdout] 161 | | } [INFO] [stdout] | |_________^ help: try: `context.streamers.get(streamer_id).map(|streamer_id| streamer_id.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/viewer.rs:171:27 [INFO] [stdout] | [INFO] [stdout] 171 | streamer::send_to(&context, &streamer_id.to_string(), &connect_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/viewer.rs:180:27 [INFO] [stdout] | [INFO] [stdout] 180 | streamer::send_to(&context, &streamer_id, &disconnect_msg).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/signaller/protomessages.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | return msg; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return msg; [INFO] [stdout] 12 + msg [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/signaller/protomessages.rs:124:18 [INFO] [stdout] | [INFO] [stdout] 124 | Ok(m) => return Ok(MessagePair { type_name: message.type_().to_string(), message: m } ), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 124 ~ Ok(m) => Ok(MessagePair { type_name: message.type_().to_string(), message: m } ), [INFO] [stdout] 125 | Err(e) => return Err(format!("Message parse fail: {}", e)), [INFO] [stdout] 126 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/signaller/protomessages.rs:125:19 [INFO] [stdout] | [INFO] [stdout] 125 | Err(e) => return Err(format!("Message parse fail: {}", e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 125 ~ Err(e) => Err(format!("Message parse fail: {}", e)), [INFO] [stdout] 126 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/protomessages.rs:109:92 [INFO] [stdout] | [INFO] [stdout] 109 | let message = match protobuf_json_mapping::parse_from_str_with_options::(&msg, &parse_options) { [INFO] [stdout] | ^^^^ help: change this to: `msg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/signaller/protomessages.rs:117:83 [INFO] [stdout] | [INFO] [stdout] 117 | Some(descriptor) => protobuf_json_mapping::parse_dyn_from_str(descriptor, &msg), [INFO] [stdout] | ^^^^ help: change this to: `msg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/wstransport/ws.rs:159:62 [INFO] [stdout] | [INFO] [stdout] 159 | streamer::on_msg(&mut locked_context, &uuid, &msg).await; [INFO] [stdout] | ^^^^ help: change this to: `msg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/wstransport/ws.rs:161:60 [INFO] [stdout] | [INFO] [stdout] 161 | viewer::on_msg(&mut locked_context, &uuid, &msg).await; [INFO] [stdout] | ^^^^ help: change this to: `msg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 48s [INFO] running `Command { std: "docker" "inspect" "48dc899eb1e755cfec1893e4df5979f6f55bc7714f798d24dd56357716b0c6c4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "48dc899eb1e755cfec1893e4df5979f6f55bc7714f798d24dd56357716b0c6c4", kill_on_drop: false }` [INFO] [stdout] 48dc899eb1e755cfec1893e4df5979f6f55bc7714f798d24dd56357716b0c6c4