[INFO] fetching crate properties-file-parser 0.1.4... [INFO] linting properties-file-parser-0.1.4 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate properties-file-parser 0.1.4 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate properties-file-parser 0.1.4 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate properties-file-parser 0.1.4 [INFO] tweaked toml for crates.io crate properties-file-parser 0.1.4 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate properties-file-parser 0.1.4 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate properties-file-parser 0.1.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded anyhow v1.0.92 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a1677ce16db7a3b53a31ed62963a409a425b7f7d7e33b1e2a84f985fdddbf9df [INFO] running `Command { std: "docker" "start" "-a" "a1677ce16db7a3b53a31ed62963a409a425b7f7d7e33b1e2a84f985fdddbf9df", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a1677ce16db7a3b53a31ed62963a409a425b7f7d7e33b1e2a84f985fdddbf9df", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a1677ce16db7a3b53a31ed62963a409a425b7f7d7e33b1e2a84f985fdddbf9df", kill_on_drop: false }` [INFO] [stdout] a1677ce16db7a3b53a31ed62963a409a425b7f7d7e33b1e2a84f985fdddbf9df [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ae3a88db892e14ecd81e2488732b71b930f7653ccc18144a482c7855ebe4dd99 [INFO] running `Command { std: "docker" "start" "-a" "ae3a88db892e14ecd81e2488732b71b930f7653ccc18144a482c7855ebe4dd99", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.89 [INFO] [stderr] Compiling unicode-ident v1.0.13 [INFO] [stderr] Compiling thiserror v1.0.68 [INFO] [stderr] Compiling ucd-trie v0.1.7 [INFO] [stderr] Compiling once_cell v1.20.2 [INFO] [stderr] Compiling thiserror v2.0.3 [INFO] [stderr] Compiling anyhow v1.0.92 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.87 [INFO] [stderr] Compiling thiserror-impl v1.0.68 [INFO] [stderr] Compiling thiserror-impl v2.0.3 [INFO] [stderr] Compiling pest v2.7.14 [INFO] [stderr] Compiling pest_meta v2.7.14 [INFO] [stderr] Compiling pest_generator v2.7.14 [INFO] [stderr] Compiling pest_derive v2.7.14 [INFO] [stderr] Checking properties-file-parser v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use properties_file_parser; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:36:29 [INFO] [stdout] | [INFO] [stdout] 36 | ... return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - println!("{:?}", err.to_string()); [INFO] [stdout] 36 - return; [INFO] [stdout] 35 + println!("{:?}", err.to_string()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 44 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - println!("{:?}", err.to_string()); [INFO] [stdout] 44 - return; [INFO] [stdout] 43 + println!("{:?}", err.to_string()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use properties_file_parser; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/grammar_test.rs:8:17 [INFO] [stdout] | [INFO] [stdout] 8 | assert!(!Grammar::parse(Rule::comment, "# abcde\n something_else").is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Grammar::parse(Rule::comment, "# abcde\n something_else").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/grammar_test.rs:9:17 [INFO] [stdout] | [INFO] [stdout] 9 | assert!(!Grammar::parse(Rule::comment, "! abc").is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Grammar::parse(Rule::comment, "! abc").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/grammar_test.rs:20:17 [INFO] [stdout] | [INFO] [stdout] 20 | assert!(!Grammar::parse(Rule::spaces, " ").is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Grammar::parse(Rule::spaces, " ").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/grammar_test.rs:21:17 [INFO] [stdout] | [INFO] [stdout] 21 | assert!(!Grammar::parse(Rule::spaces, " ").is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Grammar::parse(Rule::spaces, " ").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/grammar_test.rs:28:17 [INFO] [stdout] | [INFO] [stdout] 28 | assert!(!Grammar::parse(Rule::property, "key : val").is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Grammar::parse(Rule::property, "key : val").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/grammar_test.rs:29:17 [INFO] [stdout] | [INFO] [stdout] 29 | assert!(!Grammar::parse(Rule::property, "key=val").is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Grammar::parse(Rule::property, "key=val").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/grammar_test.rs:30:17 [INFO] [stdout] | [INFO] [stdout] 30 | assert!(!Grammar::parse(Rule::property, "key val").is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Grammar::parse(Rule::property, "key val").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/grammar_test.rs:31:17 [INFO] [stdout] | [INFO] [stdout] 31 | assert!(!Grammar::parse(Rule::property, "key").is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Grammar::parse(Rule::property, "key").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/grammar_test.rs:41:17 [INFO] [stdout] | [INFO] [stdout] 41 | assert!(!Grammar::parse(Rule::key, "key").is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Grammar::parse(Rule::key, "key").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/grammar_test.rs:48:17 [INFO] [stdout] | [INFO] [stdout] 48 | assert!(!Grammar::parse(Rule::value, "value").is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Grammar::parse(Rule::value, "value").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/grammar_test.rs:49:17 [INFO] [stdout] | [INFO] [stdout] 49 | assert!(!Grammar::parse(Rule::value, "value\n").is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Grammar::parse(Rule::value, "value\n").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/grammar_test.rs:50:17 [INFO] [stdout] | [INFO] [stdout] 50 | assert!(!Grammar::parse(Rule::value, "").is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Grammar::parse(Rule::value, "").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/grammar_test.rs:56:17 [INFO] [stdout] | [INFO] [stdout] 56 | assert!(!Grammar::parse(Rule::file, "key1 = value1\n\ [INFO] [stdout] | _________________^ [INFO] [stdout] 57 | | key2 value2\n\ [INFO] [stdout] 58 | | key3:\n\ [INFO] [stdout] 59 | | key4").is_err()); [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 56 ~ assert!(Grammar::parse(Rule::file, "key1 = value1\n\ [INFO] [stdout] 57 + key2 value2\n\ [INFO] [stdout] 58 + key3:\n\ [INFO] [stdout] 59 ~ key4").is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/grammar_test.rs:60:17 [INFO] [stdout] | [INFO] [stdout] 60 | assert!(!Grammar::parse(Rule::file, "").is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Grammar::parse(Rule::file, "").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/grammar_test.rs:61:17 [INFO] [stdout] | [INFO] [stdout] 61 | assert!(!Grammar::parse(Rule::file, "#comment\n\ [INFO] [stdout] | _________________^ [INFO] [stdout] 62 | | \n\ [INFO] [stdout] 63 | | key = value").is_err()); [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 61 ~ assert!(Grammar::parse(Rule::file, "#comment\n\ [INFO] [stdout] 62 + \n\ [INFO] [stdout] 63 ~ key = value").is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/grammar_test.rs:79:17 [INFO] [stdout] | [INFO] [stdout] 79 | assert!(!Grammar::parse(Rule::silentEOI, "").is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Grammar::parse(Rule::silentEOI, "").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:36:29 [INFO] [stdout] | [INFO] [stdout] 36 | ... return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - println!("{:?}", err.to_string()); [INFO] [stdout] 36 - return; [INFO] [stdout] 35 + println!("{:?}", err.to_string()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 44 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - println!("{:?}", err.to_string()); [INFO] [stdout] 44 - return; [INFO] [stdout] 43 + println!("{:?}", err.to_string()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.98s [INFO] running `Command { std: "docker" "inspect" "ae3a88db892e14ecd81e2488732b71b930f7653ccc18144a482c7855ebe4dd99", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ae3a88db892e14ecd81e2488732b71b930f7653ccc18144a482c7855ebe4dd99", kill_on_drop: false }` [INFO] [stdout] ae3a88db892e14ecd81e2488732b71b930f7653ccc18144a482c7855ebe4dd99