[INFO] fetching crate probability-rs 0.1.2... [INFO] linting probability-rs-0.1.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate probability-rs 0.1.2 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate probability-rs 0.1.2 [INFO] finished tweaking crates.io crate probability-rs 0.1.2 [INFO] tweaked toml for crates.io crate probability-rs 0.1.2 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate probability-rs 0.1.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate probability-rs 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 817bc5a8a94852bbce700ea5f447bdd3e81e81086e52eda04771f5f008964cef [INFO] running `Command { std: "docker" "start" "-a" "817bc5a8a94852bbce700ea5f447bdd3e81e81086e52eda04771f5f008964cef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "817bc5a8a94852bbce700ea5f447bdd3e81e81086e52eda04771f5f008964cef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "817bc5a8a94852bbce700ea5f447bdd3e81e81086e52eda04771f5f008964cef", kill_on_drop: false }` [INFO] [stdout] 817bc5a8a94852bbce700ea5f447bdd3e81e81086e52eda04771f5f008964cef [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1a99aa00e241f98a28810a41857a9a16bdbac970f06e491a3bfc2b49a8b04ef4 [INFO] running `Command { std: "docker" "start" "-a" "1a99aa00e241f98a28810a41857a9a16bdbac970f06e491a3bfc2b49a8b04ef4", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.103 [INFO] [stderr] Checking serde_json v1.0.145 [INFO] [stderr] Checking clap_builder v4.5.50 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking probability-rs v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/dist/beta.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 14 | if !(a > 0.0 && b > 0.0) || !a.is_finite() || !b.is_finite() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(a > 0.0 && b > 0.0 && a.is_finite() && b.is_finite())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/dist/beta.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 14 | if !(a > 0.0 && b > 0.0) || !a.is_finite() || !b.is_finite() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(a > 0.0 && b > 0.0 && a.is_finite())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/dist/beta.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | x >= 0.0 && x <= 1.0 && x.is_finite() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `(0.0..=1.0).contains(&x)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the use of negated comparison operators on partially ordered types produces code that is hard to read and refactor, please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable [INFO] [stdout] --> src/dist/chisquared.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 14 | if !(v > 0.0) || !v.is_finite() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stdout] = note: `#[warn(clippy::neg_cmp_op_on_partial_ord)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/dist/gamma.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 15 | if !(shape > 0.0 && scale > 0.0) || !shape.is_finite() || !scale.is_finite() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(shape > 0.0 && scale > 0.0 && shape.is_finite() && scale.is_finite())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/dist/gamma.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 15 | if !(shape > 0.0 && scale > 0.0) || !shape.is_finite() || !scale.is_finite() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(shape > 0.0 && scale > 0.0 && shape.is_finite())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/dist/gamma.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 169 | 0.99999999999980993, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] = note: `#[warn(clippy::excessive_precision)]` on by default [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 169 - 0.99999999999980993, [INFO] [stdout] 169 + 0.999_999_999_999_809_9, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/dist/gamma.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 172 | 771.32342877765313, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 172 - 771.32342877765313, [INFO] [stdout] 172 + 771.323_428_777_653_1, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/dist/gamma.rs:173:10 [INFO] [stdout] | [INFO] [stdout] 173 | -176.61502916214059, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 173 - -176.61502916214059, [INFO] [stdout] 173 + -176.615_029_162_140_6, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/dist/gamma.rs:176:9 [INFO] [stdout] | [INFO] [stdout] 176 | 9.9843695780195716e-6, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 176 - 9.9843695780195716e-6, [INFO] [stdout] 176 + 9.984_369_578_019_572e-6, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: there is no need to manually implement bit rotation [INFO] [stdout] --> src/rng/xoroshiro128.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | (x << k) | (x >> (64 - k)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: this expression can be rewritten as: `x.rotate_left(k)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_rotate [INFO] [stdout] = note: `#[warn(clippy::manual_rotate)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: there is no need to manually implement bit rotation [INFO] [stdout] --> src/rng/xoshiro256.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | (x << k) | (x >> (64 - k)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: this expression can be rewritten as: `x.rotate_left(k)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_rotate [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling quote v1.0.41 [INFO] [stderr] Compiling syn v2.0.108 [INFO] [stderr] Checking clap v4.5.50 [INFO] [stderr] Compiling zerocopy-derive v0.8.27 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking zerocopy v0.8.27 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/dist/beta.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 14 | if !(a > 0.0 && b > 0.0) || !a.is_finite() || !b.is_finite() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(a > 0.0 && b > 0.0 && a.is_finite() && b.is_finite())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/dist/beta.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 14 | if !(a > 0.0 && b > 0.0) || !a.is_finite() || !b.is_finite() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(a > 0.0 && b > 0.0 && a.is_finite())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/dist/beta.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | x >= 0.0 && x <= 1.0 && x.is_finite() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `(0.0..=1.0).contains(&x)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the use of negated comparison operators on partially ordered types produces code that is hard to read and refactor, please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable [INFO] [stdout] --> src/dist/chisquared.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 14 | if !(v > 0.0) || !v.is_finite() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stdout] = note: `#[warn(clippy::neg_cmp_op_on_partial_ord)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/dist/gamma.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 15 | if !(shape > 0.0 && scale > 0.0) || !shape.is_finite() || !scale.is_finite() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(shape > 0.0 && scale > 0.0 && shape.is_finite() && scale.is_finite())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/dist/gamma.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 15 | if !(shape > 0.0 && scale > 0.0) || !shape.is_finite() || !scale.is_finite() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(shape > 0.0 && scale > 0.0 && shape.is_finite())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/dist/gamma.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 169 | 0.99999999999980993, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] = note: `#[warn(clippy::excessive_precision)]` on by default [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 169 - 0.99999999999980993, [INFO] [stdout] 169 + 0.999_999_999_999_809_9, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/dist/gamma.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 172 | 771.32342877765313, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 172 - 771.32342877765313, [INFO] [stdout] 172 + 771.323_428_777_653_1, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/dist/gamma.rs:173:10 [INFO] [stdout] | [INFO] [stdout] 173 | -176.61502916214059, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 173 - -176.61502916214059, [INFO] [stdout] 173 + -176.615_029_162_140_6, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/dist/gamma.rs:176:9 [INFO] [stdout] | [INFO] [stdout] 176 | 9.9843695780195716e-6, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 176 - 9.9843695780195716e-6, [INFO] [stdout] 176 + 9.984_369_578_019_572e-6, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: there is no need to manually implement bit rotation [INFO] [stdout] --> src/rng/xoroshiro128.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | (x << k) | (x >> (64 - k)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: this expression can be rewritten as: `x.rotate_left(k)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_rotate [INFO] [stdout] = note: `#[warn(clippy::manual_rotate)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: there is no need to manually implement bit rotation [INFO] [stdout] --> src/rng/xoshiro256.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | (x << k) | (x >> (64 - k)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: this expression can be rewritten as: `x.rotate_left(k)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_rotate [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 16.87s [INFO] running `Command { std: "docker" "inspect" "1a99aa00e241f98a28810a41857a9a16bdbac970f06e491a3bfc2b49a8b04ef4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1a99aa00e241f98a28810a41857a9a16bdbac970f06e491a3bfc2b49a8b04ef4", kill_on_drop: false }` [INFO] [stdout] 1a99aa00e241f98a28810a41857a9a16bdbac970f06e491a3bfc2b49a8b04ef4