[INFO] fetching crate prest-db-macro 0.5.0... [INFO] linting prest-db-macro-0.5.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate prest-db-macro 0.5.0 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate prest-db-macro 0.5.0 [INFO] finished tweaking crates.io crate prest-db-macro 0.5.0 [INFO] tweaked toml for crates.io crate prest-db-macro 0.5.0 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate prest-db-macro 0.5.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate prest-db-macro 0.5.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded derive_utils v0.15.0 [INFO] [stderr] Downloaded iter-enum v1.2.0 [INFO] [stderr] Downloaded find-crate v0.6.3 [INFO] [stderr] Downloaded futures-enum v0.1.17 [INFO] [stderr] Downloaded slab v0.4.10 [INFO] [stderr] Downloaded derive_utils v0.11.2 [INFO] [stderr] Downloaded gluesql-utils v0.16.3 [INFO] [stderr] Downloaded rand_xoshiro v0.6.0 [INFO] [stderr] Downloaded sized-chunks v0.6.5 [INFO] [stderr] Downloaded borsh v1.5.7 [INFO] [stderr] Downloaded rkyv v0.7.45 [INFO] [stderr] Downloaded bitmaps v2.1.0 [INFO] [stderr] Downloaded gluesql-core v0.16.3 [INFO] [stderr] Downloaded borsh-derive v1.5.7 [INFO] [stderr] Downloaded rkyv_derive v0.7.45 [INFO] [stderr] Downloaded im-rc v15.1.0 [INFO] [stderr] Downloaded sqlparser v0.50.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 96ca2a24269b31804c30e093a66869656b0e1c871fa9a7752e41a02b5c09e7a7 [INFO] running `Command { std: "docker" "start" "-a" "96ca2a24269b31804c30e093a66869656b0e1c871fa9a7752e41a02b5c09e7a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "96ca2a24269b31804c30e093a66869656b0e1c871fa9a7752e41a02b5c09e7a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "96ca2a24269b31804c30e093a66869656b0e1c871fa9a7752e41a02b5c09e7a7", kill_on_drop: false }` [INFO] [stdout] 96ca2a24269b31804c30e093a66869656b0e1c871fa9a7752e41a02b5c09e7a7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b349e93eeadb767539d2ac81ed5f250feddff4b0dcafd57704b89f9dd2af9f30 [INFO] running `Command { std: "docker" "start" "-a" "b349e93eeadb767539d2ac81ed5f250feddff4b0dcafd57704b89f9dd2af9f30", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Checking cfg-if v1.0.1 [INFO] [stderr] Checking memchr v2.7.5 [INFO] [stderr] Compiling zerocopy v0.8.26 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Checking futures-core v0.3.31 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Compiling typenum v1.18.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking futures-task v0.3.31 [INFO] [stderr] Checking slab v0.4.10 [INFO] [stderr] Checking pin-project-lite v0.2.16 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling libm v0.2.15 [INFO] [stderr] Compiling bigdecimal v0.4.8 [INFO] [stderr] Compiling rustversion v1.0.21 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling im-rc v15.1.0 [INFO] [stderr] Compiling rust_decimal v1.37.2 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking unicode-ident v1.0.18 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Compiling thiserror v1.0.69 [INFO] [stderr] Compiling serde_json v1.0.140 [INFO] [stderr] Checking ryu v1.0.20 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking proc-macro2 v1.0.95 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking itoa v1.0.15 [INFO] [stderr] Checking iana-time-zone v0.1.63 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Checking quote v1.0.40 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking bitmaps v2.1.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking rand_xoshiro v0.6.0 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking uuid v1.17.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking sized-chunks v0.6.5 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Compiling derive_utils v0.15.0 [INFO] [stderr] Compiling derive_utils v0.11.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling pin-project-internal v1.1.10 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling async-trait v0.1.88 [INFO] [stderr] Compiling iter-enum v1.2.0 [INFO] [stderr] Compiling strum_macros v0.25.3 [INFO] [stderr] Compiling async-recursion v1.1.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking pin-project v1.1.10 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking gluesql-utils v0.16.3 [INFO] [stderr] Checking chrono v0.4.41 [INFO] [stderr] Checking ordered-float v4.6.0 [INFO] [stderr] Compiling toml v0.5.11 [INFO] [stderr] Checking sqlparser v0.50.0 [INFO] [stderr] Compiling find-crate v0.6.3 [INFO] [stderr] Compiling futures-enum v0.1.17 [INFO] [stderr] Checking gluesql-core v0.16.3 [INFO] [stderr] Checking prest-db-macro v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> analyze.rs:36:8 [INFO] [stdout] | [INFO] [stdout] 36 | if pkey && optional || pkey && list { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 36 - if pkey && optional || pkey && list { [INFO] [stdout] 36 + if !(!pkey || !optional && !list) { [INFO] [stdout] | [INFO] [stdout] 36 - if pkey && optional || pkey && list { [INFO] [stdout] 36 + if (list || optional) && pkey { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> analyze.rs:42:22 [INFO] [stdout] | [INFO] [stdout] 42 | let serialized = match inner_type_str { [INFO] [stdout] | ______________________^ [INFO] [stdout] 43 | | "Uuid" | "String" | "NaiveDateTime" | "bool" | "u128" | "u64" | "u32" | "u16" | "u8" [INFO] [stdout] 44 | | | "i128" | "i64" | "i32" | "i16" | "i8" | "f64" | "f32" => false, [INFO] [stdout] 45 | | _ => true, [INFO] [stdout] 46 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 42 ~ let serialized = !matches!(inner_type_str, "Uuid" | "String" | "NaiveDateTime" | "bool" | "u128" | "u64" | "u32" | "u16" | "u8" [INFO] [stdout] 43 ~ | "i128" | "i64" | "i32" | "i16" | "i8" | "f64" | "f32"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> expand.rs:46:62 [INFO] [stdout] | [INFO] [stdout] 46 | let schema_name = ident(&format!("{}Schema", struct_ident.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> analyze.rs:36:8 [INFO] [stdout] | [INFO] [stdout] 36 | if pkey && optional || pkey && list { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 36 - if pkey && optional || pkey && list { [INFO] [stdout] 36 + if !(!pkey || !optional && !list) { [INFO] [stdout] | [INFO] [stdout] 36 - if pkey && optional || pkey && list { [INFO] [stdout] 36 + if (list || optional) && pkey { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> analyze.rs:42:22 [INFO] [stdout] | [INFO] [stdout] 42 | let serialized = match inner_type_str { [INFO] [stdout] | ______________________^ [INFO] [stdout] 43 | | "Uuid" | "String" | "NaiveDateTime" | "bool" | "u128" | "u64" | "u32" | "u16" | "u8" [INFO] [stdout] 44 | | | "i128" | "i64" | "i32" | "i16" | "i8" | "f64" | "f32" => false, [INFO] [stdout] 45 | | _ => true, [INFO] [stdout] 46 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 42 ~ let serialized = !matches!(inner_type_str, "Uuid" | "String" | "NaiveDateTime" | "bool" | "u128" | "u64" | "u32" | "u16" | "u8" [INFO] [stdout] 43 ~ | "i128" | "i64" | "i32" | "i16" | "i8" | "f64" | "f32"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> expand.rs:46:62 [INFO] [stdout] | [INFO] [stdout] 46 | let schema_name = ident(&format!("{}Schema", struct_ident.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> expand.rs:353:29 [INFO] [stdout] | [INFO] [stdout] 353 | if *list && *serialized { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 354 | | value = q!( prest::sql::Value::List(v.into_iter().map(|v| #value).collect()) ) [INFO] [stdout] 355 | | } else if *list { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> expand.rs:355:21 [INFO] [stdout] | [INFO] [stdout] 355 | } else if *list { [INFO] [stdout] | _____________________^ [INFO] [stdout] 356 | | value = q!( prest::sql::Value::List(v.into_iter().map(|v| #value).collect()) ) [INFO] [stdout] 357 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> expand.rs:353:29 [INFO] [stdout] | [INFO] [stdout] 353 | if *list && *serialized { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 354 | | value = q!( prest::sql::Value::List(v.into_iter().map(|v| #value).collect()) ) [INFO] [stdout] 355 | | } else if *list { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> expand.rs:355:21 [INFO] [stdout] | [INFO] [stdout] 355 | } else if *list { [INFO] [stdout] | _____________________^ [INFO] [stdout] 356 | | value = q!( prest::sql::Value::List(v.into_iter().map(|v| #value).collect()) ) [INFO] [stdout] 357 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 50.09s [INFO] running `Command { std: "docker" "inspect" "b349e93eeadb767539d2ac81ed5f250feddff4b0dcafd57704b89f9dd2af9f30", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b349e93eeadb767539d2ac81ed5f250feddff4b0dcafd57704b89f9dd2af9f30", kill_on_drop: false }` [INFO] [stdout] b349e93eeadb767539d2ac81ed5f250feddff4b0dcafd57704b89f9dd2af9f30