[INFO] fetching crate pqcrypto-mqdss 0.3.0... [INFO] linting pqcrypto-mqdss-0.3.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate pqcrypto-mqdss 0.3.0 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate pqcrypto-mqdss 0.3.0 [INFO] finished tweaking crates.io crate pqcrypto-mqdss 0.3.0 [INFO] tweaked toml for crates.io crate pqcrypto-mqdss 0.3.0 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate pqcrypto-mqdss 0.3.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 25 packages to latest compatible versions [INFO] [stderr] Adding rand v0.7.3 (available: v0.10.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e5afff6020d2a4629ec07e54e233136159aabbdad0a2730fbb74cfbba6789c19 [INFO] running `Command { std: "docker" "start" "-a" "e5afff6020d2a4629ec07e54e233136159aabbdad0a2730fbb74cfbba6789c19", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e5afff6020d2a4629ec07e54e233136159aabbdad0a2730fbb74cfbba6789c19", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e5afff6020d2a4629ec07e54e233136159aabbdad0a2730fbb74cfbba6789c19", kill_on_drop: false }` [INFO] [stdout] e5afff6020d2a4629ec07e54e233136159aabbdad0a2730fbb74cfbba6789c19 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6ab13bd088f0ff1d317899ebd68d0b607c9250dd927c4d3cc433f0d6bfe60e3f [INFO] running `Command { std: "docker" "start" "-a" "6ab13bd088f0ff1d317899ebd68d0b607c9250dd927c4d3cc433f0d6bfe60e3f", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Compiling zerocopy v0.8.42 [INFO] [stderr] Checking cfg-if v1.0.4 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling find-msvc-tools v0.1.9 [INFO] [stderr] Compiling glob v0.3.3 [INFO] [stderr] Checking pqcrypto-traits v0.3.5 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Compiling cc v1.2.57 [INFO] [stderr] Compiling pqcrypto-mqdss v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> build.rs:18:16 [INFO] [stdout] | [INFO] [stdout] 18 | .files(common_files.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/cc-1.2.57/src/lib.rs:839:12 [INFO] [stdout] | [INFO] [stdout] 839 | P: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 18 - .files(common_files.into_iter()) [INFO] [stdout] 18 + .files(common_files) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/mqdss48.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | &self.0.as_slice() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `self.0.as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]` [INFO] [stdout] --> src/mqdss48.rs:191:1 [INFO] [stdout] | [INFO] [stdout] 191 | / pub fn open( [INFO] [stdout] 192 | | sm: &SignedMessage, [INFO] [stdout] 193 | | pk: &PublicKey, [INFO] [stdout] 194 | | ) -> std::result::Result, primitive::VerificationError> { [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: either add some descriptive message or remove the attribute [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use [INFO] [stdout] = note: `#[warn(clippy::double_must_use)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]` [INFO] [stdout] --> src/mqdss48.rs:243:1 [INFO] [stdout] | [INFO] [stdout] 243 | / pub fn verify_detached_signature( [INFO] [stdout] 244 | | sig: &DetachedSignature, [INFO] [stdout] 245 | | msg: &[u8], [INFO] [stdout] 246 | | pk: &PublicKey, [INFO] [stdout] 247 | | ) -> std::result::Result<(), primitive::VerificationError> { [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: either add some descriptive message or remove the attribute [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/mqdss64.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | &self.0.as_slice() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `self.0.as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]` [INFO] [stdout] --> src/mqdss64.rs:191:1 [INFO] [stdout] | [INFO] [stdout] 191 | / pub fn open( [INFO] [stdout] 192 | | sm: &SignedMessage, [INFO] [stdout] 193 | | pk: &PublicKey, [INFO] [stdout] 194 | | ) -> std::result::Result, primitive::VerificationError> { [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: either add some descriptive message or remove the attribute [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]` [INFO] [stdout] --> src/mqdss64.rs:243:1 [INFO] [stdout] | [INFO] [stdout] 243 | / pub fn verify_detached_signature( [INFO] [stdout] 244 | | sig: &DetachedSignature, [INFO] [stdout] 245 | | msg: &[u8], [INFO] [stdout] 246 | | pk: &PublicKey, [INFO] [stdout] 247 | | ) -> std::result::Result<(), primitive::VerificationError> { [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: either add some descriptive message or remove the attribute [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/mqdss48.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | &self.0.as_slice() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `self.0.as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]` [INFO] [stdout] --> src/mqdss48.rs:191:1 [INFO] [stdout] | [INFO] [stdout] 191 | / pub fn open( [INFO] [stdout] 192 | | sm: &SignedMessage, [INFO] [stdout] 193 | | pk: &PublicKey, [INFO] [stdout] 194 | | ) -> std::result::Result, primitive::VerificationError> { [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: either add some descriptive message or remove the attribute [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use [INFO] [stdout] = note: `#[warn(clippy::double_must_use)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]` [INFO] [stdout] --> src/mqdss48.rs:243:1 [INFO] [stdout] | [INFO] [stdout] 243 | / pub fn verify_detached_signature( [INFO] [stdout] 244 | | sig: &DetachedSignature, [INFO] [stdout] 245 | | msg: &[u8], [INFO] [stdout] 246 | | pk: &PublicKey, [INFO] [stdout] 247 | | ) -> std::result::Result<(), primitive::VerificationError> { [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: either add some descriptive message or remove the attribute [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mqdss48.rs:298:17 [INFO] [stdout] | [INFO] [stdout] 298 | assert!(!verify_detached_signature(&sig, &message[..message.len() - 1], &pk).is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `verify_detached_signature(&sig, &message[..message.len() - 1], &pk).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/mqdss64.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | &self.0.as_slice() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `self.0.as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]` [INFO] [stdout] --> src/mqdss64.rs:191:1 [INFO] [stdout] | [INFO] [stdout] 191 | / pub fn open( [INFO] [stdout] 192 | | sm: &SignedMessage, [INFO] [stdout] 193 | | pk: &PublicKey, [INFO] [stdout] 194 | | ) -> std::result::Result, primitive::VerificationError> { [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: either add some descriptive message or remove the attribute [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]` [INFO] [stdout] --> src/mqdss64.rs:243:1 [INFO] [stdout] | [INFO] [stdout] 243 | / pub fn verify_detached_signature( [INFO] [stdout] 244 | | sig: &DetachedSignature, [INFO] [stdout] 245 | | msg: &[u8], [INFO] [stdout] 246 | | pk: &PublicKey, [INFO] [stdout] 247 | | ) -> std::result::Result<(), primitive::VerificationError> { [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: either add some descriptive message or remove the attribute [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mqdss64.rs:298:17 [INFO] [stdout] | [INFO] [stdout] 298 | assert!(!verify_detached_signature(&sig, &message[..message.len() - 1], &pk).is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `verify_detached_signature(&sig, &message[..message.len() - 1], &pk).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.06s [INFO] running `Command { std: "docker" "inspect" "6ab13bd088f0ff1d317899ebd68d0b607c9250dd927c4d3cc433f0d6bfe60e3f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6ab13bd088f0ff1d317899ebd68d0b607c9250dd927c4d3cc433f0d6bfe60e3f", kill_on_drop: false }` [INFO] [stdout] 6ab13bd088f0ff1d317899ebd68d0b607c9250dd927c4d3cc433f0d6bfe60e3f