[INFO] fetching crate pqcrypto-falcon 0.4.1... [INFO] linting pqcrypto-falcon-0.4.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate pqcrypto-falcon 0.4.1 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate pqcrypto-falcon 0.4.1 [INFO] finished tweaking crates.io crate pqcrypto-falcon 0.4.1 [INFO] tweaked toml for crates.io crate pqcrypto-falcon 0.4.1 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate pqcrypto-falcon 0.4.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate pqcrypto-falcon 0.4.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serde-big-array v0.5.1 [INFO] [stderr] Downloaded pqcrypto-traits v0.3.5 [INFO] [stderr] Downloaded pqcrypto-internals v0.2.11 [INFO] [stderr] Downloaded cc v1.2.31 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b9f43a8ebdb1eac7537fd70ccf567aad88b0e8952a8c78ac8cc44040a11c4c98 [INFO] running `Command { std: "docker" "start" "-a" "b9f43a8ebdb1eac7537fd70ccf567aad88b0e8952a8c78ac8cc44040a11c4c98", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b9f43a8ebdb1eac7537fd70ccf567aad88b0e8952a8c78ac8cc44040a11c4c98", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b9f43a8ebdb1eac7537fd70ccf567aad88b0e8952a8c78ac8cc44040a11c4c98", kill_on_drop: false }` [INFO] [stdout] b9f43a8ebdb1eac7537fd70ccf567aad88b0e8952a8c78ac8cc44040a11c4c98 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fee4a3cae5988467f80fe3f7b359e0367841866f52ebc2816c275473327db358 [INFO] running `Command { std: "docker" "start" "-a" "fee4a3cae5988467f80fe3f7b359e0367841866f52ebc2816c275473327db358", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Compiling dunce v1.0.5 [INFO] [stderr] Checking pqcrypto-traits v0.3.5 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Compiling jobserver v0.1.33 [INFO] [stderr] Compiling cc v1.2.31 [INFO] [stderr] Compiling pqcrypto-internals v0.2.11 [INFO] [stderr] Compiling pqcrypto-falcon v0.4.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated method `rand::Rng::gen`: Renamed to `random` to avoid conflict with the new `gen` keyword in Rust 2024. [INFO] [stdout] --> src/falcon1024.rs:384:44 [INFO] [stdout] | [INFO] [stdout] 384 | let message = (0..len).map(|_| rng.gen::()).collect::>(); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `rand::Rng::gen`: Renamed to `random` to avoid conflict with the new `gen` keyword in Rust 2024. [INFO] [stdout] --> src/falcon1024.rs:395:44 [INFO] [stdout] | [INFO] [stdout] 395 | let message = (0..len).map(|_| rng.gen::()).collect::>(); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `rand::Rng::gen`: Renamed to `random` to avoid conflict with the new `gen` keyword in Rust 2024. [INFO] [stdout] --> src/falcon512.rs:384:44 [INFO] [stdout] | [INFO] [stdout] 384 | let message = (0..len).map(|_| rng.gen::()).collect::>(); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `rand::Rng::gen`: Renamed to `random` to avoid conflict with the new `gen` keyword in Rust 2024. [INFO] [stdout] --> src/falcon512.rs:395:44 [INFO] [stdout] | [INFO] [stdout] 395 | let message = (0..len).map(|_| rng.gen::()).collect::>(); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `rand::Rng::gen`: Renamed to `random` to avoid conflict with the new `gen` keyword in Rust 2024. [INFO] [stdout] --> src/falconpadded1024.rs:406:44 [INFO] [stdout] | [INFO] [stdout] 406 | let message = (0..len).map(|_| rng.gen::()).collect::>(); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `rand::Rng::gen`: Renamed to `random` to avoid conflict with the new `gen` keyword in Rust 2024. [INFO] [stdout] --> src/falconpadded1024.rs:417:44 [INFO] [stdout] | [INFO] [stdout] 417 | let message = (0..len).map(|_| rng.gen::()).collect::>(); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `rand::Rng::gen`: Renamed to `random` to avoid conflict with the new `gen` keyword in Rust 2024. [INFO] [stdout] --> src/falconpadded512.rs:402:44 [INFO] [stdout] | [INFO] [stdout] 402 | let message = (0..len).map(|_| rng.gen::()).collect::>(); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `rand::Rng::gen`: Renamed to `random` to avoid conflict with the new `gen` keyword in Rust 2024. [INFO] [stdout] --> src/falconpadded512.rs:413:44 [INFO] [stdout] | [INFO] [stdout] 413 | let message = (0..len).map(|_| rng.gen::()).collect::>(); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/falcon1024.rs:400:17 [INFO] [stdout] | [INFO] [stdout] 400 | assert!(!verify_detached_signature(&sig, &message[..message.len() - 1], &pk).is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `verify_detached_signature(&sig, &message[..message.len() - 1], &pk).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/falcon512.rs:400:17 [INFO] [stdout] | [INFO] [stdout] 400 | assert!(!verify_detached_signature(&sig, &message[..message.len() - 1], &pk).is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `verify_detached_signature(&sig, &message[..message.len() - 1], &pk).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/falconpadded1024.rs:422:17 [INFO] [stdout] | [INFO] [stdout] 422 | assert!(!verify_detached_signature(&sig, &message[..message.len() - 1], &pk).is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `verify_detached_signature(&sig, &message[..message.len() - 1], &pk).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/falconpadded512.rs:418:17 [INFO] [stdout] | [INFO] [stdout] 418 | assert!(!verify_detached_signature(&sig, &message[..message.len() - 1], &pk).is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `verify_detached_signature(&sig, &message[..message.len() - 1], &pk).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 21.19s [INFO] running `Command { std: "docker" "inspect" "fee4a3cae5988467f80fe3f7b359e0367841866f52ebc2816c275473327db358", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fee4a3cae5988467f80fe3f7b359e0367841866f52ebc2816c275473327db358", kill_on_drop: false }` [INFO] [stdout] fee4a3cae5988467f80fe3f7b359e0367841866f52ebc2816c275473327db358