[INFO] fetching crate postgres_migrator 0.6.7... [INFO] linting postgres_migrator-0.6.7 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate postgres_migrator 0.6.7 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate postgres_migrator 0.6.7 [INFO] finished tweaking crates.io crate postgres_migrator 0.6.7 [INFO] tweaked toml for crates.io crate postgres_migrator 0.6.7 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate postgres_migrator 0.6.7 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate postgres_migrator 0.6.7 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serial_test v0.8.0 [INFO] [stderr] Downloaded siphasher v0.3.9 [INFO] [stderr] Downloaded futures v0.3.21 [INFO] [stderr] Downloaded postgres-protocol v0.6.3 [INFO] [stderr] Downloaded anyhow v1.0.55 [INFO] [stderr] Downloaded clap_derive v3.1.2 [INFO] [stderr] Downloaded tokio-postgres v0.7.5 [INFO] [stderr] Downloaded mio v0.8.0 [INFO] [stderr] Downloaded futures-executor v0.3.21 [INFO] [stderr] Downloaded serial_test_derive v0.8.0 [INFO] [stderr] Downloaded clap v3.1.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2fa4664ab238a6a72c260d8a21afb5aee5db16ada3ed864ac07cd2f233d5ddf8 [INFO] running `Command { std: "docker" "start" "-a" "2fa4664ab238a6a72c260d8a21afb5aee5db16ada3ed864ac07cd2f233d5ddf8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2fa4664ab238a6a72c260d8a21afb5aee5db16ada3ed864ac07cd2f233d5ddf8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2fa4664ab238a6a72c260d8a21afb5aee5db16ada3ed864ac07cd2f233d5ddf8", kill_on_drop: false }` [INFO] [stdout] 2fa4664ab238a6a72c260d8a21afb5aee5db16ada3ed864ac07cd2f233d5ddf8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 82424c152e4dcacbf22e5bdf2954bb32dcd5523a9c12915c506c4fa04fb50ecb [INFO] running `Command { std: "docker" "start" "-a" "82424c152e4dcacbf22e5bdf2954bb32dcd5523a9c12915c506c4fa04fb50ecb", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.119 [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Compiling quote v1.0.15 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Checking crypto-common v0.1.3 [INFO] [stderr] Checking block-buffer v0.10.2 [INFO] [stderr] Checking stringprep v0.1.2 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking siphasher v0.3.9 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling anyhow v1.0.55 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking phf_shared v0.10.0 [INFO] [stderr] Checking phf v0.10.1 [INFO] [stderr] Checking digest v0.10.3 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.2 [INFO] [stderr] Checking md-5 v0.10.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking getrandom v0.2.5 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking mio v0.8.0 [INFO] [stderr] Checking parking_lot_core v0.8.5 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking parking_lot_core v0.9.3 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tokio v1.17.0 [INFO] [stderr] Checking postgres-protocol v0.6.3 [INFO] [stderr] Checking postgres-types v0.2.2 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Compiling async-trait v0.1.52 [INFO] [stderr] Compiling clap_derive v3.1.2 [INFO] [stderr] Compiling serial_test_derive v0.8.0 [INFO] [stderr] Checking tokio-util v0.6.9 [INFO] [stderr] Checking clap v3.1.3 [INFO] [stderr] Checking futures-executor v0.3.21 [INFO] [stderr] Checking futures v0.3.21 [INFO] [stderr] Checking tokio-postgres v0.7.5 [INFO] [stderr] Checking serial_test v0.8.0 [INFO] [stderr] Checking postgres v0.19.2 [INFO] [stderr] Checking postgres_migrator v0.6.7 (/opt/rustwide/workdir) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:31:38 [INFO] [stdout] | [INFO] [stdout] 31 | const DEFAULT_MIGRATIONS_DIRECTORY: &'static str = "migrations"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:32:34 [INFO] [stdout] | [INFO] [stdout] 32 | const DEFAULT_SCHEMA_DIRECTORY: &'static str = "schema"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:461:22 [INFO] [stdout] | [INFO] [stdout] 461 | const EXISTS_QUERY: &'static str = "select true from pg_catalog.pg_class where relname = '_schema_versions' and relkind = 'r'"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:628:25 [INFO] [stdout] | [INFO] [stdout] 628 | const TEMP_DB_COMMENT: &'static str = "'TEMP DB CREATED BY postgres_migrator'"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:31:38 [INFO] [stdout] | [INFO] [stdout] 31 | const DEFAULT_MIGRATIONS_DIRECTORY: &'static str = "migrations"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:32:34 [INFO] [stdout] | [INFO] [stdout] 32 | const DEFAULT_SCHEMA_DIRECTORY: &'static str = "schema"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:461:22 [INFO] [stdout] | [INFO] [stdout] 461 | const EXISTS_QUERY: &'static str = "select true from pg_catalog.pg_class where relname = '_schema_versions' and relkind = 'r'"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:628:25 [INFO] [stdout] | [INFO] [stdout] 628 | const TEMP_DB_COMMENT: &'static str = "'TEMP DB CREATED BY postgres_migrator'"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:50:2 [INFO] [stdout] | [INFO] [stdout] 50 | re.replace_all(text, "_").to_lowercase().into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `re.replace_all(text, "_").to_lowercase()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:50:2 [INFO] [stdout] | [INFO] [stdout] 50 | re.replace_all(text, "_").to_lowercase().into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `re.replace_all(text, "_").to_lowercase()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:106:18 [INFO] [stdout] | [INFO] [stdout] 106 | purge_directory(&DEFAULT_SCHEMA_DIRECTORY)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `DEFAULT_SCHEMA_DIRECTORY` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:107:19 [INFO] [stdout] | [INFO] [stdout] 107 | ensure_directory(&DEFAULT_SCHEMA_DIRECTORY)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `DEFAULT_SCHEMA_DIRECTORY` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:196:9 [INFO] [stdout] | [INFO] [stdout] 196 | if !(index == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `(index != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:203:9 [INFO] [stdout] | [INFO] [stdout] 203 | if !(current_version > previous_version) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(current_version <= previous_version)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:128:36 [INFO] [stdout] | [INFO] [stdout] 128 | let schema_files = list_sql_files(&DEFAULT_SCHEMA_DIRECTORY)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `DEFAULT_SCHEMA_DIRECTORY` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:145:18 [INFO] [stdout] | [INFO] [stdout] 145 | purge_directory(&DEFAULT_SCHEMA_DIRECTORY)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `DEFAULT_SCHEMA_DIRECTORY` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant redefinition of a binding `previous_version` [INFO] [stdout] --> src/main.rs:202:6 [INFO] [stdout] | [INFO] [stdout] 202 | let previous_version = previous_version; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: `previous_version` is initially defined here [INFO] [stdout] --> src/main.rs:173:8 [INFO] [stdout] | [INFO] [stdout] 173 | let previous_version = portions.next() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_locals [INFO] [stdout] = note: `#[warn(clippy::redundant_locals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:196:9 [INFO] [stdout] | [INFO] [stdout] 196 | if !(index == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `(index != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:203:9 [INFO] [stdout] | [INFO] [stdout] 203 | if !(current_version > previous_version) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(current_version <= previous_version)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant redefinition of a binding `previous_version` [INFO] [stdout] --> src/main.rs:202:6 [INFO] [stdout] | [INFO] [stdout] 202 | let previous_version = previous_version; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: `previous_version` is initially defined here [INFO] [stdout] --> src/main.rs:173:8 [INFO] [stdout] | [INFO] [stdout] 173 | let previous_version = portions.next() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_locals [INFO] [stdout] = note: `#[warn(clippy::redundant_locals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:399:5 [INFO] [stdout] | [INFO] [stdout] 399 | if output.stderr.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!output.stderr.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:237:17 [INFO] [stdout] | [INFO] [stdout] 237 | PathBuf::from(format!("err/90000000000000.null.sql")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"err/90000000000000.null.sql".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:421:72 [INFO] [stdout] | [INFO] [stdout] 421 | let (migration_files, previous_version) = gather_validated_migrations(&args)?; [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:430:27 [INFO] [stdout] | [INFO] [stdout] 430 | let source = TempDb::new(&dbname, "migrations", &args.pg_url)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `dbname` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:259:33 [INFO] [stdout] | [INFO] [stdout] 259 | let file_path3 = PathBuf::from(format!("ok/90000000000001.90000000000000.sql")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"ok/90000000000001.90000000000000.sql".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:260:33 [INFO] [stdout] | [INFO] [stdout] 260 | let file_path4 = PathBuf::from(format!("ok/90000000000002.90000000000001.sql")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"ok/90000000000002.90000000000001.sql".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:432:27 [INFO] [stdout] | [INFO] [stdout] 432 | let target = TempDb::new(&dbname, "schema", &args.pg_url)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `dbname` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:273:33 [INFO] [stdout] | [INFO] [stdout] 273 | let file_path3 = PathBuf::from(format!("ok/90000000000001.90000000000000.sql")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"ok/90000000000001.90000000000000.sql".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:274:33 [INFO] [stdout] | [INFO] [stdout] 274 | let file_path4 = PathBuf::from(format!("ok/90000000000002.90000000000001.sql")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"ok/90000000000002.90000000000001.sql".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:468:52 [INFO] [stdout] | [INFO] [stdout] 468 | let migration_files = gather_validated_migrations(&args)?.0; [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:399:5 [INFO] [stdout] | [INFO] [stdout] 399 | if output.stderr.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!output.stderr.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:507:35 [INFO] [stdout] | [INFO] [stdout] 507 | let mut file = fs::File::open(&file_path)?; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `file_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:421:72 [INFO] [stdout] | [INFO] [stdout] 421 | let (migration_files, previous_version) = gather_validated_migrations(&args)?; [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:430:27 [INFO] [stdout] | [INFO] [stdout] 430 | let source = TempDb::new(&dbname, "migrations", &args.pg_url)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `dbname` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:432:27 [INFO] [stdout] | [INFO] [stdout] 432 | let target = TempDb::new(&dbname, "schema", &args.pg_url)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `dbname` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/main.rs:610:2 [INFO] [stdout] | [INFO] [stdout] 610 | Ok(compute_diff(&source.1, &target.1, args.exclude_privileges, &args.schema_arg)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 610 - Ok(compute_diff(&source.1, &target.1, args.exclude_privileges, &args.schema_arg)?) [INFO] [stdout] 610 + compute_diff(&source.1, &target.1, args.exclude_privileges, &args.schema_arg) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:614:34 [INFO] [stdout] | [INFO] [stdout] 614 | let diff = compute_backend_diff(&args, source, target)?; [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:468:52 [INFO] [stdout] | [INFO] [stdout] 468 | let migration_files = gather_validated_migrations(&args)?.0; [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:620:34 [INFO] [stdout] | [INFO] [stdout] 620 | let diff = compute_backend_diff(&args, source, target)?; [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:507:35 [INFO] [stdout] | [INFO] [stdout] 507 | let mut file = fs::File::open(&file_path)?; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `file_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/main.rs:610:2 [INFO] [stdout] | [INFO] [stdout] 610 | Ok(compute_diff(&source.1, &target.1, args.exclude_privileges, &args.schema_arg)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 610 - Ok(compute_diff(&source.1, &target.1, args.exclude_privileges, &args.schema_arg)?) [INFO] [stdout] 610 + compute_diff(&source.1, &target.1, args.exclude_privileges, &args.schema_arg) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:614:34 [INFO] [stdout] | [INFO] [stdout] 614 | let diff = compute_backend_diff(&args, source, target)?; [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:620:34 [INFO] [stdout] | [INFO] [stdout] 620 | let diff = compute_backend_diff(&args, source, target)?; [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:789:28 [INFO] [stdout] | [INFO] [stdout] 789 | command_generate(&args, &migration_description, is_onboard)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `migration_description` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:789:28 [INFO] [stdout] | [INFO] [stdout] 789 | command_generate(&args, &migration_description, is_onboard)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `migration_description` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 18.95s [INFO] running `Command { std: "docker" "inspect" "82424c152e4dcacbf22e5bdf2954bb32dcd5523a9c12915c506c4fa04fb50ecb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "82424c152e4dcacbf22e5bdf2954bb32dcd5523a9c12915c506c4fa04fb50ecb", kill_on_drop: false }` [INFO] [stdout] 82424c152e4dcacbf22e5bdf2954bb32dcd5523a9c12915c506c4fa04fb50ecb