[INFO] fetching crate port-selector 0.1.6... [INFO] linting port-selector-0.1.6 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate port-selector 0.1.6 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate port-selector 0.1.6 [INFO] finished tweaking crates.io crate port-selector 0.1.6 [INFO] tweaked toml for crates.io crate port-selector 0.1.6 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate port-selector 0.1.6 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 14 packages to latest compatible versions [INFO] [stderr] Adding rand v0.8.5 (available: v0.10.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dbc18cfba8ea88f6c79d9f47d76f34b2b0494b1ed5c3f7aa9a599c682954bb3d [INFO] running `Command { std: "docker" "start" "-a" "dbc18cfba8ea88f6c79d9f47d76f34b2b0494b1ed5c3f7aa9a599c682954bb3d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dbc18cfba8ea88f6c79d9f47d76f34b2b0494b1ed5c3f7aa9a599c682954bb3d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dbc18cfba8ea88f6c79d9f47d76f34b2b0494b1ed5c3f7aa9a599c682954bb3d", kill_on_drop: false }` [INFO] [stdout] dbc18cfba8ea88f6c79d9f47d76f34b2b0494b1ed5c3f7aa9a599c682954bb3d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ab67a12c0a590feb29298e3b2d66f11603800b8fe67803d839e4b4c04f0329d3 [INFO] running `Command { std: "docker" "start" "-a" "ab67a12c0a590feb29298e3b2d66f11603800b8fe67803d839e4b4c04f0329d3", kill_on_drop: false }` [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking port-selector v0.1.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/take_up.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | assert_eq!(is_free_tcp(used_tcp_port), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 117 - assert_eq!(is_free_tcp(used_tcp_port), false); [INFO] [stdout] 117 + assert!(!is_free_tcp(used_tcp_port)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/take_up.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 142 | assert_eq!(is_free(free_port.unwrap()), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 142 - assert_eq!(is_free(free_port.unwrap()), false); [INFO] [stdout] 142 + assert!(!is_free(free_port.unwrap())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:187:17 [INFO] [stdout] | [INFO] [stdout] 187 | assert!(!port.is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `port.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/lib.rs:196:21 [INFO] [stdout] | [INFO] [stdout] 196 | assert!(&port.unwrap() >= &50000 && &port.unwrap() <= &60000); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 196 - assert!(&port.unwrap() >= &50000 && &port.unwrap() <= &60000); [INFO] [stdout] 196 + assert!(port.unwrap() >= 50000 && &port.unwrap() <= &60000); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/lib.rs:196:49 [INFO] [stdout] | [INFO] [stdout] 196 | assert!(&port.unwrap() >= &50000 && &port.unwrap() <= &60000); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 196 - assert!(&port.unwrap() >= &50000 && &port.unwrap() <= &60000); [INFO] [stdout] 196 + assert!(&port.unwrap() >= &50000 && port.unwrap() <= 60000); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.70s [INFO] running `Command { std: "docker" "inspect" "ab67a12c0a590feb29298e3b2d66f11603800b8fe67803d839e4b4c04f0329d3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ab67a12c0a590feb29298e3b2d66f11603800b8fe67803d839e4b4c04f0329d3", kill_on_drop: false }` [INFO] [stdout] ab67a12c0a590feb29298e3b2d66f11603800b8fe67803d839e4b4c04f0329d3