[INFO] fetching crate poker-face 0.2.0... [INFO] linting poker-face-0.2.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate poker-face 0.2.0 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate poker-face 0.2.0 [INFO] finished tweaking crates.io crate poker-face 0.2.0 [INFO] tweaked toml for crates.io crate poker-face 0.2.0 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate poker-face 0.2.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate poker-face 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded endian-type v0.1.2 [INFO] [stderr] Downloaded strum v0.25.0 [INFO] [stderr] Downloaded winapi-util v0.1.11 [INFO] [stderr] Downloaded strum_macros v0.25.3 [INFO] [stderr] Downloaded heck v0.4.1 [INFO] [stderr] Downloaded rustyline v12.0.0 [INFO] [stderr] Downloaded once_cell_polyfill v1.70.2 [INFO] [stderr] Downloaded quote v1.0.42 [INFO] [stderr] Downloaded clipboard-win v4.5.0 [INFO] [stderr] Downloaded anstyle-query v1.1.5 [INFO] [stderr] Downloaded cfg-if v1.0.4 [INFO] [stderr] Downloaded clap_lex v0.7.6 [INFO] [stderr] Downloaded rand_chacha v0.3.1 [INFO] [stderr] Downloaded windows-link v0.2.1 [INFO] [stderr] Downloaded anstream v0.6.21 [INFO] [stderr] Downloaded is-terminal v0.4.17 [INFO] [stderr] Downloaded hermit-abi v0.5.2 [INFO] [stderr] Downloaded termcolor v1.4.1 [INFO] [stderr] Downloaded proc-macro2 v1.0.103 [INFO] [stderr] Downloaded anstyle v1.0.13 [INFO] [stderr] Downloaded anyhow v1.0.100 [INFO] [stderr] Downloaded zerocopy-derive v0.8.31 [INFO] [stderr] Downloaded rand v0.8.5 [INFO] [stderr] Downloaded memchr v2.7.6 [INFO] [stderr] Downloaded clap v4.5.53 [INFO] [stderr] Downloaded log v0.4.29 [INFO] [stderr] Downloaded clap_derive v4.5.49 [INFO] [stderr] Downloaded clap_builder v4.5.53 [INFO] [stderr] Downloaded regex v1.12.2 [INFO] [stderr] Downloaded aho-corasick v1.1.4 [INFO] [stderr] Downloaded radix_trie v0.2.1 [INFO] [stderr] Downloaded zerocopy v0.8.31 [INFO] [stderr] Downloaded unicode-width v0.1.14 [INFO] [stderr] Downloaded nix v0.26.4 [INFO] [stderr] Downloaded syn v2.0.111 [INFO] [stderr] Downloaded humantime v2.3.0 [INFO] [stderr] Downloaded env_logger v0.10.2 [INFO] [stderr] Downloaded lazy_static v1.5.0 [INFO] [stderr] Downloaded regex-syntax v0.8.8 [INFO] [stderr] Downloaded error-code v2.3.1 [INFO] [stderr] Downloaded bitflags v2.10.0 [INFO] [stderr] Downloaded nibble_vec v0.1.0 [INFO] [stderr] Downloaded unicode-ident v1.0.22 [INFO] [stderr] Downloaded anstyle-wincon v3.0.11 [INFO] [stderr] Downloaded is_terminal_polyfill v1.70.2 [INFO] [stderr] Downloaded str-buf v1.0.6 [INFO] [stderr] Downloaded errno v0.3.14 [INFO] [stderr] Downloaded fd-lock v3.0.13 [INFO] [stderr] Downloaded regex-automata v0.4.13 [INFO] [stderr] Downloaded libc v0.2.178 [INFO] [stderr] Downloaded winapi v0.3.9 [INFO] [stderr] Downloaded windows-sys v0.61.2 [INFO] [stderr] Downloaded winapi-i686-pc-windows-gnu v0.4.0 [INFO] [stderr] Downloaded winapi-x86_64-pc-windows-gnu v0.4.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 38bb810160f8791d37fcb44be75ecd0b7926976177d7e78c31c30888b65d004f [INFO] running `Command { std: "docker" "start" "-a" "38bb810160f8791d37fcb44be75ecd0b7926976177d7e78c31c30888b65d004f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "38bb810160f8791d37fcb44be75ecd0b7926976177d7e78c31c30888b65d004f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "38bb810160f8791d37fcb44be75ecd0b7926976177d7e78c31c30888b65d004f", kill_on_drop: false }` [INFO] [stdout] 38bb810160f8791d37fcb44be75ecd0b7926976177d7e78c31c30888b65d004f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ca315aba4b092ba94cd7e520353348ef6c7a75b079c3fb4d1480c1caca244be7 [INFO] running `Command { std: "docker" "start" "-a" "ca315aba4b092ba94cd7e520353348ef6c7a75b079c3fb4d1480c1caca244be7", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.178 [INFO] [stderr] Compiling proc-macro2 v1.0.103 [INFO] [stderr] Compiling unicode-ident v1.0.22 [INFO] [stderr] Compiling quote v1.0.42 [INFO] [stderr] Checking cfg-if v1.0.4 [INFO] [stderr] Compiling zerocopy v0.8.31 [INFO] [stderr] Checking memchr v2.7.6 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Compiling rustversion v1.0.22 [INFO] [stderr] Checking regex-syntax v0.8.8 [INFO] [stderr] Checking is_terminal_polyfill v1.70.2 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking anstyle v1.0.13 [INFO] [stderr] Checking colorchoice v1.0.4 [INFO] [stderr] Checking anstyle-parse v0.2.7 [INFO] [stderr] Checking anstyle-query v1.1.5 [INFO] [stderr] Compiling anyhow v1.0.100 [INFO] [stderr] Compiling thiserror v1.0.69 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking clap_lex v0.7.6 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking humantime v2.3.0 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Checking home v0.5.11 [INFO] [stderr] Checking unicode-segmentation v1.12.0 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking strum v0.25.0 [INFO] [stderr] Checking clap_builder v4.5.53 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking is-terminal v0.4.17 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking fd-lock v3.0.13 [INFO] [stderr] Checking rustyline v12.0.0 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling strum_macros v0.25.3 [INFO] [stderr] Checking clap v4.5.53 [INFO] [stderr] Checking poker-face v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/card.rs:42:1 [INFO] [stdout] | [INFO] [stdout] 42 | / impl PartialOrd for Card { [INFO] [stdout] 43 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 44 | | self.val.partial_cmp(&other.val) [INFO] [stdout] 45 | | } [INFO] [stdout] 46 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 43 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 44 - self.val.partial_cmp(&other.val) [INFO] [stdout] 45 - } [INFO] [stdout] 43 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/card.rs:138:27 [INFO] [stdout] | [INFO] [stdout] 138 | pub fn sort(&mut self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `writeln!` [INFO] [stdout] --> src/card.rs:199:9 [INFO] [stdout] | [INFO] [stdout] 199 | writeln!(f, "") [INFO] [stdout] | ^^^^^^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stdout] = note: `#[warn(clippy::writeln_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `writeln!` [INFO] [stdout] --> src/card.rs:208:17 [INFO] [stdout] | [INFO] [stdout] 208 | writeln!(f, "")?; [INFO] [stdout] | ^^^^^^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/match_evaluator.rs:82:20 [INFO] [stdout] | [INFO] [stdout] 82 | if (v1 == v2 && v2 == v3 && v3 == v4 || v2 == v3 && v3 == v4 && v4 == v5) => [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 82 - if (v1 == v2 && v2 == v3 && v3 == v4 || v2 == v3 && v3 == v4 && v4 == v5) => [INFO] [stdout] 82 + if !(v2 != v3 || v3 != v4 || v1 != v2 && v4 != v5) => [INFO] [stdout] | [INFO] [stdout] 82 - if (v1 == v2 && v2 == v3 && v3 == v4 || v2 == v3 && v3 == v4 && v4 == v5) => [INFO] [stdout] 82 + if (v4 == v5 || v1 == v2) && v3 == v4 && v2 == v3 => [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/match_evaluator.rs:87:20 [INFO] [stdout] | [INFO] [stdout] 87 | if (v1 == v2 && v2 == v3 && v4 == v5 || v3 == v4 && v4 == v5 && v1 == v2) => [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 87 - if (v1 == v2 && v2 == v3 && v4 == v5 || v3 == v4 && v4 == v5 && v1 == v2) => [INFO] [stdout] 87 + if !(v1 != v2 || v4 != v5 || v2 != v3 && v3 != v4) => [INFO] [stdout] | [INFO] [stdout] 87 - if (v1 == v2 && v2 == v3 && v4 == v5 || v3 == v4 && v4 == v5 && v1 == v2) => [INFO] [stdout] 87 + if (v3 == v4 || v2 == v3) && v4 == v5 && v1 == v2 => [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/match_evaluator.rs:107:21 [INFO] [stdout] | [INFO] [stdout] 107 | if (v1 == v2 && v2 == v3 || v2 == v3 && v3 == v4 || v3 == v4 && v4 == v5) => [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 107 - if (v1 == v2 && v2 == v3 || v2 == v3 && v3 == v4 || v3 == v4 && v4 == v5) => [INFO] [stdout] 107 + if (!(v2 != v3 || v1 != v2 && v3 != v4) || v3 == v4 && v4 == v5) => [INFO] [stdout] | [INFO] [stdout] 107 - if (v1 == v2 && v2 == v3 || v2 == v3 && v3 == v4 || v3 == v4 && v4 == v5) => [INFO] [stdout] 107 + if ((v3 == v4 || v1 == v2) && v2 == v3 || v3 == v4 && v4 == v5) => [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/match_evaluator.rs:112:21 [INFO] [stdout] | [INFO] [stdout] 112 | if (v1 == v2 && v3 == v4 || v1 == v2 && v4 == v5 || v2 == v3 && v4 == v5) => [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 112 - if (v1 == v2 && v3 == v4 || v1 == v2 && v4 == v5 || v2 == v3 && v4 == v5) => [INFO] [stdout] 112 + if (!(v1 != v2 || v3 != v4 && v4 != v5) || v2 == v3 && v4 == v5) => [INFO] [stdout] | [INFO] [stdout] 112 - if (v1 == v2 && v3 == v4 || v1 == v2 && v4 == v5 || v2 == v3 && v4 == v5) => [INFO] [stdout] 112 + if ((v4 == v5 || v3 == v4) && v1 == v2 || v2 == v3 && v4 == v5) => [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/bin/main.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | / match score1 { [INFO] [stdout] 31 | | Rank::HighCard(c) => println!("With a highcard of value {c}"), [INFO] [stdout] 32 | | _ => (), [INFO] [stdout] 33 | | } [INFO] [stdout] | |_____^ help: try: `if let Rank::HighCard(c) = score1 { println!("With a highcard of value {c}") }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/bin/main.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | / match score2 { [INFO] [stdout] 37 | | Rank::HighCard(c) => println!("With a highcard of value {c}"), [INFO] [stdout] 38 | | _ => (), [INFO] [stdout] 39 | | } [INFO] [stdout] | |_____^ help: try: `if let Rank::HighCard(c) = score2 { println!("With a highcard of value {c}") }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/bin/main.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | / match score1 { [INFO] [stdout] 31 | | Rank::HighCard(c) => println!("With a highcard of value {c}"), [INFO] [stdout] 32 | | _ => (), [INFO] [stdout] 33 | | } [INFO] [stdout] | |_____^ help: try: `if let Rank::HighCard(c) = score1 { println!("With a highcard of value {c}") }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/bin/main.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | / match score2 { [INFO] [stdout] 37 | | Rank::HighCard(c) => println!("With a highcard of value {c}"), [INFO] [stdout] 38 | | _ => (), [INFO] [stdout] 39 | | } [INFO] [stdout] | |_____^ help: try: `if let Rank::HighCard(c) = score2 { println!("With a highcard of value {c}") }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/card.rs:42:1 [INFO] [stdout] | [INFO] [stdout] 42 | / impl PartialOrd for Card { [INFO] [stdout] 43 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 44 | | self.val.partial_cmp(&other.val) [INFO] [stdout] 45 | | } [INFO] [stdout] 46 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 43 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 44 - self.val.partial_cmp(&other.val) [INFO] [stdout] 45 - } [INFO] [stdout] 43 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/card.rs:138:27 [INFO] [stdout] | [INFO] [stdout] 138 | pub fn sort(&mut self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `writeln!` [INFO] [stdout] --> src/card.rs:199:9 [INFO] [stdout] | [INFO] [stdout] 199 | writeln!(f, "") [INFO] [stdout] | ^^^^^^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stdout] = note: `#[warn(clippy::writeln_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `writeln!` [INFO] [stdout] --> src/card.rs:208:17 [INFO] [stdout] | [INFO] [stdout] 208 | writeln!(f, "")?; [INFO] [stdout] | ^^^^^^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/match_evaluator.rs:82:20 [INFO] [stdout] | [INFO] [stdout] 82 | if (v1 == v2 && v2 == v3 && v3 == v4 || v2 == v3 && v3 == v4 && v4 == v5) => [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 82 - if (v1 == v2 && v2 == v3 && v3 == v4 || v2 == v3 && v3 == v4 && v4 == v5) => [INFO] [stdout] 82 + if !(v2 != v3 || v3 != v4 || v1 != v2 && v4 != v5) => [INFO] [stdout] | [INFO] [stdout] 82 - if (v1 == v2 && v2 == v3 && v3 == v4 || v2 == v3 && v3 == v4 && v4 == v5) => [INFO] [stdout] 82 + if (v4 == v5 || v1 == v2) && v3 == v4 && v2 == v3 => [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/match_evaluator.rs:87:20 [INFO] [stdout] | [INFO] [stdout] 87 | if (v1 == v2 && v2 == v3 && v4 == v5 || v3 == v4 && v4 == v5 && v1 == v2) => [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 87 - if (v1 == v2 && v2 == v3 && v4 == v5 || v3 == v4 && v4 == v5 && v1 == v2) => [INFO] [stdout] 87 + if !(v1 != v2 || v4 != v5 || v2 != v3 && v3 != v4) => [INFO] [stdout] | [INFO] [stdout] 87 - if (v1 == v2 && v2 == v3 && v4 == v5 || v3 == v4 && v4 == v5 && v1 == v2) => [INFO] [stdout] 87 + if (v3 == v4 || v2 == v3) && v4 == v5 && v1 == v2 => [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/match_evaluator.rs:107:21 [INFO] [stdout] | [INFO] [stdout] 107 | if (v1 == v2 && v2 == v3 || v2 == v3 && v3 == v4 || v3 == v4 && v4 == v5) => [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 107 - if (v1 == v2 && v2 == v3 || v2 == v3 && v3 == v4 || v3 == v4 && v4 == v5) => [INFO] [stdout] 107 + if (!(v2 != v3 || v1 != v2 && v3 != v4) || v3 == v4 && v4 == v5) => [INFO] [stdout] | [INFO] [stdout] 107 - if (v1 == v2 && v2 == v3 || v2 == v3 && v3 == v4 || v3 == v4 && v4 == v5) => [INFO] [stdout] 107 + if ((v3 == v4 || v1 == v2) && v2 == v3 || v3 == v4 && v4 == v5) => [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/match_evaluator.rs:112:21 [INFO] [stdout] | [INFO] [stdout] 112 | if (v1 == v2 && v3 == v4 || v1 == v2 && v4 == v5 || v2 == v3 && v4 == v5) => [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 112 - if (v1 == v2 && v3 == v4 || v1 == v2 && v4 == v5 || v2 == v3 && v4 == v5) => [INFO] [stdout] 112 + if (!(v1 != v2 || v3 != v4 && v4 != v5) || v2 == v3 && v4 == v5) => [INFO] [stdout] | [INFO] [stdout] 112 - if (v1 == v2 && v3 == v4 || v1 == v2 && v4 == v5 || v2 == v3 && v4 == v5) => [INFO] [stdout] 112 + if ((v4 == v5 || v3 == v4) && v1 == v2 || v2 == v3 && v4 == v5) => [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/match_evaluator.rs:297:9 [INFO] [stdout] | [INFO] [stdout] 297 | assert_eq!(MatchHandEvaluator::seq(14, 13, 12, 11, 10), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 297 - assert_eq!(MatchHandEvaluator::seq(14, 13, 12, 11, 10), true); [INFO] [stdout] 297 + assert!(MatchHandEvaluator::seq(14, 13, 12, 11, 10)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/match_evaluator.rs:298:9 [INFO] [stdout] | [INFO] [stdout] 298 | assert_eq!(MatchHandEvaluator::seq(13, 14, 12, 11, 5), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 298 - assert_eq!(MatchHandEvaluator::seq(13, 14, 12, 11, 5), false); [INFO] [stdout] 298 + assert!(!MatchHandEvaluator::seq(13, 14, 12, 11, 5)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/match_evaluator.rs:299:9 [INFO] [stdout] | [INFO] [stdout] 299 | assert_eq!(MatchHandEvaluator::seq(9, 8, 7, 6, 5), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 299 - assert_eq!(MatchHandEvaluator::seq(9, 8, 7, 6, 5), true); [INFO] [stdout] 299 + assert!(MatchHandEvaluator::seq(9, 8, 7, 6, 5)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/match_evaluator.rs:300:9 [INFO] [stdout] | [INFO] [stdout] 300 | assert_eq!(MatchHandEvaluator::seq(5, 4, 3, 2, 1), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 300 - assert_eq!(MatchHandEvaluator::seq(5, 4, 3, 2, 1), true); [INFO] [stdout] 300 + assert!(MatchHandEvaluator::seq(5, 4, 3, 2, 1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/match_evaluator.rs:301:9 [INFO] [stdout] | [INFO] [stdout] 301 | assert_eq!(MatchHandEvaluator::seq(10, 9, 8, 7, 5), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 301 - assert_eq!(MatchHandEvaluator::seq(10, 9, 8, 7, 5), false); [INFO] [stdout] 301 + assert!(!MatchHandEvaluator::seq(10, 9, 8, 7, 5)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/match_evaluator.rs:308:9 [INFO] [stdout] | [INFO] [stdout] 308 | assert_eq!(MatchHandEvaluator::suits(&Suit::Hearts, &Suit::Hearts, &Suit::Hearts, &Suit::Hearts, &Suit::Hearts), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 308 - assert_eq!(MatchHandEvaluator::suits(&Suit::Hearts, &Suit::Hearts, &Suit::Hearts, &Suit::Hearts, &Suit::Hearts), true); [INFO] [stdout] 308 + assert!(MatchHandEvaluator::suits(&Suit::Hearts, &Suit::Hearts, &Suit::Hearts, &Suit::Hearts, &Suit::Hearts)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/match_evaluator.rs:309:9 [INFO] [stdout] | [INFO] [stdout] 309 | assert_eq!(MatchHandEvaluator::suits(&Suit::Spades, &Suit::Spades, &Suit::Spades, &Suit::Spades, &Suit::Spades), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 309 - assert_eq!(MatchHandEvaluator::suits(&Suit::Spades, &Suit::Spades, &Suit::Spades, &Suit::Spades, &Suit::Spades), true); [INFO] [stdout] 309 + assert!(MatchHandEvaluator::suits(&Suit::Spades, &Suit::Spades, &Suit::Spades, &Suit::Spades, &Suit::Spades)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/match_evaluator.rs:310:9 [INFO] [stdout] | [INFO] [stdout] 310 | ... assert_eq!(MatchHandEvaluator::suits(&Suit::Diamonds, &Suit::Diamonds, &Suit::Diamonds, &Suit::Diamonds, &Suit::Diamonds), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 310 - assert_eq!(MatchHandEvaluator::suits(&Suit::Diamonds, &Suit::Diamonds, &Suit::Diamonds, &Suit::Diamonds, &Suit::Diamonds), true); [INFO] [stdout] 310 + assert!(MatchHandEvaluator::suits(&Suit::Diamonds, &Suit::Diamonds, &Suit::Diamonds, &Suit::Diamonds, &Suit::Diamonds)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/match_evaluator.rs:311:9 [INFO] [stdout] | [INFO] [stdout] 311 | assert_eq!(MatchHandEvaluator::suits(&Suit::Clubs, &Suit::Clubs, &Suit::Clubs, &Suit::Clubs, &Suit::Clubs), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 311 - assert_eq!(MatchHandEvaluator::suits(&Suit::Clubs, &Suit::Clubs, &Suit::Clubs, &Suit::Clubs, &Suit::Clubs), true); [INFO] [stdout] 311 + assert!(MatchHandEvaluator::suits(&Suit::Clubs, &Suit::Clubs, &Suit::Clubs, &Suit::Clubs, &Suit::Clubs)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/match_evaluator.rs:314:9 [INFO] [stdout] | [INFO] [stdout] 314 | assert_eq!(MatchHandEvaluator::suits(&Suit::Hearts, &Suit::Diamonds, &Suit::Hearts, &Suit::Hearts, &Suit::Hearts), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 314 - assert_eq!(MatchHandEvaluator::suits(&Suit::Hearts, &Suit::Diamonds, &Suit::Hearts, &Suit::Hearts, &Suit::Hearts), false); [INFO] [stdout] 314 + assert!(!MatchHandEvaluator::suits(&Suit::Hearts, &Suit::Diamonds, &Suit::Hearts, &Suit::Hearts, &Suit::Hearts)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/match_evaluator.rs:315:9 [INFO] [stdout] | [INFO] [stdout] 315 | assert_eq!(MatchHandEvaluator::suits(&Suit::Spades, &Suit::Spades, &Suit::Spades, &Suit::Spades, &Suit::Clubs), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 315 - assert_eq!(MatchHandEvaluator::suits(&Suit::Spades, &Suit::Spades, &Suit::Spades, &Suit::Spades, &Suit::Clubs), false); [INFO] [stdout] 315 + assert!(!MatchHandEvaluator::suits(&Suit::Spades, &Suit::Spades, &Suit::Spades, &Suit::Spades, &Suit::Clubs)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/match_evaluator.rs:316:9 [INFO] [stdout] | [INFO] [stdout] 316 | assert_eq!(MatchHandEvaluator::suits(&Suit::Hearts, &Suit::Clubs, &Suit::Diamonds, &Suit::Spades, &Suit::Hearts), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 316 - assert_eq!(MatchHandEvaluator::suits(&Suit::Hearts, &Suit::Clubs, &Suit::Diamonds, &Suit::Spades, &Suit::Hearts), false); [INFO] [stdout] 316 + assert!(!MatchHandEvaluator::suits(&Suit::Hearts, &Suit::Clubs, &Suit::Diamonds, &Suit::Spades, &Suit::Hearts)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 13.13s [INFO] running `Command { std: "docker" "inspect" "ca315aba4b092ba94cd7e520353348ef6c7a75b079c3fb4d1480c1caca244be7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ca315aba4b092ba94cd7e520353348ef6c7a75b079c3fb4d1480c1caca244be7", kill_on_drop: false }` [INFO] [stdout] ca315aba4b092ba94cd7e520353348ef6c7a75b079c3fb4d1480c1caca244be7